ledger_sync 1.4.2 → 1.4.4

data/lib/ledger_sync/ledgers/quickbooks_online/transfer/operations/find.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/util/error_matcher.rb

@@ -24,15 +24,18 @@ module LedgerSync
           end
 
           def error_message
-            (body && JSON.parse(body).dig('fault', 'error')&.first&.fetch('message')) ||
-            (body && JSON.parse(body).dig('Fault', 'Error')&.first&.fetch('Message')) ||
-              (body && JSON.parse(body).dig('error')) ||
-              error.message
+            return error.message unless body
+
+            parsed_body = JSON.parse(body)
+
+            parsed_body.dig('fault', 'error')&.first&.fetch('message') ||
+              parsed_body.dig('Fault', 'Error')&.first&.fetch('Message') ||
+              parsed_body.dig('error')
           end
 
           def detail
             (body && JSON.parse(body).dig('fault', 'error')&.first&.fetch('detail')) ||
-            (body && JSON.parse(body).dig('Fault', 'Error')&.first&.fetch('Detail'))
+              (body && JSON.parse(body).dig('Fault', 'Error')&.first&.fetch('Detail'))
           end
 
           def code

data/lib/ledger_sync/ledgers/quickbooks_online/util/ledger_error_parser.rb

@@ -13,7 +13,7 @@ module LedgerSync
             end
 
             def output_message
-              "Request trhottled with: #{error_message}"
+              "Request throttle with: #{error_message}"
             end
 
             def match?
@@ -33,7 +33,7 @@ module LedgerSync
 
             def match?
               code == 3200 ||
-              message.include?('authenticationfailed') ||
+                message.include?('authenticationfailed') ||
                 message.include?('errorcode=003200')
             end
           end
@@ -49,7 +49,7 @@ module LedgerSync
 
             def match?
               code == 3100 ||
-              message.include?('authorizationfailed') ||
+                message.include?('authorizationfailed') ||
                 message.include?('errorcode=003100')
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/util/operation_error_parser.rb

@@ -18,7 +18,7 @@ module LedgerSync
 
             def match?
               code == 6240 ||
-              message.include?('the name supplied already exists')
+                message.include?('the name supplied already exists')
             end
           end
 
@@ -33,7 +33,7 @@ module LedgerSync
 
             def match?
               code == 610 ||
-              message.include?('object not found')
+                message.include?('object not found')
             end
           end
 

data/lib/ledger_sync/ledgers/quickbooks_online/webhook_event.rb

@@ -65,7 +65,9 @@ module LedgerSync
         end
 
         def resource!
-          raise "Resource class does not exist for QuickBooks Online object: #{quickbooks_online_resource_type}" if resource.nil?
+          if resource.nil?
+            raise "Resource class does not exist for QuickBooks Online object: #{quickbooks_online_resource_type}"
+          end
 
           resource
         end

data/lib/ledger_sync/ledgers/quickbooks_online/webhook_notification.rb

@@ -13,9 +13,10 @@ module LedgerSync
                     :realm_id,
                     :webhook
 
-        def initialize(payload:, webhook: nil)
-          @original_payload = payload
-          @payload = payload.is_a?(String) ? JSON.parse(payload) : payload
+        def initialize(args = {})
+          @original_payload = args.fetch(:payload)
+          @webhook          = args.fetch(:webhook, nil)
+          @payload          = original_payload.is_a?(String) ? JSON.parse(original_payload) : original_payload
 
           @realm_id = @payload.dig('realmId')
           raise 'Invalid payload: Could not find realmId' if @realm_id.blank?

data/lib/ledger_sync/ledgers/response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LedgerSync
   module Ledgers
     class Response
@@ -52,4 +54,4 @@ module LedgerSync
       end
     end
   end
-end
+end

data/lib/ledger_sync/ledgers/stripe/client.rb

@@ -17,7 +17,7 @@ module LedgerSync
         def url_for(resource:)
           DashboardURLHelper.new(
             resource: resource,
-            base_url: "https://dashboard.stripe.com"
+            base_url: 'https://dashboard.stripe.com'
           ).url
         end
 

data/lib/ledger_sync/ledgers/stripe/dashboard_url_helper.rb

@@ -13,7 +13,7 @@ module LedgerSync
                                client: self,
                                resource: resource
                              )
-          end
+                           end
         end
       end
     end

data/lib/ledger_sync/ledgers/stripe/operation/create.rb

@@ -8,8 +8,6 @@ module LedgerSync
       class Operation
         class Create
           include Stripe::Operation::Mixin
-
-          private
         end
       end
     end

data/lib/ledger_sync/ledgers/stripe/operation/delete.rb

@@ -8,8 +8,6 @@ module LedgerSync
       class Operation
         class Delete
           include Stripe::Operation::Mixin
-
-          private
         end
       end
     end

data/lib/ledger_sync/ledgers/stripe/operation/update.rb

@@ -8,8 +8,6 @@ module LedgerSync
       class Operation
         class Update
           include Stripe::Operation::Mixin
-
-          private
         end
       end
     end

data/lib/ledger_sync/resource.rb

@@ -48,7 +48,9 @@ module LedgerSync
     end
 
     def changes
-      super.merge(Hash[resource_attributes.references_many.map { |ref| [ref.name, ref.changes['value']] if ref.changed? }.compact])
+      super.merge(Hash[resource_attributes.references_many.map do |ref|
+                         [ref.name, ref.changes['value']] if ref.changed?
+                       end.compact])
     end
 
     def class_from_resource_type(obj)

data/lib/ledger_sync/resource_attribute/dirty_mixin.rb

@@ -36,7 +36,7 @@ module LedgerSync
       # Change the dirty change set of {"name" => ["Bill", "Bob"]}
       # to current values of attributes that have changed: {"name" => "Bob"}
       def changes_to_h
-        Hash[changes.map { |k, v| [k, v.last] }]
+        changes.transform_values(&:last)
       end
 
       def dirty_attributes_to_h

data/lib/ledger_sync/resource_attribute/mixin.rb

@@ -55,7 +55,7 @@ module LedgerSync
 
       def initialize(**data)
         # Initialize empty values
-        resource_attributes.keys.each { |e| instance_variable_set("@#{e}", nil) }
+        resource_attributes.each_key { |e| instance_variable_set("@#{e}", nil) }
 
         assign_attributes(data)
 
@@ -85,8 +85,8 @@ module LedgerSync
       end
 
       def serialize_attributes
-        Hash[resource_attributes.map { |k, v| [k, v.value] }]
+        resource_attributes.transform_values(&:value)
       end
     end
   end
-end
+end

data/lib/ledger_sync/resource_attribute_set.rb

@@ -47,7 +47,7 @@ module LedgerSync
     end
 
     def to_h
-      Hash[attributes.map { |k, v| [k, v.value] }]
+      attributes.transform_values(&:value)
     end
   end
 end

data/lib/ledger_sync/result.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 module LedgerSync
   module ResultBase
     module HelperMethods
-      def Success(value = nil, *args)
+      def Success(value = nil, *args) # rubocop:disable Naming/MethodName
         self::Success.new(value, *args)
       end
 
-      def Failure(error = nil, *args)
+      def Failure(error = nil, *args) # rubocop:disable Naming/MethodName
         self::Failure.new(error, *args)
       end
     end
@@ -52,22 +54,15 @@ module LedgerSync
 
       def self.included(base)
         base.class_eval do
-          serialize only: %i[
-            next_searcher
-            previous_searcher
+          # TODO: removed next and previous searcher, because it causes a string of them.
+          # We should add next_searcher_params which would be easier to serialize.
+          simply_serialize only: %i[
             resources
             searcher
           ]
         end
       end
 
-      def self.included(base)
-        base.class_eval do
-          # TODO: removed next and previous searcher, because it causes a string of them.  We should add next_searcher_params which would be easier to serialize.
-          simply_serialize only: %i[resources searcher]
-        end
-      end
-
       def initialize(*args, searcher:, **keywords)
         @resources = searcher.resources
         @searcher = searcher

data/lib/ledger_sync/serialization/deserializer_attribute.rb

@@ -59,7 +59,9 @@ module LedgerSync
           resource.public_send(
             "#{first_attribute}=",
             build_resource_value_from_nested_attributes(
-              resource.public_send(first_attribute) || resource.class.resource_attributes[first_attribute.to_sym].type.resource_class.new,
+              resource.public_send(
+                first_attribute
+              ) || resource.class.resource_attributes[first_attribute.to_sym].type.resource_class.new,
               value,
               remaining_attributes
             )
@@ -71,7 +73,9 @@ module LedgerSync
 
       def resource_attribute_class(resource:)
         @resource_attribute_type ||= {}
-        @resource_attribute_type[resource] ||= resource.class.resource_attributes[resource_attribute_dot_parts.first.to_sym].type.resource_class
+        @resource_attribute_type[resource] ||= resource.class.resource_attributes[
+          resource_attribute_dot_parts.first.to_sym
+        ].type.resource_class
       end
     end
   end

data/lib/ledger_sync/serializer.rb

@@ -40,7 +40,9 @@ module LedgerSync
     end
 
     def self.attribute(hash_attribute, args = {}, &block)
-      raise 'You cannot provide hash_attribute in args.  Pass the value as the first argument.' if args.key?(:hash_attribute)
+      if args.key?(:hash_attribute)
+        raise 'You cannot provide hash_attribute in args.  Pass the value as the first argument.'
+      end
 
       _attribute(
         args.merge(

data/lib/ledger_sync/type/reference_one.rb

@@ -23,7 +23,7 @@ module LedgerSync
                                 resource_class
                               else
                                 [resource_class]
-        end
+                              end
       end
 
       private

data/lib/ledger_sync/util/hash_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 # Inspired by
 # https://github.com/rails/rails/blob/v6.0.0/activesupport/lib/active_support/core_ext/hash/keys.rb#L116
@@ -20,7 +22,11 @@ module LedgerSync
       end
 
       def deep_symbolize_keys(hash)
-        deep_transform_keys_in_object(hash) { |key| key.to_sym rescue key }
+        deep_transform_keys_in_object(hash) do |key|
+          key.to_sym
+        rescue StandardError
+          key
+        end
       end
 
       def deep_transform_keys_in_object(object, &block)
@@ -37,7 +43,11 @@ module LedgerSync
       end
 
       def deep_stringify_keys(hash)
-        deep_transform_keys_in_object(hash) { |key| key.to_s rescue key }
+        deep_transform_keys_in_object(hash) do |key|
+          key.to_s
+        rescue StandardError
+          key
+        end
       end
     end
   end

data/lib/ledger_sync/util/mixins/delegate_iterable_methods_mixin.rb

@@ -18,6 +18,7 @@ module LedgerSync
           ARRAY_METHODS = (SHARED_METHODS | %i[]).freeze
 
           HASH_METHODS = (SHARED_METHODS | %i[
+            each_key
             each_value
             fetch
             key?

data/lib/ledger_sync/util/read_only_object.rb

@@ -8,7 +8,7 @@ module LedgerSync
       def initialize(args = {})
         @raw = args.with_indifferent_access
 
-        self.class.attributes.except { |k, _| e.to_sym == :raw }.each do |name, attr_settings|
+        self.class.attributes.except { |_k, _| e.to_sym == :raw }.each do |name, attr_settings|
           if attr_settings.key?(:default)
             instance_variable_set(
               "@#{name}",

data/lib/ledger_sync/util/resource_converter.rb

@@ -14,20 +14,13 @@ module LedgerSync
         source       = args.fetch(:source).dup
         source       = Util::HashHelpers.deep_stringify_keys(source) if source.is_a?(Hash)
 
-        if source.is_a?(Hash) && args.key?(:only_changes)
-          raise 'only_changes can only be passed when the source is a resource'
-        end
-
-        self.class.attributes.each do |converter_attribute|
-          next if only_changes && !source.attribute_changed?(converter_attribute.source_attribute)
-
+        convertable_attributes(only_changes: only_changes, source: source).each do |converter_attribute|
           args_to_pass = {
             destination: destination,
             source: source
           }
           next if converter_attribute.if_method.present? && !send(converter_attribute.if_method, args_to_pass)
 
-
           # This is for in place changes
           destination = converter_attribute.build_destination!(args_to_pass)
         end
@@ -35,6 +28,17 @@ module LedgerSync
         destination
       end
 
+      def convertable_attributes(args = {})
+        converter_attributes = self.class.attributes
+        source               = args.fetch(:source)
+
+        return converter_attributes unless args[:only_changes] == true
+
+        raise 'only_changes can only be passed when the source is a resource' if source.is_a?(Hash)
+
+        converter_attributes.select { |e| source.attribute_changed?(e.source_attribute) }
+      end
+
       def self._attribute(destination_attribute = nil, args = {}, &block)
         if args.key?(:destination_attribute)
           raise 'You cannot provide destination_attribute in args.  Pass the value as the first argument.'

data/lib/ledger_sync/util/resource_converter/attribute.rb

@@ -79,7 +79,9 @@ module LedgerSync
 
         def destination_attribute_class(destination:)
           @destination_attribute_type ||= {}
-          @destination_attribute_type[destination] ||= destination.class.destination_attributes[destination_attribute_dot_parts.first.to_sym].type.resource_class
+          @destination_attribute_type[destination] ||= destination.class.destination_attributes[
+            destination_attribute_dot_parts.first.to_sym
+          ].type.resource_class
         end
 
         def destination_attribute_dot_parts

data/lib/ledger_sync/util/resource_converter/attribute_set.rb

@@ -22,7 +22,8 @@ module LedgerSync
         def add(attribute)
           unless attribute.destination_attribute.nil?
             if @attribute_keys.key?(attribute.destination_attribute.to_s)
-              raise "destination_attribute already defined for #{resource_converter_class.name}: #{attribute.destination_attribute}"
+              raise "destination_attribute already defined for #{resource_converter_class.name}: "\
+                    "#{attribute.destination_attribute}"
             end
 
             @attribute_keys[attribute.destination_attribute] = attribute

data/lib/ledger_sync/util/resources_builder.rb

@@ -36,12 +36,12 @@ module LedgerSync
 
       private
 
-      def build_resource(external_id:, type:)
-        external_id = external_id.to_sym
-        type = type.to_sym
-
-        ledger_id = @data.dig(type, external_id, :ledger_id)
+      def build_resource(args = {}) # rubocop:disable Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
+        external_id  = args.fetch(:external_id).to_sym
+        type         = args.fetch(:type).to_sym
+        ledger_id    = @data.dig(type, external_id, :ledger_id)
         current_data = @data.dig(type, external_id, :data)
+
         raise "No data provided for #{type} (ID: #{external_id})" if current_data.nil?
 
         resource_class = if ledger == :root

data/lib/ledger_sync/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LedgerSync
-  VERSION = '1.4.2'.freeze
+  VERSION = '1.4.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ledger_sync
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.4
 platform: ruby
 authors:
 - Ryan Jackson
@@ -136,6 +136,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.9'
+- !ruby/object:Gem::Dependency
+  name: overcommit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -457,6 +471,7 @@ files:
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".gitignore"
+- ".overcommit.yml"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - ".travis.yml"
@@ -611,13 +626,6 @@ files:
 - documentation/site/images/logo.svg
 - documentation/site/index.md
 - documentation/site/overview.md
-- documentation/site/reference/architecture/clients.md
-- documentation/site/reference/architecture/index.md
-- documentation/site/reference/architecture/operations.md
-- documentation/site/reference/architecture/resources.md
-- documentation/site/reference/architecture/results.md
-- documentation/site/reference/architecture/searchers.md
-- documentation/site/reference/architecture/serialization.md
 - documentation/site/reference/index.md
 - documentation/site/reference/netsuite/authentication/_token_based_authentication.md
 - documentation/site/reference/netsuite/authentication/index.md
@@ -1085,8 +1093,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Sync common objects to accounting software.