ledger_sync 1.4.2 → 1.4.4

data/documentation/site/reference/quickbooks_online/resources/deposit.md

@@ -41,3 +41,9 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+| Name |
+| ---- |
+| `LedgerSync::Ledgers::QuickBooksOnline::Deposit::Searcher` |

data/documentation/site/reference/quickbooks_online/resources/deposit_line_item.md

@@ -21,3 +21,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/expense.md

@@ -44,3 +44,9 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+| Name |
+| ---- |
+| `LedgerSync::Ledgers::QuickBooksOnline::Expense::Searcher` |

data/documentation/site/reference/quickbooks_online/resources/expense_line_item.md

@@ -20,3 +20,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/invoice.md

@@ -41,3 +41,7 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/invoice_sales_line_item.md

@@ -20,3 +20,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/item.md

@@ -17,3 +17,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/journal_entry.md

@@ -39,3 +39,9 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+| Name |
+| ---- |
+| `LedgerSync::Ledgers::QuickBooksOnline::JournalEntry::Searcher` |

data/documentation/site/reference/quickbooks_online/resources/journal_entry_line_item.md

@@ -22,3 +22,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/ledger_class.md

@@ -39,3 +39,9 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+| Name |
+| ---- |
+| `LedgerSync::Ledgers::QuickBooksOnline::LedgerClass::Searcher` |

data/documentation/site/reference/quickbooks_online/resources/payment.md

@@ -44,3 +44,7 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/payment_line_item.md

@@ -18,3 +18,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/preferences.md

@@ -32,3 +32,7 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/primary_email_addr.md

@@ -17,3 +17,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/primary_phone.md

@@ -17,3 +17,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/resource.md

@@ -16,3 +16,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/subsidiary.md

@@ -18,3 +18,7 @@ layout: reference_quickbooks_online
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/transfer.md

@@ -40,3 +40,7 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/quickbooks_online/resources/vendor.md

@@ -41,3 +41,9 @@ layout: reference_quickbooks_online
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+| Name |
+| ---- |
+| `LedgerSync::Ledgers::QuickBooksOnline::Vendor::Searcher` |

data/documentation/site/reference/stripe/resources/customer.md

@@ -43,3 +43,7 @@ layout: reference_stripe
 
 | Name | Type |
 | ---- | ---- |
+
+## Searchers
+
+There are no searchers for this resource.

data/documentation/site/reference/stripe/resources/resource.md

@@ -16,3 +16,7 @@ layout: reference_stripe
 
 ## Operations
 
+
+## Searchers
+
+There are no searchers for this resource.

data/ledger_sync.gemspec

@@ -11,7 +11,8 @@ Gem::Specification.new do |spec|
   # spec.required_rubygems_version = Gem::Requirement.new('>= 0') if spec.respond_to? :required_rubygems_version=
   spec.authors = ['Ryan Jackson']
   spec.date = '2019-05-21'
-  spec.description = 'LedgerSync is a simple library that allows you to sync common objects to popular accounting software like QuickBooks Online, Xero, NetSuite, etc.'
+  spec.description = 'LedgerSync is a simple library that allows you to sync common objects to popular accounting '\
+                     'software like QuickBooks Online, Xero, NetSuite, etc.'
   spec.email = ['ryanwjackson@gmail.com']
   spec.homepage = 'https://github.com/LedgerSync/ledger_sync'
   spec.licenses = ['MIT']
@@ -36,6 +37,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency('jekyll-menus', '~> 0.6.0')
   spec.add_development_dependency('jekyll-paginate', '~> 1.1')
   spec.add_development_dependency('jekyll-paginate-v2', '~> 1.9')
+  spec.add_development_dependency('overcommit')
   spec.add_development_dependency('rake', '~> 13.0')
   spec.add_development_dependency('rspec', '~> 3.2')
   spec.add_development_dependency('rubocop', '>= 0')

data/lib/ledger_sync.rb

@@ -90,7 +90,9 @@ module LedgerSync
   end
 
   def self.log_level=(val)
-    raise ArgumentError, 'log_level should only be set to `nil`, `debug` or `info`' if !val.nil? && ![LEVEL_DEBUG, LEVEL_ERROR, LEVEL_INFO].include?(val)
+    if !val.nil? && ![LEVEL_DEBUG, LEVEL_ERROR, LEVEL_INFO].include?(val)
+      raise ArgumentError, 'log_level should only be set to `nil`, `debug` or `info`'
+    end
 
     @log_level = val
   end

data/lib/ledger_sync/concerns/validatable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LedgerSync
   module Validatable
     def valid?

data/lib/ledger_sync/error/operation_errors.rb

@@ -31,7 +31,7 @@ module LedgerSync
         attr_reader :attribute,
                     :validation
 
-        def initialize(message:, attribute:, operation:, validation:, response:nil)
+        def initialize(message:, attribute:, operation:, validation:, response: nil)
           @attribute = attribute
           @validation = validation
 

data/lib/ledger_sync/error/resource_errors.rb

@@ -22,7 +22,8 @@ module LedgerSync
                when LedgerSync::ResourceAttribute::Reference::Many
                  invalid_classes = value.reject { |e| e.is_a?(type_resource_class) }.map(&:class)
                  if type_resource_class.is_a?(Array)
-                   "an array of one or more of the following: #{type_resource_class.name}.  Given array containing: #{invalid_classes.join(', ')}"
+                   "an array of one or more of the following: #{type_resource_class.name}.  Given array containing: "\
+                   "#{invalid_classes.join(', ')}"
                  else
                    "an array of #{type_resource_class.name}.  Given array containing: #{invalid_classes.join(', ')}"
                  end
@@ -43,7 +44,7 @@ module LedgerSync
                                  else
                                    attribute.type.valid_classes
                                  end
-    end
+      end
     end
   end
 

data/lib/ledger_sync/ledger_configuration_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module LedgerSync
   class LedgerConfigurationStore
     include Enumerable
@@ -13,7 +15,9 @@ module LedgerSync
 
     def add_alias(client_key, existing_config)
       if respond_to?(client_key)
-        raise LedgerSync::ConfigurationError, "Alias already taken: #{client_key}" if send(client_key) != existing_config
+        if send(client_key) != existing_config
+          raise LedgerSync::ConfigurationError, "Alias already taken: #{client_key}"
+        end
 
         return
       end

data/lib/ledger_sync/ledgers/client.rb

@@ -45,12 +45,12 @@ module LedgerSync
         )
       end
 
-      def searcher_for(resource_type:, query: '')
-        searcher_class_for(resource_type: resource_type).new(client: self, query: query)
+      def searcher_for(*args)
+        self.class.searcher_for(*args)
       end
 
-      def searcher_class_for(resource_type:)
-        base_module.const_get(LedgerSync::Util::StringHelpers.camelcase(resource_type.to_s))::Searcher
+      def searcher_class_for(*args)
+        self.class.searcher_class_for(*args)
       end
 
       def url_for(*_args)
@@ -106,6 +106,14 @@ module LedgerSync
         @root_key ||= config.root_key
       end
 
+      def self.searcher_for(resource_type:, query: '')
+        searcher_class_for(resource_type: resource_type).new(client: self, query: query)
+      end
+
+      def self.searcher_class_for(resource_type:)
+        base_module.const_get(LedgerSync::Util::StringHelpers.camelcase(resource_type.to_s))::Searcher
+      end
+
       def self.url_for(resource: nil); end
     end
   end

data/lib/ledger_sync/ledgers/mixins/infer_serializer_mixin.rb

@@ -25,7 +25,9 @@ module LedgerSync
           end
 
           def inferred_searcher_deserializer_class_name
-            @inferred_searcher_deserializer_class_name ||= "#{inferred_resource_class.resource_module_str}::SearcherDeserializer"
+            @inferred_searcher_deserializer_class_name ||= begin
+              "#{inferred_resource_class.resource_module_str}::SearcherDeserializer"
+            end
           end
 
           def inferred_serializer_class

data/lib/ledger_sync/ledgers/netsuite/account/operations/find.rb

@@ -3,7 +3,7 @@
 module LedgerSync
   module Ledgers
     module NetSuite
-    class Account
+      class Account
         module Operations
           class Find < NetSuite::Operation::Find
             class Contract < LedgerSync::Ledgers::Contract

data/lib/ledger_sync/ledgers/netsuite/client.rb

@@ -37,7 +37,7 @@ module LedgerSync
         end
 
         def account_id_for_oauth
-          account_id.gsub(/\-/, '_').upcase
+          account_id.gsub(/-/, '_').upcase
         end
 
         def account_id_for_url
@@ -64,7 +64,7 @@ module LedgerSync
           resource = args.fetch(:resource, nil)
           params   = args.fetch(:params, {})
 
-          ret = self.class.ledger_resource_type_for(resource_class: resource.class) # This can be turned into a case statement if we need to override
+          ret = self.class.ledger_resource_type_for(resource_class: resource.class)
           ret += "/#{resource.ledger_id}" if resource.ledger_id.present? && args.fetch(:id, true)
           Util::URLHelpers.merge_params_in_path(
             path: ret,

data/lib/ledger_sync/ledgers/netsuite/dashboard_url_helper.rb

@@ -4,7 +4,7 @@ module LedgerSync
   module Ledgers
     module NetSuite
       class DashboardURLHelper < LedgerSync::Ledgers::DashboardURLHelper
-        def resource_path
+        def resource_path # rubocop:disable Metrics/CyclomaticComplexity
           @resource_path = case resource
                            when NetSuite::Account
                              "/app/accounting/account/account.nl?id=#{resource.ledger_id}"

data/lib/ledger_sync/ledgers/netsuite/error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module LedgerSync
   module Ledgers
     module NetSuite

data/lib/ledger_sync/ledgers/netsuite/journal_entry_line_item/deserializer.rb

@@ -1,6 +1,3 @@
-
-
-
 # frozen_string_literal: true
 
 require_relative '../account/deserializer'

data/lib/ledger_sync/ledgers/netsuite/resources/account.rb

@@ -6,8 +6,7 @@ module LedgerSync
   module Ledgers
     module NetSuite
       class Account < NetSuite::Resource
-
-         TYPES = {
+        TYPES = {
           'bank' => 'Bank',
           'other_current_assets' => 'OthCurrAsset',
           'fixed_asset' => 'FixedAsset',

data/lib/ledger_sync/ledgers/netsuite/searcher.rb

@@ -42,7 +42,9 @@ module LedgerSync
             when 404
               []
             when 400
-              if request.body["title"].include? "Invalid search query Search error occurred: Record ‘subsidiary’ was not found"
+              if request.body['title'].include?(
+                'Invalid search query Search error occurred: Record ‘subsidiary’ was not found'
+              )
                 raise LedgerSync::Ledgers::NetSuite::Error::SubsidiariesNotEnabled
               end
             end

data/lib/ledger_sync/ledgers/netsuite/token.rb

@@ -141,7 +141,7 @@ module LedgerSync
         def url_params
           return {} if uri.query.nil?
 
-          @url_params ||= Hash[CGI.parse(uri.query).map { |k, v| [k, v.first] }]
+          @url_params ||= CGI.parse(uri.query).transform_values(&:first)
         end
 
         def url_without_params

data/lib/ledger_sync/ledgers/netsuite/type/deserializer_entity_type.rb

@@ -10,12 +10,12 @@ module LedgerSync
           def cast_value(args = {})
             value = args.fetch(:value)
 
-            unless value.nil?
-              resource = (value.fetch("links").first.fetch("href").include? "vendor") ? Vendor : Customer
-              resource.new(
-                ledger_id: value['id']
-              )
-            end
+            return if value.nil?
+
+            resource = value.fetch('links').first.fetch('href').include?('vendor') ? Vendor : Customer
+            resource.new(
+              ledger_id: value['id']
+            )
           end
 
           def valid_classes

data/lib/ledger_sync/ledgers/netsuite/vendor/operations/create.rb

@@ -3,7 +3,7 @@
 module LedgerSync
   module Ledgers
     module NetSuite
-    class Vendor
+      class Vendor
         module Operations
           class Create < NetSuite::Operation::Create
             class Contract < LedgerSync::Ledgers::Contract

data/lib/ledger_sync/ledgers/netsuite/vendor/operations/delete.rb

@@ -3,7 +3,7 @@
 module LedgerSync
   module Ledgers
     module NetSuite
-    class Vendor
+      class Vendor
         module Operations
           class Delete < NetSuite::Operation::Delete
             class Contract < LedgerSync::Ledgers::Contract