RubyGems - ledger_sync - Versions diffs - 1.4.2 → 1.4.4 - Mend

ledger_sync 1.4.2 → 1.4.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (165) hide show

data/lib/ledger_sync/ledgers/netsuite/vendor/operations/find.rb CHANGED

@@ -3,7 +3,7 @@
 module LedgerSync
   module Ledgers
     module NetSuite
-    class Vendor
+      class Vendor
         module Operations
           class Find < NetSuite::Operation::Find
             class Contract < LedgerSync::Ledgers::Contract

data/lib/ledger_sync/ledgers/netsuite/vendor/operations/update.rb CHANGED

@@ -3,7 +3,7 @@
 module LedgerSync
   module Ledgers
     module NetSuite
-    class Vendor
+      class Vendor
         module Operations
           class Update < NetSuite::Operation::Update
             class Contract < LedgerSync::Ledgers::Contract

data/lib/ledger_sync/ledgers/netsuite_soap/client.rb CHANGED

@@ -1,33 +1,27 @@
+# frozen_string_literal: true
 require 'oauth2'
 module LedgerSync
   module Ledgers
     module NetSuiteSOAP
       class Client < Ledgers::Client
-        DEFAULT_API_VERSION = '2016_2'.freeze
+        DEFAULT_API_VERSION = '2016_2'
         attr_reader :account_id,
                     :api_version,
                     :consumer_key,
                     :consumer_secret,
-                    :account_id,
                     :token_id,
                     :token_secret
-        def initialize(
-          account_id:,
-          api_version: nil,
-          consumer_key:,
-          consumer_secret:,
-          token_id:,
-          token_secret:
-        )
-          @account_id = account_id
-          @api_version = api_version || DEFAULT_API_VERSION
-          @consumer_key = consumer_key
-          @consumer_secret = consumer_secret
-          @token_id = token_id
-          @token_secret = token_secret
+        def initialize(args = {})
+          @account_id      = args.fetch(:account_id)
+          @api_version     = args.fetch(:api_version, DEFAULT_API_VERSION)
+          @consumer_key    = args.fetch(:consumer_key)
+          @consumer_secret = args.fetch(:consumer_secret)
+          @token_id        = args.fetch(:token_id)
+          @token_secret    = args.fetch(:token_secret)
         end
         #
@@ -51,11 +45,11 @@ module LedgerSync
         def setup
           setup_account_id_for_gem = account_id_for_gem
           setup_account_id_for_url = account_id_for_url
-          setup_api_version = api_version
-          setup_consumer_key = consumer_key
-          setup_consumer_secret = consumer_secret
-          setup_token_id = token_id
-          setup_token_secret = token_secret
+          setup_api_version        = api_version
+          setup_consumer_key       = consumer_key
+          setup_consumer_secret    = consumer_secret
+          setup_token_id           = token_id
+          setup_token_secret       = token_secret
           ::NetSuite.configure do
             reset!

data/lib/ledger_sync/ledgers/netsuite_soap/customer/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module NetSuiteSOAP

data/lib/ledger_sync/ledgers/operation.rb CHANGED

@@ -3,7 +3,7 @@
 module LedgerSync
   module Ledgers
     module Operation
-      module Mixin
+      module Mixin # rubocop:disable Metrics/ModuleLength
         module ClassMethods
           def client_class
             @client_class ||= Class.const_get("#{name.split('::')[0..2].join('::')}::Ledger")
@@ -57,14 +57,16 @@ module LedgerSync
           @validation_contract = args.fetch(:validation_contract, nil)
           # self.class.raise_if_unexpected_class(expected: self.class.inferred_resource_class, given: @resource.class)
-          self.class.raise_if_unexpected_class(expected: LedgerSync::Ledgers::Contract, given: validation_contract) unless @validation_contract.nil?
+          return if @validation_contract.nil?
+          self.class.raise_if_unexpected_class(expected: LedgerSync::Ledgers::Contract, given: validation_contract)
         end
         def perform
           failure(LedgerSync::Error::OperationError::PerformedOperationError.new(operation: self)) if @performed
           @result = begin
-                      operate
+            operate
                     rescue LedgerSync::Error => e
                       failure(e)
                     rescue StandardError => e

data/lib/ledger_sync/ledgers/quickbooks_online/account/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/account/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/bill/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/bill/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/bill/operations/update.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/client.rb CHANGED

@@ -96,7 +96,8 @@ module LedgerSync
           ledger_resource_type = self.class.ledger_resource_type_for(
             resource_class: resource_class
           ).classify
-          full_query = "SELECT * FROM #{ledger_resource_type} WHERE #{query} STARTPOSITION #{offset} MAXRESULTS #{limit}"
+          full_query = "SELECT * FROM #{ledger_resource_type} WHERE #{query} STARTPOSITION #{offset} MAXRESULTS "\
+                       "#{limit}"
           url = "#{oauth_base_uri}/query?query=#{CGI.escape(full_query)}"
           request(
@@ -116,7 +117,9 @@ module LedgerSync
         end
         def revoke_token!
-          headers = OAUTH_HEADERS.dup.merge('Authorization' => 'Basic ' + Base64.strict_encode64(client_id + ':' + client_secret))
+          headers = OAUTH_HEADERS.dup.merge(
+            'Authorization' => 'Basic ' + Base64.strict_encode64(client_id + ':' + client_secret)
+          )
           LedgerSync::Ledgers::Request.new(
             body: {
               token: access_token
@@ -141,7 +144,7 @@ module LedgerSync
           oauth_token
         end
-        def update_secrets_in_dotenv
+        def update_secrets_in_dotenv # rubocop:disable Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
           return if ENV['TEST_ENV'] && !ENV['USE_DOTENV_ADAPTOR_SECRETS']
           filename = File.join(Dir.pwd, '.env')
@@ -166,6 +169,7 @@ module LedgerSync
                 tempfile.puts line
               end
             end
             tempfile.close
             FileUtils.mv tempfile.path, filename
           end
@@ -243,7 +247,11 @@ module LedgerSync
           @access_token = token.token
           @expires_at = Time&.at(token.expires_at.to_i)&.to_datetime
-          @refresh_token_expires_at = Time&.at(Time.now.to_i + token.params['x_refresh_token_expires_in'])&.to_datetime unless token.params['x_refresh_token_expires_in'].nil?
+          unless token.params['x_refresh_token_expires_in'].nil?
+            @refresh_token_expires_at = Time&.at(
+              Time.now.to_i + token.params['x_refresh_token_expires_in']
+            )&.to_datetime
+          end
           @previous_refresh_tokens << refresh_token if refresh_token.present?
           @refresh_token = token.refresh_token

data/lib/ledger_sync/ledgers/quickbooks_online/customer/searcher.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/dashboard_url_helper.rb CHANGED

@@ -4,29 +4,29 @@ module LedgerSync
   module Ledgers
     module QuickBooksOnline
       class DashboardURLHelper < LedgerSync::Ledgers::DashboardURLHelper
-        def resource_path
+        def resource_path # rubocop:disable Metrics/CyclomaticComplexity
           @resource_path = case resource
-          when QuickBooksOnline::Account
-            "/register?accountId=#{resource.ledger_id}"
-          when QuickBooksOnline::Bill
-            "/bill?txnId=#{resource.ledger_id}"
-          when QuickBooksOnline::Customer
-            "/customerdetail?nameId=#{resource.ledger_id}"
-          when QuickBooksOnline::Deposit
-            "/deposit?txnId=#{resource.ledger_id}"
-          when QuickBooksOnline::Expense
-            "/expense?txnId=#{resource.ledger_id}"
-          when QuickBooksOnline::JournalEntry
-            "/journal?txnId=#{resource.ledger_id}"
-          when QuickBooksOnline::LedgerClass
-            "/class"
-          when QuickBooksOnline::Payment
-            "/recvpayment?txnId=#{resource.ledger_id}"
-          when QuickBooksOnline::Transfer
-            "/transfer?txnId=#{resource.ledger_id}"
-          when QuickBooksOnline::Vendor
-            "/vendordetail?nameId=#{resource.ledger_id}"
-          end
+                           when QuickBooksOnline::Account
+                             "/register?accountId=#{resource.ledger_id}"
+                           when QuickBooksOnline::Bill
+                             "/bill?txnId=#{resource.ledger_id}"
+                           when QuickBooksOnline::Customer
+                             "/customerdetail?nameId=#{resource.ledger_id}"
+                           when QuickBooksOnline::Deposit
+                             "/deposit?txnId=#{resource.ledger_id}"
+                           when QuickBooksOnline::Expense
+                             "/expense?txnId=#{resource.ledger_id}"
+                           when QuickBooksOnline::JournalEntry
+                             "/journal?txnId=#{resource.ledger_id}"
+                           when QuickBooksOnline::LedgerClass
+                             '/class'
+                           when QuickBooksOnline::Payment
+                             "/recvpayment?txnId=#{resource.ledger_id}"
+                           when QuickBooksOnline::Transfer
+                             "/transfer?txnId=#{resource.ledger_id}"
+                           when QuickBooksOnline::Vendor
+                             "/vendordetail?nameId=#{resource.ledger_id}"
+                           end
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/department/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/department/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/deposit/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/deposit/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/deposit/searcher.rb CHANGED

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 require_relative '../searcher'
 module LedgerSync

data/lib/ledger_sync/ledgers/quickbooks_online/deserializer.rb CHANGED

@@ -14,11 +14,13 @@ module LedgerSync
           deserialized_resource = super(hash: hash, resource: resource)
           # Ref: https://github.com/LedgerSync/ledger_sync/issues/86
-          if deserialized_resource.is_a?(LedgerSync::Ledgers::QuickBooksOnline::Account) && deserialized_resource.account_type
+          if deserialized_resource.is_a?(LedgerSync::Ledgers::QuickBooksOnline::Account) &&
+             deserialized_resource.account_type &&
+             deserialized_resource.classification.blank?
             deserialized_resource.classification = deserialized_resource.class::TYPES_TO_CLASSIFICATION_MAPPING.fetch(
               deserialized_resource.account_type,
               nil
-            ) if deserialized_resource.classification.blank?
+            )
           end
           return deserialized_resource unless merge_for_full_update

data/lib/ledger_sync/ledgers/quickbooks_online/expense/deserializer.rb CHANGED

@@ -8,6 +8,8 @@ module LedgerSync
     module QuickBooksOnline
       class Expense
         class Deserializer < QuickBooksOnline::Deserializer
+          id
           references_one :currency,
                          hash_attribute: :CurrencyRef,
                          deserializer: Currency::Deserializer
@@ -33,8 +35,7 @@ module LedgerSync
               Client.resource_from_ledger_type(
                 type: value['type']
               ).new(
-                ledger_id: value['value'],
-                display_name: value['name']
+                ledger_id: value['value']
               )
             end
           end

data/lib/ledger_sync/ledgers/quickbooks_online/expense/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/expense/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/expense/operations/update.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/invoice/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/invoice/operations/update.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/journal_entry/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/journal_entry/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/journal_entry/operations/update.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/ledger_class/deserializer.rb CHANGED

@@ -21,7 +21,6 @@ module LedgerSync
           attribute 'parent.ledger_id',
                     hash_attribute: 'ParentRef.value'
         end
       end
     end

data/lib/ledger_sync/ledgers/quickbooks_online/ledger_class/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/ledger_class/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/operation.rb CHANGED

@@ -1,4 +1,4 @@
-  # frozen_string_literal: true
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers

data/lib/ledger_sync/ledgers/quickbooks_online/payment/operations/find.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/payment/operations/update.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline

data/lib/ledger_sync/ledgers/quickbooks_online/resources/customer.rb CHANGED

@@ -13,6 +13,10 @@ module LedgerSync
         references_one :PrimaryPhone, to: PrimaryPhone
         references_one :PrimaryEmailAddr, to: PrimaryEmailAddr
         references_one :subsidiary, to: Subsidiary
+        def name
+          self.DisplayName
+        end
       end
     end
   end

data/lib/ledger_sync/ledgers/quickbooks_online/transfer/operations/create.rb CHANGED

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
 module LedgerSync
   module Ledgers
     module QuickBooksOnline