katello 3.17.3 → 3.18.0.rc1

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/products/details/repositories/new/new-repository.controller.js

@@ -17,6 +17,7 @@
  * @requires OstreeUpstreamSyncPolicy
  * @requires Architecture
  * @requires RepositoryTypesService
+ * @requires OSVersions
  * @requires YumContentUnits
  * #requires HttpProxyPolicy
  *
@@ -24,118 +25,121 @@
  *   Controls the creation of an empty Repository object for use by sub-controllers.
  */
 angular.module('Bastion.repositories').controller('NewRepositoryController',
-    ['$scope', '$sce', 'Repository', 'Product', 'ContentCredential', 'FormUtils', 'translate', 'Notification', 'ApiErrorHandler', 'BastionConfig', 'Checksum', 'YumContentUnits', 'DownloadPolicy', 'OstreeUpstreamSyncPolicy', 'Architecture', 'RepositoryTypesService', 'HttpProxy', 'HttpProxyPolicy',
-    function ($scope, $sce, Repository, Product, ContentCredential, FormUtils, translate, Notification, ApiErrorHandler, BastionConfig, Checksum, YumContentUnits, DownloadPolicy, OstreeUpstreamSyncPolicy, Architecture, RepositoryTypesService, HttpProxy, HttpProxyPolicy) {
-
-        function success() {
-            Notification.setSuccessMessage(translate('Repository %s successfully created.').replace('%s', $scope.repository.name));
-            $scope.transitionTo('product.repositories', {productId: $scope.$stateParams.productId});
-        }
-
-        function error(response) {
-            var foundError = false;
-            $scope.working = false;
-
-            angular.forEach($scope.repositoryForm, function (field) {
-                if ($scope.repositoryForm.hasOwnProperty(field) && field.hasOwnProperty('$modelValue')) {
-                    field.$setValidity('server', true);
-                    $scope.repositoryForm[field].$error.messages = [];
+    ['$scope', '$sce', 'Repository', 'Product', 'ContentCredential', 'FormUtils', 'translate', 'Notification', 'ApiErrorHandler', 'BastionConfig', 'Checksum', 'YumContentUnits', 'DownloadPolicy', 'OstreeUpstreamSyncPolicy', 'Architecture', 'RepositoryTypesService', 'HttpProxy', 'HttpProxyPolicy', 'OSVersions',
+        function ($scope, $sce, Repository, Product, ContentCredential, FormUtils, translate, Notification, ApiErrorHandler, BastionConfig, Checksum, YumContentUnits, DownloadPolicy, OstreeUpstreamSyncPolicy, Architecture, RepositoryTypesService, HttpProxy, HttpProxyPolicy, OSVersions) {
+
+            function success() {
+                Notification.setSuccessMessage(translate('Repository %s successfully created.').replace('%s', $scope.repository.name));
+                $scope.transitionTo('product.repositories', {productId: $scope.$stateParams.productId});
+            }
+
+            function error(response) {
+                var foundError = false;
+                $scope.working = false;
+
+                angular.forEach($scope.repositoryForm, function (field) {
+                    if ($scope.repositoryForm.hasOwnProperty(field) && field.hasOwnProperty('$modelValue')) {
+                        field.$setValidity('server', true);
+                        $scope.repositoryForm[field].$error.messages = [];
+                    }
+                });
+
+                angular.forEach(response.data.errors, function (errors, field) {
+                    if ($scope.repositoryForm.hasOwnProperty(field)) {
+                        foundError = true;
+                        $scope.repositoryForm[field].$setValidity('server', false);
+                        $scope.repositoryForm[field].$error.messages = errors;
+                    }
+                });
+
+                if (!foundError) {
+                    Notification.setErrorMessage(response.data.displayMessage);
                 }
+            }
+
+            $scope.page = {
+                error: false,
+                loading: true
+            };
+
+            $scope.repository = new Repository({'product_id': $scope.$stateParams.productId, unprotected: true,
+                'checksum_type': null, 'mirror_on_sync': true, 'verify_ssl_on_sync': true,
+                'download_policy': BastionConfig.defaultDownloadPolicy, 'arch': null,
+                'ostree_upstream_sync_policy': 'latest'});
+
+            $scope.product = Product.get({id: $scope.$stateParams.productId}, function () {
+                $scope.page.loading = false;
+            }, function (response) {
+                $scope.page.loading = false;
+                ApiErrorHandler.handleGETRequestErrors(response, $scope);
             });
 
-            angular.forEach(response.data.errors, function (errors, field) {
-                if ($scope.repositoryForm.hasOwnProperty(field)) {
-                    foundError = true;
-                    $scope.repositoryForm[field].$setValidity('server', false);
-                    $scope.repositoryForm[field].$error.messages = errors;
+            $scope.repositoryTypes = RepositoryTypesService.creatable();
+            $scope.repositoryTypes = _.sortBy($scope.repositoryTypes, 'name');
+
+            $scope.checksums = Checksum.checksums;
+            $scope.downloadPolicies = DownloadPolicy.downloadPolicies;
+            $scope.ostreeUpstreamSyncPolicies = OstreeUpstreamSyncPolicy.syncPolicies;
+            $scope.ignorableYumContentUnits = YumContentUnits.units;
+
+            $scope.$watch('repository.name', function () {
+                if ($scope.repositoryForm && $scope.repositoryForm.name) {
+                    $scope.repositoryForm.name.$setValidity('server', true);
+                    FormUtils.labelize($scope.repository);
                 }
             });
 
-            if (!foundError) {
-                Notification.setErrorMessage(response.data.displayMessage);
-            }
-        }
-
-        $scope.page = {
-            error: false,
-            loading: true
-        };
-
-        $scope.repository = new Repository({'product_id': $scope.$stateParams.productId, unprotected: true,
-            'checksum_type': null, 'mirror_on_sync': true, 'verify_ssl_on_sync': true,
-            'download_policy': BastionConfig.defaultDownloadPolicy, 'arch': null,
-            'ostree_upstream_sync_policy': 'latest'});
-
-        $scope.product = Product.get({id: $scope.$stateParams.productId}, function () {
-            $scope.page.loading = false;
-        }, function (response) {
-            $scope.page.loading = false;
-            ApiErrorHandler.handleGETRequestErrors(response, $scope);
-        });
-
-        $scope.repositoryTypes = RepositoryTypesService.creatable();
-        $scope.repositoryTypes = _.sortBy($scope.repositoryTypes, 'name');
-
-        $scope.checksums = Checksum.checksums;
-        $scope.downloadPolicies = DownloadPolicy.downloadPolicies;
-        $scope.ostreeUpstreamSyncPolicies = OstreeUpstreamSyncPolicy.syncPolicies;
-        $scope.ignorableYumContentUnits = YumContentUnits.units;
-
-        $scope.$watch('repository.name', function () {
-            if ($scope.repositoryForm && $scope.repositoryForm.name) {
-                $scope.repositoryForm.name.$setValidity('server', true);
-                FormUtils.labelize($scope.repository);
-            }
-        });
-
-        $scope.handleFiles = function (element) {
-            var reader = new FileReader();
-            reader.addEventListener("loadend", function() {
-                var data = reader.result;
-              /* eslint-disable camelcase */
-                $scope.repository.ansible_collection_requirements = data;
-                $scope.$apply();
-            });
-            reader.readAsText(element.files[0]);
-        };
-
-        ContentCredential.queryUnpaged(function (contentCredentials) {
-            $scope.contentCredentials = contentCredentials.results;
-        });
-
-        Architecture.queryUnpaged(function (architecture) {
-            var results = architecture.results;
-            var noarch = {
-                id: 'noarch',
-                name: translate('Default'),
-                value: null
+            $scope.handleFiles = function (element) {
+                var reader = new FileReader();
+                reader.addEventListener("loadend", function() {
+                    var data = reader.result;
+                    /* eslint-disable camelcase */
+                    $scope.repository.ansible_collection_requirements = data;
+                    $scope.$apply();
+                });
+                reader.readAsText(element.files[0]);
             };
-            results.map(function(i) {
-                i.id = i.name;
+
+            ContentCredential.queryUnpaged(function (contentCredentials) {
+                $scope.contentCredentials = contentCredentials.results;
             });
-            results.unshift(noarch);
-            $scope.architecture = results;
-            $scope.repository.arch = results[0].id;
-        });
-
-        $scope.save = function (repository) {
-            if (repository.content_type === 'ostree') {
-                repository.unprotected = false;
-            }
-            if (repository.content_type !== 'yum') {
-                repository['download_policy'] = '';
-            }
-            if (repository.arch === 'Default') {
-                repository.arch = null;
-            }
-            repository.$save(success, error);
-        };
 
-        $scope.repository['http_proxy_policy'] = HttpProxyPolicy.policies[0].label;
-        $scope.policies = HttpProxyPolicy.policies;
-        $scope.proxies = [];
+            Architecture.queryUnpaged(function (architecture) {
+                var results = architecture.results;
+                var noarch = {
+                    id: 'noarch',
+                    name: translate('No restriction'),
+                    value: null
+                };
+                results.map(function(i) {
+                    i.id = i.name;
+                });
+                results.unshift(noarch);
+                $scope.architecture = results;
+                $scope.repository.arch = results[0].id;
+            });
+
+            $scope.save = function (repository) {
+                if (repository.content_type === 'ostree') {
+                    repository.unprotected = false;
+                }
+                if (repository.content_type === 'yum') {
+                    repository.os_versions = $scope.osVersionsParam();
+                }
+                if (repository.content_type !== 'yum') {
+                    repository['download_policy'] = '';
+                }
+                if (repository.arch === 'No restriction') {
+                    repository.arch = null;
+                }
+                repository.$save(success, error);
+            };
+
+            $scope.repository['http_proxy_policy'] = HttpProxyPolicy.policies[0].label;
+            $scope.policies = HttpProxyPolicy.policies;
+            $scope.proxies = [];
 
-        $scope.collectionURLPopover = $sce.trustAsHtml("You can sync collections utilizing just the url:<br/>" +
+            $scope.collectionURLPopover = $sce.trustAsHtml("You can sync collections utilizing just the url:<br/>" +
           "<b>1. For all collections in Ansible Galaxy:</b><br/>" +
           "https://galaxy.ansible.com/api/v2/collections <br/>" +
           "<b>2. For specific collection with URL filtering:</b><br/>" +
@@ -143,18 +147,26 @@ angular.module('Bastion.repositories').controller('NewRepositoryController',
           "<b>3. For specific collections with Requirements.yml:</b><br/>" +
           "Use base URL https://galaxy.ansible.com/ and specify requirements.yml below to specify collections");
 
-        $scope.requirementPopover = $sce.trustAsHtml("To learn more about requirement.yml specification, visit <a href='https://docs.ansible.com/ansible/devel/dev_guide/collections_tech_preview.html#install-multiple-collections-with-a-requirements-file' target=\"_blank\">documentation </a>");
+            $scope.requirementPopover = $sce.trustAsHtml("To learn more about requirement.yml specification, visit <a href='https://docs.ansible.com/ansible/devel/dev_guide/collections_tech_preview.html#install-multiple-collections-with-a-requirements-file' target=\"_blank\">documentation </a>");
+
+            $scope.displayHttpProxyPolicyName = function (policy) {
+                return HttpProxyPolicy.displayHttpProxyPolicyName(policy);
+            };
+
+            $scope.displayHttpProxyName = function (proxyId) {
+                return HttpProxyPolicy.displayHttpProxyName($scope.proxies, proxyId);
+            };
+
+            HttpProxy.queryUnpaged(function (proxies) {
+                $scope.proxies = proxies.results;
+            });
 
-        $scope.displayHttpProxyPolicyName = function (policy) {
-            return HttpProxyPolicy.displayHttpProxyPolicyName(policy);
-        };
+            $scope.osVersionsOptions = OSVersions.getOSVersionsOptions($scope.repository);
+            $scope.repository.os_versions = $scope.osVersionsOptions[0]; // ensure that No restriction is selected initially
 
-        $scope.displayHttpProxyName = function (proxyId) {
-            return HttpProxyPolicy.displayHttpProxyName($scope.proxies, proxyId);
-        };
+            $scope.osVersionsParam = function () {
+                return OSVersions.osVersionsParam($scope.repository.os_versions);
+            };
 
-        HttpProxy.queryUnpaged(function (proxies) {
-            $scope.proxies = proxies.results;
-        });
-    }]
+        }]
 );

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/products/details/repositories/new/views/new-repository.html

@@ -50,10 +50,22 @@
                 ng-model="repository.arch"
                 ng-options="arch.id as arch.name for arch in architecture">
         </select>
-        <p class="help-block" translate>
-          Choose <b>Default</b> to enable the repository for all architectures
-        </p>
       </div>
+
+      <div
+        bst-form-group label="{{ 'Restrict to OS version' | translate }}"
+        ng-if="repository.content_type === 'yum'"
+      >
+       <select id="os_versions"
+               name="os_versions"
+               ng-model="repository.os_versions"
+               ng-options="tag as tag.name for tag in osVersionsOptions track by tag.id">
+       </select>
+       <p class="help-block" translate>
+         The repository will be enabled by default on content hosts with the selected OS version.
+       </p>
+      </div>
+
     </div>
     <div ng-show="repository.content_type !== undefined">
       <h4 translate> Sync Settings </h4>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/products/details/repositories/os-versions.service.js

@@ -0,0 +1,46 @@
+
+/**
+ * @ngdoc service
+ * @name  Bastion.products.details.repositories.service:OSVersions
+ *
+ * @description
+ *   Helper functions for repo osVersions.
+ */
+
+angular
+    .module('Bastion.repositories')
+    .service('OSVersions', function () {
+
+        this.getOSVersionsOptions = function () {
+            return [
+                { name: 'No restriction', id: '' },
+                { name: 'Red Hat Enterprise Linux 8 ', id: 'rhel-8' },
+                { name: 'Red Hat Enterprise Linux 7 ', id: 'rhel-7' },
+                { name: 'Red Hat Enterprise Linux 6 ', id: 'rhel-6' }
+            ];
+        };
+
+        // return an array of OS versions
+        this.osVersionsParam = function (osVersion) {
+            var param = osVersion;
+            if (osVersion && osVersion.hasOwnProperty('id')) {
+                param = osVersion.id;
+            }
+            // exclude null, undefined, and ''
+            return [param].filter(function (el) {
+                return el && el !== '';
+            });
+        };
+
+        // return the OS versions as comma-separated string
+        this.formatOSVersions = function (osVersionList) {
+            var individualVersions, versionStr;
+            individualVersions = this.osVersionsParam(osVersionList);
+            if (individualVersions) {
+                versionStr = individualVersions.join(",");
+            }
+            return versionStr;
+        };
+
+    }
+    );

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/subscriptions/views/content-access-mode-banner.html

@@ -1,5 +1,5 @@
 <div id="content-access-mode-banner" bst-alert="info" ng-show="simpleContentAccessEnabled">
   <span translate>
-This organization has Simple Content Access enabled. Hosts can consume from all repositories in their Content View regardless of subscription status.
+This organization has Simple Content Access enabled.  Hosts are not required to have subscriptions attached to access repositories.
   </span>
 </div>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/sync-plans/details/views/sync-plan-details.html

@@ -16,7 +16,7 @@
   <nav data-block="item-actions" bst-feature-flag="custom_products">
     <span select-action-dropdown>
       <ul class="dropdown-menu dropdown-menu-right" uib-dropdown-menu role="menu">
-        <li role="menuitem" ng-hide="denied('sync_products')">
+        <li role="menuitem" ng-hide="denied('sync_sync_plans')">
           <a ng-click="runSyncPlan()">
             <span translate>Run Sync Plan</span>
           </a>

data/lib/katello/engine.rb

@@ -216,6 +216,7 @@ module Katello
       ::Api::V2::HostsController.include Katello::Concerns::Api::V2::HostsControllerExtensions
       ::Api::V2::HostgroupsController.include Katello::Concerns::Api::V2::HostgroupsControllerExtensions
       ::Api::V2::SmartProxiesController.include Katello::Concerns::Api::V2::SmartProxiesControllerExtensions
+      ::Api::V2::RegistrationController.prepend Katello::Concerns::Api::V2::RegistrationControllerExtensions
 
       ::HostsController.class_eval do
         helper Katello::Concerns::HostsAndHostgroupsHelperExtensions

data/lib/katello/permission_creator.rb

@@ -8,7 +8,6 @@ module Katello
       activation_keys_permissions
       capsule_content_permissions
       content_view_permissions
-      gpg_key_permissions
       content_credential_permissions
       host_collections_permissions
       lifecycle_environment_permissions
@@ -25,7 +24,8 @@ module Katello
                            'katello/api/v2/activation_keys' => [:index, :show, :available_host_collections, :available_releases,
                                                                 :product_content, :auto_complete_search]
                          },
-                         :resource_type => 'Katello::ActivationKey'
+                         :resource_type => 'Katello::ActivationKey',
+                         :finder_scope => :readable
       @plugin.permission :create_activation_keys,
                          {
                            'katello/api/v2/activation_keys' => [:create, :copy]
@@ -37,12 +37,14 @@ module Katello
                                                                 :add_subscriptions, :remove_subscriptions,
                                                                 :add_host_collections, :remove_host_collections]
                          },
-                         :resource_type => 'Katello::ActivationKey'
+                         :resource_type => 'Katello::ActivationKey',
+                         :finder_scope => :editable
       @plugin.permission :destroy_activation_keys,
                          {
                            'katello/api/v2/activation_keys' => [:destroy]
                          },
-                         :resource_type => 'Katello::ActivationKey'
+                         :resource_type => 'Katello::ActivationKey',
+                         :finder_scope => :deletable
     end
 
     def capsule_content_permissions
@@ -72,7 +74,7 @@ module Katello
                    'katello/api/v2/content_view_histories' => [:index, :auto_complete_search],
                    'katello/api/v2/content_view_puppet_modules' => [:index, :show, :auto_complete_search],
                    'katello/api/v2/content_view_repositories' => [:show_all],
-                   'katello/api/v2/content_view_versions' => [:index, :show, :auto_complete_search, :export_histories],
+                   'katello/api/v2/content_view_versions' => [:index, :show, :auto_complete_search, :export_histories, :export_api_status],
                    'katello/api/v2/content_view_components' => [:index, :show],
                    'katello/api/v2/packages' => [:index],
                    'katello/api/v2/package_groups' => [:index, :show, :auto_complete_search, :compare],
@@ -109,7 +111,8 @@ module Katello
                                                 :view_compare_puppet_modules,
                                                 :views]
                  },
-                 :resource_type => 'Katello::ContentView'
+                 :resource_type => 'Katello::ContentView',
+                 :finder_scope => :readable
       @plugin.permission :create_content_views,
                          {
                            'katello/api/v2/content_views' => [:create, :copy]
@@ -124,76 +127,65 @@ module Katello
                            'katello/api/v2/content_view_puppet_modules' => [:create, :update, :destroy],
                            'katello/api/v2/content_view_components' => [:add_components, :remove_components, :update]
                          },
-                         :resource_type => 'Katello::ContentView'
+                         :resource_type => 'Katello::ContentView',
+                         :finder_scope => :editable
       @plugin.permission :destroy_content_views,
                          {
                            'katello/api/v2/content_views' => [:destroy, :remove],
                            'katello/api/v2/content_view_versions' => [:destroy]
                          },
-                         :resource_type => 'Katello::ContentView'
+                         :resource_type => 'Katello::ContentView',
+                         :finder_scope => :deletable
       @plugin.permission :publish_content_views,
                          {
                            'katello/api/v2/content_views' => [:publish],
                            'katello/api/v2/content_view_versions' => [:incremental_update, :republish_repositories, :import]
                          },
-                         :resource_type => 'Katello::ContentView'
+                         :resource_type => 'Katello::ContentView',
+                         :finder_scope => :publishable
       @plugin.permission :promote_or_remove_content_views,
                          {
                            'katello/api/v2/content_view_versions' => [:promote],
                            'katello/api/v2/content_views' => [:remove_from_environment, :remove, :republish_repositories]
                          },
-                         :resource_type => 'Katello::ContentView'
+                         :resource_type => 'Katello::ContentView',
+                         :finder_scope => :promotable_or_removable
       @plugin.permission :export_content_views,
                          {
-                           'katello/api/v2/content_view_versions' => [:export]
-                         },
-                         :resource_type => 'Katello::ContentView'
-    end
-
-    def gpg_key_permissions
-      @plugin.permission :view_gpg_keys,
-                         {
-                           'katello/api/v2/gpg_keys' => [:index, :show, :content, :auto_complete_search]
-                         },
-                         :resource_type => 'Katello::GpgKey'
-      @plugin.permission :create_gpg_keys,
-                         {
-                           'katello/api/v2/gpg_keys' => [:create]
-                         },
-                         :resource_type => 'Katello::GpgKey'
-      @plugin.permission :edit_gpg_keys,
-                         {
-                           'katello/api/v2/gpg_keys' => [:update, :set_content]
-                         },
-                         :resource_type => 'Katello::GpgKey'
-      @plugin.permission :destroy_gpg_keys,
-                         {
-                           'katello/api/v2/gpg_keys' => [:destroy]
+                           'katello/api/v2/content_view_versions' => [:export, :export_histories, :export_api_status]
                          },
-                         :resource_type => 'Katello::GpgKey'
+                         :resource_type => 'Katello::ContentView',
+                         :finder_scope => :exportable
     end
 
     def content_credential_permissions
       @plugin.permission :view_content_credentials,
                          {
-                           'katello/api/v2/content_credentials' => [:index, :show, :content, :auto_complete_search]
+                           'katello/api/v2/content_credentials' => [:index, :show, :content, :auto_complete_search],
+                           'katello/api/v2/gpg_keys' => [:index, :show, :content, :auto_complete_search]
                          },
-                         :resource_type => 'Katello::GpgKey'
+                         :resource_type => 'Katello::GpgKey',
+                         :finder_scope => :readable
       @plugin.permission :create_content_credentials,
                          {
-                           'katello/api/v2/content_credentials' => [:create]
+                           'katello/api/v2/content_credentials' => [:create],
+                           'katello/api/v2/gpg_keys' => [:create]
                          },
                          :resource_type => 'Katello::GpgKey'
       @plugin.permission :edit_content_credentials,
                          {
-                           'katello/api/v2/content_credentials' => [:update, :set_content]
+                           'katello/api/v2/content_credentials' => [:update, :set_content],
+                           'katello/api/v2/gpg_keys' => [:update, :set_content]
                          },
-                         :resource_type => 'Katello::GpgKey'
+                         :resource_type => 'Katello::GpgKey',
+                         :finder_scope => :editable
       @plugin.permission :destroy_content_credentials,
                          {
-                           'katello/api/v2/content_credentials' => [:destroy]
+                           'katello/api/v2/content_credentials' => [:destroy],
+                           'katello/api/v2/gpg_keys' => [:destroy]
                          },
-                         :resource_type => 'Katello::GpgKey'
+                         :resource_type => 'Katello::GpgKey',
+                         :finder_scope => :deletable
     end
 
     def host_collections_permissions
@@ -201,22 +193,26 @@ module Katello
                          {
                            'katello/api/v2/host_collections' => [:index, :show, :auto_complete_search]
                          },
-                         :resource_type => 'Katello::HostCollection'
+                         :resource_type => 'Katello::HostCollection',
+                         :finder_scope => :readable
       @plugin.permission :create_host_collections,
                          {
                            'katello/api/v2/host_collections' => [:create, :copy]
                          },
-                         :resource_type => 'Katello::HostCollection'
+                         :resource_type => 'Katello::HostCollection',
+                         :finder_scope => :creatable
       @plugin.permission :edit_host_collections,
                          {
                            'katello/api/v2/host_collections' => [:update, :add_hosts, :remove_hosts]
                          },
-                         :resource_type => 'Katello::HostCollection'
+                         :resource_type => 'Katello::HostCollection',
+                         :finder_scope => :editable
       @plugin.permission :destroy_host_collections,
                          {
                            'katello/api/v2/host_collections' => [:destroy]
                          },
-                         :resource_type => 'Katello::HostCollection'
+                         :resource_type => 'Katello::HostCollection',
+                         :finder_scope => :deletable
     end
 
     def lifecycle_environment_permissions
@@ -225,26 +221,30 @@ module Katello
                            'katello/api/v2/environments' => [:index, :show, :paths, :repositories, :auto_complete_search],
                            'katello/api/rhsm/candlepin_proxies' => [:rhsm_index]
                          },
-                         :resource_type => 'Katello::KTEnvironment'
+                         :resource_type => 'Katello::KTEnvironment',
+                         :finder_scope => :readable
       @plugin.permission :create_lifecycle_environments,
                          {
                            'katello/api/v2/environments' => [:create]
                          },
-                         :resource_type => 'Katello::KTEnvironment'
+                         :resource_type => 'Katello::KTEnvironment',
+                         :finder_scope => :creatable
       @plugin.permission :edit_lifecycle_environments,
                          {
                            'katello/api/v2/environments' => [:update]
                          },
-                         :resource_type => 'Katello::KTEnvironment'
+                         :resource_type => 'Katello::KTEnvironment',
+                         :finder_scope => :editable
       @plugin.permission :destroy_lifecycle_environments,
                          {
                            'katello/api/v2/environments' => [:destroy]
                          },
-                         :resource_type => 'Katello::KTEnvironment'
-
+                         :resource_type => 'Katello::KTEnvironment',
+                         :finder_scope => :deletable
       @plugin.permission :promote_or_remove_content_views_to_environments,
                          {},
-                         :resource_type => 'Katello::KTEnvironment'
+                         :resource_type => 'Katello::KTEnvironment',
+                         :finder_scope => :promotable
     end
 
     def product_permissions # rubocop:disable Metrics/MethodLength
@@ -329,7 +329,6 @@ module Katello
                            'katello/api/v2/products_bulk_actions' => [:sync_products],
                            'katello/api/v2/repositories_bulk_actions' => [:sync_repositories],
                            'katello/api/v2/sync' => [:index],
-                           'katello/api/v2/sync_plans' => [:sync],
                            'katello/sync_management' => [:index, :sync_status, :product_status, :sync, :destroy]
                          },
                          :resource_type => 'Katello::Product',
@@ -372,33 +371,43 @@ module Katello
                          :resource_type => 'Katello::Subscription'
       @plugin.permission :manage_subscription_allocations,
                          {
-                           'katello/api/v2/upstream_subscriptions' => [:index, :create, :destroy, :update, :ping, :enable_simple_content_access, :disable_simple_content_access]
+                           'katello/api/v2/upstream_subscriptions' => [:index, :create, :destroy, :update, :ping, :enable_simple_content_access, :disable_simple_content_access, :simple_content_access_eligible]
                          },
                          :resource_type => 'Katello::Subscription'
     end
 
-    def sync_plan_permissions
+    def sync_plan_permissions # rubocop:disable Metrics/MethodLength
       @plugin.permission :view_sync_plans,
                          {
                            'katello/api/v2/sync_plans' => [:index, :show, :add_products, :remove_products, :available_products, :auto_complete_search],
                            'katello/api/v2/products' => [:index]
                          },
-                         :resource_type => 'Katello::SyncPlan'
+                         :resource_type => 'Katello::SyncPlan',
+                         :finder_scope => :readable
       @plugin.permission :create_sync_plans,
                          {
                            'katello/api/v2/sync_plans' => [:create]
                          },
-                         :resource_type => 'Katello::SyncPlan'
+                         :resource_type => 'Katello::SyncPlan',
+                         :finder_scope => :editable
       @plugin.permission :edit_sync_plans,
                          {
                            'katello/api/v2/sync_plans' => [:update]
                          },
-                         :resource_type => 'Katello::SyncPlan'
+                         :resource_type => 'Katello::SyncPlan',
+                         :finder_scope => :editable
       @plugin.permission :destroy_sync_plans,
                          {
                            'katello/api/v2/sync_plans' => [:destroy]
                          },
-                         :resource_type => 'Katello::SyncPlan'
+                         :resource_type => 'Katello::SyncPlan',
+                         :finder_scope => :deletable
+      @plugin.permission :sync_sync_plans,
+                         {
+                           'katello/api/v2/sync_plans' => [:sync]
+                         },
+                         :resource_type => 'Katello::SyncPlan',
+                         :finder_scope => :syncable
     end
 
     def user_permissions