katello 3.17.3 → 3.18.0.rc1

data/db/migrate/20201008204114_add_os_versions_to_katello_root_repositories.rb

@@ -0,0 +1,5 @@
+class AddOsVersionsToKatelloRootRepositories < ActiveRecord::Migration[6.0]
+  def change
+    add_column :katello_root_repositories, :os_versions, :text
+  end
+end

data/db/migrate/20201012172713_remove_gpg_key_perms.rb

@@ -0,0 +1,23 @@
+class RemoveGpgKeyPerms < ActiveRecord::Migration[6.0]
+  def permission_map
+    {
+      Permission.find_by(name: :view_gpg_keys) => Permission.find_by(name: :view_content_credentials),
+      Permission.find_by(name: :edit_gpg_keys) => Permission.find_by(name: :edit_content_credentials),
+      Permission.find_by(name: :destroy_gpg_keys) => Permission.find_by(name: :destroy_content_credentials),
+      Permission.find_by(name: :create_gpg_keys) => Permission.find_by(name: :create_content_credentials)
+    }
+  end
+
+  def up
+    perms = permission_map
+    perms.each do |old_perm, new_perm|
+      Filtering.where(permission_id: old_perm.id).update_all(:permission_id => new_perm.id) if old_perm
+    end
+    names = perms.keys.compact.map(&:name)
+    Permission.where(:name => names).destroy_all if names.any?
+  end
+
+  def down
+    fail ActiveRecord::IrreversibleMigration
+  end
+end

data/db/migrate/20201012192035_add_metadata_to_katello_content_view_version_export_history.rb

@@ -0,0 +1,5 @@
+class AddMetadataToKatelloContentViewVersionExportHistory < ActiveRecord::Migration[6.0]
+  def change
+    add_column :katello_content_view_version_export_histories, :metadata, :text
+  end
+end

data/db/seeds.d/111-upgrade_tasks.rb

@@ -13,6 +13,7 @@ UpgradeTask.define_tasks(:katello) do
     {:name => 'katello:upgrades:3.13:republish_deb_metadata'},
     {:name => 'katello:upgrades:3.15:set_sub_facet_dmi_uuid'},
     {:name => 'katello:upgrades:3.15:reindex_rpm_modular'},
-    {:name => 'katello:upgrades:3.16:update_applicable_el8_hosts'}
+    {:name => 'katello:upgrades:3.16:update_applicable_el8_hosts'},
+    {:name => 'katello:upgrades:3.18:add_cvv_export_history_metadata'}
   ]
 end

data/engines/bastion/app/assets/javascripts/bastion/components/notification.service.js

@@ -32,6 +32,6 @@ angular.module('Bastion.components').service("Notification", ['$interpolate', 'f
     };
 
     this.setErrorMessage = function (message, context) {
-        foreman.toastNotifications.notify({message: interpolateIfNeeded(message, context), type: 'danger'});
+        foreman.toastNotifications.notify({message: interpolateIfNeeded(message, context), type: 'error'});
     };
 }]);

data/engines/bastion/app/assets/javascripts/bastion/components/nutupane.factory.js

@@ -97,7 +97,6 @@ angular.module('Bastion.components').factory('Nutupane',
             self.load = function () {
                 var deferred = $q.defer(),
                     responsePage,
-                    resourceCall,
                     table = self.table,
                     existingTable = TableCache.getTable(getTableName());
 
@@ -115,11 +114,7 @@ angular.module('Bastion.components').factory('Nutupane',
                 params.search = table.searchTerm || "";
                 params.search = self.searchTransform(params.search);
 
-                resourceCall = resource[table.action](params, function (response) {
-                    if (response.error) {
-                        Notification.setErrorMessage(response.error);
-                    }
-
+                resource[table.action](params).$promise.then(function (response) {
                     angular.forEach(response.results, function (row) {
                         row.selected = table.allResultsSelected;
                     });
@@ -155,14 +150,14 @@ angular.module('Bastion.components').factory('Nutupane',
                     table.working = false;
                     table.refreshing = false;
                     table.initialLoad = false;
-                });
+                }).catch(function(response) {
+                    table.working = false;
+                    table.refreshing = false;
 
-                if (resourceCall && resourceCall.$promise && resourceCall.$promise.catch) {
-                    resourceCall.$promise.catch(function () {
-                        table.working = false;
-                        table.refreshing = false;
-                    });
-                }
+                    if (response && response.data && response.data.error && response.data.error.message) {
+                        Notification.setErrorMessage(response.data.error.message);
+                    }
+                });
 
                 return deferred.promise;
             };

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/common/views/katello-agent-notice.html

@@ -1,7 +1,7 @@
 <section>
   <p bst-alert="warning" >
     <span translate>
-      Katello-agent is deprecated and will be removed in a future release.
+      Katello-agent is deprecated and will be removed in Katello 4.0.  Consider migrating to Remote Execution.
     </span>
   </p>
 </section>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/content-hosts-bulk-system-purpose-modal.controller.js

@@ -0,0 +1,112 @@
+/**
+ * @ngdoc object
+ * @name  Bastion.content-hosts.controller:ContentHostsBulkSystemPurposeModalController
+ *
+ * @requires $scope
+ * @requires $uibModalInstance
+ * @requires HostBulkAction
+ * @requires Organization
+ * @requires CurrentOrganization
+ * @requires Notification
+ * @requires hostIds
+ *
+ * @description
+ *   A controller for providing bulk action functionality for setting system purpose values
+ */
+angular.module('Bastion.content-hosts').controller('ContentHostsBulkSystemPurposeModalController',
+    ['$scope', '$uibModalInstance', 'HostBulkAction', 'Organization', 'CurrentOrganization', 'Notification', 'hostIds',
+    function ($scope, $uibModalInstance, HostBulkAction, Organization, CurrentOrganization, Notification, hostIds) {
+
+        $scope.organization = Organization.get({id: CurrentOrganization});
+
+        $scope.purposeAddonsList = function () {
+            var defaultOptions = ['No Change', 'None (Clear)'];
+            if ($scope.organization.system_purposes && $scope.organization.system_purposes.addons) {
+                return defaultOptions.concat($scope.organization.system_purposes.addons);
+            }
+            return [];
+        };
+
+        $scope.defaultUsages = ['No change', 'None (Clear)', 'Production', 'Development/Test', 'Disaster Recovery'];
+        $scope.defaultRoles = ['No change', 'None (Clear)', 'Red Hat Enterprise Linux Server', 'Red Hat Enterprise Linux Workstation', 'Red Hat Enterprise Linux Compute Node'];
+        $scope.defaultServiceLevels = ['No change', 'None (Clear)', 'Self-Support', 'Standard', 'Premium'];
+
+        $scope.hostCount = hostIds.included.ids.length;
+
+        $scope.selectedUsages = $scope.defaultUsages[0];
+        $scope.selectedRoles = $scope.defaultRoles[0];
+        $scope.selectedServiceLevels = $scope.defaultServiceLevels[0];
+
+        $scope.selected = {
+           addons: undefined
+        };
+
+        $scope.selectedItemToParam = function (item) {
+            var mapping = {
+                "None (Clear)": "",
+                "No change": null,
+                "": []
+            };
+            if (Array.isArray(item)) {
+                return $scope.selectedAddonsToParam(item);
+            }
+            if (mapping.hasOwnProperty(item)) {
+                return mapping[item];
+            }
+            return item;
+        };
+
+        $scope.selectedAddonsToParam = function (addons) {
+            var intentOptions = ['No Change', 'None (Clear)'];
+
+            var userIntent = intentOptions.filter(function(val) {
+                return addons.indexOf(val) !== -1;
+            });
+
+            if (userIntent.length === 0) {
+                return addons;
+            }
+
+            if (userIntent.includes('No Change')) {
+                return null;
+            }
+
+            if (userIntent.includes('None (Clear)') && addons.length === 1) {
+                return [];
+            } if (userIntent.includes('None (Clear)') && addons.length > 1) {
+                addons.shift();
+                return addons;
+            }
+        };
+
+        function actionParams() {
+            var params = hostIds;
+
+            params['purpose_usage'] = $scope.selectedItemToParam($scope.selectedUsages);
+            params['purpose_role'] = $scope.selectedItemToParam($scope.selectedRoles);
+            params['purpose_addons'] = $scope.selectedItemToParam($scope.selectedAddons);
+            params['service_level'] = $scope.selectedItemToParam($scope.selectedServiceLevels);
+
+            return params;
+        }
+
+        $scope.performAction = function () {
+            HostBulkAction.systemPurpose(actionParams(), function (task) {
+            $scope.ok();
+            $scope.transitionTo('content-hosts.bulk-task', {taskId: task.id});
+        }, function (response) {
+            angular.forEach(response.data.errors, function (error) {
+                Notification.setErrorMessage(error);
+            });
+        });
+        };
+
+        $scope.ok = function () {
+            $uibModalInstance.close();
+        };
+
+        $scope.cancel = function () {
+            $uibModalInstance.dismiss('cancel');
+        };
+    }]
+);

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/views/content-hosts-bulk-system-purpose-modal.html

@@ -0,0 +1,78 @@
+<div data-extend-template="components/views/bst-modal.html">
+  <h4 data-block="modal-header" translate>Content Host System Purpose</h4>
+
+  <div data-block="modal-body">
+    <h4 translate>Assign System Purpose:</h4>
+
+    <div class="row">
+      <div class="col-sm-12">
+        <div bst-global-notification></div>
+      </div>
+    </div>
+
+    <form name="contentHostContentForm" class="form" ng-hide="content.workingMode">
+      <div>
+        <label translate>Service Level:</label>
+
+        <select type="select"
+                ng-options="item for item in defaultServiceLevels"
+                ng-model="selectedServiceLevels">
+        </select>
+      <br /><br />
+
+        <label translate>Usage Type:</label>
+
+        <select type="select"
+                ng-options="item for item in defaultUsages"
+                ng-model="selectedRoles">
+        </select>
+        <br /><br />
+
+        <label translate>Role:</label>
+
+        <select type="select"
+                ng-options="item for item in defaultRoles"
+                ng-model="selectedUsages">
+        </select>
+        <br /><br />
+
+        <label ng-hide="!purposeAddonsList().length" translate>Add ons:</label>
+        <div class="help-block" style="text-align:left;">
+          <p translate>ctrl-click or shift-click to select multiple Add ons</p>
+        </div>
+
+        <select multiple ng-multiple="true"
+                ng-hide="!purposeAddonsList().length"
+                ng-options="item for item in purposeAddonsList()"
+                ng-model="selectedAddons">
+        </select>
+        <br /><br />
+
+      </div>
+
+      <div bst-alert="info" ng-show="showConfirm">
+        <span translate>
+          Set System Purpose values on {{ hostCount }} selected content hosts?
+        </span>
+        <div>
+          <br />
+          <button type="button" class="btn btn-primary" ng-click="showConfirm = false; performAction()" translate>Assign</button>
+        </div>
+      </div>
+
+      <button class="btn btn-primary"
+              type="button"
+              ng-hide="showConfirm"
+              ng-click="showConfirm = true;">
+        <span translate>Assign</span>
+      </button>
+
+    </form>
+  </div>
+
+  <div data-block="modal-footer">
+    <button type="button" class="btn btn-default" ng-click="cancel()" translate>
+      Cancel
+    </button>
+  </div>
+</div>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/content/content-host-debs-installed.controller.js

@@ -8,40 +8,15 @@
  * @requires HostDeb
  * @requires translate
  * @requires Nutupane
- * @requires Notification
  *
  * @description
  *   Provides the functionality for the content host deb packages list and actions.
  */
 angular.module('Bastion.content-hosts').controller('ContentHostDebsInstalledController',
-    ['$scope', '$timeout', '$window', 'HostDeb', 'translate', 'Nutupane', 'BastionConfig', 'Notification',
-    function ($scope, $timeout, $window, HostDeb, translate, Nutupane, BastionConfig, Notification) {
+    ['$scope', '$timeout', '$window', 'HostDeb', 'translate', 'Nutupane',
+    function ($scope, $timeout, $window, HostDeb, translate, Nutupane) {
         var debsNutupane;
 
-        $scope.openEventInfo = function (event) {
-            // when the event has label defined, it means it comes
-            // from foreman-tasks
-            if (event.label) {
-                $scope.transitionTo('content-host.tasks.details', {taskId: event.id});
-            } else {
-                $scope.transitionTo('content-host.events.details', {eventId: event.id});
-            }
-            $scope.working = false;
-        };
-
-        $scope.errorHandler = function (response) {
-            angular.forEach(response.data.errors, function (responseError) {
-                Notification.setErrorMessage(responseError);
-            });
-            $scope.working = false;
-        };
-
-        $scope.working = false;
-        $scope.remoteExecutionPresent = BastionConfig.remoteExecutionPresent;
-        $scope.packageActionFormValues = {
-            authenticityToken: $window.AUTH_TOKEN.replace(/"/g, '')
-        };
-
         $scope.removeSelectedDebs = function () {
             var selected;
 
@@ -54,21 +29,6 @@ angular.module('Bastion.content-hosts').controller('ContentHostDebsInstalledCont
             }
         };
 
-        $scope.performPackageAction = function (actionType, term) {
-            $scope.performViaRemoteExecution(actionType, term, false);
-        };
-
-        $scope.performViaRemoteExecution = function (actionType, term, customize) {
-            $scope.packageActionFormValues.package = term;
-            $scope.packageActionFormValues.remoteAction = actionType;
-            $scope.packageActionFormValues.hostIds = $scope.host.id;
-            $scope.packageActionFormValues.customize = customize;
-
-            $timeout(function () {
-                angular.element('#packageActionForm').submit();
-            }, 0);
-        };
-
         debsNutupane = new Nutupane(HostDeb, {id: $scope.$stateParams.hostId});
         debsNutupane.primaryOnly = true;
         $scope.table = debsNutupane.table;

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/content-host-modal-helper.service.js

@@ -91,6 +91,17 @@ angular.module('Bastion.content-hosts').service('ContentHostsModalHelper', ['$ui
             });
         };
 
+        this.openSystemPurposeModal = function() {
+            $uibModal.open({
+                templateUrl: 'content-hosts/bulk/views/content-hosts-bulk-system-purpose-modal.html',
+                controller: 'ContentHostsBulkSystemPurposeModalController',
+                size: 'lg',
+                resolve: {
+                    hostIds: this.resolveFunc()
+                }
+            });
+        };
+
         this.openModuleStreamsModal = function() {
             $uibModal.open({
                 templateUrl: 'content-hosts/bulk/views/content-host-bulk-module-streams-modal.html',

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/content-hosts.controller.js

@@ -160,6 +160,11 @@ angular.module('Bastion.content-hosts').controller('ContentHostsController',
             ContentHostsModalHelper.openModuleStreamsModal();
         };
 
+        $scope.openSystemPurposeModal = function () {
+            nutupane.invalidate();
+            ContentHostsModalHelper.openSystemPurposeModal();
+        };
+
         $scope.openTracesModal = function () {
             nutupane.invalidate();
             ContentHostsModalHelper.openTracesModal();

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/views/content-hosts.html

@@ -51,6 +51,10 @@
           <a ng-click="openModuleStreamsModal()" disable-link="table.numSelected === 0" translate>Manage Module Streams</a>
         </li>
 
+        <li role="menuitem" ng-show="permitted('edit_hosts')" ng-class="{disabled: table.numSelected === 0}">
+          <a ng-click="openSystemPurposeModal()" disable-link="table.numSelected === 0" translate>Manage System Purpose</a>
+        </li>
+
         <li role="menuitem" ng-show="permitted('edit_hosts')" ng-class="{disabled: table.numSelected === 0}">
           <a ng-click="openTracesModal()" disable-link="table.numSelected === 0" translate>Manage Host Traces</a>
         </li>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/views/register-client.html

@@ -12,7 +12,7 @@
   <section>
     <p bst-alert="warning" >
     <span translate>
-      Katello-agent is deprecated and will be removed in a future release.
+      Katello-agent is deprecated and will be removed in Katello 4.0.  Consider migrating to Remote Execution.
     </span>
     </p>
   </section>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/host-collections/details/host-collection-details.controller.js

@@ -77,6 +77,10 @@ angular.module('Bastion.host-collections').controller('HostCollectionDetailsCont
             ContentHostsModalHelper.openSubscriptionsModal();
         };
 
+        $scope.openSystemPurposeModal = function () {
+            ContentHostsModalHelper.openSystemPurposeModal();
+        };
+
         $scope.openModuleStreamsModal = function () {
             ContentHostsModalHelper.openModuleStreamsModal();
         };

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/host-collections/details/views/host-collection-info.html

@@ -100,6 +100,12 @@
           </a>
         </li>
 
+        <li>
+          <a translate ng-click="openSystemPurposeModal()">
+            System Purpose Management
+          </a>
+        </li>
+
         <li bst-feature-flag="lifecycle_environments">
           <a translate ng-click="openEnvironmentModal()">
             Change assigned Lifecycle Environment or Content View

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/hosts/host-bulk-action.factory.js

@@ -27,7 +27,8 @@ angular.module('Bastion.hosts').factory('HostBulkAction',
             availableIncrementalUpdates: {method: 'POST', isArray: true, params: {action: 'available_incremental_updates'}},
             moduleStreams: {method: 'POST', params: {action: 'module_streams'}},
             traces: {method: 'POST', params: {action: 'traces'}},
-            resolveTraces: {method: 'PUT', isArray: true, params: {action: 'resolve_traces'}}
+            resolveTraces: {method: 'PUT', isArray: true, params: {action: 'resolve_traces'}},
+            systemPurpose: {method: 'PUT', params: {action: 'system_purpose'}}
         });
 
     }]

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/i18n/bastion_katello.pot

@@ -273,6 +273,7 @@ msgstr ""
 msgid "* These marked Content View Versions are from Composite Content Views.  Their components needing updating are listed underneath."
 msgstr ""
 
+#: app/assets/javascripts/bastion_katello/products/bulk/products-bulk-advanced-sync-modal.controller.js
 #: app/assets/javascripts/bastion_katello/products/products.controller.js
 msgid "/foreman_tasks/tasks/%taskId"
 msgstr ""
@@ -1311,6 +1312,7 @@ msgstr ""
 msgid "Click to monitor task progress."
 msgstr ""
 
+#: app/assets/javascripts/bastion_katello/products/bulk/products-bulk-advanced-sync-modal.controller.js
 #: app/assets/javascripts/bastion_katello/products/bulk/products-bulk-http-proxy-modal.controller.js
 #: app/assets/javascripts/bastion_katello/products/details/product-repositories.controller.js
 #: app/assets/javascripts/bastion_katello/products/products.controller.js
@@ -2083,11 +2085,6 @@ msgstr ""
 msgid "Enable"
 msgstr ""
 
-#: app/assets/javascripts/bastion_katello/products/details/repositories/details/views/repository-info.html
-#: app/assets/javascripts/bastion_katello/products/details/repositories/new/views/new-repository.html
-msgid "Enable on Registration"
-msgstr ""
-
 #: app/assets/javascripts/bastion_katello/content-hosts/content/views/content-host-traces.html
 #: app/assets/javascripts/bastion_katello/content-hosts/details/views/content-host-info.html
 msgid "Enable Traces"
@@ -2756,7 +2753,7 @@ msgstr ""
 
 #: app/assets/javascripts/bastion_katello/common/views/katello-agent-notice.html
 #: app/assets/javascripts/bastion_katello/content-hosts/views/register-client.html
-msgid "Katello-agent is deprecated and will be removed in a future release."
+msgid "Katello-agent is deprecated and will be removed in Katello 4.0.  Consider migrating to Remote Execution."
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/content-views/details/views/content-view-info.html
@@ -3238,7 +3235,7 @@ msgid "Name"
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/products/details/repositories/new/views/new-repository.html
-msgid "Name of the upstream repository you want to sync. Example: 'busybox' or 'fedora/ssh'."
+msgid "Name of the upstream repository you want to sync. Example: 'quay/busybox' or 'fedora/ssh'."
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/content-hosts/details/views/content-host-info.html
@@ -3937,7 +3934,11 @@ msgid "Product sync has been initiated in the background."
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/products/bulk/products-bulk-advanced-sync-modal.controller.js
-msgid "Product syncs has been initiated in the background. Click %s to monitor the progress."
+msgid "Product syncs has been initiated in the background."
+msgstr ""
+
+#: app/assets/javascripts/bastion_katello/products/products.controller.js
+msgid "Product verify checksum has been initiated in the background."
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/content-credentials/details/views/content-credential-details.html
@@ -4771,10 +4772,6 @@ msgstr ""
 msgid "Selecting \"Complete Sync\" will cause only Yum repositories of the selected product to be synced. Selecting \"Validate Content\" will cause only Yum repositories using the \"Immediate\" or \"Background\" download policies will be synced."
 msgstr ""
 
-#: app/assets/javascripts/bastion_katello/products/details/repositories/new/views/new-repository.html
-msgid "Selecting this option will automatically enable this Repository when a Host registers and consumes this subscription."
-msgstr ""
-
 #: app/assets/javascripts/bastion_katello/products/details/repositories/new/views/new-repository.html
 msgid "Selecting this option will result in contents that are no longer part of the upstream repository being removed during synchronization."
 msgstr ""
@@ -5456,7 +5453,7 @@ msgid ""
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/subscriptions/views/content-access-mode-banner.html
-msgid "This organization has Simple Content Access enabled. Hosts can consume from all repositories in their Content View regardless of subscription status."
+msgid "This organization has Simple Content Access enabled.  Hosts are not required to have subscriptions attached to access repositories."
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/content-views/deletion/views/version-deletion-environments.html
@@ -5737,7 +5734,7 @@ msgid "Url"
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/products/details/repositories/new/views/new-repository.html
-msgid "URL of the registry you want to sync. Example: https://registry-1.docker.io/"
+msgid "URL of the registry you want to sync. Example: https://registry-1.docker.io/ or https://quay.io/"
 msgstr ""
 
 #: app/assets/javascripts/bastion_katello/products/discovery/views/discovery.html
@@ -5798,6 +5795,11 @@ msgstr ""
 msgid "Variant"
 msgstr ""
 
+#: app/assets/javascripts/bastion_katello/products/details/repositories/details/views/repository-details.html
+#: app/assets/javascripts/bastion_katello/products/views/products.html
+msgid "Verify Content Checksum"
+msgstr ""
+
 #: app/assets/javascripts/bastion_katello/products/details/repositories/details/views/repository-info.html
 #: app/assets/javascripts/bastion_katello/products/details/repositories/new/views/new-repository.html
 #: app/assets/javascripts/bastion_katello/products/discovery/views/discovery-create.html

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/products/bulk/products-bulk-advanced-sync-modal.controller.js

@@ -21,13 +21,12 @@ angular.module('Bastion.products').controller('ProductsBulkAdvancedSyncModalCont
             var success, error;
 
             success = function (task) {
-                var url, message, taskLink;
-                url = $state.href('task', {taskId: task.id});
-                taskLink = $sce.trustAsHtml("<a href=" + url + ">here</a>");
-                message = translate("Product syncs has been initiated in the background. " +
-                    "Click %s to monitor the progress.");
-
-                Notification.setSuccessMessage(message.replace('%s', taskLink));
+                var message = translate("Product syncs has been initiated in the background.");
+                Notification.setSuccessMessage(message, {
+                link: {
+                    children: translate("Click to view task"),
+                    href: translate("/foreman_tasks/tasks/%taskId").replace('%taskId', task.id)
+                }});
             };
 
             error = function (response) {