jira-ruby 1.5.0 → 1.6.0

data/spec/integration/resolution_spec.rb

@@ -1,29 +1,26 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Resolution do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "1" }
+    let(:key) { '1' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://www.example.com/jira/rest/api/2/resolution/1",
+        'self' => 'http://www.example.com/jira/rest/api/2/resolution/1',
         'id' => key,
         'name' => 'Fixed',
-        'description' => 'A fix for this issue is checked into the tree and tested.', 
+        'description' => 'A fix for this issue is checked into the tree and tested.',
         'iconUrl' => 'http://www.example.com/jira/images/icons/status_resolved.gif'
       }
     end
 
     let(:expected_collection_length) { 2 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
   end
-end
+end

data/spec/integration/status_spec.rb

@@ -1,17 +1,15 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Status do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "1" }
+    let(:key) { '1' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/status/1",
+        'self' => 'http://localhost:2990/jira/rest/api/2/status/1',
         'id' => key,
         'name' => 'Open'
       }
@@ -19,9 +17,8 @@ describe JIRA::Resource::Status do
 
     let(:expected_collection_length) { 5 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
   end
 end

data/spec/integration/transition_spec.rb

@@ -1,24 +1,23 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Transition do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
     let(:key) { '10000' }
 
-    let(:target) { JIRA::Resource::Transition.new(client, :attrs => {'id' => '99999'}, :issue_id => '10014') }
+    let(:target) { JIRA::Resource::Transition.new(client, attrs: { 'id' => '99999' }, issue_id: '10014') }
 
-    let(:belongs_to) {
-      JIRA::Resource::Issue.new(client, :attrs => {
-        'id' => '10002',
-        'self' => "#{site_url}/jira/rest/api/2/issue/10002",
-        'fields' => {
-          'comment' => {'comments' => []}
-        }
-      })
-    }
+    let(:belongs_to) do
+      JIRA::Resource::Issue.new(client, attrs: {
+                                  'id' => '10002',
+                                  'self' => "#{site_url}/jira/rest/api/2/issue/10002",
+                                  'fields' => {
+                                    'comment' => { 'comments' => [] }
+                                  }
+                                })
+    end
 
     let(:expected_attributes) do
       {
@@ -27,26 +26,24 @@ describe JIRA::Resource::Transition do
       }
     end
 
-    let(:attributes_for_post) {
+    let(:attributes_for_post) do
       {
         'transition' => {
           'id' => '42'
         }
       }
-    }
+    end
 
-    it_should_behave_like "a resource"
+    it_should_behave_like 'a resource'
 
-    describe "POST endpoint" do
-      it "saves a new resource" do
+    describe 'POST endpoint' do
+      it 'saves a new resource' do
         stub_request(:post, /#{described_class.collection_path(client, prefix)}$/)
-          .with(:body => attributes_for_post.to_json)
-          .to_return(:status => 200, :body => get_mock_from_path(:post))
+          .with(body: attributes_for_post.to_json)
+          .to_return(status: 200, body: get_mock_from_path(:post))
         subject = build_receiver.build
         expect(subject.save(attributes_for_post)).to be_truthy
       end
     end
-
   end
-
 end

data/spec/integration/user_spec.rb

@@ -1,25 +1,41 @@
 require 'spec_helper'
 
 describe JIRA::Resource::User do
-
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "admin" }
+    let(:key) { 'admin' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/user?username=admin",
+        'self' => 'http://localhost:2990/jira/rest/api/2/user?username=admin',
         'name' => key,
         'emailAddress' => 'admin@example.com'
       }
     end
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a singular GET endpoint'
+
+    describe '#all' do
+      let(:client) do
+        client = double(options: { rest_base_path: '/jira/rest/api/2' })
+        allow(client).to receive(:get).with('/rest/api/2/user/search?username=_&maxResults=1000').and_return(JIRA::Resource::UserFactory.new(client))
+        client
+      end
+
+      before do
+        allow(client).to receive(:get)
+          .with('/rest/api/2/user/search?username=_&maxResults=1000') { OpenStruct.new(body: '["User1"]') }
+        allow(client).to receive_message_chain(:User, :build).with('users') { [] }
+      end
+
+      it 'gets users with maxResults of 1000' do
+        expect(client).to receive(:get).with('/rest/api/2/user/search?username=_&maxResults=1000')
+        expect(client).to receive_message_chain(:User, :build).with('User1')
+        JIRA::Resource::User.all(client)
+      end
+    end
   end
 end

data/spec/integration/version_spec.rb

@@ -1,43 +1,39 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Version do
-
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "10000" }
+    let(:key) { '10000' }
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/version/10000",
+        'self' => 'http://localhost:2990/jira/rest/api/2/version/10000',
         'id'   => key,
-        'description' => "Initial version"
+        'description' => 'Initial version'
       }
     end
 
-    let(:attributes_for_post) {
-      {"name" => "2.0", "project" => "SAMPLEPROJECT" }
-    }
-    let(:expected_attributes_from_post) {
-      { "id" => "10001", "name" => "2.0" }
-    }
-
-    let(:attributes_for_put) {
-      {"name" => "2.0.0" }
-    }
-    let(:expected_attributes_from_put) {
-      { "id" => "10000", "name" => "2.0.0" }
-    }
+    let(:attributes_for_post) do
+      { 'name' => '2.0', 'project' => 'SAMPLEPROJECT' }
+    end
+    let(:expected_attributes_from_post) do
+      { 'id' => '10001', 'name' => '2.0' }
+    end
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a singular GET endpoint"
-    it_should_behave_like "a resource with a DELETE endpoint"
-    it_should_behave_like "a resource with a POST endpoint"
-    it_should_behave_like "a resource with a PUT endpoint"
-    it_should_behave_like "a resource with a PUT endpoint that rejects invalid fields"
+    let(:attributes_for_put) do
+      { 'name' => '2.0.0' }
+    end
+    let(:expected_attributes_from_put) do
+      { 'id' => '10000', 'name' => '2.0.0' }
+    end
 
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a singular GET endpoint'
+    it_should_behave_like 'a resource with a DELETE endpoint'
+    it_should_behave_like 'a resource with a POST endpoint'
+    it_should_behave_like 'a resource with a PUT endpoint'
+    it_should_behave_like 'a resource with a PUT endpoint that rejects invalid fields'
   end
 end

data/spec/integration/watcher_spec.rb

@@ -1,59 +1,53 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Watcher do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
+    let(:target) { JIRA::Resource::Watcher.new(client, attrs: { 'id' => '99999' }, issue_id: '10002') }
 
-    let(:target) { JIRA::Resource::Watcher.new(client, :attrs => {'id' => '99999'}, :issue_id => '10002') }
-
-    let(:belongs_to) {
-      JIRA::Resource::Issue.new(client, :attrs => {
-        'id' => '10002',
-        'fields' => {
-          'comment' => {'comments' => []}
-        }
-      })
-    }
+    let(:belongs_to) do
+      JIRA::Resource::Issue.new(client, attrs: {
+                                  'id' => '10002',
+                                  'fields' => {
+                                    'comment' => { 'comments' => [] }
+                                  }
+                                })
+    end
 
     let(:expected_attributes) do
       {
-        "self" => "http://localhost:2990/jira/rest/api/2/issue/10002/watchers",
+        'self' => 'http://localhost:2990/jira/rest/api/2/issue/10002/watchers',
         "isWatching": false,
         "watchCount": 1,
         "watchers": [
-            {
-                "self": "http://www.example.com/jira/rest/api/2/user?username=admin",
-                "name": "admin",
-                "displayName": "admin",
-                "active": false
-            }
+          {
+            "self": 'http://www.example.com/jira/rest/api/2/user?username=admin',
+            "name": 'admin',
+            "displayName": 'admin',
+            "active": false
+          }
         ]
       }
     end
 
-    describe "watchers" do
-      it "should returns all the watchers" do
-
-       stub_request(:get,
-                    site_url + "/jira/rest/api/2/issue/10002").
-                    to_return(:status => 200, :body => get_mock_response('issue/10002.json'))
+    describe 'watchers' do
+      it 'should returns all the watchers' do
+        stub_request(:get,
+                     site_url + '/jira/rest/api/2/issue/10002')
+          .to_return(status: 200, body: get_mock_response('issue/10002.json'))
 
-       stub_request(:get,
-                    site_url + "/jira/rest/api/2/issue/10002/watchers").
-                    to_return(:status => 200, :body => get_mock_response('issue/10002/watchers.json'))
+        stub_request(:get,
+                     site_url + '/jira/rest/api/2/issue/10002/watchers')
+          .to_return(status: 200, body: get_mock_response('issue/10002/watchers.json'))
 
-          issue = client.Issue.find("10002")
-          watchers = client.Watcher.all(options = {:issue => issue})
-          expect(watchers.length).to eq(1)
+        issue = client.Issue.find('10002')
+        watchers = client.Watcher.all(options = { issue: issue })
+        expect(watchers.length).to eq(1)
       end
-
     end
 
-    it_should_behave_like "a resource"
-
+    it_should_behave_like 'a resource'
   end
-
 end

data/spec/integration/webhook.rb

@@ -1,34 +1,25 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Webhook do
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
-
-    let(:key) { "2" }
+    let(:key) { '2' }
 
     let(:expected_attributes) do
-     {"name"=>"from API", "url"=>"http://localhost:3000/webhooks/1", "excludeBody"=>false, "filters"=>{"issue-related-events-section"=>""}, "events"=>[], "enabled"=>true, "self"=>"http://localhost:2990/jira/rest/webhooks/1.0/webhook/2", "lastUpdatedUser"=>"admin", "lastUpdatedDisplayName"=>"admin", "lastUpdated"=>1453306520188}
+      { 'name' => 'from API', 'url' => 'http://localhost:3000/webhooks/1', 'excludeBody' => false, 'filters' => { 'issue-related-events-section' => '' }, 'events' => [], 'enabled' => true, 'self' => 'http://localhost:2990/jira/rest/webhooks/1.0/webhook/2', 'lastUpdatedUser' => 'admin', 'lastUpdatedDisplayName' => 'admin', 'lastUpdated' => 1_453_306_520_188 }
     end
 
     let(:expected_collection_length) { 1 }
 
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-
-    
-
-    it "returns a collection of components" do
-
-      stub_request(:get, site_url + described_class.singular_path(client, key)).
-        to_return(:status => 200, :body => get_mock_response('webhook/webhook.json'))
-
-
-      
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
 
+    it 'returns a collection of components' do
+      stub_request(:get, site_url + described_class.singular_path(client, key))
+        .to_return(status: 200, body: get_mock_response('webhook/webhook.json'))
     end
   end
 end

data/spec/integration/worklog_spec.rb

@@ -1,55 +1,51 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Worklog do
-
-
   with_each_client do |site_url, client|
     let(:client) { client }
     let(:site_url) { site_url }
 
+    let(:key) { '10000' }
 
-    let(:key) { "10000" }
-
-    let(:target) { JIRA::Resource::Worklog.new(client, :attrs => {'id' => '99999'}, :issue_id => '54321') }
+    let(:target) { JIRA::Resource::Worklog.new(client, attrs: { 'id' => '99999' }, issue_id: '54321') }
 
     let(:expected_collection_length) { 3 }
 
-    let(:belongs_to) {
-      JIRA::Resource::Issue.new(client, :attrs => {
-        'id' => '10002', 'fields' => {
-          'comment' => {'comments' => []}
-        }
-      })
-    }
+    let(:belongs_to) do
+      JIRA::Resource::Issue.new(client, attrs: {
+                                  'id' => '10002', 'fields' => {
+                                    'comment' => { 'comments' => [] }
+                                  }
+                                })
+    end
 
     let(:expected_attributes) do
       {
-        'self' => "http://localhost:2990/jira/rest/api/2/issue/10002/worklog/10000",
+        'self' => 'http://localhost:2990/jira/rest/api/2/issue/10002/worklog/10000',
         'id'   => key,
-        'comment' => "Some epic work."
+        'comment' => 'Some epic work.'
       }
     end
 
-    let(:attributes_for_post) {
-      {"timeSpent" => "2d"}
-    }
-    let(:expected_attributes_from_post) {
-      { "id" => "10001", "timeSpent" => "2d"}
-    }
-
-    let(:attributes_for_put) {
-      {"timeSpent" => "2d"}
-    }
-    let(:expected_attributes_from_put) {
-      { "id" => "10001", "timeSpent" => "4d"}
-    }
-
-    it_should_behave_like "a resource"
-    it_should_behave_like "a resource with a collection GET endpoint"
-    it_should_behave_like "a resource with a singular GET endpoint"
-    it_should_behave_like "a resource with a DELETE endpoint"
-    it_should_behave_like "a resource with a POST endpoint"
-    it_should_behave_like "a resource with a PUT endpoint"
+    let(:attributes_for_post) do
+      { 'timeSpent' => '2d' }
+    end
+    let(:expected_attributes_from_post) do
+      { 'id' => '10001', 'timeSpent' => '2d' }
+    end
+
+    let(:attributes_for_put) do
+      { 'timeSpent' => '2d' }
+    end
+    let(:expected_attributes_from_put) do
+      { 'id' => '10001', 'timeSpent' => '4d' }
+    end
 
+    it_should_behave_like 'a resource'
+    it_should_behave_like 'a resource with a collection GET endpoint'
+    it_should_behave_like 'a resource with a singular GET endpoint'
+    it_should_behave_like 'a resource with a DELETE endpoint'
+    it_should_behave_like 'a resource with a POST endpoint'
+    it_should_behave_like 'a resource with a PUT endpoint'
   end
 end