jira-ruby 1.5.0 → 1.6.0

data/spec/jira/resource/createmeta_spec.rb

@@ -1,21 +1,21 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Createmeta do
-  let(:client) {
+  let(:client) do
     double(
       'client',
-      :options => {
-        :rest_base_path => '/jira/rest/api/2'
+      options: {
+        rest_base_path: '/jira/rest/api/2'
       }
     )
-  }
+  end
 
-  let(:response) {
+  let(:response) do
     double(
       'response',
-      :body => '{"expand":"projects","projects":[{"self":"http://localhost:2029/rest/api/2/project/TST","id":"10200","key":"test_key","name":"Test Name"}]}'
+      body: '{"expand":"projects","projects":[{"self":"http://localhost:2029/rest/api/2/project/TST","id":"10200","key":"test_key","name":"Test Name"}]}'
     )
-  }
+  end
 
   describe 'general' do
     it 'should query correct url without parameters' do
@@ -25,12 +25,12 @@ describe JIRA::Resource::Createmeta do
 
     it 'should query correct url with `expand` parameter' do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?expand=projects.issuetypes.fields').and_return(response)
-      JIRA::Resource::Createmeta.all(client, :expand => 'projects.issuetypes.fields')
+      JIRA::Resource::Createmeta.all(client, expand: 'projects.issuetypes.fields')
     end
 
     it 'should query correct url with `foo` parameter' do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?foo=bar').and_return(response)
-      JIRA::Resource::Createmeta.all(client, :foo => 'bar')
+      JIRA::Resource::Createmeta.all(client, foo: 'bar')
     end
 
     it 'should return an array of createmeta objects' do
@@ -49,7 +49,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectKeys=PROJECT_1').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectKeys => 'PROJECT_1',
+        projectKeys: 'PROJECT_1'
       )
     end
 
@@ -57,7 +57,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectKeys=PROJECT_1%2CPROJECT_2').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectKeys => ['PROJECT_1', 'PROJECT_2'],
+        projectKeys: %w[PROJECT_1 PROJECT_2]
       )
     end
 
@@ -68,7 +68,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectKeys=PRJ').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectKeys => prj,
+        projectKeys: prj
       )
     end
 
@@ -81,7 +81,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectKeys=PRJ_2%2CPRJ_1').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectKeys => [prj_2, prj_1],
+        projectKeys: [prj_2, prj_1]
       )
     end
 
@@ -92,18 +92,17 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectKeys=PROJECT_1%2CPRJ_5').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectKeys => ['PROJECT_1', prj_5],
+        projectKeys: ['PROJECT_1', prj_5]
       )
     end
   end
 
-
   describe 'projectIds' do
     it 'should query correct url when only one `projectIds` given as string' do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectIds=10101').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectIds => '10101',
+        projectIds: '10101'
       )
     end
 
@@ -111,7 +110,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectIds=10101%2C20202').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectIds => ['10101', '20202'],
+        projectIds: %w[10101 20202]
       )
     end
 
@@ -122,7 +121,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectIds=30303').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectIds => prj,
+        projectIds: prj
       )
     end
 
@@ -135,7 +134,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectIds=50505%2C30303').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectIds => [prj_2, prj_1],
+        projectIds: [prj_2, prj_1]
       )
     end
 
@@ -146,18 +145,17 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?projectIds=10101%2C60606').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :projectIds => ['10101', prj_5],
+        projectIds: ['10101', prj_5]
       )
     end
   end
 
-
   describe 'issuetypeNames' do
     it 'should query correct url when only one `issuetypeNames` given as string' do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeNames=Feature').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeNames => 'Feature',
+        issuetypeNames: 'Feature'
       )
     end
 
@@ -165,7 +163,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeNames=Feature%2CBug').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeNames => ['Feature', 'Bug'],
+        issuetypeNames: %w[Feature Bug]
       )
     end
 
@@ -176,7 +174,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeNames=Epic').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeNames => issue_type,
+        issuetypeNames: issue_type
       )
     end
 
@@ -189,7 +187,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeNames=Sub-Task%2CEpic').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeNames => [issue_type_2, issue_type_1],
+        issuetypeNames: [issue_type_2, issue_type_1]
       )
     end
 
@@ -200,18 +198,17 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeNames=Feature%2CEpic').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeNames => ['Feature', issue_type],
+        issuetypeNames: ['Feature', issue_type]
       )
     end
   end
 
-
   describe 'issuetypeIds' do
     it 'should query correct url when only one `issuetypeIds` given as string' do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeIds=10101').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeIds => '10101',
+        issuetypeIds: '10101'
       )
     end
 
@@ -219,7 +216,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeIds=10101%2C20202').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeIds => ['10101', '20202'],
+        issuetypeIds: %w[10101 20202]
       )
     end
 
@@ -230,7 +227,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeIds=30303').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeIds => issue_type,
+        issuetypeIds: issue_type
       )
     end
 
@@ -243,7 +240,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeIds=50505%2C30303').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeIds => [issue_type_2, issue_type_1],
+        issuetypeIds: [issue_type_2, issue_type_1]
       )
     end
 
@@ -254,7 +251,7 @@ describe JIRA::Resource::Createmeta do
       expect(client).to receive(:get).with('/jira/rest/api/2/issue/createmeta?issuetypeIds=10101%2C30303').and_return(response)
       JIRA::Resource::Createmeta.all(
         client,
-        :issuetypeIds => ['10101', issue_type],
+        issuetypeIds: ['10101', issue_type]
       )
     end
   end

data/spec/jira/resource/field_spec.rb

@@ -1,91 +1,85 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Field do
-
   let(:cache) { OpenStruct.new }
 
   let(:client) do
-    client = double(options: {rest_base_path: '/jira/rest/api/2'}  )
+    client = double(options: { rest_base_path: '/jira/rest/api/2' })
     field = JIRA::Resource::FieldFactory.new(client)
     allow(client).to receive(:Field).and_return(field)
     allow(client).to receive(:cache).and_return(cache)
     # info about all fields on the client
     allow(client.Field).to receive(:all).and_return([
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"customfield_10666", "name" => "Priority",   "custom" => true,  "orderable" => true,  "navigable" => true, "searchable" => true,  "clauseNames" => ["cf[10666]","Priority"],         "schema" =>{"type" => "string",    "custom" => "com.atlassian.jira.plugin.system.customfieldtypes:select","customId" => 10666}}),
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"issuekey",          "name" => "Key",        "custom" => false, "orderable" => false, "navigable" => true, "searchable" => false, "clauseNames" => ["id","issue","issuekey","key"]}),
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"priority",          "name" => "Priority",   "custom" => false, "orderable" => true,  "navigable" => true, "searchable" => true,  "clauseNames" => ["priority"],                     "schema" =>{"type" => "priority",  "system" => "priority"}}),
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"summary",           "name" => "Summary",    "custom" => false, "orderable" => true,  "navigable" => true, "searchable" => true,  "clauseNames" => ["summary"],                      "schema" =>{"type" => "string",    "system" => "summary"}}),
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"issuetype",         "name" => "Issue Type", "custom" => false, "orderable" => true,  "navigable" => true, "searchable" => true,  "clauseNames" => ["issuetype","type"],             "schema" =>{"type" => "issuetype", "system" => "issuetype"}}),
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"customfield_10111", "name" => "SingleWord", "custom" => true,  "orderable" => true,  "navigable" => true, "searchable" => true,  "clauseNames" => ["cf[10111]","SingleWord"],       "schema" =>{"type" => "string",    "custom" => "com.atlassian.jira.plugin.system.customfieldtypes:select","customId" => 10111}}),
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"customfield_10222", "name" => "Multi Word", "custom" => true,  "orderable" => true,  "navigable" => true, "searchable" => true,  "clauseNames" => ["cf[10222]","Multi Word"],       "schema" =>{"type" => "string",    "custom" => "com.atlassian.jira.plugin.system.customfieldtypes:select","customId" => 10222}}),
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"customfield_10333", "name" => "Why/N@t",    "custom" => true,  "orderable" => true,  "navigable" => true, "searchable" => true,  "clauseNames" => ["cf[10333]","Why/N@t"],          "schema" =>{"type" => "string",    "custom" => "com.atlassian.jira.plugin.system.customfieldtypes:select","customId" => 10333}}),
-      JIRA::Resource::Field.new(client, :attrs => {'id' =>"customfield_10444", "name" => "SingleWord", "custom" => true,  "orderable" => true,  "navigable" => true, "searchable" => true,  "clauseNames" => ["cf[10444]","SingleWord"],       "schema" =>{"type" => "string",    "custom" => "com.atlassian.jira.plugin.system.customfieldtypes:select","customId" => 10444}})
-    ])
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'customfield_10666', 'name' => 'Priority', 'custom' => true, 'orderable' => true, 'navigable' => true, 'searchable' => true, 'clauseNames' => ['cf[10666]', 'Priority'], 'schema' => { 'type' => 'string', 'custom' => 'com.atlassian.jira.plugin.system.customfieldtypes:select', 'customId' => 10_666 } }),
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'issuekey',          'name' => 'Key',        'custom' => false, 'orderable' => false, 'navigable' => true, 'searchable' => false, 'clauseNames' => %w[id issue issuekey key] }),
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'priority',          'name' => 'Priority',   'custom' => false, 'orderable' => true,  'navigable' => true, 'searchable' => true,  'clauseNames' => ['priority'],                     'schema' => { 'type' => 'priority',  'system' => 'priority' } }),
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'summary',           'name' => 'Summary',    'custom' => false, 'orderable' => true,  'navigable' => true, 'searchable' => true,  'clauseNames' => ['summary'],                      'schema' => { 'type' => 'string',    'system' => 'summary' } }),
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'issuetype',         'name' => 'Issue Type', 'custom' => false, 'orderable' => true,  'navigable' => true, 'searchable' => true,  'clauseNames' => %w[issuetype type], 'schema' => { 'type' => 'issuetype', 'system' => 'issuetype' } }),
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'customfield_10111', 'name' => 'SingleWord', 'custom' => true,  'orderable' => true,  'navigable' => true, 'searchable' => true,  'clauseNames' => ['cf[10111]', 'SingleWord'],       'schema' => { 'type' => 'string',    'custom' => 'com.atlassian.jira.plugin.system.customfieldtypes:select', 'customId' => 10_111 } }),
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'customfield_10222', 'name' => 'Multi Word', 'custom' => true,  'orderable' => true,  'navigable' => true, 'searchable' => true,  'clauseNames' => ['cf[10222]', 'Multi Word'],       'schema' => { 'type' => 'string',    'custom' => 'com.atlassian.jira.plugin.system.customfieldtypes:select', 'customId' => 10_222 } }),
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'customfield_10333', 'name' => 'Why/N@t',    'custom' => true,  'orderable' => true,  'navigable' => true, 'searchable' => true,  'clauseNames' => ['cf[10333]', 'Why/N@t'],          'schema' => { 'type' => 'string',    'custom' => 'com.atlassian.jira.plugin.system.customfieldtypes:select', 'customId' => 10_333 } }),
+                                                      JIRA::Resource::Field.new(client, attrs: { 'id' => 'customfield_10444', 'name' => 'SingleWord', 'custom' => true,  'orderable' => true,  'navigable' => true, 'searchable' => true,  'clauseNames' => ['cf[10444]', 'SingleWord'],       'schema' => { 'type' => 'string',    'custom' => 'com.atlassian.jira.plugin.system.customfieldtypes:select', 'customId' => 10_444 } })
+                                                    ])
     client
   end
 
-  describe "field_mappings" do
-
-    shared_context "mapped or not" do
-
-      subject {
-        JIRA::Resource::Field.new(client, :attrs => {
-          'priority' => 1,
-          'customfield_10111' => 'data_in_custom_field',
-          'customfield_10222' => 'multi word custom name',
-          'customfield_10333' => 'complex custom name',
-          'customfield_10444' => 'duplicated custom name',
-          'customfield_10666' => 'duplicate of a system name',
-        })
-      }
+  describe 'field_mappings' do
+    shared_context 'mapped or not' do
+      subject do
+        JIRA::Resource::Field.new(client, attrs: {
+                                    'priority' => 1,
+                                    'customfield_10111' => 'data_in_custom_field',
+                                    'customfield_10222' => 'multi word custom name',
+                                    'customfield_10333' => 'complex custom name',
+                                    'customfield_10444' => 'duplicated custom name',
+                                    'customfield_10666' => 'duplicate of a system name'
+                                  })
+      end
 
-      it "can find a standard field by id" do
+      it 'can find a standard field by id' do
         expect(subject.priority).to eq(1)
       end
 
-      it "can find a custom field by customfield_##### name" do
+      it 'can find a custom field by customfield_##### name' do
         expect(subject.customfield_10111).to eq('data_in_custom_field')
       end
 
-      it "is not confused by common attribute keys" do
-        expect{subject.name}.to raise_error(NoMethodError)
-        expect{subject.custom}.to raise_error(NoMethodError)
+      it 'is not confused by common attribute keys' do
+        expect { subject.name }.to raise_error(NoMethodError)
+        expect { subject.custom }.to raise_error(NoMethodError)
         expect(subject.id).to eq(nil)   # picks up ID from the parent -
       end
     end
 
-    context "before fields are mapped" do
+    context 'before fields are mapped' do
+      include_context 'mapped or not'
 
-      include_context "mapped or not"
-
-      it "can find a standard field by id" do
+      it 'can find a standard field by id' do
         expect(subject.priority).to eq(1)
       end
 
-      it "cannot find a standard field by name before mapping" do
-        expect{subject.Priority}.to raise_error(NoMethodError)
+      it 'cannot find a standard field by name before mapping' do
+        expect { subject.Priority }.to raise_error(NoMethodError)
       end
 
-      it "can find a custom field by customfield_##### name" do
+      it 'can find a custom field by customfield_##### name' do
         expect(subject.customfield_10111).to eq('data_in_custom_field')
       end
 
-      it "is not confused by common attribute keys and raises error" do
-        expect{subject.name}.to raise_error(NoMethodError)
-        expect{subject.custom}.to raise_error(NoMethodError)
+      it 'is not confused by common attribute keys and raises error' do
+        expect { subject.name }.to raise_error(NoMethodError)
+        expect { subject.custom }.to raise_error(NoMethodError)
         expect(subject.id).to eq(nil)   # picks up ID from the parent -
       end
     end
 
-    context "after fields are mapped" do
-
-      include_context "mapped or not"
+    context 'after fields are mapped' do
+      include_context 'mapped or not'
 
-      it "warns of duplicate fields" do
-        expect{client.Field.map_fields}.to output(/renaming as Priority_10666/).to_stderr
-        expect{client.Field.map_fields}.to output(/renaming as SingleWord_10444/).to_stderr
+      it 'warns of duplicate fields' do
+        expect { client.Field.map_fields }.to output(/renaming as Priority_10666/).to_stderr
+        expect { client.Field.map_fields }.to output(/renaming as SingleWord_10444/).to_stderr
       end
-
     end
   end
 end

data/spec/jira/resource/filter_spec.rb

@@ -2,48 +2,48 @@ require 'spec_helper'
 
 describe JIRA::Resource::Filter do
   let(:client) do
-    client = double()
+    client = double
     allow(client).to receive(:Issue).and_return(JIRA::Resource::IssueFactory.new(self))
     client
   end
   let(:collection_path) { '/rest/api/2/filter' }
   let(:jira_user) do
     {
-      :self => "https://localhost/rest/api/2/user?username=ljharb",
-      :name => 'ljharb',
-      :avatarUrls => {
+      self: 'https://localhost/rest/api/2/user?username=ljharb',
+      name: 'ljharb',
+      avatarUrls: {
         '16x16' => 'https://localhost/secure/useravatar?size=small&ownerId=ljharb&avatarId=1',
         '48x48' => 'https://localhost/secure/useravatar?ownerId=ljharb&avatarId=1'
       },
-      :displayName => 'Jordan Harband',
-      :active => true
+      displayName: 'Jordan Harband',
+      active: true
     }
   end
   let(:filter_attrs) do
     {
-      :self => "https://localhost#{collection_path}/42",
-      :id => 42,
-      :name => 'Resolved Tickets',
-      :description => '',
-      :owner => jira_user,
-      :jql => '"Git Repository" ~ jira-ruby AND status = Resolved',
-      :viewUrl => 'https://localhost/secure/IssueNavigator.jspa?mode=hide&requestId=42',
-      :searchUrl => 'https://localhost/rest/api/2/search?jql=%22Git+Repository%22+~+jira-ruby+AND+status+%3D+Resolved',
-      :favourite => false,
-      :sharePermissions => [
+      self: "https://localhost#{collection_path}/42",
+      id: 42,
+      name: 'Resolved Tickets',
+      description: '',
+      owner: jira_user,
+      jql: '"Git Repository" ~ jira-ruby AND status = Resolved',
+      viewUrl: 'https://localhost/secure/IssueNavigator.jspa?mode=hide&requestId=42',
+      searchUrl: 'https://localhost/rest/api/2/search?jql=%22Git+Repository%22+~+jira-ruby+AND+status+%3D+Resolved',
+      favourite: false,
+      sharePermissions: [
         {
-          :id => 123,
-          :type => 'global'
+          id: 123,
+          type: 'global'
         }
       ],
-      :subscriptions => {
-        :size => 0,
-        :items => []
+      subscriptions: {
+        size: 0,
+        items: []
       }
     }
   end
   let(:filter_response) do
-    response = double()
+    response = double
     allow(response).to receive(:body).and_return(filter_attrs.to_json)
     response
   end
@@ -54,40 +54,40 @@ describe JIRA::Resource::Filter do
   end
   let(:jql_issue) do
     {
-      :id => '663147',
-      :self => 'https://localhost/rest/api/2/issue/663147',
-      :key => "JIRARUBY-2386",
-      :fields => {
-        :reporter => jira_user,
-        :created => '2013-12-11T23:28:02.000+0000',
-        :assignee => jira_user
+      id: '663147',
+      self: 'https://localhost/rest/api/2/issue/663147',
+      key: 'JIRARUBY-2386',
+      fields: {
+        reporter: jira_user,
+        created: '2013-12-11T23:28:02.000+0000',
+        assignee: jira_user
       }
     }
   end
   let(:jql_attrs) do
     {
-      :startAt => 0,
-      :maxResults => 50,
-      :total => 2,
-      :issues => [jql_issue]
+      startAt: 0,
+      maxResults: 50,
+      total: 2,
+      issues: [jql_issue]
     }
   end
   let(:issue_jql_response) do
-    response = double()
+    response = double
     allow(response).to receive(:body).and_return(jql_attrs.to_json)
     response
   end
 
-  it "can be found by ID" do
+  it 'can be found by ID' do
     expect(JSON.parse(filter.attrs.to_json)).to eql(JSON.parse(filter_attrs.to_json))
   end
 
-  it "returns issues" do
+  it 'returns issues' do
     expect(filter).to be_present
-    allow(client).to receive(:options).and_return({ :rest_base_path => 'localhost' })
-    expect(client).to receive(:get).
-      with("localhost/search?jql=#{CGI.escape(filter.jql)}").
-      and_return(issue_jql_response)
+    allow(client).to receive(:options).and_return(rest_base_path: 'localhost')
+    expect(client).to receive(:get)
+      .with("localhost/search?jql=#{CGI.escape(filter.jql)}")
+      .and_return(issue_jql_response)
     issues = filter.issues
     expect(issues).to be_an(Array)
     expect(issues.size).to eql(1)