jira-ruby 1.5.0 → 1.6.0

data/spec/jira/resource/user_factory_spec.rb

@@ -1,19 +1,18 @@
 require 'spec_helper'
 
 describe JIRA::Resource::UserFactory do
-
-  let(:client) {
+  let(:client) do
     instance_double('Client', options: { rest_base_path: '/jira/rest/api/2' })
-  }
+  end
 
   subject { JIRA::Resource::UserFactory.new(client) }
 
-  describe "#myself" do
-    let(:response) {
+  describe '#myself' do
+    let(:response) do
       instance_double(
         'Response', body: get_mock_response('user_username=admin.json')
       )
-    }
+    end
 
     let(:user) { subject.myself }
 
@@ -23,11 +22,10 @@ describe JIRA::Resource::UserFactory do
       ).and_return(response)
     end
 
-    it "returns a JIRA::Resource::User with correct attrs" do
+    it 'returns a JIRA::Resource::User with correct attrs' do
       expect(user).to be_a(JIRA::Resource::User)
       expect(user.name).to eq('admin')
       expect(user.emailAddress).to eq('admin@example.com')
     end
   end
-
 end

data/spec/jira/resource/worklog_spec.rb

@@ -1,18 +1,17 @@
 require 'spec_helper'
 
 describe JIRA::Resource::Worklog do
+  let(:client) { double }
 
-  let(:client) { double() }
-
-  describe "relationships" do
-    subject {
-      JIRA::Resource::Worklog.new(client, :issue_id => '99999', :attrs => {
-        'author' => {'foo' => 'bar'},
-        'updateAuthor' => {'foo' => 'bar'}
-      })
-    }
+  describe 'relationships' do
+    subject do
+      JIRA::Resource::Worklog.new(client, issue_id: '99999', attrs: {
+                                    'author' => { 'foo' => 'bar' },
+                                    'updateAuthor' => { 'foo' => 'bar' }
+                                  })
+    end
 
-    it "has the correct relationships" do
+    it 'has the correct relationships' do
       expect(subject).to have_one(:author, JIRA::Resource::User)
       expect(subject.author.foo).to eq('bar')
 
@@ -20,5 +19,4 @@ describe JIRA::Resource::Worklog do
       expect(subject.update_author.foo).to eq('bar')
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -2,7 +2,9 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'rubygems'
 require 'bundler/setup'
 require 'webmock/rspec'
-Dir["./spec/support/**/*.rb"].each {|f| require f}
+require 'pry'
+
+Dir['./spec/support/**/*.rb'].each { |f| require f }
 
 require 'jira-ruby'
 
@@ -10,13 +12,10 @@ RSpec.configure do |config|
   config.extend ClientsHelper
 end
 
-
 def get_mock_response(file, value_if_file_not_found = false)
-  begin
-    file.sub!('?', '_') # we have to replace this character on Windows machine
-    File.read(File.join(File.dirname(__FILE__), 'mock_responses/', file))
-  rescue Errno::ENOENT => e
-    raise e if value_if_file_not_found == false
-    value_if_file_not_found
-  end
+  file.sub!('?', '_') # we have to replace this character on Windows machine
+  File.read(File.join(File.dirname(__FILE__), 'mock_responses/', file))
+rescue Errno::ENOENT => e
+  raise e if value_if_file_not_found == false
+  value_if_file_not_found
 end

data/spec/support/clients_helper.rb

@@ -2,12 +2,12 @@ module ClientsHelper
   def with_each_client
     clients = {}
 
-    oauth_client = JIRA::Client.new({ :consumer_key => 'foo', :consumer_secret => 'bar' })
+    oauth_client = JIRA::Client.new(consumer_key: 'foo', consumer_secret: 'bar')
     oauth_client.set_access_token('abc', '123')
-    clients["http://localhost:2990"] = oauth_client
+    clients['http://localhost:2990'] = oauth_client
 
-    basic_client = JIRA::Client.new({ :username => 'foo', :password => 'bar', :auth_type => :basic, :use_ssl => false })
-    clients["http://foo:bar@localhost:2990"] = basic_client
+    basic_client = JIRA::Client.new(username: 'foo', password: 'bar', auth_type: :basic, use_ssl: false)
+    clients['http://foo:bar@localhost:2990'] = basic_client
 
     clients.each do |site_url, client|
       yield site_url, client

data/spec/support/shared_examples/integration.rb

@@ -1,43 +1,39 @@
 require 'cgi'
 
 def get_mock_from_path(method, options = {})
-  if defined? belongs_to
-    prefix = belongs_to.path_component + '/'
-  else
-    prefix = ''
-  end
-
-  if options[:url]
-    url = options[:url]
-  elsif options[:key]
-    url = described_class.singular_path(client, options[:key], prefix)
-  else
-    url = described_class.collection_path(client, prefix)
-  end
+  prefix = if defined? belongs_to
+             belongs_to.path_component + '/'
+           else
+             ''
+           end
+
+  url = if options[:url]
+          options[:url]
+        elsif options[:key]
+          described_class.singular_path(client, options[:key], prefix)
+        else
+          described_class.collection_path(client, prefix)
+        end
   file_path = url.sub(client.options[:rest_base_path], '')
   file_path = file_path + '.' + options[:suffix] if options[:suffix]
   file_path = file_path + '.' + method.to_s unless method == :get
-  value_if_not_found = options.keys.include?(:value_if_not_found) ? options[:value_if_not_found] : false
+  value_if_not_found = options.key?(:value_if_not_found) ? options[:value_if_not_found] : false
   get_mock_response("#{file_path}.json", value_if_not_found)
 end
 
 def class_basename
- described_class.name.split('::').last
+  described_class.name.split('::').last
 end
 
 def options
   options = {}
-  if defined? belongs_to
-    options[belongs_to.to_sym] = belongs_to
-  end
+  options[belongs_to.to_sym] = belongs_to if defined? belongs_to
   options
 end
 
 def prefix
   prefix = '/'
-  if defined? belongs_to
-    prefix = belongs_to.path_component + '/'
-  end
+  prefix = belongs_to.path_component + '/' if defined? belongs_to
   prefix
 end
 
@@ -49,73 +45,66 @@ def build_receiver
   end
 end
 
-shared_examples "a resource" do
-
-  it "gracefully handles non-json responses" do
+shared_examples 'a resource' do
+  it 'gracefully handles non-json responses' do
     if defined? target
       subject = target
     else
       subject = client.send(class_basename).build(described_class.key_attribute.to_s => '99999')
     end
-    stub_request(:put, site_url + subject.url).
-                to_return(:status => 405, :body => "<html><body>Some HTML</body></html>")
+    stub_request(:put, site_url + subject.url)
+      .to_return(status: 405, body: '<html><body>Some HTML</body></html>')
     expect(subject.save('foo' => 'bar')).to be_falsey
     expect(lambda do
       expect(subject.save!('foo' => 'bar')).to be_falsey
     end).to raise_error(JIRA::HTTPError)
   end
-
 end
 
-shared_examples "a resource with a collection GET endpoint" do
-
-  it "should get the collection" do
-    stub_request(:get, site_url + described_class.collection_path(client)).
-                 to_return(:status => 200, :body => get_mock_from_path(:get))
+shared_examples 'a resource with a collection GET endpoint' do
+  it 'should get the collection' do
+    stub_request(:get, site_url + described_class.collection_path(client))
+      .to_return(status: 200, body: get_mock_from_path(:get))
     collection = build_receiver.all
 
     expect(collection.length).to eq(expected_collection_length)
     expect(collection.first).to have_attributes(expected_attributes)
   end
-
 end
 
-shared_examples "a resource with JQL inputs and a collection GET endpoint" do
-
-  it "should get the collection" do
+shared_examples 'a resource with JQL inputs and a collection GET endpoint' do
+  it 'should get the collection' do
     stub_request(
       :get,
       site_url +
         client.options[:rest_base_path] +
         '/search?jql=' +
         CGI.escape(jql_query_string)
-    ).to_return(:status => 200, :body => get_mock_response('issue.json'))
+    ).to_return(status: 200, body: get_mock_response('issue.json'))
 
     collection = build_receiver.jql(jql_query_string)
 
     expect(collection.length).to eq(expected_collection_length)
     expect(collection.first).to have_attributes(expected_attributes)
   end
-
 end
 
-shared_examples "a resource with a singular GET endpoint" do
-
-  it "GETs a single resource" do
+shared_examples 'a resource with a singular GET endpoint' do
+  it 'GETs a single resource' do
     # E.g., for JIRA::Resource::Project, we need to call
     # client.Project.find()
-    stub_request(:get, site_url + described_class.singular_path(client, key, prefix)).
-                to_return(:status => 200, :body => get_mock_from_path(:get, :key => key))
+    stub_request(:get, site_url + described_class.singular_path(client, key, prefix))
+      .to_return(status: 200, body: get_mock_from_path(:get, key: key))
     subject = client.send(class_basename).find(key, options)
 
     expect(subject).to have_attributes(expected_attributes)
   end
 
-  it "builds and fetches a single resource" do
+  it 'builds and fetches a single resource' do
     # E.g., for JIRA::Resource::Project, we need to call
     # client.Project.build('key' => 'ABC123')
-    stub_request(:get, site_url + described_class.singular_path(client, key, prefix)).
-                to_return(:status => 200, :body => get_mock_from_path(:get, :key => key))
+    stub_request(:get, site_url + described_class.singular_path(client, key, prefix))
+      .to_return(status: 200, body: get_mock_from_path(:get, key: key))
 
     subject = build_receiver.build(described_class.key_attribute.to_s => key)
     subject.fetch
@@ -123,48 +112,45 @@ shared_examples "a resource with a singular GET endpoint" do
     expect(subject).to have_attributes(expected_attributes)
   end
 
-  it "handles a 404" do
-    stub_request(:get, site_url + described_class.singular_path(client, '99999', prefix)).
-                to_return(:status => 404, :body => '{"errorMessages":["'+class_basename+' Does Not Exist"],"errors": {}}')
-    expect(   lambda do
+  it 'handles a 404' do
+    stub_request(:get, site_url + described_class.singular_path(client, '99999', prefix))
+      .to_return(status: 404, body: '{"errorMessages":["' + class_basename + ' Does Not Exist"],"errors": {}}')
+    expect(lambda do
       client.send(class_basename).find('99999', options)
     end).to raise_exception(JIRA::HTTPError)
   end
 end
 
-shared_examples "a resource with a DELETE endpoint" do
-  it "deletes a resource" do
+shared_examples 'a resource with a DELETE endpoint' do
+  it 'deletes a resource' do
     # E.g., for JIRA::Resource::Project, we need to call
     # client.Project.delete()
-    stub_request(:delete, site_url + described_class.singular_path(client, key, prefix)).
-                to_return(:status => 204, :body => nil)
+    stub_request(:delete, site_url + described_class.singular_path(client, key, prefix))
+      .to_return(status: 204, body: nil)
 
     subject = build_receiver.build(described_class.key_attribute.to_s => key)
     expect(subject.delete).to be_truthy
   end
 end
 
-shared_examples "a resource with a POST endpoint" do
-
-  it "saves a new resource" do
-    stub_request(:post, site_url + described_class.collection_path(client, prefix)).
-                to_return(:status => 201, :body => get_mock_from_path(:post))
+shared_examples 'a resource with a POST endpoint' do
+  it 'saves a new resource' do
+    stub_request(:post, site_url + described_class.collection_path(client, prefix))
+      .to_return(status: 201, body: get_mock_from_path(:post))
     subject = build_receiver.build
     expect(subject.save(attributes_for_post)).to be_truthy
     expected_attributes_from_post.each do |method_name, value|
       expect(subject.send(method_name)).to eq(value)
     end
   end
-
 end
 
-shared_examples "a resource with a PUT endpoint" do
-
-  it "saves an existing component" do
-    stub_request(:get, site_url + described_class.singular_path(client, key, prefix)).
-                to_return(:status => 200, :body => get_mock_from_path(:get, :key =>key))
-    stub_request(:put, site_url + described_class.singular_path(client, key, prefix)).
-                  to_return(:status => 200, :body => get_mock_from_path(:put, :key => key, :value_if_not_found => nil))
+shared_examples 'a resource with a PUT endpoint' do
+  it 'saves an existing component' do
+    stub_request(:get, site_url + described_class.singular_path(client, key, prefix))
+      .to_return(status: 200, body: get_mock_from_path(:get, key: key))
+    stub_request(:put, site_url + described_class.singular_path(client, key, prefix))
+      .to_return(status: 200, body: get_mock_from_path(:put, key: key, value_if_not_found: nil))
     subject = build_receiver.build(described_class.key_attribute.to_s => key)
     subject.fetch
     expect(subject.save(attributes_for_put)).to be_truthy
@@ -172,23 +158,20 @@ shared_examples "a resource with a PUT endpoint" do
       expect(subject.send(method_name)).to eq(value)
     end
   end
-
 end
 
 shared_examples 'a resource with a PUT endpoint that rejects invalid fields' do
-
-  it "fails to save with an invalid field" do
-    stub_request(:get, site_url + described_class.singular_path(client, key)).
-                to_return(:status => 200, :body => get_mock_from_path(:get, :key => key))
-    stub_request(:put, site_url + described_class.singular_path(client, key)).
-                to_return(:status => 400, :body => get_mock_from_path(:put, :key => key, :suffix => "invalid"))
+  it 'fails to save with an invalid field' do
+    stub_request(:get, site_url + described_class.singular_path(client, key))
+      .to_return(status: 200, body: get_mock_from_path(:get, key: key))
+    stub_request(:put, site_url + described_class.singular_path(client, key))
+      .to_return(status: 400, body: get_mock_from_path(:put, key: key, suffix: 'invalid'))
     subject = client.send(class_basename).build(described_class.key_attribute.to_s => key)
     subject.fetch
 
-    expect(subject.save('fields'=> {'invalid' => 'field'})).to be_falsey
+    expect(subject.save('fields' => { 'invalid' => 'field' })).to be_falsey
     expect(lambda do
-      subject.save!('fields'=> {'invalid' => 'field'})
+      subject.save!('fields' => { 'invalid' => 'field' })
     end).to raise_error(JIRA::HTTPError)
   end
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jira-ruby
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - SUMO Heavy Industries
@@ -9,30 +9,24 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-19 00:00:00.000000000 Z
+date: 2018-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: oauth
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: multipart-post
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -46,153 +40,159 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: multipart-post
+  name: oauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.13'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.13'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.13.0
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '4.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.18.0
+        version: 4.6.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.18'
+        version: '4.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.18.0
+        version: 4.6.5
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0.10'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 0.10.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0.10'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 0.10.3
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 10.3.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 10.3.2
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: guard
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.13'
+        version: '10.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: 10.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.13'
+        version: '10.3'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: 10.3.2
 - !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.6'
+        version: '3.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.6.5
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.6'
+        version: '3.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.6.5
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '1.18'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.10.3
+        version: 1.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '1.18'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.10.3
+        version: 1.18.0
 description: API for JIRA
 email: 
 executables: []
@@ -222,6 +222,7 @@ files:
 - lib/jira/resource/agile.rb
 - lib/jira/resource/applinks.rb
 - lib/jira/resource/attachment.rb
+- lib/jira/resource/board.rb
 - lib/jira/resource/comment.rb
 - lib/jira/resource/component.rb
 - lib/jira/resource/createmeta.rb
@@ -238,6 +239,7 @@ files:
 - lib/jira/resource/resolution.rb
 - lib/jira/resource/serverinfo.rb
 - lib/jira/resource/sprint.rb
+- lib/jira/resource/sprint_report.rb
 - lib/jira/resource/status.rb
 - lib/jira/resource/transition.rb
 - lib/jira/resource/user.rb
@@ -276,6 +278,7 @@ files:
 - spec/jira/request_client_spec.rb
 - spec/jira/resource/agile_spec.rb
 - spec/jira/resource/attachment_spec.rb
+- spec/jira/resource/board_spec.rb
 - spec/jira/resource/createmeta_spec.rb
 - spec/jira/resource/field_spec.rb
 - spec/jira/resource/filter_spec.rb
@@ -283,6 +286,7 @@ files:
 - spec/jira/resource/issuelink_spec.rb
 - spec/jira/resource/project_factory_spec.rb
 - spec/jira/resource/project_spec.rb
+- spec/jira/resource/sprint_spec.rb
 - spec/jira/resource/user_factory_spec.rb
 - spec/jira/resource/worklog_spec.rb
 - spec/mock_responses/board/1.json
@@ -365,7 +369,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: jira-ruby
-rubygems_version: 2.6.14
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Ruby Gem for use with the Atlassian JIRA REST API
@@ -398,6 +402,7 @@ test_files:
 - spec/jira/request_client_spec.rb
 - spec/jira/resource/agile_spec.rb
 - spec/jira/resource/attachment_spec.rb
+- spec/jira/resource/board_spec.rb
 - spec/jira/resource/createmeta_spec.rb
 - spec/jira/resource/field_spec.rb
 - spec/jira/resource/filter_spec.rb
@@ -405,6 +410,7 @@ test_files:
 - spec/jira/resource/issuelink_spec.rb
 - spec/jira/resource/project_factory_spec.rb
 - spec/jira/resource/project_spec.rb
+- spec/jira/resource/sprint_spec.rb
 - spec/jira/resource/user_factory_spec.rb
 - spec/jira/resource/worklog_spec.rb
 - spec/mock_responses/board/1.json