ibm_db 4.0.0-x86-mingw32 → 5.0.2-x86-mingw32

data/test/cases/associations/left_outer_join_association_test.rb

@@ -1,88 +1,88 @@
-require "cases/helper"
-require 'models/post'
-require 'models/comment'
-require 'models/author'
-require 'models/essay'
-require 'models/categorization'
-require 'models/person'
-
-class LeftOuterJoinAssociationTest < ActiveRecord::TestCase
-  fixtures :authors, :essays, :posts, :comments, :categorizations, :people
-
-  def test_construct_finder_sql_applies_aliases_tables_on_association_conditions
-    result = Author.left_outer_joins(:thinking_posts, :welcome_posts).to_a
-    assert_equal authors(:david), result.first
-  end
-
-  def test_construct_finder_sql_does_not_table_name_collide_on_duplicate_associations
-    assert_nothing_raised do
-      queries = capture_sql do
-        Person.left_outer_joins(:agents => {:agents => :agents})
-              .left_outer_joins(:agents => {:agents => {:primary_contact => :agents}}).to_a
-      end
-      assert queries.any? { |sql| /agents_people_4/i =~ sql }
-    end
-  end
-
-  def test_left_outer_joins_count_is_same_as_size_of_loaded_results
-    assert_equal 17, Post.left_outer_joins(:comments).to_a.size
-    assert_equal 17, Post.left_outer_joins(:comments).count
-  end
-
-  def test_left_joins_aliases_left_outer_joins
-    assert_equal Post.left_outer_joins(:comments).to_sql, Post.left_joins(:comments).to_sql
-  end
-
-  def test_left_outer_joins_return_has_value_for_every_comment
-    all_post_ids = Post.pluck(:id)
-    assert_equal all_post_ids, all_post_ids & Post.left_outer_joins(:comments).pluck(:id)
-  end
-
-  def test_left_outer_joins_actually_does_a_left_outer_join
-    queries = capture_sql { Author.left_outer_joins(:posts).to_a }
-    assert queries.any? { |sql| /LEFT OUTER JOIN/i =~ sql }
-  end
-
-  def test_construct_finder_sql_ignores_empty_left_outer_joins_hash
-    queries = capture_sql { Author.left_outer_joins({}).to_a }
-    assert queries.none? { |sql| /LEFT OUTER JOIN/i =~ sql }
-  end
-
-  def test_construct_finder_sql_ignores_empty_left_outer_joins_array
-    queries = capture_sql { Author.left_outer_joins([]).to_a }
-    assert queries.none? { |sql| /LEFT OUTER JOIN/i =~ sql }
-  end
-
-  def test_left_outer_joins_forbids_to_use_string_as_argument
-    assert_raise(ArgumentError){ Author.left_outer_joins('LEFT OUTER JOIN "posts" ON "posts"."user_id" = "users"."id"').to_a }
-  end
-
-  def test_join_conditions_added_to_join_clause
-    queries = capture_sql { Author.left_outer_joins(:essays).to_a }
-    assert queries.any? { |sql| /writer_type.*?=.*?(Author|\?|\$1)/i =~ sql }
-    assert queries.none? { |sql| /WHERE/i =~ sql }
-  end
-
-  def test_find_with_sti_join
-    scope = Post.left_outer_joins(:special_comments).where(:id => posts(:sti_comments).id)
-
-    # The join should match SpecialComment and its subclasses only
-    assert scope.where("comments.type" => "Comment").empty?
-    assert !scope.where("comments.type" => "SpecialComment").empty?
-    assert !scope.where("comments.type" => "SubSpecialComment").empty?
-  end
-
-  def test_does_not_override_select
-    authors = Author.select("authors.name, #{%{(authors.author_address_id || ' ' || authors.author_address_extra_id) as addr_id}}").left_outer_joins(:posts)
-    assert authors.any?
-    assert authors.first.respond_to?(:addr_id)
-  end
-
-  test "the default scope of the target is applied when joining associations" do
-    author = Author.create! name: "Jon"
-    author.categorizations.create!
-    author.categorizations.create! special: true
-
-    assert_equal [author], Author.where(id: author).left_outer_joins(:special_categorizations)
-  end
-end
+require "cases/helper"
+require 'models/post'
+require 'models/comment'
+require 'models/author'
+require 'models/essay'
+require 'models/categorization'
+require 'models/person'
+
+class LeftOuterJoinAssociationTest < ActiveRecord::TestCase
+  fixtures :authors, :essays, :posts, :comments, :categorizations, :people
+
+  def test_construct_finder_sql_applies_aliases_tables_on_association_conditions
+    result = Author.left_outer_joins(:thinking_posts, :welcome_posts).to_a
+    assert_equal authors(:david), result.first
+  end
+
+  def test_construct_finder_sql_does_not_table_name_collide_on_duplicate_associations
+    assert_nothing_raised do
+      queries = capture_sql do
+        Person.left_outer_joins(:agents => {:agents => :agents})
+              .left_outer_joins(:agents => {:agents => {:primary_contact => :agents}}).to_a
+      end
+      assert queries.any? { |sql| /agents_people_4/i =~ sql }
+    end
+  end
+
+  def test_left_outer_joins_count_is_same_as_size_of_loaded_results
+    assert_equal 17, Post.left_outer_joins(:comments).to_a.size
+    assert_equal 17, Post.left_outer_joins(:comments).count
+  end
+
+  def test_left_joins_aliases_left_outer_joins
+    assert_equal Post.left_outer_joins(:comments).to_sql, Post.left_joins(:comments).to_sql
+  end
+
+  def test_left_outer_joins_return_has_value_for_every_comment
+    all_post_ids = Post.pluck(:id)
+    assert_equal all_post_ids, all_post_ids & Post.left_outer_joins(:comments).pluck(:id)
+  end
+
+  def test_left_outer_joins_actually_does_a_left_outer_join
+    queries = capture_sql { Author.left_outer_joins(:posts).to_a }
+    assert queries.any? { |sql| /LEFT OUTER JOIN/i =~ sql }
+  end
+
+  def test_construct_finder_sql_ignores_empty_left_outer_joins_hash
+    queries = capture_sql { Author.left_outer_joins({}).to_a }
+    assert queries.none? { |sql| /LEFT OUTER JOIN/i =~ sql }
+  end
+
+  def test_construct_finder_sql_ignores_empty_left_outer_joins_array
+    queries = capture_sql { Author.left_outer_joins([]).to_a }
+    assert queries.none? { |sql| /LEFT OUTER JOIN/i =~ sql }
+  end
+
+  def test_left_outer_joins_forbids_to_use_string_as_argument
+    assert_raise(ArgumentError){ Author.left_outer_joins('LEFT OUTER JOIN "posts" ON "posts"."user_id" = "users"."id"').to_a }
+  end
+
+  def test_join_conditions_added_to_join_clause
+    queries = capture_sql { Author.left_outer_joins(:essays).to_a }
+    assert queries.any? { |sql| /writer_type.*?=.*?(Author|\?|\$1)/i =~ sql }
+    assert queries.none? { |sql| /WHERE/i =~ sql }
+  end
+
+  def test_find_with_sti_join
+    scope = Post.left_outer_joins(:special_comments).where(:id => posts(:sti_comments).id)
+
+    # The join should match SpecialComment and its subclasses only
+    assert scope.where("comments.type" => "Comment").empty?
+    assert !scope.where("comments.type" => "SpecialComment").empty?
+    assert !scope.where("comments.type" => "SubSpecialComment").empty?
+  end
+
+  def test_does_not_override_select
+    authors = Author.select("authors.name, #{%{(authors.author_address_id || ' ' || authors.author_address_extra_id) as addr_id}}").left_outer_joins(:posts)
+    assert authors.any?
+    assert authors.first.respond_to?(:addr_id)
+  end
+
+  test "the default scope of the target is applied when joining associations" do
+    author = Author.create! name: "Jon"
+    author.categorizations.create!
+    author.categorizations.create! special: true
+
+    assert_equal [author], Author.where(id: author).left_outer_joins(:special_categorizations)
+  end
+end

data/test/cases/associations/nested_through_associations_test.rb

@@ -1,579 +1,579 @@
-require "cases/helper"
-require 'models/author'
-require 'models/post'
-require 'models/person'
-require 'models/reference'
-require 'models/job'
-require 'models/reader'
-require 'models/comment'
-require 'models/tag'
-require 'models/tagging'
-require 'models/subscriber'
-require 'models/book'
-require 'models/subscription'
-require 'models/rating'
-require 'models/member'
-require 'models/member_detail'
-require 'models/member_type'
-require 'models/sponsor'
-require 'models/club'
-require 'models/organization'
-require 'models/category'
-require 'models/categorization'
-require 'models/membership'
-require 'models/essay'
-
-class NestedThroughAssociationsTest < ActiveRecord::TestCase
-  fixtures :authors, :books, :posts, :subscriptions, :subscribers, :tags, :taggings,
-           :people, :readers, :references, :jobs, :ratings, :comments, :members, :member_details,
-           :member_types, :sponsors, :clubs, :organizations, :categories, :categories_posts,
-           :categorizations, :memberships, :essays
-
-  # Through associations can either use the has_many or has_one macros.
-  #
-  # has_many
-  #   - Source reflection can be has_many, has_one, belongs_to or has_and_belongs_to_many
-  #   - Through reflection can be has_many, has_one, belongs_to or has_and_belongs_to_many
-  #
-  # has_one
-  #   - Source reflection can be has_one or belongs_to
-  #   - Through reflection can be has_one or belongs_to
-  #
-  # Additionally, the source reflection and/or through reflection may be subject to
-  # polymorphism and/or STI.
-  #
-  # When testing these, we need to make sure it works via loading the association directly, or
-  # joining the association, or including the association. We also need to ensure that associations
-  # are readonly where relevant.
-
-  # has_many through
-  # Source: has_many through
-  # Through: has_many
-  def test_has_many_through_has_many_with_has_many_through_source_reflection
-    general = tags(:general)
-    assert_equal [general, general], authors(:david).tags
-  end
-
-  def test_has_many_through_has_many_with_has_many_through_source_reflection_preload
-    authors = assert_queries(5) { Author.includes(:tags).to_a }
-    general = tags(:general)
-
-    assert_no_queries do
-      assert_equal [general, general], authors.first.tags
-    end
-  end
-
-  def test_has_many_through_has_many_with_has_many_through_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Author.where('tags.id' => tags(:general).id),
-      [authors(:david)], :tags
-    )
-
-    # This ensures that the polymorphism of taggings is being observed correctly
-    authors = Author.joins(:tags).where('taggings.taggable_type' => 'FakeModel')
-    assert authors.empty?
-  end
-
-  # has_many through
-  # Source: has_many
-  # Through: has_many through
-  def test_has_many_through_has_many_through_with_has_many_source_reflection
-    luke, david = subscribers(:first), subscribers(:second)
-    assert_equal [luke, david, david], authors(:david).subscribers.order('subscribers.nick')
-  end
-
-  def test_has_many_through_has_many_through_with_has_many_source_reflection_preload
-    luke, david = subscribers(:first), subscribers(:second)
-    authors = assert_queries(4) { Author.includes(:subscribers).to_a }
-    assert_no_queries do
-      assert_equal [luke, david, david], authors.first.subscribers.sort_by(&:nick)
-    end
-  end
-
-  def test_has_many_through_has_many_through_with_has_many_source_reflection_preload_via_joins
-    # All authors with subscribers where one of the subscribers' nick is 'alterself'
-    assert_includes_and_joins_equal(
-      Author.where('subscribers.nick' => 'alterself'),
-      [authors(:david)], :subscribers
-    )
-  end
-
-  # has_many through
-  # Source: has_one through
-  # Through: has_one
-  def test_has_many_through_has_one_with_has_one_through_source_reflection
-    assert_equal [member_types(:founding)], members(:groucho).nested_member_types
-  end
-
-  def test_has_many_through_has_one_with_has_one_through_source_reflection_preload
-    members = assert_queries(4) { Member.includes(:nested_member_types).to_a }
-    founding = member_types(:founding)
-    assert_no_queries do
-      assert_equal [founding], members.first.nested_member_types
-    end
-  end
-
-  def test_has_many_through_has_one_with_has_one_through_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Member.where('member_types.id' => member_types(:founding).id),
-      [members(:groucho)], :nested_member_types
-    )
-  end
-
-  # has_many through
-  # Source: has_one
-  # Through: has_one through
-  def test_has_many_through_has_one_through_with_has_one_source_reflection
-    assert_equal [sponsors(:moustache_club_sponsor_for_groucho)], members(:groucho).nested_sponsors
-  end
-
-  def test_has_many_through_has_one_through_with_has_one_source_reflection_preload
-    members = assert_queries(4) { Member.includes(:nested_sponsors).to_a }
-    mustache = sponsors(:moustache_club_sponsor_for_groucho)
-    assert_no_queries(ignore_none: false) do
-      assert_equal [mustache], members.first.nested_sponsors
-    end
-  end
-
-  def test_has_many_through_has_one_through_with_has_one_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Member.where('sponsors.id' => sponsors(:moustache_club_sponsor_for_groucho).id),
-      [members(:groucho)], :nested_sponsors
-    )
-  end
-
-  # has_many through
-  # Source: has_many through
-  # Through: has_one
-  def test_has_many_through_has_one_with_has_many_through_source_reflection
-    groucho_details, other_details = member_details(:groucho), member_details(:some_other_guy)
-
-    assert_equal [groucho_details, other_details],
-                 members(:groucho).organization_member_details.order('member_details.id')
-  end
-
-  def test_has_many_through_has_one_with_has_many_through_source_reflection_preload
-    ActiveRecord::Base.connection.table_alias_length  # preheat cache
-    members = assert_queries(4) { Member.includes(:organization_member_details).to_a.sort_by(&:id) }
-    groucho_details, other_details = member_details(:groucho), member_details(:some_other_guy)
-
-    assert_no_queries do
-      assert_equal [groucho_details, other_details], members.first.organization_member_details.sort_by(&:id)
-    end
-  end
-
-  def test_has_many_through_has_one_with_has_many_through_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Member.where('member_details.id' => member_details(:groucho).id).order('member_details.id'),
-      [members(:groucho), members(:some_other_guy)], :organization_member_details
-    )
-
-    members = Member.joins(:organization_member_details).
-                     where('member_details.id' => 9)
-    assert members.empty?
-  end
-
-  # has_many through
-  # Source: has_many
-  # Through: has_one through
-  def test_has_many_through_has_one_through_with_has_many_source_reflection
-    groucho_details, other_details = member_details(:groucho), member_details(:some_other_guy)
-
-    assert_equal [groucho_details, other_details],
-                 members(:groucho).organization_member_details_2.order('member_details.id')
-  end
-
-  def test_has_many_through_has_one_through_with_has_many_source_reflection_preload
-    members = assert_queries(4) { Member.includes(:organization_member_details_2).to_a.sort_by(&:id) }
-    groucho_details, other_details = member_details(:groucho), member_details(:some_other_guy)
-
-    # postgresql test if randomly executed then executes "SHOW max_identifier_length". Hence
-    # the need to ignore certain predefined sqls that deal with system calls.
-    assert_no_queries(ignore_none: false) do
-      assert_equal [groucho_details, other_details], members.first.organization_member_details_2.sort_by(&:id)
-    end
-  end
-
-  def test_has_many_through_has_one_through_with_has_many_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Member.where('member_details.id' => member_details(:groucho).id).order('member_details.id'),
-      [members(:groucho), members(:some_other_guy)], :organization_member_details_2
-    )
-
-    members = Member.joins(:organization_member_details_2).
-                     where('member_details.id' => 9)
-    assert members.empty?
-  end
-
-  # has_many through
-  # Source: has_and_belongs_to_many
-  # Through: has_many
-  def test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection
-    general, cooking = categories(:general), categories(:cooking)
-
-    assert_equal [general, cooking], authors(:bob).post_categories.order('categories.id')
-  end
-
-  def test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection_preload
-    authors = assert_queries(4) { Author.includes(:post_categories).to_a.sort_by(&:id) }
-    general, cooking = categories(:general), categories(:cooking)
-
-    assert_no_queries do
-      assert_equal [general, cooking], authors[2].post_categories.sort_by(&:id)
-    end
-  end
-
-  def test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection_preload_via_joins
-    # preload table schemas
-    Author.joins(:post_categories).first
-
-    assert_includes_and_joins_equal(
-      Author.where('categories.id' => categories(:cooking).id),
-      [authors(:bob)], :post_categories
-    )
-  end
-
-  # has_many through
-  # Source: has_many
-  # Through: has_and_belongs_to_many
-  def test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection
-    greetings, more = comments(:greetings), comments(:more_greetings)
-
-    assert_equal [greetings, more], categories(:technology).post_comments.order('comments.id')
-  end
-
-  def test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection_preload
-    Category.includes(:post_comments).to_a # preheat cache
-    categories = assert_queries(4) { Category.includes(:post_comments).to_a.sort_by(&:id) }
-    greetings, more = comments(:greetings), comments(:more_greetings)
-
-    assert_no_queries do
-      assert_equal [greetings, more], categories[1].post_comments.sort_by(&:id)
-    end
-  end
-
-  def test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection_preload_via_joins
-    # preload table schemas
-    Category.joins(:post_comments).first
-
-    assert_includes_and_joins_equal(
-      Category.where('comments.id' => comments(:more_greetings).id).order('categories.id'),
-      [categories(:general), categories(:technology)], :post_comments
-    )
-  end
-
-  # has_many through
-  # Source: has_many through a habtm
-  # Through: has_many through
-  def test_has_many_through_has_many_with_has_many_through_habtm_source_reflection
-    greetings, more = comments(:greetings), comments(:more_greetings)
-
-    assert_equal [greetings, more], authors(:bob).category_post_comments.order('comments.id')
-  end
-
-  def test_has_many_through_has_many_with_has_many_through_habtm_source_reflection_preload
-    authors = assert_queries(6) { Author.includes(:category_post_comments).to_a.sort_by(&:id) }
-    greetings, more = comments(:greetings), comments(:more_greetings)
-
-    assert_no_queries do
-      assert_equal [greetings, more], authors[2].category_post_comments.sort_by(&:id)
-    end
-  end
-
-  def test_has_many_through_has_many_with_has_many_through_habtm_source_reflection_preload_via_joins
-    # preload table schemas
-    Author.joins(:category_post_comments).first
-
-    assert_includes_and_joins_equal(
-      Author.where('comments.id' => comments(:does_it_hurt).id).order('authors.id'),
-      [authors(:david), authors(:mary)], :category_post_comments
-    )
-  end
-
-  # has_many through
-  # Source: belongs_to
-  # Through: has_many through
-  def test_has_many_through_has_many_through_with_belongs_to_source_reflection
-    assert_equal [tags(:general), tags(:general)], authors(:david).tagging_tags
-  end
-
-  def test_has_many_through_has_many_through_with_belongs_to_source_reflection_preload
-    authors = assert_queries(5) { Author.includes(:tagging_tags).to_a }
-    general = tags(:general)
-
-    assert_no_queries do
-      assert_equal [general, general], authors.first.tagging_tags
-    end
-  end
-
-  def test_has_many_through_has_many_through_with_belongs_to_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Author.where('tags.id' => tags(:general).id),
-      [authors(:david)], :tagging_tags
-    )
-  end
-
-  # has_many through
-  # Source: has_many through
-  # Through: belongs_to
-  def test_has_many_through_belongs_to_with_has_many_through_source_reflection
-    welcome_general, thinking_general = taggings(:welcome_general), taggings(:thinking_general)
-
-    assert_equal [welcome_general, thinking_general],
-                 categorizations(:david_welcome_general).post_taggings.order('taggings.id')
-  end
-
-  def test_has_many_through_belongs_to_with_has_many_through_source_reflection_preload
-    categorizations = assert_queries(4) { Categorization.includes(:post_taggings).to_a.sort_by(&:id) }
-    welcome_general, thinking_general = taggings(:welcome_general), taggings(:thinking_general)
-
-    assert_no_queries do
-      assert_equal [welcome_general, thinking_general], categorizations.first.post_taggings.sort_by(&:id)
-    end
-  end
-
-  def test_has_many_through_belongs_to_with_has_many_through_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Categorization.where('taggings.id' => taggings(:welcome_general).id).order('taggings.id'),
-      [categorizations(:david_welcome_general)], :post_taggings
-    )
-  end
-
-  # has_one through
-  # Source: has_one through
-  # Through: has_one
-  def test_has_one_through_has_one_with_has_one_through_source_reflection
-    assert_equal member_types(:founding), members(:groucho).nested_member_type
-  end
-
-  def test_has_one_through_has_one_with_has_one_through_source_reflection_preload
-    members = assert_queries(4) { Member.includes(:nested_member_type).to_a.sort_by(&:id) }
-    founding = member_types(:founding)
-
-    assert_no_queries do
-      assert_equal founding, members.first.nested_member_type
-    end
-  end
-
-  def test_has_one_through_has_one_with_has_one_through_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Member.where('member_types.id' => member_types(:founding).id),
-      [members(:groucho)], :nested_member_type
-    )
-  end
-
-  # has_one through
-  # Source: belongs_to
-  # Through: has_one through
-  def test_has_one_through_has_one_through_with_belongs_to_source_reflection
-    assert_equal categories(:general), members(:groucho).club_category
-  end
-
-  def test_joins_and_includes_from_through_models_not_included_in_association
-    prev_default_scope = Club.default_scopes
-
-    [:includes, :preload, :joins, :eager_load].each do |q|
-      Club.default_scopes = [proc { Club.send(q, :category) }]
-      assert_equal categories(:general), members(:groucho).reload.club_category
-    end
-  ensure
-    Club.default_scopes = prev_default_scope
-  end
-
-  def test_has_one_through_has_one_through_with_belongs_to_source_reflection_preload
-    members = assert_queries(4) { Member.includes(:club_category).to_a.sort_by(&:id) }
-    general = categories(:general)
-
-    assert_no_queries do
-      assert_equal general, members.first.club_category
-    end
-  end
-
-  def test_has_one_through_has_one_through_with_belongs_to_source_reflection_preload_via_joins
-    assert_includes_and_joins_equal(
-      Member.where('categories.id' => categories(:technology).id),
-      [members(:blarpy_winkup)], :club_category
-    )
-  end
-
-  def test_distinct_has_many_through_a_has_many_through_association_on_source_reflection
-    author = authors(:david)
-    assert_equal [tags(:general)], author.distinct_tags
-  end
-
-  def test_distinct_has_many_through_a_has_many_through_association_on_through_reflection
-    author = authors(:david)
-    assert_equal [subscribers(:first), subscribers(:second)],
-                 author.distinct_subscribers.order('subscribers.nick')
-  end
-
-  def test_nested_has_many_through_with_a_table_referenced_multiple_times
-    author = authors(:bob)
-    assert_equal [posts(:misc_by_bob), posts(:misc_by_mary), posts(:other_by_bob), posts(:other_by_mary)],
-                 author.similar_posts.sort_by(&:id)
-
-    # Mary and Bob both have posts in misc, but they are the only ones.
-    authors = Author.joins(:similar_posts).where('posts.id' => posts(:misc_by_bob).id)
-    assert_equal [authors(:mary), authors(:bob)], authors.distinct.sort_by(&:id)
-
-    # Check the polymorphism of taggings is being observed correctly (in both joins)
-    authors = Author.joins(:similar_posts).where('taggings.taggable_type' => 'FakeModel')
-    assert authors.empty?
-    authors = Author.joins(:similar_posts).where('taggings_authors_join.taggable_type' => 'FakeModel')
-    assert authors.empty?
-  end
-
-  def test_has_many_through_with_foreign_key_option_on_through_reflection
-    assert_equal [posts(:welcome), posts(:authorless)], people(:david).agents_posts.order('posts.id')
-    assert_equal [authors(:david)], references(:david_unicyclist).agents_posts_authors
-
-    references = Reference.joins(:agents_posts_authors).where('authors.id' => authors(:david).id)
-    assert_equal [references(:david_unicyclist)], references
-  end
-
-  def test_has_many_through_with_foreign_key_option_on_source_reflection
-    assert_equal [people(:michael), people(:susan)], jobs(:unicyclist).agents.order('people.id')
-
-    jobs = Job.joins(:agents)
-    assert_equal [jobs(:unicyclist), jobs(:unicyclist)], jobs
-  end
-
-  def test_has_many_through_with_sti_on_through_reflection
-    ratings = posts(:sti_comments).special_comments_ratings.sort_by(&:id)
-    assert_equal [ratings(:special_comment_rating), ratings(:sub_special_comment_rating)], ratings
-
-    # Ensure STI is respected in the join
-    scope = Post.joins(:special_comments_ratings).where(:id => posts(:sti_comments).id)
-    assert scope.where("comments.type" => "Comment").empty?
-    assert !scope.where("comments.type" => "SpecialComment").empty?
-    assert !scope.where("comments.type" => "SubSpecialComment").empty?
-  end
-
-  def test_has_many_through_with_sti_on_nested_through_reflection
-    taggings = posts(:sti_comments).special_comments_ratings_taggings
-    assert_equal [taggings(:special_comment_rating)], taggings
-
-    scope = Post.joins(:special_comments_ratings_taggings).where(:id => posts(:sti_comments).id)
-    assert scope.where("comments.type" => "Comment").empty?
-    assert !scope.where("comments.type" => "SpecialComment").empty?
-  end
-
-  def test_nested_has_many_through_writers_should_raise_error
-    david = authors(:david)
-    subscriber = subscribers(:first)
-
-    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
-      david.subscribers = [subscriber]
-    end
-
-    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
-      david.subscriber_ids = [subscriber.id]
-    end
-
-    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
-      david.subscribers << subscriber
-    end
-
-    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
-      david.subscribers.delete(subscriber)
-    end
-
-    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
-      david.subscribers.clear
-    end
-
-    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
-      david.subscribers.build
-    end
-
-    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
-      david.subscribers.create
-    end
-  end
-
-  def test_nested_has_one_through_writers_should_raise_error
-    groucho = members(:groucho)
-    founding = member_types(:founding)
-
-    assert_raises(ActiveRecord::HasOneThroughNestedAssociationsAreReadonly) do
-      groucho.nested_member_type = founding
-    end
-  end
-
-  def test_nested_has_many_through_with_conditions_on_through_associations
-    assert_equal [tags(:blue)], authors(:bob).misc_post_first_blue_tags
-  end
-
-  def test_nested_has_many_through_with_conditions_on_through_associations_preload
-    assert Author.where('tags.id' => 100).joins(:misc_post_first_blue_tags).empty?
-
-    authors = assert_queries(3) { Author.includes(:misc_post_first_blue_tags).to_a.sort_by(&:id) }
-    blue = tags(:blue)
-
-    assert_no_queries do
-      assert_equal [blue], authors[2].misc_post_first_blue_tags
-    end
-  end
-
-  def test_nested_has_many_through_with_conditions_on_through_associations_preload_via_joins
-    # Pointless condition to force single-query loading
-    assert_includes_and_joins_equal(
-      Author.where('tags.id = tags.id').references(:tags),
-      [authors(:bob)], :misc_post_first_blue_tags
-    )
-  end
-
-  def test_nested_has_many_through_with_conditions_on_source_associations
-    assert_equal [tags(:blue)], authors(:bob).misc_post_first_blue_tags_2
-  end
-
-  def test_nested_has_many_through_with_conditions_on_source_associations_preload
-    authors = assert_queries(4) { Author.includes(:misc_post_first_blue_tags_2).to_a.sort_by(&:id) }
-    blue = tags(:blue)
-
-    assert_no_queries do
-      assert_equal [blue], authors[2].misc_post_first_blue_tags_2
-    end
-  end
-
-  def test_nested_has_many_through_with_conditions_on_source_associations_preload_via_joins
-    # Pointless condition to force single-query loading
-    assert_includes_and_joins_equal(
-      Author.where('tags.id = tags.id').references(:tags),
-      [authors(:bob)], :misc_post_first_blue_tags_2
-    )
-  end
-
-  def test_nested_has_many_through_with_foreign_key_option_on_the_source_reflection_through_reflection
-    assert_equal [categories(:general)], organizations(:nsa).author_essay_categories
-
-    organizations = Organization.joins(:author_essay_categories).
-                                 where('categories.id' => categories(:general).id)
-    assert_equal [organizations(:nsa)], organizations
-
-    assert_equal categories(:general), organizations(:nsa).author_owned_essay_category
-
-    organizations = Organization.joins(:author_owned_essay_category).
-                                 where('categories.id' => categories(:general).id)
-    assert_equal [organizations(:nsa)], organizations
-  end
-
-  def test_nested_has_many_through_should_not_be_autosaved
-    c = Categorization.new
-    c.author = authors(:david)
-    c.post_taggings.to_a
-    assert !c.post_taggings.empty?
-    c.save
-    assert !c.post_taggings.empty?
-  end
-
-  private
-
-    def assert_includes_and_joins_equal(query, expected, association)
-      actual = assert_queries(1) { query.joins(association).to_a.uniq }
-      assert_equal expected, actual
-
-      actual = assert_queries(1) { query.includes(association).to_a.uniq }
-      assert_equal expected, actual
-    end
-end
+require "cases/helper"
+require 'models/author'
+require 'models/post'
+require 'models/person'
+require 'models/reference'
+require 'models/job'
+require 'models/reader'
+require 'models/comment'
+require 'models/tag'
+require 'models/tagging'
+require 'models/subscriber'
+require 'models/book'
+require 'models/subscription'
+require 'models/rating'
+require 'models/member'
+require 'models/member_detail'
+require 'models/member_type'
+require 'models/sponsor'
+require 'models/club'
+require 'models/organization'
+require 'models/category'
+require 'models/categorization'
+require 'models/membership'
+require 'models/essay'
+
+class NestedThroughAssociationsTest < ActiveRecord::TestCase
+  fixtures :authors, :books, :posts, :subscriptions, :subscribers, :tags, :taggings,
+           :people, :readers, :references, :jobs, :ratings, :comments, :members, :member_details,
+           :member_types, :sponsors, :clubs, :organizations, :categories, :categories_posts,
+           :categorizations, :memberships, :essays
+
+  # Through associations can either use the has_many or has_one macros.
+  #
+  # has_many
+  #   - Source reflection can be has_many, has_one, belongs_to or has_and_belongs_to_many
+  #   - Through reflection can be has_many, has_one, belongs_to or has_and_belongs_to_many
+  #
+  # has_one
+  #   - Source reflection can be has_one or belongs_to
+  #   - Through reflection can be has_one or belongs_to
+  #
+  # Additionally, the source reflection and/or through reflection may be subject to
+  # polymorphism and/or STI.
+  #
+  # When testing these, we need to make sure it works via loading the association directly, or
+  # joining the association, or including the association. We also need to ensure that associations
+  # are readonly where relevant.
+
+  # has_many through
+  # Source: has_many through
+  # Through: has_many
+  def test_has_many_through_has_many_with_has_many_through_source_reflection
+    general = tags(:general)
+    assert_equal [general, general], authors(:david).tags
+  end
+
+  def test_has_many_through_has_many_with_has_many_through_source_reflection_preload
+    authors = assert_queries(5) { Author.includes(:tags).to_a }
+    general = tags(:general)
+
+    assert_no_queries do
+      assert_equal [general, general], authors.first.tags
+    end
+  end
+
+  def test_has_many_through_has_many_with_has_many_through_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Author.where('tags.id' => tags(:general).id),
+      [authors(:david)], :tags
+    )
+
+    # This ensures that the polymorphism of taggings is being observed correctly
+    authors = Author.joins(:tags).where('taggings.taggable_type' => 'FakeModel')
+    assert authors.empty?
+  end
+
+  # has_many through
+  # Source: has_many
+  # Through: has_many through
+  def test_has_many_through_has_many_through_with_has_many_source_reflection
+    luke, david = subscribers(:first), subscribers(:second)
+    assert_equal [luke, david, david], authors(:david).subscribers.order('subscribers.nick')
+  end
+
+  def test_has_many_through_has_many_through_with_has_many_source_reflection_preload
+    luke, david = subscribers(:first), subscribers(:second)
+    authors = assert_queries(4) { Author.includes(:subscribers).to_a }
+    assert_no_queries do
+      assert_equal [luke, david, david], authors.first.subscribers.sort_by(&:nick)
+    end
+  end
+
+  def test_has_many_through_has_many_through_with_has_many_source_reflection_preload_via_joins
+    # All authors with subscribers where one of the subscribers' nick is 'alterself'
+    assert_includes_and_joins_equal(
+      Author.where('subscribers.nick' => 'alterself'),
+      [authors(:david)], :subscribers
+    )
+  end
+
+  # has_many through
+  # Source: has_one through
+  # Through: has_one
+  def test_has_many_through_has_one_with_has_one_through_source_reflection
+    assert_equal [member_types(:founding)], members(:groucho).nested_member_types
+  end
+
+  def test_has_many_through_has_one_with_has_one_through_source_reflection_preload
+    members = assert_queries(4) { Member.includes(:nested_member_types).to_a }
+    founding = member_types(:founding)
+    assert_no_queries do
+      assert_equal [founding], members.first.nested_member_types
+    end
+  end
+
+  def test_has_many_through_has_one_with_has_one_through_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Member.where('member_types.id' => member_types(:founding).id),
+      [members(:groucho)], :nested_member_types
+    )
+  end
+
+  # has_many through
+  # Source: has_one
+  # Through: has_one through
+  def test_has_many_through_has_one_through_with_has_one_source_reflection
+    assert_equal [sponsors(:moustache_club_sponsor_for_groucho)], members(:groucho).nested_sponsors
+  end
+
+  def test_has_many_through_has_one_through_with_has_one_source_reflection_preload
+    members = assert_queries(4) { Member.includes(:nested_sponsors).to_a }
+    mustache = sponsors(:moustache_club_sponsor_for_groucho)
+    assert_no_queries(ignore_none: false) do
+      assert_equal [mustache], members.first.nested_sponsors
+    end
+  end
+
+  def test_has_many_through_has_one_through_with_has_one_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Member.where('sponsors.id' => sponsors(:moustache_club_sponsor_for_groucho).id),
+      [members(:groucho)], :nested_sponsors
+    )
+  end
+
+  # has_many through
+  # Source: has_many through
+  # Through: has_one
+  def test_has_many_through_has_one_with_has_many_through_source_reflection
+    groucho_details, other_details = member_details(:groucho), member_details(:some_other_guy)
+
+    assert_equal [groucho_details, other_details],
+                 members(:groucho).organization_member_details.order('member_details.id')
+  end
+
+  def test_has_many_through_has_one_with_has_many_through_source_reflection_preload
+    ActiveRecord::Base.connection.table_alias_length  # preheat cache
+    members = assert_queries(4) { Member.includes(:organization_member_details).to_a.sort_by(&:id) }
+    groucho_details, other_details = member_details(:groucho), member_details(:some_other_guy)
+
+    assert_no_queries do
+      assert_equal [groucho_details, other_details], members.first.organization_member_details.sort_by(&:id)
+    end
+  end
+
+  def test_has_many_through_has_one_with_has_many_through_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Member.where('member_details.id' => member_details(:groucho).id).order('member_details.id'),
+      [members(:groucho), members(:some_other_guy)], :organization_member_details
+    )
+
+    members = Member.joins(:organization_member_details).
+                     where('member_details.id' => 9)
+    assert members.empty?
+  end
+
+  # has_many through
+  # Source: has_many
+  # Through: has_one through
+  def test_has_many_through_has_one_through_with_has_many_source_reflection
+    groucho_details, other_details = member_details(:groucho), member_details(:some_other_guy)
+
+    assert_equal [groucho_details, other_details],
+                 members(:groucho).organization_member_details_2.order('member_details.id')
+  end
+
+  def test_has_many_through_has_one_through_with_has_many_source_reflection_preload
+    members = assert_queries(4) { Member.includes(:organization_member_details_2).to_a.sort_by(&:id) }
+    groucho_details, other_details = member_details(:groucho), member_details(:some_other_guy)
+
+    # postgresql test if randomly executed then executes "SHOW max_identifier_length". Hence
+    # the need to ignore certain predefined sqls that deal with system calls.
+    assert_no_queries(ignore_none: false) do
+      assert_equal [groucho_details, other_details], members.first.organization_member_details_2.sort_by(&:id)
+    end
+  end
+
+  def test_has_many_through_has_one_through_with_has_many_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Member.where('member_details.id' => member_details(:groucho).id).order('member_details.id'),
+      [members(:groucho), members(:some_other_guy)], :organization_member_details_2
+    )
+
+    members = Member.joins(:organization_member_details_2).
+                     where('member_details.id' => 9)
+    assert members.empty?
+  end
+
+  # has_many through
+  # Source: has_and_belongs_to_many
+  # Through: has_many
+  def test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection
+    general, cooking = categories(:general), categories(:cooking)
+
+    assert_equal [general, cooking], authors(:bob).post_categories.order('categories.id')
+  end
+
+  def test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection_preload
+    authors = assert_queries(4) { Author.includes(:post_categories).to_a.sort_by(&:id) }
+    general, cooking = categories(:general), categories(:cooking)
+
+    assert_no_queries do
+      assert_equal [general, cooking], authors[2].post_categories.sort_by(&:id)
+    end
+  end
+
+  def test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection_preload_via_joins
+    # preload table schemas
+    Author.joins(:post_categories).first
+
+    assert_includes_and_joins_equal(
+      Author.where('categories.id' => categories(:cooking).id),
+      [authors(:bob)], :post_categories
+    )
+  end
+
+  # has_many through
+  # Source: has_many
+  # Through: has_and_belongs_to_many
+  def test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection
+    greetings, more = comments(:greetings), comments(:more_greetings)
+
+    assert_equal [greetings, more], categories(:technology).post_comments.order('comments.id')
+  end
+
+  def test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection_preload
+    Category.includes(:post_comments).to_a # preheat cache
+    categories = assert_queries(4) { Category.includes(:post_comments).to_a.sort_by(&:id) }
+    greetings, more = comments(:greetings), comments(:more_greetings)
+
+    assert_no_queries do
+      assert_equal [greetings, more], categories[1].post_comments.sort_by(&:id)
+    end
+  end
+
+  def test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection_preload_via_joins
+    # preload table schemas
+    Category.joins(:post_comments).first
+
+    assert_includes_and_joins_equal(
+      Category.where('comments.id' => comments(:more_greetings).id).order('categories.id'),
+      [categories(:general), categories(:technology)], :post_comments
+    )
+  end
+
+  # has_many through
+  # Source: has_many through a habtm
+  # Through: has_many through
+  def test_has_many_through_has_many_with_has_many_through_habtm_source_reflection
+    greetings, more = comments(:greetings), comments(:more_greetings)
+
+    assert_equal [greetings, more], authors(:bob).category_post_comments.order('comments.id')
+  end
+
+  def test_has_many_through_has_many_with_has_many_through_habtm_source_reflection_preload
+    authors = assert_queries(6) { Author.includes(:category_post_comments).to_a.sort_by(&:id) }
+    greetings, more = comments(:greetings), comments(:more_greetings)
+
+    assert_no_queries do
+      assert_equal [greetings, more], authors[2].category_post_comments.sort_by(&:id)
+    end
+  end
+
+  def test_has_many_through_has_many_with_has_many_through_habtm_source_reflection_preload_via_joins
+    # preload table schemas
+    Author.joins(:category_post_comments).first
+
+    assert_includes_and_joins_equal(
+      Author.where('comments.id' => comments(:does_it_hurt).id).order('authors.id'),
+      [authors(:david), authors(:mary)], :category_post_comments
+    )
+  end
+
+  # has_many through
+  # Source: belongs_to
+  # Through: has_many through
+  def test_has_many_through_has_many_through_with_belongs_to_source_reflection
+    assert_equal [tags(:general), tags(:general)], authors(:david).tagging_tags
+  end
+
+  def test_has_many_through_has_many_through_with_belongs_to_source_reflection_preload
+    authors = assert_queries(5) { Author.includes(:tagging_tags).to_a }
+    general = tags(:general)
+
+    assert_no_queries do
+      assert_equal [general, general], authors.first.tagging_tags
+    end
+  end
+
+  def test_has_many_through_has_many_through_with_belongs_to_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Author.where('tags.id' => tags(:general).id),
+      [authors(:david)], :tagging_tags
+    )
+  end
+
+  # has_many through
+  # Source: has_many through
+  # Through: belongs_to
+  def test_has_many_through_belongs_to_with_has_many_through_source_reflection
+    welcome_general, thinking_general = taggings(:welcome_general), taggings(:thinking_general)
+
+    assert_equal [welcome_general, thinking_general],
+                 categorizations(:david_welcome_general).post_taggings.order('taggings.id')
+  end
+
+  def test_has_many_through_belongs_to_with_has_many_through_source_reflection_preload
+    categorizations = assert_queries(4) { Categorization.includes(:post_taggings).to_a.sort_by(&:id) }
+    welcome_general, thinking_general = taggings(:welcome_general), taggings(:thinking_general)
+
+    assert_no_queries do
+      assert_equal [welcome_general, thinking_general], categorizations.first.post_taggings.sort_by(&:id)
+    end
+  end
+
+  def test_has_many_through_belongs_to_with_has_many_through_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Categorization.where('taggings.id' => taggings(:welcome_general).id).order('taggings.id'),
+      [categorizations(:david_welcome_general)], :post_taggings
+    )
+  end
+
+  # has_one through
+  # Source: has_one through
+  # Through: has_one
+  def test_has_one_through_has_one_with_has_one_through_source_reflection
+    assert_equal member_types(:founding), members(:groucho).nested_member_type
+  end
+
+  def test_has_one_through_has_one_with_has_one_through_source_reflection_preload
+    members = assert_queries(4) { Member.includes(:nested_member_type).to_a.sort_by(&:id) }
+    founding = member_types(:founding)
+
+    assert_no_queries do
+      assert_equal founding, members.first.nested_member_type
+    end
+  end
+
+  def test_has_one_through_has_one_with_has_one_through_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Member.where('member_types.id' => member_types(:founding).id),
+      [members(:groucho)], :nested_member_type
+    )
+  end
+
+  # has_one through
+  # Source: belongs_to
+  # Through: has_one through
+  def test_has_one_through_has_one_through_with_belongs_to_source_reflection
+    assert_equal categories(:general), members(:groucho).club_category
+  end
+
+  def test_joins_and_includes_from_through_models_not_included_in_association
+    prev_default_scope = Club.default_scopes
+
+    [:includes, :preload, :joins, :eager_load].each do |q|
+      Club.default_scopes = [proc { Club.send(q, :category) }]
+      assert_equal categories(:general), members(:groucho).reload.club_category
+    end
+  ensure
+    Club.default_scopes = prev_default_scope
+  end
+
+  def test_has_one_through_has_one_through_with_belongs_to_source_reflection_preload
+    members = assert_queries(4) { Member.includes(:club_category).to_a.sort_by(&:id) }
+    general = categories(:general)
+
+    assert_no_queries do
+      assert_equal general, members.first.club_category
+    end
+  end
+
+  def test_has_one_through_has_one_through_with_belongs_to_source_reflection_preload_via_joins
+    assert_includes_and_joins_equal(
+      Member.where('categories.id' => categories(:technology).id),
+      [members(:blarpy_winkup)], :club_category
+    )
+  end
+
+  def test_distinct_has_many_through_a_has_many_through_association_on_source_reflection
+    author = authors(:david)
+    assert_equal [tags(:general)], author.distinct_tags
+  end
+
+  def test_distinct_has_many_through_a_has_many_through_association_on_through_reflection
+    author = authors(:david)
+    assert_equal [subscribers(:first), subscribers(:second)],
+                 author.distinct_subscribers.order('subscribers.nick')
+  end
+
+  def test_nested_has_many_through_with_a_table_referenced_multiple_times
+    author = authors(:bob)
+    assert_equal [posts(:misc_by_bob), posts(:misc_by_mary), posts(:other_by_bob), posts(:other_by_mary)],
+                 author.similar_posts.sort_by(&:id)
+
+    # Mary and Bob both have posts in misc, but they are the only ones.
+    authors = Author.joins(:similar_posts).where('posts.id' => posts(:misc_by_bob).id)
+    assert_equal [authors(:mary), authors(:bob)], authors.distinct.sort_by(&:id)
+
+    # Check the polymorphism of taggings is being observed correctly (in both joins)
+    authors = Author.joins(:similar_posts).where('taggings.taggable_type' => 'FakeModel')
+    assert authors.empty?
+    authors = Author.joins(:similar_posts).where('taggings_authors_join.taggable_type' => 'FakeModel')
+    assert authors.empty?
+  end
+
+  def test_has_many_through_with_foreign_key_option_on_through_reflection
+    assert_equal [posts(:welcome), posts(:authorless)], people(:david).agents_posts.order('posts.id')
+    assert_equal [authors(:david)], references(:david_unicyclist).agents_posts_authors
+
+    references = Reference.joins(:agents_posts_authors).where('authors.id' => authors(:david).id)
+    assert_equal [references(:david_unicyclist)], references
+  end
+
+  def test_has_many_through_with_foreign_key_option_on_source_reflection
+    assert_equal [people(:michael), people(:susan)], jobs(:unicyclist).agents.order('people.id')
+
+    jobs = Job.joins(:agents)
+    assert_equal [jobs(:unicyclist), jobs(:unicyclist)], jobs
+  end
+
+  def test_has_many_through_with_sti_on_through_reflection
+    ratings = posts(:sti_comments).special_comments_ratings.sort_by(&:id)
+    assert_equal [ratings(:special_comment_rating), ratings(:sub_special_comment_rating)], ratings
+
+    # Ensure STI is respected in the join
+    scope = Post.joins(:special_comments_ratings).where(:id => posts(:sti_comments).id)
+    assert scope.where("comments.type" => "Comment").empty?
+    assert !scope.where("comments.type" => "SpecialComment").empty?
+    assert !scope.where("comments.type" => "SubSpecialComment").empty?
+  end
+
+  def test_has_many_through_with_sti_on_nested_through_reflection
+    taggings = posts(:sti_comments).special_comments_ratings_taggings
+    assert_equal [taggings(:special_comment_rating)], taggings
+
+    scope = Post.joins(:special_comments_ratings_taggings).where(:id => posts(:sti_comments).id)
+    assert scope.where("comments.type" => "Comment").empty?
+    assert !scope.where("comments.type" => "SpecialComment").empty?
+  end
+
+  def test_nested_has_many_through_writers_should_raise_error
+    david = authors(:david)
+    subscriber = subscribers(:first)
+
+    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
+      david.subscribers = [subscriber]
+    end
+
+    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
+      david.subscriber_ids = [subscriber.id]
+    end
+
+    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
+      david.subscribers << subscriber
+    end
+
+    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
+      david.subscribers.delete(subscriber)
+    end
+
+    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
+      david.subscribers.clear
+    end
+
+    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
+      david.subscribers.build
+    end
+
+    assert_raises(ActiveRecord::HasManyThroughNestedAssociationsAreReadonly) do
+      david.subscribers.create
+    end
+  end
+
+  def test_nested_has_one_through_writers_should_raise_error
+    groucho = members(:groucho)
+    founding = member_types(:founding)
+
+    assert_raises(ActiveRecord::HasOneThroughNestedAssociationsAreReadonly) do
+      groucho.nested_member_type = founding
+    end
+  end
+
+  def test_nested_has_many_through_with_conditions_on_through_associations
+    assert_equal [tags(:blue)], authors(:bob).misc_post_first_blue_tags
+  end
+
+  def test_nested_has_many_through_with_conditions_on_through_associations_preload
+    assert Author.where('tags.id' => 100).joins(:misc_post_first_blue_tags).empty?
+
+    authors = assert_queries(3) { Author.includes(:misc_post_first_blue_tags).to_a.sort_by(&:id) }
+    blue = tags(:blue)
+
+    assert_no_queries do
+      assert_equal [blue], authors[2].misc_post_first_blue_tags
+    end
+  end
+
+  def test_nested_has_many_through_with_conditions_on_through_associations_preload_via_joins
+    # Pointless condition to force single-query loading
+    assert_includes_and_joins_equal(
+      Author.where('tags.id = tags.id').references(:tags),
+      [authors(:bob)], :misc_post_first_blue_tags
+    )
+  end
+
+  def test_nested_has_many_through_with_conditions_on_source_associations
+    assert_equal [tags(:blue)], authors(:bob).misc_post_first_blue_tags_2
+  end
+
+  def test_nested_has_many_through_with_conditions_on_source_associations_preload
+    authors = assert_queries(4) { Author.includes(:misc_post_first_blue_tags_2).to_a.sort_by(&:id) }
+    blue = tags(:blue)
+
+    assert_no_queries do
+      assert_equal [blue], authors[2].misc_post_first_blue_tags_2
+    end
+  end
+
+  def test_nested_has_many_through_with_conditions_on_source_associations_preload_via_joins
+    # Pointless condition to force single-query loading
+    assert_includes_and_joins_equal(
+      Author.where('tags.id = tags.id').references(:tags),
+      [authors(:bob)], :misc_post_first_blue_tags_2
+    )
+  end
+
+  def test_nested_has_many_through_with_foreign_key_option_on_the_source_reflection_through_reflection
+    assert_equal [categories(:general)], organizations(:nsa).author_essay_categories
+
+    organizations = Organization.joins(:author_essay_categories).
+                                 where('categories.id' => categories(:general).id)
+    assert_equal [organizations(:nsa)], organizations
+
+    assert_equal categories(:general), organizations(:nsa).author_owned_essay_category
+
+    organizations = Organization.joins(:author_owned_essay_category).
+                                 where('categories.id' => categories(:general).id)
+    assert_equal [organizations(:nsa)], organizations
+  end
+
+  def test_nested_has_many_through_should_not_be_autosaved
+    c = Categorization.new
+    c.author = authors(:david)
+    c.post_taggings.to_a
+    assert !c.post_taggings.empty?
+    c.save
+    assert !c.post_taggings.empty?
+  end
+
+  private
+
+    def assert_includes_and_joins_equal(query, expected, association)
+      actual = assert_queries(1) { query.joins(association).to_a.uniq }
+      assert_equal expected, actual
+
+      actual = assert_queries(1) { query.includes(association).to_a.uniq }
+      assert_equal expected, actual
+    end
+end