hybrid_platforms_conductor 33.9.2 → 33.9.4

data/spec/hybrid_platforms_conductor_test/api/tests_runner/common_spec.rb

@@ -140,7 +140,7 @@ describe HybridPlatformsConductor::TestsRunner do
       register_test_plugins(test_tests_runner, several_tests: HybridPlatformsConductorTest::TestPlugins::SeveralChecks)
       # Mock the Actions Executor and Deployer expected calls
       expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-        expect(test_deployer.use_why_run).to eq true
+        expect(test_deployer.use_why_run).to be true
         {
           'node11' => [0, 'node11 check ok', 'node11 stderr'],
           'node12' => [0, 'node12 check ok', 'node12 stderr'],
@@ -153,7 +153,7 @@ describe HybridPlatformsConductor::TestsRunner do
         expect(actions.size).to eq node_suffixes.size
         node_suffixes.each do |node_suffix|
           node = "node#{node_suffix}"
-          expect(actions.key?(node)).to eq true
+          expect(actions.key?(node)).to be true
           expect(actions[node].size).to eq 1
           expect(actions[node][:remote_bash]).to eq [
             'echo \'===== TEST COMMAND EXECUTION ===== Separator generated by Hybrid Platforms Conductor test framework =====\'',
@@ -162,7 +162,7 @@ describe HybridPlatformsConductor::TestsRunner do
             'echo "$?"'
           ]
         end
-        node_suffixes.map do |node_suffix|
+        node_suffixes.to_h do |node_suffix|
           [
             "node#{node_suffix}",
             [
@@ -178,7 +178,7 @@ describe HybridPlatformsConductor::TestsRunner do
               EO_STDERR
             ]
           ]
-        end.to_h
+        end
       end])
       # Run everything
       test_tests_runner.tests = [:several_tests]
@@ -207,7 +207,7 @@ describe HybridPlatformsConductor::TestsRunner do
     with_test_platform({ tests: { specific_platform_handler_test: SpecificPlatformHandlerTest } }) do
       test_tests_runner.tests = [:specific_platform_handler_test]
       expect(test_tests_runner.run_tests([])).to eq 0
-      expect(SpecificPlatformHandlerTest.run).to eq true
+      expect(SpecificPlatformHandlerTest.run).to be true
     end
   end
 

data/spec/hybrid_platforms_conductor_test/api/tests_runner/node_check_spec.rb

@@ -26,7 +26,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
@@ -48,7 +48,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node12 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
             'node22' => [0, 'node22 check ok', 'node22 stderr']
@@ -66,7 +66,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = %i[node_check_test node_check_test_2]
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
@@ -92,7 +92,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [1, 'node12 check ok', 'node12 stderr'],
@@ -114,7 +114,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [1, 'node12 check ok', 'node12 stderr'],
@@ -178,7 +178,7 @@ describe HybridPlatformsConductor::TestsRunner do
         HybridPlatformsConductorTest::TestPlugins::NodeCheck.only_on_nodes = %w[node12 node22]
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node12 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
             'node22' => [0, 'node22 check ok', 'node22 stderr']

data/spec/hybrid_platforms_conductor_test/api/tests_runner/node_ssh_spec.rb

@@ -34,7 +34,7 @@ describe HybridPlatformsConductor::TestsRunner do
       expect(actions.size).to eq node_suffixes.size
       node_suffixes.each do |node_suffix|
         node = "node#{node_suffix}"
-        expect(actions.key?(node)).to eq true
+        expect(actions.key?(node)).to be true
         expect(actions[node].size).to eq 1
         expect(actions[node][:remote_bash]).to eq [
           'echo \'===== TEST COMMAND EXECUTION ===== Separator generated by Hybrid Platforms Conductor test framework =====\'',
@@ -43,7 +43,7 @@ describe HybridPlatformsConductor::TestsRunner do
           'echo "$?"'
         ]
       end
-      node_suffixes.map do |node_suffix|
+      node_suffixes.to_h do |node_suffix|
         [
           "node#{node_suffix}",
           [
@@ -59,7 +59,7 @@ describe HybridPlatformsConductor::TestsRunner do
             EO_STDERR
           ]
         ]
-      end.to_h
+      end
     end
 
     it 'executes SSH node tests once per node with the correct command' do
@@ -120,7 +120,7 @@ describe HybridPlatformsConductor::TestsRunner do
           expect(actions.size).to eq node_suffixes.size
           node_suffixes.each do |node_suffix|
             node = "node#{node_suffix}"
-            expect(actions.key?(node)).to eq true
+            expect(actions.key?(node)).to be true
             expect(actions[node].size).to eq 1
             expect(actions[node][:remote_bash]).to eq [
               'echo \'===== TEST COMMAND EXECUTION ===== Separator generated by Hybrid Platforms Conductor test framework =====\'',
@@ -133,7 +133,7 @@ describe HybridPlatformsConductor::TestsRunner do
               'echo "$?"'
             ]
           end
-          node_suffixes.map do |node_suffix|
+          node_suffixes.to_h do |node_suffix|
             [
               "node#{node_suffix}",
               [
@@ -154,7 +154,7 @@ describe HybridPlatformsConductor::TestsRunner do
                 EO_STDERR
               ]
             ]
-          end.to_h
+          end
         end])
         test_tests_runner.tests = %i[node_ssh_test node_ssh_test_2]
         ssh_executions = []

data/spec/hybrid_platforms_conductor_test/api/tests_runner/reports_spec.rb

@@ -208,7 +208,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platforms_for_reports_test do
         # Mock the Actions Executor and Deployer expected calls
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
@@ -221,7 +221,7 @@ describe HybridPlatformsConductor::TestsRunner do
           expect(actions.size).to eq node_suffixes.size
           node_suffixes.each do |node_suffix|
             node = "node#{node_suffix}"
-            expect(actions.key?(node)).to eq true
+            expect(actions.key?(node)).to be true
             expect(actions[node].size).to eq 1
             expect(actions[node][:remote_bash]).to eq [
               'echo \'===== TEST COMMAND EXECUTION ===== Separator generated by Hybrid Platforms Conductor test framework =====\'',
@@ -230,7 +230,7 @@ describe HybridPlatformsConductor::TestsRunner do
               'echo "$?"'
             ]
           end
-          node_suffixes.map do |node_suffix|
+          node_suffixes.to_h do |node_suffix|
             [
               "node#{node_suffix}",
               [
@@ -246,7 +246,7 @@ describe HybridPlatformsConductor::TestsRunner do
                 EO_STDERR
               ]
             ]
-          end.to_h
+          end
         end])
         # Run everything
         test_tests_runner.tests = [:several_tests]

data/spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb.rb

@@ -40,7 +40,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_upcase(nodes, metadata)
         record_call(:get_upcase, nodes, metadata)
-        nodes.map { |node| [node, node.upcase] }.to_h
+        nodes.to_h { |node| [node, node.upcase] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -55,7 +55,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_double(nodes, metadata)
         record_call(:get_double, nodes, metadata)
-        nodes.map { |node| [node, node * 2] }.to_h
+        nodes.to_h { |node| [node, node * 2] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -70,7 +70,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_reversed_double(nodes, metadata)
         record_call(:get_reversed_double, nodes, metadata)
-        nodes.map { |node| [node, metadata[node][:double].reverse] }.to_h
+        nodes.to_h { |node| [node, metadata[node][:double].reverse] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -85,7 +85,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_reversed_downcase(nodes, metadata)
         record_call(:get_reversed_downcase, nodes, metadata)
-        nodes.map { |node| [node, metadata[node][:downcase] ? metadata[node][:downcase].reverse : 'UNKNOWN'] }.to_h
+        nodes.to_h { |node| [node, metadata[node][:downcase] ? metadata[node][:downcase].reverse : 'UNKNOWN'] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -115,7 +115,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_same_comment(nodes, metadata)
         record_call(:get_same_comment, nodes, metadata)
-        nodes.map { |node| [node, "Comment for #{node}"] }.to_h
+        nodes.to_h { |node| [node, "Comment for #{node}"] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -130,7 +130,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_different_comment(nodes, metadata)
         record_call(:get_different_comment, nodes, metadata)
-        nodes.map { |node| [node, 'Comment from test_cmdb'] }.to_h
+        nodes.to_h { |node| [node, 'Comment from test_cmdb'] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -145,7 +145,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_different_comment_2(nodes, metadata)
         record_call(:get_different_comment_2, nodes, metadata)
-        nodes.map { |node| [node, 'Comment2 from test_cmdb'] }.to_h
+        nodes.to_h { |node| [node, 'Comment2 from test_cmdb'] }
       end
 
       # Register a call to be checked by the tests later
@@ -156,7 +156,7 @@ module HybridPlatformsConductorTest
       def record_call(method, *args)
         @calls = [] unless defined?(@calls)
         # Create a shallow copy of the args, just to make sure they won't get changed by later code
-        @calls << [method] + Marshal.load(Marshal.dump(args))
+        @calls << ([method] + Marshal.load(Marshal.dump(args)))
       end
 
     end

data/spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb_2.rb

@@ -27,7 +27,7 @@ module HybridPlatformsConductorTest
       def get_nothing(nodes, metadata)
         record_call(:get_nothing, nodes, metadata)
         # Here we return something to test that if the first one fails we have the second CMDB
-        nodes.map { |node| [node, "#{node} has nothing"] }.to_h
+        nodes.to_h { |node| [node, "#{node} has nothing"] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -42,7 +42,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_same_comment(nodes, metadata)
         record_call(:get_same_comment, nodes, metadata)
-        nodes.map { |node| [node, "Comment for #{node}"] }.to_h
+        nodes.to_h { |node| [node, "Comment for #{node}"] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -57,7 +57,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_different_comment(nodes, metadata)
         record_call(:get_different_comment, nodes, metadata)
-        nodes.map { |node| [node, 'Comment from test_cmdb_2'] }.to_h
+        nodes.to_h { |node| [node, 'Comment from test_cmdb_2'] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -72,7 +72,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_different_comment_2(nodes, metadata)
         record_call(:get_different_comment_2, nodes, metadata)
-        nodes.map { |node| [node, 'Comment2 from test_cmdb_2'] }.to_h
+        nodes.to_h { |node| [node, 'Comment2 from test_cmdb_2'] }
       end
 
       # Register a call to be checked by the tests later
@@ -83,7 +83,7 @@ module HybridPlatformsConductorTest
       def record_call(method, *args)
         @calls = [] unless defined?(@calls)
         # Create a shallow copy of the args, just to make sure they won't get changed by later code
-        @calls << [method] + Marshal.load(Marshal.dump(args))
+        @calls << ([method] + Marshal.load(Marshal.dump(args)))
       end
 
     end

data/spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb_others.rb

@@ -30,7 +30,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_others(nodes, metadata)
         record_call(:get_others, nodes, metadata)
-        nodes.map do |node|
+        nodes.to_h do |node|
           [
             node,
             {
@@ -39,7 +39,7 @@ module HybridPlatformsConductorTest
               nothing: "#{node} has another nothing"
             }
           ]
-        end.to_h
+        end
       end
 
       # Register a call to be checked by the tests later
@@ -50,7 +50,7 @@ module HybridPlatformsConductorTest
       def record_call(method, *args)
         @calls = [] unless defined?(@calls)
         # Create a shallow copy of the args, just to make sure they won't get changed by later code
-        @calls << [method] + Marshal.load(Marshal.dump(args))
+        @calls << ([method] + Marshal.load(Marshal.dump(args)))
       end
 
     end

data/spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb_others_2.rb

@@ -30,14 +30,14 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_others(nodes, metadata)
         record_call(:get_others, nodes, metadata)
-        nodes.map do |node|
+        nodes.to_h do |node|
           [
             node,
             {
               downcase: "__#{node}__"
             }
           ]
-        end.to_h
+        end
       end
 
       # Register a call to be checked by the tests later
@@ -48,7 +48,7 @@ module HybridPlatformsConductorTest
       def record_call(method, *args)
         @calls = [] unless defined?(@calls)
         # Create a shallow copy of the args, just to make sure they won't get changed by later code
-        @calls << [method] + Marshal.load(Marshal.dump(args))
+        @calls << ([method] + Marshal.load(Marshal.dump(args)))
       end
 
     end

data/spec/hybrid_platforms_conductor_test/docs_spec.rb

@@ -3,7 +3,7 @@ describe 'Documentation' do
   it 'makes sure all Markdown links are valid' do
     check_stdout = `bundle exec tools/check_md README.md #{Dir.glob('docs/**/*.md').join(' ')}`.split("\n")
     summary_idx = check_stdout.index { |line| line =~ /^\d+ errors:$/ }
-    expect(summary_idx).not_to eq(nil), "Could not parse check output: #{check_stdout.join("\n")}"
+    expect(summary_idx).not_to be_nil, "Could not parse check output: #{check_stdout.join("\n")}"
     expect(check_stdout[summary_idx]).to eq('0 errors:'), "Invalid links found: #{check_stdout[summary_idx..].join("\n")}"
   end
 

data/spec/hybrid_platforms_conductor_test/executables/check_node_spec.rb

@@ -13,7 +13,7 @@ describe 'check-node executable' do
   it 'checks a given node' do
     with_test_platform_for_check_node do
       expect(test_deployer).to receive(:deploy_on).with('node') do
-        expect(test_deployer.use_why_run).to eq true
+        expect(test_deployer.use_why_run).to be true
         test_deployer.stdout_device << "Check ok\n"
         { 'node' => [0, "Check ok\n", ''] }
       end

data/spec/hybrid_platforms_conductor_test/executables/deploy_spec.rb

@@ -13,7 +13,7 @@ describe 'deploy executable' do
   it 'deploys a given node' do
     with_test_platform_for_deploy do
       expect(test_deployer).to receive(:deploy_on).with(['node']) do
-        expect(test_deployer.use_why_run).to eq false
+        expect(test_deployer.use_why_run).to be false
         test_deployer.stdout_device << "Deploy ok\n"
         { 'node' => [0, "Deploy ok\n", ''] }
       end

data/spec/hybrid_platforms_conductor_test/executables/options/cmd_runner_spec.rb

@@ -13,7 +13,7 @@ describe 'executables\' Cmd Runner options' do
   it 'displays commands instead of running them' do
     with_test_platform_for_cmd_runner_options do
       expect_actions_executor_runs([proc do
-        expect(test_cmd_runner.dry_run).to eq true
+        expect(test_cmd_runner.dry_run).to be true
         {}
       end])
       exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--show-commands'

data/spec/hybrid_platforms_conductor_test/executables/options/deployer_spec.rb

@@ -13,7 +13,7 @@ describe 'executables\' Deployer options' do
   it 'uses parallel mode' do
     with_test_platform_for_deployer_options do
       expect(test_deployer).to receive(:deploy_on).with(['node']) do
-        expect(test_deployer.concurrent_execution).to eq true
+        expect(test_deployer.concurrent_execution).to be true
         {}
       end
       exit_code, _stdout, stderr = run 'deploy', '--node', 'node', '--parallel'
@@ -25,7 +25,7 @@ describe 'executables\' Deployer options' do
   it 'uses why-run' do
     with_test_platform_for_deployer_options do
       expect(test_deployer).to receive(:deploy_on).with(['node']) do
-        expect(test_deployer.use_why_run).to eq true
+        expect(test_deployer.use_why_run).to be true
         {}
       end
       exit_code, _stdout, stderr = run 'deploy', '--node', 'node', '--why-run'

data/spec/hybrid_platforms_conductor_test/executables/options/nodes_handler_spec.rb

@@ -63,6 +63,7 @@ describe 'executables\' Nodes Handler options' do
   it 'displays info about nodes' do
     with_test_platform_for_nodes_handler_options do
       with_cmd_runner_mocked [
+        ['command -v getent', proc { [0, '', ''] }],
         ['getent hosts my_host15.my_domain', proc { [0, '192.168.42.15 my_host16.my_domain', ''] }],
         ['getent hosts my_host16.my_domain', proc { [0, '192.168.42.16 my_host16.my_domain', ''] }]
       ] do

data/spec/hybrid_platforms_conductor_test/executables/options/tests_runner_spec.rb

@@ -61,7 +61,7 @@ describe 'executables\' Tests Runner options' do
   it 'uses current run_logs instead of executing new check-nodes' do
     with_test_platform({}) do
       expect(test_tests_runner).to receive(:run_tests).with([]) do
-        expect(test_tests_runner.skip_run).to eq true
+        expect(test_tests_runner.skip_run).to be true
         0
       end
       exit_code, stdout, stderr = run 'test', '--test', 'my_test', '--skip-run'

data/spec/hybrid_platforms_conductor_test/executables/report_spec.rb

@@ -47,6 +47,7 @@ describe 'report executable' do
       }
     ) do
       with_cmd_runner_mocked [
+        ['command -v getent', proc { [0, '', ''] }],
         ['getent hosts node.domain.com', proc { [0, '192.168.0.1 node.domain.com', ''] }]
       ] do
         exit_code, stdout, stderr = run 'report', '--node', 'node'

data/spec/hybrid_platforms_conductor_test/executables/run_spec.rb

@@ -73,7 +73,7 @@ describe 'run executable' do
   it 'executes a single command on several nodes' do
     with_test_platform_for_run do
       expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
-        expect(concurrent).to eq false
+        expect(concurrent).to be false
         expect(actions).to eq(%w[node1 node2] => [{ remote_bash: ['echo Hello'] }])
         test_actions_executor.stdout_device << "Hello\nHello\n"
         { 'node1' => [0, "Hello\nHello\n", ''] }
@@ -133,7 +133,7 @@ describe 'run executable' do
   it 'executes in parallel' do
     with_test_platform_for_run do
       expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
-        expect(concurrent).to eq true
+        expect(concurrent).to be true
         expect(actions).to eq(%w[node1 node2] => [{ remote_bash: ['echo Hello'] }])
         test_actions_executor.stdout_device << "Hello\nHello\n"
         { 'node1' => [0, "Hello\nHello\n", ''] }

data/spec/hybrid_platforms_conductor_test/helpers/actions_executor_helpers.rb

@@ -58,7 +58,7 @@ module HybridPlatformsConductorTest
       def with_connections_mocked_on(expected_nodes)
         expect(test_actions_executor).to receive(:with_connections_prepared_to) do |nodes, no_exception: false, &client_code|
           expect(nodes.sort).to eq expected_nodes.sort
-          client_code.call nodes.map { |node| [node, test_actions_executor.connector(:test_connector)] }.to_h
+          client_code.call(nodes.to_h { |node| [node, test_actions_executor.connector(:test_connector)] })
         end
         yield
       end

data/spec/hybrid_platforms_conductor_test/helpers/cmdb_helpers.rb

@@ -21,12 +21,12 @@ module HybridPlatformsConductorTest
       def register_test_cmdb(cmdb_names = [:test_cmdb])
         register_plugins(
           :cmdb,
-          cmdb_names.map do |plugin_id|
+          cmdb_names.to_h do |plugin_id|
             [
               plugin_id,
               HybridPlatformsConductorTest::CmdbPlugins.const_get(plugin_id.to_s.split('_').collect(&:capitalize).join.to_sym)
             ]
-          end.to_h
+          end
         )
       end
 

data/spec/hybrid_platforms_conductor_test/helpers/connector_ssh_helpers.rb

@@ -105,7 +105,7 @@ module HybridPlatformsConductorTest
               { optional: with_control_master_destroy_optional }
             ]
           end
-          ssh_commands_once + ssh_commands_per_connection * node_connection_info[:times]
+          ssh_commands_once + (ssh_commands_per_connection * node_connection_info[:times])
         end.flatten(1)
       end
 

data/spec/hybrid_platforms_conductor_test/helpers/deployer_helpers.rb

@@ -40,10 +40,10 @@ module HybridPlatformsConductorTest
       # * Hash<String, [Integer or Symbol, String, String] >: Expected result of those expected actions
       def expect_actions_to_deploy_on(actions, nodes, check: false, sudo: 'sudo -u root', expected_actions: [], mocked_result: nil)
         nodes = [nodes] if nodes.is_a?(String)
-        mocked_result = nodes.map { |node| [node, [0, "#{check ? 'Check' : 'Deploy'} successful", '']] }.to_h if mocked_result.nil?
+        mocked_result = nodes.to_h { |node| [node, [0, "#{check ? 'Check' : 'Deploy'} successful", '']] } if mocked_result.nil?
         expect(actions.size).to eq nodes.size
         nodes.each do |node|
-          expect(actions.key?(node)).to eq true
+          expect(actions.key?(node)).to be true
           expect(actions[node].size).to eq(2 + expected_actions.size)
           expect_action_to_lock_node(actions[node][0], node, sudo: sudo)
           expect(actions[node][1..-2]).to eq expected_actions
@@ -62,10 +62,10 @@ module HybridPlatformsConductorTest
         nodes = [nodes] if nodes.is_a?(String)
         expect(actions.size).to eq nodes.size
         nodes.each do |node|
-          expect(actions.key?(node)).to eq true
+          expect(actions.key?(node)).to be true
           expect_action_to_unlock_node(actions[node], node, sudo: sudo)
         end
-        nodes.map { |node| [node, [0, 'Release mutex successful', '']] }.to_h
+        nodes.to_h { |node| [node, [0, 'Release mutex successful', '']] }
       end
 
       # Expect a given set of actions to upload log files on a list of nodes (using the test_log log plugin)
@@ -77,10 +77,10 @@ module HybridPlatformsConductorTest
         nodes = [nodes] if nodes.is_a?(String)
         expect(actions.size).to eq nodes.size
         nodes.each do |node|
-          expect(actions.key?(node)).to eq true
+          expect(actions.key?(node)).to be true
           expect(actions[node]).to eq [{ bash: "echo Save test logs to #{node}" }]
         end
-        nodes.map { |node| [node, [0, 'Logs uploaded', '']] }.to_h
+        nodes.to_h { |node| [node, [0, 'Logs uploaded', '']] }
       end
 
       # Get a test Deployer
@@ -325,7 +325,7 @@ module HybridPlatformsConductorTest
         expect_actions_executor_runs(statuses.map do |status|
           status = { 'node' => status } if status.is_a?(Array)
           expected_actions_for_deploy_on(
-            services: status.keys.map { |node| [node, %w[service]] }.to_h,
+            services: status.keys.to_h { |node| [node, %w[service]] },
             mocked_deploy_result: status
           )
         end.flatten)

data/spec/hybrid_platforms_conductor_test/helpers/platforms_handler_helpers.rb

@@ -14,7 +14,7 @@ module HybridPlatformsConductorTest
       #   * Parameters::
       #     * *repositories* (Hash<String,String>): Path to the repositories, per repository name
       def with_repositories(names = [], as_git: false)
-        repositories = names.map { |name| [name, "#{Dir.tmpdir}/hpc_test/#{name}"] }.to_h
+        repositories = names.to_h { |name| [name, "#{Dir.tmpdir}/hpc_test/#{name}"] }
         repositories.each_value do |dir|
           FileUtils.rm_rf dir
           FileUtils.mkdir_p dir
@@ -91,12 +91,12 @@ module HybridPlatformsConductorTest
               "#{platform_type}_platform path: '#{dir}'#{platforms_info[platform].key?(:name) ? ", name: '#{platforms_info[platform][:name]}'" : ''}"
             end.join("\n") + "\n#{additional_config}"
           ) do
-            register_platform_handlers(platform_types.map do |platform_type|
+            register_platform_handlers(platform_types.to_h do |platform_type|
               [
                 platform_type,
                 HybridPlatformsConductorTest::PlatformHandlerPlugins.const_get(platform_type.to_s.split('_').collect(&:capitalize).join.to_sym)
               ]
-            end.to_h)
+            end)
             self.test_platforms_info = platforms_info
             yield repositories
           end