hybrid_platforms_conductor 33.9.2 → 33.9.4

data/spec/hybrid_platforms_conductor_test/api/actions_executor/actions/bash_spec.rb

@@ -54,7 +54,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             },
             log_to_dir: logs_dir
           )
-          expect(File.exist?("#{logs_dir}/node.stdout")).to eq true
+          expect(File.exist?("#{logs_dir}/node.stdout")).to be true
           expect(File.read("#{logs_dir}/node.stdout")).to eq "TestStdout\nTestStderr\n"
         end
       end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/actions/ruby_spec.rb

@@ -18,7 +18,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             }
           )['node']
         ).to eq [0, 'TestStdout', 'TestStderr']
-        expect(executed).to eq true
+        expect(executed).to be true
       end
     end
 
@@ -38,7 +38,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             timeout: 1
           )['node']
         ).to eq [:timeout, '', '']
-        expect(executed).to eq false
+        expect(executed).to be false
       end
     end
 
@@ -54,7 +54,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             } },
             log_to_dir: logs_dir
           )
-          expect(File.exist?("#{logs_dir}/node.stdout")).to eq true
+          expect(File.exist?("#{logs_dir}/node.stdout")).to be true
           expect(File.read("#{logs_dir}/node.stdout")).to eq "TestStdout\nTestStderr\n"
         end
       end
@@ -68,7 +68,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             {
               'node' => {
                 ruby: proc do |stdout, stderr, action|
-                  expect(action.is_a?(HybridPlatformsConductor::HpcPlugins::Action::Ruby)).to eq true
+                  expect(action.is_a?(HybridPlatformsConductor::HpcPlugins::Action::Ruby)).to be true
                   stdout << 'TestStdout'
                   stderr << 'TestStderr'
                   executed = true
@@ -77,7 +77,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             }
           )['node']
         ).to eq [0, 'TestStdout', 'TestStderr']
-        expect(executed).to eq true
+        expect(executed).to be true
       end
     end
 
@@ -90,7 +90,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
               'node' => {
                 ruby: {
                   code: proc do |stdout, stderr, _action, connector|
-                    expect(connector.is_a?(HybridPlatformsConductorTest::TestConnector)).to eq true
+                    expect(connector.is_a?(HybridPlatformsConductorTest::TestConnector)).to be true
                     stdout << 'TestStdout'
                     stderr << 'TestStderr'
                     executed = true
@@ -101,7 +101,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             }
           )['node']
         ).to eq [0, 'TestStdout', 'TestStderr']
-        expect(executed).to eq true
+        expect(executed).to be true
       end
     end
 
@@ -125,7 +125,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             }
           )['node']
         ).to eq [0, 'TestStdout', 'TestStderr']
-        expect(executed).to eq true
+        expect(executed).to be true
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/cli_options_spec.rb

@@ -60,7 +60,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       it 'does not use the SSH control master' do
         with_test_platform_for_cli do
           expect_actions_executor_runs [proc do
-            expect(test_connector.ssh_use_control_master).to eq false
+            expect(test_connector.ssh_use_control_master).to be false
             {}
           end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-no-control-master'
@@ -73,7 +73,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       it 'does not use strict host key checking' do
         with_test_platform_for_cli do
           expect_actions_executor_runs [proc do
-            expect(test_connector.ssh_strict_host_key_checking).to eq false
+            expect(test_connector.ssh_strict_host_key_checking).to be false
             {}
           end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-no-host-key-checking'
@@ -111,7 +111,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       it 'expects passwords to be input' do
         with_test_platform_for_cli do
           expect_actions_executor_runs [proc do
-            expect(test_connector.auth_password).to eq true
+            expect(test_connector.auth_password).to be true
             {}
           end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--password'

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/connections_spec.rb

@@ -536,14 +536,14 @@ describe HybridPlatformsConductor::ActionsExecutor do
               test_connector.with_connection_to(['node']) do
                 test_connector.prepare_for('node', nil, stdout, stderr)
                 ssh_exec_2 = test_connector.ssh_exec
-                expect(File.exist?(ssh_exec_1)).to eq true
-                expect(File.exist?(ssh_exec_2)).to eq true
+                expect(File.exist?(ssh_exec_1)).to be true
+                expect(File.exist?(ssh_exec_2)).to be true
               end
-              expect(File.exist?(ssh_exec_1)).to eq true
-              expect(File.exist?(ssh_exec_2)).to eq false
+              expect(File.exist?(ssh_exec_1)).to be true
+              expect(File.exist?(ssh_exec_2)).to be false
             end
-            expect(File.exist?(ssh_exec_1)).to eq false
-            expect(File.exist?(ssh_exec_2)).to eq false
+            expect(File.exist?(ssh_exec_1)).to be false
+            expect(File.exist?(ssh_exec_2)).to be false
           end
         end
       end
@@ -590,13 +590,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] +
-              [[
+              ([[
                 %r{^.+/ssh -o BatchMode=yes -o ControlMaster=yes -o ControlPersist=yes hpc\.node true$},
                 proc do
                   nbr_boot_messages += 1
                   [255, '', "System is booting up. See pam_nologin(8)\nAuthentication failed.\n"]
                 end
-              ]] * 3 +
+              ]] * 3) +
               ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } })
           ) do
             test_connector.ssh_user = 'test_user'

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/global_helpers_spec.rb

@@ -246,7 +246,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             Host hpc.node1
               Hostname 192.168.42.1
           EO_SSH_CONFIG
-          expect(ssh_config_for('node2', nodes: %w[node1 node3])).to eq nil
+          expect(ssh_config_for('node2', nodes: %w[node1 node3])).to be_nil
         end
       end
 

data/spec/hybrid_platforms_conductor_test/api/actions_executor/helpers_spec.rb

@@ -11,14 +11,14 @@ describe HybridPlatformsConductor::ActionsExecutor do
     it 'returns if a user has privileged access on a node' do
       with_test_platform({ nodes: { 'node' => {} } }) do
         test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-        expect(test_actions_executor.privileged_access?('node')).to eq false
+        expect(test_actions_executor.privileged_access?('node')).to be false
       end
     end
 
     it 'returns if a user has privileged access on a node when connecting with root' do
       with_test_platform({ nodes: { 'node' => {} } }) do
         test_actions_executor.connector(:ssh).ssh_user = 'root'
-        expect(test_actions_executor.privileged_access?('node')).to eq true
+        expect(test_actions_executor.privileged_access?('node')).to be true
       end
     end
 
@@ -28,7 +28,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
           ['whoami', proc { [0, 'test_user', ''] }]
         ] do
           test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-          expect(test_actions_executor.privileged_access?('node')).to eq false
+          expect(test_actions_executor.privileged_access?('node')).to be false
         end
       end
     end
@@ -39,7 +39,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
           ['whoami', proc { [0, 'root', ''] }]
         ] do
           test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-          expect(test_actions_executor.privileged_access?('node')).to eq true
+          expect(test_actions_executor.privileged_access?('node')).to be true
         end
       end
     end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/timeout_spec.rb

@@ -15,7 +15,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
         expect(test_actions_executor.execute_actions(
           {
             'node' => { test_action: { code: proc do |stdout, _stderr, action|
-              expect(action.timeout).to eq nil
+              expect(action.timeout).to be_nil
               stdout << 'Hello'
             end } }
           }

data/spec/hybrid_platforms_conductor_test/api/cmd_runner_spec.rb

@@ -168,7 +168,7 @@ describe HybridPlatformsConductor::CmdRunner do
       cmd_runner = test_cmd_runner
       cmd_runner.dry_run = true
       expect(cmd_runner.run_cmd("echo TestContent >#{repository}/test_file")).to eq [0, '', '']
-      expect(File.exist?("#{repository}/test_file")).to eq false
+      expect(File.exist?("#{repository}/test_file")).to be false
     end
   end
 
@@ -177,7 +177,7 @@ describe HybridPlatformsConductor::CmdRunner do
       cmd_runner = test_cmd_runner
       cmd_runner.dry_run = true
       expect(cmd_runner.run_cmd("echo TestContent >#{repository}/test_file", expected_code: 2)).to eq [2, '', '']
-      expect(File.exist?("#{repository}/test_file")).to eq false
+      expect(File.exist?("#{repository}/test_file")).to be false
     end
   end
 
@@ -190,13 +190,13 @@ describe HybridPlatformsConductor::CmdRunner do
   it 'returns non-root user when user is not root' do
     cmd_runner = test_cmd_runner
     expect(cmd_runner).to receive(:run_cmd).with('whoami', log_to_stdout: false).and_return [0, 'not_root', '']
-    expect(cmd_runner.root?).to eq false
+    expect(cmd_runner.root?).to be false
   end
 
   it 'returns root user when user is root' do
     cmd_runner = test_cmd_runner
     expect(cmd_runner).to receive(:run_cmd).with('whoami', log_to_stdout: false).and_return [0, 'root', '']
-    expect(cmd_runner.root?).to eq true
+    expect(cmd_runner.root?).to be true
   end
 
   it 'returns the correct executable prefix' do

data/spec/hybrid_platforms_conductor_test/api/deployer/log_plugins/remote_fs_spec.rb

@@ -34,7 +34,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(actions_per_nodes['node'][0].keys.sort).to eq %i[ruby remote_bash].sort
                 expect(actions_per_nodes['node'][0][:remote_bash]).to eq 'sudo -u root mkdir -p /var/log/deployments && sudo -u root chmod 600 /var/log/deployments'
                 expect(actions_per_nodes['node'][1].keys.sort).to eq %i[scp].sort
-                expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to eq true
+                expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to be true
                 expect(actions_per_nodes['node'][1][:scp].delete(:owner)).to eq 'root'
                 expect(actions_per_nodes['node'][1][:scp].delete(:group)).to eq 'root'
                 expect(actions_per_nodes['node'][1][:scp].size).to eq 1
@@ -44,7 +44,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(actions_per_nodes['node'][2][:remote_bash]).to eq "sudo -u root chmod 600 /var/log/deployments/#{File.basename(tmp_log_file)}"
                 # Call the Ruby codes to be tested
                 actions_per_nodes['node'][0][:ruby].call
-                expect(File.exist?(tmp_log_file)).to eq true
+                expect(File.exist?(tmp_log_file)).to be true
                 file_content_regexp = Regexp.new <<~EOREGEXP
                   repo_name_0: platform
                   commit_id_0: 123456
@@ -62,7 +62,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(File.read(tmp_log_file)).to match file_content_regexp
                 actions_per_nodes['node'][2][:ruby].call
                 # Check temporary log file gets deleted for security reasons
-                expect(File.exist?(tmp_log_file)).to eq false
+                expect(File.exist?(tmp_log_file)).to be false
               end
             ]
             expect(test_deployer.deploy_on('node')).to eq('node' => [0, 'Deploy successful stdout', 'Deploy successful stderr'])
@@ -93,7 +93,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(actions_per_nodes['node'][0].keys.sort).to eq %i[ruby remote_bash].sort
                 expect(actions_per_nodes['node'][0][:remote_bash]).to eq 'mkdir -p /var/log/deployments && chmod 600 /var/log/deployments'
                 expect(actions_per_nodes['node'][1].keys.sort).to eq %i[scp].sort
-                expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to eq false
+                expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to be false
                 expect(actions_per_nodes['node'][1][:scp].delete(:owner)).to eq 'root'
                 expect(actions_per_nodes['node'][1][:scp].delete(:group)).to eq 'root'
                 expect(actions_per_nodes['node'][1][:scp].size).to eq 1
@@ -103,7 +103,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(actions_per_nodes['node'][2][:remote_bash]).to eq "chmod 600 /var/log/deployments/#{File.basename(tmp_log_file)}"
                 # Call the Ruby codes to be tested
                 actions_per_nodes['node'][0][:ruby].call
-                expect(File.exist?(tmp_log_file)).to eq true
+                expect(File.exist?(tmp_log_file)).to be true
                 file_content_regexp = Regexp.new <<~EOREGEXP
                   repo_name_0: platform
                   commit_id_0: 123456
@@ -121,7 +121,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(File.read(tmp_log_file)).to match file_content_regexp
                 actions_per_nodes['node'][2][:ruby].call
                 # Check temporary log file gets deleted for security reasons
-                expect(File.exist?(tmp_log_file)).to eq false
+                expect(File.exist?(tmp_log_file)).to be false
               end
             ]
             expect(test_deployer.deploy_on('node')).to eq('node' => [0, 'Deploy successful stdout', 'Deploy successful stderr'])
@@ -150,7 +150,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(actions_per_nodes['node'][0].keys.sort).to eq %i[ruby remote_bash].sort
               expect(actions_per_nodes['node'][0][:remote_bash]).to eq 'sudo -u root mkdir -p /var/log/deployments && sudo -u root chmod 600 /var/log/deployments'
               expect(actions_per_nodes['node'][1].keys.sort).to eq %i[scp].sort
-              expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to eq true
+              expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to be true
               expect(actions_per_nodes['node'][1][:scp].delete(:owner)).to eq 'root'
               expect(actions_per_nodes['node'][1][:scp].delete(:group)).to eq 'root'
               expect(actions_per_nodes['node'][1][:scp].size).to eq 1
@@ -160,7 +160,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(actions_per_nodes['node'][2][:remote_bash]).to eq "sudo -u root chmod 600 /var/log/deployments/#{File.basename(tmp_log_file)}"
               # Call the Ruby codes to be tested
               actions_per_nodes['node'][0][:ruby].call
-              expect(File.exist?(tmp_log_file)).to eq true
+              expect(File.exist?(tmp_log_file)).to be true
               file_content_regexp = Regexp.new <<~EOREGEXP
                 repo_name_0: platform
                 commit_id_0: 123456
@@ -178,7 +178,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(File.read(tmp_log_file)).to match file_content_regexp
               actions_per_nodes['node'][2][:ruby].call
               # Check temporary log file gets deleted for security reasons
-              expect(File.exist?(tmp_log_file)).to eq false
+              expect(File.exist?(tmp_log_file)).to be false
             end
           ]
           with_cmd_runner_mocked [
@@ -211,7 +211,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(actions_per_nodes['node'][0].keys.sort).to eq %i[ruby remote_bash].sort
               expect(actions_per_nodes['node'][0][:remote_bash]).to eq 'mkdir -p /var/log/deployments && chmod 600 /var/log/deployments'
               expect(actions_per_nodes['node'][1].keys.sort).to eq %i[scp].sort
-              expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to eq false
+              expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to be false
               expect(actions_per_nodes['node'][1][:scp].delete(:owner)).to eq 'root'
               expect(actions_per_nodes['node'][1][:scp].delete(:group)).to eq 'root'
               expect(actions_per_nodes['node'][1][:scp].size).to eq 1
@@ -221,7 +221,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(actions_per_nodes['node'][2][:remote_bash]).to eq "chmod 600 /var/log/deployments/#{File.basename(tmp_log_file)}"
               # Call the Ruby codes to be tested
               actions_per_nodes['node'][0][:ruby].call
-              expect(File.exist?(tmp_log_file)).to eq true
+              expect(File.exist?(tmp_log_file)).to be true
               file_content_regexp = Regexp.new <<~EOREGEXP
                 repo_name_0: platform
                 commit_id_0: 123456
@@ -239,7 +239,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(File.read(tmp_log_file)).to match file_content_regexp
               actions_per_nodes['node'][2][:ruby].call
               # Check temporary log file gets deleted for security reasons
-              expect(File.exist?(tmp_log_file)).to eq false
+              expect(File.exist?(tmp_log_file)).to be false
             end
           ]
           with_cmd_runner_mocked [

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioner_spec.rb

@@ -14,7 +14,7 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         provisioner = nil
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node', environment: 'hpc_testing_provisioner') do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.local_environment).to eq true
+          expect(sub_test_deployer.local_environment).to be true
           provisioner = test_instance
           expect(test_instance.node).to eq 'node'
           expect(test_instance.environment).to match(/^#{Regexp.escape(`whoami`.strip)}_hpc_testing_provisioner_\d+_\d+_\w+$/)
@@ -33,7 +33,7 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 666 }).and_yield
         provisioner = nil
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node', environment: 'hpc_testing_provisioner') do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.local_environment).to eq true
+          expect(sub_test_deployer.local_environment).to be true
           provisioner = test_instance
           expect(test_instance.node).to eq 'node'
           expect(test_instance.environment).to match(/^#{Regexp.escape(`whoami`.strip)}_hpc_testing_provisioner_\d+_\d+_\w+$/)
@@ -65,8 +65,8 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node1', environment: 'hpc_testing_provisioner') do |sub_test_deployer, test_instance|
           sub_nodes_handler = sub_test_deployer.instance_variable_get(:@nodes_handler)
-          expect(sub_nodes_handler.get_ssh_session_exec_of('node1')).to eq true
-          expect(sub_nodes_handler.get_ssh_session_exec_of('node2')).to eq false
+          expect(sub_nodes_handler.get_ssh_session_exec_of('node1')).to be true
+          expect(sub_nodes_handler.get_ssh_session_exec_of('node2')).to be false
           ssh_transforms = test_instance.instance_variable_get(:@config).ssh_connection_transforms
           expect(ssh_transforms.size).to eq 1
           expect(ssh_transforms[0][:nodes_selectors_stack]).to eq [%w[node2]]
@@ -90,8 +90,8 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node1', environment: 'hpc_testing_provisioner') do |sub_test_deployer|
           sub_nodes_handler = sub_test_deployer.instance_variable_get(:@nodes_handler)
-          expect(sub_nodes_handler.get_local_node_of('node1')).to eq false
-          expect(sub_nodes_handler.get_local_node_of('node2')).to eq true
+          expect(sub_nodes_handler.get_local_node_of('node1')).to be false
+          expect(sub_nodes_handler.get_local_node_of('node2')).to be true
         end
       end
     end
@@ -132,7 +132,7 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         provisioner = nil
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node', environment: 'hpc_testing_provisioner', reuse_instance: true) do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.local_environment).to eq true
+          expect(sub_test_deployer.local_environment).to be true
           provisioner = test_instance
           expect(test_instance.node).to eq 'node'
           expect(test_instance.environment).to eq "#{`whoami`.strip}_hpc_testing_provisioner"
@@ -150,7 +150,7 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         provisioner = nil
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node', environment: 'hpc_testing_provisioner', reuse_instance: true) do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.local_environment).to eq true
+          expect(sub_test_deployer.local_environment).to be true
           provisioner = test_instance
           expect(test_instance.node).to eq 'node'
           expect(test_instance.environment).to eq "#{`whoami`.strip}_hpc_testing_provisioner"

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/docker_spec.rb

@@ -48,7 +48,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Docker do
       instance.wait_for_state! :created
       begin
         # Test that the instance is created
-        expect(::Docker::Container.all(all: true).find { |container| container.info['Names'].include? "/hpc_docker_container_node_#{environment}" }).not_to eq nil
+        expect(::Docker::Container.all(all: true).find { |container| container.info['Names'].include? "/hpc_docker_container_node_#{environment}" }).not_to be_nil
         expect(instance.state).to eq :created
       ensure
         # Clean the Docker containers if needed

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/reserve_proxmox_container/expired_containers_spec.rb

@@ -14,7 +14,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 4 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   # Make sure it is expired
-                  1000 => { ip: '192.168.0.100', maxmem: 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1000 => { ip: '192.168.0.100', maxmem: 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -29,7 +29,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
       it 'expires a VM when there are not enough free resources on a PVE node' do
         with_sync_node do
-          creation_date = (Time.now - 31 * 24 * 60 * 60).utc
+          creation_date = (Time.now - (31 * 24 * 60 * 60)).utc
           mock_proxmox(
             mocked_pve_nodes: {
               'pve_node_name' => {
@@ -81,7 +81,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                     maxmem: 4 * 1024 * 1024 * 1024,
                     status: 'stopped',
                     # Make sure it is expired
-                    creation_date: (Time.now - 31 * 24 * 60 * 60).utc
+                    creation_date: (Time.now - (31 * 24 * 60 * 60)).utc
                   }
                 }
               }
@@ -117,7 +117,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 8 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -154,7 +154,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 6 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -185,8 +185,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 8 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
-                  1002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
+                  1002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -224,8 +224,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 8 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
-                  2002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
+                  2002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -261,14 +261,14 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               'pve_node_1' => {
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1000 => { ip: '192.168.0.100', maxmem: 14 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1000 => { ip: '192.168.0.100', maxmem: 14 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               },
               # But this node has still a bit of resources left without expiring VMs
               'pve_node_2' => {
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1001 => { ip: '192.168.0.101', maxmem: 10 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 10 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -302,14 +302,14 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 8 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 6 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 6 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               },
               'pve_node_2' => {
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1002 => { ip: '192.168.0.102', maxmem: 10 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1003 => { ip: '192.168.0.103', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1003 => { ip: '192.168.0.103', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -359,7 +359,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -415,7 +415,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               'pve_node_2' => {
                 memory_total: 2 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -463,7 +463,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -521,7 +521,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               'pve_node_2' => {
                 memory_total: 2 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -571,7 +571,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -634,7 +634,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               'pve_node_2' => {
                 memory_total: 2 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -748,7 +748,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
       it 'does not expire a VM that is stopped for some time even when it is not used for debug purposes' do
         with_sync_node do
           mock_proxmox(
-            mocked_pve_nodes: [{
+            mocked_pve_nodes: ([{
               # 2 seconds separate each run.
               # Make sure the third and later runs mock the container as running instead of stopped
               'pve_node_name' => {
@@ -765,8 +765,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                   }
                 }
               }
-            }] * 2 +
-            [{
+            }] * 2) +
+            ([{
               # 2 seconds separate each run.
               # Make sure the third and later runs mock the container as running instead of stopped
               'pve_node_name' => {
@@ -783,7 +783,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                   }
                 }
               }
-            }] * 2
+            }] * 2)
           )
           # Timeout for a non-debug stopped container to be considered expired is 3 seconds in tests
           expect(call_reserve_proxmox_container(2, 1024, 1, max_retries: 4, wait_before_retry: 2)).to eq(error: 'not_enough_resources')
@@ -796,7 +796,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           creation_date_1 = (Time.now - 20).utc
           creation_date_2 = (Time.now - 10).utc
           mock_proxmox(
-            mocked_pve_nodes: [{
+            mocked_pve_nodes: ([{
               # 2 seconds separate each run.
               # Make sure the third and later runs mock the container as another one, still stopped
               'pve_node_name' => {
@@ -812,8 +812,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                   }
                 }
               }
-            }] * 2 +
-            [{
+            }] * 2) +
+            ([{
               # 2 seconds separate each run.
               # Make sure the third and later runs mock the container as another one, still stopped
               'pve_node_name' => {
@@ -829,7 +829,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                   }
                 }
               }
-            }] * 2
+            }] * 2)
           )
           # Timeout for a non-debug stopped container to be considered expired is 3 seconds in tests
           expect(call_reserve_proxmox_container(2, 1024, 1, max_retries: 4, wait_before_retry: 2)).to eq(error: 'not_enough_resources')

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/reserve_proxmox_container/retries_spec.rb

@@ -52,7 +52,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
         with_sync_node do
           mock_proxmox(mocked_pve_nodes: [{ 'pve_node_name' => { error_strings: ['NOK: error code = 500'] * 5 } }])
           result = call_reserve_proxmox_container(2, 1024, 4, config: { api_max_retries: 4 })
-          expect(result[:error]).not_to eq nil
+          expect(result[:error]).not_to be_nil
           expect(result[:error]).to match(%r{Unhandled exception from reserve_proxmox_container: Proxmox API get nodes/pve_node_name/lxc returns NOK: error code = 500 continuously \(tried 5 times\)})
           expect_proxmox_actions_to_be [
             [:create_ticket],