hybrid_platforms_conductor 33.9.2 → 33.9.4

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/cmdbs/host_ip_spec.rb

@@ -17,6 +17,7 @@ describe HybridPlatformsConductor::NodesHandler do
     it 'returns a host IP when hostname is set' do
       with_test_platform({ nodes: { 'test_node' => {} } }) do
         with_cmd_runner_mocked [
+          ['command -v getent', proc { [0, '', ''] }],
           ['getent hosts my_domain.my_host', proc { [0, '192.168.42.42 my_domain.my_host', ''] }]
         ] do
           expect(cmdb(:host_ip).get_host_ip(['test_node'], { 'test_node' => { hostname: 'my_domain.my_host' } })).to eq('test_node' => '192.168.42.42')
@@ -24,9 +25,21 @@ describe HybridPlatformsConductor::NodesHandler do
       end
     end
 
+    it 'returns a host IP when hostname is set without getenv' do
+      with_test_platform({ nodes: { 'test_node' => {} } }) do
+        with_cmd_runner_mocked [
+          ['command -v getent', proc { [1, '', ''] }],
+          ['host my_domain.my_host | grep \'has address\'', proc { [0, 'my_domain.my_host has address 192.168.42.42', ''] }]
+        ] do
+          expect(cmdb(:host_ip).get_host_ip(['test_node'], { 'test_node' => { hostname: 'my_domain.my_host' } })).to eq('test_node' => '192.168.42.42')
+        end
+      end
+    end
+
     it 'does not return a host IP when getent can\'t retrieve it' do
       with_test_platform({ nodes: { 'test_node' => {} } }) do
         with_cmd_runner_mocked [
+          ['command -v getent', proc { [0, '', ''] }],
           ['getent hosts my_domain.my_host', proc { [0, '', ''] }]
         ] do
           expect(cmdb(:host_ip).get_host_ip(['test_node'], { 'test_node' => { hostname: 'my_domain.my_host' } })).to eq({})
@@ -34,6 +47,17 @@ describe HybridPlatformsConductor::NodesHandler do
       end
     end
 
+    it 'does not return a host IP when getent can\'t retrieve it without getenv' do
+      with_test_platform({ nodes: { 'test_node' => {} } }) do
+        with_cmd_runner_mocked [
+          ['command -v getent', proc { [1, '', ''] }],
+          ['host my_domain.my_host | grep \'has address\'', proc { [1, '', ''] }]
+        ] do
+          expect(cmdb(:host_ip).get_host_ip(['test_node'], { 'test_node' => { hostname: 'my_domain.my_host' } })).to eq({})
+        end
+      end
+    end
+
     it 'returns a host IPs for the maximum hosts it can from the list' do
       with_test_platform(
         {
@@ -46,6 +70,7 @@ describe HybridPlatformsConductor::NodesHandler do
         }
       ) do
         with_cmd_runner_mocked [
+          ['command -v getent', proc { [0, '', ''] }],
           ['getent hosts my_domain.my_host1', proc { [0, '192.168.42.1 my_domain.my_host1', ''] }],
           ['getent hosts my_domain.my_host2', proc { [0, '', ''] }],
           ['getent hosts my_domain.my_host4', proc { [0, '192.168.42.4 my_domain.my_host4', ''] }]

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/cmdbs_plugins_api_spec.rb

@@ -56,7 +56,7 @@ describe HybridPlatformsConductor::NodesHandler do
 
     it 'returns nodes metadata using dynamic method even on non-existant properties' do
       with_cmdb_test_platform do
-        expect(test_nodes_handler.get_downcase_of('node1')).to eq nil
+        expect(test_nodes_handler.get_downcase_of('node1')).to be_nil
       end
     end
 
@@ -245,7 +245,7 @@ describe HybridPlatformsConductor::NodesHandler do
         additional_config: 'master_cmdbs(test_cmdb_2: :different_comment)'
       ) do
         expect(test_nodes_handler.get_different_comment_of('node1')).to eq 'Comment from test_cmdb_2'
-        expect(cmdb(:test_cmdb).calls).to eq nil
+        expect(cmdb(:test_cmdb).calls).to be_nil
         expect(cmdb(:test_cmdb_2).calls).to eq [
           [:get_different_comment, ['node1'], {}]
         ]
@@ -385,7 +385,7 @@ describe HybridPlatformsConductor::NodesHandler do
 
     it 'does not cache metadata from others method when they are not the required property' do
       with_cmdb_test_platform(cmdbs: %i[test_cmdb test_cmdb_others]) do
-        expect(test_nodes_handler.get_unknown_of('node1')).to eq nil
+        expect(test_nodes_handler.get_unknown_of('node1')).to be_nil
         expect(cmdb(:test_cmdb_others).calls).to eq [
           [:get_others, ['node1'], {}]
         ]
@@ -400,7 +400,7 @@ describe HybridPlatformsConductor::NodesHandler do
     it 'does not refuse conflicts between CMDBs and overriden values' do
       with_cmdb_test_platform(cmdbs: %i[test_cmdb_others]) do
         test_nodes_handler.override_metadata_of 'node1', :downcase, 'OVERIDDEN'
-        expect(test_nodes_handler.get_unknown_of('node1')).to eq nil
+        expect(test_nodes_handler.get_unknown_of('node1')).to be_nil
         expect(test_nodes_handler.get_downcase_of('node1')).to eq 'OVERIDDEN'
       end
     end
@@ -409,7 +409,7 @@ describe HybridPlatformsConductor::NodesHandler do
       with_cmdb_test_platform do
         test_nodes_handler.override_metadata_of 'node1', :upcase, 'OVERIDDEN'
         expect(test_nodes_handler.metadata_of('node1', :upcase)).to eq 'OVERIDDEN'
-        expect(cmdb(:test_cmdb).calls).to eq nil
+        expect(cmdb(:test_cmdb).calls).to be_nil
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/inventory_spec.rb

@@ -12,7 +12,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
       it 'returns no nodes list' do
         with_serverless_chef_platforms('empty') do |platform|
-          expect(platform.respond_to?(:known_nodes_lists)).to eq false
+          expect(platform.respond_to?(:known_nodes_lists)).to be false
         end
       end
 

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/packaging_spec.rb

@@ -90,7 +90,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository) do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: false)
             gems_file = "#{repository}/dist/prod/test_policy/gems.json"
-            expect(File.exist?(gems_file)).to eq true
+            expect(File.exist?(gems_file)).to be true
             expect(JSON.parse(File.read(gems_file))).to eq []
           end
         end
@@ -110,7 +110,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository) do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: { secret: 'value' }, local_environment: false)
             secret_file = "#{repository}/dist/prod/test_policy/data_bags/hpc_secrets/hpc_secrets.json"
-            expect(File.exist?(secret_file)).to eq true
+            expect(File.exist?(secret_file)).to be true
             expect(JSON.parse(File.read(secret_file))).to eq(
               'id' => 'hpc_secrets',
               'secret' => 'value'
@@ -124,7 +124,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, policy_file: 'policyfiles/test_policy.local.rb', env: 'local') do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             local_policy_file = "#{repository}/policyfiles/test_policy.local.lock.json"
-            expect(File.exist?(local_policy_file)).to eq true
+            expect(File.exist?(local_policy_file)).to be true
             expect(JSON.parse(File.read(local_policy_file))).to eq('run_list' => ['recipe[test_cookbook]'])
           end
         end
@@ -247,7 +247,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           ) do
             platform.package(services: { 'node1' => %w[test_policy_1] }, secrets: {}, local_environment: false)
             gems_file = "#{repository}/dist/prod/test_policy_1/gems.json"
-            expect(File.exist?(gems_file)).to eq true
+            expect(File.exist?(gems_file)).to be true
             expect(JSON.parse(File.read(gems_file)).sort).to eq [
               ['my_gem_1', '0.0.1'],
               ['my_gem_2', '0.0.2'],
@@ -266,7 +266,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, data_bags: true) do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: false)
             data_bag_file = "#{repository}/dist/prod/test_policy/data_bags/my_bag/my_item.json"
-            expect(File.exist?(data_bag_file)).to eq true
+            expect(File.exist?(data_bag_file)).to be true
             expect(JSON.parse(File.read(data_bag_file))).to eq(
               'id' => 'my_item',
               'content' => 'Bag content'
@@ -284,7 +284,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, policy_file: 'policyfiles/test_policy.local.rb', env: 'local') do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             local_policy_file = "#{repository}/policyfiles/test_policy.local.lock.json"
-            expect(File.exist?(local_policy_file)).to eq true
+            expect(File.exist?(local_policy_file)).to be true
             expect(JSON.parse(File.read(local_policy_file))).to eq(
               'run_list' => [
                 'hpc_test::before_run',
@@ -302,7 +302,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, policy_file: 'policyfiles/test_policy.local.rb', env: 'local') do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             local_policy_file = "#{repository}/policyfiles/test_policy.local.lock.json"
-            expect(File.exist?(local_policy_file)).to eq true
+            expect(File.exist?(local_policy_file)).to be true
             expect(JSON.parse(File.read(local_policy_file))).to eq(
               'run_list' => [
                 'hpc_test::before_run',
@@ -319,7 +319,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, policy_file: 'policyfiles/test_policy.local.rb', env: 'local') do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             local_policy_file = "#{repository}/policyfiles/test_policy.local.lock.json"
-            expect(File.exist?(local_policy_file)).to eq true
+            expect(File.exist?(local_policy_file)).to be true
             expect(JSON.parse(File.read(local_policy_file))).to eq(
               'run_list' => [
                 'recipe[test_cookbook]',
@@ -343,7 +343,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           ) do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             testadmin_key_pub = Dir.glob("#{repository}/dist/local/test_policy/cookbook_artifacts/hpc_test-*/files/default/testadmin.key.pub").first
-            expect(testadmin_key_pub).not_to eq nil
+            expect(testadmin_key_pub).not_to be_nil
             expect(File.read(testadmin_key_pub)).to eq 'ssh-rsa 12345 testadmin@test.com'
           end
         end

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/services_deployment_spec.rb

@@ -168,7 +168,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           )
           expect(platform.actions_to_deploy_on('node', 'test_policy', use_why_run: false)).to eq expected_actions_to_deploy_chef(repository)
           attributes_file = "#{repository}/dist/prod/test_policy/nodes/node.json"
-          expect(File.exist?(attributes_file)).to eq true
+          expect(File.exist?(attributes_file)).to be true
           expect(JSON.parse(File.read(attributes_file))).to eq(
             'description' => 'Single test node',
             'image' => 'debian_9',

data/spec/hybrid_platforms_conductor_test/api/platforms_handler_spec.rb

@@ -138,7 +138,7 @@ describe HybridPlatformsConductor::PlatformsHandler do
         'platform3' => { platform_type: :test }
       }
     ) do
-      expect(test_platforms_handler.platform('platform4')).to eq nil
+      expect(test_platforms_handler.platform('platform4')).to be_nil
     end
   end
 

data/spec/hybrid_platforms_conductor_test/api/plugins_spec.rb

@@ -7,6 +7,9 @@ module HybridPlatformsConductor
   class TestPluginType2 < Plugin
   end
 
+  class TestPluginType3 < Plugin
+  end
+
 end
 
 module HybridPlatformsConductorTest
@@ -122,7 +125,7 @@ describe HybridPlatformsConductor::Plugins do
       plugins[:new_plugin] = HybridPlatformsConductorTest::RandomClassWithValidation
       expect(plugins.keys).to eq [:new_plugin]
       expect(plugins[:new_plugin]).to eq HybridPlatformsConductorTest::RandomClassWithValidation
-      expect(HybridPlatformsConductorTest::RandomClassWithValidation.validation_done).to eq true
+      expect(HybridPlatformsConductorTest::RandomClassWithValidation.validation_done).to be true
     end
   end
 
@@ -133,7 +136,7 @@ describe HybridPlatformsConductor::Plugins do
       HybridPlatformsConductorTest::RandomClassWithValidation.validation_result = false
       plugins[:new_plugin] = HybridPlatformsConductorTest::RandomClassWithValidation
       expect(plugins.keys).to eq []
-      expect(HybridPlatformsConductorTest::RandomClassWithValidation.validation_done).to eq true
+      expect(HybridPlatformsConductorTest::RandomClassWithValidation.validation_done).to be true
     end
   end
 
@@ -162,6 +165,31 @@ describe HybridPlatformsConductor::Plugins do
     end
   end
 
+  it 'discovers automatically plugins of a given type in the hpc_plugins directory of a gem even if lib is used in the gem\'s installation path' do
+    with_test_platform({}) do
+      # Mock the discovery of Ruby gems
+      expect(Gem).to receive(:loaded_specs) do
+        my_test_gem_spec = instance_double Gem::Specification
+        expect(my_test_gem_spec).to receive(:full_gem_path).and_return('path/to/__gem_full_path__/in/lib/sub')
+        expect(Dir).to receive(:glob).with('path/to/__gem_full_path__/in/lib/sub/lib/**/*.rb').and_return [
+          'path/to/__gem_full_path__/in/lib/sub/lib/my_test_gem_with_lib/sub1/lib/sub2/hpc_plugins/test_plugin_type_3/test_plugin_id_5.rb'
+        ]
+        {
+          'my_test_gem_with_lib' => my_test_gem_spec
+        }
+      end
+      # Alter the load path to mock an extra Rubygem
+      $LOAD_PATH.unshift "#{__dir__}/../mocked_lib"
+      begin
+        plugins = described_class.new(:test_plugin_type_3, logger: logger, logger_stderr: logger)
+        expect(plugins.keys).to eq [:test_plugin_id_5]
+        expect(plugins[:test_plugin_id_5]).to eq HybridPlatformsConductorTest::MockedLib::MyTestGemWithLib::Sub1::Lib::Sub2::HpcPlugins::TestPluginType3::TestPluginId5
+      ensure
+        $LOAD_PATH.shift
+      end
+    end
+  end
+
   it 'discovers automatically several plugins of different types in the hpc_plugins directories of several gems' do
     with_test_platform({}) do
       # Mock the discovery of Ruby gems

data/spec/hybrid_platforms_conductor_test/api/services_handler/deploy_allowed_spec.rb

@@ -34,14 +34,14 @@ describe HybridPlatformsConductor::ServicesHandler do
     it 'allows deployment in local environment' do
       with_test_platform_for_services_test do
         with_cmd_runner_mocked([]) do
-          expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: true)).to eq nil
+          expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: true)).to be_nil
         end
       end
     end
 
     it 'allows deployment if branch is on master' do
       with_test_platform_for_services_test do
-        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to eq nil
+        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to be_nil
       end
     end
 
@@ -52,7 +52,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           deployable_services: %w[service1]
         }
       ) do
-        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to eq nil
+        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to be_nil
       end
     end
 
@@ -62,7 +62,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           git = Git.open(repository)
           git.add_remote('another_remote', remote_repo).fetch
           git.checkout('remotes/another_remote/master')
-          expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to eq nil
+          expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to be_nil
         end
       end
     end
@@ -70,7 +70,7 @@ describe HybridPlatformsConductor::ServicesHandler do
     it 'allows deployment if branch is on master even if not checked-out' do
       with_test_platform_for_services_test do |repository|
         Git.open(repository).branch('other_branch').checkout
-        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to eq nil
+        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to be_nil
       end
     end
 
@@ -95,7 +95,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             services: { 'node1' => %w[service1], 'node2' => %w[service2], 'node3' => %w[service3] },
             local_environment: false
           )
-        ).to eq nil
+        ).to be_nil
       end
     end
 
@@ -137,7 +137,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             services: { 'node1' => %w[service1 service3] },
             local_environment: false
           )
-        ).to eq nil
+        ).to be_nil
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/services_handler/package_spec.rb

@@ -10,7 +10,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
           end
         }
       ) do
@@ -31,7 +31,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
             nbr_calls += 1
           end
         }
@@ -56,7 +56,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
             nbr_calls += 1
           end
         }
@@ -91,7 +91,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq('my_secret' => 'value')
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
           end
         }
       ) do
@@ -111,7 +111,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq true
+            expect(local_environment).to be true
           end
         }
       ) do
@@ -137,7 +137,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform1'] += 1
             end
           },
@@ -147,7 +147,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform2'] += 1
             end
           },
@@ -157,7 +157,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node3' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform3'] += 1
             end
           }
@@ -190,7 +190,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform1'] += 1
             end
           },
@@ -200,7 +200,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform2'] += 1
             end
           },
@@ -210,7 +210,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node1' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform3'] += 1
             end
           }
@@ -243,7 +243,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node' => %w[service1 service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform1'] += 1
             end
           },
@@ -253,7 +253,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform2'] += 1
             end
           },
@@ -263,7 +263,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node' => %w[service5 service6])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform3'] += 1
             end
           }
@@ -296,7 +296,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform1'] += 1
             end
           },
@@ -306,7 +306,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform2'] += 1
             end
           },
@@ -316,7 +316,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node3' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform3'] += 1
             end
           }
@@ -355,7 +355,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq(expected_secrets)
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
             nbr_calls += 1
           end
         }

data/spec/hybrid_platforms_conductor_test/api/services_handler/prepare_for_deploy_spec.rb

@@ -11,8 +11,8 @@ describe HybridPlatformsConductor::ServicesHandler do
           prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
-            expect(why_run).to eq false
+            expect(local_environment).to be false
+            expect(why_run).to be false
             called = true
           end
         }
@@ -23,7 +23,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           local_environment: false,
           why_run: false
         )
-        expect(called).to eq true
+        expect(called).to be true
       end
     end
 
@@ -36,8 +36,8 @@ describe HybridPlatformsConductor::ServicesHandler do
           prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq('my_secret' => 'value')
-            expect(local_environment).to eq false
-            expect(why_run).to eq false
+            expect(local_environment).to be false
+            expect(why_run).to be false
             called = true
           end
         }
@@ -48,7 +48,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           local_environment: false,
           why_run: false
         )
-        expect(called).to eq true
+        expect(called).to be true
       end
     end
 
@@ -61,8 +61,8 @@ describe HybridPlatformsConductor::ServicesHandler do
           prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq true
-            expect(why_run).to eq false
+            expect(local_environment).to be true
+            expect(why_run).to be false
             called = true
           end
         }
@@ -73,7 +73,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           local_environment: true,
           why_run: false
         )
-        expect(called).to eq true
+        expect(called).to be true
       end
     end
 
@@ -86,8 +86,8 @@ describe HybridPlatformsConductor::ServicesHandler do
           prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
-            expect(why_run).to eq true
+            expect(local_environment).to be false
+            expect(why_run).to be true
             called = true
           end
         }
@@ -98,7 +98,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           local_environment: false,
           why_run: true
         )
-        expect(called).to eq true
+        expect(called).to be true
       end
     end
 
@@ -116,8 +116,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform1'] = true
             end
           },
@@ -127,8 +127,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform2'] = true
             end
           },
@@ -138,8 +138,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node3' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform3'] = true
             end
           }
@@ -173,8 +173,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform1'] = true
             end
           },
@@ -184,8 +184,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform2'] = true
             end
           },
@@ -195,8 +195,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node1' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform3'] = true
             end
           }
@@ -230,8 +230,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node' => %w[service1 service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform1'] = true
             end
           },
@@ -241,8 +241,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform2'] = true
             end
           },
@@ -252,8 +252,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node' => %w[service5 service6])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform3'] = true
             end
           }