hybrid_platforms_conductor 32.17.0 → 33.0.2

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/several_platforms_spec.rb

@@ -1,11 +1,13 @@
 describe HybridPlatformsConductor::NodesHandler do
 
-  context 'checking aggregations across several platforms' do
+  context 'when checking aggregations across several platforms' do
 
     it 'returns nodes' do
       with_test_platforms(
-        'platform1' => { nodes: { 'node1' => {}, 'node2' => {} } },
-        'platform2' => { nodes: { 'node3' => {}, 'node4' => {} } }
+        {
+          'platform1' => { nodes: { 'node1' => {}, 'node2' => {} } },
+          'platform2' => { nodes: { 'node3' => {}, 'node4' => {} } }
+        }
       ) do
         expect(test_nodes_handler.known_nodes.sort).to eq %w[node1 node2 node3 node4].sort
       end
@@ -13,17 +15,21 @@ describe HybridPlatformsConductor::NodesHandler do
 
     it 'fails when several platforms define the same nodes' do
       with_test_platforms(
-        'platform1' => { nodes: { 'node1' => {}, 'node2' => {} } },
-        'platform2' => { nodes: { 'node1' => {}, 'node4' => {} } }
+        {
+          'platform1' => { nodes: { 'node1' => {}, 'node2' => {} } },
+          'platform2' => { nodes: { 'node1' => {}, 'node4' => {} } }
+        }
       ) do
-        expect { test_nodes_handler.known_nodes }.to raise_error(RuntimeError, /Can\'t register node1/)
+        expect { test_nodes_handler.known_nodes }.to raise_error(RuntimeError, /Can't register node1/)
       end
     end
 
     it 'returns nodes lists' do
       with_test_platforms(
-        'platform1' => { nodes_lists: { 'nodeslist1' => [] } },
-        'platform2' => { nodes_lists: { 'nodeslist2' => [] } }
+        {
+          'platform1' => { nodes_lists: { 'nodeslist1' => [] } },
+          'platform2' => { nodes_lists: { 'nodeslist2' => [] } }
+        }
       ) do
         expect(test_nodes_handler.known_nodes_lists.sort).to eq %w[nodeslist1 nodeslist2].sort
       end
@@ -31,23 +37,27 @@ describe HybridPlatformsConductor::NodesHandler do
 
     it 'fails when several platforms define the same nodes lists' do
       with_test_platforms(
-        'platform1' => { nodes_lists: { 'nodeslist1' => [] } },
-        'platform2' => { nodes_lists: { 'nodeslist1' => [] } }
+        {
+          'platform1' => { nodes_lists: { 'nodeslist1' => [] } },
+          'platform2' => { nodes_lists: { 'nodeslist1' => [] } }
+        }
       ) do
-        expect { test_nodes_handler.known_nodes_lists }.to raise_error(RuntimeError, /Can\'t register nodes list nodeslist1/)
+        expect { test_nodes_handler.known_nodes_lists }.to raise_error(RuntimeError, /Can't register nodes list nodeslist1/)
       end
     end
 
     it 'returns services' do
       with_test_platforms(
-        'platform1' => { nodes: {
-          'node1' => { services: ['service1'] },
-          'node2' => { services: ['service2'] }
-        } },
-        'platform2' => { nodes: {
-          'node3' => { services: ['service1', 'service4'] },
-          'node4' => { services: ['service3'] }
-        } }
+        {
+          'platform1' => { nodes: {
+            'node1' => { services: ['service1'] },
+            'node2' => { services: ['service2'] }
+          } },
+          'platform2' => { nodes: {
+            'node3' => { services: %w[service1 service4] },
+            'node4' => { services: ['service3'] }
+          } }
+        }
       ) do
         expect(test_nodes_handler.known_services.sort).to eq %w[service1 service2 service3 service4].sort
       end

data/spec/hybrid_platforms_conductor_test/api/platform_handler_spec.rb

@@ -1,19 +1,19 @@
 describe HybridPlatformsConductor::PlatformHandler do
 
   it 'returns the correct platform type' do
-    with_test_platform do
+    with_test_platform({}) do
       expect(test_platforms_handler.platform('platform').platform_type).to eq :test
     end
   end
 
   it 'returns the correct path' do
-    with_test_platform do
+    with_test_platform({}) do
       expect(test_platforms_handler.platform('platform').repository_path).to eq "#{Dir.tmpdir}/hpc_test/platform"
     end
   end
 
   it 'returns the correct info' do
-    with_test_platform do
+    with_test_platform({}) do
       expect(test_platforms_handler.platform('platform').info).to eq(repo_name: 'platform')
     end
   end
@@ -76,7 +76,7 @@ describe HybridPlatformsConductor::PlatformHandler do
         git = Git.open(repository)
         FileUtils.touch("#{repository}/test_file_1")
         FileUtils.touch("#{repository}/test_file_2")
-        git.add(['test_file_1', 'test_file_2'])
+        git.add(%w[test_file_1 test_file_2])
         git.commit('Test commit')
         # Make some diffs
         FileUtils.touch("#{repository}/new_file")

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/config_dsl_spec.rb

@@ -1,9 +1,9 @@
 describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef do
 
-  context 'checking config DSL' do
+  context 'when checking config DSL' do
 
     it 'defines helpers that include recipes' do
-      with_repository do |repository|
+      with_repository do
         with_platforms('helpers_including_recipes(my_helper: [\'cookbook1::recipe1\', \'cookbook2\'])') do
           expect(test_config.known_helpers_including_recipes).to eq(
             my_helper: %w[cookbook1::recipe1 cookbook2]

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/deploy_output_parsing_spec.rb

@@ -1,10 +1,10 @@
 describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef do
 
-  context 'checking how deployment output is parsed' do
+  context 'when checking how deployment output is parsed' do
 
     it 'parses a deployment output properly' do
       with_serverless_chef_platforms('empty') do |platform|
-        stdout = <<~EOS
+        stdout = <<~EO_STDOUT
           Starting Chef Client, version 14.14.29
           resolving cookbooks for run list: ["policy_xae_websql::xae"]
           Synchronizing Cookbooks:
@@ -36,8 +36,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           Running handlers:
           Running handlers complete
           Chef Client finished, 16/300 resources updated in 27 seconds
-        EOS
-        expect(platform.parse_deploy_output(stdout, '')). to eq [
+        EO_STDOUT
+        expect(platform.parse_deploy_output(stdout, '')).to eq [
           {
             action: 'update',
             diffs: "force update new lists of packages\n",
@@ -67,10 +67,10 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           },
           {
             action: 'create',
-            diffs: <<~EOS,
+            diffs: <<~EO_STDOUT,
               create new file /opt/chef_cache/xaecalcite_0.2.4-1_amd64.deb
               update content in file /opt/chef_cache/xaecalcite_0.2.4-1_amd64.deb from none to 39b0ca
-            EOS
+            EO_STDOUT
             name: 'remote_file[/opt/chef_cache/xaecalcite_0.2.4-1_amd64.deb]',
             status: :changed
           },

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/diff_impacts_spec.rb

@@ -1,9 +1,9 @@
 describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef do
 
-  context 'checking files diff impacts' do
+  context 'when checking files diff impacts' do
 
     it 'returns no impact for no diffs' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
+      with_serverless_chef_platforms('recipes') do |platform|
         expect(platform.impacts_from({})).to eq [
           [],
           [],
@@ -13,10 +13,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'ignores files with no impact' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_1/README.md' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_1/README.md' => {})).to eq [
           [],
           [],
           false
@@ -25,10 +23,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'returns all nodes impact for global files' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'global.rb' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('global.rb' => {})).to eq [
           [],
           [],
           true
@@ -37,10 +33,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'returns direct impacted nodes' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'nodes/node1.json' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('nodes/node1.json' => {})).to eq [
           %w[node1],
           [],
           false
@@ -49,10 +43,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'returns direct impacted nodes with strange characters' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'nodes/node-v45.env_@user.json' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('nodes/node-v45.env_@user.json' => {})).to eq [
           ['node-v45.env_@user'],
           [],
           false
@@ -61,10 +53,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'returns impacted service due to a change in its recipes' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_1/recipes/default.rb' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_1/recipes/default.rb' => {})).to eq [
           [],
           %w[test_policy_1],
           false
@@ -73,10 +63,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'returns impacted service due to a change in its attributes' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_1/attributes/default.rb' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_1/attributes/default.rb' => {})).to eq [
           [],
           %w[test_policy_1],
           false
@@ -86,14 +74,12 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'returns impacted service due to a change in an included template' do
       with_serverless_chef_platforms('recipes') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           template '/home/file' do
             source 'test_template.erb'
           end
-        EOS
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_1/templates/default/test_template.erb' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_1/templates/default/test_template.erb' => {})).to eq [
           [],
           %w[test_policy_1],
           false
@@ -102,10 +88,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'does not return impacted service due to a change in a non included template' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_1/templates/default/test_template.erb' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_1/templates/default/test_template.erb' => {})).to eq [
           [],
           [],
           false
@@ -115,14 +99,12 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'returns impacted service due to a change in an included file' do
       with_serverless_chef_platforms('recipes') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           file '/home/file' do
             source 'test_file'
           end
-        EOS
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_1/files/default/test_file' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_1/files/default/test_file' => {})).to eq [
           [],
           %w[test_policy_1],
           false
@@ -131,10 +113,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'does not return impacted service due to a change in a non included file' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_1/files/default/test_file' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_1/files/default/test_file' => {})).to eq [
           [],
           [],
           false
@@ -144,12 +124,10 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'returns impacted service due to a resource usage in a recipe' do
       with_serverless_chef_platforms('recipes') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           test_cookbook_2_my_resource
-        EOS
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_2/resources/my_resource.rb' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/resources/my_resource.rb' => {})).to eq [
           [],
           %w[test_policy_1],
           false
@@ -158,10 +136,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'does not return impacted service due to a resource not being used in a recipe' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_2/resources/my_resource.rb' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/resources/my_resource.rb' => {})).to eq [
           [],
           [],
           false
@@ -171,12 +147,10 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'returns impacted service due to a library helper usage in a recipe' do
       with_serverless_chef_platforms('recipes') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           a = my_library_helper(42)
-        EOS
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_2/libraries/default.rb' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/libraries/default.rb' => {})).to eq [
           [],
           %w[test_policy_1],
           false
@@ -186,12 +160,10 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'ignored impacted service from an unknown helper' do
       with_serverless_chef_platforms('recipes') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           a = unknown_helper(42)
-        EOS
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_2/recipes/default.rb' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/recipes/default.rb' => {})).to eq [
           [],
           %w[test_policy_2],
           false
@@ -202,16 +174,14 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     it 'returns impacted service due to an unknown library helper usage that has been configured' do
       with_serverless_chef_platforms(
         'recipes',
-        additional_config: <<~EOS
+        additional_config: <<~EO_CONFIG
           helpers_including_recipes(unknown_helper: ['test_cookbook_2'])
-        EOS
+        EO_CONFIG
       ) do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           a = unknown_helper(42)
-        EOS
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_2/recipes/default.rb' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/recipes/default.rb' => {})).to eq [
           [],
           %w[test_policy_1 test_policy_2],
           false
@@ -220,10 +190,8 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
     end
 
     it 'does not return impacted service due to a library helper not being used in a recipe' do
-      with_serverless_chef_platforms('recipes') do |platform, repository|
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_2/libraries/default.rb' => {}
-        )).to eq [
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/libraries/default.rb' => {})).to eq [
           [],
           [],
           false
@@ -233,12 +201,10 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'returns impacted service due to a usage of another cookbook\'s default recipe' do
       with_serverless_chef_platforms('recipes') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           include_recipe 'test_cookbook_2'
-        EOS
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_2/recipes/default.rb' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/recipes/default.rb' => {})).to eq [
           [],
           %w[test_policy_1 test_policy_2],
           false
@@ -248,12 +214,10 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'returns impacted service due to a usage of another cookbook\'s recipe' do
       with_serverless_chef_platforms('recipes') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           include_recipe 'test_cookbook_2::other_recipe'
-        EOS
-        expect(platform.impacts_from(
-          'cookbooks/test_cookbook_2/recipes/other_recipe.rb' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/recipes/other_recipe.rb' => {})).to eq [
           [],
           %w[test_policy_1],
           false
@@ -263,12 +227,10 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'ignores cookbooks from cookbook paths that are not configured' do
       with_serverless_chef_platforms('several_cookbooks') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           include_recipe 'test_cookbook_2'
-        EOS
-        expect(platform.impacts_from(
-          'other_cookbooks/test_cookbook_2/recipes/default.rb' => {}
-        )).to eq [
+        EO_RECIPE
+        expect(platform.impacts_from('other_cookbooks/test_cookbook_2/recipes/default.rb' => {})).to eq [
           [],
           %w[],
           true
@@ -278,13 +240,11 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
     it 'considers cookbooks from non-standard cookbook paths that are configured' do
       with_serverless_chef_platforms('several_cookbooks') do |platform, repository|
-        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
           include_recipe 'test_cookbook_2'
-        EOS
+        EO_RECIPE
         ENV['hpc_test_cookbooks_path'] = 'other_cookbooks'
-        expect(platform.impacts_from(
-          'other_cookbooks/test_cookbook_2/recipes/default.rb' => {}
-        )).to eq [
+        expect(platform.impacts_from('other_cookbooks/test_cookbook_2/recipes/default.rb' => {})).to eq [
           [],
           %w[test_policy_1 test_policy_2],
           false
@@ -297,13 +257,11 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
         FileUtils.mkdir_p("#{other_repo}/cookbooks/test_cookbook_2/recipes")
         File.write("#{other_repo}/cookbooks/test_cookbook_2/recipes/default.rb", '')
         with_serverless_chef_platforms('several_cookbooks') do |platform, repository|
-          File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EOS)
+          File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
             include_recipe 'test_cookbook_2'
-          EOS
+          EO_RECIPE
           ENV['hpc_test_cookbooks_path'] = "#{other_repo}:other_cookbooks"
-          expect(platform.impacts_from(
-            'unknown_cookbooks/test_cookbook_2/recipes/default.rb' => {}
-          )).to eq [
+          expect(platform.impacts_from('unknown_cookbooks/test_cookbook_2/recipes/default.rb' => {})).to eq [
             [],
             %w[],
             true