hybrid_platforms_conductor 32.17.0 → 33.0.2

data/lib/hybrid_platforms_conductor/hpc_plugins/test/vulnerabilities.rb

@@ -1,4 +1,5 @@
 require 'nokogiri'
+require 'hybrid_platforms_conductor/test_only_remote_node'
 
 module HybridPlatformsConductor
 
@@ -17,7 +18,7 @@ module HybridPlatformsConductor
       #     Each final OVAL URL can be directly an XML file, either raw or compressed with .gz or .bz2.
       #     This is useful to follow repository links, such as jFrog or web servers serving common file systems structure storing several versions of the OVAL file.
       # * *reported_severities* (Array<String> or nil): List of severities to report, if any (use Unknown when the severity is not known), or nil for all [default: nil]
-      class Vulnerabilities < HybridPlatformsConductor::Test
+      class Vulnerabilities < TestOnlyRemoteNode
 
         # Known compression methods, per file extension, and their corresponding uncompress bash script
         KNOWN_COMPRESSIONS = {
@@ -47,8 +48,9 @@ module HybridPlatformsConductor
                   # Follow the last link recursively until we find a .xml or compressed file
                   current_url = artifactory_url
                   loop do
-                    current_url = "#{current_url}#{current_url.end_with?('/') ? '' : '/'}#{Nokogiri::HTML.parse(URI.open(current_url)).css('a').last['href']}"
+                    current_url = "#{current_url}#{current_url.end_with?('/') ? '' : '/'}#{Nokogiri::HTML.parse(URI.parse(current_url).open).css('a').last['href']}"
                     break if current_url.end_with?('.xml') || KNOWN_COMPRESSIONS.keys.any? { |file_ext| current_url.end_with?(".#{file_ext}") }
+
                     log_debug "Follow last link to #{current_url}"
                   end
                   current_url
@@ -56,7 +58,7 @@ module HybridPlatformsConductor
               )
               # TODO: Access the user correctly when the user notion will be moved out of the ssh connector
               sudo = @deployer.instance_variable_get(:@actions_executor).connector(:ssh).ssh_user == 'root' ? '' : "#{@nodes_handler.sudo_on(@node)} "
-              Hash[urls.map do |url|
+              urls.map do |url|
                 # 1. Get the OVAL file on the node to be tested (uncompress it if needed)
                 # 2. Make sure oscap is installed
                 # 3. Generate the report for this OVAL file using oscap
@@ -66,13 +68,13 @@ module HybridPlatformsConductor
                 packages_to_install = []
                 KNOWN_COMPRESSIONS.each do |file_ext, compress_info|
                   file_ending = ".#{file_ext}"
-                  if local_oval_file.end_with?(file_ending)
-                    uncompress_cmds << compress_info[:cmd].call(local_oval_file)
-                    packages_to_install.concat(compress_info[:packages])
-                    local_oval_file = File.basename(local_oval_file, file_ending)
-                  end
+                  next unless local_oval_file.end_with?(file_ending)
+
+                  uncompress_cmds << compress_info[:cmd].call(local_oval_file)
+                  packages_to_install.concat(compress_info[:packages])
+                  local_oval_file = File.basename(local_oval_file, file_ending)
                 end
-                cmds = <<~EOS
+                cmds = <<~EO_BASH
                   set -e
                   #{
                     case image
@@ -84,7 +86,7 @@ module HybridPlatformsConductor
                       # On Debian 10 we have to compile it from sources, as the packaged official version has core dumps.
                       # cf https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1688223.html
                       # TODO: Remove this Debian 10 specificity when the official libopenscap8 will be corrected
-                      <<~EOS2
+                      <<~EO_BASH2
                         if [ ! -x "$(command -v oscap)" ] || [ "$(oscap --version | head -n 1 | awk '{print $6}')" != "1.3.4" ]; then
                           rm -rf openscap
                           git clone --recurse-submodules https://github.com/OpenSCAP/openscap.git
@@ -96,7 +98,7 @@ module HybridPlatformsConductor
                           #{sudo}make install
                         fi
                         #{sudo}apt install -y wget #{packages_to_install.join(' ')}
-                      EOS2
+                      EO_BASH2
                     else
                       raise "Non supported image: #{image}. Please adapt this test's code."
                     end
@@ -110,7 +112,7 @@ module HybridPlatformsConductor
                   echo "===== RESULTS ====="
                   cat "#{local_oval_file}.results.xml"
                   cd ..
-                EOS
+                EO_BASH
                 [
                   cmds,
                   {
@@ -119,21 +121,21 @@ module HybridPlatformsConductor
                       if idx_results.nil?
                         error 'No results given by the oscap run', stdout.join("\n")
                       else
-                        results = Nokogiri::XML(stdout[idx_results + 1..-1].join("\n"))
+                        results = Nokogiri::XML(stdout[idx_results + 1..].join("\n"))
                         results.remove_namespaces!
                         oval_definitions = results.css('oval_results oval_definitions definitions definition')
                         results.css('results system definitions definition').each do |definition_xml|
-                          if definition_xml['result'] == 'true'
-                            # Just found an OVAL item to be patched.
-                            definition_id = definition_xml['definition_id']
-                            oval_definition = oval_definitions.find { |el| el['id'] == definition_id }
-                            # We don't forcefully want to report all missing patches. Only the most important ones.
-                            severity = oval_definition.css('metadata advisory severity').text
-                            severity = 'Unknown' if severity.empty?
-                            if !oval_info.key?('reported_severities') || oval_info['reported_severities'].include?(severity)
-                              # Only consider the first line of the description, as sometimes it's very long
-                              error "Non-patched #{severity} vulnerability found: #{oval_definition.css('metadata title').text} - #{oval_definition.css('metadata description').text.split("\n").first}"
-                            end
+                          next unless definition_xml['result'] == 'true'
+
+                          # Just found an OVAL item to be patched.
+                          definition_id = definition_xml['definition_id']
+                          oval_definition = oval_definitions.find { |el| el['id'] == definition_id }
+                          # We don't forcefully want to report all missing patches. Only the most important ones.
+                          severity = oval_definition.css('metadata advisory severity').text
+                          severity = 'Unknown' if severity.empty?
+                          if !oval_info.key?('reported_severities') || oval_info['reported_severities'].include?(severity)
+                            # Only consider the first line of the description, as sometimes it's very long
+                            error "Non-patched #{severity} vulnerability found: #{oval_definition.css('metadata title').text} - #{oval_definition.css('metadata description').text.split("\n").first}"
                           end
                         end
                       end
@@ -142,7 +144,7 @@ module HybridPlatformsConductor
                     timeout: 240
                   }
                 ]
-              end]
+              end.to_h
             else
               error "No OVAL file defined for image #{image} at #{oval_file}"
               {}

data/lib/hybrid_platforms_conductor/hpc_plugins/test_report/confluence.rb

@@ -12,7 +12,7 @@ module HybridPlatformsConductor
       # Report tests results on a generated Confluence page
       class Confluence < HybridPlatformsConductor::TestReport
 
-        self.extend_config_dsl_with CommonConfigDsl::Confluence, :init_confluence
+        extend_config_dsl_with CommonConfigDsl::Confluence, :init_confluence
 
         # Maximum errors to be reported by item
         MAX_ERROR_ITEMS_DISPLAYED = 10
@@ -34,7 +34,7 @@ module HybridPlatformsConductor
                   at('h1:contains("Evolution")').
                   search('~ structured-macro:first-of-type').
                   css('table td').
-                  map { |td_element| td_element.text }.
+                  map(&:text).
                   each_slice(2).
                   to_a.
                   map { |(time_str, value_str)| [Time.parse("#{time_str} UTC"), value_str.to_f] }

data/lib/hybrid_platforms_conductor/hpc_plugins/test_report/stdout.rb

@@ -97,18 +97,20 @@ module HybridPlatformsConductor
               table << [
                 nodes_list,
                 nodes_info[:nodes].size,
-                nodes_info[:nodes].empty? ? '' : "#{(nodes_info[:tested_nodes].size*100.0/nodes_info[:nodes].size).to_i} %",
+                nodes_info[:nodes].empty? ? '' : "#{(nodes_info[:tested_nodes].size * 100.0 / nodes_info[:nodes].size).to_i} %",
                 nodes_info[:tested_nodes].empty? ? '' : "#{((nodes_info[:tested_nodes].size - nodes_info[:tested_nodes_in_error_as_expected].size) * 100.0 / nodes_info[:tested_nodes].size).to_i} %",
                 nodes_info[:tested_nodes].empty? ? '' : "#{((nodes_info[:tested_nodes].size - nodes_info[:tested_nodes_in_error].size) * 100.0 / nodes_info[:tested_nodes].size).to_i} %",
-                nodes_info[:nodes].empty? ? '' :
+                if nodes_info[:nodes].empty?
+                  ''
+                else
                   ('=' * ((nodes_info[:tested_nodes_in_error_as_expected].size * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).yellow.bold +
-                  ('=' * (((nodes_info[:tested_nodes_in_error].size - nodes_info[:tested_nodes_in_error_as_expected].size).abs * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).red.bold +
-                  ('=' * (((nodes_info[:tested_nodes].size - nodes_info[:tested_nodes_in_error].size) * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).green.bold +
-                  ('=' * (((nodes_info[:nodes].size - nodes_info[:tested_nodes].size) * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).white.bold
+                    ('=' * (((nodes_info[:tested_nodes_in_error].size - nodes_info[:tested_nodes_in_error_as_expected].size).abs * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).red.bold +
+                    ('=' * (((nodes_info[:tested_nodes].size - nodes_info[:tested_nodes_in_error].size) * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).green.bold +
+                    ('=' * (((nodes_info[:nodes].size - nodes_info[:tested_nodes].size) * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).white.bold
+                end
               ]
             end
           end)
-
         end
 
       end

data/lib/hybrid_platforms_conductor/io_router.rb

@@ -30,6 +30,7 @@ module HybridPlatformsConductor
     # Start routing messages asynchronously
     def start
       raise 'IO router is already started. Can\'t start it again.' unless @reading_thread.nil?
+
       @end_read = false
       # Create a thread to handle routes asynchronously
       @reading_thread = Thread.new do
@@ -37,22 +38,21 @@ module HybridPlatformsConductor
           need_to_stop = @end_read.clone
           data_found = false
           @routes.each do |src_io, dst_ios|
-            if src_io.is_a?(Queue)
-              queue_size = src_io.size
-              if queue_size > 0
-                # There is data to be read from src_io
-                data_found = true
-                data_chunk_str = queue_size.times.map { src_io.pop }.join
-                dst_ios.each do |dst_io|
-                  dst_io << data_chunk_str
-                  dst_io.flush if dst_io.respond_to?(:flush)
-                end
-              end
-            else
-              raise "Unknown type of source IO: #{src_io}"
+            raise "Unknown type of source IO: #{src_io}" unless src_io.is_a?(Queue)
+
+            queue_size = src_io.size
+            next unless queue_size.positive?
+
+            # There is data to be read from src_io
+            data_found = true
+            data_chunk_str = queue_size.times.map { src_io.pop }.join
+            dst_ios.each do |dst_io|
+              dst_io << data_chunk_str
+              dst_io.flush if dst_io.respond_to?(:flush)
             end
           end
           break if need_to_stop && !data_found
+
           sleep 0.1
         end
       end
@@ -61,6 +61,7 @@ module HybridPlatformsConductor
     # Stop routing messages asynchronously
     def stop
       raise 'IO router is not started. Can\'t stop it.' if @reading_thread.nil?
+
       @end_read = true
       @reading_thread.join
     end

data/lib/hybrid_platforms_conductor/json_dumper.rb

@@ -23,7 +23,7 @@ module HybridPlatformsConductor
     # * *config* (Config): Config to be used. [default = Config.new]
     # * *nodes_handler* (NodesHandler): Nodes handler to be used. [default = NodesHandler.new]
     # * *deployer* (Deployer): Deployer to be used. [default = Deployer.new]
-    def initialize(logger: Logger.new(STDOUT), logger_stderr: Logger.new(STDERR), config: Config.new, nodes_handler: NodesHandler.new, deployer: Deployer.new)
+    def initialize(logger: Logger.new($stdout), logger_stderr: Logger.new($stderr), config: Config.new, nodes_handler: NodesHandler.new, deployer: Deployer.new)
       init_loggers(logger, logger_stderr)
       @config = config
       @nodes_handler = nodes_handler
@@ -74,7 +74,7 @@ module HybridPlatformsConductor
             out "[ #{node} ] - Error while dumping JSON. Check #{stdout_file_name}"
           else
             json_file_name = "#{@dump_dir}/#{node}.json"
-            File.write(json_file_name, stdout[dump_begin_idx+1..dump_end_idx-1].join("\n"))
+            File.write(json_file_name, stdout[dump_begin_idx + 1..dump_end_idx - 1].join("\n"))
             out "[ #{node} ] - OK. Check #{json_file_name}"
           end
         else

data/lib/hybrid_platforms_conductor/log.rb

@@ -0,0 +1,31 @@
+require 'hybrid_platforms_conductor/logger_helpers'
+require 'hybrid_platforms_conductor/plugin'
+
+module HybridPlatformsConductor
+
+  # Ancestor of all log plugins
+  class Log < Plugin
+
+    # Constructor
+    #
+    # Parameters::
+    # * *logger* (Logger): Logger to be used [default: Logger.new(STDOUT)]
+    # * *logger_stderr* (Logger): Logger to be used for stderr [default: Logger.new(STDERR)]
+    # * *config* (Config): Config to be used. [default: Config.new]
+    # * *nodes_handler* (NodesHandler): Nodes handler to be used. [default: NodesHandler.new]
+    # * *actions_executor* (ActionsExecutor): Actions executor to be used. [default: ActionsExecutor.new]
+    def initialize(
+      logger: Logger.new($stdout),
+      logger_stderr: Logger.new($stderr),
+      config: Config.new,
+      nodes_handler: NodesHandler.new,
+      actions_executor: ActionsExecutor.new
+    )
+      super(logger: logger, logger_stderr: logger_stderr, config: config)
+      @nodes_handler = nodes_handler
+      @actions_executor = actions_executor
+    end
+
+  end
+
+end

data/lib/hybrid_platforms_conductor/logger_helpers.rb

@@ -55,25 +55,27 @@ module HybridPlatformsConductor
 
       # Make sure if the current line is not flushed we still do it
       def flush
-        unless @current_line.nil?
-          @stream << @current_line
-          @current_line = nil
-        end
+        return if @current_line.nil?
+
+        @stream << @current_line
+        @current_line = nil
       end
 
     end
 
     class << self
+
       attr_reader :progress_bar_semaphore
+
     end
     # Make sure the progress bar setting is protected by a Mutex
     @progress_bar_semaphore = Mutex.new
 
     # Sorted list of levels and their corresponding modifiers.
     LEVELS_MODIFIERS = {
-      fatal: [:red, :bold],
-      error: [:red, :bold],
-      warn: [:yellow, :bold],
+      fatal: %i[red bold],
+      error: %i[red bold],
+      warn: %i[yellow bold],
       info: [:white],
       debug: [:white],
       unknown: [:white]
@@ -82,7 +84,7 @@ module HybridPlatformsConductor
     # List of levels that will output on stderr
     LEVELS_TO_STDERR = %i[warn error fatal]
 
-    LEVELS_MODIFIERS.keys.each do |level|
+    LEVELS_MODIFIERS.each_key do |level|
       define_method("log_#{level}") do |message|
         (LEVELS_TO_STDERR.include?(level) ? @logger_stderr : @logger).send(
           level,
@@ -105,10 +107,10 @@ module HybridPlatformsConductor
     # Set loggers to the desired format
     def set_loggers_format
       [@logger, @logger_stderr].each do |logger|
-        logger.formatter = proc do |severity, datetime, progname, msg|
+        logger.formatter = proc do |severity, _datetime, progname, msg|
           # If the message already has control characters, don't colorize it
           keep_original_color = msg.include? "\u001b"
-          message = "[#{Time.now.utc.strftime('%F %T')} (PID #{$$} / TID #{Thread.current.object_id})] #{severity.rjust(5)} - [ #{progname} ] - "
+          message = "[#{Time.now.utc.strftime('%F %T')} (PID #{$PROCESS_ID} / TID #{Thread.current.object_id})] #{severity.rjust(5)} - [ #{progname} ] - "
           message << "#{msg}\n" unless keep_original_color
           LEVELS_MODIFIERS[severity.downcase.to_sym].each do |modifier|
             message = message.send(modifier)
@@ -282,8 +284,8 @@ module HybridPlatformsConductor
         yield progress_bar
       ensure
         LoggerHelpers.progress_bar_semaphore.synchronize do
-          self.stdout_device.flush
-          self.stderr_device.flush
+          stdout_device.flush
+          stderr_device.flush
           self.stdout_device = previous_stdout_device unless previous_stdout_device.nil?
           self.stderr_device = previous_stderr_device unless previous_stderr_device.nil?
         end
@@ -298,15 +300,16 @@ module HybridPlatformsConductor
     def stdouts_to_s
       messages = []
       {
-        'STDOUT' => self.stdout_device,
-        'STDERR' => self.stderr_device
+        'STDOUT' => stdout_device,
+        'STDERR' => stderr_device
       }.each do |name, device|
-        if device.is_a?(File)
+        case device
+        when File
           if File.exist?(device.path)
             content = File.read(device.path).strip
             messages << "----- #{name} BEGIN - #{device.path} -----\n#{content}\n----- #{name} END - #{device.path} -----" unless content.empty?
           end
-        elsif device.is_a?(StringIO)
+        when StringIO
           content = device.string
           messages << "----- #{name} BEGIN -----\n#{content}\n----- #{name} END -----" unless content.empty?
         end

data/lib/hybrid_platforms_conductor/nodes_handler.rb

@@ -40,7 +40,7 @@ module HybridPlatformsConductor
       # * *master_cmdbs_info* (Hash< Symbol, Symbol or Array<Symbol> >): List of metadata properties (or single one) per CMDB name considered as master for those properties.
       def master_cmdbs(master_cmdbs_info)
         @cmdb_masters << {
-          cmdb_masters: Hash[master_cmdbs_info.map { |cmdb, properties| [cmdb, properties.is_a?(Array) ? properties : [properties]] }],
+          cmdb_masters: master_cmdbs_info.transform_values { |properties| properties.is_a?(Array) ? properties : [properties] },
           nodes_selectors_stack: current_nodes_selectors_stack
         }
       end
@@ -60,7 +60,8 @@ module HybridPlatformsConductor
 
     Config.extend_config_dsl_with ConfigDSLExtension, :init_nodes_handler_config
 
-    include LoggerHelpers, ParallelThreads
+    include ParallelThreads
+    include LoggerHelpers
 
     class GitError < RuntimeError
     end
@@ -74,8 +75,8 @@ module HybridPlatformsConductor
     # * *cmd_runner* (CmdRunner): Command executor to be used. [default: CmdRunner.new]
     # * *platforms_handler* (PlatformsHandler): Platforms Handler to be used. [default: PlatformsHandler.new]
     def initialize(
-      logger: Logger.new(STDOUT),
-      logger_stderr: Logger.new(STDERR),
+      logger: Logger.new($stdout),
+      logger_stderr: Logger.new($stderr),
       config: Config.new,
       cmd_runner: CmdRunner.new,
       platforms_handler: PlatformsHandler.new
@@ -111,11 +112,11 @@ module HybridPlatformsConductor
           )
           @cmdbs_others << cmdb if cmdb.respond_to?(:get_others)
           cmdb.methods.each do |method|
-            if method.to_s =~ /^get_(.*)$/
-              property = $1.to_sym
-              @cmdbs_per_property[property] = [] unless @cmdbs_per_property.key?(property)
-              @cmdbs_per_property[property] << cmdb
-            end
+            next unless method.to_s =~ /^get_(.*)$/
+
+            property = Regexp.last_match(1).to_sym
+            @cmdbs_per_property[property] = [] unless @cmdbs_per_property.key?(property)
+            @cmdbs_per_property[property] << cmdb
           end
           cmdb
         end
@@ -133,13 +134,17 @@ module HybridPlatformsConductor
         # Register all known nodes for this platform
         platform.known_nodes.each do |node|
           raise "Can't register #{node} to platform #{platform.repository_path}, as it is already defined in platform #{@nodes_platform[node].repository_path}." if @nodes_platform.key?(node)
+
           @nodes_platform[node] = platform
         end
         # Register all known nodes lists
+        next unless platform.respond_to?(:known_nodes_lists)
+
         platform.known_nodes_lists.each do |nodes_list|
           raise "Can't register nodes list #{nodes_list} to platform #{platform.repository_path}, as it is already defined in platform #{@nodes_list_platform[nodes_list].repository_path}." if @nodes_list_platform.key?(nodes_list)
+
           @nodes_list_platform[nodes_list] = platform
-        end if platform.respond_to?(:known_nodes_lists)
+        end
       end
     end
 
@@ -147,7 +152,7 @@ module HybridPlatformsConductor
     #
     # Parameters::
     # * *options_parser* (OptionParser): The option parser to complete
-    def options_parse(options_parser, parallel: true)
+    def options_parse(options_parser)
       options_parser.separator ''
       options_parser.separator 'Nodes handler options:'
       options_parser.on('-o', '--show-nodes', 'Display the list of possible nodes and exit') do
@@ -221,6 +226,7 @@ module HybridPlatformsConductor
         platform_name, from_commit, to_commit, flags = nodes_git_impact.split(':')
         flags = (flags || '').split(',')
         raise "Invalid platform in --nodes-git-impact: #{platform_name}. Possible values are: #{platform_names.join(', ')}." unless platform_names.include?(platform_name)
+
         nodes_selector = { platform: platform_name }
         nodes_selector[:from_commit] = from_commit if from_commit && !from_commit.empty?
         nodes_selector[:to_commit] = to_commit if to_commit && !to_commit.empty?
@@ -329,7 +335,7 @@ module HybridPlatformsConductor
     # * *block* (Proc): Code block given to the call
     def method_missing(method, *args, &block)
       if method.to_s =~ /^get_(.*)_of$/
-        property = $1.to_sym
+        property = Regexp.last_match(1).to_sym
         # Define the method so that we don't go trough method_missing next time (more efficient).
         define_property_method_for(property)
         # Then call it
@@ -341,6 +347,15 @@ module HybridPlatformsConductor
       end
     end
 
+    # Make sure we register the methods we handle in method_missing
+    #
+    # Parameters::
+    # * *name* (Symbol): The missing method name
+    # * *include_private* (Boolean): Should we include private methods in the search?
+    def respond_to_missing?(name, include_private)
+      name.to_s =~ /^get_(.*)_of$/ || super
+    end
+
     # Prefetch some metadata properties for a given list of nodes.
     # Useful for performance reasons when clients know they will need to use a lot of properties on nodes.
     # Keep a thread-safe memory cache of it.
@@ -352,52 +367,51 @@ module HybridPlatformsConductor
       (properties.is_a?(Symbol) ? [properties] : properties).each do |property|
         # Gather the list of nodes missing this property
         missing_nodes = nodes.select { |node| !@metadata.key?(node) || !@metadata[node].key?(property) }
-        unless missing_nodes.empty?
-          # Query the CMDBs having first the get_<property> method, then the ones having the get_others method till we have our property set for all missing nodes
-          # Metadata being retrieved by the different CMDBs, per node
+        next if missing_nodes.empty?
+
+        # Query the CMDBs having first the get_<property> method, then the ones having the get_others method till we have our property set for all missing nodes
+        # Metadata being retrieved by the different CMDBs, per node
+        # Hash< String, Object >
+        updated_metadata = {}
+        (
+          (@cmdbs_per_property.key?(property) ? @cmdbs_per_property[property] : []).map { |cmdb| [cmdb, property] } +
+            @cmdbs_others.map { |cmdb| [cmdb, :others] }
+        ).each do |(cmdb, cmdb_property)|
+          # If among the missing nodes some of them have some master CMDB declared for this property, filter them out unless we are dealing with their master CMDB.
+          nodes_to_query = missing_nodes.select do |node|
+            master_cmdb = cmdb_master_for(node, property)
+            master_cmdb.nil? || master_cmdb == cmdb
+          end
+          next if nodes_to_query.empty?
+
+          # Check first if this property depends on other ones for this cmdb
+          if cmdb.respond_to?(:property_dependencies)
+            property_deps = cmdb.property_dependencies
+            prefetch_metadata_of nodes_to_query, property_deps[property] if property_deps.key?(property)
+          end
+          # Property values, per node name
           # Hash< String, Object >
-          updated_metadata = {}
-          (
-            (@cmdbs_per_property.key?(property) ? @cmdbs_per_property[property] : []).map { |cmdb| [cmdb, property] } +
-              @cmdbs_others.map { |cmdb| [cmdb, :others] }
-          ).each do |(cmdb, cmdb_property)|
-            # If among the missing nodes some of them have some master CMDB declared for this property, filter them out unless we are dealing with their master CMDB.
-            nodes_to_query = missing_nodes.select do |node|
-              master_cmdb = cmdb_master_for(node, property)
-              master_cmdb.nil? || master_cmdb == cmdb
-            end
-            unless nodes_to_query.empty?
-              # Check first if this property depends on other ones for this cmdb
-              if cmdb.respond_to?(:property_dependencies)
-                property_deps = cmdb.property_dependencies
-                prefetch_metadata_of nodes_to_query, property_deps[property] if property_deps.key?(property)
-              end
-              # Property values, per node name
-              # Hash< String, Object >
-              metadata_from_cmdb = Hash[
-                cmdb.send("get_#{cmdb_property}".to_sym, nodes_to_query, @metadata.slice(*nodes_to_query)).map do |node, cmdb_result|
-                  [node, cmdb_property == :others ? cmdb_result[property] : cmdb_result]
-                end
-              ].compact
-              cmdb_log_header = "[CMDB #{cmdb.class.name.split('::').last}.#{cmdb_property}] -"
-              log_debug "#{cmdb_log_header} Query property #{property} for #{nodes_to_query.size} nodes (#{nodes_to_query[0..7].join(', ')}...) => Found metadata for #{metadata_from_cmdb.size} nodes."
-              updated_metadata.merge!(metadata_from_cmdb) do |node, existing_value, new_value|
-                raise "#{cmdb_log_header} Returned a conflicting value for metadata #{property} of node #{node}: #{new_value} whereas the value was already set to #{existing_value}" if !existing_value.nil? && new_value != existing_value
-                new_value
-              end
-            end
+          metadata_from_cmdb = cmdb.send("get_#{cmdb_property}".to_sym, nodes_to_query, @metadata.slice(*nodes_to_query)).transform_values do |cmdb_result|
+            cmdb_property == :others ? cmdb_result[property] : cmdb_result
+          end.compact
+          cmdb_log_header = "[CMDB #{cmdb.class.name.split('::').last}.#{cmdb_property}] -"
+          log_debug "#{cmdb_log_header} Query property #{property} for #{nodes_to_query.size} nodes (#{nodes_to_query[0..7].join(', ')}...) => Found metadata for #{metadata_from_cmdb.size} nodes."
+          updated_metadata.merge!(metadata_from_cmdb) do |node, existing_value, new_value|
+            raise "#{cmdb_log_header} Returned a conflicting value for metadata #{property} of node #{node}: #{new_value} whereas the value was already set to #{existing_value}" if !existing_value.nil? && new_value != existing_value
+
+            new_value
           end
-          # Avoid conflicts in metadata while merging and make sure this update is thread-safe
-          # As @metadata is only appending data and never deleting it, protecting the update only is enough.
-          # At worst several threads will query several times the same CMDBs to update the same data several times.
-          # If we also want to be thread-safe in this regard, we should protect the whole CMDB call with mutexes, at the granularity of the node + property bein read.
-          @metadata_mutex.synchronize do
-            missing_nodes.each do |node|
-              @metadata[node] = {} unless @metadata.key?(node)
-              # Here, explicitely store nil if nothing has been found for a node because we know there is no value to be fetched.
-              # This way we won't query again all CMDBs thanks to the cache.
-              @metadata[node][property] = updated_metadata[node]
-            end
+        end
+        # Avoid conflicts in metadata while merging and make sure this update is thread-safe
+        # As @metadata is only appending data and never deleting it, protecting the update only is enough.
+        # At worst several threads will query several times the same CMDBs to update the same data several times.
+        # If we also want to be thread-safe in this regard, we should protect the whole CMDB call with mutexes, at the granularity of the node + property bein read.
+        @metadata_mutex.synchronize do
+          missing_nodes.each do |node|
+            @metadata[node] = {} unless @metadata.key?(node)
+            # Here, explicitely store nil if nothing has been found for a node because we know there is no value to be fetched.
+            # This way we won't query again all CMDBs thanks to the cache.
+            @metadata[node][property] = updated_metadata[node]
           end
         end
       end
@@ -426,6 +440,7 @@ module HybridPlatformsConductor
       nodes_selectors = nodes_selectors.flatten
       # 1. Check for the presence of all
       return known_nodes if nodes_selectors.any? { |nodes_selector| nodes_selector.is_a?(Hash) && nodes_selector.key?(:all) && nodes_selector[:all] }
+
       # 2. Expand the nodes lists, platforms and services contents
       string_nodes = []
       nodes_selectors.each do |nodes_selector|
@@ -435,6 +450,7 @@ module HybridPlatformsConductor
           if nodes_selector.key?(:list)
             platform = @nodes_list_platform[nodes_selector[:list]]
             raise "Unknown nodes list: #{nodes_selector[:list]}" if platform.nil?
+
             string_nodes.concat(platform.nodes_selectors_from_nodes_list(nodes_selector[:list]))
           end
           string_nodes.concat(@platforms_handler.platform(nodes_selector[:platform]).known_nodes) if nodes_selector.key?(:platform)
@@ -462,8 +478,8 @@ module HybridPlatformsConductor
       # 3. Expand the Regexps
       real_nodes = []
       string_nodes.each do |node|
-        if node =~ /^\/(.+)\/$/
-          node_regexp = Regexp.new($1)
+        if node =~ %r{^/(.+)/$}
+          node_regexp = Regexp.new(Regexp.last_match(1))
           real_nodes.concat(known_nodes.select { |known_node| known_node[node_regexp] })
         else
           real_nodes << node
@@ -489,13 +505,11 @@ module HybridPlatformsConductor
     # * *parallel* (Boolean): Iterate in a multithreaded way? [default: false]
     # * *nbr_threads_max* (Integer or nil): Maximum number of threads to be used in case of parallel, or nil for no limit [default: nil]
     # * *progress* (String or nil): Name of a progress bar to follow the progression, or nil for no progress bar [default: 'Processing nodes']
-    # * Proc: The code called for each node being iterated on.
+    # * *block* (Proc): The code called for each node being iterated on.
     #   * Parameters::
     #     * *node* (String): The node name
-    def for_each_node_in(nodes, parallel: false, nbr_threads_max: nil, progress: 'Processing nodes')
-      for_each_element_in(nodes.sort, parallel: parallel, nbr_threads_max: nbr_threads_max, progress: progress) do |node|
-        yield node
-      end
+    def for_each_node_in(nodes, parallel: false, nbr_threads_max: nil, progress: 'Processing nodes', &block)
+      for_each_element_in(nodes.sort, parallel: parallel, nbr_threads_max: nbr_threads_max, progress: progress, &block)
     end
 
     # Get the list of impacted nodes from a git diff on a platform
@@ -513,10 +527,11 @@ module HybridPlatformsConductor
     def impacted_nodes_from_git_diff(platform_name, from_commit: 'master', to_commit: nil, smallest_set: false)
       platform = @platforms_handler.platform(platform_name)
       raise "Unkown platform #{platform_name}. Possible platforms are #{@platforms_handler.known_platforms.map(&:name).sort.join(', ')}" if platform.nil?
+
       begin
         _exit_status, stdout, _stderr = @cmd_runner.run_cmd "cd #{platform.repository_path} && git --no-pager diff --no-color #{from_commit} #{to_commit.nil? ? '' : to_commit}", log_to_stdout: log_debug?
       rescue CmdRunner::UnexpectedExitCodeError
-        raise GitError, $!.to_s
+        raise GitError, $ERROR_INFO.to_s
       end
       # Parse the git diff output to create a structured diff
       # Hash< String, Hash< Symbol, Object > >: List of diffs info, per file name having a diff. Diffs info have the following properties:
@@ -526,9 +541,10 @@ module HybridPlatformsConductor
       current_file_diff = nil
       stdout.split("\n").each do |line|
         case line
-        when /^diff --git a\/(.+) b\/(.+)$/
+        when %r{^diff --git a/(.+) b/(.+)$}
           # A new file diff
-          from, to = $1, $2
+          from = Regexp.last_match(1)
+          to = Regexp.last_match(2)
           current_file_diff = {
             diff: ''
           }
@@ -626,11 +642,13 @@ module HybridPlatformsConductor
         cmdb_masters_cache = {}
         select_confs_for_node(node, @config.cmdb_masters).each do |cmdb_masters_info|
           cmdb_masters_info[:cmdb_masters].each do |cmdb, properties|
-            properties.each do |property|
-              raise "Property #{property} have conflicting CMDB masters for #{node} declared in the configuration: #{cmdb_masters_cache[property].class.name} and #{@cmdbs[cmdb].class.name}" if cmdb_masters_cache.key?(property) && cmdb_masters_cache[property] != @cmdbs[cmdb]
-              log_debug "CMDB master for #{node} / #{property}: #{cmdb}"
-              raise "CMDB #{cmdb} is configured as a master for property #{property} on node #{node} but it does not implement the needed API to retrieve it" unless (@cmdbs_per_property[property] || []).include?(@cmdbs[cmdb]) || @cmdbs_others.include?(@cmdbs[cmdb])
-              cmdb_masters_cache[property] = @cmdbs[cmdb]
+            properties.each do |itr_property|
+              raise "Property #{itr_property} have conflicting CMDB masters for #{node} declared in the configuration: #{cmdb_masters_cache[itr_property].class.name} and #{@cmdbs[cmdb].class.name}" if cmdb_masters_cache.key?(itr_property) && cmdb_masters_cache[itr_property] != @cmdbs[cmdb]
+
+              log_debug "CMDB master for #{node} / #{itr_property}: #{cmdb}"
+              raise "CMDB #{cmdb} is configured as a master for property #{itr_property} on node #{node} but it does not implement the needed API to retrieve it" unless (@cmdbs_per_property[itr_property] || []).include?(@cmdbs[cmdb]) || @cmdbs_others.include?(@cmdbs[cmdb])
+
+              cmdb_masters_cache[itr_property] = @cmdbs[cmdb]
             end
           end
         end