hybrid_platforms_conductor 32.17.0 → 33.0.2

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/podman_spec.rb

@@ -40,7 +40,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
 
   it 'creates an instance' do
     with_test_podman_platform do |instance, repository|
-      with_cmd_runner_mocked([
+      with_cmd_runner_mocked [
         ['whoami', proc { [0, 'test_user', ''] }],
         [
           "cd #{repository}/docker_image && sudo podman build --tag hpc_image_test_image --security-opt seccomp=/usr/share/containers/seccomp.json --cgroup-manager=cgroupfs .",
@@ -54,7 +54,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
           'sudo podman container create --name hpc_container_node_test hpc_image_test_image',
           proc { [0, '', ''] }
         ]
-      ]) do
+      ] do
         instance.create
       end
     end
@@ -62,7 +62,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
 
   it 'creates an instance as root' do
     with_test_podman_platform do |instance, repository|
-      with_cmd_runner_mocked([
+      with_cmd_runner_mocked [
         ['whoami', proc { [0, 'root', ''] }],
         [
           "cd #{repository}/docker_image && podman build --tag hpc_image_test_image --security-opt seccomp=/usr/share/containers/seccomp.json --cgroup-manager=cgroupfs .",
@@ -76,7 +76,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
           'podman container create --name hpc_container_node_test hpc_image_test_image',
           proc { [0, '', ''] }
         ]
-      ]) do
+      ] do
         instance.create
       end
     end
@@ -84,7 +84,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
 
   it 'reuses an instance already created' do
     with_test_podman_platform do |instance, repository|
-      with_cmd_runner_mocked([
+      with_cmd_runner_mocked [
         ['whoami', proc { [0, 'test_user', ''] }],
         [
           "cd #{repository}/docker_image && sudo podman build --tag hpc_image_test_image --security-opt seccomp=/usr/share/containers/seccomp.json --cgroup-manager=cgroupfs .",
@@ -94,7 +94,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
           /^sudo podman container list --all | grep hpc_container_node_test_\d+_\d+$/,
           proc { [0, "062ede10d1c0  localhost/hpc_image_debian_9:latest  /usr/sbin/sshd -D  7 days ago   Exited (0) 6 days ago           hpc_container_node_test_\n", ''] }
         ]
-      ]) do
+      ] do
         instance.create
       end
     end
@@ -102,7 +102,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
 
   it 'starts an instance' do
     with_test_podman_platform do |instance, repository|
-      with_cmd_runner_mocked([
+      with_cmd_runner_mocked [
         ['whoami', proc { [0, 'test_user', ''] }],
         [
           "cd #{repository}/docker_image && sudo podman build --tag hpc_image_test_image --security-opt seccomp=/usr/share/containers/seccomp.json --cgroup-manager=cgroupfs .",
@@ -113,7 +113,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
           proc { [0, "062ede10d1c0  localhost/hpc_image_debian_9:latest  /usr/sbin/sshd -D  7 days ago   Exited (0) 6 days ago           hpc_container_node_test_\n", ''] }
         ],
         ['sudo podman container start --cgroup-manager=cgroupfs hpc_container_node_test', proc { [0, '', ''] }]
-      ]) do
+      ] do
         instance.create
         instance.start
       end
@@ -122,7 +122,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
 
   it 'stops an instance' do
     with_test_podman_platform do |instance, repository|
-      with_cmd_runner_mocked([
+      with_cmd_runner_mocked [
         ['whoami', proc { [0, 'test_user', ''] }],
         [
           "cd #{repository}/docker_image && sudo podman build --tag hpc_image_test_image --security-opt seccomp=/usr/share/containers/seccomp.json --cgroup-manager=cgroupfs .",
@@ -134,7 +134,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
         ],
         ['sudo podman container start --cgroup-manager=cgroupfs hpc_container_node_test', proc { [0, '', ''] }],
         ['sudo podman container stop hpc_container_node_test', proc { [0, '', ''] }]
-      ]) do
+      ] do
         instance.create
         instance.start
         instance.stop
@@ -144,7 +144,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
 
   it 'destroys an instance' do
     with_test_podman_platform do |instance, repository|
-      with_cmd_runner_mocked([
+      with_cmd_runner_mocked [
         ['whoami', proc { [0, 'test_user', ''] }],
         [
           "cd #{repository}/docker_image && sudo podman build --tag hpc_image_test_image --security-opt seccomp=/usr/share/containers/seccomp.json --cgroup-manager=cgroupfs .",
@@ -155,7 +155,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
           proc { [0, "062ede10d1c0  localhost/hpc_image_debian_9:latest  /usr/sbin/sshd -D  7 days ago   Exited (0) 6 days ago           hpc_container_node_test_\n", ''] }
         ],
         ['sudo podman container rm hpc_container_node_test', proc { [0, '', ''] }]
-      ]) do
+      ] do
         instance.create
         instance.destroy
       end
@@ -163,14 +163,14 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
   end
 
   it 'gets the status of a missing instance' do
-    with_test_podman_platform do |instance, repository|
+    with_test_podman_platform do |instance|
       expect(instance.state).to eq :missing
     end
   end
 
   it 'gets the status of a created instance' do
     with_test_podman_platform do |instance, repository|
-      with_cmd_runner_mocked([
+      with_cmd_runner_mocked [
         ['whoami', proc { [0, 'test_user', ''] }],
         [
           "cd #{repository}/docker_image && sudo podman build --tag hpc_image_test_image --security-opt seccomp=/usr/share/containers/seccomp.json --cgroup-manager=cgroupfs .",
@@ -181,7 +181,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
           proc { [0, "062ede10d1c0  localhost/hpc_image_debian_9:latest  /usr/sbin/sshd -D  7 days ago   Exited (0) 6 days ago           hpc_container_node_test_\n", ''] }
         ],
         ['sudo podman container inspect hpc_container_node_test', proc { [0, '[{"State":{"Status": "created"}}]', ''] }]
-      ]) do
+      ] do
         instance.create
         expect(instance.state).to eq :created
       end
@@ -190,7 +190,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
 
   it 'gets the IP of a created instance' do
     with_test_podman_platform do |instance, repository|
-      with_cmd_runner_mocked([
+      with_cmd_runner_mocked [
         ['whoami', proc { [0, 'test_user', ''] }],
         [
           "cd #{repository}/docker_image && sudo podman build --tag hpc_image_test_image --security-opt seccomp=/usr/share/containers/seccomp.json --cgroup-manager=cgroupfs .",
@@ -201,7 +201,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Podman do
           proc { [0, "062ede10d1c0  localhost/hpc_image_debian_9:latest  /usr/sbin/sshd -D  7 days ago   Exited (0) 6 days ago           hpc_container_node_test_\n", ''] }
         ],
         ['sudo podman container inspect hpc_container_node_test | grep IPAddress', proc { [0, ' "IPAddress": "192.168.42.42",', ''] }]
-      ]) do
+      ] do
         instance.create
         expect(instance.ip).to eq '192.168.42.42'
       end

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/config_dsl_spec.rb

@@ -2,11 +2,11 @@ require 'hybrid_platforms_conductor/hpc_plugins/provisioner/proxmox'
 
 describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
-  context 'checking Config DSL extensions' do
+  context 'when checking Config DSL extensions' do
 
     it 'declares proxmox configuratin in Config DSL' do
-      with_repository do |repository|
-        platforms = <<~EOS
+      with_repository do
+        platforms = <<~EO_CONFIG
           proxmox(
             api_url: 'https://my-proxmox.my-domain.com:8006',
             sync_node: 'test_node',
@@ -60,7 +60,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
             },
             default_timeout: 666
           )
-        EOS
+        EO_CONFIG
         with_platforms platforms do
           expect(test_config.proxmox_servers).to eq [
             {

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/create_spec.rb

@@ -2,7 +2,7 @@ require 'hybrid_platforms_conductor/hpc_plugins/provisioner/proxmox'
 
 describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
-  context 'checking containers creation' do
+  context 'when checking containers creation' do
 
     it 'creates an instance' do
       with_test_proxmox_platform do |instance|
@@ -11,7 +11,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           mock_proxmox_to_get_nodes_info
         ]
         instance.create
-        expect(@proxmox_create_options).to eq({
+        expect(proxmox_create_options).to eq(
           'cores' => 2,
           'cpulimit' => 2,
           'description' => "===== HPC info =====\nnode: node\nenvironment: test\ndebug: false\n",
@@ -23,7 +23,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           'password' => 'root_pwd',
           'rootfs' => 'local-lvm:10',
           'searchdomain' => 'my-domain.com'
-        })
+        )
       end
     end
 
@@ -39,7 +39,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           expected_file_id: 'node_really_big_environment_name_that_will_exceed_for_sure_the_limit_of_hostnames_really_big_environment_name_that_will_exceed_for_sure_the_limit_of_hostnames_really_big_environment_name_that_will_exceed_for_sure_the_limit_of_hostnam-258ca1fc'
         )
         instance.create
-        expect(@proxmox_create_options['hostname']).to eq expected_hostname
+        expect(proxmox_create_options['hostname']).to eq expected_hostname
       end
     end
 
@@ -54,7 +54,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           expected_sudo: false
         )
         instance.create
-        expect(@proxmox_create_options).to eq({
+        expect(proxmox_create_options).to eq(
           'cores' => 2,
           'cpulimit' => 2,
           'description' => "===== HPC info =====\nnode: node\nenvironment: test\ndebug: false\n",
@@ -66,7 +66,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           'password' => 'root_pwd',
           'rootfs' => 'local-lvm:10',
           'searchdomain' => 'my-domain.com'
-        })
+        )
       end
     end
 
@@ -110,7 +110,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
     it 'fails to create an instance when the reserve_proxmox_container sync node ends in error' do
       with_test_proxmox_platform do |instance|
-        mock_proxmox_calls_with([
+        mock_proxmox_calls_with(
+          [
             # 1 - The info on existing containers
             mock_proxmox_to_get_nodes_info
           ],
@@ -121,13 +122,15 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
     end
 
     it 'creates an instance using resources defined for a given node' do
-      with_test_proxmox_platform(node_metadata: {
-        deploy_resources_min: {
-          cpus: 24,
-          ram_mb: 4096,
-          disk_gb: 20
+      with_test_proxmox_platform(
+        node_metadata: {
+          deploy_resources_min: {
+            cpus: 24,
+            ram_mb: 4096,
+            disk_gb: 20
+          }
         }
-      }) do |instance|
+      ) do |instance|
         mock_proxmox_calls_with(
           [
             # 1 - The info on existing containers
@@ -135,7 +138,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           ]
         )
         instance.create
-        expect(@proxmox_create_options).to eq({
+        expect(proxmox_create_options).to eq(
           'cores' => 24,
           'cpulimit' => 24,
           'description' => "===== HPC info =====\nnode: node\nenvironment: test\ndebug: false\n",
@@ -147,7 +150,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           'password' => 'root_pwd',
           'rootfs' => 'local-lvm:20',
           'searchdomain' => 'my-domain.com'
-        })
+        )
       end
     end
 
@@ -164,23 +167,19 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 }
               ],
               extra_expects: proc do |proxmox|
-                expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc') do
-                  [
-                    {
-                      'vmid' => '1042'
-                    }
-                  ]
-                end
-                expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc/1042/config') do
+                expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc').and_return [
                   {
-                    'net0' => 'ip=192.168.0.101/32',
-                    'description' => <<~EOS
-                      ===== HPC info =====
-                      node: node
-                      environment: test
-                    EOS
+                    'vmid' => '1042'
                   }
-                end
+                ]
+                expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc/1042/config').and_return(
+                  'net0' => 'ip=192.168.0.101/32',
+                  'description' => <<~EO_DESCRIPTION
+                    ===== HPC info =====
+                    node: node
+                    environment: test
+                  EO_DESCRIPTION
+                )
               end
             )
           ],
@@ -236,22 +235,18 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               }
             ],
             extra_expects: proc do |proxmox|
-              expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc') do
-                [
-                  {
-                    'vmid' => '1042'
-                  }
-                ]
-              end
-              expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc/1042/config') do
+              expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc').and_return [
                 {
-                  'description' => <<~EOS
-                    ===== HPC info =====
-                    node: node
-                    environment: other_environment
-                  EOS
+                  'vmid' => '1042'
                 }
-              end
+              ]
+              expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc/1042/config').and_return(
+                'description' => <<~EO_DESCRIPTION
+                  ===== HPC info =====
+                  node: node
+                  environment: other_environment
+                EO_DESCRIPTION
+              )
             end
           )
         ]
@@ -271,13 +266,11 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               }
             ],
             extra_expects: proc do |proxmox|
-              expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc') do
-                [
-                  {
-                    'vmid' => '100'
-                  }
-                ]
-              end
+              expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc').and_return [
+                {
+                  'vmid' => '100'
+                }
+              ]
             end
           )
         ]

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/destroy_spec.rb

@@ -2,7 +2,7 @@ require 'hybrid_platforms_conductor/hpc_plugins/provisioner/proxmox'
 
 describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
-  context 'checking containers destroy' do
+  context 'when checking containers destroy' do
 
     it 'destroys an instance' do
       with_test_proxmox_platform do |instance|
@@ -15,11 +15,11 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
         )
         instance.create
         instance.destroy
-        expect(@proxmox_destroy_options).to eq({
+        expect(proxmox_destroy_options).to eq(
           'vm_id' => 1024,
           'environment' => 'test',
           'node' => 'node'
-        })
+        )
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/ip_spec.rb

@@ -2,7 +2,7 @@ require 'hybrid_platforms_conductor/hpc_plugins/provisioner/proxmox'
 
 describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
-  context 'checking containers IP retrieval' do
+  context 'when checking containers IP retrieval' do
 
     it 'returns the IP of a newly created instance' do
       with_test_proxmox_platform do |instance|
@@ -28,23 +28,19 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 }
               ],
               extra_expects: proc do |proxmox|
-                expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc') do
-                  [
-                    {
-                      'vmid' => '1042'
-                    }
-                  ]
-                end
-                expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc/1042/config') do
+                expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc').and_return [
                   {
-                    'net0' => 'ip=192.168.42.101/32',
-                    'description' => <<~EOS
-                      ===== HPC info =====
-                      node: node
-                      environment: test
-                    EOS
+                    'vmid' => '1042'
                   }
-                end
+                ]
+                expect(proxmox).to receive(:get).with('nodes/pve_node_name/lxc/1042/config').and_return(
+                  'net0' => 'ip=192.168.42.101/32',
+                  'description' => <<~EO_DESCRIPTION
+                    ===== HPC info =====
+                    node: node
+                    environment: test
+                  EO_DESCRIPTION
+                )
               end
             )
           ],

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/reserve_proxmox_container/destroy_vm_spec.rb

@@ -2,15 +2,17 @@ require 'hybrid_platforms_conductor/hpc_plugins/provisioner/proxmox'
 
 describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
-  context 'checking the reserve_proxmox_container sync tool' do
+  context 'when checking the reserve_proxmox_container sync tool' do
 
-    context 'checking how VMs are being destroyed' do
+    context 'when checking how VMs are being destroyed' do
 
       it 'releases a previously reserved VM that has been reserved and is running' do
         with_sync_node do
-          mock_proxmox(mocked_pve_nodes: {
-            'pve_node_name' => { lxc_containers: { 1042 => { status: 'running', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' } } }
-          })
+          mock_proxmox(
+            mocked_pve_nodes: {
+              'pve_node_name' => { lxc_containers: { 1042 => { status: 'running', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' } } }
+            }
+          )
           expect(call_release_proxmox_container(1042, 'node', 'test_env')).to eq({ pve_node: 'pve_node_name' })
           expect_proxmox_actions_to_be [
             [:post, 'nodes/pve_node_name/lxc/1042/status/stop'],
@@ -21,9 +23,11 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
       it 'releases a previously reserved VM that has been reserved and is stopped' do
         with_sync_node do
-          mock_proxmox(mocked_pve_nodes: {
-            'pve_node_name' => { lxc_containers: { 1042 => { status: 'stopped', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' } } }
-          })
+          mock_proxmox(
+            mocked_pve_nodes: {
+              'pve_node_name' => { lxc_containers: { 1042 => { status: 'stopped', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' } } }
+            }
+          )
           expect(call_release_proxmox_container(1042, 'node', 'test_env')).to eq({ pve_node: 'pve_node_name' })
           expect_proxmox_actions_to_be [
             [:delete, 'nodes/pve_node_name/lxc/1042']
@@ -41,12 +45,16 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
       it 'releases a previously reserved VM without impacting other VMs' do
         with_sync_node do
-          mock_proxmox(mocked_pve_nodes: {
-            'pve_node_name' => { lxc_containers: {
-              1042 => { status: 'running', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' },
-              1043 => { status: 'running', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' }
+          mock_proxmox(
+            mocked_pve_nodes: {
+              'pve_node_name' => {
+                lxc_containers: {
+                  1042 => { status: 'running', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' },
+                  1043 => { status: 'running', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' }
+                }
+              }
             }
-          } })
+          )
           expect(call_release_proxmox_container(1042, 'node', 'test_env')).to eq({ pve_node: 'pve_node_name' })
           expect_proxmox_actions_to_be [
             [:post, 'nodes/pve_node_name/lxc/1042/status/stop'],
@@ -57,9 +65,11 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
       it 'does not release a previously reserved VM that has now a different node' do
         with_sync_node do
-          mock_proxmox(mocked_pve_nodes: {
-            'pve_node_name' => { lxc_containers: { 1042 => { status: 'stopped', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' } } }
-          })
+          mock_proxmox(
+            mocked_pve_nodes: {
+              'pve_node_name' => { lxc_containers: { 1042 => { status: 'stopped', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' } } }
+            }
+          )
           expect(call_release_proxmox_container(1042, 'other_node', 'test_env')).to eq({})
           expect_proxmox_actions_to_be []
         end
@@ -67,9 +77,11 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
       it 'does not release a previously reserved VM that has now a different environment' do
         with_sync_node do
-          mock_proxmox(mocked_pve_nodes: {
-            'pve_node_name' => { lxc_containers: { 1042 => { status: 'stopped', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' } } }
-          })
+          mock_proxmox(
+            mocked_pve_nodes: {
+              'pve_node_name' => { lxc_containers: { 1042 => { status: 'stopped', creation_date: (Time.now - 60).utc, node: 'node', environment: 'test_env' } } }
+            }
+          )
           expect(call_release_proxmox_container(1042, 'node', 'other_test_env')).to eq({})
           expect_proxmox_actions_to_be []
         end