hammer_cli_foreman 2.3.2 → 3.0.0

data/test/functional/template_test.rb

@@ -95,6 +95,18 @@ describe 'template' do
 
       assert_cmd(success_result("Provisioning template updated.\n"), result)
     end
+
+    it 'updates nothing without template related parameters' do
+      params = %w[--id=1 --organization-id=1 --location-id=1]
+
+      api_expects(:template_kinds, :index, 'Get list of template kinds').returns(index_response([]))
+      api_expects(:provisioning_templates, :update, 'Update template with no params').returns({})
+
+      expected_result = success_result("Nothing to update.\n")
+
+      result = run_cmd(@cmd + params)
+      assert_cmd(expected_result, result)
+    end
   end
 
   describe 'create' do
@@ -128,45 +140,13 @@ describe 'template' do
       @cmd = %w(template combination)
     end
 
-    it 'should create new combination with warning' do
-      params = ['create','--provisioning-template-id=10', '--hostgroup-id=1', '--environment-id=1']
-      expected_result = success_result("Template combination created.\n")
-      expected_result.expected_err = "Warning: Option --environment-id is deprecated. Use --puppet-environment[-id] instead\n"
-      api_expects(:template_combinations, :create, 'Create template combination') do |params|
-        params['provisioning_template_id'] == 10 &&
-          params['hostgroup_id'] == 1 &&
-          params['environment_id'] == 1 &&
-          params['template_combination'] == {'environment_id' => 1, 'hostgroup_id' => 1}
-      end
-
-      result = run_cmd(@cmd + params)
-      assert_cmd(expected_result, result)
-    end
-
     it 'should create new combination' do
-      params = ['create','--provisioning-template-id=10', '--hostgroup-id=1', '--puppet-environment-id=1']
+      params = ['create','--provisioning-template-id=10', '--hostgroup-id=1']
       expected_result = success_result("Template combination created.\n")
       api_expects(:template_combinations, :create, 'Create template combination') do |params|
         params['provisioning_template_id'] == 10 &&
           params['hostgroup_id'] == 1 &&
-          params['environment_id'] == 1 &&
-          params['template_combination'] == {'environment_id' => 1, 'hostgroup_id' => 1}
-      end
-
-      result = run_cmd(@cmd + params)
-      assert_cmd(expected_result, result)
-    end
-
-    it 'should update combination with warning' do
-      params = ['update', '--id=3', '--provisioning-template-id=10', '--hostgroup-id=1', '--environment-id=1']
-      expected_result = success_result("Template combination updated.\n")
-      expected_result.expected_err = "Warning: Option --environment-id is deprecated. Use --puppet-environment[-id] instead\n"
-      api_expects(:template_combinations, :update, 'Update template combination') do |params|
-        params['id'] == '3' &&
-          params['provisioning_template_id'] == 10 &&
-          params['hostgroup_id'] == 1 &&
-          params['environment_id'] == 1 &&
-          params['template_combination'] == { 'environment_id' => 1, 'hostgroup_id' => 1 }
+          params['template_combination'] == {'hostgroup_id' => 1}
       end
 
       result = run_cmd(@cmd + params)
@@ -174,14 +154,13 @@ describe 'template' do
     end
 
     it 'should update combination' do
-      params = ['update', '--id=3', '--provisioning-template-id=10', '--hostgroup-id=1', '--puppet-environment-id=1']
+      params = ['update', '--id=3', '--provisioning-template-id=10', '--hostgroup-id=1']
       expected_result = success_result("Template combination updated.\n")
       api_expects(:template_combinations, :update, 'Update template combination') do |params|
         params['id'] == '3' &&
           params['provisioning_template_id'] == 10 &&
           params['hostgroup_id'] == 1 &&
-          params['environment_id'] == 1 &&
-          params['template_combination'] == { 'environment_id' => 1, 'hostgroup_id' => 1 }
+          params['template_combination'] == { 'hostgroup_id' => 1 }
       end
 
       result = run_cmd(@cmd + params)

data/test/functional/user_test.rb

@@ -82,6 +82,17 @@ describe "user" do
       assert_cmd(expected_result, result)
     end
 
+    it 'updates nothing without user related parameters' do
+      params = %w[--id=1]
+
+      api_expects(:users, :update, 'Update user with no params').returns({})
+
+      expected_result = success_result("Nothing to update.\n")
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
     describe "update password" do
       def replace_foreman_connection(connection)
         HammerCLI.context[:api_connection].drop('foreman')

data/test/functional/usergroup_test.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), 'test_helper')
+
+describe 'user-group' do
+  describe 'list' do
+    before do
+      @cmd = %w[user-group list]
+      @user_groups = [{
+                          id: 1,
+                          name: 'test-user-group',
+                          admin: 'yes',
+                        }]
+    end
+
+    it 'should return a list of user groups' do
+      api_expects(:usergroups, :index, 'List user groups').returns(@user_groups)
+
+      output = IndexMatcher.new([
+                                  %w[ID NAME ADMIN],
+                                  %w[1 test-user-group yes]
+                                ])
+      expected_result = success_result(output)
+
+      result = run_cmd(@cmd)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'should run list command with defaults' do
+      providers = { 'foreman' => HammerCLIForeman::Defaults.new(api_connection({}, '2.5')) }
+      defaults = HammerCLI::Defaults.new(
+        {
+          organization_id: {
+            provider: 'foreman'
+          },
+          location_id: {
+            provider: 'foreman'
+          }
+        }
+      )
+      defaults.stubs(:write_to_file).returns(true)
+      defaults.stubs(:providers).returns(providers)
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_organization' => { 'id' => 2 } }]))
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_location' => { 'id' => 1 } }]))
+      api_expects(:usergroups, :index, 'List user groups').returns(@user_groups)
+
+      result = run_cmd(@cmd, { use_defaults: true, defaults: defaults })
+      _(result.exit_code).must_equal HammerCLI::EX_OK
+    end
+  end
+end
+
+

data/test/test_helper.rb

@@ -17,7 +17,7 @@ require "mocha/minitest"
 require 'hammer_cli'
 require 'hammer_cli_foreman/testing/api_expectations'
 
-FOREMAN_VERSION = ENV['TEST_API_VERSION'] || '2.1'
+FOREMAN_VERSION = ENV['TEST_API_VERSION'] || '2.5'
 unless Dir.entries('test/data').include? FOREMAN_VERSION
   raise StandardError.new "Version is not correct"
 end

data/test/unit/apipie_resource_mock.rb

@@ -19,15 +19,6 @@ module ResourceMocks
     end
   end
 
-  def self.smart_class_parameters_index
-    ResourceMocks.mock_action_call(:smart_class_parameters, :index,
-      { "results" => [ { 'parameter' => 'config', 'id' => '1'} ] })
-  end
-
-  def self.smart_class_parameters_show
-    ResourceMocks.mock_action_call(:smart_class_parameters, :show, { 'smart_class_parameter' => { 'override_value_order' => '', 'environments' => [] }})
-  end
-
   def self.smart_variables_index
     ResourceMocks.mock_action_call(:smart_variables, :index,
       { "results" => [ { 'variable' => 'var', 'id' => '1'} ] })
@@ -107,8 +98,6 @@ module ResourceMocks
     ResourceMocks.mock_action_call(:hosts, :show, {
       "ip" => "192.168.122.51",
       "ip6" => nil,
-      "environment_id" => 1,
-      "environment_name" => "production",
       "last_report" => "2016-10-24 12:06:31 UTC",
       "mac" => "52:54:00:ce:b2:b9",
       "realm_id" => nil,
@@ -150,26 +139,11 @@ module ResourceMocks
       "organization_name" => nil,
       "location_id" => nil,
       "location_name" => nil,
-      "puppet_status" => 0,
       "model_name" => "KVM",
       "configuration_status" => 0,
       "configuration_status_label" => "No reports",
       "name" => "foreman.example.com",
       "id" => 1,
-      "puppet_proxy_id" => 1,
-      "puppet_proxy_name" => "foreman.example.com",
-      "puppet_ca_proxy_id" => 1,
-      "puppet_ca_proxy_name" => "foreman.example.com",
-      "puppet_proxy" => {
-        "name" => "foreman.example.com",
-        "id" => 1,
-        "url" => "https://foreman.example.com:9090"
-      },
-      "puppet_ca_proxy" => {
-        "name" => "foreman.example.com",
-        "id" => 1,
-        "url" => "https://foreman.example.com:9090"
-      },
       "hostgroup_name" => nil,
       "hostgroup_title" => nil,
       "parameters" => [],
@@ -193,10 +167,7 @@ module ResourceMocks
         "primary" => false,
         "provision" => false,
         "type" => "interface"
-      }],
-      "puppetclasses" => [],
-      "config_groups" => [],
-      "all_puppetclasses" => []
+      }]
     })
   end
 
@@ -237,6 +208,27 @@ module ResourceMocks
       )
   end
 
+  def self.bookmarks
+    ResourceMocks.mock_action_calls(
+      [:bookmarks, :index, []],
+      [:bookmarks, :show, {}]
+    )
+  end
+
+  def self.mail_notifications
+    ResourceMocks.mock_action_calls(
+      [:mail_notifications, :index, []],
+      [:mail_notifications, :show, {}]
+    )
+  end
+
+  def self.compute_profiles
+    ResourceMocks.mock_action_calls(
+      [:compute_profiles, :index, []],
+      [:compute_profiles, :show, {}]
+    )
+  end
+
   def self.parameters_index
     ResourceMocks.mock_action_call(:parameters, :index, [])
   end
@@ -314,13 +306,4 @@ module ResourceMocks
       "value" => "random value",
     }])
   end
-
-  def self.config_groups_index
-    ResourceMocks.mock_action_call(:config_groups, :index, [{
-      id: 15,
-      name: "test config group",
-      puppetclasses: [ { name: "My puppetclass" } ]
-    }])
-  end
-
 end

data/test/unit/architecture_test.rb

@@ -17,6 +17,8 @@ describe HammerCLIForeman::Architecture do
     context "parameters" do
       it_should_accept "no arguments"
       it_should_accept_search_params
+      it_should_accept 'organization', ['--organization-id=1']
+      it_should_accept 'location', ['--location-id=1']
     end
 
     context "output" do
@@ -37,6 +39,8 @@ describe HammerCLIForeman::Architecture do
     context "parameters" do
       it_should_accept "id", ["--id=1"]
       it_should_accept "name", ["--name=arch"]
+      it_should_accept 'organization', %w[--id=1 --organization-id=1]
+      it_should_accept 'location', %w[--id=1 --location-id=1]
       # it_should_fail_with "no arguments" # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
@@ -57,6 +61,8 @@ describe HammerCLIForeman::Architecture do
 
     context "parameters" do
       it_should_accept "name", ["--name=arch"]
+      it_should_accept 'organization', %w[--name=arch --organization-id=1]
+      it_should_accept 'location', %w[--name=arch --location-id=1]
       # it_should_fail_with "name missing", []
       # TODO: temporarily disabled, parameters are checked in the api
     end
@@ -71,6 +77,8 @@ describe HammerCLIForeman::Architecture do
     context "parameters" do
       it_should_accept "name", ["--name=arch"]
       it_should_accept "id", ["--id=1"]
+      it_should_accept 'organization', %w[--id=1 --organization-id=1]
+      it_should_accept 'location', %w[--id=1 --location-id=1]
       # it_should_fail_with "name or id missing", [] # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
@@ -84,9 +92,10 @@ describe HammerCLIForeman::Architecture do
     context "parameters" do
       it_should_accept "name", ["--name=arch", "--new-name=arch2"]
       it_should_accept "id", ["--id=1", "--new-name=arch2"]
+      it_should_accept 'organization', %w[--id=1 --new-name=arch2 --organization-id=1]
+      it_should_accept 'location', %w[--id=1 --new-name=arch2 --location-id=1]
       # it_should_fail_with "no params", [] # TODO: temporarily disabled, parameters are checked in the id resolver
       # it_should_fail_with "name or id missing", ["--new-name=arch2"] # TODO: temporarily disabled, parameters are checked in the id resolver
     end
-
   end
 end

data/test/unit/bookmark_test.rb

@@ -0,0 +1,95 @@
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), 'test_helper')
+require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
+
+require 'hammer_cli_foreman/bookmark'
+
+describe HammerCLIForeman::Bookmark do
+  include CommandTestHelper
+
+  context 'ListCommand' do
+    before :each do
+      ResourceMocks.bookmarks
+    end
+
+    let(:cmd) { HammerCLIForeman::Bookmark::ListCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'no arguments'
+      it_should_accept 'organization', ['--organization-id=1']
+      it_should_accept 'location', ['--location-id=1']
+    end
+
+    context 'output' do
+      let(:expected_record_count) { count_records(cmd.resource.call(:index)) }
+
+      it_should_print_n_records
+      it_should_print_column 'Id'
+      it_should_print_column 'Name'
+      it_should_print_column 'Controller'
+      it_should_print_column 'Search Query'
+      it_should_print_column 'Public'
+      it_should_print_column 'Owner Id'
+      it_should_print_column 'Owner Type'
+    end
+  end
+
+  context 'InfoCommand' do
+    let(:cmd) { HammerCLIForeman::Bookmark::InfoCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=active']
+      it_should_accept 'organization', %w[--id=1 --organization-id=1]
+      it_should_accept 'location', %w[--id=1 --location-id=1]
+    end
+
+    context 'output' do
+      with_params ['--id=1'] do
+        it_should_print_n_records 1
+        it_should_print_column 'Id'
+        it_should_print_column 'Name'
+        it_should_print_column 'Controller'
+        it_should_print_column 'Search Query'
+        it_should_print_column 'Public'
+        it_should_print_column 'Owner Id'
+        it_should_print_column 'Owner Type'
+      end
+    end
+  end
+
+  context 'CreateCommand' do
+    let(:cmd) { HammerCLIForeman::Bookmark::CreateCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'name, public, controller, query, organization, location',
+                       ['--name=active', '--public=1', '--controller=hosts', '--organization-id=1', '--location-id=1',
+                        '--query=last_report > "35 minutes ago" and (status.applied > 0 or status.restarted > 0)']
+    end
+
+  end
+
+  context 'DeleteCommand' do
+    let(:cmd) { HammerCLIForeman::Bookmark::DeleteCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=active']
+      it_should_accept 'organization', %w[--id=1 --organization-id=1]
+      it_should_accept 'location', %w[--id=1 --location-id=1]
+    end
+  end
+
+  context 'UpdateCommand' do
+    let(:cmd) { HammerCLIForeman::Bookmark::UpdateCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=active']
+      it_should_accept 'name, public, controller, query, organization, location',
+                       ['--name=active', '--public=1', '--controller=hosts', '--organization-id=1', '--location-id=1',
+                        '--query=last_report > "35 minutes ago" and (status.applied > 0 or status.restarted > 0)']
+    end
+  end
+end

data/test/unit/compute_profile_test.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), 'test_helper')
+require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
+
+require 'hammer_cli_foreman/compute_profile'
+
+describe HammerCLIForeman::ComputeProfile do
+  include CommandTestHelper
+
+  context 'ListCommand' do
+    before :each do
+      ResourceMocks.compute_profiles
+    end
+
+    let(:cmd) { HammerCLIForeman::ComputeProfile::ListCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'no arguments'
+      it_should_accept 'organization', ['--organization-id=1']
+      it_should_accept 'location', ['--location-id=1']
+    end
+
+    context 'output' do
+      let(:expected_record_count) { count_records(cmd.resource.call(:index)) }
+
+      it_should_print_n_records
+      it_should_print_column 'Id'
+      it_should_print_column 'Name'
+    end
+  end
+
+  context 'InfoCommand' do
+    let(:cmd) { HammerCLIForeman::ComputeProfile::InfoCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=test']
+      it_should_accept 'organization', %w[--id=1 --organization-id=1]
+      it_should_accept 'location', %w[--id=1 --location-id=1]
+    end
+
+    context 'output' do
+      with_params ['--id=1'] do
+        it_should_print_n_records 1
+        it_should_print_column 'Id'
+        it_should_print_column 'Name'
+        it_should_print_column 'Created at'
+        it_should_print_column 'Updated at'
+        it_should_print_column 'Compute attributes'
+      end
+    end
+  end
+
+  context 'CreateCommand' do
+    let(:cmd) { HammerCLIForeman::ComputeProfile::CreateCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'name', ['--name=test']
+      it_should_accept 'organization', %w[--name=test --organization-id=1]
+      it_should_accept 'location', %w[--name=test --location-id=1]
+    end
+
+  end
+
+  context 'DeleteCommand' do
+    let(:cmd) { HammerCLIForeman::ComputeProfile::DeleteCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=test']
+      it_should_accept 'organization', %w[--id=1 --organization-id=1]
+      it_should_accept 'location', %w[--id=1 --location-id=1]
+    end
+  end
+
+  context 'UpdateCommand' do
+    let(:cmd) { HammerCLIForeman::ComputeProfile::UpdateCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=test']
+      it_should_accept 'organization', %w[--id=1 --organization-id=1]
+      it_should_accept 'location', %w[--id=1 --location-id=1]
+    end
+  end
+end