hammer_cli_foreman 2.3.2 → 3.0.0

data/test/functional/filter_test.rb

@@ -1,18 +1,21 @@
+# frozen_string_literal: true
+
 require File.join(File.dirname(__FILE__), 'test_helper')
 
 describe 'filter' do
   def api_expects_filter_info(options)
     override = !!options[:override]
-    api_expects(:filters, :show, 'Get filter info').with_params({
-      :id => '1'
-    }).returns(@filter.merge('override?' => override))
+    api_expects(:filters, :show, 'Get filter info').with_params(
+      id: '1'
+    ).returns(@filter.merge('override?' => override))
   end
 
   def taxonomy_usage_error(action, cmd)
     usage_error_result(
       cmd,
       'Organizations and locations can be set only for overriding filters.',
-      "Could not #{action} the permission filter")
+      "Could not #{action} the permission filter"
+    )
   end
 
   def assert_update_success(result)
@@ -21,7 +24,7 @@ describe 'filter' do
 
   describe 'create' do
     before do
-      @cmd = %w(filter create)
+      @cmd = %w[filter create]
     end
 
     it 'prints error when taxonomies are used for a not-overriding filter' do
@@ -32,41 +35,106 @@ describe 'filter' do
       result = run_cmd(@cmd + params)
       assert_cmd(taxonomy_usage_error('create', @cmd), result)
     end
+
+    it 'should create a filter' do
+      params = ['--role-id=1', '--permission-ids=[1]']
+
+      api_expects(:filters, :create) do |params|
+        (params['filter']['role_id'] == 1)
+        (params['filter']['permission_ids'] == [1])
+      end
+
+      result = run_cmd(@cmd + params)
+      assert_cmd(success_result("Permission filter for [%<resource_type_label>s] created.\n"), result)
+    end
+  end
+
+  describe 'list' do
+    before do
+      @cmd = %w[filter list]
+      @filters = [{
+        id: 1,
+        resource_type: 'Architecture',
+        search: 'none',
+        unlimited?: true,
+        override?: false,
+        role: { name: 'Manager', id: 2, description: 'Role granting all available permissions.', origin: 'foreman' },
+        permissions: 'view_architectures'
+      }]
+    end
+
+    it 'should return a list of filters' do
+      api_expects(:filters, :index, 'List filters').returns(@filters)
+
+      output = IndexMatcher.new([
+                                  ['ID', 'RESOURCE TYPE', 'SEARCH', 'UNLIMITED?', 'OVERRIDE?', 'ROLE', 'PERMISSIONS'],
+                                  ['1', 'Architecture', 'none', 'yes', 'no', 'Manager', 'view_architectures']
+                                ])
+      expected_result = success_result(output)
+
+      result = run_cmd(@cmd)
+      assert_cmd(expected_result, result)
+    end
+  end
+
+  describe 'delete' do
+    before do
+      @cmd = %w(filter delete)
+    end
+
+    it 'should print error missing argument id' do
+      expected_result = "Could not delete the permission filter:\n  Missing arguments for '--id'.\n"
+
+      api_expects_no_call
+
+      result = run_cmd(@cmd)
+      assert_match(expected_result, result.err)
+    end
+
+    it 'should delete a filter' do
+      params = ['--id=1']
+
+      api_expects(:filters, :destroy, 'Delete a filter').with_params(id: '1')
+
+      result = run_cmd(@cmd + params)
+      assert_cmd(success_result("Permission filter deleted.\n"), result)
+    end
   end
 
   describe 'update' do
     before do
-      @cmd = %w(filter update)
+      @cmd = %w[filter update]
       @filter = {
-        "search" => nil,
-        "resource_type" => "User",
-        "unlimited?" => false,
-        "created_at" => "2017-07-18 14:34:09 UTC",
-        "updated_at" => "2017-07-18 14:34:09 UTC",
-        "override?" => true,
-        "id" => 404,
-        "role" => {
-          "name" => "Some Role",
-          "id" => 28,
-          "description" => "Description\nof the new\nrole",
-          "origin" => nil
+        'search' => nil,
+        'resource_type_label' => 'User',
+        'resource_type' => 'User',
+        'unlimited?' => false,
+        'created_at' => '2017-07-18 14:34:09 UTC',
+        'updated_at' => '2017-07-18 14:34:09 UTC',
+        'override?' => true,
+        'id' => 404,
+        'role' => {
+          'name' => 'Some Role',
+          'id' => 28,
+          'description' => "Description\nof the new\nrole",
+          'origin' => nil
         },
-        "permissions" => [{
-            "name" => "view_users",
-            "id" => 164,
-            "resource_type" => "User"
+        'permissions' => [{
+          'name' => 'view_users',
+          'id' => 164,
+          'resource_type' => 'User'
         }],
-        "locations" => [{
-          "id" => 28,
-          "name" => "location74",
-          "title" => "location74",
-          "description" => nil
+        'locations' => [{
+          'id' => 28,
+          'name' => 'location74',
+          'title' => 'location74',
+          'description' => nil
         }],
-        "organizations" => [{
-          "id" => 27,
-          "name" => "organization74",
-          "title" => "organization74",
-          "description" => nil
+        'organizations' => [{
+          'id' => 27,
+          'name' => 'organization74',
+          'title' => 'organization74',
+          'description' => nil
         }]
       }
     end
@@ -74,13 +142,13 @@ describe 'filter' do
     it 'resets taxonomies when a filter is not-overriding' do
       params = ['--id=1']
 
-      api_expects_filter_info(:override => false)
-      api_expects(:filters, :update, 'Update the filter').with_params({
+      api_expects_filter_info(override: false)
+      api_expects(:filters, :update, 'Update the filter').with_params(
         'filter' => {
           'organization_ids' => [],
           'location_ids' => []
         }
-      }).returns(@filter)
+      ).returns(@filter)
 
       assert_update_success(run_cmd(@cmd + params))
     end
@@ -88,12 +156,12 @@ describe 'filter' do
     it 'resets taxonomies when switching a filter to not-overriding' do
       params = ['--id=1', '--override=false']
 
-      api_expects(:filters, :update, 'Update the filter').with_params({
+      api_expects(:filters, :update, 'Update the filter').with_params(
         'filter' => {
           'organization_ids' => [],
           'location_ids' => []
         }
-      }).returns(@filter)
+      ).returns(@filter)
 
       assert_update_success(run_cmd(@cmd + params))
     end
@@ -101,13 +169,13 @@ describe 'filter' do
     it 'can add taxonomies when a filter is overriding' do
       params = ['--id=1', '--organization-ids=1,2', '--location-ids=3,4']
 
-      api_expects_filter_info(:override => true)
-      api_expects(:filters, :update, 'Update the filter').with_params({
+      api_expects_filter_info(override: true)
+      api_expects(:filters, :update, 'Update the filter').with_params(
         'filter' => {
-          'organization_ids' => ['1', '2'],
-          'location_ids' => ['3', '4']
+          'organization_ids' => %w[1 2],
+          'location_ids' => %w[3 4]
         }
-      }).returns(@filter)
+      ).returns(@filter)
 
       assert_update_success(run_cmd(@cmd + params))
     end
@@ -115,12 +183,12 @@ describe 'filter' do
     it 'can add taxonomies when switching a filter to overriding' do
       params = ['--id=1', '--organization-ids=1,2', '--location-ids=3,4', '--override=true']
 
-      api_expects(:filters, :update, 'Update the filter').with_params({
+      api_expects(:filters, :update, 'Update the filter').with_params(
         'filter' => {
-          'organization_ids' => ['1', '2'],
-          'location_ids' => ['3', '4']
+          'organization_ids' => %w[1 2],
+          'location_ids' => %w[3 4]
         }
-      }).returns(@filter)
+      ).returns(@filter)
 
       assert_update_success(run_cmd(@cmd + params))
     end
@@ -128,7 +196,7 @@ describe 'filter' do
     it 'prints error when taxonomies are used on not-overriding' do
       params = ['--id=1', '--organization-ids=1,2', '--location-ids=3,4']
 
-      api_expects_filter_info(:override => false)
+      api_expects_filter_info(override: false)
 
       result = run_cmd(@cmd + params)
       assert_cmd(taxonomy_usage_error('update', @cmd), result)

data/test/functional/host_test.rb

@@ -297,6 +297,54 @@ describe "host create" do
       assert_cmd(expected_result, result)
   end
 
+  it 'should create a host with an owner' do
+    params = ['--owner-id=1']
+
+    api_expects(:hosts, :create, 'Create a host with an owner').with_params(
+      'location_id' => 1, 'organization_id' => 1, 'host' => {
+        'owner_id' => '1', 'name' => 'test'
+      }
+    ).returns(results: { 'owner_id' => '1', 'name' => 'test' })
+
+    expected_result = success_result("Host created.\n")
+
+    result = run_cmd(cmd + minimal_params_without_hostgroup + params)
+
+    assert_cmd(expected_result, result)
+  end
+
+  it 'should create a host and set owner-type' do
+    params = ['--owner=admin']
+
+    api_expects_search(:users, {login: 'admin'}).returns(index_response([{ 'id' => 1 }]))
+
+    api_expects(:hosts, :create, 'Create a host with an owner').with_params(
+      'location_id' => 1, 'organization_id' => 1, 'host' => {
+        'owner_id' => 1, 'name' => 'test'
+      }
+    ).returns(results: { 'owner' => 'admin', 'name' => 'test' })
+
+    expected_result = success_result("Host created.\n")
+
+    result = run_cmd(cmd + minimal_params_without_hostgroup + params)
+
+    assert_cmd(expected_result, result)
+  end
+
+  it 'should create a host with default owner-type User' do
+
+    api_expects(:hosts, :create, 'Create a host with an owner').with_params(
+      'location_id' => 1, 'organization_id' => 1, 'host' => {
+         'name' => 'test'
+      }
+    ).returns(results: { 'owner_type' => 'User', 'name' => 'test' })
+
+    expected_result = success_result("Host created.\n")
+
+    result = run_cmd(cmd + minimal_params_without_hostgroup)
+
+    assert_cmd(expected_result, result)
+  end
 end
 
 describe 'host update' do
@@ -308,7 +356,6 @@ describe 'host update' do
       'organization_id' => '5',
       'location_id' => '5',
       'compute_attributes' => {},
-      'puppetclass_ids' => [],
       'owner_id' => '1',
       'owner_name' => 'adminGroup',
       'owner_type' => 'Usergroup'
@@ -356,7 +403,7 @@ describe 'host update' do
   it 'updates nothing without host related parameters' do
     api_expects(:hosts, :update, 'Update host with no host params').returns({})
 
-    expected_result = success_result("Host updated.\n")
+    expected_result = success_result("Nothing to update.\n")
 
     result = run_cmd(cmd + minimal_params)
     assert_cmd(expected_result, result)
@@ -410,7 +457,25 @@ describe 'host update' do
     )
     api_expects(:hosts, :update, 'Update host with new owner').with_params(
         'id' => '1', 'location_id' => 1, 'organization_id' => 1, 'host' => {
-        'owner_id' => '1' }
+          'owner_id' => '1' }
+    ) do |par|
+      par['id'] == '1' && par['host']['owner_id'] == '1'
+    end.returns(updated_host)
+
+    expected_result = success_result("Host updated.\n")
+
+    result = run_cmd(cmd + minimal_params + params)
+
+    assert_cmd(expected_result, result)
+  end
+
+  it 'should update the host owner with id' do
+    params = ['--owner-id=1']
+
+    api_expects(:hosts, :update, 'Update host with new owner').with_params(
+      'id' => '1', 'location_id' => 1, 'organization_id' => 1, 'host' => {
+        'owner_id' => '1'
+      }
     ) do |par|
       par['id'] == '1' && par['host']['owner_id'] == '1'
     end.returns(updated_host)
@@ -426,7 +491,7 @@ end
 describe 'host config reports' do
   let(:report15) do
     {
-        "id" => 15,
+      "id" => 15,
         "host_id" => 1,
         "host_name" => "host.example.com",
         "reported_at" => "2017-11-13 03:04:53 UTC",
@@ -503,16 +568,32 @@ describe 'disassociate host from vm' do
   end
 end
 
-describe 'run puppetrun for host' do
-  let(:cmd) { ['host', 'puppetrun'] }
-  let(:params) { ['--id=1'] }
 
-  it "does nothing for puppetrun" do
-    expected_result = CommandExpectation.new
-    expected_result.expected_err = "The puppetrun feature has been removed, however you can use the Remote Execution Plugin to run Puppet commands\n"
-    expected_result.expected_exit_code = HammerCLI::EX_SOFTWARE
 
-    result = run_cmd(cmd)
-    assert_cmd(expected_result, result)
+describe 'list' do
+  before do
+    @cmd = %w[host list]
+  end
+
+  it 'should run list command with defaults' do
+    providers = { 'foreman' => HammerCLIForeman::Defaults.new(api_connection({}, '2.1')) }
+    defaults = HammerCLI::Defaults.new(
+      {
+        organization_id: {
+          provider: 'foreman'
+        },
+        location_id: {
+          provider: 'foreman'
+        }
+      }
+    )
+    defaults.stubs(:write_to_file).returns(true)
+    defaults.stubs(:providers).returns(providers)
+    api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_organization' => { 'id' => 2 } }]))
+    api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_location' => { 'id' => 1 } }]))
+    api_expects(:hosts, :index, 'List hosts').returns(index_response([{ 'id' => '42' }]))
+
+    result = run_cmd(@cmd, { use_defaults: true, defaults: defaults })
+    _(result.exit_code).must_equal HammerCLI::EX_OK
   end
 end

data/test/functional/hostgroup/create_test.rb

@@ -68,25 +68,6 @@ module HammerCLIForeman
         run_cmd(%w(hostgroup create --name hg1 --domain d1))
       end
 
-      it 'allows environment id' do
-        api_expects(:hostgroups, :create) do |p|
-          p['hostgroup']['environment_id'] == 1 &&
-            p['hostgroup']['name'] == 'hg1'
-        end
-        run_cmd(%w(hostgroup create --name hg1 --environment-id 1))
-      end
-
-      it 'allows environment name' do
-        api_expects(:environments, :index) do |p|
-          p[:search] = "name = \"env1\""
-        end.returns(index_response([{'id' => 1}]))
-        api_expects(:hostgroups, :create) do |p|
-          p['hostgroup']['environment_id'] == 1 &&
-            p['hostgroup']['name'] == 'hg1'
-        end
-        run_cmd(%w(hostgroup create --name hg1 --environment env1))
-      end
-
       it 'allows location ids' do
         api_expects(:hostgroups, :create) do |p|
           p['hostgroup']['location_ids'] == ['1','4'] &&
@@ -203,104 +184,6 @@ module HammerCLIForeman
         run_cmd(%w(hostgroup create --name hg1 --partition-table pt1))
       end
 
-      it 'allows puppet ca proxy id' do
-        api_expects(:hostgroups, :create).with_params({
-          :hostgroup => {
-            :name => 'hg1',
-            :puppet_ca_proxy_id => 1
-          }
-        })
-        run_cmd(%w(hostgroup create --name hg1 --puppet-ca-proxy-id 1))
-      end
-
-      it 'allows puppet ca proxy name' do
-        api_expects(:smart_proxies, :index) do |p|
-          p[:search] = "name = \"sp1\""
-        end.returns(index_response([{'id' => 1}]))
-        api_expects(:hostgroups, :create) do |p|
-          p['hostgroup']['puppet_ca_proxy_id'] == 1 &&
-            p['hostgroup']['name'] == 'hg1'
-        end
-        run_cmd(%w(hostgroup create --name hg1 --puppet-ca-proxy sp1))
-      end
-
-      it 'allows puppet class ids' do
-        api_expects(:hostgroups, :create) do |p|
-          p['hostgroup']['puppetclass_ids'] == ['1','2'] &&
-            p['hostgroup']['name'] == 'hg1'
-        end
-        run_cmd(%w(hostgroup create --name hg1 --puppet-class-ids 1,2))
-      end
-
-      it 'allows puppet class names' do
-        api_expects(:puppetclasses, :index) do |p|
-          p[:search] = "name = \"pc1\" or name = \"pc2\""
-        end.returns(index_response('puppetclasses' => [
-          {'id' => 1, 'name' => 'pc1'},
-          {'id' => 2, 'name' => 'pc2'}
-        ]))
-        api_expects(:hostgroups, :create) do |p|
-          p['hostgroup']['puppetclass_ids'] == [1,2] &&
-            p['hostgroup']['name'] == 'hg1'
-        end
-        run_cmd(%w(hostgroup create --name hg1 --puppet-classes pc1,pc2))
-      end
-
-      it 'allows puppet class names that exceeds entries_per_page' do
-        search_objects = []
-        response_objects = []
-        ids = []
-        names = []
-        1100.times.with_object('pc').each do |id, name|
-          next_name = "\"#{name}#{id}\""
-          search_objects << "name = #{next_name}"
-          response_objects << { 'id' => id, 'name' => next_name }
-          ids << id
-          names << next_name
-        end
-
-        api_expects(:puppetclasses, :index) do |p|
-          p[:search] == search_objects.join(' or ') &&
-            p[:page].to_i == 1 &&
-            p[:per_page].to_i == HammerCLIForeman::IdResolver::ALL_PER_PAGE
-        end.returns(
-          index_response('puppetclasses' => response_objects[0...1000]))
-
-        api_expects(:puppetclasses, :index) do |p|
-          p[:search] == search_objects.join(' or ') &&
-            p[:page].to_i == 2 &&
-            p[:per_page].to_i == HammerCLIForeman::IdResolver::ALL_PER_PAGE
-        end.returns(index_response('puppetclasses' => response_objects[1000...1100]))
-
-        api_expects(:hostgroups, :create) do |p|
-          p['hostgroup']['name'] == 'hg1' &&
-            p['hostgroup']['puppetclass_ids'] == ids
-        end
-
-        run_cmd(%w[hostgroup create --name hg1 --puppet-classes] << names.join(',').tr('"', ''))
-      end
-
-      it 'allows puppet proxy id' do
-        api_expects(:hostgroups, :create).with_params({
-          :hostgroup => {
-            :name => 'hg1',
-            :puppet_proxy_id => 1
-          }
-        })
-        run_cmd(%w(hostgroup create --name hg1 --puppet-proxy-id 1))
-      end
-
-      it 'allows puppet proxy name' do
-        api_expects(:smart_proxies, :index) do |p|
-          p[:search] = "name = \"sp1\""
-        end.returns(index_response([{'id' => 1}]))
-        api_expects(:hostgroups, :create) do |p|
-          p['hostgroup']['puppet_proxy_id'] == 1 &&
-            p['hostgroup']['name'] == 'hg1'
-        end
-        run_cmd(%w(hostgroup create --name hg1 --puppet-proxy sp1))
-      end
-
       it 'allows realm id' do
         api_expects(:hostgroups, :create) do |p|
           p['hostgroup']['realm_id'] == 1 &&