hammer_cli_foreman 2.3.2 → 3.0.0

data/test/functional/hostgroup/update_test.rb

@@ -68,25 +68,6 @@ module HammerCLIForeman
         run_cmd(%w(hostgroup update --id 1 --domain d1))
       end
 
-      it 'allows environment id' do
-        api_expects(:hostgroups, :update) do |p|
-          p['hostgroup']['environment_id'] == 1 &&
-            p['id'] == '1'
-        end
-        run_cmd(%w(hostgroup update --id 1 --environment-id 1))
-      end
-
-      it 'allows environment name' do
-        api_expects(:environments, :index) do |p|
-          p[:search] = "name = \"env1\""
-        end.returns(index_response([{'id' => 1}]))
-        api_expects(:hostgroups, :update) do |p|
-          p['hostgroup']['environment_id'] == 1 &&
-            p['id'] == '1'
-        end
-        run_cmd(%w(hostgroup update --id 1 --environment env1))
-      end
-
       it 'allows location ids' do
         api_expects(:hostgroups, :update) do |p|
           p['hostgroup']['location_ids'] == ['1','4'] &&
@@ -201,66 +182,6 @@ module HammerCLIForeman
         run_cmd(%w(hostgroup update --id 1 --partition-table pt1))
       end
 
-      it 'allows puppet ca proxy id' do
-        api_expects(:hostgroups, :update).with_params({
-          :id => '1',
-          :hostgroup => { :puppet_ca_proxy_id => 1 }
-        })
-        run_cmd(%w(hostgroup update --id 1 --puppet-ca-proxy-id 1))
-      end
-
-      it 'allows puppet ca proxy name' do
-        api_expects(:smart_proxies, :index) do |p|
-          p[:search] = "name = \"sp1\""
-        end.returns(index_response([{'id' => 1}]))
-        api_expects(:hostgroups, :update) do |p|
-          p['hostgroup']['puppet_ca_proxy_id'] == 1 &&
-            p['id'] == '1'
-        end
-        run_cmd(%w(hostgroup update --id 1 --puppet-ca-proxy sp1))
-      end
-
-      it 'allows puppet class ids' do
-        api_expects(:hostgroups, :update) do |p|
-          p['hostgroup']['puppetclass_ids'] == ['1','2'] &&
-            p['id'] == '1'
-        end
-        run_cmd(%w(hostgroup update --id 1 --puppet-class-ids 1,2))
-      end
-
-      it 'allows puppet class names' do
-        api_expects(:puppetclasses, :index) do |p|
-          p[:search] = "name = \"pc1\" or name = \"pc2\""
-        end.returns(index_response('puppetclasses' => [
-          {'id' => 1, 'name' => 'pc1'},
-          {'id' => 2, 'name' => 'pc2'}
-        ]))
-        api_expects(:hostgroups, :update) do |p|
-          p['hostgroup']['puppetclass_ids'] == [1,2] &&
-            p['id'] == '1'
-        end
-        run_cmd(%w(hostgroup update --id 1 --puppet-classes pc1,pc2))
-      end
-
-      it 'allows puppet proxy id' do
-        api_expects(:hostgroups, :update).with_params({
-          :id => '1',
-          :hostgroup => { :puppet_proxy_id => 1 }
-        })
-        run_cmd(%w(hostgroup update --id 1 --puppet-proxy-id 1))
-      end
-
-      it 'allows puppet proxy name' do
-        api_expects(:smart_proxies, :index) do |p|
-          p[:search] = "name = \"sp1\""
-        end.returns(index_response([{'id' => 1}]))
-        api_expects(:hostgroups, :update) do |p|
-          p['hostgroup']['puppet_proxy_id'] == 1 &&
-            p['id'] == '1'
-        end
-        run_cmd(%w(hostgroup update --id 1 --puppet-proxy sp1))
-      end
-
       it 'allows realm id' do
         api_expects(:hostgroups, :update) do |p|
           p['hostgroup']['realm_id'] == 1 &&

data/test/functional/http_proxy_test.rb

@@ -61,9 +61,21 @@ describe 'httpproxy' do
   end
 
   it 'deletes an http proxy' do
+    api_expects(:http_proxies, :destroy, 'Delete proxy').returns(http_proxy)
+
     expected_result = success_result("Http proxy deleted.\n")
 
     result = run_cmd(%w(http-proxy delete --id 1))
     assert_cmd(expected_result, result)
   end
+
+  it 'updates nothing without related parameters' do
+    api_expects(:http_proxies, :update, 'Update proxy with no params').returns({})
+
+    expected_result = success_result("Nothing to update.\n")
+
+    result = run_cmd(%w(http-proxy update --id 1))
+    assert_cmd(expected_result, result)
+  end
+
 end

data/test/functional/location_test.rb

@@ -208,7 +208,6 @@ describe 'info' do
         provisioning_templates: [],
         domains: [],
         realms: [],
-        environments: [],
         hostgroups: [],
         organizations: [],
         parameters: []
@@ -242,8 +241,6 @@ describe 'info' do
                                  '',
                                  'Realms:',
                                  '',
-                                 'Environments:',
-                                 '',
                                  'Hostgroups:',
                                  '',
                                  'Parameters:',
@@ -272,4 +269,17 @@ describe 'update' do
     result = run_cmd(@cmd + params)
     assert_cmd(success_result("Location updated.\n"), result)
   end
+
+  it 'updates nothing without related parameters' do
+    params = %w[--id=1]
+
+    api_expects(:locations, :index)
+    api_expects(:locations, :update, 'Update location with no params').returns({})
+
+    expected_result = success_result("Nothing to update.\n")
+
+    result = run_cmd(@cmd + params)
+    assert_cmd(expected_result, result)
+  end
+
 end

data/test/functional/mail_notification_test.rb

@@ -24,6 +24,28 @@ describe 'mail_notification' do
       result = run_cmd(@cmd)
       assert_cmd(expected_result, result)
     end
+
+    it 'should run list command with defaults' do
+      providers = { 'foreman' => HammerCLIForeman::Defaults.new(api_connection({}, '2.5')) }
+      defaults = HammerCLI::Defaults.new(
+        {
+          organization_id: {
+            provider: 'foreman'
+          },
+          location_id: {
+            provider: 'foreman'
+          }
+        }
+      )
+      defaults.stubs(:write_to_file).returns(true)
+      defaults.stubs(:providers).returns(providers)
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_organization' => { 'id' => 2 } }]))
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_location' => { 'id' => 1 } }]))
+      api_expects(:mail_notifications, :index, 'List mail notifications').returns(@mail_notifications)
+
+      result = run_cmd(@cmd, { use_defaults: true, defaults: defaults })
+      _(result.exit_code).must_equal HammerCLI::EX_OK
+    end
   end
 
   describe 'info' do

data/test/functional/media_test.rb

@@ -126,5 +126,16 @@ describe 'medium' do
       result = run_cmd(@cmd + params)
       assert_cmd(success_result("Installation medium updated.\n"), result)
     end
+
+    it 'updates nothing without medium related parameters' do
+      params = %w[--id=1]
+
+      api_expects(:media, :update, 'Update medium with no params').returns({})
+
+      expected_result = success_result("Nothing to update.\n")
+
+      result = run_cmd(@cmd + params)
+      assert_cmd(expected_result, result)
+    end
   end
 end

data/test/functional/model_test.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), 'test_helper')
+
+describe 'model' do
+  describe 'list' do
+    before do
+      @cmd = %w[model list]
+      @models = [{
+                          id: 1,
+                          name: 'model',
+                        }]
+    end
+
+    it 'should return a list of models' do
+      api_expects(:models, :index, 'List models').returns(@models)
+
+      output = IndexMatcher.new([
+                                  %w[ID NAME],
+                                  %w[1 model]
+                                ])
+      expected_result = success_result(output)
+
+      result = run_cmd(@cmd)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'should run list command with defaults' do
+      providers = { 'foreman' => HammerCLIForeman::Defaults.new(api_connection({}, '2.5')) }
+      defaults = HammerCLI::Defaults.new(
+        {
+          organization_id: {
+            provider: 'foreman'
+          },
+          location_id: {
+            provider: 'foreman'
+          }
+        }
+      )
+      defaults.stubs(:write_to_file).returns(true)
+      defaults.stubs(:providers).returns(providers)
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_organization' => { 'id' => 2 } }]))
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_location' => { 'id' => 1 } }]))
+      api_expects(:models, :index, 'List models').returns(@models)
+
+      result = run_cmd(@cmd, { use_defaults: true, defaults: defaults })
+      _(result.exit_code).must_equal HammerCLI::EX_OK
+    end
+  end
+end
+
+

data/test/functional/operating_system_test.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), 'test_helper')
+
+describe 'operating_system' do
+  describe 'list' do
+    before do
+      @cmd = %w[os list]
+      @operating_system = [{
+                          id: 1,
+                          release_name: 'Redhat 7',
+                          family: 'Redhat',
+                        }]
+    end
+
+    it 'should return a list of operating system' do
+      api_expects(:operatingsystems, :index, 'List operating systems').returns(@operating_system)
+
+      output = IndexMatcher.new([
+                                  ['ID', 'RELEASE NAME', 'FAMILY'],
+                                  ['1', 'Redhat 7', 'Redhat']
+                                ])
+      expected_result = success_result(output)
+
+      result = run_cmd(@cmd)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'should run list command with defaults' do
+      providers = { 'foreman' => HammerCLIForeman::Defaults.new(api_connection({}, '2.5')) }
+      defaults = HammerCLI::Defaults.new(
+        {
+          organization_id: {
+            provider: 'foreman'
+          },
+          location_id: {
+            provider: 'foreman'
+          }
+        }
+      )
+      defaults.stubs(:write_to_file).returns(true)
+      defaults.stubs(:providers).returns(providers)
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_organization' => { 'id' => 2 } }]))
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_location' => { 'id' => 1 } }]))
+      api_expects(:operatingsystems, :index, 'List operating systems').returns(@operating_system)
+
+      result = run_cmd(@cmd, { use_defaults: true, defaults: defaults })
+      _(result.exit_code).must_equal HammerCLI::EX_OK
+    end
+  end
+end
+
+

data/test/functional/ping_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.join(File.dirname(__FILE__), 'test_helper')
 
 describe 'ping' do
@@ -30,5 +32,36 @@ describe 'ping' do
       result = run_cmd(cmd)
       assert_cmd(expected_result, result)
     end
+
+    it 'returns 1 if one of the services failed and shows unrecognized services' do
+      ping_results['results']['new_plugin'] = {
+        'services' => {
+          'first' => {
+            'status' => 'FAIL'
+          },
+          'second' => {
+            'status' => 'ok'
+          }
+        },
+        'status' => 'FAIL'
+      }
+      api_expects(:ping, :ping, 'Ping').returns(ping_results)
+
+      expected_result = CommandExpectation.new
+      expected_result.expected_out = OutputMatcher.new(
+        [
+          'database:',
+          '    Status:          ok',
+          '    Server Response: Duration: 0ms'
+        ]
+      )
+      expected_result.expected_err =
+        ['1 more service(s) failed, but not shown:',
+         'first',
+         ''].join("\n")
+      expected_result.expected_exit_code = 1
+      result = run_cmd(cmd)
+      assert_cmd(expected_result, result)
+    end
   end
 end

data/test/functional/realm_test.rb

@@ -99,5 +99,16 @@ describe 'realm' do
       result = run_cmd(@cmd + params)
       assert_cmd(success_result("Realm [%{name}] updated.\n"), result)
     end
+
+    it 'updates nothing without realm related parameters' do
+      params = %w[--id=1]
+
+      api_expects(:realms, :update, 'Update realm with no params').returns({})
+
+      expected_result = success_result("Nothing to update.\n")
+
+      result = run_cmd(@cmd + params)
+      assert_cmd(expected_result, result)
+    end
   end
 end

data/test/functional/registration_test.rb

@@ -0,0 +1,8 @@
+require File.join(File.dirname(__FILE__), 'test_helper')
+
+describe 'registration_commands' do
+  it 'create' do
+    api_expects(:registration_commands, :create)
+    run_cmd(%w(host-registration generate-command))
+  end
+end

data/test/functional/report_template_test.rb

@@ -195,6 +195,17 @@ describe 'report-template' do
       result = run_cmd(cmd + params)
       assert_cmd(success_result("Report template updated.\n"), result)
     end
+
+    it 'updates nothing without template related parameters' do
+      params = %w[--id=1]
+
+      api_expects(:report_templates, :update, 'Update template with no params').returns({})
+
+      expected_result = success_result("Nothing to update.\n")
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
   end
 
   describe 'dump' do

data/test/functional/settings_test.rb

@@ -31,6 +31,27 @@ describe 'Settings' do
       assert_cmd(expected_result, result)
     end
 
+    it 'should run list command with defaults' do
+      providers = { 'foreman' => HammerCLIForeman::Defaults.new(api_connection({}, '2.5')) }
+      defaults = HammerCLI::Defaults.new(
+        {
+          organization_id: {
+            provider: 'foreman'
+          },
+          location_id: {
+            provider: 'foreman'
+          }
+        }
+      )
+      defaults.stubs(:write_to_file).returns(true)
+      defaults.stubs(:providers).returns(providers)
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_organization' => { 'id' => 2 } }]))
+      api_expects(:users, :index, 'Find user').with_params(search: 'login=admin').returns(index_response([{ 'default_location' => { 'id' => 1 } }]))
+      api_expects(:settings, :index, 'List settings').returns(setting)
+
+      result = run_cmd(@cmd, { use_defaults: true, defaults: defaults })
+      _(result.exit_code).must_equal HammerCLI::EX_OK
+    end
   end
 
   describe 'info' do

data/test/functional/status_test.rb

@@ -1,24 +1,60 @@
 require File.join(File.dirname(__FILE__), 'test_helper')
 
+BASIC_STATUS = {
+  'database' => { 'active' => true, 'duration_ms' => 0 },
+  'version' => '1.24.0-develop',
+  'api' => { 'version' => 'v2' },
+  'plugins' => [],
+  'smart_proxies' => [],
+  'compute_resources' => []
+}
+
+STRING_STATUS = Marshal.load(Marshal.dump(BASIC_STATUS)).merge({
+  'plugins' => [
+    'Foreman plugin: foreman_ansible, 6.0.1, Daniel Lobato Garcia, Ansible integration with Foreman'
+  ]
+})
+
+STRUCTURED_STATUS = Marshal.load(Marshal.dump(BASIC_STATUS)).merge({
+  'plugins' => [
+    {'name': 'foreman_ansible', 'version': '6.0.1'}
+  ]
+})
+
 describe 'status' do
   let(:base_cmd) { %w[status] }
 
   describe 'foreman' do
     let(:cmd) { base_cmd << 'foreman' }
-    let(:status_results) do
-      {
-        'results' => {
-          'foreman' => {
-            'database' => { 'active' => true, 'duration_ms' => 0 },
-            'version' => '1.24.0-develop',
-            'api' => { 'version' => 'v2' },
-            'plugins' => [],
-            'smart_proxies' => [],
-            'compute_resources' => []
-          }
-        }
-      }
+    let(:status_results) { {'results' => {'foreman' => BASIC_STATUS }} }
+
+    it 'checks status of the foreman system' do
+      api_expects(:ping, :statuses, 'Status').returns(status_results)
+
+      output = OutputMatcher.new(
+        [
+          'Version:           1.24.0-develop',
+          'API Version:       v2',
+          'Database:',
+          '    Status:          ok',
+          '    Server Response: Duration: 0ms',
+          'Plugins:',
+          '',
+          'Smart Proxies:',
+          '',
+          'Compute Resources:'
+        ]
+      )
+
+      expected_result = success_result(output)
+      result = run_cmd(cmd)
+      assert_cmd(expected_result, result)
     end
+  end
+
+  describe 'foreman with string plugins' do
+    let(:cmd) { base_cmd << 'foreman' }
+    let(:status_results) { {'results' => {'foreman' => STRING_STATUS }} }
 
     it 'checks status of the foreman system' do
       api_expects(:ping, :statuses, 'Status').returns(status_results)
@@ -31,7 +67,37 @@ describe 'status' do
           '    Status:          ok',
           '    Server Response: Duration: 0ms',
           'Plugins:',
+          ' 1) Name:    foreman_ansible',
+          '    Version: 6.0.1',
+          'Smart Proxies:',
           '',
+          'Compute Resources:'
+        ]
+      )
+
+      expected_result = success_result(output)
+      result = run_cmd(cmd)
+      assert_cmd(expected_result, result)
+    end
+  end
+
+  describe 'foreman with structured plugins' do
+    let(:cmd) { base_cmd << 'foreman' }
+    let(:status_results) { {'results' => {'foreman' => STRUCTURED_STATUS }} }
+
+    it 'checks status of the foreman system' do
+      api_expects(:ping, :statuses, 'Status').returns(status_results)
+
+      output = OutputMatcher.new(
+        [
+          'Version:           1.24.0-develop',
+          'API Version:       v2',
+          'Database:',
+          '    Status:          ok',
+          '    Server Response: Duration: 0ms',
+          'Plugins:',
+          ' 1) Name:    foreman_ansible',
+          '    Version: 6.0.1',
           'Smart Proxies:',
           '',
           'Compute Resources:'