granite-form 0.1.1 → 0.3.0

data/spec/{lib/granite → granite}/form/model/persistence_spec.rb

@@ -11,12 +11,10 @@ describe Granite::Form::Model::Persistence do
   end
 
   specify { expect(model.new).not_to be_persisted }
-  specify { expect(model.new).not_to be_destroyed }
 
   describe '#instantiate' do
     specify { expect(model.instantiate({})).to be_an_instance_of model }
     specify { expect(model.instantiate({})).to be_persisted }
-    specify { expect(model.instantiate({})).not_to be_destroyed }
 
     context do
       subject(:instance) { model.instantiate(name: 'Hello', foo: 'Bar') }

data/spec/{lib/granite → granite}/form/model/primary_spec.rb

@@ -54,7 +54,7 @@ describe Granite::Form::Model::Primary do
         include Granite::Form::Model::Primary
 
         primary_attribute type: Integer
-        attribute :name
+        attribute :name, Object
       end
     end
 

data/spec/{lib/granite → granite}/form/model/validations/associated_spec.rb

@@ -3,8 +3,7 @@ require 'spec_helper'
 describe Granite::Form::Model::Validations::AssociatedValidator do
   before do
     stub_model(:validated_assoc) do
-      include Granite::Form::Model
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Persistence
 
       attribute :name, String
 
@@ -12,8 +11,7 @@ describe Granite::Form::Model::Validations::AssociatedValidator do
     end
 
     stub_model(:unvalidated_assoc) do
-      include Granite::Form::Model
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Persistence
 
       attribute :name, String
     end

data/spec/{lib/granite → granite}/form/model/validations/nested_spec.rb

@@ -3,8 +3,7 @@ require 'spec_helper'
 describe Granite::Form::Model::Validations::NestedValidator do
   before do
     stub_model(:validated_assoc) do
-      include Granite::Form::Model
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Persistence
       include Granite::Form::Model::Primary
 
       primary :id, Integer
@@ -14,8 +13,7 @@ describe Granite::Form::Model::Validations::NestedValidator do
     end
 
     stub_model(:unvalidated_assoc) do
-      include Granite::Form::Model
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Persistence
 
       attribute :name, String
     end
@@ -114,35 +112,79 @@ describe Granite::Form::Model::Validations::NestedValidator do
 
   context 'object field is invalid and referenced object does not include AutosaveAssociation' do
     before do
-      stub_class(:validated_object) do
-        include Granite::Form::Model::Validations
-        include Granite::Form::Model::Attributes
-        include Granite::Form::Model::Primary
-
-        primary :id
+      stub_model(:validated_object) do
         attribute :title, String
         validates_presence_of :title
       end
 
-      Main.class_eval do
-        include Granite::Form::Model::Associations
+      stub_model(:main) do
+        include Granite::Form::Model::Persistence
+
         attribute :object, Object
         validates :object, nested: true
       end
     end
 
-    subject(:instance) { Main.instantiate name: 'hello', object: object, validated_one: {name: 'name'} }
+    subject(:instance) { Main.instantiate name: 'hello', object: object }
 
-    context do
+    context 'nested object is valid' do
       let(:object) { ValidatedObject.new(title: 'Mr.') }
+
       it { is_expected.to be_valid }
     end
 
-    context do
+    context 'nested object is invalid' do
       let(:object) { ValidatedObject.new }
+
       it do
         expect { subject.valid? }.not_to raise_error
         expect(subject).not_to be_valid
+        expect(subject.errors.count).to eq(1)
+      end
+
+      context 'nested validation runs twice' do
+        before do
+          stub_model(:main) do
+            include Granite::Form::Model::Persistence
+
+            attribute :object, Object
+            validates :object, nested: true
+            validates :object, nested: true
+          end
+        end
+
+        it do
+          subject.validate
+          expect(subject.errors.count).to eq(1)
+        end
+
+        context 'nested object validation has condition' do
+          before do
+            stub_model(:validated_object) do
+              attribute :title, String
+              validates_presence_of :title, if: -> { true }
+            end
+          end
+
+          it do
+            subject.validate
+            expect(subject.errors.count).to eq(1)
+          end
+        end
+
+        context 'nested object validation has message' do
+          before do
+            stub_model(:validated_object) do
+              attribute :title, String
+              validates_presence_of :title, message: 'test'
+            end
+          end
+
+          it do
+            subject.validate
+            expect(subject.errors.count).to eq(1)
+          end
+        end
       end
     end
   end

data/spec/granite/form/types/active_support/time_zone_spec.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::ActiveSupport::TimeZone do
+  describe 'typecasting' do
+    include_context 'type setup', 'ActiveSupport::TimeZone'
+
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast(Object.new)).to be_nil }
+    specify { expect(typecast(Time.now)).to be_nil }
+    specify { expect(typecast('blablabla')).to be_nil }
+    specify { expect(typecast(TZInfo::Timezone.all.first)).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast('Moscow')).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast('+4')).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast('-3')).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast('3600')).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast('-7200')).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast(4)).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast(-3)).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast(3600)).to be_a ActiveSupport::TimeZone }
+    specify { expect(typecast(-7200)).to be_a ActiveSupport::TimeZone }
+  end
+end

data/spec/granite/form/types/array_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::Array do
+  describe 'typecasting' do
+    include_context 'type setup', 'Array'
+
+    specify { expect(typecast([1, 2, 3])).to eq([1, 2, 3]) }
+    specify { expect(typecast('hello, world')).to eq(%w[hello world]) }
+    specify { expect(typecast(10)).to be_nil }
+  end
+end

data/spec/granite/form/types/big_decimal_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::BigDecimal do
+  describe 'typecasting' do
+    include_context 'type setup', 'BigDecimal'
+
+    specify { expect(typecast('hello')).to be_nil }
+    specify { expect(typecast('123hello')).to be_nil }
+    specify { expect(typecast('123')).to eq(BigDecimal('123.0')) }
+    specify { expect(typecast('123.')).to be_nil }
+    specify { expect(typecast('123.5')).to eq(BigDecimal('123.5')) }
+    specify { expect(typecast(123)).to eq(BigDecimal('123.0')) }
+    specify { expect(typecast(123.5)).to eq(BigDecimal('123.5')) }
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast([123.5])).to be_nil }
+  end
+end

data/spec/granite/form/types/boolean_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::Boolean do
+  describe 'typecasting' do
+    include_context 'type setup', 'Boolean'
+
+    specify { expect(typecast('hello')).to be_nil }
+    specify { expect(typecast('true')).to eq(true) }
+    specify { expect(typecast('false')).to eq(false) }
+    specify { expect(typecast('1')).to eq(true) }
+    specify { expect(typecast('0')).to eq(false) }
+    specify { expect(typecast(true)).to eq(true) }
+    specify { expect(typecast(false)).to eq(false) }
+    specify { expect(typecast(1)).to eq(true) }
+    specify { expect(typecast(0)).to eq(false) }
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast([123])).to be_nil }
+  end
+end

data/spec/granite/form/types/date_spec.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::Date do
+  describe 'typecasting' do
+    include_context 'type setup', 'Date'
+    let(:date) { Date.new(2013, 6, 13) }
+
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast('2013-06-13')).to eq(date) }
+    specify { expect(typecast('2013-55-55')).to be_nil }
+    specify { expect(typecast('blablabla')).to be_nil }
+    specify { expect(typecast(DateTime.new(2013, 6, 13, 23, 13))).to eq(date) } # rubocop:disable Style/DateTime
+    specify { expect(typecast(Time.new(2013, 6, 13, 23, 13))).to eq(date) }
+    specify { expect(typecast(Date.new(2013, 6, 13))).to eq(date) }
+  end
+end

data/spec/granite/form/types/date_time_spec.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::DateTime do
+  # rubocop:disable Style/DateTime
+  describe 'typecasting' do
+    include_context 'type setup', 'DateTime'
+    let(:datetime) { DateTime.new(2013, 6, 13, 23, 13) }
+
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast('2013-06-13 23:13')).to eq(datetime) }
+    specify { expect(typecast('2013-55-55 55:55')).to be_nil }
+    specify { expect(typecast('blablabla')).to be_nil }
+    specify { expect(typecast(Date.new(2013, 6, 13))).to eq(DateTime.new(2013, 6, 13, 0, 0)) }
+    specify { expect(typecast(Time.utc(2013, 6, 13, 23, 13).utc)).to eq(datetime) }
+    specify { expect(typecast(DateTime.new(2013, 6, 13, 23, 13))).to eq(datetime) }
+  end
+  # rubocop:enable Style/DateTime
+end

data/spec/granite/form/types/float_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::Float do
+  describe 'typecasting' do
+    include_context 'type setup', 'Float'
+
+    specify { expect(typecast('hello')).to be_nil }
+    specify { expect(typecast('123hello')).to be_nil }
+    specify { expect(typecast('123')).to eq(123.0) }
+    specify { expect(typecast('123.')).to be_nil }
+    specify { expect(typecast('123.5')).to eq(123.5) }
+    specify { expect(typecast(123)).to eq(123.0) }
+    specify { expect(typecast(123.5)).to eq(123.5) }
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast([123.5])).to be_nil }
+  end
+end

data/spec/granite/form/types/hash_with_action_controller_parameters_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::HashWithActionControllerParameters do
+  describe 'typecasting' do
+    include_context 'type setup', 'Hash'
+
+    before(:all) do
+      require 'action_controller'
+      Class.new(ActionController::Base)
+    end
+
+    let(:to_h) { {'x' => {'foo' => 'bar'}, 'y' => 2} }
+    let(:parameters) { ActionController::Parameters.new(to_h) }
+
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast(to_h)).to eq(to_h) }
+    specify { expect(typecast(parameters)).to be_nil }
+    specify { expect(typecast(parameters.permit(:y, x: [:foo]))).to eq(to_h) }
+  end
+end

data/spec/granite/form/types/integer_spec.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::Integer do
+  describe 'typecasting' do
+    include_context 'type setup', 'Integer'
+
+    specify { expect(typecast('hello')).to be_nil }
+    specify { expect(typecast('123hello')).to be_nil }
+    specify { expect(typecast('123')).to eq(123) }
+    specify { expect(typecast('123.5')).to eq(123) }
+    specify { expect(typecast(123)).to eq(123) }
+    specify { expect(typecast(123.5)).to eq(123) }
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast([123])).to be_nil }
+  end
+end

data/spec/granite/form/types/object_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::Object do
+  subject(:type) { described_class.new(String, reflection, model.new) }
+  let(:model) { stub_model }
+  let(:reflection) { Granite::Form::Model::Attributes::Reflections::Base.new(:field) }
+
+  describe '#initialize' do
+    it { is_expected.to have_attributes(type: String, reflection: reflection, owner: an_instance_of(model)) }
+  end
+
+  describe 'typecasting' do
+    before { stub_class(:descendant) }
+
+    context 'with Object type' do
+      include_context 'type setup', 'Object'
+
+      specify { expect(typecast('hello')).to eq('hello') }
+      specify { expect(typecast([])).to eq([]) }
+      specify { expect(typecast(Descendant.new)).to be_a(Descendant) }
+      specify { expect(typecast(Object.new)).to be_a(Object) }
+      specify { expect(typecast(nil)).to be_nil }
+    end
+
+    context 'with Descendant type' do
+      include_context 'type setup', 'Descendant'
+
+      before { stub_class(:descendant2, Descendant) }
+
+      specify { expect(typecast('hello')).to be_nil }
+      specify { expect(typecast([])).to be_nil }
+      specify { expect(typecast(Descendant.new)).to be_a(Descendant) }
+      specify { expect(typecast(Descendant2.new)).to be_a(Descendant2) }
+      specify { expect(typecast(Object.new)).to be_nil }
+      specify { expect(typecast(nil)).to be_nil }
+    end
+  end
+end

data/spec/granite/form/types/string_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::String do
+  describe 'typecasting' do
+    include_context 'type setup', 'String'
+
+    specify { expect(typecast('hello')).to eq('hello') }
+    specify { expect(typecast(123)).to eq('123') }
+    specify { expect(typecast(nil)).to be_nil }
+  end
+end

data/spec/granite/form/types/time_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::Time do
+  # rubocop:disable Style/DateTime
+  describe 'typecasting' do
+    include_context 'type setup', 'Time'
+
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast('2013-06-13 23:13')).to eq('2013-06-13 23:13'.to_time) }
+    specify { expect(typecast('2013-55-55 55:55')).to be_nil }
+    specify { expect(typecast('blablabla')).to be_nil }
+    specify { expect(typecast(Date.new(2013, 6, 13))).to eq(Time.new(2013, 6, 13, 0, 0)) }
+    specify { expect(typecast(DateTime.new(2013, 6, 13, 19, 13))).to eq(DateTime.new(2013, 6, 13, 19, 13).to_time) }
+    specify { expect(typecast(Time.new(2013, 6, 13, 23, 13))).to eq(Time.new(2013, 6, 13, 23, 13)) }
+
+    context 'Time.zone set' do
+      around { |example| Time.use_zone('Bangkok', &example) }
+
+      specify { expect(typecast(nil)).to be_nil }
+      specify { expect(typecast('2013-06-13 23:13')).to eq(Time.zone.parse('2013-06-13 23:13')) }
+      specify { expect(typecast('2013-55-55 55:55')).to be_nil }
+      specify { expect(typecast('blablabla')).to be_nil }
+      specify { expect(typecast(Date.new(2013, 6, 13))).to eq(Time.new(2013, 6, 13, 0, 0)) }
+      specify { expect(typecast(DateTime.new(2013, 6, 13, 19, 13))).to eq(DateTime.new(2013, 6, 13, 19, 13).to_time) }
+      specify { expect(typecast(Time.new(2013, 6, 13, 23, 13))).to eq(Time.new(2013, 6, 13, 23, 13)) }
+    end
+  end
+  # rubocop:enable Style/DateTime
+end

data/spec/granite/form/types/uuid_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::Types::UUID do
+  describe 'typecasting' do
+    include_context 'type setup', 'Granite::Form::UUID'
+    let(:uuid) { Granite::Form::UUID.random_create }
+    let(:uuid_tools) { UUIDTools::UUID.random_create }
+
+    specify { expect(typecast(nil)).to be_nil }
+    specify { expect(typecast(Object.new)).to be_nil }
+    specify { expect(typecast(uuid_tools)).to be_a Granite::Form::UUID }
+    specify { expect(typecast(uuid_tools)).to eq(uuid_tools) }
+    specify { expect(typecast(uuid)).to eq(uuid) }
+    specify { expect(typecast(uuid.to_s)).to eq(uuid) }
+    specify { expect(typecast(uuid.to_i)).to eq(uuid) }
+    specify { expect(typecast(uuid.hexdigest)).to eq(uuid) }
+    specify { expect(typecast(uuid.raw)).to eq(uuid) }
+  end
+end

data/spec/spec_helper.rb

@@ -10,21 +10,6 @@ require 'database_cleaner'
 
 Dir[File.join(__dir__, 'support', '**', '*.rb')].sort.each { |f| require f }
 
-ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
-ActiveRecord::Base.logger = Logger.new('/dev/null')
-
-ActiveRecord::Schema.define do
-  create_table :users do |t|
-    t.column :email, :string
-    t.column :projects, :text
-    t.column :profile, :text
-  end
-
-  create_table :authors do |t|
-    t.column :name, :string
-  end
-end
-
 RSpec.configure do |config|
   config.mock_with :rspec
   config.order = :random

data/spec/support/active_record.rb

@@ -0,0 +1,20 @@
+ActiveRecord::Base.establish_connection(
+  adapter: 'postgresql',
+  database: 'granite',
+  username: 'granite',
+  password: 'granite',
+  host: 'localhost'
+)
+ActiveRecord::Base.logger = Logger.new('/dev/null')
+
+ActiveRecord::Schema.define do
+  create_table :users, force: :cascade do |t|
+    t.column :email, :string
+    t.column :projects, :text
+    t.column :profile, :text
+  end
+
+  create_table :authors, force: :cascade do |t|
+    t.column :name, :string
+  end
+end

data/spec/{shared → support/shared}/nested_attribute_examples.rb

@@ -4,7 +4,7 @@ shared_examples 'nested attributes' do
   before do
     stub_model :project do
       include Granite::Form::Model::Primary
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Associations
 
       primary :slug, String
       attribute :title, String
@@ -12,7 +12,7 @@ shared_examples 'nested attributes' do
 
     stub_model :profile do
       include Granite::Form::Model::Primary
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Associations
 
       primary :identifier
       attribute :first_name, String
@@ -49,14 +49,12 @@ shared_examples 'nested attributes' do
       specify do
         expect do
           user.profile_attributes = {first_name: 'User 1', _destroy: '1'}
-          user.save { true }
         end.not_to change { user.profile.first_name }
       end
       specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'} }.to change { user.profile.first_name }.to('User 1') }
       specify do
         expect do
           user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'}
-          user.save { true }
         end.to change { user.profile.first_name }.to('User 1')
       end
 
@@ -67,14 +65,12 @@ shared_examples 'nested attributes' do
         specify do
           expect do
             user.profile_attributes = {first_name: 'User 1', _destroy: '1'}
-            user.save { true }
           end.not_to change { user.profile.first_name }
         end
-        specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'} }.to change { user.profile.first_name }.to('User 1') }
+        specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'} }.to change { user.profile }.to(nil) }
         specify do
           expect do
             user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'}
-            user.save { true }
           end.to change { user.profile }.to(nil)
         end
       end
@@ -92,8 +88,6 @@ shared_examples 'nested attributes' do
     context 'not primary' do
       before do
         stub_model :profile do
-          include Granite::Form::Model::Lifecycle
-
           attribute :identifier, Integer
           attribute :first_name, String
         end
@@ -245,7 +239,6 @@ shared_examples 'nested attributes' do
             {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
             {title: 'Project 4', _destroy: '1'}
           ]
-          user.save { true }
         end
           .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
       end
@@ -259,16 +252,6 @@ shared_examples 'nested attributes' do
               {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
               {title: 'Project 4', _destroy: '1'}
             ]
-          end
-            .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
-        end
-        specify do
-          expect do
-            user.projects_attributes = [
-              {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
-              {title: 'Project 4', _destroy: '1'}
-            ]
-            user.save { true }
           end
             .to change { user.projects.map(&:title) }.to(['Project 2'])
         end
@@ -303,7 +286,6 @@ shared_examples 'nested attributes' do
       before do
         stub_model :project do
           include Granite::Form::Model::Primary
-          include Granite::Form::Model::Lifecycle
 
           attribute :slug, String
           attribute :title, String

data/spec/support/shared/type_examples.rb

@@ -0,0 +1,7 @@
+shared_context 'type setup' do |type_name|
+  let(:model) { stub_model { attribute :column, type_name.constantize } }
+
+  def typecast(value)
+    model.new(column: value).column
+  end
+end