granite-form 0.1.1 → 0.3.0

data/spec/{lib/granite → granite}/form/model/associations/embeds_one_spec.rb

@@ -3,7 +3,8 @@ require 'spec_helper'
 describe Granite::Form::Model::Associations::EmbedsOne do
   before do
     stub_model(:author) do
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Persistence
+      include Granite::Form::Model::Associations
 
       attribute :name, String
       validates :name, presence: true
@@ -61,12 +62,6 @@ describe Granite::Form::Model::Associations::EmbedsOne do
         ])
     end
 
-    specify do
-      expect { association.create(name: 'Author1') }
-        .to change { book.callbacks }
-        .to([[:before_add, author1], [:after_add, author1]])
-    end
-
     specify do
       expect { association.writer(author1) }
         .to change { book.callbacks }
@@ -118,7 +113,6 @@ describe Granite::Form::Model::Associations::EmbedsOne do
     let(:author) { Author.new(name: 'Author') }
 
     specify { expect(association.build.embedder).to eq(book) }
-    specify { expect(association.create.embedder).to eq(book) }
     specify do
       expect { association.writer(author) }
         .to change { author.embedder }.from(nil).to(book)
@@ -156,7 +150,6 @@ describe Granite::Form::Model::Associations::EmbedsOne do
       end
 
       specify { expect(association.build(name: 'Author').name).to eq('AuthorBook') }
-      specify { expect(association.create(name: 'Author').name).to eq('AuthorBook') }
     end
   end
 
@@ -175,132 +168,6 @@ describe Granite::Form::Model::Associations::EmbedsOne do
     end
   end
 
-  describe '#create' do
-    specify { expect(association.create).to be_a Author }
-    specify { expect(association.create).not_to be_persisted }
-
-    specify { expect(association.create(name: 'Fred')).to be_a Author }
-    specify { expect(association.create(name: 'Fred')).to be_persisted }
-
-    specify do
-      expect { association.create }
-        .not_to change { book.read_attribute(:author) }
-    end
-    specify do
-      expect { association.create(name: 'Fred') }
-        .to change { book.read_attribute(:author) }
-        .from(nil).to('name' => 'Fred')
-    end
-
-    specify do
-      expect { existing_association.create }
-        .not_to change { existing_book.read_attribute(:author) }
-    end
-    specify do
-      expect { existing_association.create(name: 'Fred') }
-        .to change { existing_book.read_attribute(:author) }
-        .from('name' => 'Johny').to('name' => 'Fred')
-    end
-  end
-
-  describe '#create!' do
-    specify { expect { association.create! }.to raise_error Granite::Form::ValidationError }
-    specify do
-      expect { muffle(Granite::Form::ValidationError) { association.create! } }
-        .to change { association.target }
-        .from(nil).to(an_instance_of(Author))
-    end
-
-    specify { expect(association.create!(name: 'Fred')).to be_a Author }
-    specify { expect(association.create!(name: 'Fred')).to be_persisted }
-
-    specify do
-      expect { muffle(Granite::Form::ValidationError) { association.create! } }
-        .not_to change { book.read_attribute(:author) }
-    end
-    specify do
-      expect { muffle(Granite::Form::ValidationError) { association.create! } }
-        .to change { association.reader.try(:attributes) }
-        .from(nil).to('name' => nil)
-    end
-    specify do
-      expect { association.create(name: 'Fred') }
-        .to change { book.read_attribute(:author) }
-        .from(nil).to('name' => 'Fred')
-    end
-
-    specify do
-      expect { muffle(Granite::Form::ValidationError) { existing_association.create! } }
-        .not_to change { existing_book.read_attribute(:author) }
-    end
-    specify do
-      expect { muffle(Granite::Form::ValidationError) { existing_association.create! } }
-        .to change { existing_association.reader.try(:attributes) }
-        .from('name' => 'Johny').to('name' => nil)
-    end
-    specify do
-      expect { existing_association.create!(name: 'Fred') }
-        .to change { existing_book.read_attribute(:author) }
-        .from('name' => 'Johny').to('name' => 'Fred')
-    end
-  end
-
-  describe '#apply_changes' do
-    specify do
-      association.build
-      expect { association.apply_changes }
-        .not_to change { association.target.persisted? }.from(false)
-    end
-    specify do
-      association.build(name: 'Fred')
-      expect { association.apply_changes }
-        .to change { association.target.persisted? }.to(true)
-    end
-    specify do
-      existing_association.target.mark_for_destruction
-      expect { existing_association.apply_changes }
-        .to change { existing_association.target }.to(nil)
-    end
-    specify do
-      existing_association.target.destroy!
-      expect { existing_association.apply_changes }
-        .to change { existing_association.target }.to(nil)
-    end
-    specify do
-      existing_association.target.mark_for_destruction
-      expect { existing_association.apply_changes }
-        .to change { existing_association.destroyed.try(:name) }.from(nil).to('Johny')
-    end
-    specify do
-      existing_association.target.destroy!
-      expect { existing_association.apply_changes }
-        .to change { existing_association.destroyed.try(:name) }.from(nil).to('Johny')
-    end
-  end
-
-  describe '#apply_changes!' do
-    specify do
-      association.build
-      expect { association.apply_changes! }
-        .to raise_error Granite::Form::AssociationChangesNotApplied
-    end
-    specify do
-      association.build(name: 'Fred')
-      expect { association.apply_changes! }
-        .to change { association.target.persisted? }.to(true)
-    end
-    specify do
-      existing_association.target.mark_for_destruction
-      expect { existing_association.apply_changes! }
-        .to change { existing_association.target }.to(nil)
-    end
-    specify do
-      existing_association.target.destroy!
-      expect { existing_association.apply_changes! }
-        .to change { existing_association.target }.to(nil)
-    end
-  end
-
   describe '#target' do
     specify { expect(association.target).to be_nil }
     specify { expect(existing_association.target).to eq(existing_book.author) }
@@ -369,6 +236,31 @@ describe Granite::Form::Model::Associations::EmbedsOne do
     end
   end
 
+  describe '#sync' do
+    let!(:author) { association.build(name: 'Fred') }
+
+    specify { expect { association.sync }.to change { book.read_attribute(:author) }.from(nil).to('name' => 'Fred') }
+
+    context 'when embedding is nested' do
+      before do
+        Author.class_eval do
+          include Granite::Form::Model::Associations
+
+          embeds_many :reviews do
+            attribute :rating, Integer
+          end
+        end
+
+        author.reviews.build(rating: 7)
+      end
+
+      specify do
+        expect { association.sync }.to change { book.read_attribute(:author) }
+          .from(nil).to('name' => 'Fred', 'reviews' => [{'rating' => 7}])
+      end
+    end
+  end
+
   describe '#clear' do
     specify { expect(association.clear).to eq(true) }
     specify { expect { association.clear }.not_to change { association.reader } }
@@ -378,28 +270,6 @@ describe Granite::Form::Model::Associations::EmbedsOne do
       expect { existing_association.clear }
         .to change { existing_association.reader.try(:attributes) }.from('name' => 'Johny').to(nil)
     end
-    specify do
-      expect { existing_association.clear }
-        .to change { existing_book.read_attribute(:author) }.from('name' => 'Johny').to(nil)
-    end
-
-    context do
-      before { Author.send(:include, Granite::Form::Model::Callbacks) }
-      if ActiveModel.version >= Gem::Version.new('5.0.0')
-        before { Author.before_destroy { throw :abort } }
-      else
-        before { Author.before_destroy { false } }
-      end
-      specify { expect(existing_association.clear).to eq(false) }
-      specify do
-        expect { existing_association.clear }
-          .not_to change { existing_association.reader }
-      end
-      specify do
-        expect { existing_association.clear }
-          .not_to change { existing_book.read_attribute(:author).symbolize_keys }
-      end
-    end
   end
 
   describe '#reader' do
@@ -441,23 +311,6 @@ describe Granite::Form::Model::Associations::EmbedsOne do
         expect { association.writer(new_author) }
           .to change { association.reader.try(:attributes) }.from(nil).to('name' => 'Morty')
       end
-      specify do
-        expect { association.writer(new_author) }
-          .to change { book.read_attribute(:author) }.from(nil).to('name' => 'Morty')
-      end
-
-      specify do
-        expect { association.writer(invalid_author) }
-          .to raise_error Granite::Form::AssociationChangesNotApplied
-      end
-      specify do
-        expect { muffle(Granite::Form::AssociationChangesNotApplied) { association.writer(invalid_author) } }
-          .not_to change { association.reader }
-      end
-      specify do
-        expect { muffle(Granite::Form::AssociationChangesNotApplied) { association.writer(invalid_author) } }
-          .not_to change { book.read_attribute(:author) }
-      end
     end
 
     context 'persisted owner' do
@@ -468,32 +321,16 @@ describe Granite::Form::Model::Associations::EmbedsOne do
 
       specify { expect(association.writer(nil)).to be_nil }
       specify { expect(association.writer(new_author)).to eq(new_author) }
-      specify do
-        expect { association.writer(nil) }
-          .not_to change { book.read_attribute(:author) }
-      end
       specify do
         expect { association.writer(new_author) }
           .to change { association.reader.try(:attributes) }.from(nil).to('name' => 'Morty')
       end
-      specify do
-        expect { association.writer(new_author) }
-          .not_to change { book.read_attribute(:author) }
-      end
 
       specify do
         expect { association.writer(invalid_author) }
           .to change { association.reader.try(:attributes) }.from(nil).to('name' => nil)
       end
-      specify do
-        expect { association.writer(invalid_author) }
-          .not_to change { book.read_attribute(:author) }
-      end
 
-      specify do
-        expect { muffle(Granite::Form::AssociationTypeMismatch) { existing_association.writer(stub_model(:dummy).new) } }
-          .not_to change { existing_book.read_attribute(:author) }
-      end
       specify do
         expect { muffle(Granite::Form::AssociationTypeMismatch) { existing_association.writer(stub_model(:dummy).new) } }
           .not_to change { existing_association.reader }
@@ -501,33 +338,11 @@ describe Granite::Form::Model::Associations::EmbedsOne do
 
       specify { expect(existing_association.writer(nil)).to be_nil }
       specify { expect(existing_association.writer(new_author)).to eq(new_author) }
-      specify do
-        expect { existing_association.writer(nil) }
-          .to change { existing_book.read_attribute(:author) }.from('name' => 'Johny').to(nil)
-      end
       specify do
         expect { existing_association.writer(new_author) }
           .to change { existing_association.reader.try(:attributes) }
           .from('name' => 'Johny').to('name' => 'Morty')
       end
-      specify do
-        expect { existing_association.writer(new_author) }
-          .to change { existing_book.read_attribute(:author) }
-          .from('name' => 'Johny').to('name' => 'Morty')
-      end
-
-      specify do
-        expect { existing_association.writer(invalid_author) }
-          .to raise_error Granite::Form::AssociationChangesNotApplied
-      end
-      specify do
-        expect { muffle(Granite::Form::AssociationChangesNotApplied) { existing_association.writer(invalid_author) } }
-          .not_to change { existing_association.reader }
-      end
-      specify do
-        expect { muffle(Granite::Form::AssociationChangesNotApplied) { existing_association.writer(invalid_author) } }
-          .not_to change { existing_book.read_attribute(:author) }
-      end
     end
   end
 end

data/spec/granite/form/model/associations/nested_attributes_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Granite::Form::Model::Associations::NestedAttributes do
+  context '' do
+    before do
+      stub_model :user do
+        include Granite::Form::Model::Associations
+
+        attribute :email, String
+        embeds_one :profile
+        embeds_many :projects
+
+        accepts_nested_attributes_for :profile, :projects
+      end
+    end
+
+    include_examples 'nested attributes'
+  end
+
+  describe '#assign_attributes' do
+    specify 'invent a good example'
+  end
+end

data/spec/granite/form/model/associations/references_many_spec.rb

@@ -0,0 +1,251 @@
+require 'spec_helper'
+
+describe Granite::Form::Model::Associations::ReferencesMany do
+  before do
+    stub_model(:dummy)
+    stub_class(:author, ActiveRecord::Base) do
+      scope :name_starts_with_a, -> { where('name ILIKE "a%"') }
+
+      validates :name, presence: true
+    end
+
+    stub_model(:book) do
+      include Granite::Form::Model::Persistence
+      include Granite::Form::Model::Associations
+
+      attribute :title, String
+      references_many :authors
+    end
+  end
+
+  let(:author) { Author.create!(name: 'Rick') }
+  let(:other) { Author.create!(name: 'Ben') }
+
+  let(:book) { Book.new }
+  let(:association) { book.association(:authors) }
+
+  let(:existing_book) { Book.instantiate title: 'Genesis', author_ids: [author.id] }
+  let(:existing_association) { existing_book.association(:authors) }
+
+  describe 'book#association' do
+    specify { expect(association).to be_a described_class }
+    specify { expect(association).to eq(book.association(:authors)) }
+  end
+
+  describe 'book#inspect' do
+    specify { expect(existing_book.inspect).to eq(<<~STR.chomp) }
+      #<Book authors: #<ReferencesMany [#{author.inspect}]>, title: "Genesis", author_ids: [#{author.id}]>
+    STR
+  end
+
+  describe '#scope' do
+    specify { expect(association.scope).to be_a ActiveRecord::Relation }
+    specify { expect(association.scope).to respond_to(:where) }
+    specify { expect(association.scope).to respond_to(:name_starts_with_a) }
+  end
+
+  describe '#target' do
+    specify { expect(association.target).to eq([]) }
+    specify { expect(existing_association.target).to eq(existing_book.authors) }
+    specify { expect { association.concat author }.to change { association.target.count }.to(1) }
+  end
+
+  describe '#default' do
+    before { Book.references_many :authors, default: ->(_book) { author.id } }
+    let(:existing_book) { Book.instantiate title: 'Genesis' }
+
+    specify { expect(association.target).to eq([author]) }
+    specify { expect { association.replace([other]) }.to change { association.target }.to([other]) }
+    specify { expect { association.replace([]) }.to change { association.target }.to eq([]) }
+
+    specify { expect(existing_association.target).to eq([]) }
+    specify { expect { existing_association.replace([other]) }.to change { existing_association.target }.to([other]) }
+    specify { expect { existing_association.replace([]) }.not_to change { existing_association.target } }
+  end
+
+  describe '#loaded?' do
+    specify { expect(association.loaded?).to eq(false) }
+    specify { expect { association.target }.to change { association.loaded? }.to(true) }
+    specify { expect { association.replace([]) }.to change { association.loaded? }.to(true) }
+    specify { expect { existing_association.replace([]) }.to change { existing_association.loaded? }.to(true) }
+  end
+
+  describe '#reload' do
+    specify { expect(association.reload).to eq([]) }
+
+    specify { expect(existing_association.reload).to eq(existing_book.authors) }
+
+    context do
+      before { existing_association.reader.last.name = 'Conan' }
+      specify do
+        expect { existing_association.reload }
+          .to change { existing_association.reader.map(&:name) }
+          .from(['Conan']).to(['Rick'])
+      end
+    end
+  end
+
+  describe '#reader' do
+    specify { expect(association.reader).to eq([]) }
+    specify { expect(association.reader).to be_a Granite::Form::Model::Associations::PersistenceAdapters::ActiveRecord::ReferencedProxy }
+
+    specify { expect(existing_association.reader.first).to be_a Author }
+    specify { expect(existing_association.reader.first).to be_persisted }
+
+    context do
+      before { association.concat author }
+      specify { expect(association.reader.last).to be_a Author }
+      specify { expect(association.reader.size).to eq(1) }
+      specify { expect(association.reader(true)).to eq([author]) }
+    end
+
+    context do
+      before { existing_association.concat other }
+      specify { expect(existing_association.reader.size).to eq(2) }
+      specify { expect(existing_association.reader.last.name).to eq('Ben') }
+      specify { expect(existing_association.reader(true).size).to eq(2) }
+      specify { expect(existing_association.reader(true).last.name).to eq('Ben') }
+    end
+
+    context 'proxy missing method delection' do
+      specify { expect(existing_association.reader).to respond_to(:where) }
+      specify { expect(existing_association.reader).to respond_to(:name_starts_with_a) }
+    end
+  end
+
+  describe '#writer' do
+    let(:new_author1) { Author.create!(name: 'John') }
+    let(:new_author2) { Author.create!(name: 'Adam') }
+    let(:new_author3) { Author.new(name: 'Jane') }
+
+    specify do
+      expect { association.writer([Dummy.new]) }
+        .to raise_error Granite::Form::AssociationTypeMismatch
+    end
+
+    specify { expect { association.writer(nil) }.to raise_error NoMethodError }
+    specify { expect { association.writer(new_author1) }.to raise_error NoMethodError }
+    specify { expect(association.writer([])).to eq([]) }
+
+    specify { expect(association.writer([new_author1])).to eq([new_author1]) }
+    specify do
+      expect { association.writer([new_author1]) }
+        .to change { association.reader.map(&:name) }.from([]).to(['John'])
+    end
+    specify do
+      expect { association.writer([new_author1]) }
+        .to change { book.read_attribute(:author_ids) }
+        .from([]).to([new_author1.id])
+    end
+
+    specify do
+      expect { existing_association.writer([new_author1, Dummy.new, new_author2]) }
+        .to raise_error Granite::Form::AssociationTypeMismatch
+    end
+    specify do
+      expect { muffle(Granite::Form::AssociationTypeMismatch) { existing_association.writer([new_author1, Dummy.new, new_author2]) } }
+        .not_to change { existing_book.read_attribute(:author_ids) }
+    end
+    specify do
+      expect { muffle(Granite::Form::AssociationTypeMismatch) { existing_association.writer([new_author1, Dummy.new, new_author2]) } }
+        .not_to change { existing_association.reader }
+    end
+
+    specify { expect { existing_association.writer(nil) }.to raise_error NoMethodError }
+    specify do
+      expect { muffle(NoMethodError) { existing_association.writer(nil) } }
+        .not_to change { existing_book.read_attribute(:author_ids) }
+    end
+    specify do
+      expect { muffle(NoMethodError) { existing_association.writer(nil) } }
+        .not_to change { existing_association.reader }
+    end
+
+    specify { expect(existing_association.writer([])).to eq([]) }
+    specify do
+      expect { existing_association.writer([]) }
+        .to change { existing_book.read_attribute(:author_ids) }.to([])
+    end
+    specify do
+      expect { existing_association.writer([]) }
+        .to change { existing_association.reader }.from([author]).to([])
+    end
+
+    specify { expect(existing_association.writer([new_author1, new_author2])).to eq([new_author1, new_author2]) }
+    specify do
+      expect { existing_association.writer([new_author1, new_author2]) }
+        .to change { existing_association.reader.map(&:name) }
+        .from(['Rick']).to(%w[John Adam])
+    end
+    specify do
+      expect { existing_association.writer([new_author1, new_author2]) }
+        .to change { existing_book.read_attribute(:author_ids) }
+        .from([author.id]).to([new_author1.id, new_author2.id])
+    end
+
+    specify do
+      expect { existing_association.writer([new_author3]) }
+        .to change { existing_association.target }.from([author]).to([new_author3])
+    end
+    specify do
+      expect { existing_association.writer([new_author3]) }
+        .to change { existing_book.read_attribute(:author_ids) }
+        .from([author.id]).to([nil])
+    end
+  end
+
+  describe '#concat' do
+    let(:new_author1) { Author.create!(name: 'John') }
+    let(:new_author2) { Author.create!(name: 'Adam') }
+
+    specify do
+      expect { association.concat(Dummy.new) }
+        .to raise_error Granite::Form::AssociationTypeMismatch
+    end
+
+    specify { expect { association.concat(nil) }.to raise_error Granite::Form::AssociationTypeMismatch }
+    specify { expect(association.concat([])).to eq([]) }
+    specify { expect(existing_association.concat([])).to eq(existing_book.authors) }
+    specify { expect(existing_association.concat).to eq(existing_book.authors) }
+
+    specify { expect(association.concat(new_author1)).to eq([new_author1]) }
+    specify do
+      expect { association.concat(new_author1) }
+        .to change { association.reader.map(&:name) }.from([]).to(['John'])
+    end
+    specify do
+      expect { association.concat(new_author1) }
+        .to change { book.read_attribute(:author_ids) }.from([]).to([new_author1.id])
+    end
+
+    specify do
+      expect { existing_association.concat(new_author1, Dummy.new, new_author2) }
+        .to raise_error Granite::Form::AssociationTypeMismatch
+    end
+    specify do
+      expect { muffle(Granite::Form::AssociationTypeMismatch) { existing_association.concat(new_author1, Dummy.new, new_author2) } }
+        .to change { existing_book.read_attribute(:author_ids) }
+        .from([author.id]).to([author.id, new_author1.id])
+    end
+    specify do
+      expect { muffle(Granite::Form::AssociationTypeMismatch) { existing_association.concat(new_author1, Dummy.new, new_author2) } }
+        .to change { existing_association.reader.map(&:name) }
+        .from(['Rick']).to(%w[Rick John])
+    end
+
+    specify do
+      expect(existing_association.concat(new_author1, new_author2))
+        .to eq([author, new_author1, new_author2])
+    end
+    specify do
+      expect { existing_association.concat([new_author1, new_author2]) }
+        .to change { existing_association.reader.map(&:name) }
+        .from(['Rick']).to(%w[Rick John Adam])
+    end
+    specify do
+      expect { existing_association.concat([new_author1, new_author2]) }
+        .to change { existing_book.read_attribute(:author_ids) }
+        .from([author.id]).to([author.id, new_author1.id, new_author2.id])
+    end
+  end
+end