granite-form 0.1.1 → 0.3.0

data/lib/granite/form/types/time.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Granite
+  module Form
+    module Types
+      class Time < Object
+        def typecast(value)
+          value.is_a?(::String) && ::Time.zone ? ::Time.zone.parse(value) : value.try(:to_time)
+        rescue ArgumentError
+          nil
+        end
+      end
+    end
+  end
+end

data/lib/granite/form/types/uuid.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module Granite
+  module Form
+    module Types
+      class UUID < Object
+        def typecast(value)
+          case value
+          when UUIDTools::UUID
+            Granite::Form::UUID.parse_raw value.raw
+          when Granite::Form::UUID
+            value
+          when ::String
+            Granite::Form::UUID.parse_string value
+          when ::Integer
+            Granite::Form::UUID.parse_int value
+          end
+        end
+      end
+    end
+  end
+end

data/lib/granite/form/types.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'granite/form/types/object'
+require 'granite/form/types/array'
+require 'granite/form/types/big_decimal'
+require 'granite/form/types/boolean'
+require 'granite/form/types/date'
+require 'granite/form/types/date_time'
+require 'granite/form/types/hash_with_action_controller_parameters'
+require 'granite/form/types/float'
+require 'granite/form/types/integer'
+require 'granite/form/types/string'
+require 'granite/form/types/time'
+require 'granite/form/types/uuid'
+require 'granite/form/types/active_support/time_zone'

data/lib/granite/form/version.rb

@@ -1,5 +1,5 @@
 module Granite
   module Form
-    VERSION = '0.1.1'.freeze
+    VERSION = '0.3.0'.freeze
   end
 end

data/lib/granite/form.rb

@@ -11,6 +11,7 @@ require 'granite/form/version'
 require 'granite/form/errors'
 require 'granite/form/extensions'
 require 'granite/form/undefined_class'
+require 'granite/form/types'
 require 'granite/form/config'
 require 'granite/form/railtie' if defined? Rails
 require 'granite/form/model'
@@ -19,130 +20,26 @@ require 'granite/form/model/associations/persistence_adapters/active_record'
 
 module Granite
   module Form
-    BOOLEAN_MAPPING = {
-      1 => true,
-      0 => false,
-      '1' => true,
-      '0' => false,
-      't' => true,
-      'f' => false,
-      'T' => true,
-      'F' => false,
-      true => true,
-      false => false,
-      'true' => true,
-      'false' => false,
-      'TRUE' => true,
-      'FALSE' => false,
-      'y' => true,
-      'n' => false,
-      'yes' => true,
-      'no' => false
-    }.freeze
-
     def self.config
       Granite::Form::Config.instance
     end
 
     singleton_class.delegate(*Granite::Form::Config.delegated, to: :config)
 
-    typecaster('Object') { |value, attribute| value if value.class < attribute.type }
-    typecaster('String') { |value, _| value.to_s }
-    typecaster('Array') do |value|
-      case value
-      when ::Array then
-        value
-      when ::String then
-        value.split(',').map(&:strip)
-      end
-    end
-    typecaster('Hash') do |value|
-      case value
-      when ::Hash then
-        value
-      end
-    end
-    ActiveSupport.on_load :action_controller do
-      Granite::Form.typecaster('Hash') do |value|
-        case value
-        when ActionController::Parameters
-          value.to_h if value.permitted?
-        when ::Hash then
-          value
-        end
-      end
-    end
-    typecaster('Date') do |value|
-      begin
-        value.to_date
-      rescue ArgumentError, NoMethodError
-        nil
-      end
-    end
-    typecaster('DateTime') do |value|
-      begin
-        value.to_datetime
-      rescue ArgumentError
-        nil
-      end
-    end
-    typecaster('Time') do |value|
-      begin
-        value.is_a?(String) && ::Time.zone ? ::Time.zone.parse(value) : value.to_time
-      rescue ArgumentError
-        nil
-      end
-    end
-    typecaster('ActiveSupport::TimeZone') do |value|
-      case value
-      when ActiveSupport::TimeZone
-        value
-      when ::TZInfo::Timezone
-        ActiveSupport::TimeZone[value.name]
-      when String, Numeric, ActiveSupport::Duration
-        value = begin
-                  Float(value)
-                rescue ArgumentError, TypeError
-                  value
-                end
-        ActiveSupport::TimeZone[value]
-      end
-    end
-    typecaster('BigDecimal') do |value|
-      next unless value
-      begin
-        BigDecimal(Float(value).to_s)
-      rescue ArgumentError, TypeError
-        nil
-      end
-    end
-    typecaster('Float') do |value|
-      begin
-        Float(value)
-      rescue ArgumentError, TypeError
-        nil
-      end
-    end
-    typecaster('Integer') do |value|
-      begin
-        Float(value).to_i
-      rescue ArgumentError, TypeError
-        nil
-      end
-    end
-    typecaster('Boolean') { |value| BOOLEAN_MAPPING[value] }
-    typecaster('Granite::Form::UUID') do |value|
-      case value
-      when UUIDTools::UUID
-        Granite::Form::UUID.parse_raw value.raw
-      when Granite::Form::UUID
-        value
-      when String
-        Granite::Form::UUID.parse_string value
-      when Integer
-        Granite::Form::UUID.parse_int value
-      end
-    end
+    config.types = {
+      'Object' => Types::Object,
+      'String' => Types::String,
+      'Array' => Types::Array,
+      'Date' => Types::Date,
+      'DateTime' => Types::DateTime,
+      'Time' => Types::Time,
+      'ActiveSupport::TimeZone' => Types::ActiveSupport::TimeZone,
+      'BigDecimal' => Types::BigDecimal,
+      'Float' => Types::Float,
+      'Integer' => Types::Integer,
+      'Boolean' => Types::Boolean,
+      'Granite::Form::UUID' => Types::UUID
+    }
   end
 end
 
@@ -150,6 +47,10 @@ require 'granite/form/base'
 
 Granite::Form.base_class = Granite::Form::Base
 
+ActiveSupport.on_load :action_controller do
+  Granite::Form.config.types['Hash'] = Granite::Form::Types::HashWithActionControllerParameters
+end
+
 ActiveSupport.on_load :active_record do
   require 'granite/form/active_record/associations'
   require 'granite/form/active_record/nested_attributes'

data/spec/{lib/granite → granite}/form/active_record/associations_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Granite::Form::ActiveRecord::Associations do
   before do
     stub_model(:project) do
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Persistence
       include Granite::Form::Model::Associations
 
       attribute :title, String
@@ -18,7 +18,8 @@ describe Granite::Form::ActiveRecord::Associations do
     end
 
     stub_model(:profile) do
-      include Granite::Form::Model::Lifecycle
+      include Granite::Form::Model::Persistence
+      include Granite::Form::Model::Associations
 
       attribute :first_name, String
       attribute :last_name, String
@@ -89,7 +90,10 @@ describe Granite::Form::ActiveRecord::Associations do
       end
 
       context 'with profile already set' do
-        before { user.create_profile(admin: true) }
+        before do
+          user.build_profile(admin: true)
+          user.save!
+        end
 
         specify do
           user.profile.admin = false
@@ -104,13 +108,9 @@ describe Granite::Form::ActiveRecord::Associations do
     let(:user) { User.create }
 
     describe '#projects' do
-      specify do
-        expect { user.projects << Project.new }
-          .not_to change { user.read_attribute(:projects) }
-      end
       specify do
         expect { user.projects << Project.new(title: 'First') }
-          .to change { user.projects.reload.count }.from(0).to(1)
+          .not_to change { user.read_attribute(:projects) }
       end
       specify do
         user.projects << Project.new(title: 'First')
@@ -124,15 +124,14 @@ describe Granite::Form::ActiveRecord::Associations do
 
         specify do
           expect { user.projects << project }
-            .to change { user.read_attribute(:projects) }.from(nil)
-            .to([{'title' => 'First', 'author' => {'name' => 'Author'}}])
+            .not_to change { user.read_attribute(:projects) }
         end
         specify do
           expect do
             user.projects << project
             user.save
           end
-            .to change { user.reload.read_attribute(:projects) }.from(nil)
+            .to change { user.reload.read_attribute(:projects) }.from([])
             .to([{'title' => 'First', 'author' => {'name' => 'Author'}}])
         end
       end
@@ -150,8 +149,7 @@ describe Granite::Form::ActiveRecord::Associations do
       end
       specify do
         expect { user.profile = Profile.new(first_name: 'google.com') }
-          .to change { user.read_attribute(:profile) }.from(nil)
-          .to({first_name: 'google.com', last_name: nil, admin: nil}.to_json)
+          .not_to change { user.read_attribute(:profile) }
       end
       specify do
         expect do
@@ -196,16 +194,16 @@ describe Granite::Form::ActiveRecord::Associations do
 
     specify { expect(User.reflect_on_association(:projects).klass).to eq(User::Project) }
     specify { expect(User.new.projects).to eq([]) }
-    specify { expect(User.new.tap { |u| u.projects.create(title: 'Project') }.projects).to be_a(Granite::Form::Model::Associations::Collection::Embedded) }
-    specify { expect(User.new.tap { |u| u.projects.create(title: 'Project') }.read_attribute(:projects)).to eq([{title: 'Project'}].to_json) }
+    specify { expect(User.new.tap { |u| u.projects.build(title: 'Project') }.projects).to be_a(Granite::Form::Model::Associations::Collection::Embedded) }
+    specify { expect(User.new.tap { |u| u.projects.build(title: 'Project') }.projects).to match([have_attributes(title: 'Project')]) }
 
     specify { expect(User.reflect_on_association(:profile).klass).to eq(User::Profile) }
     specify { expect(User.reflect_on_association(:profile).klass).to be < Profile }
     specify { expect(User.new.profile).to be_nil }
-    specify { expect(User.new.tap { |u| u.create_profile(first_name: 'Profile') }.profile).to be_a(User::Profile) }
+    specify { expect(User.new.tap { |u| u.build_profile(first_name: 'Profile') }.profile).to be_a(User::Profile) }
     specify do
-      expect(User.new.tap { |u| u.create_profile(first_name: 'Profile') }.read_attribute(:profile))
-        .to eq({first_name: 'Profile', last_name: nil, admin: nil, age: nil}.to_json)
+      expect(User.new.tap { |u| u.build_profile(first_name: 'Profile') }.profile)
+        .to have_attributes(first_name: 'Profile', last_name: nil, admin: nil, age: nil)
     end
   end
 end

data/spec/{lib/granite → granite}/form/active_record/nested_attributes_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-require 'shared/nested_attribute_examples'
 
 describe Granite::Form::ActiveRecord::NestedAttributes do
   before do

data/spec/{lib/granite → granite}/form/config_spec.rb

@@ -47,20 +47,32 @@ describe Granite::Form::Config do
 
   describe '#typecaster' do
     specify do
-      expect { subject.typecaster('Object') {} }
-        .to change { muffle(Granite::Form::TypecasterMissing) { subject.typecaster(Time, Object) } }
-        .from(nil).to(an_instance_of(Proc))
+      expect { subject.typecaster('Object', &:to_s) }
+        .to change { subject.types['Object'] }.from(nil).to(an_instance_of(Class))
+
+      expect(subject.types['Object'].new(Object, nil, stub_model.new).typecast(1)).to eq('1')
     end
+
+    specify do
+      expect { subject.typecaster(Object) {} }
+        .to change { subject.types['Object'] }.from(nil).to(an_instance_of(Class))
+    end
+
     specify do
-      expect { subject.typecaster('Object') {} }
-        .to change { muffle(Granite::Form::TypecasterMissing) { subject.typecaster('time', 'object') } }
-        .from(nil).to(an_instance_of(Proc))
+      expect { subject.typecaster('object') {} }
+        .to change { subject.types['Object'] }.from(nil).to(an_instance_of(Class))
     end
+  end
+
+  describe '#type_for' do
+    let(:definition) { subject.types['Numeric'] }
+
+    before { subject.typecaster('Numeric') {} }
+
     specify do
-      expect { subject.typecaster('Object') {} }
-        .to change { muffle(Granite::Form::TypecasterMissing) { subject.typecaster(Object) } }
-        .from(nil).to(an_instance_of(Proc))
+      expect(subject.type_for(Numeric)).to eq(definition)
+      expect(subject.type_for(Integer)).to eq(definition)
+      expect { subject.type_for(String) }.to raise_error(Granite::Form::TypecasterMissing)
     end
-    specify { expect { subject.typecaster(Object) }.to raise_error Granite::Form::TypecasterMissing }
   end
 end

data/spec/granite/form/extensions_spec.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Granite::Form::UUID do
+  subject(:uuid) { Granite::Form::UUID.random_create }
+
+  specify { expect(uuid.as_json).to eq(uuid.to_s) }
+  specify { expect(uuid.to_json).to eq("\"#{uuid}\"") }
+  specify { expect(uuid.to_param).to eq(uuid.to_s) }
+  specify { expect(uuid.to_query(:key)).to eq("key=#{uuid}") }
+end