github_api 0.4.11 → 0.5.0.rc1

data/spec/github/issues/events_spec.rb

@@ -8,49 +8,49 @@ describe Github::Issues::Events do
   let(:repo)   { 'github' }
   let(:issue_id) { 1 }
 
-  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
+  after { reset_authentication_for github }
 
-  describe 'events' do
-    it { github.issues.should respond_to :events }
-    it { github.issues.should respond_to :list_events }
-    it { github.issues.should respond_to :issue_events }
-    it { github.issues.should respond_to :repo_events }
+  describe '#list' do
+    it { github.issues.comments.should respond_to :all }
 
     context 'without issue_id' do
       context "resource found" do
         before do
           stub_get("/repos/#{user}/#{repo}/issues/events").
-            to_return(:body => fixture('issues/events.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+            to_return(:body => fixture('issues/events.json'),
+              :status => 200,
+              :headers => {:content_type => "application/json; charset=utf-8"})
         end
 
         it "should fail to get resource without username" do
-          expect { github.issues.events }.to raise_error(ArgumentError)
+          expect { github.issues.events.list }.to raise_error(ArgumentError)
         end
 
         it "should get the resources" do
-          github.issues.events user, repo
+          github.issues.events.list user, repo
           a_get("/repos/#{user}/#{repo}/issues/events").should have_been_made
         end
 
         it "should return array of resources" do
-          events = github.issues.events user, repo
+          events = github.issues.events.list user, repo
           events.should be_an Array
           events.should have(1).items
         end
 
         it "should be a mash type" do
-          events = github.issues.events user, repo
+          events = github.issues.events.list user, repo
           events.first.should be_a Hashie::Mash
         end
 
         it "should get issue information" do
-          events = github.issues.events user, repo
+          events = github.issues.events.list user, repo
           events.first.actor.login.should == 'octocat'
         end
 
         it "should yield to a block" do
-          github.issues.should_receive(:events).with(user, repo).and_yield('web')
-          github.issues.events(user, repo) { |param| 'web' }.should == 'web'
+          github.issues.events.should_receive(:list).
+            with(user, repo).and_yield('web')
+          github.issues.events.list(user, repo) { |param| 'web' }.should == 'web'
         end
       end
 
@@ -62,7 +62,7 @@ describe Github::Issues::Events do
 
         it "should return 404 with a message 'Not Found'" do
           expect {
-            github.issues.events user, repo
+            github.issues.events.list user, repo
           }.to raise_error(Github::Error::NotFound)
         end
       end
@@ -76,63 +76,69 @@ describe Github::Issues::Events do
         end
 
         it "should get the resources" do
-          github.issues.events user, repo, issue_id
+          github.issues.events.list user, repo, issue_id
           a_get("/repos/#{user}/#{repo}/issues/#{issue_id}/events").should have_been_made
         end
 
         it "should return array of resources" do
-          events = github.issues.events user, repo, issue_id
+          events = github.issues.events.list user, repo, issue_id
           events.should be_an Array
           events.should have(1).items
         end
 
         it "should be a mash type" do
-          events = github.issues.events user, repo, issue_id
+          events = github.issues.events.list user, repo, issue_id
           events.first.should be_a Hashie::Mash
         end
 
         it "should get issue information" do
-          events = github.issues.events user, repo, issue_id
+          events = github.issues.events.list user, repo, issue_id
           events.first.actor.login.should == 'octocat'
         end
 
         it "should yield to a block" do
-          github.issues.should_receive(:events).with(user, repo, issue_id).and_yield('web')
-          github.issues.events(user, repo, issue_id) { |param| 'web' }.should == 'web'
+          github.issues.events.should_receive(:list).
+            with(user, repo, issue_id).and_yield('web')
+          github.issues.events.list(user, repo, issue_id) { |param| 'web' }.
+            should == 'web'
         end
       end
     end # with issue_id
-  end # events
+  end # list
 
-  describe "event" do
+  describe "#get" do
     let(:event_id) { 1 }
 
-    it { github.issues.should respond_to :event }
-    it { github.issues.should respond_to :get_event }
+    it { github.issues.events.should respond_to :find }
 
     context "resource found" do
       before do
         stub_get("/repos/#{user}/#{repo}/issues/events/#{event_id}").
-          to_return(:body => fixture('issues/event.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('issues/event.json'),
+            :status => 200,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to get resource without event id" do
-        expect { github.issues.event(user, repo, nil)}.to raise_error(ArgumentError)
+        expect {
+          github.issues.events.get user, repo, nil
+        }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.issues.event user, repo, event_id
-        a_get("/repos/#{user}/#{repo}/issues/events/#{event_id}").should have_been_made
+        github.issues.events.get user, repo, event_id
+        a_get("/repos/#{user}/#{repo}/issues/events/#{event_id}").
+          should have_been_made
       end
 
       it "should get event information" do
-        event = github.issues.event user, repo, event_id
+        event = github.issues.events.get user, repo, event_id
         event.actor.id.should == event_id
         event.actor.login.should == 'octocat'
       end
 
       it "should return mash" do
-        event = github.issues.event user, repo, event_id
+        event = github.issues.events.get user, repo, event_id
         event.should be_a Hashie::Mash
       end
     end
@@ -140,15 +146,17 @@ describe Github::Issues::Events do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/issues/events/#{event_id}").
-          to_return(:body => fixture('issues/event.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('issues/event.json'),
+            :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to retrive resource" do
         expect {
-          github.issues.event user, repo, event_id
+          github.issues.events.get user, repo, event_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # event
+  end # get
 
 end # Github::Issues:Events

data/spec/github/issues/labels_spec.rb

@@ -4,14 +4,14 @@ describe Github::Issues::Labels do
   let(:github) { Github.new }
   let(:user)   { 'peter-murach' }
   let(:repo)   { 'github' }
+  let(:label_id) { 1 }
 
   after { github.user, github.repo, github.oauth_token = nil, nil, nil }
 
   it { described_class::VALID_LABEL_INPUTS.should_not be_nil }
 
-  describe 'labels' do
-    it { github.issues.should respond_to :labels }
-    it { github.issues.should respond_to :list_labels }
+  describe '#list' do
+    it { github.issues.should respond_to :all }
 
     context "resource found" do
       before do
@@ -20,34 +20,35 @@ describe Github::Issues::Labels do
       end
 
       it "should fail to get resource without username" do
-        github.user, github.repo = nil, nil
-        expect { github.issues.labels nil, repo }.to raise_error(ArgumentError)
+        expect {
+          github.issues.labels.list nil, repo
+        }.to raise_error(ArgumentError)
       end
 
       it "should get the resources" do
-        github.issues.labels user, repo
+        github.issues.labels.list user, repo
         a_get("/repos/#{user}/#{repo}/labels").should have_been_made
       end
 
       it "should return array of resources" do
-        labels = github.issues.labels user, repo
+        labels = github.issues.labels.list user, repo
         labels.should be_an Array
         labels.should have(1).items
       end
 
       it "should be a mash type" do
-        labels = github.issues.labels user, repo
+        labels = github.issues.labels.list user, repo
         labels.first.should be_a Hashie::Mash
       end
 
       it "should get issue information" do
-        labels = github.issues.labels user, repo
+        labels = github.issues.labels.list user, repo
         labels.first.name.should == 'bug'
       end
 
       it "should yield to a block" do
-        github.issues.should_receive(:labels).with(user, repo).and_yield('web')
-        github.issues.labels(user, repo) { |param| 'web' }.should == 'web'
+        github.issues.labels.should_receive(:list).with(user, repo).and_yield('web')
+        github.issues.labels.list(user, repo) { |param| 'web' }.should == 'web'
       end
     end
 
@@ -59,18 +60,13 @@ describe Github::Issues::Labels do
 
       it "should return 404 with a message 'Not Found'" do
         expect {
-          github.issues.labels user, repo
+          github.issues.labels.list user, repo
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # labels
-
-  describe "label" do
-    let(:label_id) { 1 }
-
-    it { github.issues.should respond_to :label }
-    it { github.issues.should respond_to :get_label }
+  end # list
 
+  describe "#find" do
     context "resource found" do
       before do
         stub_get("/repos/#{user}/#{repo}/labels/#{label_id}").
@@ -78,21 +74,23 @@ describe Github::Issues::Labels do
       end
 
       it "should fail to get resource without label id" do
-        expect { github.issues.label(user, repo, nil)}.to raise_error(ArgumentError)
+        expect {
+          github.issues.labels.find(user, repo, nil)
+        }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.issues.label user, repo, label_id
+        github.issues.labels.find user, repo, label_id
         a_get("/repos/#{user}/#{repo}/labels/#{label_id}").should have_been_made
       end
 
       it "should get label information" do
-        label = github.issues.label user, repo, label_id
+        label = github.issues.labels.find user, repo, label_id
         label.name.should == 'bug'
       end
 
       it "should return mash" do
-        label = github.issues.label user, repo, label_id
+        label = github.issues.labels.find user, repo, label_id
         label.should be_a Hashie::Mash
       end
     end
@@ -105,13 +103,13 @@ describe Github::Issues::Labels do
 
       it "should fail to retrive resource" do
         expect {
-          github.issues.label user, repo, label_id
+          github.issues.labels.find user, repo, label_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # label
+  end # find
 
-  describe "create_label" do
+  describe "#create" do
     let(:inputs) {
       {
         "name" => "API",
@@ -127,28 +125,28 @@ describe Github::Issues::Labels do
 
       it "should fail to create resource if 'name' input is missing" do
         expect {
-          github.issues.create_label user, repo, inputs.except('name')
+          github.issues.labels.create user, repo, inputs.except('name')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'color' input is missing" do
         expect {
-          github.issues.create_label user, repo, inputs.except('color')
+          github.issues.labels.create user, repo, inputs.except('color')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
-        github.issues.create_label user, repo, inputs
+        github.issues.labels.create user, repo, inputs
         a_post("/repos/#{user}/#{repo}/labels").with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        label = github.issues.create_label user, repo, inputs
+        label = github.issues.labels.create user, repo, inputs
         label.should be_a Hashie::Mash
       end
 
       it "should get the label information" do
-        label = github.issues.create_label user, repo, inputs
+        label = github.issues.labels.create user, repo, inputs
         label.name.should == 'bug'
       end
     end
@@ -157,19 +155,17 @@ describe Github::Issues::Labels do
       before do
         stub_post("/repos/#{user}/#{repo}/labels").with(inputs).
           to_return(:body => fixture('issues/label.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
       end
 
       it "should faile to retrieve resource" do
         expect {
-          github.issues.create_label user, repo, inputs
+          github.issues.labels.create user, repo, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # create_label
+  end # create
 
-  describe "update_label" do
-    let(:label_id) { 1 }
+  describe "#update" do
     let(:inputs) {
       {
         "name" => "API",
@@ -185,28 +181,28 @@ describe Github::Issues::Labels do
 
       it "should fail to create resource if 'name' input is missing" do
         expect {
-          github.issues.update_label user, repo, label_id, inputs.except('name')
+          github.issues.labels.update user, repo, label_id, inputs.except('name')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'color' input is missing" do
         expect {
-          github.issues.update_label user, repo, label_id, inputs.except('color')
+          github.issues.labels.update user, repo, label_id, inputs.except('color')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should update resource successfully" do
-        github.issues.update_label user, repo, label_id, inputs
+        github.issues.labels.update user, repo, label_id, inputs
         a_patch("/repos/#{user}/#{repo}/labels/#{label_id}").with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        label = github.issues.update_label user, repo, label_id, inputs
+        label = github.issues.labels.update user, repo, label_id, inputs
         label.should be_a Hashie::Mash
       end
 
       it "should get the label information" do
-        label = github.issues.update_label user, repo, label_id, inputs
+        label = github.issues.labels.update user, repo, label_id, inputs
         label.name.should == 'bug'
       end
     end
@@ -215,20 +211,17 @@ describe Github::Issues::Labels do
       before do
         stub_patch("/repos/#{user}/#{repo}/labels/#{label_id}").with(inputs).
           to_return(:body => fixture('issues/label.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
       end
 
       it "should faile to retrieve resource" do
         expect {
-          github.issues.update_label user, repo, label_id, inputs
+          github.issues.labels.update user, repo, label_id, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # update_label
-
-  describe "delete_label" do
-    let(:label_id) { 1 }
+  end # update
 
+  describe "#delete" do
     context "resouce removed" do
       before do
         stub_delete("/repos/#{user}/#{repo}/labels/#{label_id}").
@@ -236,17 +229,17 @@ describe Github::Issues::Labels do
       end
 
       it "should remove resource successfully" do
-        github.issues.delete_label user, repo, label_id
+        github.issues.labels.delete user, repo, label_id
         a_delete("/repos/#{user}/#{repo}/labels/#{label_id}").should have_been_made
       end
 
       it "should return the resource" do
-        label = github.issues.delete_label user, repo, label_id
+        label = github.issues.labels.delete user, repo, label_id
         label.should be_a Hashie::Mash
       end
 
       it "should get the label information" do
-        label = github.issues.delete_label user, repo, label_id
+        label = github.issues.labels.delete user, repo, label_id
         label.name.should == 'bug'
       end
     end
@@ -259,18 +252,15 @@ describe Github::Issues::Labels do
 
       it "should faile to retrieve resource" do
         expect {
-          github.issues.delete_label user, repo, label_id
+          github.issues.labels.delete user, repo, label_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # delete_label
+  end # delete
 
-  describe 'labels_for' do
+  describe '#issue' do
     let(:issue_id) { 1 }
 
-    it { github.issues.should respond_to :labels_for }
-    it { github.issues.should respond_to :issue_labels }
-
     context "resource found" do
       before do
         stub_get("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").
@@ -279,35 +269,36 @@ describe Github::Issues::Labels do
 
       it "should fail to get resource without issue_id" do
         expect {
-          github.issues.labels_for user, repo, nil
+          github.issues.labels.issue user, repo, nil
         }.to raise_error(ArgumentError)
       end
 
       it "should get the resources" do
-        github.issues.labels_for user, repo, issue_id
+        github.issues.labels.issue user, repo, issue_id
         a_get("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").
           should have_been_made
       end
 
       it "should return array of resources" do
-        labels = github.issues.labels_for user, repo, issue_id
+        labels = github.issues.labels.issue user, repo, issue_id
         labels.should be_an Array
         labels.should have(1).items
       end
 
       it "should be a mash type" do
-        labels = github.issues.labels_for user, repo, issue_id
+        labels = github.issues.labels.issue user, repo, issue_id
         labels.first.should be_a Hashie::Mash
       end
 
       it "should get issue information" do
-        labels = github.issues.labels_for user, repo, issue_id
+        labels = github.issues.labels.issue user, repo, issue_id
         labels.first.name.should == 'bug'
       end
 
       it "should yield to a block" do
-        github.issues.should_receive(:labels_for).with(user, repo, issue_id).and_yield('web')
-        github.issues.labels_for(user, repo, issue_id) { |param| 'web' }.should == 'web'
+        github.issues.labels.should_receive(:issue).
+          with(user, repo, issue_id).and_yield('web')
+        github.issues.labels.issue(user, repo, issue_id) { |param| 'web' }.should == 'web'
       end
     end
 
@@ -319,13 +310,13 @@ describe Github::Issues::Labels do
 
       it "should return 404 with a message 'Not Found'" do
         expect {
-          github.issues.labels_for user, repo, issue_id
+          github.issues.labels.issue user, repo, issue_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # labels_for
+  end # issue
 
-  describe "add_labels" do
+  describe "#add" do
     let(:issue_id) { 1 }
     let(:labels) { "Label 1" }
 
@@ -337,22 +328,22 @@ describe Github::Issues::Labels do
 
       it "should fail to add labels if issue-id is missing" do
         expect {
-          github.issues.add_labels user, repo, nil, labels
+          github.issues.labels.add user, repo, nil, labels
         }.to raise_error(ArgumentError)
       end
 
       it "should create resource successfully" do
-        github.issues.add_labels user, repo, issue_id, labels
+        github.issues.labels.add user, repo, issue_id, labels
         a_post("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").should have_been_made
       end
 
       it "should return the resource" do
-        labels = github.issues.add_labels user, repo, issue_id, labels
+        labels = github.issues.labels.add user, repo, issue_id, labels
         labels.first.should be_a Hashie::Mash
       end
 
       it "should get the label information" do
-        labels = github.issues.add_labels user, repo, issue_id, labels
+        labels = github.issues.labels.add user, repo, issue_id, labels
         labels.first.name.should == 'bug'
       end
     end
@@ -366,13 +357,13 @@ describe Github::Issues::Labels do
 
       it "should fail to retrieve resource" do
         expect {
-          github.issues.add_labels user, repo, issue_id, labels
+          github.issues.labels.add user, repo, issue_id, labels
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # add_labels
+  end # add
 
-  describe "remove_label" do
+  describe "#remove" do
     let(:issue_id) { 1 }
     let(:label_id) { 1 }
 
@@ -384,22 +375,22 @@ describe Github::Issues::Labels do
 
       it "should throw exception if issue-id not present" do
         expect {
-          github.issues.remove_label user, repo, nil
+          github.issues.labels.remove user, repo, nil
         }.to raise_error(ArgumentError)
       end
 
       it "should remove label successfully" do
-        github.issues.remove_label user, repo, issue_id, label_id
+        github.issues.labels.remove user, repo, issue_id, label_id
         a_delete("/repos/#{user}/#{repo}/issues/#{issue_id}/labels/#{label_id}").should have_been_made
       end
 
       it "should return the resource" do
-        labels = github.issues.remove_label user, repo, issue_id, label_id
+        labels = github.issues.labels.remove user, repo, issue_id, label_id
         labels.first.should be_a Hashie::Mash
       end
 
       it "should get the label information" do
-        labels = github.issues.remove_label user, repo, issue_id, label_id
+        labels = github.issues.labels.remove user, repo, issue_id, label_id
         labels.first.name.should == 'bug'
       end
     end
@@ -411,7 +402,7 @@ describe Github::Issues::Labels do
       end
 
       it "should remove labels successfully" do
-        github.issues.remove_label user, repo, issue_id
+        github.issues.labels.remove user, repo, issue_id
         a_delete("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").should have_been_made
       end
     end
@@ -424,13 +415,13 @@ describe Github::Issues::Labels do
 
       it "should faile to retrieve resource" do
         expect {
-          github.issues.remove_label user, repo, issue_id, label_id
+          github.issues.labels.remove user, repo, issue_id, label_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # remove_label
+  end # remove
 
-  describe "replace_labels" do
+  describe "#replace" do
     let(:issue_id) { 1 }
     let(:labels) { "Label 1" }
 
@@ -442,22 +433,22 @@ describe Github::Issues::Labels do
 
       it "should fail to add labels if issue-id is missing" do
         expect {
-          github.issues.replace_labels user, repo, nil, labels
+          github.issues.labels.replace user, repo, nil, labels
         }.to raise_error(ArgumentError)
       end
 
       it "should create resource successfully" do
-        github.issues.replace_labels user, repo, issue_id, labels
+        github.issues.labels.replace user, repo, issue_id, labels
         a_put("/repos/#{user}/#{repo}/issues/#{issue_id}/labels").should have_been_made
       end
 
       it "should return the resource" do
-        labels = github.issues.replace_labels user, repo, issue_id, labels
+        labels = github.issues.labels.replace user, repo, issue_id, labels
         labels.first.should be_a Hashie::Mash
       end
 
       it "should get the label information" do
-        labels = github.issues.replace_labels user, repo, issue_id, labels
+        labels = github.issues.labels.replace user, repo, issue_id, labels
         labels.first.name.should == 'bug'
       end
     end
@@ -471,19 +462,15 @@ describe Github::Issues::Labels do
 
       it "should fail to retrieve resource" do
         expect {
-          github.issues.replace_labels user, repo, issue_id, labels
+          github.issues.labels.replace user, repo, issue_id, labels
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # add_labels
+  end # replace
 
-  describe 'milestone_labels' do
+  describe '#milestone' do
     let(:milestone_id) { 1 }
 
-    it { github.issues.should respond_to :milestone_labels }
-    it { github.issues.should respond_to :milestone_issues_labels }
-    it { github.issues.should respond_to :list_milestone_labels }
-
     context "resource found" do
       before do
         stub_get("/repos/#{user}/#{repo}/milestones/#{milestone_id}/labels").
@@ -492,34 +479,35 @@ describe Github::Issues::Labels do
 
       it "should throw exception if milestone-id not present" do
         expect {
-          github.issues.remove_label user, repo, nil
+          github.issues.labels.milestone user, repo, nil
         }.to raise_error(ArgumentError)
       end
 
       it "should get the resources" do
-        github.issues.milestone_labels user, repo, milestone_id
+        github.issues.labels.milestone user, repo, milestone_id
         a_get("/repos/#{user}/#{repo}/milestones/#{milestone_id}/labels").should have_been_made
       end
 
       it "should return array of resources" do
-        labels = github.issues.milestone_labels user, repo, milestone_id
+        labels = github.issues.labels.milestone user, repo, milestone_id
         labels.should be_an Array
         labels.should have(1).items
       end
 
       it "should be a mash type" do
-        labels = github.issues.milestone_labels user, repo, milestone_id
+        labels = github.issues.labels.milestone user, repo, milestone_id
         labels.first.should be_a Hashie::Mash
       end
 
       it "should get issue information" do
-        labels = github.issues.milestone_labels user, repo, milestone_id
+        labels = github.issues.labels.milestone user, repo, milestone_id
         labels.first.name.should == 'bug'
       end
 
       it "should yield to a block" do
-        github.issues.should_receive(:milestone_labels).with(user, repo, milestone_id).and_yield('web')
-        github.issues.milestone_labels(user, repo, milestone_id) { |param| 'web' }.should == 'web'
+        github.issues.labels.should_receive(:milestone).
+          with(user, repo, milestone_id).and_yield('web')
+        github.issues.labels.milestone(user, repo, milestone_id) { |param| 'web' }.should == 'web'
       end
     end
 
@@ -531,10 +519,10 @@ describe Github::Issues::Labels do
 
       it "should return 404 with a message 'Not Found'" do
         expect {
-          github.issues.milestone_labels user, repo, milestone_id
+          github.issues.labels.milestone user, repo, milestone_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # milestone_labels
+  end # milestone
 
 end # Github::Issues::Labels