github_api 0.4.11 → 0.5.0.rc1

data/spec/github/git_data/blobs_spec.rb

@@ -12,32 +12,35 @@ describe Github::GitData::Blobs do
 
   it { described_class::VALID_BLOB_PARAM_NAMES.should_not be_nil }
 
-  describe "blob" do
-    it { github.git_data.should respond_to :blob }
-    it { github.git_data.should respond_to :get_blob }
+  describe "#get" do
+    it { github.git_data.blobs.should respond_to :find }
 
     context "resource found" do
       before do
         stub_get("/repos/#{user}/#{repo}/git/blobs/#{sha}").
-          to_return(:body => fixture('git_data/blob.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('git_data/blob.json'),
+            :status => 200,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to get resource without sha" do
-        expect { github.git_data.blob(user, repo, nil)}.to raise_error(ArgumentError)
+        expect {
+          github.git_data.blobs.get user, repo, nil
+        }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.git_data.blob user, repo, sha
+        github.git_data.blobs.get user, repo, sha
         a_get("/repos/#{user}/#{repo}/git/blobs/#{sha}").should have_been_made
       end
 
       it "should get blob information" do
-        blob = github.git_data.blob user, repo, sha
+        blob = github.git_data.blobs.get user, repo, sha
         blob.content.should eql "Content of the blob"
       end
 
       it "should return mash" do
-        blob = github.git_data.blob user, repo, sha
+        blob = github.git_data.blobs.get user, repo, sha
         blob.should be_a Hashie::Mash
       end
     end
@@ -45,18 +48,20 @@ describe Github::GitData::Blobs do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/git/blobs/#{sha}").
-          to_return(:body => fixture('git_data/blob.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('git_data/blob.json'),
+            :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to retrive resource" do
         expect {
-          github.git_data.blob user, repo, sha
+          github.git_data.blobs.get user, repo, sha
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # blob
+  end # get
 
-  describe "create_blob" do
+  describe "#create" do
     let(:inputs) {
       {
         "content" => "Content of the blob",
@@ -69,33 +74,35 @@ describe Github::GitData::Blobs do
       before do
         stub_post("/repos/#{user}/#{repo}/git/blobs").
           with(:body => JSON.generate(inputs.except('unrelated'))).
-          to_return(:body => fixture('git_data/blob_sha.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('git_data/blob_sha.json'),
+            :status => 201,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to create resource if 'content' input is missing" do
         expect {
-          github.git_data.create_blob user, repo, inputs.except('content')
+          github.git_data.blobs.create user, repo, inputs.except('content')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'encoding' input is missing" do
         expect {
-          github.git_data.create_blob user, repo, inputs.except('encoding')
+          github.git_data.blobs.create user, repo, inputs.except('encoding')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
-        github.git_data.create_blob user, repo, inputs
+        github.git_data.blobs.create user, repo, inputs
         a_post("/repos/#{user}/#{repo}/git/blobs").with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        blob_sha = github.git_data.create_blob user, repo, inputs
+        blob_sha = github.git_data.blobs.create user, repo, inputs
         blob_sha.should be_a Hashie::Mash
       end
 
       it "should get the blob information" do
-        blob_sha = github.git_data.create_blob user, repo, inputs
+        blob_sha = github.git_data.blobs.create user, repo, inputs
         blob_sha.sha.should == sha
       end
     end
@@ -109,10 +116,10 @@ describe Github::GitData::Blobs do
 
       it "should faile to retrieve resource" do
         expect {
-          github.git_data.create_blob user, repo, inputs
+          github.git_data.blobs.create user, repo, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # create_blob
+  end # create
 
 end # Github::GitData::Blobs

data/spec/github/git_data/commits_spec.rb

@@ -12,9 +12,8 @@ describe Github::GitData::Commits, :type => :base do
 
   it { described_class::VALID_COMMIT_PARAM_NAMES.should_not be_nil }
 
-  describe "commit" do
-    it { github.git_data.should respond_to :commit }
-    it { github.git_data.should respond_to :get_commit }
+  describe "#get" do
+    it { github.git_data.commits.should respond_to :find }
 
     context "resource found" do
       before do
@@ -24,22 +23,22 @@ describe Github::GitData::Commits, :type => :base do
 
       it "should fail to get resource without sha" do
         expect {
-          github.git_data.commit(user, repo, nil)
+          github.git_data.commits.get user, repo, nil
         }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.git_data.commit user, repo, sha
+        github.git_data.commits.get user, repo, sha
         a_get("/repos/#{user}/#{repo}/git/commits/#{sha}").should have_been_made
       end
 
       it "should get commit information" do
-        commit = github.git_data.commit user, repo, sha
+        commit = github.git_data.commits.get user, repo, sha
         commit.author.name.should eql "Scott Chacon"
       end
 
       it "should return mash" do
-        commit = github.git_data.commit user, repo, sha
+        commit = github.git_data.commits.get user, repo, sha
         commit.should be_a Hashie::Mash
       end
     end
@@ -47,18 +46,20 @@ describe Github::GitData::Commits, :type => :base do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/git/commits/#{sha}").
-          to_return(:body => fixture('git_data/commit.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('git_data/commit.json'),
+            :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to retrive resource" do
         expect {
-          github.git_data.commit user, repo, sha
+          github.git_data.commits.get user, repo, sha
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # commit
+  end # get
 
-  describe "create_commit" do
+  describe "#create" do
     let(:inputs) {
       {
         "message" =>  "my commit message",
@@ -84,34 +85,34 @@ describe Github::GitData::Commits, :type => :base do
 
       it "should fail to create resource if 'message' input is missing" do
         expect {
-          github.git_data.create_commit user, repo, inputs.except('message')
+          github.git_data.commits.create user, repo, inputs.except('message')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'tree' input is missing" do
         expect {
-          github.git_data.create_commit user, repo, inputs.except('tree')
+          github.git_data.commits.create user, repo, inputs.except('tree')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'parents' input is missing" do
         expect {
-          github.git_data.create_commit user, repo, inputs.except('parents')
+          github.git_data.commits.create user, repo, inputs.except('parents')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
-        github.git_data.create_commit user, repo, inputs
+        github.git_data.commits.create user, repo, inputs
         a_post("/repos/#{user}/#{repo}/git/commits").with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        commit = github.git_data.create_commit user, repo, inputs
+        commit = github.git_data.commits.create user, repo, inputs
         commit.should be_a Hashie::Mash
       end
 
       it "should get the commit information" do
-        commit = github.git_data.create_commit user, repo, inputs
+        commit = github.git_data.commits.create user, repo, inputs
         commit.author.name.should eql "Scott Chacon"
       end
     end
@@ -124,10 +125,10 @@ describe Github::GitData::Commits, :type => :base do
 
       it "should faile to retrieve resource" do
         expect {
-          github.git_data.create_commit user, repo, inputs
+          github.git_data.commits.create user, repo, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # create_commit
+  end # create
 
 end # Github::GitData::Commits

data/spec/github/git_data/references_spec.rb

@@ -14,13 +14,8 @@ describe Github::GitData::References do
   it { described_class::VALID_REF_PARAM_NAMES.should_not be_nil }
   it { described_class::VALID_REF_PARAM_VALUES.should_not be_nil }
 
-  describe "references" do
-
-    context 'check aliases' do
-      it { github.git_data.should respond_to :references }
-      it { github.git_data.should respond_to :list_references }
-      it { github.git_data.should respond_to :get_all_references }
-    end
+  describe "#list" do
+    it { github.git_data.references.should respond_to :all }
 
     context "get all the refernces based on sub-namespace" do
       before do
@@ -29,39 +24,42 @@ describe Github::GitData::References do
       end
 
       it "should fail to get resource without username" do
-        expect { github.git_data.references }.to raise_error(ArgumentError)
+        expect {
+          github.git_data.references.list nil, repo
+        }.to raise_error(ArgumentError)
       end
 
       it "should fail to call with invalid reference" do
         expect {
-          github.git_data.references user, repo, 'branch'
+          github.git_data.references.list user, repo, 'branch'
         }.to raise_error(ArgumentError)
       end
 
       it "should get the resources" do
-        github.git_data.references user, repo, ref
+        github.git_data.references.list user, repo, ref
         a_get("/repos/#{user}/#{repo}/git/refs/#{ref}").should have_been_made
       end
 
       it "should return array of resources" do
-        references = github.git_data.references user, repo, ref
+        references = github.git_data.references.list user, repo, ref
         references.should be_an Array
         references.should have(3).items
       end
 
       it "should be a mash type" do
-        references = github.git_data.references user, repo, ref
+        references = github.git_data.references.list user, repo, ref
         references.first.should be_a Hashie::Mash
       end
 
       it "should get reference information" do
-        references = github.git_data.references user, repo, ref
+        references = github.git_data.references.list user, repo, ref
         references.first.ref.should eql 'refs/heads/master'
       end
 
       it "should yield to a block" do
-        github.git_data.should_receive(:references).with(user, repo, ref).and_yield('web')
-        github.git_data.references(user, repo, ref) { |param| 'web' }
+        github.git_data.references.should_receive(:list).
+          with(user, repo, ref).and_yield('web')
+        github.git_data.references.list(user, repo, ref) { |param| 'web' }
       end
     end
 
@@ -72,7 +70,7 @@ describe Github::GitData::References do
       end
 
       it "should get the resources" do
-        github.git_data.references user, repo
+        github.git_data.references.list user, repo
         a_get("/repos/#{user}/#{repo}/git/refs").should have_been_made
       end
     end
@@ -85,15 +83,14 @@ describe Github::GitData::References do
 
       it "should return 404 with a message 'Not Found'" do
         expect {
-          github.git_data.references user, repo, ref
+          github.git_data.references.list user, repo, ref
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # references
+  end # list
 
-  describe "reference" do
-    it { github.git_data.should respond_to :reference }
-    it { github.git_data.should respond_to :get_reference }
+  describe "#get" do
+    it { github.git_data.references.should respond_to :find }
 
     context "resource found" do
       before do
@@ -102,27 +99,29 @@ describe Github::GitData::References do
       end
 
       it "should fail to get resource without ref" do
-        expect { github.git_data.reference(user, repo, nil)}.to raise_error(ArgumentError)
+        expect {
+          github.git_data.references.get user, repo, nil
+        }.to raise_error(ArgumentError)
       end
 
       it "should fail to get resource with wrong ref" do
         expect {
-          github.git_data.reference user, repo, 'branch'
+          github.git_data.references.get user, repo, 'branch'
         }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.git_data.reference user, repo, ref
+        github.git_data.references.get user, repo, ref
         a_get("/repos/#{user}/#{repo}/git/refs/#{ref}").should have_been_made
       end
 
       it "should get reference information" do
-        reference = github.git_data.reference user, repo, ref
+        reference = github.git_data.references.get user, repo, ref
         reference.first.ref.should eql "refs/heads/sc/featureA"
       end
 
       it "should return mash" do
-        reference = github.git_data.reference user, repo, ref
+        reference = github.git_data.references.get user, repo, ref
         reference.first.should be_a Hashie::Mash
       end
     end
@@ -135,13 +134,13 @@ describe Github::GitData::References do
 
       it "should fail to retrive resource" do
         expect {
-          github.git_data.reference user, repo, ref
+          github.git_data.references.get user, repo, ref
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # reference
+  end # get
 
-  describe "create_reference" do
+  describe "#create" do
     let(:inputs) {
       {
         "ref" => "refs/heads/master",
@@ -159,34 +158,34 @@ describe Github::GitData::References do
 
       it "should fail to create resource if 'ref' input is missing" do
         expect {
-          github.git_data.create_reference user, repo, inputs.except('ref')
+          github.git_data.references.create user, repo, inputs.except('ref')
         }.to raise_error(ArgumentError)
       end
 
       it "should fail to create resource if 'sha' input is missing" do
         expect {
-          github.git_data.create_reference user, repo, inputs.except('sha')
+          github.git_data.references.create user, repo, inputs.except('sha')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to create resource if 'ref' is wrong" do
         expect {
-          github.git_data.create_reference user, repo, 'branch'
+          github.git_data.references.create user, repo, 'branch'
         }.to raise_error(ArgumentError)
       end
 
       it "should create resource successfully" do
-        github.git_data.create_reference user, repo, inputs
+        github.git_data.references.create user, repo, inputs
         a_post("/repos/#{user}/#{repo}/git/refs").with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        reference = github.git_data.create_reference user, repo, inputs
+        reference = github.git_data.references.create user, repo, inputs
         reference.first.should be_a Hashie::Mash
       end
 
       it "should get the reference information" do
-        reference = github.git_data.create_reference user, repo, inputs
+        reference = github.git_data.references.create user, repo, inputs
         reference.first.ref.should eql 'refs/heads/sc/featureA'
       end
     end
@@ -200,13 +199,13 @@ describe Github::GitData::References do
 
       it "should faile to retrieve resource" do
         expect {
-          github.git_data.create_reference user, repo, inputs
+          github.git_data.references.create user, repo, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # create_reference
+  end # create
 
-  describe "update_reference" do
+  describe "#update" do
     let(:inputs) {
       {
         "sha" => "827efc6d56897b048c772eb4087f854f46256132",
@@ -224,28 +223,29 @@ describe Github::GitData::References do
 
       it "should fail to update resource if 'sha' input is missing" do
         expect {
-          github.git_data.update_reference user, repo, ref, inputs.except('sha')
+          github.git_data.references.update user, repo, ref, inputs.except('sha')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should fail to update resource if 'ref' is wrong" do
         expect {
-          github.git_data.update_reference user, repo, 'branch', inputs
+          github.git_data.references.update user, repo, 'branch', inputs
         }.to raise_error(ArgumentError)
       end
 
       it "should update resource successfully" do
-        github.git_data.update_reference user, repo, ref, inputs
-        a_patch("/repos/#{user}/#{repo}/git/refs/#{ref}").with(inputs).should have_been_made
+        github.git_data.references.update user, repo, ref, inputs
+        a_patch("/repos/#{user}/#{repo}/git/refs/#{ref}").
+          with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        reference = github.git_data.update_reference user, repo, ref, inputs
+        reference = github.git_data.references.update user, repo, ref, inputs
         reference.first.should be_a Hashie::Mash
       end
 
       it "should get the reference information" do
-        reference = github.git_data.update_reference user, repo, ref, inputs
+        reference = github.git_data.references.update user, repo, ref, inputs
         reference.first.ref.should eql 'refs/heads/sc/featureA'
       end
     end
@@ -259,10 +259,47 @@ describe Github::GitData::References do
 
       it "should faile to retrieve resource" do
         expect {
-          github.git_data.update_reference user, repo, ref, inputs
+          github.git_data.references.update user, repo, ref, inputs
+        }.to raise_error(Github::Error::NotFound)
+      end
+    end
+  end # update
+
+  describe "#delete" do
+    it { github.git_data.references.should respond_to :remove }
+
+    context "resouce delete" do
+      before do
+        stub_delete("/repos/#{user}/#{repo}/git/refs/#{ref}").
+          to_return(:body => '', :status => 204, 
+            :headers => {:content_type => "application/json; charset=utf-8"})
+      end
+
+      it "should fail to delete resource if 'ref' input is missing" do
+        expect {
+          github.git_data.references.delete user, repo, nil
+        }.to raise_error(ArgumentError)
+      end
+
+      it "should delete resource successfully" do
+        github.git_data.references.delete user, repo, ref
+        a_delete("/repos/#{user}/#{repo}/git/refs/#{ref}").should have_been_made
+      end
+    end
+
+    context "failed to create resource" do
+      before do
+        stub_delete("/repos/#{user}/#{repo}/git/refs/#{ref}").
+          to_return(:body => '', :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
+      end
+
+      it "should faile to retrieve resource" do
+        expect {
+          github.git_data.references.delete user, repo, ref
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # update_reference
+  end # delete
 
 end # Github::GitData::References