github_api 0.4.11 → 0.5.0.rc1

data/spec/github/git_data/tags_spec.rb

@@ -12,9 +12,8 @@ describe Github::GitData::Tags do
 
   it { described_class::VALID_TAG_PARAM_NAMES.should_not be_nil }
 
-  describe "tag" do
-    it { github.git_data.should respond_to :tag }
-    it { github.git_data.should respond_to :get_tag }
+  describe "#get" do
+    it { github.git_data.tags.should respond_to :find }
 
     context "resource found" do
       before do
@@ -23,21 +22,23 @@ describe Github::GitData::Tags do
       end
 
       it "should fail to get resource without sha" do
-        expect { github.git_data.tag(user, repo, nil)}.to raise_error(ArgumentError)
+        expect {
+          github.git_data.tags.get user, repo, nil
+        }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.git_data.tag user, repo, sha
+        github.git_data.tags.get user, repo, sha
         a_get("/repos/#{user}/#{repo}/git/tags/#{sha}").should have_been_made
       end
 
       it "should get tag information" do
-        tag = github.git_data.tag user, repo, sha
+        tag = github.git_data.tags.get user, repo, sha
         tag.tag.should eql "v0.0.1"
       end
 
       it "should return mash" do
-        tag = github.git_data.tag user, repo, sha
+        tag = github.git_data.tags.get user, repo, sha
         tag.should be_a Hashie::Mash
       end
     end
@@ -50,13 +51,13 @@ describe Github::GitData::Tags do
 
       it "should fail to retrive resource" do
         expect {
-          github.git_data.tag user, repo, sha
+          github.git_data.tags.get user, repo, sha
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # tag
+  end # get
 
-  describe "create_tag" do
+  describe "#create" do
     let(:inputs) {
       {
         "tag" => "v0.0.1",
@@ -83,17 +84,17 @@ describe Github::GitData::Tags do
       end
 
       it "should create resource successfully" do
-        github.git_data.create_tag user, repo, inputs
+        github.git_data.tags.create user, repo, inputs
         a_post("/repos/#{user}/#{repo}/git/tags").with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        tag = github.git_data.create_tag user, repo, inputs
+        tag = github.git_data.tags.create user, repo, inputs
         tag.should be_a Hashie::Mash
       end
 
       it "should get the tag information" do
-        tag = github.git_data.create_tag user, repo, inputs
+        tag = github.git_data.tags.create user, repo, inputs
         tag.sha.should == sha
       end
     end
@@ -107,10 +108,10 @@ describe Github::GitData::Tags do
 
       it "should faile to retrieve resource" do
         expect {
-          github.git_data.create_tag user, repo, inputs
+          github.git_data.tags.create user, repo, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # create_tag
+  end # create
 
 end # Github::GitData::Tags

data/spec/github/git_data/trees_spec.rb

@@ -12,9 +12,8 @@ describe Github::GitData::Trees do
 
   it { described_class::VALID_TREE_PARAM_NAMES.should_not be_nil }
 
-  describe "tree" do
-    it { github.git_data.should respond_to :tree }
-    it { github.git_data.should respond_to :get_tree }
+  describe "#get" do
+    it { github.git_data.trees.should respond_to :find }
 
     context "non-resursive" do
       before do
@@ -23,21 +22,23 @@ describe Github::GitData::Trees do
       end
 
       it "should fail to get resource without sha" do
-        expect { github.git_data.tree(user, repo, nil)}.to raise_error(ArgumentError)
+        expect {
+          github.git_data.trees.get user, repo, nil
+        }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.git_data.tree user, repo, sha
+        github.git_data.trees.get user, repo, sha
         a_get("/repos/#{user}/#{repo}/git/trees/#{sha}").should have_been_made
       end
 
       it "should get tree information" do
-        tree = github.git_data.tree user, repo, sha
+        tree = github.git_data.trees.get user, repo, sha
         tree.sha.should eql sha
       end
 
       it "should return mash" do
-        tree = github.git_data.tree user, repo, sha
+        tree = github.git_data.trees.get user, repo, sha
         tree.should be_a Hashie::Mash
       end
     end
@@ -49,17 +50,17 @@ describe Github::GitData::Trees do
       end
 
       it "should get the resource" do
-        github.git_data.tree user, repo, sha, 'recursive' => true
+        github.git_data.trees.get user, repo, sha, 'recursive' => true
         a_get("/repos/#{user}/#{repo}/git/trees/#{sha}?recursive=1").should have_been_made
       end
 
       it "should get tree information" do
-        tree = github.git_data.tree user, repo, sha, 'recursive' => true
+        tree = github.git_data.trees.get user, repo, sha, 'recursive' => true
         tree.sha.should eql sha
       end
 
       it "should return mash" do
-        tree = github.git_data.tree user, repo, sha, 'recursive' => true
+        tree = github.git_data.trees.get user, repo, sha, 'recursive' => true
         tree.should be_a Hashie::Mash
       end
     end
@@ -72,13 +73,13 @@ describe Github::GitData::Trees do
 
       it "should fail to retrive resource" do
         expect {
-          github.git_data.tree user, repo, sha
+          github.git_data.trees.get user, repo, sha
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # tree
+  end # get
 
-  describe "create_tree" do
+  describe "#create" do
     let(:inputs) {
       {
         "tree" => [
@@ -101,22 +102,22 @@ describe Github::GitData::Trees do
 
       it "should fail to create resource if 'content' input is missing" do
         expect {
-          github.git_data.create_tree user, repo, inputs.except('tree')
+          github.git_data.trees.create user, repo, inputs.except('tree')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
-        github.git_data.create_tree user, repo, inputs
+        github.git_data.trees.create user, repo, inputs
         a_post("/repos/#{user}/#{repo}/git/trees").with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        tree_sha = github.git_data.create_tree user, repo, inputs
+        tree_sha = github.git_data.trees.create user, repo, inputs
         tree_sha.should be_a Hashie::Mash
       end
 
       it "should get the tree information" do
-        tree_sha = github.git_data.create_tree user, repo, inputs
+        tree_sha = github.git_data.trees.create user, repo, inputs
         tree_sha.sha.should == sha
       end
     end
@@ -130,10 +131,10 @@ describe Github::GitData::Trees do
 
       it "should faile to retrieve resource" do
         expect {
-          github.git_data.create_tree user, repo, inputs
+          github.git_data.trees.create user, repo, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # create_tree
+  end # create
 
 end # Github::GitData::Trees

data/spec/github/git_data_spec.rb

@@ -1,4 +1,13 @@
 require 'spec_helper'
 
 describe Github::GitData do
-end
+
+  context 'access to apis' do
+    it { subject.blobs.should be_a Github::GitData::Blobs }
+    it { subject.commits.should be_a Github::GitData::Commits }
+    it { subject.references.should be_a Github::GitData::References }
+    it { subject.tags.should be_a Github::GitData::Tags }
+    it { subject.trees.should be_a Github::GitData::Trees }
+  end
+
+end # Github::GitData

data/spec/github/issues/comments_spec.rb

@@ -13,48 +13,49 @@ describe Github::Issues::Comments do
 
   it { described_class::VALID_ISSUE_COMMENT_PARAM_NAME.should_not be_nil }
 
-  describe 'comments' do
-
-    it { github.issues.should respond_to :comments }
-    it { github.issues.should respond_to :issue_comments }
-    it { github.issues.should respond_to :list_comments }
-    it { github.issues.should respond_to :list_issue_comments }
+  describe '#list' do
+    it { github.issues.should respond_to :all }
 
     context "resource found" do
       before do
         stub_get("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
-          to_return(:body => fixture('issues/comments.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('issues/comments.json'),
+            :status => 200,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to get resource without username" do
-        github.user, github.repo = nil, nil
-        expect { github.issues.comments user, repo, nil }.to raise_error(ArgumentError)
+        expect {
+          github.issues.comments.list user, repo, nil
+        }.to raise_error(ArgumentError)
       end
 
       it "should get the resources" do
-        github.issues.comments user, repo, issue_id
+        github.issues.comments.list user, repo, issue_id
         a_get("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").should have_been_made
       end
 
       it "should return array of resources" do
-        comments = github.issues.comments user, repo, issue_id
+        comments = github.issues.comments.list user, repo, issue_id
         comments.should be_an Array
         comments.should have(1).items
       end
 
       it "should be a mash type" do
-        comments = github.issues.comments user, repo, issue_id
+        comments = github.issues.comments.list user, repo, issue_id
         comments.first.should be_a Hashie::Mash
       end
 
       it "should get issue comment information" do
-        comments = github.issues.comments user, repo, issue_id
+        comments = github.issues.comments.list user, repo, issue_id
         comments.first.user.login.should == 'octocat'
       end
 
       it "should yield to a block" do
-        github.issues.should_receive(:comments).with(user, repo, issue_id).and_yield('web')
-        github.issues.comments(user, repo, issue_id) { |param| 'web' }.should == 'web'
+        github.issues.comments.should_receive(:list).
+          with(user, repo, issue_id).and_yield('web')
+        github.issues.comments.list(user, repo, issue_id) { |param| 'web' }.
+          should == 'web'
       end
     end
 
@@ -66,17 +67,14 @@ describe Github::Issues::Comments do
 
       it "should return 404 with a message 'Not Found'" do
         expect {
-          github.issues.comments user, repo, issue_id
+          github.issues.comments.list user, repo, issue_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # comments
+  end # list
 
-  describe "comment" do
-
-    it { github.issues.should respond_to :comment }
-    it { github.issues.should respond_to :issue_comment }
-    it { github.issues.should respond_to :get_comment }
+  describe "#get" do
+    it { github.issues.comments.should respond_to :find }
 
     context "resource found" do
       before do
@@ -85,22 +83,24 @@ describe Github::Issues::Comments do
       end
 
       it "should fail to get resource without comment id" do
-        expect { github.issues.comment(user, repo, nil)}.to raise_error(ArgumentError)
+        expect {
+          github.issues.comments.get user, repo, nil
+        }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.issues.comment user, repo, comment_id
+        github.issues.comments.get user, repo, comment_id
         a_get("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").should have_been_made
       end
 
       it "should get comment information" do
-        comment = github.issues.comment user, repo, comment_id
+        comment = github.issues.comments.get user, repo, comment_id
         comment.user.id.should == comment_id
         comment.user.login.should == 'octocat'
       end
 
       it "should return mash" do
-        comment = github.issues.comment user, repo, comment_id
+        comment = github.issues.comments.get user, repo, comment_id
         comment.should be_a Hashie::Mash
       end
     end
@@ -108,136 +108,146 @@ describe Github::Issues::Comments do
     context "resource not found" do
       before do
         stub_get("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          to_return(:body => fixture('issues/comment.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('issues/comment.json'),
+          :status => 404,
+          :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to retrive resource" do
         expect {
-          github.issues.comment user, repo, comment_id
+          github.issues.comments.get user, repo, comment_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # comment
+  end # get
 
-  describe "create_comment" do
+  describe "#create" do
     let(:issue_id) { 1 }
     let(:inputs) { { 'body' => 'a new comment' } }
 
-    it { github.issues.should respond_to :create_comment }
-    it { github.issues.should respond_to :create_issue_comment }
-
     context "resouce created" do
       before do
-        stub_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").with(:body => inputs).
-          to_return(:body => fixture('issues/comment.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+        stub_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
+          with(:body => inputs).
+          to_return(:body => fixture('issues/comment.json'),
+          :status => 201,
+          :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to create resource if 'body' input is missing" do
         expect {
-          github.issues.create_comment user, repo, issue_id, inputs.except('body')
+          github.issues.comments.create user, repo, issue_id, inputs.except('body')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
-        github.issues.create_comment user, repo, issue_id, inputs
-        a_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").with(inputs).should have_been_made
+        github.issues.comments.create user, repo, issue_id, inputs
+        a_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
+          with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        comment = github.issues.create_comment user, repo, issue_id, inputs
+        comment = github.issues.comments.create user, repo, issue_id, inputs
         comment.should be_a Hashie::Mash
       end
 
       it "should get the comment information" do
-        comment = github.issues.create_comment user, repo, issue_id, inputs
+        comment = github.issues.comments.create user, repo, issue_id, inputs
         comment.user.login.should == 'octocat'
       end
     end
 
     context "failed to create resource" do
       before do
-        stub_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").with(inputs).
-          to_return(:body => fixture('issues/comment.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+        stub_post("/repos/#{user}/#{repo}/issues/#{issue_id}/comments").
+          with(inputs).
+          to_return(:body => fixture('issues/comment.json'),
+            :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to retrieve resource" do
         expect {
-          github.issues.create_comment user, repo, issue_id, inputs
+          github.issues.comments.create user, repo, issue_id, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # create_comment
+  end # create
 
   describe "edit_comment" do
     let(:comment_id) { 1 }
     let(:inputs) { { 'body' => 'a new comment' } }
 
-    it { github.issues.should respond_to :edit_comment }
-    it { github.issues.should respond_to :edit_issue_comment }
-
     context "resouce edited" do
       before do
-        stub_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").with(inputs).
-          to_return(:body => fixture('issues/comment.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
+        stub_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
+          with(inputs).
+          to_return(:body => fixture('issues/comment.json'),
+            :status => 201,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to create resource if 'body' input is missing" do
         expect {
-          github.issues.edit_comment user, repo, comment_id, inputs.except('body')
+          github.issues.comments.edit user, repo, comment_id, inputs.except('body')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
-        github.issues.edit_comment user, repo, comment_id, inputs
-        a_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").with(inputs).should have_been_made
+        github.issues.comments.edit user, repo, comment_id, inputs
+        a_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
+          with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        comment = github.issues.edit_comment user, repo, comment_id, inputs
+        comment = github.issues.comments.edit user, repo, comment_id, inputs
         comment.should be_a Hashie::Mash
       end
 
       it "should get the comment information" do
-        comment = github.issues.edit_comment user, repo, comment_id, inputs
+        comment = github.issues.comments.edit user, repo, comment_id, inputs
         comment.user.login.should == 'octocat'
       end
     end
 
     context "failed to create resource" do
       before do
-        stub_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").with(inputs).
-          to_return(:body => fixture('issues/comment.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+        stub_patch("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
+          with(inputs).
+          to_return(:body => fixture('issues/comment.json'),
+            :status => 404,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to retrieve resource" do
         expect {
-          github.issues.edit_comment user, repo, comment_id, inputs
+          github.issues.comments.edit user, repo, comment_id, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # edit_comment
+  end # edit
 
-  describe "delete_comment" do
+  describe "#delete" do
     let(:comment_id) { 1 }
 
-    it { github.issues.should respond_to :delete_comment }
-    it { github.issues.should respond_to :delete_issue_comment }
-
     context "resouce deleted" do
       before do
         stub_delete("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
-          to_return(:body => fixture('issues/comment.json'), :status => 204, :headers => {:content_type => "application/json; charset=utf-8"})
+          to_return(:body => fixture('issues/comment.json'),
+            :status => 204,
+            :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to delete resource if comment_id is missing" do
         expect {
-          github.issues.delete_comment user, repo, nil
+          github.issues.comments.delete user, repo, nil
         }.to raise_error(ArgumentError)
       end
 
       it "should create resource successfully" do
-        github.issues.delete_comment user, repo, comment_id
-        a_delete("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").should have_been_made
+        github.issues.comments.delete user, repo, comment_id
+        a_delete("/repos/#{user}/#{repo}/issues/comments/#{comment_id}").
+          should have_been_made
       end
     end
 
@@ -249,10 +259,10 @@ describe Github::Issues::Comments do
 
       it "should fail to retrieve resource" do
         expect {
-          github.issues.delete_comment user, repo, comment_id
+          github.issues.comments.delete user, repo, comment_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
-  end # delete_comment
+  end # delete
 
 end # Github::Issues::Comments