gergich 0.2.2 → 1.0.0

data/spec/gergich/capture/stylelint_capture_spec.rb

@@ -1,15 +1,17 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::StylelintCapture do
   let(:output) do
-    <<-OUTPUT
-app/stylesheets/base/_print.scss
- 3:17  ✖  Unexpected invalid hex color "#owiehfi"   color-no-invalid-hex
- 3:17  ⚠  Expected "#owiehfi" to be "#OWIEHFI"      color-hex-case
+    <<~OUTPUT
+      app/stylesheets/base/_print.scss
+       3:17  ✖  Unexpected invalid hex color "#owiehfi"   color-no-invalid-hex
+       3:17  ⚠  Expected "#owiehfi" to be "#OWIEHFI"      color-hex-case
 
-app/stylesheets/base/_variables.scss
-  2:15  ✖  Unexpected invalid hex color "#2D3B4"   color-no-invalid-hex
- 30:15  ⚠  Expected "#2d3b4a" to be "#2D3B4A"      color-hex-case
+      app/stylesheets/base/_variables.scss
+        2:15  ✖  Unexpected invalid hex color "#2D3B4"   color-no-invalid-hex
+       30:15  ⚠  Expected "#2d3b4a" to be "#2D3B4A"      color-hex-case
     OUTPUT
   end
   let(:comments) do

data/spec/gergich/capture/swiftlint_capture_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::SwiftlintCapture do
@@ -5,11 +7,12 @@ RSpec.describe Gergich::Capture::SwiftlintCapture do
   let(:colon_violation) { "Colon Violation: Colons should be next to the identifier when specifying a type. (colon)" }
   let(:line_length_violation) { "Line Length Violation: Line should be 100 characters or less: currently 129 characters (line_length)" }
   let(:force_cast_violation) { "Force Cast Violation: Force casts should be avoided. (force_cast)" }
+  # rubocop:enable Metrics/LineLength
   let(:output) do
-    <<-OUTPUT
-/path/to/My.swift:13:22: warning: #{colon_violation}
-/path/to/Fail.swift:76: warning: #{line_length_violation}
-/path/to/Cast.swift:15:9: error: #{force_cast_violation}
+    <<~OUTPUT
+      /path/to/My.swift:13:22: warning: #{colon_violation}
+      /path/to/Fail.swift:76: warning: #{line_length_violation}
+      /path/to/Cast.swift:15:9: error: #{force_cast_violation}
     OUTPUT
   end
   let(:comments) do

data/spec/gergich/capture_spec.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require_relative "../../lib/gergich/capture"
 
 RSpec.describe Gergich::Capture do
   let!(:draft) { double }
 
   let :output do
-    <<-OUTPUT
-#{path}
-  4:21  error  Missing semicolon  semi
-OUTPUT
+    <<~OUTPUT
+      #{path}
+        4:21  error  Missing semicolon  semi
+    OUTPUT
   end
 
   before do

data/spec/gergich_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Gergich::API do
   context "bad change-id" do
     let(:result) { double(:result, body: "Not Found: 1234") }
@@ -99,6 +101,11 @@ RSpec.describe Gergich::Draft do
         expect(subject).to eq("foo.rb" => [{ line: 1, message: "[INFO] fix foo" }])
       end
 
+      it "strips whitespace from filename" do
+        draft.add_comment " foo.rb\n", 1, "fix foo", "info"
+        expect(subject).to eq("foo.rb" => [{ line: 1, message: "[INFO] fix foo" }])
+      end
+
       it "includes COMMIT_MSG comments" do
         draft.add_comment "/COMMIT_MSG", 1, "fix commit", "info"
         expect(subject).to eq("/COMMIT_MSG" => [{ line: 1, message: "[INFO] fix commit" }])
@@ -210,16 +217,18 @@ RSpec.describe Gergich::Draft do
 end
 
 RSpec.describe Gergich::Review do
+  let(:change_id) { "test" }
   let!(:commit) do
     double(
       :commit,
+      change_id: change_id,
       files: [
         "foo.rb",
         "bar/baz.lol"
       ],
-      revision_id: "test",
-      revision_number: 1,
-      change_id: "test"
+      info: {},
+      revision_id: change_id,
+      revision_number: 1
     )
   end
   let!(:draft) do
@@ -231,6 +240,37 @@ RSpec.describe Gergich::Review do
     draft.reset!
   end
 
+  describe "#status" do
+    subject { review.status }
+
+    context "nothing to publish" do
+      before :each do
+        allow(review).to receive(:anything_to_publish?).and_return(false)
+      end
+      it { expect { subject }.to output(include("Nothing to publish")).to_stdout }
+    end
+
+    context "something to publish" do
+      before :each do
+        allow(review).to receive(:anything_to_publish?).and_return(true)
+        allow(review).to receive(:already_commented?).and_return(false)
+        allow(review).to receive(:generate_payload).and_return({})
+        allow(review).to receive(:my_messages).and_return([])
+      end
+      it {
+        expected_outputs = [
+          "Project:",
+          "Branch:",
+          "Revision:",
+          "ChangeId: #{change_id}",
+          "Files:"
+          # There's more... but this is good
+        ]
+        expect { subject }.to output(include(*expected_outputs)).to_stdout
+      }
+    end
+  end
+
   describe "#publish!" do
     context "nothing to publish" do
       before :each do
@@ -253,7 +293,6 @@ RSpec.describe Gergich::Review do
 
       it "publishes via the api" do
         expect(Gergich::API).to receive(:post)
-        allow(review).to receive(:change_name?).and_return(false)
         review.publish!
       end
     end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "simplecov" if ENV["COVERAGE"]
 require_relative "../lib/gergich"
 

data/spec/support/capture_shared_examples.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../../lib/gergich/capture"
 
 RSpec.shared_examples_for "a captor" do

metadata

@@ -1,99 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: gergich
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Jon Jensen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-17 00:00:00.000000000 Z
+date: 2019-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.16'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.16'
 - !ruby/object:Gem::Dependency
-  name: httparty
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.5'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.47.1
+        version: '0.49'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.47.1
+        version: '0.49'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: 0.16.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: 0.16.0
 description: Gergich is a little command-line tool for wiring up linters to Gerrit
   so you can get nice inline comments right on the review
 email: jon@instructure.com
@@ -105,6 +105,12 @@ extra_rdoc_files: []
 files:
 - LICENSE
 - README.md
+- bin/check_coverage
+- bin/gergich
+- bin/master_bouncer
+- bin/run_tests.sh
+- lib/gergich.rb
+- lib/gergich/capture.rb
 - lib/gergich/capture/androidlint_capture.rb
 - lib/gergich/capture/brakeman_capture.rb
 - lib/gergich/capture/eslint_capture.rb
@@ -114,11 +120,9 @@ files:
 - lib/gergich/capture/shellcheck_capture.rb
 - lib/gergich/capture/stylelint_capture.rb
 - lib/gergich/capture/swiftlint_capture.rb
-- lib/gergich/capture.rb
+- lib/gergich/cli.rb
 - lib/gergich/cli/gergich.rb
 - lib/gergich/cli/master_bouncer.rb
-- lib/gergich/cli.rb
-- lib/gergich.rb
 - spec/gergich/capture/androidlint_capture_spec.rb
 - spec/gergich/capture/brakeman_capture_spec.rb
 - spec/gergich/capture/custom_capture_spec.rb
@@ -133,10 +137,6 @@ files:
 - spec/gergich_spec.rb
 - spec/spec_helper.rb
 - spec/support/capture_shared_examples.rb
-- bin/check_coverage
-- bin/gergich
-- bin/master_bouncer
-- bin/run_tests.sh
 homepage: https://github.com/instructure/gergich
 licenses:
 - MIT
@@ -147,17 +147,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14.1
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Command-line tool for adding Gerrit comments