gergich 0.2.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: dc6e202255732bf23a6df2c75e18250897744e99
-  data.tar.gz: 1942f228ae335675740fa7ae626a92204ce7e7a5
+SHA256:
+  metadata.gz: c35e56070c32b0ee9d3ae02336e3d27eb4831b5f4f04dc6b73e75d9e87f02908
+  data.tar.gz: 45ee0f9e2b95996903267e298c2347c5f6d234e86516af7677dafa999910c895
 SHA512:
-  metadata.gz: 88c9113246e2e97fda409346032d88de432c910c360ec72c28b368e33e9bb34606663f2588601ef2be3e4bdab18644eac6498cc94749404dc941a373b0865238
-  data.tar.gz: d3266350ace476809d572e191275a7a18dab184d48954f8e3407680f8ec2b3e5840524c3c626d98ea6f7bd970ca21fa7a46108c67894d6e75153de430ef9ce28
+  metadata.gz: 93c5d49b94710befacbaa40b05af12a530b1dd6dbcda69349e45731ce2d8d628109390d34432b3a12f5132eec5b3b368c316c88d5b075ea81fd226d46294d507
+  data.tar.gz: 442c992f4077b79da2666d350d0f803ef55a40e401c0e6b79cabaff4ca5cd807380ea1cb3b99c37bc5aa7b2305323508e9017faa0d0ef0473c4cd9ef66c94b17

data/bin/check_coverage

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "simplecov"
 
 SimpleCov.command_name "check_coverage"
-SimpleCov.minimum_coverage 90
+SimpleCov.minimum_coverage 85
 SimpleCov.at_exit { SimpleCov.result.format! }

data/bin/gergich

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 if ENV["COVERAGE"]
   require "simplecov"

data/bin/master_bouncer

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
-# encoding=utf-8
+# frozen_string_literal: true
 
 if ENV["COVERAGE"]
   require "simplecov"

data/bin/run_tests.sh

@@ -49,9 +49,4 @@ fi
 
 run_command bin/check_coverage
 
-if [[ "$GEMNASIUM_TOKEN" && "$GEMNASIUM_ENABLED" ]]; then
-  # Push our dependency specification files to gemnasium for analysis
-  run_command gemnasium dependency_files push -f=gergich.gemspec
-fi
-
 clean_up_and_exit

data/lib/gergich.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "erb"
 require "sqlite3"
 require "json"
@@ -105,18 +107,9 @@ module Gergich
 
       API.post(generate_url, generate_payload)
 
-      # because why not
-      if change_name?
-        API.put("/accounts/self/name", { name: whats_his_face }.to_json)
-      end
-
       review_info
     end
 
-    def change_name?
-      ENV["GERGICH_CHANGE_NAME"] != "0" && rand < 0.01 && GERGICH_USER == "gergich"
-    end
-
     def anything_to_publish?
       !review_info[:comments].empty? ||
         !review_info[:cover_message_parts].empty? ||
@@ -202,7 +195,7 @@ module Gergich
     end
 
     def my_messages
-      @messages ||= API.get("/changes/#{commit.change_id}/detail")["messages"]
+      @my_messages ||= API.get("/changes/#{commit.change_id}/detail")["messages"]
         .select { |message| message["author"] && message["author"]["username"] == GERGICH_USER }
     end
 
@@ -227,6 +220,7 @@ module Gergich
     # then grab the comment's revision.
     def current_label_revision
       return nil if my_messages.empty?
+
       @current_label_revision ||= begin
         date = current_label_date
         comment_for_current_label = my_messages.find { |message| message["date"] == date } ||
@@ -254,17 +248,13 @@ module Gergich
       score = upcoming_score
       prefix_parts = []
       prefix_parts << unique_comment_prefix if multi_build_setup?
-      prefix_parts << score if score < 0
+      prefix_parts << score if score.negative?
       prefix_parts.join(":")
       # [].join(":") => ""
       # [-2].join(":") => "-2"
       # ["some build prefix", -2].join(":") => "some build prefix:-2"
     end
 
-    def whats_his_face
-      "#{%w[Garry Larry Terry Jerry].sample} Gergich (Bot)"
-    end
-
     def review_info
       @review_info ||= draft.info
     end
@@ -306,7 +296,8 @@ module Gergich
         ret = HTTParty.send(method, url, options).body
         return ret if options[:raw]
 
-        if ret.sub!(/\A\)\]\}'\n/, "") && ret =~ /\A("|\[|\{)/
+        ret = ret.sub(/\A\)\]\}'\n/, "")
+        if ret && ret =~ /\A("|\[|\{)/
           JSON.parse("[#{ret}]")[0] # array hack so we can parse a string literal
         elsif ret =~ /Not found: (?<change_id>.*)/i
           raise("Cannot find Change-Id: #{Regexp.last_match[:change_id]} at #{url}.\n"\
@@ -321,7 +312,7 @@ module Gergich
       end
 
       def base_uri
-        @base_url ||= \
+        @base_uri ||= \
           ENV["GERRIT_BASE_URL"] ||
           ENV.key?("GERRIT_HOST") && "https://#{ENV['GERRIT_HOST']}" ||
           raise(GergichError, "need to set GERRIT_BASE_URL or GERRIT_HOST")
@@ -452,13 +443,16 @@ module Gergich
     #            severe comment will be used to determine the overall
     #            Code-Review score (0, -1, or -2 respectively)
     def add_comment(path, position, message, severity)
+      stripped_path = path.strip
+
       raise GergichError, "invalid position `#{position}`" unless valid_position?(position)
+
       position = position.to_json if position.is_a?(Hash)
       raise GergichError, "invalid severity `#{severity}`" unless SEVERITY_MAP.key?(severity)
       raise GergichError, "no message specified" unless message.is_a?(String) && !message.empty?
 
       db.execute "INSERT INTO comments (path, position, message, severity) VALUES (?, ?, ?, ?)",
-                 [path, position, message, severity]
+                 [stripped_path, position, message, severity]
     end
 
     POSITION_KEYS = %w[end_character end_line start_character start_line].freeze
@@ -478,7 +472,7 @@ module Gergich
           labels[row["name"]] = row["score"]
         end
         score = min_comment_score
-        labels[GERGICH_REVIEW_LABEL] = score if score < 0 && score < labels[GERGICH_REVIEW_LABEL]
+        labels[GERGICH_REVIEW_LABEL] = score if score < [0, labels[GERGICH_REVIEW_LABEL]].min
         labels
       end
     end
@@ -535,21 +529,21 @@ module Gergich
     end
 
     def orphaned_message
-      message = "NOTE: I couldn't create inline comments for everything. " \
+      messages = ["NOTE: I couldn't create inline comments for everything. " \
                 "Although this isn't technically part of your commit, you " \
                 "should still check it out (i.e. side effects or auto-" \
-                "generated from stuff you *did* change):"
+                "generated from stuff you *did* change):"]
 
       other_comments.each do |file|
         file.comments.each do |position, comments|
           comments.each do |comment|
             line = position.is_a?(Integer) ? position : position["start_line"]
-            message << "\n\n#{file.path}:#{line}: #{comment}"
+            messages << "#{file.path}:#{line}: #{comment}"
           end
         end
       end
 
-      message
+      messages.join("\n\n")
     end
 
     def cover_message_parts

data/lib/gergich/capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../gergich"
 require "English"
 
@@ -35,6 +37,7 @@ module Gergich
         if add_comments
           comments.each do |comment|
             next if skip_paths.any? { |path| comment[:path].start_with?(path) }
+
             draft.add_comment comment[:path], comment[:position],
                               comment[:message], comment[:severity]
           end
@@ -67,12 +70,12 @@ module Gergich
       end
 
       def wiretap(io, suppress_output)
-        output = ""
+        output = []
         io.each do |line|
           $stdout.puts line unless suppress_output
           output << line
         end
-        output
+        output.join("")
       end
 
       def load_captor(format)
@@ -81,6 +84,7 @@ module Gergich
         else
           captor = captors[format]
           raise GergichError, "Unrecognized format `#{format}`" unless captor
+
           captor
         end
       end

data/lib/gergich/capture/androidlint_capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gergich
   module Capture
     class AndroidlintCapture < BaseCapture
@@ -23,6 +25,8 @@ module Gergich
         # /path/to/values.xml:5: Warning: For language "fr" (French) the following quantities are not relevant: few, zero [UnusedQuantity]
         #    <plurals name="number">
         #    ^
+        #
+        # rubocop:enable Metrics/LineLength
         pattern = /
           ^([^:\n]+):(\d+)?:?\s(\w+):\s(.*?)\n
           ([^\n]+\n

data/lib/gergich/capture/brakeman_capture.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module Gergich
   module Capture
     class BrakemanCapture < BaseCapture
       # Map Brakeman "confidence level" to severity.
       # http://brakemanscanner.org/docs/confidence/
       SEVERITY_MAP = {
-        "Weak"   => "warn",
+        "Weak" => "warn",
         "Medium" => "warn",
-        "High"   => "error"
+        "High" => "error"
       }.freeze
 
       def run(output)

data/lib/gergich/capture/eslint_capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gergich
   module Capture
     class EslintCapture < BaseCapture

data/lib/gergich/capture/flake8_capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gergich
   module Capture
     class Flake8Capture < BaseCapture

data/lib/gergich/capture/i18nliner_capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gergich
   module Capture
     class I18nlinerCapture < BaseCapture

data/lib/gergich/capture/rubocop_capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gergich
   module Capture
     class RubocopCapture < BaseCapture

data/lib/gergich/capture/shellcheck_capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "json"
 
 module Gergich

data/lib/gergich/capture/stylelint_capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gergich
   module Capture
     class StylelintCapture < BaseCapture
@@ -14,7 +16,7 @@ module Gergich
       #   2:15  ✖  Unexpected invalid hex color "#2D3B4"   color-no-invalid-hex
       #  30:15  ⚠  Expected "#2d3b4a" to be "#2D3B4A"      color-hex-case
 
-      MESSAGE_PREFIX = "[stylelint]".freeze
+      MESSAGE_PREFIX = "[stylelint]"
 
       SEVERITY_MAP = {
         "✖" => "error",
@@ -23,14 +25,14 @@ module Gergich
 
       # example file line:
       # app/stylesheets/base/_variables.scss
-      FILE_PATH_PATTERN = /([^\n]+)\n/
+      FILE_PATH_PATTERN = /([^\n]+)\n/.freeze
 
       # example error line:
       #   1:15  ✖  Unexpected invalid hex color "#2D3B4"   color-no-invalid-hex
-      ERROR_PATTERN = /^\s+(\d+):\d+\s+(✖|⚠)\s+(.*?)\s\s+[^\n]+\n/
+      ERROR_PATTERN = /^\s+(\d+):\d+\s+(✖|⚠)\s+(.*?)\s\s+[^\n]+\n/.freeze
       # rubocop:enable Style/AsciiComments
 
-      PATTERN = /#{FILE_PATH_PATTERN}((#{ERROR_PATTERN})+)/
+      PATTERN = /#{FILE_PATH_PATTERN}((#{ERROR_PATTERN})+)/.freeze
 
       def run(output)
         output.scan(PATTERN).map { |file, errors|

data/lib/gergich/capture/swiftlint_capture.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gergich
   module Capture
     class SwiftlintCapture < BaseCapture
@@ -15,6 +17,8 @@ module Gergich
         # Example:
         # /path/to/My.swift:13:22: warning: Colon Violation: Colons should be next to the identifier when specifying a type. (colon)
         # /path/to/Fail.swift:80: warning: Line Length Violation: Line should be 100 characters or less: currently 108 characters (line_length)
+        #
+        # rubocop:enable Metrics/LineLength
         pattern = /
           ^([^:\n]+):(\d+)(?::\d+)?:\s(\w+):\s(.*?)\n
         /mx

data/lib/gergich/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "shellwords"
 require "English"
 
@@ -38,7 +40,7 @@ def help_command(commands)
       end
     },
     help: -> {
-      indentation = commands.keys.map(&:size).sort.last
+      indentation = commands.keys.map(&:size).max
       commands_help = commands
         .to_a
         .sort_by(&:first)
@@ -73,7 +75,7 @@ def run_app(commands)
       run_command(action)
     rescue GergichError
       error $ERROR_INFO.message
-    rescue
+    rescue StandardError
       error "Unhandled exception: #{$ERROR_INFO}\n#{$ERROR_INFO.backtrace.join("\n")}"
     end
   else

data/lib/gergich/cli/gergich.rb

@@ -1,4 +1,4 @@
-# encoding=utf-8
+# frozen_string_literal: true
 
 require_relative "../cli"
 require_relative "../../gergich"
@@ -14,11 +14,11 @@ CI_TEST_ARGS = {
   ],
   "label" => ["Code-Review", 1],
   "message" => ["this is a test"],
-  "capture" => ["rubocop", "echo #{Shellwords.escape(<<-OUTPUT)}"]
-bin/gergich:47:8: C: Prefer double-quoted strings
-if ENV['DEBUG']
-       ^^^^^^^
-OUTPUT
+  "capture" => ["rubocop", "echo #{Shellwords.escape(<<~OUTPUT)}"]
+    bin/gergich:47:8: C: Prefer double-quoted strings
+    if ENV['DEBUG']
+           ^^^^^^^
+  OUTPUT
 }.freeze
 
 def run_ci_test!(all_commands)
@@ -27,13 +27,14 @@ def run_ci_test!(all_commands)
   commands_to_test << "status" # put it at the end, so we maximize the stuff it tests
 
   commands = commands_to_test.map { |command| [command, CI_TEST_ARGS[command] || []] }
-  commands.concat all_commands.map { |command| ["help", [command]] }
+  commands.concat(all_commands.map { |command| ["help", [command]] })
 
   # after running our test commands, reset and publish frd:
   commands << ["reset"]
-  commands << ["label", ["QA-Review", 1]]
-  commands << ["label", ["Product-Review", 1]]
-  commands << ["label", ["Code-Review", 1]]
+  # Note that while gergich should always be able to vote on these labels, he may be used to
+  # vone on other branches depending on project usage and project-specific permissions
+  commands << ["label", ["Lint-Review", 1]]
+  commands << ["label", ["Code-Review", 1]] # Not all projects have Lint-Review
   commands << ["message", ["\`gergich citest\` checks out :thumbsup: :mj:"]]
   commands << ["publish"]
 
@@ -50,21 +51,21 @@ commands = {}
 
 commands["reset"] = {
   summary: "Clear out pending comments/labels/messages for this patchset",
-  action: ->() {
+  action: -> {
     Gergich::Draft.new.reset!
   },
   help: -> {
-    <<-TEXT
-gergich reset
+    <<~TEXT
+      gergich reset
 
-Clear out the draft for this patchset. Useful for testing.
-TEXT
+      Clear out the draft for this patchset. Useful for testing.
+    TEXT
   }
 }
 
 commands["publish"] = {
   summary: "Publish the draft for this patchset",
-  action: ->() {
+  action: -> {
     if (data = Gergich::Review.new.publish!)
       puts "Published #{data[:total_comments]} comments, set score to #{data[:score]}"
     else
@@ -72,33 +73,33 @@ commands["publish"] = {
     end
   },
   help: -> {
-    <<-TEXT
-gergich publish
+    <<~TEXT
+      gergich publish
 
-Publish all draft comments/labels/messages for this patchset. no-op if
-there are none.
+      Publish all draft comments/labels/messages for this patchset. no-op if
+      there are none.
 
-The cover message and Code-Review label (e.g. -2) are inferred from the
-comments, but labels and messages may be manually set (via `gergich
-message` and `gergich labels`)
-TEXT
+      The cover message and Code-Review label (e.g. -2) are inferred from the
+      comments, but labels and messages may be manually set (via `gergich
+      message` and `gergich labels`)
+    TEXT
   }
 }
 
 commands["status"] = {
   summary: "Show the current draft for this patchset",
-  action: ->() {
+  action: -> {
     Gergich::Review.new.status
   },
   help: -> {
-    <<-TEXT
-gergich status
+    <<~TEXT
+      gergich status
 
-Show the current draft for this patchset
+      Show the current draft for this patchset
 
-Display any labels, cover messages and inline comments that will be set
-as part of this review.
-TEXT
+      Display any labels, cover messages and inline comments that will be set
+      as part of this review.
+    TEXT
   }
 }
 
@@ -107,8 +108,8 @@ commands["comment"] = {
   action: ->(comment_data) {
     comment_data = begin
       JSON.parse(comment_data)
-    rescue JSON::ParserError
-      error("Unable to parse <comment_data> json", "comment")
+                   rescue JSON::ParserError
+                     error("Unable to parse <comment_data> json", "comment")
     end
     comment_data = [comment_data] unless comment_data.is_a?(Array)
 
@@ -120,36 +121,36 @@ commands["comment"] = {
                         comment["severity"]
     end
   },
-  help: ->() {
-    <<-TEXT
-gergich comment <comment_data>
-
-<comment_data> is a JSON object (or array of objects). Each comment object
-should have the following properties:
-  path     - the relative file path, e.g. "app/models/user.rb"
-  position - either a number (line) or an object (range). If an object,
-             must have the following numeric properties:
-               * start_line
-               * start_character
-               * end_line
-               * end_character
-  message  - the text of the comment
-  severity - "info"|"warn"|"error" - this will automatically prefix the
-             comment (e.g. "[ERROR] message here"), and the most severe
-             comment will be used to determine the overall Code-Review
-             score (0, -1, or -2 respectively)
-
-Note that a cover message and Code-Review score will be inferred from the
-most severe comment.
-
-Examples
-    gergich comment '{"path":"foo.rb","position":3,"severity":"error",
-                      "message":"ಠ_ಠ"}'
-    gergich comment '{"path":"bar.rb","severity":"warn",
-                      "position":{"start_line":3,"start_character":5,...},
-                      "message":"¯\\_(ツ)_/¯"}'
-    gergich comment '[{"path":"baz.rb",...}, {...}, {...}]'
-TEXT
+  help: -> {
+    <<~TEXT
+      gergich comment <comment_data>
+
+      <comment_data> is a JSON object (or array of objects). Each comment object
+      should have the following properties:
+        path     - the relative file path, e.g. "app/models/user.rb"
+        position - either a number (line) or an object (range). If an object,
+                   must have the following numeric properties:
+                     * start_line
+                     * start_character
+                     * end_line
+                     * end_character
+        message  - the text of the comment
+        severity - "info"|"warn"|"error" - this will automatically prefix the
+                   comment (e.g. "[ERROR] message here"), and the most severe
+                   comment will be used to determine the overall Code-Review
+                   score (0, -1, or -2 respectively)
+
+      Note that a cover message and Code-Review score will be inferred from the
+      most severe comment.
+
+      Examples
+          gergich comment '{"path":"foo.rb","position":3,"severity":"error",
+                            "message":"ಠ_ಠ"}'
+          gergich comment '{"path":"bar.rb","severity":"warn",
+                            "position":{"start_line":3,"start_character":5,...},
+                            "message":"¯\\_(ツ)_/¯"}'
+          gergich comment '[{"path":"baz.rb",...}, {...}, {...}]'
+    TEXT
   }
 }
 
@@ -159,13 +160,13 @@ commands["message"] = {
     draft = Gergich::Draft.new
     draft.add_message message
   },
-  help: ->() {
-    <<-TEXT
-gergich message <message>
+  help: -> {
+    <<~TEXT
+      gergich message <message>
 
-<message> will be appended to existing cover messages (inferred or manually
-added) for this patchset.
-TEXT
+      <message> will be appended to existing cover messages (inferred or manually
+      added) for this patchset.
+    TEXT
   }
 }
 
@@ -174,16 +175,16 @@ commands["label"] = {
   action: ->(label, score) {
     Gergich::Draft.new.add_label label, score
   },
-  help: ->() {
-    <<-TEXT
-gergich label <label> <score>
+  help: -> {
+    <<~TEXT
+      gergich label <label> <score>
 
-Add a draft label to this patchset. If the same label is set multiple
-times, the lowest score will win.
+      Add a draft label to this patchset. If the same label is set multiple
+      times, the lowest score will win.
 
-<label>  - a valid label (e.g. "Code-Review")
-<score>  - a valid score (e.g. -1)
-TEXT
+      <label>  - a valid label (e.g. "Code-Review")
+      <score>  - a valid score (e.g. -1)
+    TEXT
   }
 }
 
@@ -194,63 +195,63 @@ commands["capture"] = {
     status, = Gergich::Capture.run(format, command)
     exit status
   },
-  help: ->() {
-    <<-TEXT
-gergich capture <format> <command>
+  help: -> {
+    <<~TEXT
+      gergich capture <format> <command>
 
-For common linting formats, `gergich capture` can be used to automatically
-do `gergich comment` calls so you don't have to wire it up yourself.
+      For common linting formats, `gergich capture` can be used to automatically
+      do `gergich comment` calls so you don't have to wire it up yourself.
 
-<format>        - One of the following:
-                  * brakeman
-                  * rubocop
-                  * eslint
-                  * i18nliner
-                  * flake8
-                  * stylelint
-                  * custom:<path>:<class_name> - file path and ruby
-                    class_name of a custom formatter.
+      <format>        - One of the following:
+                        * brakeman
+                        * rubocop
+                        * eslint
+                        * i18nliner
+                        * flake8
+                        * stylelint
+                        * custom:<path>:<class_name> - file path and ruby
+                          class_name of a custom formatter.
 
-<command>       - The command to run whose output conforms to <format>.
-                  Output from the command will still go to STDOUT, and
-                  Gergich will preserve its exit status.
-                  If command is "-", Gergich will simply read from STDIN
-                  and the exit status will always be 0.
+      <command>       - The command to run whose output conforms to <format>.
+                        Output from the command will still go to STDOUT, and
+                        Gergich will preserve its exit status.
+                        If command is "-", Gergich will simply read from STDIN
+                        and the exit status will always be 0.
 
-Examples:
-    gergich capture rubocop "bundle exec rubocop"
+      Examples:
+          gergich capture rubocop "bundle exec rubocop"
 
-    gergich capture eslint eslint
+          gergich capture eslint eslint
 
-    gergich capture i18nliner "rake i18nliner:check"
+          gergich capture i18nliner "rake i18nliner:check"
 
-    gergich capture custom:./gergich/xss:Gergich::XSS "node script/xsslint"
+          gergich capture custom:./gergich/xss:Gergich::XSS "node script/xsslint"
 
-    docker-compose run --rm web eslint | gergich capture eslint -
-    # you might be interested in $PIPESTATUS[0]
-TEXT
+          docker-compose run --rm web eslint | gergich capture eslint -
+          # you might be interested in $PIPESTATUS[0]
+    TEXT
   }
 }
 
 commands["citest"] = {
   summary: "Do a full gergich test based on the current commit",
-  action: ->() {
+  action: -> {
     # automagically test any new command that comes along
     run_ci_test!(commands.keys)
   },
-  help: ->() {
-    <<-TEXT
-gergich citest
-
-You shouldn't need to run this locally, it runs on jenkins. It does the
-following:
-
-1. runs all the gergich commands (w/ dummy data)
-2. ensure all `help` commands work
-3. ensures gergich status is correct
-4. resets
-5. posts an actual +1
-6. publishes
+  help: -> {
+    <<~TEXT
+      gergich citest
+
+      You shouldn't need to run this locally, it runs on jenkins. It does the
+      following:
+
+      1. runs all the gergich commands (w/ dummy data)
+      2. ensure all `help` commands work
+      3. ensures gergich status is correct
+      4. resets
+      5. posts an actual +1
+      6. publishes
     TEXT
   }
 }