gergich 0.2.2 → 1.0.0

data/lib/gergich/cli/master_bouncer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../cli"
 
 ENV["GERGICH_USER"] = ENV.fetch("MASTER_BOUNCER_USER", "master_bouncer")
@@ -19,7 +21,7 @@ def potentially_mergeable_changes
                     "branch:master" \
                  "&o=CURRENT_REVISION"
   changes = Gergich::API.get(url)
-  changes.select { |c| c["subject"] !~ /\Awip($|\W)/i }
+  changes.reject { |c| c["subject"] =~ /\Awip($|\W)/i }
 end
 
 def maybe_bounce_commit!(commit)
@@ -67,22 +69,22 @@ commands = {}
 
 commands["check"] = {
   summary: "Check the current commit's age",
-  action: ->() {
+  action: -> {
     maybe_bounce_commit! Gergich::Commit.new
   },
-  help: ->() {
-    <<-TEXT
-master_bouncer check
+  help: -> {
+    <<~TEXT
+      master_bouncer check
 
-Check the current commit's age, and bounce it if it's too old (-1 or -2,
-depending on the threshold)
-TEXT
+      Check the current commit's age, and bounce it if it's too old (-1 or -2,
+      depending on the threshold)
+    TEXT
   }
 }
 
 commands["check_all"] = {
   summary: "Check the age of all potentially mergeable changes",
-  action: ->() {
+  action: -> {
     Gergich.git("fetch")
     gerrit_host = ENV["GERRIT_HOST"] || error("No GERRIT_HOST set")
 
@@ -102,12 +104,12 @@ commands["check_all"] = {
       sleep 1
     end
   },
-  help: ->() {
-    <<-TEXT
-master_bouncer check_all
+  help: -> {
+    <<~TEXT
+      master_bouncer check_all
 
-Check all open Verified+1 patchsets and bounce any that are too old.
-TEXT
+      Check all open Verified+1 patchsets and bounce any that are too old.
+    TEXT
   }
 }
 

data/spec/gergich/capture/androidlint_capture_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::AndroidlintCapture do
@@ -6,19 +8,20 @@ RSpec.describe Gergich::Capture::AndroidlintCapture do
   let(:rtl_enabled) { "The project references RTL attributes, but does not explicitly enable or disable RTL support with android:supportsRtl in the manifest [RtlEnabled]" }
   let(:lint_error) { 'No .class files were found in project "0.0.2", so none of the classfile based checks could be run. Does the project need to be built first? [LintError]' }
   let(:unused_quantity) { 'For language "fr" (French) the following quantities are not relevant: few, zero [UnusedQuantity]' }
+  # rubocop:enable Metrics/LineLength
   let(:output) do
-    <<-OUTPUT
-/path/to/some.xml:27: Warning: #{rtl_hardcoded}
-    android:drawableLeft="@drawable/ic_cv_media"/>
-    ~~~~~~~~~~~~~~~~~~~~
+    <<~OUTPUT
+      /path/to/some.xml:27: Warning: #{rtl_hardcoded}
+          android:drawableLeft="@drawable/ic_cv_media"/>
+          ~~~~~~~~~~~~~~~~~~~~
 
-/path/to/AndroidManifest.xml: Warning: #{rtl_enabled}
+      /path/to/AndroidManifest.xml: Warning: #{rtl_enabled}
 
-/path/to/library/0.0.2: Error: #{lint_error}
+      /path/to/library/0.0.2: Error: #{lint_error}
 
-/path/to/values.xml:5: Warning: #{unused_quantity}
-    <plurals name="number">
-    ^
+      /path/to/values.xml:5: Warning: #{unused_quantity}
+          <plurals name="number">
+          ^
 
     OUTPUT
   end
@@ -28,7 +31,9 @@ RSpec.describe Gergich::Capture::AndroidlintCapture do
       {
         path: "/path/to/some.xml",
         position: 27,
+        # rubocop:disable Metrics/LineLength
         message: "[androidlint] #{rtl_hardcoded}\n\n    android:drawableLeft=\"@drawable/ic_cv_media\"/>\n    ~~~~~~~~~~~~~~~~~~~~",
+        # rubocop:enable Metrics/LineLength
         severity: "warn"
       },
       {

data/spec/gergich/capture/brakeman_capture_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::BrakemanCapture do
@@ -10,75 +12,75 @@ RSpec.describe Gergich::Capture::BrakemanCapture do
   let(:comments) do
     [
       {
-        path:     "app/models/custom_data.rb",
+        path: "app/models/custom_data.rb",
         position: 36,
-        message:  <<-MESSAGE.strip,
-[brakeman] Attribute Restriction: attr_accessible is recommended over attr_protected
-  See: http://brakemanscanner.org/docs/warning_types/attribute_restriction/
-                  MESSAGE
+        message: <<~MESSAGE.strip,
+          [brakeman] Attribute Restriction: attr_accessible is recommended over attr_protected
+            See: http://brakemanscanner.org/docs/warning_types/attribute_restriction/
+        MESSAGE
         severity: "warn"
       },
       {
-        path:     "app/models/submission_comment.rb",
+        path: "app/models/submission_comment.rb",
         position: 0,
-        message:  <<-MESSAGE.strip,
-[brakeman] Mass Assignment: Potentially dangerous attribute available for mass assignment
-  Code: :context_id
-  See: http://brakemanscanner.org/docs/warning_types/mass_assignment/
-                  MESSAGE
+        message: <<~MESSAGE.strip,
+          [brakeman] Mass Assignment: Potentially dangerous attribute available for mass assignment
+            Code: :context_id
+            See: http://brakemanscanner.org/docs/warning_types/mass_assignment/
+        MESSAGE
         severity: "warn"
       },
       {
-        path:     "app/controllers/context_controller.rb",
+        path: "app/controllers/context_controller.rb",
         position: 60,
-        message:  <<-MESSAGE.strip,
-[brakeman] Redirect: Possible unprotected redirect
-  Code: redirect_to(CanvasKaltura::ClientV3.new.assetSwfUrl(params[:id]))
-  User Input: params[:id]
-  See: http://brakemanscanner.org/docs/warning_types/redirect/
-                  MESSAGE
+        message: <<~MESSAGE.strip,
+          [brakeman] Redirect: Possible unprotected redirect
+            Code: redirect_to(CanvasKaltura::ClientV3.new.assetSwfUrl(params[:id]))
+            User Input: params[:id]
+            See: http://brakemanscanner.org/docs/warning_types/redirect/
+        MESSAGE
         severity: "warn"
       },
       {
-        path:     "app/views/context/object_snippet.html.erb",
+        path: "app/views/context/object_snippet.html.erb",
         position: 6,
-        message:  <<-MESSAGE.strip,
-[brakeman] Cross Site Scripting: Unescaped parameter value
-  Code: Base64.decode64((params[:object_data] or ""))
-  User Input: params[:object_data]
-  See: http://brakemanscanner.org/docs/warning_types/cross_site_scripting
+        message: <<~MESSAGE.strip,
+          [brakeman] Cross Site Scripting: Unescaped parameter value
+            Code: Base64.decode64((params[:object_data] or ""))
+            User Input: params[:object_data]
+            See: http://brakemanscanner.org/docs/warning_types/cross_site_scripting
         MESSAGE
         severity: "warn"
       },
       {
-        path:     "app/models/account.rb",
+        path: "app/models/account.rb",
         position: 795,
-        message:  <<-MESSAGE.strip,
-[brakeman] SQL Injection: Possible SQL injection
-  Code: Account.find_by_sql(Account.sub_account_ids_recursive_sql(parent_account_id))
-  User Input: Account.sub_account_ids_recursive_sql(parent_account_id)
-  See: http://brakemanscanner.org/docs/warning_types/sql_injection/
+        message: <<~MESSAGE.strip,
+          [brakeman] SQL Injection: Possible SQL injection
+            Code: Account.find_by_sql(Account.sub_account_ids_recursive_sql(parent_account_id))
+            User Input: Account.sub_account_ids_recursive_sql(parent_account_id)
+            See: http://brakemanscanner.org/docs/warning_types/sql_injection/
         MESSAGE
         severity: "error"
       },
       {
-        path:     "lib/cc/importer/blti_converter.rb",
+        path: "lib/cc/importer/blti_converter.rb",
         position: 145,
-        message:  <<-MESSAGE.strip,
-[brakeman] SSL Verification Bypass: SSL certificate verification was bypassed
-  Code: Net::HTTP.new(URI.parse(url).host, URI.parse(url).port).verify_mode = OpenSSL::SSL::VERIFY_NONE
-  See: http://brakemanscanner.org/docs/warning_types/ssl_verification_bypass/
+        message: <<~MESSAGE.strip,
+          [brakeman] SSL Verification Bypass: SSL certificate verification was bypassed
+            Code: Net::HTTP.new(URI.parse(url).host, URI.parse(url).port).verify_mode = OpenSSL::SSL::VERIFY_NONE
+            See: http://brakemanscanner.org/docs/warning_types/ssl_verification_bypass/
         MESSAGE
         severity: "error"
       },
       {
-        path:     "lib/cc/importer/canvas/quiz_converter.rb",
+        path: "lib/cc/importer/canvas/quiz_converter.rb",
         position: 44,
-        message:  <<-MESSAGE.strip,
-[brakeman] Command Injection: Possible command injection
-  Code: `\#{Qti.get_conversion_command(File.join(qti_folder, "qti_2_1"), qti_folder)}`
-  User Input: Qti.get_conversion_command(File.join(qti_folder, "qti_2_1"), qti_folder)
-  See: http://brakemanscanner.org/docs/warning_types/command_injection/
+        message: <<~MESSAGE.strip,
+          [brakeman] Command Injection: Possible command injection
+            Code: `\#{Qti.get_conversion_command(File.join(qti_folder, "qti_2_1"), qti_folder)}`
+            User Input: Qti.get_conversion_command(File.join(qti_folder, "qti_2_1"), qti_folder)
+            See: http://brakemanscanner.org/docs/warning_types/command_injection/
         MESSAGE
         severity: "warn"
       }

data/spec/gergich/capture/custom_capture_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../../../lib/gergich/capture"
 
 RSpec.describe "CustomCaptor" do
@@ -12,8 +14,8 @@ RSpec.describe "CustomCaptor" do
   let(:described_class) { CustomCaptor }
   let(:capture_format) { "custom:sqlite3:CustomCaptor" }
   let(:output) do
-    <<-OUTPUT
-foo.rb:1: you done screwed up
+    <<~OUTPUT
+      foo.rb:1: you done screwed up
     OUTPUT
   end
   let(:comments) do

data/spec/gergich/capture/eslint_capture_spec.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::EslintCapture do
   let(:output) do
-    <<-OUTPUT
-jsapp/models/user.js
-  4:21  error    Missing semicolon  semi
-  5:1   warning  Too much cowbell   cowbell-overload
+    <<~OUTPUT
+      jsapp/models/user.js
+        4:21  error    Missing semicolon  semi
+        5:1   warning  Too much cowbell   cowbell-overload
     OUTPUT
   end
   let(:comments) do

data/spec/gergich/capture/flake8_capture_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::Flake8Capture do
   let(:output) do
-    <<-OUTPUT
-./djangogeneric/settings/base.py:73:80: E501 line too long (81 > 79 characters)
+    <<~OUTPUT
+      ./djangogeneric/settings/base.py:73:80: E501 line too long (81 > 79 characters)
     OUTPUT
   end
   let(:comments) do

data/spec/gergich/capture/i18nliner_capture_spec.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::I18nlinerCapture do
   let(:output) do
-    <<-OUTPUT
-1)
-invalid signature on line 4: <unsupported expression>
-jsapp/models/user.js
+    <<~OUTPUT
+      1)
+      invalid signature on line 4: <unsupported expression>
+      jsapp/models/user.js
     OUTPUT
   end
   let(:comments) do

data/spec/gergich/capture/rubocop_capture_spec.rb

@@ -1,22 +1,24 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::RubocopCapture do
   let(:output) do
-    <<-OUTPUT
-Offenses:
+    <<~OUTPUT
+      Offenses:
 
-bin/gergich:47:8: C: Prefer double-quoted strings
-if ENV['DEBUG']
-       ^^^^^^^
-foo/bar/baz.rb:1:2: W: no context for this one :shrug:
-lib/gergich.rb:10:9: E: this is a terrible name
+      bin/gergich:47:8: C: Prefer double-quoted strings
+      if ENV['DEBUG']
+             ^^^^^^^
+      foo/bar/baz.rb:1:2: W: no context for this one :shrug:
+      lib/gergich.rb:10:9: E: this is a terrible name
 
-seriously, what were you thinking?
-    def foo
-        ^^^
-lib/gergich.rb:22:55: W: Line is too long. [55/54]
-    def initialize(ref = "HEAD", revision_number = nil)
-                                                     ^^
+      seriously, what were you thinking?
+          def foo
+              ^^^
+      lib/gergich.rb:22:55: W: Line is too long. [55/54]
+          def initialize(ref = "HEAD", revision_number = nil)
+                                                           ^^
     OUTPUT
   end
   let(:comments) do
@@ -36,24 +38,24 @@ lib/gergich.rb:22:55: W: Line is too long. [55/54]
       {
         path: "lib/gergich.rb",
         position: 10,
-        message: <<-OUTPUT,
-[rubocop] this is a terrible name
+        message: <<~OUTPUT,
+          [rubocop] this is a terrible name
 
-seriously, what were you thinking?
+          seriously, what were you thinking?
 
-     def foo
-         ^^^
+               def foo
+                   ^^^
         OUTPUT
         severity: "error"
       },
       {
         path: "lib/gergich.rb",
         position: 22,
-        message: <<-OUTPUT,
-[rubocop] Line is too long. [55/54]
+        message: <<~OUTPUT,
+          [rubocop] Line is too long. [55/54]
 
-     def initialize(ref = "HEAD", revision_number = nil)
-                                                      ^^
+               def initialize(ref = "HEAD", revision_number = nil)
+                                                                ^^
         OUTPUT
         severity: "warn"
       }

data/spec/gergich/capture/shellcheck_capture_spec.rb

@@ -1,50 +1,52 @@
+# frozen_string_literal: true
+
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::ShellcheckCapture do
   let(:output) do
-    <<-'OUTPUT'
-[
-  {
-    "file": "bin/sync-translations.sh",
-    "line": 23,
-    "endLine": 23,
-    "column": 21,
-    "endColumn": 21,
-    "level": "style",
-    "code": 2006,
-    "message": "Use $(..) instead of legacy `..`."
-  },
-  {
-    "file": "bin/sync-translations.sh",
-    "line": 23,
-    "endLine": 23,
-    "column": 43,
-    "endColumn": 43,
-    "level": "warning",
-    "code": 2046,
-    "message": "Quote this to prevent word splitting."
-  },
-  {
-    "file": "bin/sync-translations.sh",
-    "line": 32,
-    "endLine": 32,
-    "column": 62,
-    "endColumn": 62,
-    "level": "info",
-    "code": 2086,
-    "message": "Double quote to prevent globbing and word splitting."
-  },
-  {
-    "file": "fail.sh",
-    "line": 3,
-    "endLine": 3,
-    "column": 12,
-    "endColumn": 12,
-    "level": "error",
-    "code": 1101,
-    "message": "Delete trailing spaces after \\ to break line (or use quotes for literal space)."
-  }
-]
+    <<~'OUTPUT'
+      [
+        {
+          "file": "bin/sync-translations.sh",
+          "line": 23,
+          "endLine": 23,
+          "column": 21,
+          "endColumn": 21,
+          "level": "style",
+          "code": 2006,
+          "message": "Use $(..) instead of legacy `..`."
+        },
+        {
+          "file": "bin/sync-translations.sh",
+          "line": 23,
+          "endLine": 23,
+          "column": 43,
+          "endColumn": 43,
+          "level": "warning",
+          "code": 2046,
+          "message": "Quote this to prevent word splitting."
+        },
+        {
+          "file": "bin/sync-translations.sh",
+          "line": 32,
+          "endLine": 32,
+          "column": 62,
+          "endColumn": 62,
+          "level": "info",
+          "code": 2086,
+          "message": "Double quote to prevent globbing and word splitting."
+        },
+        {
+          "file": "fail.sh",
+          "line": 3,
+          "endLine": 3,
+          "column": 12,
+          "endColumn": 12,
+          "level": "error",
+          "code": 1101,
+          "message": "Delete trailing spaces after \\ to break line (or use quotes for literal space)."
+        }
+      ]
     OUTPUT
   end