formtastic 3.0.0 → 5.0.0

data/spec/localizer_spec.rb

@@ -1,7 +1,8 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
-describe 'Formtastic::Localizer' do
+RSpec.describe 'Formtastic::Localizer' do
   describe "Cache" do
     before do
       @cache = Formtastic::Localizer::Cache.new
@@ -11,27 +12,27 @@ describe 'Formtastic::Localizer' do
     end
     
     it "should get value" do
-      @cache.get(@key).should == 'value'
-      @cache.get(@undefined_key).should be_nil
+      expect(@cache.get(@key)).to eq('value')
+      expect(@cache.get(@undefined_key)).to be_nil
     end
     
     it "should check if key exists?" do
-      @cache.has_key?(@key).should be_true
-      @cache.has_key?(@undefined_key).should be_false
+      expect(@cache.has_key?(@key)).to be_truthy
+      expect(@cache.has_key?(@undefined_key)).to be_falsey
     end
     
     it "should set a key" do
       @cache.set(['model', 'name2'], 'value2')
-      @cache.get(['model', 'name2']).should == 'value2'
+      expect(@cache.get(['model', 'name2'])).to eq('value2')
     end
     
     it "should return hash" do
-      @cache.cache.should be_an_instance_of(Hash)
+      expect(@cache.cache).to be_an_instance_of(Hash)
     end
     
     it "should clear the cache" do
       @cache.clear!
-      @cache.get(@key).should be_nil
+      expect(@cache.get(@key)).to be_nil
     end
   end
   
@@ -53,11 +54,11 @@ describe 'Formtastic::Localizer' do
     end
     
     it "should be defined" do
-      lambda { Formtastic::Localizer }.should_not raise_error
+      expect { Formtastic::Localizer }.not_to raise_error
     end
     
     it "should have a cache" do
-      Formtastic::Localizer.cache.should be_an_instance_of(Formtastic::Localizer::Cache)
+      expect(Formtastic::Localizer.cache).to be_an_instance_of(Formtastic::Localizer::Cache)
     end
     
     describe "localize" do
@@ -75,19 +76,19 @@ describe 'Formtastic::Localizer' do
       end
 
       it "should translate key with i18n" do
-        @localizer.localize(:name, :name, :label).should == 'POST.NAME'
+        expect(@localizer.localize(:name, :name, :label)).to eq('POST.NAME')
       end
       
       describe "with caching" do
         it "should not update translation when stored translations change" do
           with_config :i18n_cache_lookups, true do
-            @localizer.localize(:name, :name, :label).should == 'POST.NAME'
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NAME')
             store_post_translations('POST.NEW_NAME')
             
-            @localizer.localize(:name, :name, :label).should == 'POST.NAME'       
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NAME')       
             
             Formtastic::Localizer.cache.clear!
-            @localizer.localize(:name, :name, :label).should == 'POST.NEW_NAME'                  
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NEW_NAME')                  
           end
         end        
       end
@@ -95,9 +96,9 @@ describe 'Formtastic::Localizer' do
       describe "without caching" do
         it "should update translation when stored translations change" do
           with_config :i18n_cache_lookups, false do
-            @localizer.localize(:name, :name, :label).should == 'POST.NAME'
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NAME')
             store_post_translations('POST.NEW_NAME')
-            @localizer.localize(:name, :name, :label).should == 'POST.NEW_NAME'            
+            expect(@localizer.localize(:name, :name, :label)).to eq('POST.NEW_NAME')            
           end
         end
       end
@@ -120,7 +121,7 @@ describe 'Formtastic::Localizer' do
         end
 
         it "should translate custom key with i18n" do
-          @localizer.localize(:name, :name, :label).should == 'MESSAGE.NAME'
+          expect(@localizer.localize(:name, :name, :label)).to eq('MESSAGE.NAME')
         end
       end 
     end

data/spec/namespaced_class_finder_spec.rb

@@ -0,0 +1,91 @@
+# encoding: utf-8
+# frozen_string_literal: true
+require 'spec_helper'
+require 'formtastic/namespaced_class_finder'
+
+RSpec.describe Formtastic::NamespacedClassFinder do
+  include FormtasticSpecHelper
+
+  before do
+    stub_const('SearchPath', Module.new)
+  end
+
+  let(:search_path) { [ SearchPath ] }
+  subject(:finder) { Formtastic::NamespacedClassFinder.new(search_path) }
+
+  shared_examples 'Namespaced Class Finder' do
+    subject(:found_class) { finder.find(:custom_class) }
+
+    context 'Input defined in the Object scope' do
+      before do
+        stub_const('CustomClass', Class.new)
+      end
+
+      it { expect(found_class).to be(CustomClass) }
+    end
+
+    context 'Input defined in the search path' do
+      before do
+        stub_const('SearchPath::CustomClass', Class.new)
+      end
+
+      it { expect(found_class).to be(SearchPath::CustomClass) }
+    end
+
+    context 'Input defined both in the Object scope and the search path' do
+      before do
+        stub_const('CustomClass', Class.new)
+        stub_const('SearchPath::CustomClass', Class.new)
+      end
+
+      it { expect(found_class).to be(SearchPath::CustomClass) }
+    end
+
+    context 'Input defined outside the search path' do
+      before do
+        stub_const('Foo', Module.new)
+        stub_const('Foo::CustomClass', Class.new)
+      end
+
+      let(:error) { Formtastic::NamespacedClassFinder::NotFoundError }
+
+      it { expect { found_class }.to raise_error(error) }
+    end
+  end
+
+  context '#finder' do
+    before do
+      allow(Rails.application.config).to receive(:eager_load).and_return(eager_load)
+    end
+
+    context 'when eager_load is on' do
+      let(:eager_load) { true }
+
+      it "finder_method is :find_with_const_defined" do
+        expect(described_class.finder_method).to eq(:find_with_const_defined)
+      end
+
+      it_behaves_like 'Namespaced Class Finder'
+    end
+
+    context 'when eager_load is off' do
+      let(:eager_load) { false }
+
+      it "finder_method is :find_by_trying" do
+        described_class.instance_variable_set(:@finder_method, nil) # clear cache
+        expect(described_class.finder_method).to eq(:find_by_trying)
+      end
+
+      it_behaves_like 'Namespaced Class Finder'
+    end
+  end
+
+  context '#find' do
+    it 'caches calls' do
+      expect(subject).to receive(:resolve).once.and_call_original
+      subject.find(:object)
+      subject.find(:object)
+    end
+  end
+
+end

data/spec/schema.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+ActiveRecord::Schema.define(version: 20170208011723) do
+
+  create_table "posts", force: :cascade do |t|
+    t.integer "author_id",  limit: 4,     null: false
+  end
+
+  create_table "authors", force: :cascade do |t|
+    t.integer "age",   limit: 4,     null: false
+    t.string  "name",  limit: 255,   null: false
+    t.string  "surname",  limit: 255,   null: false
+    t.string  "login", limit: 255
+    t.datetime "created_at"
+    t.datetime "updated_at"
+  end
+
+  #non-rails foreign id convention
+  create_table "legacy_posts", force: :cascade do |t|
+    t.integer "post_author",  limit: 4,     null: false
+  end
+
+end