formtastic 3.0.0 → 5.0.0

data/spec/inputs/string_input_spec.rb

@@ -1,12 +1,13 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
-describe 'string input' do
+RSpec.describe 'string input' do
 
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
 
@@ -16,7 +17,7 @@ describe 'string input' do
         concat(builder.input(:title, :as => :string))
       end)
     end
-    
+
     it_should_have_input_wrapper_with_class(:string)
     it_should_have_input_wrapper_with_class(:input)
     it_should_have_input_wrapper_with_class(:stringish)
@@ -32,28 +33,28 @@ describe 'string input' do
     it_should_apply_custom_input_attributes_when_input_html_provided(:string)
     it_should_apply_custom_for_to_label_when_input_html_id_provided(:string)
     it_should_apply_error_logic_for_input_type(:string)
-    
+
     def input_field_for_method_should_have_maxlength(method, maxlength)
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.input(method))
       end)
-      output_buffer.should have_tag("form li input[@maxlength='#{maxlength}']")
+      expect(output_buffer.to_str).to have_tag("form li input[@maxlength='#{maxlength}']")
     end
 
     describe 'and its a ActiveModel' do
       let(:default_maxlength) { 50 }
 
       before do
-        @new_post.stub(:class).and_return(::PostModel)
+        allow(@new_post).to receive(:class).and_return(::PostModel)
       end
 
       after do
-        @new_post.stub(:class).and_return(::Post)
+        allow(@new_post).to receive(:class).and_return(::Post)
       end
 
       describe 'and validates_length_of was called for the method' do
         def should_have_maxlength(maxlength, options)
-          @new_post.class.should_receive(:validators_on).with(:title).at_least(1).and_return([
+          expect(@new_post.class).to receive(:validators_on).with(:title).at_least(1).and_return([
             active_model_length_validator([:title], options[:options])
           ])
 
@@ -61,32 +62,32 @@ describe 'string input' do
             concat(builder.input(:title))
           end)
 
-          output_buffer.should have_tag("form li input##{@new_post.class.name.underscore}_title[@maxlength='#{maxlength}']")
+          expect(output_buffer.to_str).to have_tag("form li input##{@new_post.class.name.underscore}_title[@maxlength='#{maxlength}']")
         end
 
         it 'should have maxlength if the optional :if or :unless options are not supplied' do
           should_have_maxlength(42, :options => {:maximum => 42})
         end
-        
+
         it 'should have default maxlength if the optional :if condition is not satisifed' do
           should_have_maxlength(default_maxlength, :options => {:maximum => 42, :if => false})
         end
-        
+
         it 'should have default_maxlength if the optional :if proc evaluates to false' do
           should_have_maxlength(default_maxlength, :options => {:maximum => 42, :if => proc { |record| false }})
         end
-        
+
         it 'should have maxlength if the optional :if proc evaluates to true' do
           should_have_maxlength(42, :options => { :maximum => 42, :if => proc { |record| true } })
         end
-        
+
         it 'should have default maxlength if the optional :if with a method name evaluates to false' do
-          @new_post.should_receive(:specify_maxlength).at_least(1).and_return(false)
+          expect(@new_post).to receive(:specify_maxlength).at_least(1).and_return(false)
           should_have_maxlength(default_maxlength, :options => { :maximum => 42, :if => :specify_maxlength })
         end
-        
+
         it 'should have maxlength if the optional :if with a method name evaluates to true' do
-          @new_post.should_receive(:specify_maxlength).at_least(1).and_return(true)
+          expect(@new_post).to receive(:specify_maxlength).at_least(1).and_return(true)
           should_have_maxlength(42, :options => { :maximum => 42, :if => :specify_maxlength })
         end
 
@@ -97,14 +98,14 @@ describe 'string input' do
         it 'should have maxlength if the optional :unless proc evaluates to false' do
           should_have_maxlength(42, :options => { :maximum => 42, :unless => proc { |record| false } })
         end
-        
+
         it 'should have default maxlength if the optional :unless with a method name evaluates to true' do
-          @new_post.should_receive(:specify_maxlength).at_least(1).and_return(true)
+          expect(@new_post).to receive(:specify_maxlength).at_least(1).and_return(true)
           should_have_maxlength(default_maxlength, :options => { :maximum => 42, :unless => :specify_maxlength })
         end
-        
+
         it 'should have maxlength if the optional :unless with a method name evaluates to false' do
-          @new_post.should_receive(:specify_maxlength).at_least(1).and_return(false)
+          expect(@new_post).to receive(:specify_maxlength).at_least(1).and_return(false)
           should_have_maxlength(42, :options => { :maximum => 42, :unless => :specify_maxlength })
         end
       end
@@ -112,8 +113,8 @@ describe 'string input' do
       describe 'any conditional validation' do
         describe 'proc that calls an instance method' do
           it 'calls the method on the object' do
-            @new_post.should_receive(:something?)
-            @new_post.class.should_receive(:validators_on).with(:title).at_least(1).and_return([
+            expect(@new_post).to receive(:something?)
+            expect(@new_post.class).to receive(:validators_on).with(:title).at_least(1).and_return([
               active_model_presence_validator([:title], { :unless => -> { something? } })
             ])
             concat(semantic_form_for(@new_post) do |builder|
@@ -124,8 +125,8 @@ describe 'string input' do
 
         describe 'proc with arity that calls an instance method' do
           it 'calls the method on the object' do
-            @new_post.should_receive(:something?)
-            @new_post.class.should_receive(:validators_on).with(:title).at_least(1).and_return([
+            expect(@new_post).to receive(:something?)
+            expect(@new_post.class).to receive(:validators_on).with(:title).at_least(1).and_return([
               active_model_presence_validator([:title], { :unless => ->(user) { user.something? } })
             ])
             concat(semantic_form_for(@new_post) do |builder|
@@ -136,8 +137,8 @@ describe 'string input' do
 
         describe 'symbol method name' do
           it 'calls the method on the object if the method exists' do
-            @new_post.should_receive(:something?)
-            @new_post.class.should_receive(:validators_on).with(:title).at_least(1).and_return([
+            expect(@new_post).to receive(:something?)
+            expect(@new_post.class).to receive(:validators_on).with(:title).at_least(1).and_return([
               active_model_presence_validator([:title], { :unless => :something? })
             ])
             concat(semantic_form_for(@new_post) do |builder|
@@ -149,7 +150,7 @@ describe 'string input' do
         describe 'any other conditional' do
           it 'does not raise an error' do
             @conditional = double()
-            @new_post.class.should_receive(:validators_on).with(:title).at_least(1).and_return([
+            expect(@new_post.class).to receive(:validators_on).with(:title).at_least(1).and_return([
               active_model_presence_validator([:title], { :unless => @conditional })
             ])
             concat(semantic_form_for(@new_post) do |builder|
@@ -164,22 +165,22 @@ describe 'string input' do
   end
 
   describe "when namespace is provided" do
-  
+
     before do
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
         concat(builder.input(:title, :as => :string))
       end)
     end
-  
+
     it_should_have_input_wrapper_with_id("context2_post_title_input")
     it_should_have_label_and_input_with_id("context2_post_title")
-  
+
   end
-  
+
   describe "when index is provided" do
 
     before do
-      @output_buffer = ''
+      @output_buffer = ActionView::OutputBuffer.new ''
       mock_everything
 
       concat(semantic_form_for(@new_post) do |builder|
@@ -188,57 +189,57 @@ describe 'string input' do
         end)
       end)
     end
-    
+
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer.to_str).to have_tag("li#post_author_attributes_3_name_input")
     end
-    
+
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("input#post_author_attributes_3_name")
+      expect(output_buffer.to_str).to have_tag("input#post_author_attributes_3_name")
     end
-    
+
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("input[@name='post[author_attributes][3][name]']")
+      expect(output_buffer.to_str).to have_tag("input[@name='post[author_attributes][3][name]']")
     end
-    
+
   end
-  
-  
+
+
   describe "when no object is provided" do
     before do
       concat(semantic_form_for(:project, :url => 'http://test.host/') do |builder|
         concat(builder.input(:title, :as => :string))
       end)
     end
-  
+
     it_should_have_label_with_text(/Title/)
     it_should_have_label_for("project_title")
     it_should_have_input_with_id("project_title")
     it_should_have_input_with_type(:text)
     it_should_have_input_with_name("project[title]")
   end
-  
+
   describe "when size is nil" do
     before do
       concat(semantic_form_for(:project, :url => 'http://test.host/') do |builder|
         concat(builder.input(:title, :as => :string, :input_html => {:size => nil}))
       end)
     end
-  
+
     it "should have no size attribute" do
-      output_buffer.should_not have_tag("input[@size]")
+      expect(output_buffer.to_str).not_to have_tag("input[@size]")
     end
   end
-  
+
   describe "when required" do
-    
+
     context "and configured to use HTML5 attribute" do
       it "should add the required attribute to the input's html options" do
         with_config :use_required_attribute, true do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => :string, :required => true))
           end)
-          output_buffer.should have_tag("input[@required]")
+          expect(output_buffer.to_str).to have_tag("input[@required]")
         end
       end
     end
@@ -249,11 +250,11 @@ describe 'string input' do
           concat(semantic_form_for(@new_post) do |builder|
             concat(builder.input(:title, :as => :string, :required => true))
           end)
-          output_buffer.should_not have_tag("input[@required]")
+          expect(output_buffer.to_str).not_to have_tag("input[@required]")
         end
       end
     end
-    
+
   end
 
 end

data/spec/inputs/text_input_spec.rb

@@ -1,12 +1,13 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
-describe 'text input' do
+RSpec.describe 'text input' do
 
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
 
     concat(semantic_form_for(@new_post) do |builder|
@@ -24,50 +25,50 @@ describe 'text input' do
   it_should_apply_error_logic_for_input_type(:number)
 
   it 'should use input_html to style inputs' do
-    output_buffer.replace ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:title, :as => :text, :input_html => { :class => 'myclass' }))
     end)
-    output_buffer.should have_tag("form li textarea.myclass")
+    expect(output_buffer.to_str).to have_tag("form li textarea.myclass")
   end
 
   it "should have a cols attribute when :cols is a number in :input_html" do
-    output_buffer.replace ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:title, :as => :text, :input_html => { :cols => 42 }))
     end)
-    output_buffer.should have_tag("form li textarea[@cols='42']")
+    expect(output_buffer.to_str).to have_tag("form li textarea[@cols='42']")
   end
 
   it "should not have a cols attribute when :cols is nil in :input_html" do
-    output_buffer.replace ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:title, :as => :text, :input_html => { :cols => nil }))
     end)
-    output_buffer.should_not have_tag("form li textarea[@cols]")
+    expect(output_buffer.to_str).not_to have_tag("form li textarea[@cols]")
   end
 
   it "should have a rows attribute when :rows is a number in :input_html" do
-    output_buffer.replace ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:title, :as => :text, :input_html => { :rows => 42 }))
     end)
-    output_buffer.should have_tag("form li textarea[@rows='42']")
+    expect(output_buffer.to_str).to have_tag("form li textarea[@rows='42']")
 
   end
 
   it "should not have a rows attribute when :rows is nil in :input_html" do
-    output_buffer.replace ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     concat(semantic_form_for(@new_post) do |builder|
       concat(builder.input(:title, :as => :text, :input_html => { :rows => nil }))
     end)
-    output_buffer.should_not have_tag("form li textarea[@rows]")
+    expect(output_buffer.to_str).not_to have_tag("form li textarea[@rows]")
   end
 
   describe "when namespace is provided" do
 
     before do
-      @output_buffer = ''
+      @output_buffer = ActionView::OutputBuffer.new ''
       mock_everything
 
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
@@ -80,11 +81,11 @@ describe 'text input' do
     it_should_have_label_for("context2_post_body")
 
   end
-  
+
   describe "when index is provided" do
 
     before do
-      @output_buffer = ''
+      @output_buffer = ActionView::OutputBuffer.new ''
       mock_everything
 
       concat(semantic_form_for(@new_post) do |builder|
@@ -93,34 +94,34 @@ describe 'text input' do
         end)
       end)
     end
-    
+
     it 'should index the id of the wrapper' do
-      output_buffer.should have_tag("li#post_author_attributes_3_name_input")
+      expect(output_buffer.to_str).to have_tag("li#post_author_attributes_3_name_input")
     end
-    
+
     it 'should index the id of the select tag' do
-      output_buffer.should have_tag("textarea#post_author_attributes_3_name")
+      expect(output_buffer.to_str).to have_tag("textarea#post_author_attributes_3_name")
     end
-    
+
     it 'should index the name of the select tag' do
-      output_buffer.should have_tag("textarea[@name='post[author_attributes][3][name]']")
+      expect(output_buffer.to_str).to have_tag("textarea[@name='post[author_attributes][3][name]']")
     end
-    
+
   end
-  
+
   context "when required" do
     it "should add the required attribute to the input's html options" do
-      with_config :use_required_attribute, true do 
+      with_config :use_required_attribute, true do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :text, :required => true))
         end)
-        output_buffer.should have_tag("textarea[@required]")
+        expect(output_buffer.to_str).to have_tag("textarea[@required]")
       end
     end
   end
 
   context "when :autofocus is provided in :input_html" do
-    before(:each) do
+    before(:example) do
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.input(:title, :input_html => {:autofocus => true}))
       end)
@@ -129,13 +130,13 @@ describe 'text input' do
     it_should_have_input_wrapper_with_class("autofocus")
 
     it "should add the autofocus attribute to the input's html options" do
-      output_buffer.should have_tag("input[@autofocus]")
+      expect(output_buffer.to_str).to have_tag("input[@autofocus]")
     end
   end
 
   context "when :rows is missing in :input_html" do
     before do
-      output_buffer.replace ''
+      @output_buffer = ActionView::OutputBuffer.new ''
     end
 
     it "should have a rows attribute matching default_text_area_height if numeric" do
@@ -143,7 +144,7 @@ describe 'text input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :text))
         end)
-        output_buffer.should have_tag("form li textarea[@rows='12']")
+        expect(output_buffer.to_str).to have_tag("form li textarea[@rows='12']")
       end
     end
 
@@ -152,7 +153,7 @@ describe 'text input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :text))
         end)
-        output_buffer.should_not have_tag("form li textarea[@rows]")
+        expect(output_buffer.to_str).not_to have_tag("form li textarea[@rows]")
       end
 
     end
@@ -160,7 +161,7 @@ describe 'text input' do
 
   context "when :cols is missing in :input_html" do
     before do
-      output_buffer.replace ''
+      @output_buffer = ActionView::OutputBuffer.new ''
     end
 
     it "should have a cols attribute matching default_text_area_width if numeric" do
@@ -168,7 +169,7 @@ describe 'text input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :text))
         end)
-        output_buffer.should have_tag("form li textarea[@cols='10']")
+        expect(output_buffer.to_str).to have_tag("form li textarea[@cols='10']")
       end
     end
 
@@ -177,7 +178,7 @@ describe 'text input' do
         concat(semantic_form_for(@new_post) do |builder|
           concat(builder.input(:title, :as => :text))
         end)
-        output_buffer.should_not have_tag("form li textarea[@cols]")
+        expect(output_buffer.to_str).not_to have_tag("form li textarea[@cols]")
       end
 
     end