formtastic 3.0.0 → 5.0.0

data/spec/actions/link_action_spec.rb

@@ -1,92 +1,93 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
-describe 'LinkAction', 'when cancelling' do
+RSpec.describe 'LinkAction', 'when cancelling' do
 
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
-  
+
   context 'without a :url' do
     before do
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:cancel, :as => :link))
       end)
     end
-    
+
     it 'should render a submit type of input' do
-      output_buffer.should have_tag('li.action.link_action a[@href="javascript:history.back()"]')
+      expect(output_buffer.to_str).to have_tag('li.action.link_action a[@href="javascript:history.back()"]')
     end
-    
+
   end
-  
+
   context 'with a :url as String' do
-    
+
     before do
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:cancel, :as => :link, :url => "http://foo.bah/baz"))
       end)
     end
-    
+
     it 'should render a submit type of input' do
-      output_buffer.should have_tag('li.action.link_action a[@href="http://foo.bah/baz"]')
+      expect(output_buffer.to_str).to have_tag('li.action.link_action a[@href="http://foo.bah/baz"]')
     end
-    
+
   end
 
   context 'with a :url as Hash' do
-    
+
     before do
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:cancel, :as => :link, :url => { :action => "foo" }))
       end)
     end
-    
+
     it 'should render a submit type of input' do
-      output_buffer.should have_tag('li.action.link_action a[@href="/mock/path"]')
+      expect(output_buffer.to_str).to have_tag('li.action.link_action a[@href="/mock/path"]')
     end
-    
+
   end
 
 end
 
-describe 'LinkAction', 'when submitting' do
+RSpec.describe 'LinkAction', 'when submitting' do
 
   include FormtasticSpecHelper
-  
+
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
-  
+
   it 'should raise an error' do
-    lambda { 
+    expect {
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:submit, :as => :link))
       end)
-    }.should raise_error(Formtastic::UnsupportedMethodForAction)
+    }.to raise_error(Formtastic::UnsupportedMethodForAction)
   end
-  
+
 end
 
-describe 'LinkAction', 'when submitting' do
+RSpec.describe 'LinkAction', 'when submitting' do
 
   include FormtasticSpecHelper
-  
+
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
-  
+
   it 'should raise an error' do
-    lambda { 
+    expect {
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.action(:reset, :as => :link))
       end)
-    }.should raise_error(Formtastic::UnsupportedMethodForAction)
+    }.to raise_error(Formtastic::UnsupportedMethodForAction)
   end
-  
+
 end

data/spec/builder/custom_builder_spec.rb

@@ -1,13 +1,14 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
-describe 'Formtastic::Helpers::FormHelper.builder' do
+RSpec.describe 'Formtastic::Helpers::FormHelper.builder' do
 
   include FormtasticSpecHelper
 
   class MyCustomFormBuilder < Formtastic::FormBuilder
   end
-  
+
   # TODO should be a separate spec for custom inputs
   class Formtastic::Inputs::AwesomeInput
     include Formtastic::Inputs::Base
@@ -17,37 +18,37 @@ describe 'Formtastic::Helpers::FormHelper.builder' do
   end
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
 
   it 'is the Formtastic::FormBuilder by default' do
-    Formtastic::Helpers::FormHelper.builder.should == Formtastic::FormBuilder
+    expect(Formtastic::Helpers::FormHelper.builder).to eq(Formtastic::FormBuilder)
   end
 
   it 'can be configured to use your own custom form builder' do
     # Set it to a custom builder class
     Formtastic::Helpers::FormHelper.builder = MyCustomFormBuilder
-    Formtastic::Helpers::FormHelper.builder.should == MyCustomFormBuilder
+    expect(Formtastic::Helpers::FormHelper.builder).to eq(MyCustomFormBuilder)
 
     # Reset it to the default
     Formtastic::Helpers::FormHelper.builder = Formtastic::FormBuilder
-    Formtastic::Helpers::FormHelper.builder.should == Formtastic::FormBuilder
+    expect(Formtastic::Helpers::FormHelper.builder).to eq(Formtastic::FormBuilder)
   end
 
   it 'should allow custom settings per form builder subclass' do
     with_config(:all_fields_required_by_default, true) do
       MyCustomFormBuilder.all_fields_required_by_default = false
 
-      MyCustomFormBuilder.all_fields_required_by_default.should be_false
-      Formtastic::FormBuilder.all_fields_required_by_default.should be_true
+      expect(MyCustomFormBuilder.all_fields_required_by_default).to be_falsey
+      expect(Formtastic::FormBuilder.all_fields_required_by_default).to be_truthy
     end
   end
 
   describe "when using a custom builder" do
 
     before do
-      @new_post.stub(:title)
+      allow(@new_post).to receive(:title)
       Formtastic::Helpers::FormHelper.builder = MyCustomFormBuilder
     end
 
@@ -59,10 +60,10 @@ describe 'Formtastic::Helpers::FormHelper.builder' do
 
       it "should yield an instance of the custom builder" do
         semantic_form_for(@new_post) do |builder|
-          builder.class.should.kind_of?(MyCustomFormBuilder)
+          expect(builder.class).to be(MyCustomFormBuilder)
         end
       end
-      
+
       # TODO should be a separate spec for custom inputs
       it "should allow me to call my custom input" do
         semantic_form_for(@new_post) do |builder|
@@ -70,31 +71,47 @@ describe 'Formtastic::Helpers::FormHelper.builder' do
         end
       end
 
-      # See: https://github.com/justinfrench/formtastic/issues/657
+      # See: https://github.com/formtastic/formtastic/issues/657
       it "should not conflict with navigasmic" do
-        self.class.any_instance.stub(:builder).and_return('navigasmic')
-        
-        lambda { semantic_form_for(@new_post) { |f| } }.should_not raise_error
+        allow_any_instance_of(self.class).to receive(:builder).and_return('navigasmic')
+
+        expect { semantic_form_for(@new_post) { |f| } }.not_to raise_error
       end
 
+      it "should use the custom builder's skipped_columns config for inputs" do
+        class AnotherCustomFormBuilder < Formtastic::FormBuilder
+          configure :skipped_columns, [:title, :created_at]
+        end
+        #AnotherCustomFormBuilder.skipped_columns = [:title, :created_at]
+
+        concat(semantic_form_for(@new_post, builder: AnotherCustomFormBuilder) do |builder|
+          concat(builder.inputs)
+        end)
+
+        expect(output_buffer.to_str).to_not have_tag('input#post_title')
+        expect(output_buffer.to_str).to_not have_tag('li#post_created_at_input')
+        expect(output_buffer.to_str).to have_tag('textarea#post_body')
+      end
     end
 
     describe "fields_for" do
 
       it "should yield an instance of the parent form builder" do
-        @new_post.stub(:comment).and_return([@fred])
-        @new_post.stub(:comment_attributes=)
+        allow(@new_post).to receive(:comment).and_return([@fred])
+        allow(@new_post).to receive(:comment_attributes=)
         semantic_form_for(@new_post, :builder => MyCustomFormBuilder) do |builder|
-          builder.class.should.kind_of?(MyCustomFormBuilder)
-          
+          expect(builder.class).to be(MyCustomFormBuilder)
+
           builder.fields_for(:comment) do |nested_builder|
-            nested_builder.class.should.kind_of?(MyCustomFormBuilder)
+            expect(nested_builder.class).to be(MyCustomFormBuilder)
           end
         end
       end
 
     end
 
+
+
   end
 
   describe "when using a builder passed to form options" do
@@ -102,10 +119,10 @@ describe 'Formtastic::Helpers::FormHelper.builder' do
     describe "fields_for" do
 
       it "should yield an instance of the parent form builder" do
-        @new_post.stub(:author_attributes=)
+        allow(@new_post).to receive(:author_attributes=)
         semantic_form_for(@new_post, :builder => MyCustomFormBuilder) do |builder|
           builder.fields_for(:author) do |nested_builder|
-            nested_builder.class.should.kind_of?(MyCustomFormBuilder)
+            expect(nested_builder.class).to be(MyCustomFormBuilder)
           end
         end
       end

data/spec/builder/error_proc_spec.rb

@@ -1,12 +1,13 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
-describe 'Rails field_error_proc' do
+RSpec.describe 'Rails field_error_proc' do
 
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
   end
 
@@ -14,13 +15,13 @@ describe 'Rails field_error_proc' do
     current_field_error_proc = ::ActionView::Base.field_error_proc
 
     semantic_form_for(@new_post) do |builder|
-      ::ActionView::Base.field_error_proc.should_not == current_field_error_proc
+      expect(::ActionView::Base.field_error_proc).not_to eq(current_field_error_proc)
     end
 
-    ::ActionView::Base.field_error_proc.should == current_field_error_proc
+    expect(::ActionView::Base.field_error_proc).to eq(current_field_error_proc)
 
     form_for(@new_post) do |builder|
-      ::ActionView::Base.field_error_proc.should == current_field_error_proc
+      expect(::ActionView::Base.field_error_proc).to eq(current_field_error_proc)
     end
   end
 

data/spec/builder/semantic_fields_for_spec.rb

@@ -1,127 +1,128 @@
 # encoding: utf-8
+# frozen_string_literal: true
 require 'spec_helper'
 
-describe 'Formtastic::FormBuilder#fields_for' do
+RSpec.describe 'Formtastic::FormBuilder#fields_for' do
 
   include FormtasticSpecHelper
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     mock_everything
-    @new_post.stub(:author).and_return(::Author.new)
+    allow(@new_post).to receive(:author).and_return(::Author.new)
   end
 
   context 'outside a form_for block' do
     it 'yields an instance of FormHelper.builder' do
       semantic_fields_for(@new_post) do |nested_builder|
-        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
       semantic_fields_for(@new_post.author) do |nested_builder|
-        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
       semantic_fields_for(:author, @new_post.author) do |nested_builder|
-        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
       semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
-        nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+        expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
       end
     end
-    
+
     it 'should respond to input' do
       semantic_fields_for(@new_post) do |nested_builder|
-        nested_builder.respond_to?(:input).should be_true
+        expect(nested_builder.respond_to?(:input)).to be_truthy
       end
       semantic_fields_for(@new_post.author) do |nested_builder|
-        nested_builder.respond_to?(:input).should be_true
+        expect(nested_builder.respond_to?(:input)).to be_truthy
       end
       semantic_fields_for(:author, @new_post.author) do |nested_builder|
-        nested_builder.respond_to?(:input).should be_true
+        expect(nested_builder.respond_to?(:input)).to be_truthy
       end
       semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
-        nested_builder.respond_to?(:input).should be_true
+        expect(nested_builder.respond_to?(:input)).to be_truthy
       end
     end
   end
-  
+
   context 'within a form_for block' do
     it 'yields an instance of FormHelper.builder' do
       semantic_form_for(@new_post) do |builder|
         builder.semantic_fields_for(:author) do |nested_builder|
-          nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+          expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
         end
       end
     end
-    
+
     it 'yields an instance of FormHelper.builder with hash-like model' do
       semantic_form_for(:user) do |builder|
         builder.semantic_fields_for(:author, @hash_backed_author) do |nested_builder|
-          nested_builder.class.should == Formtastic::Helpers::FormHelper.builder
+          expect(nested_builder.class).to eq(Formtastic::Helpers::FormHelper.builder)
         end
       end
     end
-    
+
     it 'nests the object name' do
       semantic_form_for(@new_post) do |builder|
         builder.semantic_fields_for(@bob) do |nested_builder|
-          nested_builder.object_name.should == 'post[author]'
+          expect(nested_builder.object_name).to eq('post[author]')
         end
       end
     end
-    
+
     it 'supports passing collection as second parameter' do
       semantic_form_for(@new_post) do |builder|
         builder.semantic_fields_for(:author, [@fred,@bob]) do |nested_builder|
-          nested_builder.object_name.should =~ /post\[author_attributes\]\[\d+\]/
+          expect(nested_builder.object_name).to match(/post\[author_attributes\]\[\d+\]/)
         end
       end
     end
-    
+
     it 'should sanitize html id for li tag' do
-      @bob.stub(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
+      allow(@bob).to receive(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
       concat(semantic_form_for(@new_post) do |builder|
         concat(builder.semantic_fields_for(@bob, :index => 1) do |nested_builder|
           concat(nested_builder.inputs(:login))
         end)
       end)
-      output_buffer.should have_tag('form fieldset.inputs #post_author_1_login_input')
+      expect(output_buffer.to_str).to have_tag('form fieldset.inputs #post_author_1_login_input')
       # Not valid selector, so using good ol' regex
-      output_buffer.should_not =~ /id="post\[author\]_1_login_input"/
+      expect(output_buffer.to_str).not_to match(/id="post\[author\]_1_login_input"/)
       # <=> output_buffer.should_not have_tag('form fieldset.inputs #post[author]_1_login_input')
     end
-    
+
     it 'should use namespace provided in nested fields' do
-      @bob.stub(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
+      allow(@bob).to receive(:column_for_attribute).and_return(double('column', :type => :string, :limit => 255))
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
         concat(builder.semantic_fields_for(@bob, :index => 1) do |nested_builder|
           concat(nested_builder.inputs(:login))
         end)
       end)
-      output_buffer.should have_tag('form fieldset.inputs #context2_post_author_1_login_input')
+      expect(output_buffer.to_str).to have_tag('form fieldset.inputs #context2_post_author_1_login_input')
     end
-    
+
     it 'should render errors on the nested inputs' do
       @errors = double('errors')
-      @errors.stub(:[]).with(errors_matcher(:login)).and_return(['oh noes'])      
-      @bob.stub(:errors).and_return(@errors)
-      
+      allow(@errors).to receive(:[]).with(errors_matcher(:login)).and_return(['oh noes'])
+      allow(@bob).to receive(:errors).and_return(@errors)
+
       concat(semantic_form_for(@new_post, :namespace => 'context2') do |builder|
         concat(builder.semantic_fields_for(@bob) do |nested_builder|
           concat(nested_builder.inputs(:login))
         end)
       end)
-      output_buffer.should =~ /oh noes/
+      expect(output_buffer.to_str).to match(/oh noes/)
     end
-    
+
   end
-  
-  context "when I rendered my own hidden id input" do 
-    
+
+  context "when I rendered my own hidden id input" do
+
     before do
-      output_buffer.replace ''
-      
-      @fred.posts.size.should == 1
-      @fred.posts.first.stub(:persisted?).and_return(true)
-      @fred.stub(:posts_attributes=)
+      @output_buffer = ActionView::OutputBuffer.new ''
+
+      expect(@fred.posts.size).to eq(1)
+      allow(@fred.posts.first).to receive(:persisted?).and_return(true)
+      allow(@fred).to receive(:posts_attributes=)
       concat(semantic_form_for(@fred) do |builder|
         concat(builder.semantic_fields_for(:posts) do |nested_builder|
           concat(nested_builder.input(:id, :as => :hidden))
@@ -129,13 +130,13 @@ describe 'Formtastic::FormBuilder#fields_for' do
         end)
       end)
     end
-  
+
     it "should only render one hidden input (my one)" do
-      output_buffer.should have_tag 'input#author_posts_attributes_0_id', :count => 1
+      expect(output_buffer.to_str).to have_tag 'input#author_posts_attributes_0_id', :count => 1
     end
-    
+
     it "should render the hidden input inside an li.hidden" do
-      output_buffer.should have_tag 'li.hidden input#author_posts_attributes_0_id'
+      expect(output_buffer.to_str).to have_tag 'li.hidden input#author_posts_attributes_0_id'
     end
   end
 

data/spec/fast_spec_helper.rb

@@ -0,0 +1,13 @@
+# encoding: utf-8
+# frozen_string_literal: true
+$LOAD_PATH << 'lib/formtastic'
+require 'active_support/all'
+require 'localized_string'
+require 'inputs'
+require 'helpers'
+
+class MyInput
+  include Formtastic::Inputs::Base
+end
+
+I18n.enforce_available_locales = false if I18n.respond_to?(:enforce_available_locales)

data/spec/generators/formtastic/form/form_generator_spec.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 # Generators are not automatically loaded by Rails
 require 'generators/formtastic/form/form_generator'
 
-describe Formtastic::FormGenerator do
+RSpec.describe Formtastic::FormGenerator do
 
   include FormtasticSpecHelper
 
@@ -11,30 +12,30 @@ describe Formtastic::FormGenerator do
   destination File.expand_path("../../../../../tmp", __FILE__)
 
   before do
-    @output_buffer = ''
+    @output_buffer = ActionView::OutputBuffer.new ''
     prepare_destination
     mock_everything
-    ::Post.stub(:reflect_on_all_associations).with(:belongs_to).and_return([
+    allow(::Post).to receive(:reflect_on_all_associations).with(:belongs_to).and_return([
       double('reflection', :name => :author, :options => {}, :klass => ::Author, :macro => :belongs_to),
       double('reflection', :name => :reviewer, :options => {:class_name => 'Author'}, :klass => ::Author, :macro => :belongs_to),
       double('reflection', :name => :main_post, :options => {}, :klass => ::Post, :macro => :belongs_to),
       double('reflection', :name => :attachment, :options => {:polymorphic => true}, :macro => :belongs_to),
     ])
   end
-  
+
   after do
     FileUtils.rm_rf(File.expand_path("../../../../../tmp", __FILE__))
   end
 
   describe 'without model' do
     it 'should raise Thor::RequiredArgumentMissingError' do
-      lambda { run_generator }.should raise_error(Thor::RequiredArgumentMissingError)
+      expect { run_generator }.to raise_error(Thor::RequiredArgumentMissingError)
     end
   end
 
   describe 'with existing model' do
     it 'should not raise an exception' do
-      lambda { run_generator %w(Post) }.should_not raise_error
+      expect { run_generator %w(Post) }.not_to raise_error
     end
   end
 
@@ -43,10 +44,10 @@ describe Formtastic::FormGenerator do
 
     describe 'render only the specified attributes' do
       subject { file('app/views/posts/_form.html.erb') }
-      it { should exist }
-      it { should contain "<%= f.input :title %>" }
-      it { should contain "<%= f.input :author %>" }
-      it { should_not contain "<%= f.input :main_post %>" }
+      it { is_expected.to exist }
+      it { is_expected.to contain "<%= f.input :title %>" }
+      it { is_expected.to contain "<%= f.input :author %>" }
+      it { is_expected.not_to contain "<%= f.input :main_post %>" }
     end
   end
 
@@ -56,17 +57,17 @@ describe Formtastic::FormGenerator do
     subject { file('app/views/posts/_form.html.erb') }
 
     describe 'content_columns' do
-      it { should contain "<%= f.input :title %>" }
-      it { should contain "<%= f.input :body %>" }
-      it { should_not contain "<%= f.input :created_at %>" }
-      it { should_not contain "<%= f.input :updated_at %>" }
+      it { is_expected.to contain "<%= f.input :title %>" }
+      it { is_expected.to contain "<%= f.input :body %>" }
+      it { is_expected.not_to contain "<%= f.input :created_at %>" }
+      it { is_expected.not_to contain "<%= f.input :updated_at %>" }
     end
 
     describe 'reflection_on_association' do
-      it { should contain "<%= f.input :author %>" }
-      it { should contain "<%= f.input :reviewer %>" }
-      it { should contain "<%= f.input :main_post %>" }
-      it { should_not contain "<%= f.input :attachment %>" }
+      it { is_expected.to contain "<%= f.input :author %>" }
+      it { is_expected.to contain "<%= f.input :reviewer %>" }
+      it { is_expected.to contain "<%= f.input :main_post %>" }
+      it { is_expected.not_to contain "<%= f.input :attachment %>" }
     end
   end
 
@@ -76,28 +77,28 @@ describe Formtastic::FormGenerator do
 
       describe 'app/views/posts/_form.html.erb' do
         subject { file('app/views/posts/_form.html.erb') }
-        it { should exist }
-        it { should contain "<%= semantic_form_for @post do |f| %>" }
+        it { is_expected.to exist }
+        it { is_expected.to contain "<%= semantic_form_for @post do |f| %>" }
       end
     end
 
     describe 'haml' do
-      
+
       describe 'app/views/posts/_form.html.haml' do
         before { run_generator %w(Post --template-engine haml) }
         subject { file('app/views/posts/_form.html.haml') }
-        it { should exist }
-        it { should contain "= semantic_form_for @post do |f|" }
+        it { is_expected.to exist }
+        it { is_expected.to contain "= semantic_form_for @post do |f|" }
       end
-      
+
       context 'with copy option' do
         describe 'app/views/posts/_form.html.haml' do
           before { run_generator %w(Post --copy --template-engine haml) }
           subject { file('app/views/posts/_form.html.haml') }
-          it { should_not exist }
+          it { is_expected.not_to exist }
         end
       end
-      
+
     end
 
     describe 'slim' do
@@ -105,18 +106,18 @@ describe Formtastic::FormGenerator do
 
       describe 'app/views/posts/_form.html.slim' do
         subject { file('app/views/posts/_form.html.slim') }
-        it { should exist }
-        it { should contain "= semantic_form_for @post do |f|" }
+        it { is_expected.to exist }
+        it { is_expected.to contain "= semantic_form_for @post do |f|" }
       end
     end
   end
-  
+
   describe 'with copy option' do
     before { run_generator %w(Post --copy) }
-  
+
     describe 'app/views/posts/_form.html.erb' do
       subject { file('app/views/posts/_form.html.erb') }
-      it { should_not exist }
+      it { is_expected.not_to exist }
     end
   end
 
@@ -125,7 +126,7 @@ describe Formtastic::FormGenerator do
 
     describe 'app/views/admin/posts/_form.html.erb' do
       subject { file('app/views/admin/posts/_form.html.erb') }
-      it { should exist }
+      it { is_expected.to exist }
     end
   end
 end