foreman_remote_execution 9.0.1 → 10.0.0

data/webpack/JobWizard/steps/ReviewDetails/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-lines */
 import React, { useEffect, useState } from 'react';
 import {
   Button,
@@ -5,12 +6,12 @@ import {
   DescriptionListTerm,
   DescriptionListGroup,
   DescriptionListDescription,
+  WizardContextConsumer,
 } from '@patternfly/react-core';
 import PropTypes from 'prop-types';
 import { useDispatch, useSelector } from 'react-redux';
-import EllipsisWithTooltip from 'react-ellipsis-with-tooltip';
 import { get } from 'foremanReact/redux/API';
-import { translate as __, sprintf } from 'foremanReact/common/I18n';
+import { translate as __ } from 'foremanReact/common/I18n';
 import {
   selectJobTemplates,
   selectHosts,
@@ -22,9 +23,12 @@ import {
   HOSTS_API,
   HOSTS_TO_PREVIEW_AMOUNT,
   WIZARD_TITLES,
+  SCHEDULE_TYPES,
 } from '../../JobWizardConstants';
 import { buildHostQuery } from '../HostsAndInputs/buildHostQuery';
 import { WizardTitle } from '../form/WizardTitle';
+import { parseEnd, parseRepeat } from './helpers';
+import { HostPreviewModal } from '../HostsAndInputs/HostPreviewModal';
 
 const ReviewDetails = ({
   jobCategory,
@@ -34,7 +38,20 @@ const ReviewDetails = ({
   templateValues,
   selectedTargets,
   hostsSearchQuery,
+  goToStepByName,
 }) => {
+  // eslint-disable-next-line react/prop-types
+  const StepButton = ({ stepName, children }) => (
+    <Button
+      variant="link"
+      isInline
+      onClick={() => {
+        goToStepByName(stepName);
+      }}
+    >
+      {children}
+    </Button>
+  );
   const dispatch = useDispatch();
   useEffect(() => {
     dispatch(
@@ -58,6 +75,7 @@ const ReviewDetails = ({
   const hosts = useSelector(selectHosts);
 
   const hostsCount = useSelector(selectHostCount);
+  const [hostPreviewOpen, setHostPreviewOpen] = useState(false);
   const stringHosts = () => {
     if (hosts.length === 0) {
       return __('No Target Hosts');
@@ -65,22 +83,57 @@ const ReviewDetails = ({
     if (hosts.length === 1 || hosts.length === 2) {
       return hosts.join(', ');
     }
-    return `${hosts[0]}, ${hosts[1]} ${sprintf(
-      __(', and %s more'),
-      hostsCount - 2
-    )}`;
+    return (
+      <div>
+        {hostsCount} {__('hosts')}{' '}
+        <Button
+          variant="link"
+          isInline
+          onClick={() => setHostPreviewOpen(true)}
+        >
+          {__('view host names')}
+        </Button>
+      </div>
+    );
   };
   const [isAdvancedShown, setIsAdvancedShown] = useState(false);
   const detailsFirstHalf = [
-    { label: __('Job category'), value: jobCategory },
-    { label: __('Job template'), value: jobTemplate },
-    { label: __('Target hosts'), value: stringHosts() },
+    {
+      label: (
+        <StepButton stepName={WIZARD_TITLES.categoryAndTemplate}>
+          {__('Job category')}
+        </StepButton>
+      ),
+      value: jobCategory,
+    },
+    {
+      label: (
+        <StepButton stepName={WIZARD_TITLES.categoryAndTemplate}>
+          {__('Job template')}
+        </StepButton>
+      ),
+      value: jobTemplate,
+    },
+    {
+      label: (
+        <StepButton stepName={WIZARD_TITLES.hostsAndInputs}>
+          {__('Target hosts')}
+        </StepButton>
+      ),
+      value: stringHosts(),
+    },
     ...templateInputs.map(({ name }) => ({
-      label: name,
+      label: (
+        <StepButton stepName={WIZARD_TITLES.hostsAndInputs}>{name}</StepButton>
+      ),
       value: templateValues[name],
     })),
     {
-      label: __('Advanced fields'),
+      label: (
+        <StepButton stepName={WIZARD_TITLES.advanced}>
+          {__('Advanced fields')}
+        </StepButton>
+      ),
       value: isAdvancedShown ? (
         <Button
           variant="link"
@@ -107,15 +160,98 @@ const ReviewDetails = ({
 
   const detailsSecondHalf = [
     {
-      label: __('Schedule type'),
+      label: (
+        <StepButton stepName={WIZARD_TITLES.typeOfExecution}>
+          {__('Schedule type')}
+        </StepButton>
+      ),
       value: scheduleValue.scheduleType,
     },
     {
-      label: __('Recurrence'),
+      label: (
+        <StepButton
+          stepName={
+            scheduleValue.scheduleType === SCHEDULE_TYPES.RECURRING
+              ? SCHEDULE_TYPES.RECURRING
+              : WIZARD_TITLES.typeOfExecution
+          }
+        >
+          {__('Recurrence')}
+        </StepButton>
+      ),
       value: scheduleValue.repeatType,
     },
+    scheduleValue.scheduleType === SCHEDULE_TYPES.FUTURE &&
+      scheduleValue.startsAt && {
+        label: (
+          <StepButton
+            stepName={
+              scheduleValue.scheduleType === SCHEDULE_TYPES.RECURRING
+                ? SCHEDULE_TYPES.RECURRING
+                : SCHEDULE_TYPES.FUTURE
+            }
+          >
+            {__('Starts at')}
+          </StepButton>
+        ),
+        value: new Date(scheduleValue.startsAt).toString(),
+      },
+    scheduleValue.scheduleType === SCHEDULE_TYPES.FUTURE &&
+      scheduleValue.startsBefore && {
+        label: (
+          <StepButton stepName={SCHEDULE_TYPES.FUTURE}>
+            {__('Starts Before')}
+          </StepButton>
+        ),
+        value: new Date(scheduleValue.startsBefore).toString(),
+      },
+
+    scheduleValue.scheduleType === SCHEDULE_TYPES.RECURRING && {
+      label: (
+        <StepButton stepName={SCHEDULE_TYPES.RECURRING}>
+          {__('Starts')}
+        </StepButton>
+      ),
+      value: scheduleValue.isFuture
+        ? new Date(scheduleValue.startsAt).toString()
+        : __('Now'),
+    },
+
+    scheduleValue.scheduleType === SCHEDULE_TYPES.RECURRING && {
+      label: (
+        <StepButton stepName={SCHEDULE_TYPES.RECURRING}>
+          {__('Repeats')}
+        </StepButton>
+      ),
+      value: parseRepeat(scheduleValue.repeatType, scheduleValue.repeatData),
+    },
+    scheduleValue.scheduleType === SCHEDULE_TYPES.RECURRING && {
+      label: (
+        <StepButton stepName={SCHEDULE_TYPES.RECURRING}>
+          {__('Ends')}
+        </StepButton>
+      ),
+      value: parseEnd(
+        scheduleValue.ends,
+        scheduleValue.isNeverEnds,
+        scheduleValue.repeatAmount
+      ),
+    },
+
+    scheduleValue.scheduleType === SCHEDULE_TYPES.RECURRING && {
+      label: (
+        <StepButton stepName={SCHEDULE_TYPES.RECURRING}>
+          {__('Purpose')}
+        </StepButton>
+      ),
+      value: scheduleValue.purpose,
+    },
     {
-      label: __('Type of query'),
+      label: (
+        <StepButton stepName={WIZARD_TITLES.typeOfExecution}>
+          {__('Type of query')}
+        </StepButton>
+      ),
       value: scheduleValue.isTypeStatic
         ? __('Static query')
         : __('Dynamic query'),
@@ -144,6 +280,11 @@ const ReviewDetails = ({
 
   return (
     <>
+      <HostPreviewModal
+        isOpen={hostPreviewOpen}
+        setIsOpen={setHostPreviewOpen}
+        searchQuery={buildHostQuery(selectedTargets, hostsSearchQuery)}
+      />
       <WizardTitle
         title={WIZARD_TITLES.review}
         className="advanced-fields-title"
@@ -153,7 +294,7 @@ const ReviewDetails = ({
           <DescriptionListGroup key={index}>
             <DescriptionListTerm>{label}</DescriptionListTerm>
             <DescriptionListDescription>
-              <EllipsisWithTooltip>{value || ''}</EllipsisWithTooltip>
+              {value || ''}
             </DescriptionListDescription>
           </DescriptionListGroup>
         ))}
@@ -162,7 +303,7 @@ const ReviewDetails = ({
             <DescriptionListGroup key={index} className="advanced-fields">
               <DescriptionListTerm>{label}</DescriptionListTerm>
               <DescriptionListDescription>
-                <EllipsisWithTooltip>{value || ''}</EllipsisWithTooltip>
+                {value || ''}
               </DescriptionListDescription>
             </DescriptionListGroup>
           ))}
@@ -170,7 +311,7 @@ const ReviewDetails = ({
           <DescriptionListGroup key={index}>
             <DescriptionListTerm>{label}</DescriptionListTerm>
             <DescriptionListDescription>
-              <EllipsisWithTooltip>{value || ''}</EllipsisWithTooltip>
+              {value || ''}
             </DescriptionListDescription>
           </DescriptionListGroup>
         ))}
@@ -187,7 +328,17 @@ ReviewDetails.propTypes = {
   templateValues: PropTypes.object.isRequired,
   selectedTargets: PropTypes.object.isRequired,
   hostsSearchQuery: PropTypes.string.isRequired,
+  goToStepByName: PropTypes.func.isRequired,
 };
 
 ReviewDetails.defaultProps = { jobTemplateID: null };
-export default ReviewDetails;
+
+const WrappedReviewDetails = props => (
+  <WizardContextConsumer>
+    {({ goToStepByName }) => (
+      <ReviewDetails goToStepByName={goToStepByName} {...props} />
+    )}
+  </WizardContextConsumer>
+);
+
+export default WrappedReviewDetails;

data/webpack/JobWizard/steps/Schedule/QueryType.js

@@ -31,7 +31,7 @@ export const QueryType = ({ isTypeStatic, setIsTypeStatic }) => (
         id="query-type-dynamic"
         label={__('Dynamic query')}
         body={__(
-          "evaluates just before the execution is started, so if it's planed in future, targeted hosts set may change before it"
+          "evaluates just before the execution is started, so if it's planned in future, targeted hosts set may change before it"
         )}
       />
     </FormGroup>

data/webpack/JobWizard/steps/Schedule/RepeatHour.js

@@ -47,7 +47,6 @@ export const RepeatHour = ({ repeatData, setRepeatData }) => {
         }}
         isOpen={minuteOpen}
         width={125}
-        menuAppendTo={() => document.querySelector('.pf-c-form.schedule-tab')}
         toggleAriaLabel="select minute toggle"
         validated={
           isValidMinute(minute)

data/webpack/JobWizard/steps/Schedule/RepeatWeek.js

@@ -5,7 +5,7 @@ import { translate as __, documentLocale } from 'foremanReact/common/I18n';
 import { RepeatDaily } from './RepeatDaily';
 import { noop } from '../../../helpers';
 
-const getWeekDays = () => {
+export const getWeekDays = () => {
   const locale = documentLocale().replace(/-/g, '_');
   const baseDate = new Date(Date.UTC(2017, 0, 1)); // just a Sunday
   const weekDays = [];

data/webpack/JobWizard/steps/Schedule/__tests__/Schedule.test.js

@@ -39,15 +39,35 @@ api.get.mockImplementation(({ handleSuccess, ...action }) => {
       handleSuccess({
         data: { results: [jobTemplateResponse.job_template] },
       });
+  } else if (action.key === 'HOST_IDS') {
+    handleSuccess &&
+      handleSuccess({
+        data: { results: [{ name: 'host1' }, { name: 'host3' }] },
+      });
   }
   return { type: 'get', ...action };
 });
 
 const mockStore = configureMockStore([]);
-const store = mockStore({});
+const store = mockStore({
+  HOSTS_API: {
+    response: {
+      subtotal: 3,
+    },
+  },
+});
 jest.useFakeTimers();
 
 describe('Schedule', () => {
+  beforeEach(() => {
+    jest.spyOn(selectors, 'selectRouterSearch');
+    selectors.selectRouterSearch.mockImplementation(() => ({
+      'host_ids[]': ['105', '37'],
+    }));
+  });
+  afterEach(() => {
+    selectors.selectRouterSearch.mockRestore();
+  });
   it('sub steps appear', () => {
     render(
       <Provider store={store}>
@@ -85,7 +105,7 @@ describe('Schedule', () => {
     });
     act(() => {
       fireEvent.click(screen.getByRole('button', { name: 'Future execution' }));
-      jest.runAllTimers(); // to handle pf4 date picker popover useTimer
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover useTimer
     });
 
     const newStartAtDate = '2030/03/12';
@@ -115,15 +135,15 @@ describe('Schedule', () => {
       fireEvent.change(startsBeforeTimeField(), {
         target: { value: newStartBeforeTime },
       });
-      jest.runOnlyPendingTimers();
+      jest.advanceTimersByTime(1000);
     });
 
     act(() => {
-      fireEvent.click(screen.getByText('Category and Template'));
+      fireEvent.click(screen.getByText('Category and template'));
     });
     act(() => {
       fireEvent.click(screen.getByRole('button', { name: 'Future execution' }));
-      jest.runAllTimers(); // to handle pf4 date picker popover useTimer
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover useTimer
     });
     expect(startsAtDateField().value).toBe(newStartAtDate);
     expect(startsAtTimeField().value).toBe(newStartAtTime);
@@ -140,7 +160,7 @@ describe('Schedule', () => {
         target: { value: '2030/03/11' },
       });
       await fireEvent.click(startsBeforeTimeField());
-      await jest.runOnlyPendingTimers();
+      await jest.advanceTimersByTime(1000);
     });
     expect(startsBeforeDateField().value).toBe('2030/03/11');
     expect(
@@ -157,13 +177,13 @@ describe('Schedule', () => {
       await fireEvent.change(startsAtDateField(), {
         target: { value: '' },
       });
-      jest.runOnlyPendingTimers();
+      jest.advanceTimersByTime(1000);
     });
 
     expect(startsBeforeDateField().value).toBe('2019/03/11');
     expect(
       screen.getAllByText("'Starts before' date must in the future")
-    ).toHaveLength(1);
+    ).toHaveLength(2);
   });
 
   it('Recurring execution - date pickers', async () => {
@@ -182,7 +202,7 @@ describe('Schedule', () => {
       fireEvent.click(
         screen.getByRole('button', { name: 'Recurring execution' })
       );
-      jest.runAllTimers(); // to handle pf4 date picker popover useTimer
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover useTimer
     });
 
     const newStartAtDate = '2030/03/12';
@@ -207,7 +227,7 @@ describe('Schedule', () => {
       fireEvent.change(startsAtTimeField(), {
         target: { value: newStartAtTime },
       });
-      jest.runOnlyPendingTimers();
+      jest.advanceTimersByTime(1000);
     });
 
     expect(endsAtDateField().disabled).toBeTruthy();
@@ -222,17 +242,17 @@ describe('Schedule', () => {
       fireEvent.change(endsAtTimeField(), {
         target: { value: newStartAtTime },
       });
-      jest.runOnlyPendingTimers();
+      jest.advanceTimersByTime(1000);
     });
 
     act(() => {
-      fireEvent.click(screen.getByText('Category and Template'));
+      fireEvent.click(screen.getByText('Category and template'));
     });
     act(() => {
       fireEvent.click(
         screen.getByRole('button', { name: 'Recurring execution' })
       );
-      jest.runAllTimers(); // to handle pf4 date picker popover useTimer
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover useTimer
     });
     expect(startsAtDateField().value).toBe(newStartAtDate);
     expect(startsAtTimeField().value).toBe(newStartAtTime);
@@ -266,7 +286,7 @@ describe('Schedule', () => {
       fireEvent.click(
         screen.getByRole('button', { name: 'Recurring execution' })
       );
-      jest.runAllTimers(); // to handle pf4 date picker popover useTimer
+      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover useTimer
     });
     await act(async () => {
       fireEvent.click(screen.getByLabelText('Daily', { selector: 'button' }));
@@ -274,7 +294,7 @@ describe('Schedule', () => {
     await act(async () => {
       fireEvent.click(screen.getByText('Cronline'));
     });
-    const newCronline = '1 2';
+    const newCronline = '1 2 3 4 5';
     const cronline = screen.getByLabelText('cronline');
     expect(cronline.value).toBe('');
     await act(async () => {
@@ -286,19 +306,33 @@ describe('Schedule', () => {
     expect(screen.getByText('Review details').disabled).toBeFalsy();
 
     await act(async () => {
-      fireEvent.click(screen.getByText('Category and Template'));
+      fireEvent.click(screen.getByText('Category and template'));
     });
-    expect(screen.getAllByText('Category and Template')).toHaveLength(3);
+    expect(screen.getAllByText('Category and template')).toHaveLength(3);
 
     await act(async () => {
       fireEvent.click(
         screen.getByRole('button', { name: 'Recurring execution' })
       );
-      jest.runAllTimers();
+      jest.advanceTimersByTime(1000);
     });
     expect(screen.queryAllByText('Recurring execution')).toHaveLength(3);
     expect(cronline.value).toBe(newCronline);
 
+    await act(async () => {
+      fireEvent.click(screen.getByText('Review details'));
+    });
+    expect(screen.queryAllByText('Review details')).toHaveLength(3);
+    expect(screen.getAllByText('Cron line - 1 2 3 4 5')).toHaveLength(1);
+
+    await act(async () => {
+      fireEvent.click(
+        screen.getByRole('button', { name: 'Recurring execution' })
+      );
+      jest.runAllTimers();
+    });
+    expect(screen.queryAllByText('Recurring execution')).toHaveLength(3);
+
     fireEvent.click(screen.getByText('Cronline'));
     await act(async () => {
       fireEvent.click(screen.getByText('Monthly'));

data/webpack/JobWizard/steps/form/DateTimePicker.js

@@ -59,7 +59,7 @@ export const DateTimePicker = ({
     return false;
   };
 
-  const onDateChange = newDate => {
+  const onDateChange = (e, newDate) => {
     const parsedNewDate = new Date(newDate);
     if (!newDate.length && allowEmpty) {
       setDateTime('');
@@ -119,7 +119,6 @@ export const DateTimePicker = ({
         is24Hour
         isDisabled={isDisabled || formattedDate.length === 0}
         invalidFormatErrorMessage={__('Invalid time format')}
-        menuAppendTo={() => document.body}
         includeSeconds={includeSeconds}
       />
     </>

data/webpack/JobWizard/steps/form/GroupedSelectField.js

@@ -68,7 +68,6 @@ export const GroupedSelectField = ({
         selections={selected}
         className="without_select2"
         onClear={onClear}
-        menuAppendTo={() => document.body}
         aria-labelledby={fieldId}
         toggleAriaLabel={`${label} toggle`}
         {...props}

data/webpack/JobWizard/steps/form/SelectField.js

@@ -43,7 +43,6 @@ export const SelectField = ({
         isOpen={isOpen}
         className="without_select2"
         maxHeight="45vh"
-        menuAppendTo={() => document.body}
         placeholderText=" " // To prevent showing first option as selected
         aria-labelledby={fieldId}
         toggleAriaLabel={`${label} toggle`}

data/webpack/JobWizard/submit.js

@@ -12,6 +12,8 @@ export const submit = ({
   location,
   organization,
   feature,
+  provider,
+  advancedInputs,
   dispatch,
 }) => {
   const {
@@ -37,6 +39,13 @@ export const submit = ({
     keyPassphrase,
     timeToPickup,
   } = advancedValues;
+  const providerInputs = advancedInputs.filter(v => v.provider_input);
+  const providerValues = {};
+  providerInputs.forEach(({ name }) => {
+    providerValues[name] = advancedTemplateValues[name];
+    delete advancedTemplateValues[name];
+  });
+
   const getCronLine = () => {
     const [hour, minute] = repeatData.at
       ? repeatData.at.split(':')
@@ -104,14 +113,16 @@ export const submit = ({
         concurrency_level: concurrencyLevel,
       },
       bookmark_id: null,
-      search_query:
-        buildHostQuery(selectedTargets, hostsSearchQuery) || 'name ~ *',
+      search_query: buildHostQuery(selectedTargets, hostsSearchQuery),
       description_format: description,
       execution_timeout_interval: timeoutToKill,
       feature,
       time_to_pickup: timeToPickup,
     },
   };
+  if (Object.keys(providerValues).length) {
+    api.job_invocation[provider] = providerValues;
+  }
 
   dispatch(
     post({
@@ -122,7 +133,7 @@ export const submit = ({
         window.location.href = `/job_invocations/${id}`;
       },
       errorToast: ({ response }) =>
-        response?.date?.error?.message ||
+        response?.data?.error?.message ||
         response?.message ||
         response?.statusText,
     })

data/webpack/react_app/components/RecentJobsCard/RecentJobsCard.js

@@ -25,7 +25,7 @@ const RecentJobsCard = ({ hostDetails: { name, id } }) => {
       header={__('Recent jobs')}
       dropdownItems={[
         <DropdownItem
-          href={foremanUrl(`${JOB_BASE_URL}${name}`)}
+          href={foremanUrl(`${JOB_BASE_URL}${id}`)}
           key="link-to-all"
           ouiaId="link-to-all-dropdown-item"
         >
@@ -33,7 +33,7 @@ const RecentJobsCard = ({ hostDetails: { name, id } }) => {
         </DropdownItem>,
         <DropdownItem
           href={foremanUrl(
-            `${JOB_BASE_URL}${name}+and+status+%3D+failed+or+status%3D+succeeded`
+            `${JOB_BASE_URL}${id}+and+status+%3D+failed+or+status%3D+succeeded`
           )}
           key="link-to-finished"
           ouiaId="link-to-finished-dropdown-item"
@@ -41,14 +41,14 @@ const RecentJobsCard = ({ hostDetails: { name, id } }) => {
           {__('View finished jobs')}
         </DropdownItem>,
         <DropdownItem
-          href={foremanUrl(`${JOB_BASE_URL}${name}+and+status+%3D+running`)}
+          href={foremanUrl(`${JOB_BASE_URL}${id}+and+status+%3D+running`)}
           key="link-to-running"
           ouiaId="link-to-running-dropdown-item"
         >
           {__('View running jobs')}
         </DropdownItem>,
         <DropdownItem
-          href={foremanUrl(`${JOB_BASE_URL}${name}+and+status+%3D+queued`)}
+          href={foremanUrl(`${JOB_BASE_URL}${id}+and+status+%3D+queued`)}
           key="link-to-scheduled"
           ouiaId="link-to-scheduled-dropdown-item"
         >

data/webpack/react_app/components/RecentJobsCard/RecentJobsTable.js

@@ -17,10 +17,10 @@ const RecentJobsTable = ({ status, hostId }) => {
   const jobsUrl =
     hostId &&
     foremanUrl(
-      `${JOB_API_URL}${hostId}+and+status%3D${status}&per_page=${JOBS_IN_CARD}`
+      `${JOB_API_URL}${hostId}&status=${status}&limit=${JOBS_IN_CARD}`
     );
   const {
-    response: { results: jobs },
+    response: { job_invocations: jobs },
     status: responseStatus,
   } = useAPI('get', jobsUrl, RECENT_JOBS_KEY);
 

data/webpack/react_app/components/RecentJobsCard/constants.js

@@ -6,8 +6,8 @@ export const SCHEDULED_TAB = 2;
 export const JOB_SUCCESS_STATUS = 0;
 export const JOB_ERROR_STATUS = 1;
 
-export const JOB_BASE_URL = '/job_invocations?search=host+%3D+';
+export const JOB_BASE_URL = '/job_invocations?search=targeted_host_id+%3D+';
 export const JOB_API_URL =
-  '/api/job_invocations?order=start_at+DESC&search=targeted_host_id%3D';
+  '/job_invocations/preview_job_invocations_per_host?host_id=';
 export const JOBS_IN_CARD = 3;
 export const RECENT_JOBS_KEY = { key: 'RECENT_JOBS_KEY' };

data/webpack/react_app/components/RegistrationExtension/RexPull.js

@@ -26,7 +26,6 @@ const options = (value = '') => {
 const RexPull = ({ isLoading, onChange, pluginValues, configParams }) => (
   <FormGroup
     label={__('REX pull mode')}
-    isRequired
     labelIcon={
       <LabelIcon
         text={__(
@@ -44,7 +43,6 @@ const RexPull = ({ isLoading, onChange, pluginValues, configParams }) => (
       className="without_select2"
       id="registration_setup_remote_execution_pull"
       isDisabled={isLoading}
-      isRequired
     >
       {/* eslint-disable-next-line camelcase */
       options(configParams?.host_registration_remote_execution_pull)}