foreman_discovery 16.0.0 → 16.3.1

data/test/functional/api/v2/settings_controller_test.rb

@@ -6,10 +6,10 @@ class Api::V2::SettingsControllerTest < ActionController::TestCase
   end
 
   test_attributes :pid => '2c5ecb7e-87bc-4980-9620-7ae00e3f360e'
-  test "should update hostname prefix without value" do
+  test "should not update hostname prefix without value" do
     setting = Setting.find_by_name("discovery_prefix")
     put :update, params: { :id => setting.id, :setting => { :value => '' } }
-    assert_equal JSON.parse(@response.body)['value'], '', "Can't update discovery_prefix setting with empty value"
+    assert_nil JSON.parse(@response.body)['value']
   end
 
   test_attributes :pid => '4969994d-f934-4f0e-9a98-476b87eb0527'

data/test/functional/discovered_hosts_controller_test.rb

@@ -8,7 +8,7 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
   setup do
     assert discovered_notification_blueprint
     @request.env['HTTP_REFERER'] = '/discovery_rules'
-    FactoryBot.create(:subnet, :network => "192.168.100.1", :mask => "255.255.255.0", :locations => [location_one], :organizations => [organization_one])
+    FactoryBot.create(:subnet, :dhcp, :network => "192.168.100.1", :mask => "255.255.255.0", :locations => [location_one], :organizations => [organization_one])
     @facts = {
       "interfaces"             => "lo,eth0",
       "ipaddress"              => "192.168.100.42",
@@ -115,7 +115,7 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
       } }, session: set_session_user_default_manager
     # all inherit buttons are pressed
     assert_select('button[name=is_overridden_btn]') do |e|
-      e.attribute("class") =~ /active/
+      e.attribute("class").to_s =~ /active/
     end
     # particular fields are set
     assert_select '#host_hostgroup_id [selected]' do |e|
@@ -140,6 +140,7 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
 
   def test_update_inheritance
     host = discover_host_from_facts(@facts)
+    ForemanDiscovery::HostConverter.stubs(:unused_ip_for_subnet).returns(host.ip)
     hostgroup = setup_hostgroup(host)
     put :update, params: {
       commit: 'Update',
@@ -167,7 +168,7 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
   def test_add_entry_to_nav_menu
     get :index, params: {}, session: set_session_user
     assert_response :success
-    assert response.body =~ /"\/discovered_hosts"/
+    assert response.body.include?('Discovered Hosts')
   end
 
   def test_reboot_success
@@ -186,7 +187,7 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
     ::ForemanDiscovery::NodeAPI::PowerService.any_instance.expects(:reboot).returns(false)
     post :reboot, params: { :id => host.id }, session: set_session_user_default_manager
     assert_redirected_to discovered_hosts_url
-    assert_equal "Failed to reboot host #{host.name}", flash[:error]
+    assert_match(/ERF42-4036/, flash[:error])
   end
 
   def test_reboot_error
@@ -195,7 +196,7 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
     ::ForemanDiscovery::NodeAPI::PowerService.any_instance.expects(:reboot).raises("request failed")
     post :reboot, params: { :id => host.id }, session: set_session_user_default_manager
     assert_redirected_to discovered_hosts_url
-    assert_match(/ERF50-4973/, flash[:error])
+    assert_match(/ERF42-4036/, flash[:error])
   end
 
   def test_auto_provision_success
@@ -274,7 +275,7 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
     ::ForemanDiscovery::NodeAPI::PowerService.any_instance.expects(:reboot).returns(false)
     post :submit_multiple_reboot, params: {:host_ids => host.id}, session: set_session_user(User.current)
     assert_redirected_to discovered_hosts_url
-    assert_equal "Errors during reboot: #{host.name}: failed to reboot", flash[:error]
+    assert_match(/ERF42-4036/, flash[:error])
     assert_nil flash[:success]
   end
 
@@ -284,12 +285,15 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
     ::ForemanDiscovery::NodeAPI::PowerService.any_instance.expects(:reboot).raises("request failed")
     post :submit_multiple_reboot, params: {:host_ids => host.id}, session: set_session_user(User.current)
     assert_redirected_to discovered_hosts_url
-    assert_match(/ERF50-4973/, flash[:error])
+    assert_match(/ERF42-4036/, flash[:error])
     assert_nil flash[:success]
   end
 
   def test_no_dns_rebuild_if_dns_pending
     host = discover_host_from_facts(@facts)
+    ForemanDiscovery::HostConverter.stubs(:unused_ip_for_subnet).returns(host.ip)
+    Nic::Managed.any_instance.stubs(:dhcp_update_required?).returns(false)
+    Net::DHCP::Record.any_instance.stubs(:conflicting?).returns(false)
     hostgroup = prepare_hostgroup_for_dns_rebuild(host)
     Nic::Managed.any_instance.expects(:rebuild_dns).never
     Host::Managed.any_instance.stubs(:skip_orchestration?).returns(false)
@@ -306,6 +310,9 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
 
   def test_dns_rebuild
     host = prepare_host_for_dns_rebuild
+    ForemanDiscovery::HostConverter.stubs(:unused_ip_for_subnet).returns(host.ip)
+    Nic::Managed.any_instance.stubs(:dhcp_update_required?).returns(false)
+    Net::DHCP::Record.any_instance.stubs(:conflicting?).returns(false)
     hostgroup = prepare_hostgroup_for_dns_rebuild(host)
     Nic::Managed.any_instance.expects(:rebuild_dns)
     Host::Managed.any_instance.stubs(:skip_orchestration?).returns(false)
@@ -319,6 +326,8 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
 
   def test_dns_rebuild_with_auto_provision
     host = prepare_host_for_dns_rebuild
+    ForemanDiscovery::HostConverter.stubs(:unused_ip_for_subnet).returns(host.ip)
+    Nic::Managed.any_instance.stubs(:dhcp_update_required?).returns(false)
     hostgroup = prepare_hostgroup_for_dns_rebuild(host)
     Nic::Managed.any_instance.expects(:rebuild_dns)
     Host::Managed.any_instance.stubs(:skip_orchestration?).returns(false)

data/test/functional/discovery_rules_controller_test.rb

@@ -6,7 +6,7 @@ class DiscoveryRulesControllerTest < ActionController::TestCase
   test "should add a link to navigation" do
     get :index, params: {}, session: set_session_user
     assert_response :success
-    assert response.body =~ /"\/discovery_rules"/
+    assert response.body =~ /\/discovery_rules/
   end
 
   test "reader role should get index" do

data/test/unit/discovered_extensions_test.rb

@@ -9,6 +9,7 @@ class DiscoveredExtensionsTest < ActiveSupport::TestCase
     @facts = facts_simple_network100_42
     @facts_ipv6 = facts_network_2001_db8
     set_default_settings
+    ProxyAPI::DHCP.any_instance.stubs(:record).returns(nil)
     ::ForemanDiscovery::HostConverter.stubs(:unused_ip_for_host)
   end
 
@@ -204,6 +205,8 @@ class DiscoveredExtensionsTest < ActiveSupport::TestCase
     assert_empty host.errors
     assert managed_host
     assert_empty managed_host.errors
+    refute_nil hostgroup.subnet
+    refute_nil managed_host.subnet
     assert_equal hostgroup.subnet, managed_host.subnet
     assert_equal "192.168.101.13", managed_host.ip
   end
@@ -224,7 +227,9 @@ class DiscoveredExtensionsTest < ActiveSupport::TestCase
     assert_empty host.errors
     assert managed_host
     assert_empty managed_host.errors
-    assert_equal hostgroup.subnet, managed_host.subnet
+    refute_nil hostgroup.subnet6
+    refute_nil managed_host.subnet6
+    assert_equal hostgroup.subnet6, managed_host.subnet6
     assert_equal "2001:db9::a8bb:ccff:fedd:eefa", managed_host.ip6
   end
 

data/test/unit/host_discovered_test.rb

@@ -260,12 +260,6 @@ class HostDiscoveredTest < ActiveSupport::TestCase
     assert_equal 'teste41f13cc3658', host.name
   end
 
-  test "should create discovered host without prefix" do
-    Setting[:discovery_prefix] = ''
-    host = discover_host_from_facts(@facts)
-    assert_equal 'e41f13cc3658',host.name
-  end
-
   test "should refresh facts and NICs of an existing discovered host" do
     host1 = discover_host_from_facts(@facts)
     assert_equal 'mace41f13cc3658', host1.name
@@ -290,16 +284,6 @@ class HostDiscoveredTest < ActiveSupport::TestCase
     assert_match(/Invalid facts: hash does not contain a valid value for any of the facts in the discovery_hostname setting:/, exception.message)
   end
 
-  test "should raise when hostname cannot be computed due to normlization and no prefix" do
-    @facts['invalidhostnamefact'] = '...'
-    Setting[:discovery_hostname] = 'invalidhostnamefact'
-    Setting[:discovery_prefix] = ''
-    exception = assert_raises(::Foreman::Exception) do
-      discover_host_from_facts(@facts)
-    end
-    assert_match(/Invalid hostname: Could not normalize the hostname/, exception.message)
-  end
-
   test 'discovered host can be searched in multiple taxonomies' do
     org1 = FactoryBot.create(:organization)
     org2 = FactoryBot.create(:organization)

data/test/unit/managed_extensions_test.rb

@@ -18,6 +18,7 @@ class ManagedExtensionsTest < ActiveSupport::TestCase
 
       @host = StubHost.new
       @host.type = "Host::Discovered"
+      @host.stubs(:ip).returns("192.168.1.1")
       @host.stubs(:old).returns(@host)
       @facts = {}
       @host.stubs(:facts).returns(@facts)

data/webpack/index.js

@@ -0,0 +1,18 @@
+/* eslint import/no-unresolved: [2, { ignore: [foremanReact/*] }] */
+/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable import/extensions */
+import componentRegistry from "foremanReact/components/componentRegistry";
+import { registerReducer } from "foremanReact/common/MountingService";
+import reducers from "./src/reducers";
+import DiscoveredHosts from "./src/ForemanDiscovery/DiscoveredHosts";
+
+// register reducers
+Object.entries(reducers).forEach(([key, reducer]) =>
+  registerReducer(key, reducer)
+);
+
+// register components for erb mounting
+componentRegistry.register({
+  name: "DiscoveredHosts",
+  type: DiscoveredHosts,
+});

data/webpack/src/ForemanDiscovery/DiscoveredHosts/Components/EmptyState/EmptyState.js

@@ -0,0 +1,28 @@
+import React from "react";
+import PropTypes from "prop-types";
+import { translate as __ } from "foremanReact/common/I18n";
+import ForemanEmptyState from "foremanReact/components/common/EmptyState";
+
+const EmptyState = (props) => {
+  const description = __(
+    "No discovered hosts found in this context. This page shows discovered bare-metal or virtual nodes waiting to be provisioned."
+  );
+  const documentation = {
+    url: props.docUrl,
+  };
+  return (
+    <ForemanEmptyState
+      header="Foreman Discovery"
+      description={description}
+      icon="gears"
+      iconType="fa"
+      documentation={documentation}
+    />
+  );
+};
+
+EmptyState.propTypes = {
+  docUrl: PropTypes.string,
+};
+
+export default EmptyState;

data/webpack/src/ForemanDiscovery/DiscoveredHosts/Components/EmptyState/index.js

@@ -0,0 +1 @@
+export { default } from "./EmptyState";

data/webpack/src/ForemanDiscovery/DiscoveredHosts/index.js

@@ -0,0 +1,6 @@
+import React from "react";
+import EmptyState from "./Components/EmptyState";
+
+const DiscoveredHosts = ({ docUrl }) => <EmptyState docUrl={docUrl} />;
+
+export default DiscoveredHosts;

data/webpack/src/reducers.js

@@ -0,0 +1,7 @@
+import { combineReducers } from "redux";
+
+const reducers = {
+  foremanDiscovery: {},
+};
+
+export default reducers;

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_discovery
 version: !ruby/object:Gem::Version
-  version: 16.0.0
+  version: 16.3.1
 platform: ruby
 authors:
 - Aditi Puntambekar
@@ -9,6 +9,7 @@ authors:
 - Alon Goldboim
 - amirfefer
 - Amit Karsale
+- Amit Upadhye
 - Amos Benari
 - Avi Sharvit
 - Bryan Kearney
@@ -34,6 +35,7 @@ authors:
 - kgaikwad
 - Lars Berntzon
 - ldjebran
+- Leos Stejskal
 - Lukas Zapletal
 - Lukáš Zapletal
 - Marek Hulan
@@ -69,7 +71,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-05 00:00:00.000000000 Z
+date: 2020-10-29 00:00:00.000000000 Z
 dependencies: []
 description: MaaS Discovery Plugin engine for Foreman
 email: gsutclif@redhat.com
@@ -104,6 +106,7 @@ files:
 - app/models/setting/discovered.rb
 - app/services/foreman_discovery/fact_parser.rb
 - app/services/foreman_discovery/host_converter.rb
+- app/services/foreman_discovery/host_fact_importer.rb
 - app/services/foreman_discovery/import_hook.rb
 - app/services/foreman_discovery/import_hook_service.rb
 - app/services/foreman_discovery/import_hooks/discovery_attribute.rb
@@ -124,6 +127,7 @@ files:
 - app/views/api/v2/discovered_hosts/show.json.rabl
 - app/views/api/v2/discovered_hosts/update.json.rabl
 - app/views/api/v2/discovery_rules/base.json.rabl
+- app/views/api/v2/discovery_rules/create.json.rabl
 - app/views/api/v2/discovery_rules/index.json.rabl
 - app/views/api/v2/discovery_rules/main.json.rabl
 - app/views/api/v2/discovery_rules/show.json.rabl
@@ -234,6 +238,7 @@ files:
 - locale/zh_TW/LC_MESSAGES/foreman_discovery.mo
 - locale/zh_TW/foreman_discovery.edit.po
 - locale/zh_TW/foreman_discovery.po
+- package.json
 - test/factories/discovery_host_related.rb
 - test/factories/discovery_rule_related.rb
 - test/facts/bond0-eth0-eth1-active-passive.json
@@ -242,12 +247,14 @@ files:
 - test/facts/dell_vlan.json
 - test/facts/facts_with_lldp.json
 - test/facts/facts_with_lldp_bond_candidate.json
+- test/facts/only-ipv6.json
 - test/facts/pxeless-vlan.json
 - test/facts/regular_host.json
 - test/facts/rhel-dl380-1kdisks.json
 - test/facts/rhel-r730.json
 - test/facts/rhel7-vlan.json
 - test/facts/simple-bond.json
+- test/facts/skylake-ipv6.json
 - test/facts/suse-vmware.json
 - test/facts/vmware_local.json
 - test/functional/api/v2/discovered_hosts_controller_test.rb
@@ -273,6 +280,11 @@ files:
 - test/unit/setting_discovered_test.rb
 - test/unit/ui_notifications/destroy_host_test.rb
 - test/unit/ui_notifications/new_host_test.rb
+- webpack/index.js
+- webpack/src/ForemanDiscovery/DiscoveredHosts/Components/EmptyState/EmptyState.js
+- webpack/src/ForemanDiscovery/DiscoveredHosts/Components/EmptyState/index.js
+- webpack/src/ForemanDiscovery/DiscoveredHosts/index.js
+- webpack/src/reducers.js
 homepage: https://github.com/theforeman/foreman_discovery
 licenses:
 - GPL-3.0
@@ -292,47 +304,49 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: MaaS Discovery Plugin for Foreman
 test_files:
-- test/functional/foreman_discovery/concerns/hosts_controller_extensions_test.rb
-- test/functional/discovered_hosts_controller_test.rb
-- test/functional/api/v2/discovered_hosts_controller_test.rb
-- test/functional/api/v2/fact_value_extensions_test.rb
-- test/functional/api/v2/settings_controller_test.rb
-- test/functional/api/v2/discovery_rules_controller_test.rb
-- test/functional/discovery_rules_controller_test.rb
-- test/integration/discovered_hosts_test.rb
-- test/test_plugin_helper.rb
-- test/facts/facts_with_lldp.json
-- test/facts/dell_vlan.json
+- test/factories/discovery_host_related.rb
+- test/factories/discovery_rule_related.rb
 - test/facts/bond0-eth0-eth1-active-passive.json
-- test/facts/simple-bond.json
-- test/facts/rhel-r730.json
+- test/facts/default.json
 - test/facts/dell_npars.json
+- test/facts/dell_vlan.json
+- test/facts/facts_with_lldp.json
+- test/facts/facts_with_lldp_bond_candidate.json
 - test/facts/pxeless-vlan.json
 - test/facts/regular_host.json
-- test/facts/facts_with_lldp_bond_candidate.json
-- test/facts/rhel7-vlan.json
-- test/facts/default.json
 - test/facts/rhel-dl380-1kdisks.json
+- test/facts/rhel-r730.json
+- test/facts/rhel7-vlan.json
+- test/facts/simple-bond.json
 - test/facts/suse-vmware.json
 - test/facts/vmware_local.json
+- test/facts/only-ipv6.json
+- test/facts/skylake-ipv6.json
+- test/functional/api/v2/discovered_hosts_controller_test.rb
+- test/functional/api/v2/discovery_rules_controller_test.rb
+- test/functional/api/v2/fact_value_extensions_test.rb
+- test/functional/api/v2/settings_controller_test.rb
+- test/functional/foreman_discovery/concerns/hosts_controller_extensions_test.rb
+- test/functional/discovery_rules_controller_test.rb
+- test/functional/discovered_hosts_controller_test.rb
+- test/integration/discovered_hosts_test.rb
+- test/models/setting_test.rb
+- test/test_helper_discovery.rb
+- test/test_plugin_helper.rb
+- test/unit/discovered_mailer_test.rb
+- test/unit/discovery_attribute_set_test.rb
 - test/unit/discovery_rule_test.rb
 - test/unit/discovery_taxonomy_extensions_test.rb
-- test/unit/discovered_mailer_test.rb
 - test/unit/fact_parser_test.rb
-- test/unit/discovered_extensions_test.rb
-- test/unit/setting_discovered_test.rb
-- test/unit/host_discovered_test.rb
 - test/unit/lldp_neighbors_test.rb
+- test/unit/setting_discovered_test.rb
 - test/unit/ui_notifications/destroy_host_test.rb
 - test/unit/ui_notifications/new_host_test.rb
-- test/unit/discovery_attribute_set_test.rb
+- test/unit/discovered_extensions_test.rb
 - test/unit/managed_extensions_test.rb
-- test/models/setting_test.rb
-- test/test_helper_discovery.rb
-- test/factories/discovery_rule_related.rb
-- test/factories/discovery_host_related.rb
+- test/unit/host_discovered_test.rb