foreman-tasks 8.3.1 → 9.0.0

data/test/unit/actions/bulk_action_test.rb

@@ -16,6 +16,12 @@ module ForemanTasks
       end
     end
 
+    class KwArgChildAction < Actions::EntryAction
+      def plan(_target, options = {})
+        plan_self(kw_string: options['kw'], kw_symbol: options[:kw])
+      end
+    end
+
     describe Actions::BulkAction do
       include ForemanTasks::TestHelpers::WithInThreadExecutor
 
@@ -46,6 +52,27 @@ module ForemanTasks
         _(success.count).must_equal 4
         _(failed.count).must_equal 1
       end
+
+      specify "it handles keyword arguments as indifferent hashes when they're being flattened" do
+        Target.expects(:unscoped).returns(Target)
+        Target.expects(:where).with(:id => targets.map(&:id)).returns(targets)
+
+        triggered = ForemanTasks.trigger(ParentAction, KwArgChildAction, targets, kw: 7)
+        task = ForemanTasks::Task.where(:external_id => triggered.id).first
+        wait_for { task.reload.state == 'stopped' }
+        task = task.sub_tasks.first
+        _(task.input[:kw_string]).must_equal 7
+        _(task.input[:kw_symbol]).must_equal 7
+      end
+
+      specify 'it allows setting concurrency limit' do
+        Target.expects(:unscoped).returns(Target)
+        Target.expects(:where).with(:id => targets.map(&:id)).returns(targets)
+
+        triggered = ForemanTasks.trigger(ParentAction, ChildAction, targets, concurrency_limit: 25)
+        task = ForemanTasks::Task.where(:external_id => triggered.id).first
+        _(task.execution_plan.entry_action.concurrency_limit).must_equal 25
+      end
     end
   end
 end

data/test/unit/actions/trigger_proxy_batch_test.rb

@@ -32,6 +32,13 @@ module ForemanTasks
           triggered.output[:planned_count] = ((total_count - 1) / batch_size) * batch_size
           run_action(triggered)
         end
+
+        it "finishes after the last batch even if the counts don't match" do
+          Actions::TriggerProxyBatch.any_instance.expects(:trigger_remote_tasks_batch).once
+          triggered.output[:planned_count] = 0
+          action = run_action(triggered, Actions::TriggerProxyBatch::TriggerLastBatch)
+          _(action.state).must_equal :success
+        end
       end
 
       describe '#trigger_remote_tasks_batch' do

data/webpack/ForemanTasks/Components/TasksTable/TasksIndexPage.js

@@ -1,10 +1,4 @@
 import React from 'react';
-import { translate as __ } from 'foremanReact/common/I18n';
 import TasksTablePage from './';
 
-export const TasksIndexPage = props => {
-  const getBreadcrumbs = () => ({
-    breadcrumbItems: [{ caption: __('Tasks'), url: `/foreman_tasks/tasks` }],
-  });
-  return <TasksTablePage getBreadcrumbs={getBreadcrumbs} {...props} />;
-};
+export const TasksIndexPage = props => <TasksTablePage {...props} />;

data/webpack/ForemanTasks/Components/TasksTable/TasksTablePage.js

@@ -123,7 +123,7 @@ TasksTablePage.propTypes = {
   selectAllRows: PropTypes.func.isRequired,
   results: PropTypes.array.isRequired,
   getTableItems: PropTypes.func.isRequired,
-  getBreadcrumbs: PropTypes.func.isRequired,
+  getBreadcrumbs: PropTypes.func,
   actionName: PropTypes.string,
   status: PropTypes.oneOf(Object.keys(STATUS)),
   history: PropTypes.object.isRequired,
@@ -143,6 +143,7 @@ TasksTablePage.propTypes = {
 TasksTablePage.defaultProps = {
   perPage: 20,
   allRowsSelected: false,
+  getBreadcrumbs: () => null,
   actionName: '',
   status: STATUS.PENDING,
   selectedRows: [],

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman-tasks
 version: !ruby/object:Gem::Version
-  version: 8.3.1
+  version: 9.0.0
 platform: ruby
 authors:
 - Ivan Nečas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-20 00:00:00.000000000 Z
+date: 2023-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dynflow