flipper-ui 0.10.2 → 0.11.0.beta1

data/spec/flipper/ui/actions/home_spec.rb

@@ -1,16 +1,16 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Actions::Home do
-  describe "GET /" do
+  describe 'GET /' do
     before do
       flipper[:stats].enable
       flipper[:search].enable
-      get "/"
+      get '/'
     end
 
-    it "responds with redirect" do
+    it 'responds with redirect' do
       expect(last_response.status).to be(302)
-      expect(last_response.headers["Location"]).to eq("/features")
+      expect(last_response.headers['Location']).to eq('/features')
     end
   end
 end

data/spec/flipper/ui/actions/percentage_of_actors_gate_spec.rb

@@ -1,54 +1,56 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Actions::PercentageOfActorsGate do
-  let(:token) {
+  let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
       Rack::Protection::AuthenticityToken.random_token
     else
-      "a"
+      'a'
     end
-  }
-  let(:session) {
+  end
+  let(:session) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
-      {:csrf => token}
+      { csrf: token }
     else
-      {"_csrf_token" => token}
+      { '_csrf_token' => token }
     end
-  }
+  end
 
-  describe "POST /features/:feature/percentage_of_actors" do
-    context "with valid value" do
+  describe 'POST /features/:feature/percentage_of_actors' do
+    context 'with valid value' do
       before do
-        post "features/search/percentage_of_actors",
-          {"value" => "24", "authenticity_token" => token},
-          "rack.session" => session
+        post 'features/search/percentage_of_actors',
+             { 'value' => '24', 'authenticity_token' => token },
+             'rack.session' => session
       end
 
-      it "enables the feature" do
+      it 'enables the feature' do
         expect(flipper[:search].percentage_of_actors_value).to be(24)
       end
 
-      it "redirects back to feature" do
+      it 'redirects back to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/search")
+        expect(last_response.headers['Location']).to eq('/features/search')
       end
     end
 
-    context "with invalid value" do
+    context 'with invalid value' do
       before do
-        post "features/search/percentage_of_actors",
-          {"value" => "555", "authenticity_token" => token},
-          "rack.session" => session
+        post 'features/search/percentage_of_actors',
+             { 'value' => '555', 'authenticity_token' => token },
+             'rack.session' => session
       end
 
-      it "does not change value" do
+      it 'does not change value' do
         expect(flipper[:search].percentage_of_actors_value).to be(0)
       end
 
-      it "redirects back to feature" do
+      # rubocop:disable Metrics/LineLength
+      it 'redirects back to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/search?error=Invalid+percentage+of+actors+value%3A+value+must+be+a+positive+number+less+than+or+equal+to+100%2C+but+was+555")
+        expect(last_response.headers['Location']).to eq('/features/search?error=Invalid+percentage+of+actors+value%3A+value+must+be+a+positive+number+less+than+or+equal+to+100%2C+but+was+555')
       end
+      # rubocop:enable Metrics/LineLength
     end
   end
 end

data/spec/flipper/ui/actions/percentage_of_time_gate_spec.rb

@@ -1,54 +1,56 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Actions::PercentageOfTimeGate do
-  let(:token) {
+  let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
       Rack::Protection::AuthenticityToken.random_token
     else
-      "a"
+      'a'
     end
-  }
-  let(:session) {
+  end
+  let(:session) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
-      {:csrf => token}
+      { csrf: token }
     else
-      {"_csrf_token" => token}
+      { '_csrf_token' => token }
     end
-  }
+  end
 
-  describe "POST /features/:feature/percentage_of_time" do
-    context "with valid value" do
+  describe 'POST /features/:feature/percentage_of_time' do
+    context 'with valid value' do
       before do
-        post "features/search/percentage_of_time",
-          {"value" => "24", "authenticity_token" => token},
-          "rack.session" => session
+        post 'features/search/percentage_of_time',
+             { 'value' => '24', 'authenticity_token' => token },
+             'rack.session' => session
       end
 
-      it "enables the feature" do
+      it 'enables the feature' do
         expect(flipper[:search].percentage_of_time_value).to be(24)
       end
 
-      it "redirects back to feature" do
+      it 'redirects back to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/search")
+        expect(last_response.headers['Location']).to eq('/features/search')
       end
     end
 
-    context "with invalid value" do
+    context 'with invalid value' do
       before do
-        post "features/search/percentage_of_time",
-          {"value" => "555", "authenticity_token" => token},
-          "rack.session" => session
+        post 'features/search/percentage_of_time',
+             { 'value' => '555', 'authenticity_token' => token },
+             'rack.session' => session
       end
 
-      it "does not change value" do
+      it 'does not change value' do
         expect(flipper[:search].percentage_of_time_value).to be(0)
       end
 
-      it "redirects back to feature" do
+      # rubocop:disable Metrics/LineLength
+      it 'redirects back to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/search?error=Invalid+percentage+of+time+value%3A+value+must+be+a+positive+number+less+than+or+equal+to+100%2C+but+was+555")
+        expect(last_response.headers['Location']).to eq('/features/search?error=Invalid+percentage+of+time+value%3A+value+must+be+a+positive+number+less+than+or+equal+to+100%2C+but+was+555')
       end
+      # rubocop:enable Metrics/LineLength
     end
   end
 end

data/spec/flipper/ui/decorators/feature_spec.rb

@@ -7,85 +7,85 @@ RSpec.describe Flipper::UI::Decorators::Feature do
   let(:flipper) { build_flipper }
   let(:feature) { flipper[:some_awesome_feature] }
 
-  subject {
+  subject do
     described_class.new(feature)
-  }
+  end
 
-  describe "#initialize" do
-    it "sets the feature" do
+  describe '#initialize' do
+    it 'sets the feature' do
       expect(subject.feature).to be(feature)
     end
   end
 
-  describe "#pretty_name" do
-    it "capitalizes each word separated by underscores" do
+  describe '#pretty_name' do
+    it 'capitalizes each word separated by underscores' do
       expect(subject.pretty_name).to eq('Some Awesome Feature')
     end
   end
 
-  describe "#as_json" do
+  describe '#as_json' do
     before do
       @result = subject.as_json
     end
 
-    it "returns Hash" do
+    it 'returns Hash' do
       expect(@result).to be_instance_of(Hash)
     end
 
-    it "includes id" do
+    it 'includes id' do
       expect(@result['id']).to eq('some_awesome_feature')
     end
 
-    it "includes pretty name" do
+    it 'includes pretty name' do
       expect(@result['name']).to eq('Some Awesome Feature')
     end
 
-    it "includes state" do
+    it 'includes state' do
       expect(@result['state']).to eq('off')
     end
 
-    it "includes gates" do
-      gates = subject.gates.map { |gate|
+    it 'includes gates' do
+      gates = subject.gates.map do |gate|
         value = subject.gate_values[gate.key]
         Flipper::UI::Decorators::Gate.new(gate, value).as_json
-      }
+      end
       expect(@result['gates']).to eq(gates)
     end
   end
 
-  describe "#<=>" do
-    let(:on) {
+  describe '#<=>' do
+    let(:on) do
       flipper.enable(:on_a)
       described_class.new(flipper[:on_a])
-    }
+    end
 
-    let(:on_b) {
+    let(:on_b) do
       flipper.enable(:on_b)
       described_class.new(flipper[:on_b])
-    }
+    end
 
-    let(:conditional) {
+    let(:conditional) do
       flipper.enable_percentage_of_time :conditional_a, 5
       described_class.new(flipper[:conditional_a])
-    }
+    end
 
-    let(:off) {
+    let(:off) do
       described_class.new(flipper[:off_a])
-    }
+    end
 
-    it "sorts :on before :conditional" do
+    it 'sorts :on before :conditional' do
       expect((on <=> conditional)).to be(-1)
     end
 
-    it "sorts :on before :off" do
+    it 'sorts :on before :off' do
       expect((on <=> conditional)).to be(-1)
     end
 
-    it "sorts :conditional before :off" do
+    it 'sorts :conditional before :off' do
       expect((on <=> conditional)).to be(-1)
     end
 
-    it "sorts on key for identical states" do
+    it 'sorts on key for identical states' do
       expect((on <=> on_b)).to be(-1)
     end
   end

data/spec/flipper/ui/decorators/gate_spec.rb

@@ -9,38 +9,38 @@ RSpec.describe Flipper::UI::Decorators::Gate do
   let(:feature) { flipper[:some_awesome_feature] }
   let(:gate) { feature.gate(:boolean) }
 
-  subject {
+  subject do
     described_class.new(gate, false)
-  }
+  end
 
-  describe "#initialize" do
-    it "sets gate" do
+  describe '#initialize' do
+    it 'sets gate' do
       expect(subject.gate).to be(gate)
     end
 
-    it "sets value" do
+    it 'sets value' do
       expect(subject.value).to eq(false)
     end
   end
 
-  describe "#as_json" do
+  describe '#as_json' do
     before do
       @result = subject.as_json
     end
 
-    it "returns Hash" do
+    it 'returns Hash' do
       expect(@result).to be_instance_of(Hash)
     end
 
-    it "includes key" do
+    it 'includes key' do
       expect(@result['key']).to eq('boolean')
     end
 
-    it "includes pretty name" do
+    it 'includes pretty name' do
       expect(@result['name']).to eq('boolean')
     end
 
-    it "includes value" do
+    it 'includes value' do
       expect(@result['value']).to be(false)
     end
   end

data/spec/flipper/ui/util_spec.rb

@@ -2,15 +2,15 @@ require 'helper'
 require 'flipper/ui/util'
 
 RSpec.describe Flipper::UI::Util do
-  describe "#blank?" do
-    context "with a string" do
-      it "returns true if blank" do
+  describe '#blank?' do
+    context 'with a string' do
+      it 'returns true if blank' do
         expect(described_class.blank?(nil)).to be(true)
         expect(described_class.blank?('')).to be(true)
         expect(described_class.blank?('   ')).to be(true)
       end
 
-      it "returns false if not blank" do
+      it 'returns false if not blank' do
         expect(described_class.blank?('nope')).to be(false)
       end
     end

data/spec/flipper/ui_spec.rb

@@ -1,128 +1,128 @@
 require 'helper'
 
 RSpec.describe Flipper::UI do
-  let(:token) {
+  let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
       Rack::Protection::AuthenticityToken.random_token
     else
-      "a"
+      'a'
     end
-  }
-  let(:session) {
+  end
+  let(:session) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
-      {:csrf => token}
+      { csrf: token }
     else
-      {"_csrf_token" => token}
+      { '_csrf_token' => token }
     end
-  }
+  end
 
-  describe "Initializing middleware with flipper instance" do
+  describe 'Initializing middleware with flipper instance' do
     let(:app) { build_app(flipper) }
 
-    it "works" do
+    it 'works' do
       flipper.enable :some_great_feature
-      get "/features"
+      get '/features'
       expect(last_response.status).to be(200)
-      expect(last_response.body).to include("some_great_feature")
+      expect(last_response.body).to include('some_great_feature')
     end
   end
 
-  describe "Initializing middleware lazily with a block" do
-    let(:app) {
-      build_app(lambda { flipper })
-    }
+  describe 'Initializing middleware lazily with a block' do
+    let(:app) do
+      build_app(-> { flipper })
+    end
 
-    it "works" do
+    it 'works' do
       flipper.enable :some_great_feature
-      get "/features"
+      get '/features'
       expect(last_response.status).to be(200)
-      expect(last_response.body).to include("some_great_feature")
+      expect(last_response.body).to include('some_great_feature')
     end
   end
 
-  describe "Request method unsupported by action" do
-    it "raises error" do
-      expect {
+  describe 'Request method unsupported by action' do
+    it 'raises error' do
+      expect do
         head '/features'
-      }.to raise_error(Flipper::UI::RequestMethodNotSupported)
+      end.to raise_error(Flipper::UI::RequestMethodNotSupported)
     end
   end
 
-  describe "Inspecting the built Rack app" do
-    it "returns a String" do
+  describe 'Inspecting the built Rack app' do
+    it 'returns a String' do
       expect(build_app(flipper).inspect).to be_a(String)
     end
   end
 
   # See https://github.com/jnunemaker/flipper/issues/80
-  it "can route features with names that match static directories" do
-    post "features/refactor-images/actors",
-      {"value" => "User:6", "operation" => "enable", "authenticity_token" => token},
-      "rack.session" => session
+  it 'can route features with names that match static directories' do
+    post 'features/refactor-images/actors',
+         { 'value' => 'User:6', 'operation' => 'enable', 'authenticity_token' => token },
+         'rack.session' => session
     expect(last_response.status).to be(302)
-    expect(last_response.headers["Location"]).to eq("/features/refactor-images")
+    expect(last_response.headers['Location']).to eq('/features/refactor-images')
   end
 
-  it "should not have an application_breadcrumb_href by default" do
-    expect(Flipper::UI.application_breadcrumb_href).to be(nil)
+  it 'does not have an application_breadcrumb_href by default' do
+    expect(described_class.application_breadcrumb_href).to be(nil)
   end
 
-  context "with application_breadcrumb_href not set" do
+  context 'with application_breadcrumb_href not set' do
     before do
-      @original_application_breadcrumb_href = Flipper::UI.application_breadcrumb_href
-      Flipper::UI.application_breadcrumb_href = nil
+      @original_application_breadcrumb_href = described_class.application_breadcrumb_href
+      described_class.application_breadcrumb_href = nil
     end
 
     after do
-      Flipper::UI.application_breadcrumb_href = @original_application_breadcrumb_href
+      described_class.application_breadcrumb_href = @original_application_breadcrumb_href
     end
 
     it 'does not add App breadcrumb' do
-      get "/features"
-      expect(last_response.body).to_not include('<a href="/myapp">App</a>')
+      get '/features'
+      expect(last_response.body).not_to include('<a href="/myapp">App</a>')
     end
   end
 
-  context "with application_breadcrumb_href set" do
+  context 'with application_breadcrumb_href set' do
     before do
-      @original_application_breadcrumb_href = Flipper::UI.application_breadcrumb_href
-      Flipper::UI.application_breadcrumb_href = "/myapp"
+      @original_application_breadcrumb_href = described_class.application_breadcrumb_href
+      described_class.application_breadcrumb_href = '/myapp'
     end
 
     after do
-      Flipper::UI.application_breadcrumb_href = @original_application_breadcrumb_href
+      described_class.application_breadcrumb_href = @original_application_breadcrumb_href
     end
 
     it 'does add App breadcrumb' do
-      get "/features"
+      get '/features'
       expect(last_response.body).to include('<a href="/myapp">App</a>')
     end
   end
 
-  context "with application_breadcrumb_href set to full url" do
+  context 'with application_breadcrumb_href set to full url' do
     before do
-      @original_application_breadcrumb_href = Flipper::UI.application_breadcrumb_href
-      Flipper::UI.application_breadcrumb_href = "https://myapp.com/"
+      @original_application_breadcrumb_href = described_class.application_breadcrumb_href
+      described_class.application_breadcrumb_href = 'https://myapp.com/'
     end
 
     after do
-      Flipper::UI.application_breadcrumb_href = @original_application_breadcrumb_href
+      described_class.application_breadcrumb_href = @original_application_breadcrumb_href
     end
 
     it 'does add App breadcrumb' do
-      get "/features"
+      get '/features'
       expect(last_response.body).to include('<a href="https://myapp.com/">App</a>')
     end
   end
 
-  it "should set feature_creation_enabled to true by default" do
-    expect(Flipper::UI.feature_creation_enabled).to be(true)
+  it 'sets feature_creation_enabled to true by default' do
+    expect(described_class.feature_creation_enabled).to be(true)
   end
 
-  context "with feature_creation_enabled set to true" do
+  context 'with feature_creation_enabled set to true' do
     before do
-      @original_feature_creation_enabled = Flipper::UI.feature_creation_enabled
-      Flipper::UI.feature_creation_enabled = true
+      @original_feature_creation_enabled = described_class.feature_creation_enabled
+      described_class.feature_creation_enabled = true
     end
 
     it 'has the add_feature button' do
@@ -131,24 +131,23 @@ RSpec.describe Flipper::UI do
     end
 
     after do
-      Flipper::UI.feature_creation_enabled = @original_feature_creation_enabled
+      described_class.feature_creation_enabled = @original_feature_creation_enabled
     end
   end
 
-  context "with feature_creation_enabled set to false" do
+  context 'with feature_creation_enabled set to false' do
     before do
-      @original_feature_creation_enabled = Flipper::UI.feature_creation_enabled
-      Flipper::UI.feature_creation_enabled = false
+      @original_feature_creation_enabled = described_class.feature_creation_enabled
+      described_class.feature_creation_enabled = false
     end
 
     it 'does not have the add_feature button' do
       get '/features'
-      expect(last_response.body).to_not include('Add Feature')
+      expect(last_response.body).not_to include('Add Feature')
     end
 
     after do
-      Flipper::UI.feature_creation_enabled = @original_feature_creation_enabled
+      described_class.feature_creation_enabled = @original_feature_creation_enabled
     end
   end
-
 end