flipper-ui 0.10.2 → 0.11.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aecff7000b2350bc4238cd50dcfc9cad07c8bb27
-  data.tar.gz: 86be7431a5eca0a785984083c645dbf6fa7e510e
+  metadata.gz: c04c941ffe3af3df192e5a29093f9d9c0efbc6dd
+  data.tar.gz: 82bf9b5cb5981e7153da0246e6cefa2ca9e807a5
 SHA512:
-  metadata.gz: 7945d54ccb03a0d2b3b309175a601d797b68f1c96fa80d66354d1028aafe12abc7fc2b1eb83b40577180a8dec3450044ad86b8ae58bf4d7653c0d3d3890e6185
-  data.tar.gz: d5d68823b6d56dfe8069792b5e18c52530400967ca8ff078cf0590dc9768d0c61c2a8ea44780a0cf2b290ac9181673e795c84ec7690af53c300e12db4e788e98
+  metadata.gz: bf1562cc247ec64099c378500f4860aa9fb84f55529404f3e85a6b3e0ddf5134a3cf05f2bfeda09e0699f0fe0d432f6af3c2178d026c5c0d639e8ddbe4e85e1f
+  data.tar.gz: 2eeab039b13a065810e28b85711d4cb88565195a15ae8f10e99a3e24d4682f991fd1db1d105d1e5d7368d61a1debfda50e3f2d07d06d8f4ec0125150cc177ccd

data/flipper-ui.gemspec

@@ -1,22 +1,22 @@
 # -*- encoding: utf-8 -*-
 require File.expand_path('../lib/flipper/version', __FILE__)
 
-flipper_ui_files = lambda { |file|
-  file =~ /(docs|examples|flipper)[\/-]ui/
-}
+flipper_ui_files = lambda do |file|
+  file =~ %r{(docs|examples|flipper)[\/-]ui}
+end
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["John Nunemaker"]
-  gem.email         = ["nunemaker@gmail.com"]
-  gem.summary       = "UI for the Flipper gem"
-  gem.description   = "Rack middleware that provides a fully featured web interface for the flipper gem."
-  gem.license       = "MIT"
-  gem.homepage      = "https://github.com/jnunemaker/flipper"
+  gem.authors       = ['John Nunemaker']
+  gem.email         = ['nunemaker@gmail.com']
+  gem.summary       = 'UI for the Flipper gem'
+  gem.description   = 'Rack middleware that provides a fully featured web interface for the flipper gem.'
+  gem.license       = 'MIT'
+  gem.homepage      = 'https://github.com/jnunemaker/flipper'
 
-  gem.files         = `git ls-files`.split("\n").select(&flipper_ui_files) + ["lib/flipper/version.rb"]
+  gem.files         = `git ls-files`.split("\n").select(&flipper_ui_files) + ['lib/flipper/version.rb']
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n").select(&flipper_ui_files)
-  gem.name          = "flipper-ui"
-  gem.require_paths = ["lib"]
+  gem.name          = 'flipper-ui'
+  gem.require_paths = ['lib']
   gem.version       = Flipper::VERSION
 
   gem.add_dependency 'rack', '>= 1.4', '< 3'

data/lib/flipper/ui.rb

@@ -9,6 +9,7 @@ end
 require 'rack/protection'
 
 require 'flipper'
+require 'flipper/middleware/setup_env'
 require 'flipper/middleware/memoizer'
 
 require 'flipper/ui/actor'
@@ -34,15 +35,16 @@ module Flipper
       @root ||= Pathname(__FILE__).dirname.expand_path.join('ui')
     end
 
-    def self.app(flipper, options = {})
-      app = lambda { |env| [200, {'Content-Type' => 'text/html'}, ['']] }
+    def self.app(flipper = nil)
+      app = ->() { [200, { 'Content-Type' => 'text/html' }, ['']] }
       builder = Rack::Builder.new
       yield builder if block_given?
       builder.use Rack::Protection
       builder.use Rack::Protection::AuthenticityToken
       builder.use Rack::MethodOverride
-      builder.use Flipper::Middleware::Memoizer, flipper
-      builder.use Middleware, flipper
+      builder.use Flipper::Middleware::SetupEnv, flipper
+      builder.use Flipper::Middleware::Memoizer
+      builder.use Middleware
       builder.run app
       klass = self
       builder.define_singleton_method(:inspect) { klass.inspect } # pretty rake routes output

data/lib/flipper/ui/action.rb

@@ -9,11 +9,11 @@ module Flipper
       extend Forwardable
 
       VALID_REQUEST_METHOD_NAMES = Set.new([
-        "get".freeze,
-        "post".freeze,
-        "put".freeze,
-        "delete".freeze,
-      ]).freeze
+                                             'get'.freeze,
+                                             'post'.freeze,
+                                             'put'.freeze,
+                                             'delete'.freeze,
+                                           ]).freeze
 
       # Public: Call this in subclasses so the action knows its route.
       #
@@ -60,14 +60,16 @@ module Flipper
       def_delegator :@request, :params
 
       def initialize(flipper, request)
-        @flipper, @request = flipper, request
+        @flipper = flipper
+        @request = request
         @code = 200
-        @headers = {"Content-Type" => "text/plain"}
-        @breadcrumbs = if Flipper::UI.application_breadcrumb_href
-          [Breadcrumb.new("App", Flipper::UI.application_breadcrumb_href)]
-        else
-          []
-        end
+        @headers = { 'Content-Type' => 'text/plain' }
+        @breadcrumbs =
+          if Flipper::UI.application_breadcrumb_href
+            [Breadcrumb.new('App', Flipper::UI.application_breadcrumb_href)]
+          else
+            []
+          end
       end
 
       # Public: Runs the request method for the provided request.
@@ -77,7 +79,8 @@ module Flipper
         if valid_request_method? && respond_to?(request_method_name)
           catch(:halt) { send(request_method_name) }
         else
-          raise UI::RequestMethodNotSupported, "#{self.class} does not support request method #{request_method_name.inspect}"
+          raise UI::RequestMethodNotSupported,
+                "#{self.class} does not support request method #{request_method_name.inspect}"
         end
       end
 
@@ -110,7 +113,7 @@ module Flipper
       #
       # Returns a response.
       def view_response(name)
-        header "Content-Type", "text/html"
+        header 'Content-Type', 'text/html'
         body = view_with_layout { view_without_layout name }
         halt [@code, @headers, [body]]
       end
@@ -132,8 +135,8 @@ module Flipper
       # location - The String location to set the Location header to.
       def redirect_to(location)
         status 302
-        header "Location", "#{script_name}#{location}"
-        halt [@code, @headers, [""]]
+        header 'Location', "#{script_name}#{location}"
+        halt [@code, @headers, ['']]
       end
 
       # Public: Set the status code for the response.
@@ -188,13 +191,11 @@ module Flipper
       def view(name)
         path = views_path.join("#{name}.erb")
 
-        unless path.exist?
-          raise "Template does not exist: #{path}"
-        end
+        raise "Template does not exist: #{path}" unless path.exist?
 
         contents = path.read
         compiled = Eruby.new(contents)
-        compiled.result Proc.new {}.binding
+        compiled.result proc {}.binding
       end
 
       # Internal: The path the app is mounted at.
@@ -218,7 +219,7 @@ module Flipper
       end
 
       def csrf_input_tag
-        %Q(<input type="hidden" name="authenticity_token" value="#{@request.session[:csrf]}">)
+        %(<input type="hidden" name="authenticity_token" value="#{@request.session[:csrf]}">)
       end
 
       def valid_request_method?

data/lib/flipper/ui/action_collection.rb

@@ -11,9 +11,9 @@ module Flipper
       end
 
       def action_for_request(request)
-        @action_classes.detect { |action_class|
+        @action_classes.detect do |action_class|
           request.path_info =~ action_class.regex
-        }
+        end
       end
     end
   end

data/lib/flipper/ui/actions/actors_gate.rb

@@ -13,10 +13,10 @@ module Flipper
           feature = flipper[feature_name.to_sym]
           @feature = Decorators::Feature.new(feature)
 
-          breadcrumb "Home", "/"
-          breadcrumb "Features", "/features"
+          breadcrumb 'Home', '/'
+          breadcrumb 'Features', '/features'
           breadcrumb @feature.key, "/features/#{@feature.key}"
-          breadcrumb "Add Actor"
+          breadcrumb 'Add Actor'
 
           view_response :add_actor
         end
@@ -24,7 +24,7 @@ module Flipper
         def post
           feature_name = Rack::Utils.unescape(request.path.split('/')[-2])
           feature = flipper[feature_name.to_sym]
-          value = params["value"].to_s.strip
+          value = params['value'].to_s.strip
 
           if Util.blank?(value)
             error = Rack::Utils.escape("#{value.inspect} is not a valid actor value.")
@@ -33,10 +33,10 @@ module Flipper
 
           actor = Flipper::UI::Actor.new(value)
 
-          case params["operation"]
-          when "enable"
+          case params['operation']
+          when 'enable'
             feature.enable_actor actor
-          when "disable"
+          when 'disable'
             feature.disable_actor actor
           end
 

data/lib/flipper/ui/actions/add_feature.rb

@@ -11,16 +11,16 @@ module Flipper
           unless Flipper::UI.feature_creation_enabled
             status 403
 
-            breadcrumb "Home", "/"
-            breadcrumb "Features", "/features"
-            breadcrumb "Noooooope"
+            breadcrumb 'Home', '/'
+            breadcrumb 'Features', '/features'
+            breadcrumb 'Noooooope'
 
             halt view_response(:feature_creation_disabled)
           end
 
-          breadcrumb "Home", "/"
-          breadcrumb "Features", "/features"
-          breadcrumb "Add"
+          breadcrumb 'Home', '/'
+          breadcrumb 'Features', '/features'
+          breadcrumb 'Add'
 
           view_response :add_feature
         end

data/lib/flipper/ui/actions/boolean_gate.rb

@@ -8,11 +8,11 @@ module Flipper
         route %r{features/[^/]*/boolean/?\Z}
 
         def post
-          feature_name = Rack::Utils.unescape(request.path.split("/")[-2])
+          feature_name = Rack::Utils.unescape(request.path.split('/')[-2])
           feature = flipper[feature_name.to_sym]
           @feature = Decorators::Feature.new(feature)
 
-          if params["action"] == "Enable"
+          if params['action'] == 'Enable'
             feature.enable
           else
             feature.disable

data/lib/flipper/ui/actions/feature.rb

@@ -5,27 +5,26 @@ module Flipper
   module UI
     module Actions
       class Feature < UI::Action
-
         route %r{features/[^/]*/?\Z}
 
         def get
-          feature_name = Rack::Utils.unescape(request.path.split("/").last)
+          feature_name = Rack::Utils.unescape(request.path.split('/').last)
           @feature = Decorators::Feature.new(flipper[feature_name])
           @page_title = "#{@feature.key} // Features"
           @percentages = [0, 1, 5, 10, 15, 25, 50, 75, 100]
 
-          breadcrumb "Home", "/"
-          breadcrumb "Features", "/features"
+          breadcrumb 'Home', '/'
+          breadcrumb 'Features', '/features'
           breadcrumb @feature.key
 
           view_response :feature
         end
 
         def delete
-          feature_name = Rack::Utils.unescape(request.path.split("/").last)
+          feature_name = Rack::Utils.unescape(request.path.split('/').last)
           feature = flipper[feature_name]
           flipper.adapter.remove(feature)
-          redirect_to "/features"
+          redirect_to '/features'
         end
       end
     end

data/lib/flipper/ui/actions/features.rb

@@ -6,19 +6,18 @@ module Flipper
   module UI
     module Actions
       class Features < UI::Action
-
         route %r{features/?\Z}
 
         def get
-          @page_title = "Features"
-          @features = flipper.features.map { |feature|
+          @page_title = 'Features'
+          @features = flipper.features.map do |feature|
             Decorators::Feature.new(feature)
-          }.sort
+          end.sort
 
           @show_blank_slate = @features.empty?
 
-          breadcrumb "Home", "/"
-          breadcrumb "Features"
+          breadcrumb 'Home', '/'
+          breadcrumb 'Features'
 
           view_response :features
         end
@@ -27,14 +26,14 @@ module Flipper
           unless Flipper::UI.feature_creation_enabled
             status 403
 
-            breadcrumb "Home", "/"
-            breadcrumb "Features", "/features"
-            breadcrumb "Noooooope"
+            breadcrumb 'Home', '/'
+            breadcrumb 'Features', '/features'
+            breadcrumb 'Noooooope'
 
             halt view_response(:feature_creation_disabled)
           end
 
-          value = params["value"].to_s.strip
+          value = params['value'].to_s.strip
 
           if Util.blank?(value)
             error = Rack::Utils.escape("#{value.inspect} is not a valid feature name.")

data/lib/flipper/ui/actions/file.rb

@@ -5,7 +5,6 @@ module Flipper
   module UI
     module Actions
       class File < UI::Action
-
         route %r{(images|css|js|octicons|fonts)/.*\Z}
 
         def get

data/lib/flipper/ui/actions/gate.rb

@@ -8,7 +8,8 @@ module Flipper
         route %r{features/[^/]*/[^/]*/?\Z}
 
         def post
-          feature_name, gate_name = request.path.split('/').pop(2).map{ |value| Rack::Utils.unescape value }
+          feature_name, gate_name = request.path.split('/').pop(2)
+                                           .map(&Rack::Utils.method(:unescape))
           update_gate_method_name = "update_#{gate_name}"
 
           feature = flipper[feature_name.to_sym]
@@ -27,7 +28,9 @@ module Flipper
 
         # Private: Returns error response that gate update method is not defined.
         def update_gate_method_undefined(gate_name)
-          error = Rack::Utils.escape("#{gate_name.inspect} gate does not exist therefore it cannot be updated.")
+          error = Rack::Utils.escape(
+            "#{gate_name.inspect} gate does not exist therefore it cannot be updated."
+          )
           redirect_to("/features/#{@feature.key}?error=#{error}")
         end
       end

data/lib/flipper/ui/actions/groups_gate.rb

@@ -12,10 +12,10 @@ module Flipper
           feature = flipper[feature_name.to_sym]
           @feature = Decorators::Feature.new(feature)
 
-          breadcrumb "Home", "/"
-          breadcrumb "Features", "/features"
+          breadcrumb 'Home', '/'
+          breadcrumb 'Features', '/features'
           breadcrumb @feature.key, "/features/#{@feature.key}"
-          breadcrumb "Add Group"
+          breadcrumb 'Add Group'
 
           view_response :add_group
         end
@@ -23,19 +23,21 @@ module Flipper
         def post
           feature_name = Rack::Utils.unescape(request.path.split('/')[-2])
           feature = flipper[feature_name.to_sym]
-          value = params["value"].to_s.strip
+          value = params['value'].to_s.strip
 
-          case params["operation"]
-          when "enable"
-            feature.enable_group value
-          when "disable"
-            feature.disable_group value
-          end
+          if Flipper.group_exists?(value)
+            case params['operation']
+            when 'enable'
+              feature.enable_group value
+            when 'disable'
+              feature.disable_group value
+            end
 
-          redirect_to("/features/#{feature.key}")
-        rescue Flipper::GroupNotRegistered => e
-          error = Rack::Utils.escape("The group named #{value.inspect} has not been registered.")
-          redirect_to("/features/#{feature.key}/groups?error=#{error}")
+            redirect_to("/features/#{feature.key}")
+          else
+            error = Rack::Utils.escape("The group named #{value.inspect} has not been registered.")
+            redirect_to("/features/#{feature.key}/groups?error=#{error}")
+          end
         end
       end
     end

data/lib/flipper/ui/actions/home.rb

@@ -5,11 +5,10 @@ module Flipper
   module UI
     module Actions
       class Home < UI::Action
-
         route %r{/?\Z}
 
         def get
-          redirect_to "/features"
+          redirect_to '/features'
         end
       end
     end

data/lib/flipper/ui/actions/percentage_of_actors_gate.rb

@@ -8,12 +8,12 @@ module Flipper
         route %r{features/[^/]*/percentage_of_actors/?\Z}
 
         def post
-          feature_name = Rack::Utils.unescape(request.path.split("/")[-2])
+          feature_name = Rack::Utils.unescape(request.path.split('/')[-2])
           feature = flipper[feature_name.to_sym]
           @feature = Decorators::Feature.new(feature)
 
           begin
-            feature.enable_percentage_of_actors params["value"]
+            feature.enable_percentage_of_actors params['value']
           rescue ArgumentError => exception
             error = Rack::Utils.escape("Invalid percentage of actors value: #{exception.message}")
             redirect_to("/features/#{@feature.key}?error=#{error}")

data/lib/flipper/ui/actions/percentage_of_time_gate.rb

@@ -8,12 +8,12 @@ module Flipper
         route %r{features/[^/]*/percentage_of_time/?\Z}
 
         def post
-          feature_name = Rack::Utils.unescape(request.path.split("/")[-2])
+          feature_name = Rack::Utils.unescape(request.path.split('/')[-2])
           feature = flipper[feature_name.to_sym]
           @feature = Decorators::Feature.new(feature)
 
           begin
-            feature.enable_percentage_of_time params["value"]
+            feature.enable_percentage_of_time params['value']
           rescue ArgumentError => exception
             error = Rack::Utils.escape("Invalid percentage of time value: #{exception.message}")
             redirect_to("/features/#{@feature.key}?error=#{error}")