flipper-ui 0.10.2 → 0.11.0.beta1

data/spec/flipper/ui/actions/feature_spec.rb

@@ -1,74 +1,74 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Actions::Feature do
-  let(:token) {
+  let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
       Rack::Protection::AuthenticityToken.random_token
     else
-      "a"
+      'a'
     end
-  }
-  let(:session) {
+  end
+  let(:session) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
-      {:csrf => token}
+      { csrf: token }
     else
-      {"_csrf_token" => token}
+      { '_csrf_token' => token }
     end
-  }
+  end
 
-  describe "DELETE /features/:feature" do
+  describe 'DELETE /features/:feature' do
     before do
       flipper.enable :search
-      delete "/features/search",
-        {"authenticity_token" => token},
-        "rack.session" => session
+      delete '/features/search',
+             { 'authenticity_token' => token },
+             'rack.session' => session
     end
 
-    it "removes feature" do
-      expect(flipper.features.map(&:key)).not_to include("search")
+    it 'removes feature' do
+      expect(flipper.features.map(&:key)).not_to include('search')
     end
 
-    it "redirects to features" do
+    it 'redirects to features' do
       expect(last_response.status).to be(302)
-      expect(last_response.headers["Location"]).to eq("/features")
+      expect(last_response.headers['Location']).to eq('/features')
     end
   end
 
-  describe "POST /features/:feature with _method=DELETE" do
+  describe 'POST /features/:feature with _method=DELETE' do
     before do
       flipper.enable :search
-      post "/features/search",
-        {"_method" => "DELETE", "authenticity_token" => token},
-        "rack.session" => session
+      post '/features/search',
+           { '_method' => 'DELETE', 'authenticity_token' => token },
+           'rack.session' => session
     end
 
-    it "removes feature" do
-      expect(flipper.features.map(&:key)).not_to include("search")
+    it 'removes feature' do
+      expect(flipper.features.map(&:key)).not_to include('search')
     end
 
-    it "redirects to features" do
+    it 'redirects to features' do
       expect(last_response.status).to be(302)
-      expect(last_response.headers["Location"]).to eq("/features")
+      expect(last_response.headers['Location']).to eq('/features')
     end
   end
 
-  describe "GET /features/:feature" do
+  describe 'GET /features/:feature' do
     before do
-      get "/features/search"
+      get '/features/search'
     end
 
-    it "responds with success" do
+    it 'responds with success' do
       expect(last_response.status).to be(200)
     end
 
-    it "renders template" do
-      expect(last_response.body).to include("search")
-      expect(last_response.body).to include("Enable")
-      expect(last_response.body).to include("Disable")
-      expect(last_response.body).to include("Actors")
-      expect(last_response.body).to include("Groups")
-      expect(last_response.body).to include("Percentage of Time")
-      expect(last_response.body).to include("Percentage of Actors")
+    it 'renders template' do
+      expect(last_response.body).to include('search')
+      expect(last_response.body).to include('Enable')
+      expect(last_response.body).to include('Disable')
+      expect(last_response.body).to include('Actors')
+      expect(last_response.body).to include('Groups')
+      expect(last_response.body).to include('Percentage of Time')
+      expect(last_response.body).to include('Percentage of Actors')
     end
   end
 end

data/spec/flipper/ui/actions/features_spec.rb

@@ -1,47 +1,47 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Actions::Features do
-  let(:token) {
+  let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
       Rack::Protection::AuthenticityToken.random_token
     else
-      "a"
+      'a'
     end
-  }
-  let(:session) {
+  end
+  let(:session) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
-      {:csrf => token}
+      { csrf: token }
     else
-      {"_csrf_token" => token}
+      { '_csrf_token' => token }
     end
-  }
+  end
 
-  describe "GET /features" do
+  describe 'GET /features' do
     before do
       flipper[:stats].enable
       flipper[:search].enable
-      get "/features"
+      get '/features'
     end
 
-    it "responds with success" do
+    it 'responds with success' do
       expect(last_response.status).to be(200)
     end
 
-    it "renders template" do
-      expect(last_response.body).to include("stats")
-      expect(last_response.body).to include("search")
+    it 'renders template' do
+      expect(last_response.body).to include('stats')
+      expect(last_response.body).to include('search')
     end
   end
 
-  describe "POST /features" do
-    let(:feature_name) { "notifications_next" }
+  describe 'POST /features' do
+    let(:feature_name) { 'notifications_next' }
 
     before do
       @original_feature_creation_enabled = Flipper::UI.feature_creation_enabled
       Flipper::UI.feature_creation_enabled = feature_creation_enabled
-      post "/features",
-        {"value" => feature_name, "authenticity_token" => token},
-        "rack.session" => session
+      post '/features',
+           { 'value' => feature_name, 'authenticity_token' => token },
+           'rack.session' => session
     end
 
     after do
@@ -51,48 +51,52 @@ RSpec.describe Flipper::UI::Actions::Features do
     context 'feature_creation_enabled set to true' do
       let(:feature_creation_enabled) { true }
 
-      it "adds feature" do
-        expect(flipper.features.map(&:key)).to include("notifications_next")
+      it 'adds feature' do
+        expect(flipper.features.map(&:key)).to include('notifications_next')
       end
 
-      it "redirects to feature" do
+      it 'redirects to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/notifications_next")
+        expect(last_response.headers['Location']).to eq('/features/notifications_next')
       end
 
       context 'feature name contains whitespace' do
-        let(:feature_name) { "  notifications_next   " }
+        let(:feature_name) { '  notifications_next   ' }
 
-        it "adds feature without whitespace" do
-          expect(flipper.features.map(&:key)).to include("notifications_next")
+        it 'adds feature without whitespace' do
+          expect(flipper.features.map(&:key)).to include('notifications_next')
         end
       end
 
-      context "for an invalid feature name" do
-        context "empty feature name" do
-          let(:feature_name) { "" }
+      context 'for an invalid feature name' do
+        context 'empty feature name' do
+          let(:feature_name) { '' }
 
-          it "does not add feature" do
+          it 'does not add feature' do
             expect(flipper.features.map(&:key)).to eq([])
           end
 
-          it "redirects back to feature" do
+          # rubocop:disable Metrics/LineLength
+          it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers["Location"]).to eq("/features/new?error=%22%22+is+not+a+valid+feature+name.")
+            expect(last_response.headers['Location']).to eq('/features/new?error=%22%22+is+not+a+valid+feature+name.')
           end
+          # rubocop:enable Metrics/LineLength
         end
 
-        context "nil feature name" do
+        context 'nil feature name' do
           let(:feature_name) { nil }
 
-          it "does not add feature" do
+          it 'does not add feature' do
             expect(flipper.features.map(&:key)).to eq([])
           end
 
-          it "redirects back to feature" do
+          # rubocop:disable Metrics/LineLength
+          it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers["Location"]).to eq("/features/new?error=%22%22+is+not+a+valid+feature+name.")
+            expect(last_response.headers['Location']).to eq('/features/new?error=%22%22+is+not+a+valid+feature+name.')
           end
+          # rubocop:enable Metrics/LineLength
         end
       end
     end
@@ -100,16 +104,16 @@ RSpec.describe Flipper::UI::Actions::Features do
     context 'feature_creation_enabled set to false' do
       let(:feature_creation_enabled) { false }
 
-      it "does not add feature" do
-        expect(flipper.features.map(&:key)).to_not include("notifications_next")
+      it 'does not add feature' do
+        expect(flipper.features.map(&:key)).not_to include('notifications_next')
       end
 
-      it "returns 403" do
+      it 'returns 403' do
         expect(last_response.status).to be(403)
       end
 
-      it "renders feature creation disabled template" do
-        expect(last_response.body).to include("Feature creation is disabled.")
+      it 'renders feature creation disabled template' do
+        expect(last_response.body).to include('Feature creation is disabled.')
       end
     end
   end

data/spec/flipper/ui/actions/file_spec.rb

@@ -1,42 +1,42 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Actions::File do
-  describe "GET /images/logo.png" do
+  describe 'GET /images/logo.png' do
     before do
       get '/images/logo.png'
     end
 
-    it "responds with 200" do
+    it 'responds with 200' do
       expect(last_response.status).to be(200)
     end
   end
 
-  describe "GET /css/application.css" do
+  describe 'GET /css/application.css' do
     before do
       get '/css/application.css'
     end
 
-    it "responds with 200" do
+    it 'responds with 200' do
       expect(last_response.status).to be(200)
     end
   end
 
-  describe "GET /fonts/bootstrap/glyphicons-halflings-regular.eot" do
+  describe 'GET /fonts/bootstrap/glyphicons-halflings-regular.eot' do
     before do
       get '/fonts/bootstrap/glyphicons-halflings-regular.eot'
     end
 
-    it "responds with 200" do
+    it 'responds with 200' do
       expect(last_response.status).to be(200)
     end
   end
 
-  describe "GET /octicons/octicons.eot" do
+  describe 'GET /octicons/octicons.eot' do
     before do
       get '/octicons/octicons.eot'
     end
 
-    it "responds with 200" do
+    it 'responds with 200' do
       expect(last_response.status).to be(200)
     end
   end

data/spec/flipper/ui/actions/gate_spec.rb

@@ -1,37 +1,39 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Actions::Gate do
-  let(:token) {
+  let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
       Rack::Protection::AuthenticityToken.random_token
     else
-      "a"
+      'a'
     end
-  }
-  let(:session) {
+  end
+  let(:session) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
-      {:csrf => token}
+      { csrf: token }
     else
-      {"_csrf_token" => token}
+      { '_csrf_token' => token }
     end
-  }
+  end
 
-  describe "POST /features/:feature/non-existent-gate" do
+  describe 'POST /features/:feature/non-existent-gate' do
     before do
-      post "/features/search/non-existent-gate",
-        {"authenticity_token" => token},
-        "rack.session" => session
+      post '/features/search/non-existent-gate',
+           { 'authenticity_token' => token },
+           'rack.session' => session
     end
 
-    it "responds with redirect" do
+    it 'responds with redirect' do
       expect(last_response.status).to be(302)
     end
 
-    it "escapes error message" do
-      expect(last_response.headers["Location"]).to eq("/features/search?error=%22non-existent-gate%22+gate+does+not+exist+therefore+it+cannot+be+updated.")
+    # rubocop:disable Metrics/LineLength
+    it 'escapes error message' do
+      expect(last_response.headers['Location']).to eq('/features/search?error=%22non-existent-gate%22+gate+does+not+exist+therefore+it+cannot+be+updated.')
     end
+    # rubocop:enable Metrics/LineLength
 
-    it "renders error in template" do
+    it 'renders error in template' do
       follow_redirect!
       expect(last_response.body).to match(/non-existent-gate.*gate does not exist/)
     end

data/spec/flipper/ui/actions/groups_gate_spec.rb

@@ -1,129 +1,136 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Actions::GroupsGate do
-  let(:token) {
+  let(:token) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
       Rack::Protection::AuthenticityToken.random_token
     else
-      "a"
+      'a'
     end
-  }
-  let(:session) {
+  end
+
+  let(:session) do
     if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
-      {:csrf => token}
+      { csrf: token }
     else
-      {"_csrf_token" => token}
+      { '_csrf_token' => token }
     end
-  }
+  end
 
-  describe "GET /features/:feature/groups" do
+  describe 'GET /features/:feature/groups' do
     before do
-      Flipper.register(:admins) { |user| user.admin? }
-      get "features/search/groups"
+      Flipper.register(:admins, &:admin?)
+      get 'features/search/groups'
     end
 
     after do
       Flipper.unregister_groups
     end
 
-    it "responds with success" do
+    it 'responds with success' do
       expect(last_response.status).to be(200)
     end
 
-    it "renders add new group form" do
+    it 'renders add new group form' do
       expect(last_response.body).to include('<form action="/features/search/groups" method="post">')
     end
   end
 
-  describe "POST /features/:feature/groups" do
-    let(:group_name) { "admins" }
+  describe 'POST /features/:feature/groups' do
+    let(:group_name) { 'admins' }
 
     before do
-      Flipper.register(:admins) { |user| user.admin? }
+      Flipper.register(:admins, &:admin?)
     end
 
     after do
       Flipper.unregister_groups
     end
 
-    context "enabling a group" do
+    context 'enabling a group' do
       before do
-        post "features/search/groups",
-          {"value" => group_name, "operation" => "enable", "authenticity_token" => token},
-          "rack.session" => session
+        post 'features/search/groups',
+             { 'value' => group_name, 'operation' => 'enable', 'authenticity_token' => token },
+             'rack.session' => session
       end
 
-      it "adds item to members" do
-        expect(flipper[:search].groups_value).to include("admins")
+      it 'adds item to members' do
+        expect(flipper[:search].groups_value).to include('admins')
       end
 
-      it "redirects back to feature" do
+      it 'redirects back to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/search")
+        expect(last_response.headers['Location']).to eq('/features/search')
       end
 
       context 'group name contains whitespace' do
-        let(:group_name) { "  admins  " }
+        let(:group_name) { '  admins  ' }
 
-        it "adds item without whitespace" do
-          expect(flipper[:search].groups_value).to include("admins")
+        it 'adds item without whitespace' do
+          expect(flipper[:search].groups_value).to include('admins')
         end
       end
 
-      context "for an unregistered group" do
-        context "unknown group name" do
-          let(:group_name) { "not_here" }
+      context 'for an unregistered group' do
+        context 'unknown group name' do
+          let(:group_name) { 'not_here' }
 
-          it "redirects back to feature" do
+          # rubocop:disable Metrics/LineLength
+          it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers["Location"]).to eq("/features/search/groups?error=The+group+named+%22not_here%22+has+not+been+registered.")
+            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The+group+named+%22not_here%22+has+not+been+registered.')
           end
+          # rubocop:enable Metrics/LineLength
         end
 
-        context "empty group name" do
-          let(:group_name) { "" }
+        context 'empty group name' do
+          let(:group_name) { '' }
 
-          it "redirects back to feature" do
+          # rubocop:disable Metrics/LineLength
+          it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers["Location"]).to eq("/features/search/groups?error=The+group+named+%22%22+has+not+been+registered.")
+            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The+group+named+%22%22+has+not+been+registered.')
           end
+          # rubocop:enable Metrics/LineLength
         end
 
-        context "nil group name" do
+        context 'nil group name' do
           let(:group_name) { nil }
 
-          it "redirects back to feature" do
+          # rubocop:disable Metrics/LineLength
+          it 'redirects back to feature' do
             expect(last_response.status).to be(302)
-            expect(last_response.headers["Location"]).to eq("/features/search/groups?error=The+group+named+%22%22+has+not+been+registered.")
+            expect(last_response.headers['Location']).to eq('/features/search/groups?error=The+group+named+%22%22+has+not+been+registered.')
           end
+          # rubocop:enable Metrics/LineLength
         end
       end
     end
 
-    context "disabling a group" do
-      let(:group_name) { "admins" }
+    context 'disabling a group' do
+      let(:group_name) { 'admins' }
 
       before do
         flipper[:search].enable_group :admins
-        post "features/search/groups",
-          {"value" => group_name, "operation" => "disable", "authenticity_token" => token},
-          "rack.session" => session
+        post 'features/search/groups',
+             { 'value' => group_name, 'operation' => 'disable', 'authenticity_token' => token },
+             'rack.session' => session
       end
 
-      it "removes item from members" do
-        expect(flipper[:search].groups_value).not_to include("admins")
+      it 'removes item from members' do
+        expect(flipper[:search].groups_value).not_to include('admins')
       end
 
-      it "redirects back to feature" do
+      it 'redirects back to feature' do
         expect(last_response.status).to be(302)
-        expect(last_response.headers["Location"]).to eq("/features/search")
+        expect(last_response.headers['Location']).to eq('/features/search')
       end
 
       context 'group name contains whitespace' do
-        let(:group_name) { "  admins  " }
+        let(:group_name) { '  admins  ' }
 
-        it "removes item without whitespace" do
-          expect(flipper[:search].groups_value).not_to include("admins")
+        it 'removes item without whitespace' do
+          expect(flipper[:search].groups_value).not_to include('admins')
         end
       end
     end