finapps 5.0.32 → 5.0.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 05c3cbe0d36260925c0a4ca37018f711a959dc0607b4d379b9adb048ef76a0c9
-  data.tar.gz: 1a519b374d9345074573372872fcc731f7b55111adc47be50ce549f7db5b913d
+  metadata.gz: 7bc0442f42cabf196882b3f3d0ae8f1ae5d9f36f49884169dd34c0accafa5537
+  data.tar.gz: 75be45fb19c5f5fb86e67e683ff436cc7e213676112eb8c132517526d3fdafcd
 SHA512:
-  metadata.gz: 79b1294efebc55a4eb589511df152268a6afbd135b9d06c0d159d8beecdb3d5c968cd5f1978dfac92934d8f1e8464004f21f7327631f236ee53b084ac1ac1858
-  data.tar.gz: b333304eae828c57e73751fa1a09f5d3da6582499eab129ff4421ac8726c204cef74a6a5d90591f41e5c9a82d9dfeb5e4422cbf738b685fcdc83cf70a38a2945
+  metadata.gz: 34ea2347a6692389744647a4143830219b0f5d9160e6e7324724f73eba7807965cc019e7000cc7621f41c34a116e6442f1279995bfac46b318936abc26cd96fc
+  data.tar.gz: 071c55d0059d031bae2dafc12ed7d242de5afb49f03b49ea07552a0f877e7e1ad4278bed42769d44622ecb30231ea26a4de7dd42ade2f2618fe94ddf5c17e3b6

data/.rubocop.yml

@@ -1,26 +1,59 @@
+inherit_from: .rubocop_todo.yml
+
+require: 
+  - rubocop-rspec
+  - rubocop-performance
+
 AllCops:
-  DisplayCopNames: true
+  TargetRubyVersion: 2.6
   Exclude:
-  - "finapps.gemspec"
-  UseCache: false
+    - "vendor/**/*"
+    - "bin/**/*"
+  CacheRootDirectory: tmp
 
-# Commonly used screens these days easily fit more than 80 characters.
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceInsideBlockBraces:
+  # The space here provides no real gain in readability while consuming
+  # horizontal space that could be used for a better parameter name.
+  # Also {| differentiates better from a hash than { | does.
+  SpaceBeforeBlockParameters: false
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+Layout/DotPosition:
+  Description: Checks the position of the dot in multi-line method calls.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
+  Enabled: true
+  EnforcedStyle: leading
+  SupportedStyles:
+  - leading
+  - trailing
 Layout/LineLength:
-  Max: 120
+  Max: 110
 
-Style/CollectionMethods:
-  Description: Preferred collection methods.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
+Lint/DeprecatedOpenSSLConstant:
   Enabled: true
-  PreferredMethods:
-    collect: map
-    collect!: map!
-    find: detect
-    find_all: select
-    reduce: inject
-Style/OptionHash:
-  Description: Don't use option hashes when you can use keyword arguments.
-  Enabled: false
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+
+Metrics/ClassLength:
+  Exclude:
+    - app/controllers/orders_controller.rb
+    - app/models/order.rb
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+  Exclude:
+    - config/environments/**/**
+    - Guardfile
+    - config/routes.rb
+    - config/Guardfile
+
 Naming/PredicateName:
   Description: Check the names of predicate methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
@@ -33,54 +66,94 @@ Naming/PredicateName:
   - is_
   Exclude:
   - spec/**/*
-Metrics/AbcSize:
-  Description: A calculated magnitude based on number of assignments, branches, and
-    conditions.
-  Enabled: false
-  Max: 15
-Metrics/BlockLength:
-  ExcludedMethods: ['describe', 'context']
-Metrics/ClassLength:
-  Description: Avoid classes longer than 100 lines of code.
-  Enabled: false
-  CountComments: false
-  Max: 100
-Metrics/ModuleLength:
-  CountComments: false
-  Max: 100
-  Description: Avoid modules longer than 100 lines of code.
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Description: A complexity metric that is strongly correlated to the number of test
-    cases needed to validate a method.
-  Enabled: false
-  Max: 6
-Metrics/MethodLength:
-  Description: Avoid methods longer than 10 lines of code.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#short-methods
+
+RSpec/FilePath:
   Enabled: false
-  CountComments: false
-  Max: 10
-Metrics/ParameterLists:
-  Description: Avoid parameter lists longer than three or four parameters.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#too-many-params
+    
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+Style/CollectionMethods:
+  Description: Preferred collection methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
+  Enabled: true
+  PreferredMethods:
+    collect: map
+    collect!: map!
+    find: detect
+    find_all: select
+    reduce: inject
+Style/GuardClause:
+  Description: Check for conditionals that can be replaced with guard clauses
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals
+  Enabled: true
+  MinBodyLength: 1
+Style/OptionHash:
+  Description: Don't use option hashes when you can use keyword arguments.
   Enabled: false
-  Max: 5
-  CountKeywordArgs: true
-Metrics/PerceivedComplexity:
-  Description: A complexity metric geared towards measuring complexity for a human
-    reader.
+Style/PercentLiteralDelimiters:
+  Description: Use `%`-literal delimiters consistently
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#percent-literal-braces
   Enabled: false
-  Max: 7
+  PreferredDelimiters:
+    "%": "()"
+    "%i": "()"
+    "%q": "()"
+    "%Q": "()"
+    "%r": "{}"
+    "%s": "()"
+    "%w": "()"
+    "%W": "()"
+    "%x": "()"
+Style/SignalException:
+  Description: Checks for proper usage of fail and raise.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#fail-method
+  Enabled: true
+  EnforcedStyle: semantic
+  SupportedStyles:
+  - only_raise
+  - only_fail
+  - semantic
+Style/StringLiterals:
+  Description: Checks if uses of quotes match the configured preference.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/StringLiteralsInInterpolation:
+  Description: Checks if uses of quotes inside expressions in interpolated strings
+    match the configured preference.
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
 Style/Documentation:
   Description: Document classes and non-namespace modules.
   Enabled: false
-Style/EmptyLiteral:
-  Description: Prefer literals to Array.new/Hash.new/String.new.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#literal-array-hash
-  Enabled: false
-Style/VariableInterpolation:
-  Description: Don't interpolate global, instance and class variables directly in
-    strings.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
+Style/OneLineConditional:
+  Description: Favor the ternary operator(?:) over if/then/else/end constructs.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#ternary-operator
   Enabled: false
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
+RSpec/NestedGroups:
+  Max: 5
+RSpec/DescribeClass:
+  Exclude:
+    - spec/system/*
+    - spec/factories_spec.rb

data/.rubocop_todo.yml

@@ -0,0 +1,120 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-06-24 14:28:46 UTC using RuboCop version 0.86.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 119
+
+# Offense count: 1
+# Configuration parameters: IgnoredMethods.
+Metrics/AbcSize:
+  Max: 16
+
+# Offense count: 1
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 28
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 431
+
+# Offense count: 3
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 16
+
+# Offense count: 29
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/rest/client_spec.rb'
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/documents_orders_notifications_spec.rb'
+    - 'spec/rest/operators_password_resets_spec.rb'
+    - 'spec/rest/operators_spec.rb'
+    - 'spec/rest/order_notifications_spec.rb'
+    - 'spec/rest/order_tokens_spec.rb'
+    - 'spec/rest/orders_spec.rb'
+    - 'spec/rest/portfolios_consumers_spec.rb'
+    - 'spec/rest/sessions_spec.rb'
+
+# Offense count: 6
+RSpec/DescribeMethod:
+  Exclude:
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/operators_password_resets_spec.rb'
+    - 'spec/rest/operators_spec.rb'
+    - 'spec/rest/order_tokens_spec.rb'
+    - 'spec/rest/products_spec.rb'
+    - 'spec/rest/sessions_spec.rb'
+
+# Offense count: 5
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/documents_orders_spec.rb'
+    - 'spec/rest/orders_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 13
+RSpec/MultipleExpectations:
+  Max: 3
+
+# Offense count: 114
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/rest/client_spec.rb'
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/documents_orders_spec.rb'
+    - 'spec/rest/order_reports_spec.rb'
+    - 'spec/rest/order_statuses_spec.rb'
+    - 'spec/rest/order_tokens_spec.rb'
+    - 'spec/rest/orders_spec.rb'
+    - 'spec/rest/password_resets_spec.rb'
+    - 'spec/rest/plaid/plaid_consumer_institutions_spec.rb'
+    - 'spec/rest/sessions_spec.rb'
+    - 'spec/rest/signed_documents_downloads_spec.rb'
+    - 'spec/rest/verix/verix_documents_spec.rb'
+    - 'spec/rest/verix/verix_pdf_documents_spec.rb'
+    - 'spec/rest/version_spec.rb'
+
+# Offense count: 6
+RSpec/RepeatedExample:
+  Exclude:
+    - 'spec/rest/signed_documents_downloads_spec.rb'
+    - 'spec/rest/verix/verix_documents_spec.rb'
+    - 'spec/rest/verix/verix_pdf_documents_spec.rb'
+
+# Offense count: 2
+RSpec/RepeatedExampleGroupBody:
+  Exclude:
+    - 'spec/rest/client_spec.rb'
+
+# Offense count: 4
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'spec/rest/client_spec.rb'
+
+# Offense count: 1
+RSpec/SubjectStub:
+  Exclude:
+    - 'spec/rest/orders_spec.rb'

data/.tmuxinator.yml

@@ -11,6 +11,7 @@ windows:
           - git pull
           - git status
           - bundle
+          - bundle outdated
   - 
     guard: 
       layout: even-horizontal

data/.travis.yml

@@ -1,5 +1,7 @@
-sudo: false
 language: ruby
+os: ["linux"]
+dist: "xenial"
+
 cache:
   bundler: true
 

data/finapps.gemspec

@@ -29,9 +29,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'guard-rspec',                '~> 4.7',   '>= 4.7.3'
   spec.add_development_dependency 'rake',                       '~> 13.0',  '>= 13.0.1'
   spec.add_development_dependency 'rspec',                      '~> 3.9',   '>= 3.9.0'
-  spec.add_development_dependency 'rubocop',                    '~> 0.79',  '>= 0.79.0'
-  spec.add_development_dependency 'rubocop-performance',        '~> 1.5',   '>= 1.5.2'
-  spec.add_development_dependency 'rubocop-rspec',              '~> 1.37',  '>= 1.37.1'
+  spec.add_development_dependency 'rubocop',                    '~> 0.86',  '>= 0.86.0'
+  spec.add_development_dependency 'rubocop-performance',        '~> 1.6',   '>= 1.6.1'
+  spec.add_development_dependency 'rubocop-rspec',              '~> 1.40',  '>= 1.40.0'
   spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.8'
   spec.add_development_dependency 'webmock',                    '~> 3.8',   '>= 3.8.0'
 

data/lib/finapps/rest/alert_definitions.rb

@@ -8,7 +8,7 @@ module FinApps
 
       def list(params = nil)
         return super END_POINT if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(END_POINT, params)
       end

data/lib/finapps/rest/alert_occurrences.rb

@@ -8,7 +8,7 @@ module FinApps
 
       def list(params = nil)
         return super END_POINT if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(END_POINT, params)
       end

data/lib/finapps/rest/consumers.rb

@@ -15,7 +15,7 @@ module FinApps
 
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end
@@ -62,15 +62,15 @@ module FinApps
 
       def with_space_search(term)
         [
-          { "email": term },
-          { "first_name": term },
-          { "last_name": term }
+          {"email": term},
+          {"first_name": term},
+          {"last_name": term}
         ]
       end
 
       def name_search(term)
         search_arr = []
-        if term.match(/\s/)
+        if /\s/.match?(term)
           term.split.each do |t|
             search_arr.append("first_name": t)
             search_arr.append("last_name": t)

data/lib/finapps/rest/consumers_portfolios.rb

@@ -11,7 +11,7 @@ module FinApps
         path = "consumers/#{ERB::Util.url_encode(id)}/portfolios"
         return super path if params.nil?
 
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end

data/lib/finapps/rest/documents_orders.rb

@@ -10,7 +10,7 @@ module FinApps
       def list(params = nil)
         path = 'documents/orders'
         return super(path) if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end
@@ -46,23 +46,22 @@ module FinApps
       private
 
       def build_filter(params)
-        search_query(params[:searchTerm]).merge(consumer_query(params[:consumer])).merge(tag_query(params[:tag]))
+        search_query(params[:searchTerm])
+          .merge(consumer_query(params[:consumer]))
+          .merge(tag_query(params[:tag]))
+          .merge(status_query(params[:status]))
       end
 
       def search_query(term)
-        if term
-          query = with_space_search(term).concat(name_search(term))
-          {
-            "$or": query
-          }
-        else
-          {}
-        end
+        return {} unless term
+
+        query = with_space_search(term).concat(name_search(term))
+        {"$or": query}
       end
 
       def name_search(term)
         search_arr = []
-        if term.match(/\s/)
+        if /\s/.match?(term)
           term.split.each do |t|
             search_arr.append("applicant.first_name": t)
             search_arr.append("applicant.last_name": t)
@@ -73,9 +72,9 @@ module FinApps
 
       def with_space_search(term)
         [
-          { "applicant.email": term },
-          { "applicant.first_name": term },
-          { "applicant.last_name": term },
+          {"applicant.email": term},
+          {"applicant.first_name": term},
+          {"applicant.last_name": term},
           {
             "reference_no": {
               "$regex": "^#{term}", "$options": 'i'
@@ -85,19 +84,21 @@ module FinApps
       end
 
       def tag_query(tag)
-        if tag
-          { "tag": tag.empty? ? nil : tag }
-        else
-          {}
-        end
+        return {} unless tag
+
+        {"tag": tag.empty? ? nil : tag}
+      end
+
+      def status_query(status)
+        return {} unless status
+
+        {status: status}
       end
 
       def consumer_query(consumer)
-        if consumer
-          { "consumer_id": consumer.empty? ? nil : consumer }
-        else
-          {}
-        end
+        return {} unless consumer
+
+        {"consumer_id": consumer.empty? ? nil : consumer}
       end
     end
   end