finapps 5.0.32 → 5.0.33

data/lib/finapps/rest/operators.rb

@@ -9,7 +9,7 @@ module FinApps
 
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end
@@ -36,7 +36,7 @@ module FinApps
       def update_password(params)
         # update password for current operator, need authorization session in header
         not_blank(params, :params)
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
 
         path = "#{end_point}/password/change"
 
@@ -64,14 +64,14 @@ module FinApps
       end
 
       def search_query(term)
-        { "last_name": term }
+        {"last_name": term}
       end
 
       def role_query(role)
         if role.is_a?(Array)
-          { "role": { "$in": role.map(&:to_i) } }
+          {"role": {"$in": role.map(&:to_i)}}
         else
-          { "role": role.to_i }
+          {"role": role.to_i}
         end
       end
     end

data/lib/finapps/rest/operators_password_resets.rb

@@ -22,7 +22,7 @@ module FinApps
       private
 
       def validates_email(params)
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless email_exists? params
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless email_exists? params
       end
 
       def email_exists?(params)

data/lib/finapps/rest/order_assignments.rb

@@ -6,7 +6,7 @@ module FinApps
       def update(id, orders_array)
         not_blank(id, :operator_id)
         not_blank(orders_array, :params)
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless orders_array.is_a? Array
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless orders_array.is_a? Array
 
         path = "operators/#{ERB::Util.url_encode(id)}/assign"
         super orders_array, path

data/lib/finapps/rest/order_reports.rb

@@ -6,7 +6,7 @@ module FinApps
       def show(id, format)
         not_blank(id, :id)
         not_blank(format, :format)
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: format' unless accepted_format?(format)
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: format' unless accepted_format?(format)
 
         path =
           "orders/#{ERB::Util.url_encode(id)}/report.#{ERB::Util.url_encode(format)}"

data/lib/finapps/rest/orders.rb

@@ -28,7 +28,7 @@ module FinApps
       #
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end
@@ -66,9 +66,9 @@ module FinApps
         if term
           {
             "$or": [
-              { "public_id": { "$regex": "^#{term}", "$options": 'i' } },
-              { "applicant.last_name": term },
-              { "assignment.last_name": term },
+              {"public_id": {"$regex": "^#{term}", "$options": 'i'}},
+              {"applicant.last_name": term},
+              {"assignment.last_name": term},
               {
                 "requestor.reference_no": {
                   "$regex": "^#{term}", "$options": 'i'
@@ -84,9 +84,9 @@ module FinApps
       def status_query(status)
         if status
           if status.is_a?(Array)
-            { "status": { "$in": status.map(&:to_i) } }
+            {"status": {"$in": status.map(&:to_i)}}
           else
-            { "status": status.to_i }
+            {"status": status.to_i}
           end
         else
           {}
@@ -96,7 +96,7 @@ module FinApps
       def assignment_query(assignment)
         # translate "" to null assignment
         if assignment
-          { "assignment.operator_id": assignment.empty? ? nil : assignment }
+          {"assignment.operator_id": assignment.empty? ? nil : assignment}
         else
           {}
         end
@@ -104,7 +104,7 @@ module FinApps
 
       def consumer_query(consumer)
         if consumer
-          { "consumer_id": consumer.empty? ? nil : consumer }
+          {"consumer_id": consumer.empty? ? nil : consumer}
         else
           {}
         end
@@ -114,8 +114,8 @@ module FinApps
         if !search_term && !nil_or_empty?(relation)
           {
             "$or": [
-              { "public_id": { "$in": relation } },
-              { "original_order_id": { "$in": relation } }
+              {"public_id": {"$in": relation}},
+              {"original_order_id": {"$in": relation}}
             ]
           }
         else

data/lib/finapps/rest/plaid/plaid_consumer_institutions.rb

@@ -9,7 +9,7 @@ module FinApps
         super(params, 'p/institution/consumer')
       end
 
-      def show(id, options = { show_accounts: false })
+      def show(id, options = {show_accounts: false})
         results, error_messages = super(nil, "p/institution/consumer/#{id}")
 
         if error_messages.empty? && options[:show_accounts]

data/lib/finapps/rest/portfolio_reports.rb

@@ -9,7 +9,7 @@ module FinApps
         path = 'portfolio/reports'
 
         return super path if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end

data/lib/finapps/rest/portfolios.rb

@@ -7,7 +7,7 @@ module FinApps
 
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end

data/lib/finapps/rest/portfolios_available_consumers.rb

@@ -12,7 +12,7 @@ module FinApps
           "portfolios/#{ERB::Util.url_encode(portfolio_id)}/consumers/available"
         return super path if params.nil?
 
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end

data/lib/finapps/rest/portfolios_consumers.rb

@@ -11,7 +11,7 @@ module FinApps
         path = build_path(portfolio_id)
         return super path if params.nil?
 
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(path, params)
       end

data/lib/finapps/rest/sessions.rb

@@ -8,7 +8,7 @@ module FinApps
 
       def create(params, path = nil)
         return super nil, path if path == LOGOUT
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
 
         path ||= CONSUMER_LOGIN
 

data/lib/finapps/rest/signed_documents_downloads.rb

@@ -6,8 +6,10 @@ module FinApps
       def show(consumer_id, signature_request_id)
         not_blank(consumer_id, :consumer_id)
         not_blank(signature_request_id, :signature_request_id)
+
         path =
-          "consumers/#{ERB::Util.url_encode(consumer_id)}/documents/#{ERB::Util.url_encode(signature_request_id)}"
+          "consumers/#{ERB::Util.url_encode(consumer_id)}/"\
+          "documents/#{ERB::Util.url_encode(signature_request_id)}"
         super(nil, path)
       end
     end

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '5.0.32'
+  VERSION = '5.0.33'
 end

data/spec/rest/alert_definitions_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::AlertDefinitions do
   include SpecHelpers::Client
-  subject { FinApps::REST::AlertDefinitions.new(client) }
+  subject { described_class.new(client) }
 
   describe '#list' do
     let(:list) { subject.list(params) }
@@ -16,9 +16,11 @@ RSpec.describe FinApps::REST::AlertDefinitions do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -29,14 +31,17 @@ RSpec.describe FinApps::REST::AlertDefinitions do
     end
 
     context 'when including valid params' do
-      let(:params) { { page: 2, sort: '-created_date', requested: 25 } }
+      let(:params) { {page: 2, sort: '-created_date', requested: 25} }
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
+
       it 'builds query and sends proper request' do
         list
         url =
@@ -63,10 +68,12 @@ RSpec.describe FinApps::REST::AlertDefinitions do
 
       it { expect { show }.not_to raise_error }
       it('returns an array') { expect(show).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:_id)
         expect(results).to have_key(:rule_name)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -75,6 +82,7 @@ RSpec.describe FinApps::REST::AlertDefinitions do
 
       it { expect { show }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end

data/spec/rest/alert_occurrences_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::AlertOccurrences do
   include SpecHelpers::Client
-  subject { FinApps::REST::AlertOccurrences.new(client) }
+  subject { described_class.new(client) }
 
   describe '#list' do
     let(:list) { subject.list(params) }
@@ -16,9 +16,11 @@ RSpec.describe FinApps::REST::AlertOccurrences do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -40,10 +42,13 @@ RSpec.describe FinApps::REST::AlertOccurrences do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
+
       it 'builds query and sends proper request' do
         list
         url =

data/spec/rest/api_request.rb

@@ -7,6 +7,7 @@ RSpec.shared_examples 'an API request' do |_parameter|
       subject
     end.not_to raise_error
   end
+
   it('returns an array') { expect(subject).to be_a(Array) }
 end
 

data/spec/rest/client_spec.rb

@@ -3,14 +3,14 @@
 RSpec.describe FinApps::REST::Client do
   describe '#new' do
     it 'raises for missing company_token' do
-      expect { FinApps::REST::Client.new nil }.to raise_error(
+      expect { described_class.new nil }.to raise_error(
         FinAppsCore::MissingArgumentsError
       )
     end
   end
 
   context 'an instance of Client' do
-    subject { FinApps::REST::Client.new(:company_token) }
+    subject { described_class.new(:company_token) }
 
     FinApps::REST::Client::RESOURCES.each do |method|
       it("responds to #{method}") { expect(subject).to respond_to(method) }

data/spec/rest/consumers_portfolios_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::ConsumersPortfolios do
   include SpecHelpers::Client
-  subject { FinApps::REST::ConsumersPortfolios.new(client) }
+  subject { described_class.new(client) }
 
   describe '#list' do
     let(:list) { subject.list(id, params) }
@@ -24,9 +24,11 @@ RSpec.describe FinApps::REST::ConsumersPortfolios do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -39,14 +41,17 @@ RSpec.describe FinApps::REST::ConsumersPortfolios do
 
     context 'when including valid params' do
       let(:id) { 'valid_id' }
-      let(:params) { { page: 2, sort: '-created_date', requested: 25 } }
+      let(:params) { {page: 2, sort: '-created_date', requested: 25} }
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
+
       it 'builds query and sends proper request' do
         list
         url =

data/spec/rest/consumers_spec.rb

@@ -4,7 +4,8 @@ require 'spec_helpers/client'
 RSpec.describe FinApps::REST::Consumers,
                'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
-  subject(:users) { FinApps::REST::Consumers.new(client) }
+  subject(:users) { described_class.new(client) }
+
   missing_public_id = ': public_id'
 
   describe '#create' do
@@ -24,9 +25,11 @@ RSpec.describe FinApps::REST::Consumers,
 
       it { expect { create }.not_to raise_error }
       it('results is a Hash') { expect(results).to be_a(Hash) }
+
       it('performs a post and returns the response') do
         expect(results).to have_key(:public_id)
       end
+
       it('error_messages array is empty') { expect(error_messages).to eq([]) }
     end
 
@@ -35,6 +38,7 @@ RSpec.describe FinApps::REST::Consumers,
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(error_messages.first.downcase).to eq('invalid request body')
       end
@@ -48,10 +52,13 @@ RSpec.describe FinApps::REST::Consumers,
 
     context 'when missing params' do
       let(:params) { nil }
-      it { expect { list }.to_not raise_error }
+
+      it { expect { list }.not_to raise_error }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns an array of records') { expect(results[:records]).to be_a(Array) }
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
@@ -70,14 +77,17 @@ RSpec.describe FinApps::REST::Consumers,
         }
       end
 
-      it { expect { list }.to_not raise_error }
+      it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') do
         expect(error_messages).to be_empty
       end
+
       it 'builds query and sends proper request' do
         list
         url = "#{versioned_api_path}/consumers?page=3&requested=19"
@@ -95,19 +105,24 @@ RSpec.describe FinApps::REST::Consumers,
         }
       end
 
-      it { expect { list }.to_not raise_error }
+      it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') do
         expect(error_messages).to be_empty
       end
+
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/consumers?filter=%7B%22$or%22:%5B%7B%22email%22:%22term%22%7D," \
-            '%7B%22first_name%22:%22term%22%7D,%7B%22last_name%22:%22term%22%7D%5D%7D&page=2&requested=25' \
-            '&sort=date_created'
+        url = "#{versioned_api_path}/consumers?"\
+          'filter=%7B%22$or%22:%5B%7B%22email%22:%22term%22%7D,' \
+          '%7B%22first_name%22:%22term%22%7D,'\
+          '%7B%22last_name%22:%22term%22%7D%5D%7D&page=2&requested=25' \
+          '&sort=date_created'
         expect(WebMock).to have_requested(:get, url)
       end
 
@@ -120,12 +135,16 @@ RSpec.describe FinApps::REST::Consumers,
             searchTerm: 'Two terms'
           }
         end
+
         it 'treats space as start of a new query for first and last name' do
           list
-          url = "#{versioned_api_path}/consumers?filter=%7B%22$or%22:%5B%7B%22email%22:%22Two%20terms%22%7D,"\
-              '%7B%22first_name%22:%22Two%20terms%22%7D,%7B%22last_name%22:%22Two%20terms%22%7D,%7B%22first_name%22:'\
-              '%22Two%22%7D,%7B%22last_name%22:%22Two%22%7D,%7B%22first_name%22:%22terms%22%7D,%7B%22last_name%22:'\
-              '%22terms%22%7D%5D%7D&page=2&requested=25&sort=date_created'
+          url = "#{versioned_api_path}/consumers?"\
+            'filter=%7B%22$or%22:%5B%7B%22email%22:%22Two%20terms%22%7D,'\
+            '%7B%22first_name%22:%22Two%20terms%22%7D,'\
+            '%7B%22last_name%22:%22Two%20terms%22%7D,%7B%22first_name%22:'\
+            '%22Two%22%7D,%7B%22last_name%22:%22Two%22%7D,'\
+            '%7B%22first_name%22:%22terms%22%7D,%7B%22last_name%22:'\
+            '%22terms%22%7D%5D%7D&page=2&requested=25&sort=date_created'
           expect(WebMock).to have_requested(:get, url)
         end
       end
@@ -149,9 +168,11 @@ RSpec.describe FinApps::REST::Consumers,
 
       it { expect { show }.not_to raise_error }
       it('results is a Hash') { expect(results).to be_a(Hash) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:public_id)
       end
+
       it('error_messages array is empty') { expect(error_messages).to eq([]) }
     end
 
@@ -162,6 +183,7 @@ RSpec.describe FinApps::REST::Consumers,
 
       it { expect { show }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(error_messages.first.downcase).to eq('resource not found')
       end
@@ -198,6 +220,7 @@ RSpec.describe FinApps::REST::Consumers,
 
         it { expect { update }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
+
         it('error messages array is populated') do
           expect(error_messages.first.downcase).to eq(
             'invalid user id specified.'
@@ -219,12 +242,15 @@ RSpec.describe FinApps::REST::Consumers,
 
         it { expect { update }.not_to raise_error }
         it('results is a Hash') { expect(results).to be_a(Hash) }
+
         it('the public_id is on the results') do
           expect(results).to have_key(:public_id)
         end
+
         it('the new token is on the results') do
           expect(results).to have_key(:token)
         end
+
         it('error_messages array is empty') { expect(error_messages).to eq([]) }
       end
 
@@ -240,6 +266,7 @@ RSpec.describe FinApps::REST::Consumers,
 
         it { expect { update }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
+
         it('error messages array is populated') do
           expect(error_messages.first.downcase).to eq('resource not found')
         end
@@ -273,6 +300,7 @@ RSpec.describe FinApps::REST::Consumers,
 
         it { expect { destroy }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
+
         it('error messages array is populated') do
           expect(error_messages.first.downcase).to eq('resource not found')
         end