finapps 5.0.32 → 5.0.33

data/spec/rest/order_assignments_spec.rb

@@ -6,12 +6,14 @@ RSpec.describe FinApps::REST::OrderAssignments do
   include SpecHelpers::Client
 
   describe '#update' do
-    subject(:order_assignments) { FinApps::REST::OrderAssignments.new(client) }
+    subject(:order_assignments) { described_class.new(client) }
+
     let(:results) { update[RESULTS] }
     let(:error_messages) { update[ERROR_MESSAGES] }
 
     context 'when missing id' do
       let(:update) { subject.update(nil, []) }
+
       it('returns missing argument error') do
         expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
@@ -19,6 +21,7 @@ RSpec.describe FinApps::REST::OrderAssignments do
 
     context 'when missing params' do
       let(:update) { subject.update(:valid_id, nil) }
+
       it('returns missing argument error') do
         expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
@@ -26,6 +29,7 @@ RSpec.describe FinApps::REST::OrderAssignments do
 
     context 'with invalid params' do
       let(:update) { subject.update(:valid_id, params: 'params') }
+
       it('returns invalid argument error') do
         expect { update }.to raise_error(FinAppsCore::InvalidArgumentsError)
       end
@@ -36,6 +40,7 @@ RSpec.describe FinApps::REST::OrderAssignments do
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(error_messages.first.downcase).to eq('resource not found')
       end

data/spec/rest/order_notifications_spec.rb

@@ -6,10 +6,11 @@ RSpec.describe FinApps::REST::OrderNotifications do
   include SpecHelpers::Client
 
   describe '#update' do
-    subject(:orders) { FinApps::REST::OrderNotifications.new(client) }
+    subject(:orders) { described_class.new(client) }
 
     context 'when missing id' do
       let(:update) { subject.update(nil) }
+
       it('returns missing argument error') do
         expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
@@ -22,6 +23,7 @@ RSpec.describe FinApps::REST::OrderNotifications do
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(error_messages.first.downcase).to eq('resource not found')
       end

data/spec/rest/order_refreshes_spec.rb

@@ -4,11 +4,12 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::OrderRefreshes do
   include SpecHelpers::Client
-  subject { FinApps::REST::OrderRefreshes.new(client) }
+  subject { described_class.new(client) }
 
   describe '#create' do
     context 'when missing id' do
       let(:create) { subject.create(nil) }
+
       it do
         expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
@@ -16,12 +17,15 @@ RSpec.describe FinApps::REST::OrderRefreshes do
 
     context 'when valid id is provided' do
       let(:create) { subject.create(:valid_id) }
+
       it { expect { create }.not_to raise_error }
       it('returns an array') { expect(create).to be_a(Array) }
+
       it('performs a post and returns new refreshed order response') do
         expect(create[RESULTS]).to have_key(:public_id)
         expect(create[RESULTS]).to have_key(:original_order_id)
       end
+
       it('returns no error messages') do
         expect(create[ERROR_MESSAGES]).to be_empty
       end
@@ -29,9 +33,11 @@ RSpec.describe FinApps::REST::OrderRefreshes do
 
     context 'when invalid id is provided' do
       let(:create) { subject.create(:invalid_id) }
+
       it { expect { create }.not_to raise_error }
       it('returns an array') { expect(create).to be_a(Array) }
       it('results is nil') { expect(create[RESULTS]).to be_nil }
+
       it('error messages array is populated') do
         expect(create[ERROR_MESSAGES].first.downcase).to eq(
           'resource not found'

data/spec/rest/order_reports_spec.rb

@@ -5,11 +5,12 @@ require 'spec_helpers/client'
 RSpec.describe FinApps::REST::OrderReports do
   include SpecHelpers::Client
 
-  let(:order_report) { FinApps::REST::OrderReports.new client }
+  let(:order_report) { described_class.new client }
 
   describe '#show' do
     context 'when missing id' do
       subject { order_report.show(nil, :pdf) }
+
       it do
         expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
@@ -17,6 +18,7 @@ RSpec.describe FinApps::REST::OrderReports do
 
     context 'when missing format' do
       subject { order_report.show(:valid_id, nil) }
+
       it do
         expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
@@ -24,6 +26,7 @@ RSpec.describe FinApps::REST::OrderReports do
 
     context 'when invalid format is provided' do
       subject { order_report.show(:valid_id, :xml) }
+
       it do
         expect { subject }.to raise_error(FinAppsCore::InvalidArgumentsError)
       end
@@ -33,9 +36,11 @@ RSpec.describe FinApps::REST::OrderReports do
       subject { order_report.show(:valid_id, :json) }
 
       it { expect { subject }.not_to raise_error }
+
       it('performs a get and returns the response') do
         expect(subject[0]).to have_key(:days_requested)
       end
+
       it('returns no error messages') { expect(subject[1]).to be_empty }
     end
 
@@ -44,6 +49,7 @@ RSpec.describe FinApps::REST::OrderReports do
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[0]).to be_nil }
+
       it('error messages array is populated') do
         expect(subject[1].first.downcase).to eq('resource not found')
       end

data/spec/rest/order_statuses_spec.rb

@@ -5,29 +5,33 @@ RSpec.describe FinApps::REST::OrderStatuses do
 
   describe '#show' do
     context 'when missing id' do
-      subject { FinApps::REST::OrderStatuses.new(client).show(nil) }
+      subject { described_class.new(client).show(nil) }
+
       it do
         expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
     context 'when valid id is provided' do
-      subject { FinApps::REST::OrderStatuses.new(client).show(:valid_id) }
+      subject { described_class.new(client).show(:valid_id) }
 
       it { expect { subject }.not_to raise_error }
+
       it('performs a get and returns the response') do
         expect(subject[RESULTS]).to have_key(:status)
       end
+
       it('returns no error messages') do
         expect(subject[ERROR_MESSAGES]).to be_empty
       end
     end
 
     context 'when invalid id is provided' do
-      subject { FinApps::REST::OrderStatuses.new(client).show(:invalid_id) }
+      subject { described_class.new(client).show(:invalid_id) }
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULTS]).to be_nil }
+
       it('error messages array is populated') do
         expect(subject[ERROR_MESSAGES].first.downcase).to eq(
           'resource not found'

data/spec/rest/order_tokens_spec.rb

@@ -7,7 +7,8 @@ RSpec.describe FinApps::REST::OrderTokens,
   include SpecHelpers::Client
 
   describe '#show' do
-    subject(:order_tokens) { FinApps::REST::OrderTokens.new(client) }
+    subject(:order_tokens) { described_class.new(client) }
+
     let(:results) { show[RESULTS] }
     let(:error_messages) { show[ERROR_MESSAGES] }
 
@@ -22,18 +23,23 @@ RSpec.describe FinApps::REST::OrderTokens,
 
     context 'for valid token' do
       let(:show) { subject.show(:valid_token) }
+
       it { expect { show }.not_to raise_error }
       it('results is a Hash') { expect(results).to be_a(Hash) }
+
       it('results contains a consumer_id') do
         expect(results).to have_key(:consumer_id)
       end
+
       it('error_messages array is empty') { expect(error_messages).to eq([]) }
     end
 
     context 'for invalid token' do
       let(:show) { subject.show(:invalid_token) }
+
       it { expect { show }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(error_messages.first.downcase).to eq('resource not found')
       end

data/spec/rest/orders_spec.rb

@@ -7,21 +7,24 @@ RSpec.describe FinApps::REST::Orders do
 
   describe '#show' do
     context 'when missing params' do
-      subject { FinApps::REST::Orders.new(client).show(nil) }
+      subject { described_class.new(client).show(nil) }
+
       it do
         expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
     context 'when valid params are provided' do
-      subject { FinApps::REST::Orders.new(client).show(:valid_id) }
+      subject { described_class.new(client).show(:valid_id) }
 
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(subject[RESULTS]).to have_key(:public_id)
         expect(subject[RESULTS]).to have_key(:consumer_id)
       end
+
       it('returns no error messages') do
         expect(subject[ERROR_MESSAGES]).to be_empty
       end
@@ -30,35 +33,41 @@ RSpec.describe FinApps::REST::Orders do
 
   describe '#create' do
     context 'when missing params' do
-      subject { FinApps::REST::Orders.new(client).create(nil) }
+      subject { described_class.new(client).create(nil) }
+
       it do
         expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
     context 'when valid params are provided' do
-      subject { FinApps::REST::Orders.new(client).create(valid_params) }
+      subject { described_class.new(client).create(valid_params) }
+
       let(:valid_params) do
-        { applicant: 'valid', institutions: 'valid', product: 'valid' }
+        {applicant: 'valid', institutions: 'valid', product: 'valid'}
       end
 
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
+
       it('performs a post and returns the response') do
         expect(subject[RESULTS]).to have_key(:public_id)
         expect(subject[RESULTS]).to have_key(:consumer_id)
       end
+
       it('returns no error messages') do
         expect(subject[ERROR_MESSAGES]).to be_empty
       end
     end
 
     context 'when invalid params are provided' do
-      subject { FinApps::REST::Orders.new(client).create(invalid_params) }
-      let(:invalid_params) { { applicant: 'valid' } }
+      subject { described_class.new(client).create(invalid_params) }
+
+      let(:invalid_params) { {applicant: 'valid'} }
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULTS]).to be_nil }
+
       it('error messages array is populated') do
         expect(subject[ERROR_MESSAGES].first.downcase).to eq(
           'invalid request body'
@@ -71,20 +80,24 @@ RSpec.describe FinApps::REST::Orders do
     context 'when missing params' do
       # use defaults
 
-      subject { FinApps::REST::Orders.new(client).list }
+      subject { described_class.new(client).list }
+
       it { expect { subject }.not_to raise_error }
 
       it('returns an array') { expect(subject).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(subject[RESULTS]).to have_key(:orders)
       end
+
       it('returns no error messages') do
         expect(subject[ERROR_MESSAGES]).to be_empty
       end
     end
 
     context 'when invalid params are provided' do
-      subject { FinApps::REST::Orders.new(client).list(invalid_params) }
+      subject { described_class.new(client).list(invalid_params) }
+
       let(:invalid_params) { %w[this is an array] }
 
       it do
@@ -93,7 +106,8 @@ RSpec.describe FinApps::REST::Orders do
     end
 
     context 'when including valid params' do
-      subject { FinApps::REST::Orders.new(client).list(params) }
+      subject { described_class.new(client).list(params) }
+
       let(:params) do
         {
           page: 2,
@@ -109,52 +123,65 @@ RSpec.describe FinApps::REST::Orders do
 
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(subject[RESULTS]).to have_key(:orders)
       end
+
       it('each order contains a consumer_id') do
         expect(subject[RESULTS][:orders]).to all(have_key(:consumer_id))
       end
+
       it('returns no error messages') do
         expect(subject[ERROR_MESSAGES]).to be_empty
       end
+
       it 'builds query and sends proper request' do
         subject
-        url =
-          "#{versioned_api_path}/orders?filter=%7B%22$or%22:%5B%7B%22public_id%22:" \
-            '%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D,%7B%22applicant.last_name%22:%22' \
-            'term%22%7D,%7B%22assignment.last_name%22:%22term%22%7D,%7B%22requestor.reference_no%22:%7B%22' \
-            '$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D%5D,%22status%22:%7B%22$in%22:%5B1,7%5D%7D,' \
-            '%22assignment.operator_id%22:%22valid_operator%22,%22consumer_id%22:%22valid_consumer_id%22%7D' \
-            '&page=2&requested=25&sort=status'
+        url = "#{versioned_api_path}/orders?"\
+          'filter=%7B%22$or%22:%5B%7B%22public_id%22:' \
+          '%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D,'\
+          '%7B%22applicant.last_name%22:%22' \
+          'term%22%7D,%7B%22assignment.last_name%22:%22term%22%7D,'\
+          '%7B%22requestor.reference_no%22:%7B%22' \
+          '$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D%5D,'\
+          '%22status%22:%7B%22$in%22:%5B1,7%5D%7D,' \
+          '%22assignment.operator_id%22:%22valid_operator%22,'\
+          '%22consumer_id%22:%22valid_consumer_id%22%7D' \
+          '&page=2&requested=25&sort=status'
         expect(WebMock).to have_requested(:get, url)
       end
+
       it 'builds query and sends proper request with searchTerm/relation exclusivity' do
         params[:searchTerm] = nil
         subject
-        url =
-          "#{versioned_api_path}/orders?filter=%7B%22status%22:%7B%22$in%22:%5B1,7%5D%7D," \
-          '%22assignment.operator_id%22:%22valid_operator%22,%22consumer_id%22:%22valid_consumer_id%22,' \
-          '%22$or%22:%5B%7B%22public_id%22:%7B%22$in%22:%5B%22valid_order_id%22%5D%7D%7D,%7B%22original_order_id%22:' \
-          '%7B%22$in%22:%5B%22valid_order_id%22%5D%7D%7D%5D%7D&page=2&requested=25&sort=status'
+        url = "#{versioned_api_path}/orders?"\
+          'filter=%7B%22status%22:%7B%22$in%22:%5B1,7%5D%7D,' \
+          '%22assignment.operator_id%22:%22valid_operator%22,'\
+          '%22consumer_id%22:%22valid_consumer_id%22,' \
+          '%22$or%22:%5B%7B%22public_id%22:%7B%22$in%22:%5B%22valid_order_id%22%5D%7D%7D,'\
+          '%7B%22original_order_id%22:%7B%22$in%22:%5B%22valid_order_id%22%5D%7D%7D%5D%7D&'\
+          'page=2&requested=25&sort=status'
         expect(WebMock).to have_requested(:get, url)
       end
+
       it 'builds null assignment query properly when supplied w/ empty string' do
-        FinApps::REST::Orders.new(client).list(assignment: '')
+        described_class.new(client).list(assignment: '')
 
-        url =
-          "#{versioned_api_path}/orders?filter=%7B%22assignment.operator_id%22:null%7D"
+        url = "#{versioned_api_path}/orders?"\
+          'filter=%7B%22assignment.operator_id%22:null%7D'
         expect(WebMock).to have_requested(:get, url)
       end
     end
   end
 
   describe '#update' do
-    subject(:orders) { FinApps::REST::Orders.new(client) }
+    subject(:orders) { described_class.new(client) }
 
     context 'with nil params' do
       context 'when missing id' do
         let(:update) { subject.update(nil) }
+
         it('returns missing argument error') do
           expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
         end
@@ -177,6 +204,7 @@ RSpec.describe FinApps::REST::Orders do
 
         it { expect { update }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
+
         it('error messages array is populated') do
           expect(error_messages.first.downcase).to eq('resource not found')
         end
@@ -186,6 +214,7 @@ RSpec.describe FinApps::REST::Orders do
     context 'with params' do
       context 'when missing id' do
         let(:update) { subject.update(nil, params: 'valid') }
+
         it('does not raise error') do
           expect { update }.not_to raise_error
         end
@@ -208,6 +237,7 @@ RSpec.describe FinApps::REST::Orders do
 
         it { expect { update }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
+
         it('error messages array is populated') do
           expect(error_messages.first.downcase).to eq('invalid request body')
         end
@@ -216,8 +246,10 @@ RSpec.describe FinApps::REST::Orders do
   end
 
   describe '#create_and_submit' do
-    subject(:orders) { FinApps::REST::Orders.new(client) }
-    let(:params) { { params: 'valid' } }
+    subject(:orders) { described_class.new(client) }
+
+    let(:params) { {params: 'valid'} }
+
     it('calls #update') do
       expect(subject).to receive(:update).with(nil, params)
       subject.create_and_submit(params)
@@ -225,10 +257,11 @@ RSpec.describe FinApps::REST::Orders do
   end
 
   describe '#destroy' do
-    subject(:orders) { FinApps::REST::Orders.new(client) }
+    subject(:orders) { described_class.new(client) }
 
     context 'when missing id' do
       let(:destroy) { subject.destroy(nil) }
+
       it('returns missing argument error') do
         expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
@@ -241,6 +274,7 @@ RSpec.describe FinApps::REST::Orders do
 
       it { expect { destroy }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(error_messages.first.downcase).to eq('resource not found')
       end