finapps 5.0.32 → 5.0.33

data/spec/rest/portfolios_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::Portfolios do
   include SpecHelpers::Client
-  subject { FinApps::REST::Portfolios.new(client) }
+  subject { described_class.new(client) }
 
   describe '#list' do
     let(:list) { subject.list(params) }
@@ -16,9 +16,11 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -29,14 +31,17 @@ RSpec.describe FinApps::REST::Portfolios do
     end
 
     context 'when including valid params' do
-      let(:params) { { page: 2, sort: '-created_date', requested: 25 } }
+      let(:params) { {page: 2, sort: '-created_date', requested: 25} }
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
+
       it 'builds query and sends proper request' do
         list
         url =
@@ -62,10 +67,12 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { show }.not_to raise_error }
       it('returns an array') { expect(show).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:_id)
         expect(results).to have_key(:product)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -74,6 +81,7 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { show }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end
@@ -104,10 +112,12 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { create }.not_to raise_error }
       it('returns an array') { expect(create).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:_id)
         expect(results).to have_key(:product)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -122,6 +132,7 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('invalid request body')
       end
@@ -135,7 +146,7 @@ RSpec.describe FinApps::REST::Portfolios do
 
     context 'when missing id' do
       let(:id) { nil }
-      let(:params) { { fake: 'data' } }
+      let(:params) { {fake: 'data'} }
 
       it do
         expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
@@ -153,10 +164,11 @@ RSpec.describe FinApps::REST::Portfolios do
 
     context 'when invalid id or params are provided' do
       let(:id) { 'invalid_id' }
-      let(:params) { { fake: 'data' } }
+      let(:params) { {fake: 'data'} }
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end
@@ -164,14 +176,16 @@ RSpec.describe FinApps::REST::Portfolios do
 
     context 'when valid id and params are provided' do
       let(:id) { 'valid_id' }
-      let(:params) { { fake: 'data' } }
+      let(:params) { {fake: 'data'} }
 
       it { expect { update }.not_to raise_error }
       it('returns an array') { expect(update).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:_id)
         expect(results).to have_key(:product)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
   end
@@ -194,6 +208,7 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { destroy }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end

data/spec/rest/products_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helpers/client'
 RSpec.describe FinApps::REST::Products,
                'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
-  subject(:products) { FinApps::REST::Products.new(client) }
+  subject(:products) { described_class.new(client) }
 
   describe '#list' do
     context 'when called' do
@@ -15,9 +15,11 @@ RSpec.describe FinApps::REST::Products,
 
       it { expect { list }.not_to raise_error }
       it('returns an array of records') { expect(results).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results[0]).to have_key(:code)
       end
+
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
   end

data/spec/rest/sessions_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helpers/client'
 RSpec.describe FinApps::REST::Sessions,
                'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
-  subject { FinApps::REST::Sessions.new(client) }
+  subject { described_class.new(client) }
 
   describe '#create' do
     let(:create) { subject.create(credentials) }
@@ -19,6 +19,7 @@ RSpec.describe FinApps::REST::Sessions,
           subject.create(email: nil, password: 'password')
         end.to raise_error(FinAppsCore::InvalidArgumentsError, message)
       end
+
       it do
         expect { subject.create(email: 'email', password: nil) }.to raise_error(
           FinAppsCore::InvalidArgumentsError,
@@ -29,11 +30,12 @@ RSpec.describe FinApps::REST::Sessions,
 
     context 'for invalid credentials' do
       let(:credentials) do
-        { email: 'email@domain.com', password: 'invalid_password' }
+        {email: 'email@domain.com', password: 'invalid_password'}
       end
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       error_message = 'Invalid Consumer Identifier or Credentials'
       it('error_messages are populated') do
         expect(error_messages.first).to eq(error_message)
@@ -42,7 +44,7 @@ RSpec.describe FinApps::REST::Sessions,
 
     context 'for valid credentials' do
       let(:credentials) do
-        { email: 'email@domain.com', password: 'valid_password' }
+        {email: 'email@domain.com', password: 'valid_password'}
       end
 
       it('results is a Hash') { expect(results).to be_a(Hash) }
@@ -53,14 +55,16 @@ RSpec.describe FinApps::REST::Sessions,
     context 'for valid credentials & path argument' do
       let(:create) { subject.create(credentials, 'operators/login') }
       let(:credentials) do
-        { email: 'email@domain.com', password: 'valid_password' }
+        {email: 'email@domain.com', password: 'valid_password'}
       end
 
       it('results is a Hash') { expect(results).to be_a(Hash) }
       it('token value is in the result') { expect(results).to have_key(:token) }
+
       it('returns operator for operator path') do
         expect(results).to have_key(:role)
       end
+
       it('error_messages is empty') { expect(error_messages).to be_empty }
     end
   end

data/spec/rest/signed_documents_downloads_spec.rb

@@ -7,16 +7,16 @@ RSpec.describe FinApps::REST::SignedDocumentsDownloads do
   include SpecHelpers::Client
 
   let(:api_client) { client }
-  let(:document) { FinApps::REST::SignedDocumentsDownloads.new(api_client) }
+  let(:document) { described_class.new(api_client) }
 
   describe '#show' do
     context 'when missing parameters' do
-      subject { document.show(nil, :signature_request_id) }
+      subject { document.show(:consumer_id, nil) }
+
       it 'raises an error when missing consumer id' do
         expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
 
-      subject { document.show(:consumer_id, nil) }
       it 'raises an error when missing signature request id' do
         expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
       end

data/spec/rest/tenant_app_settings_spec.rb

@@ -4,15 +4,17 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::TenantAppSettings do
   include SpecHelpers::Client
-  subject { FinApps::REST::TenantAppSettings.new(client) }
+  subject { described_class.new(client) }
 
   describe '#show' do
     let(:show) { subject.show }
 
     it { expect { show }.not_to raise_error }
+
     it('performs a get and returns the response') do
       expect(show[RESULTS]).to have_key(:pdf_statement_months)
     end
+
     it('returns no error messages') { expect(show[ERROR_MESSAGES]).to be_empty }
   end
 
@@ -21,28 +23,32 @@ RSpec.describe FinApps::REST::TenantAppSettings do
 
     context 'when missing params' do
       let(:params) { nil }
+
       it do
         expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
     context 'when valid params are provided' do
-      let(:params) { { pdf_statement_months: 2 } }
+      let(:params) { {pdf_statement_months: 2} }
 
       it { expect { update }.not_to raise_error }
+
       it('performs put and returns no content') do
         expect(update[RESULTS]).to be_nil
       end
+
       it('error_messages array is empty') do
         expect(update[ERROR_MESSAGES]).to be_empty
       end
     end
 
     context 'when invalid params are provided' do
-      let(:params) { { pdf_statement_months: nil } }
+      let(:params) { {pdf_statement_months: nil} }
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(update[RESULTS]).to be_nil }
+
       it('error_messages array is populated') do
         expect(update[ERROR_MESSAGES]).not_to be_empty
       end

data/spec/rest/tenant_settings_spec.rb

@@ -4,15 +4,17 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::TenantSettings do
   include SpecHelpers::Client
-  subject { FinApps::REST::TenantSettings.new(client) }
+  subject { described_class.new(client) }
 
   describe '#show' do
     let(:show) { subject.show }
 
     it { expect { show }.not_to raise_error }
+
     it('performs a get and returns the response') do
       expect(show[RESULTS]).to have_key(:iav_default_product)
     end
+
     it('returns no error messages') { expect(show[ERROR_MESSAGES]).to be_empty }
   end
 
@@ -21,28 +23,32 @@ RSpec.describe FinApps::REST::TenantSettings do
 
     context 'when missing params' do
       let(:params) { nil }
+
       it do
         expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
     context 'when valid params are provided' do
-      let(:params) { { iav_default_product: 'valid' } }
+      let(:params) { {iav_default_product: 'valid'} }
 
       it { expect { update }.not_to raise_error }
+
       it('performs put and returns no content') do
         expect(update[RESULTS]).to be_nil
       end
+
       it('error_messages array is empty') do
         expect(update[ERROR_MESSAGES]).to be_empty
       end
     end
 
     context 'when invalid params are provided' do
-      let(:params) { { bad_params: true } }
+      let(:params) { {bad_params: true} }
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(update[RESULTS]).to be_nil }
+
       it('error_messages array is populated') do
         expect(update[ERROR_MESSAGES]).not_to be_empty
       end

data/spec/rest/verix/verix_documents_spec.rb

@@ -7,45 +7,38 @@ RSpec.describe FinApps::REST::VerixDocuments do
   include SpecHelpers::Client
 
   let(:api_client) { client }
-  let(:document) { FinApps::REST::VerixDocuments.new(api_client) }
+  let(:document) { described_class.new(api_client) }
 
   describe '#list' do
     context 'when missing parameters' do
       subject { document.list(nil) }
+
       it 'raises an error when missing record id' do
         expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
-    subject(:list) do
-      document.list(
-        :record_id
-      )
-    end
+    subject { document.list(:record_id) }
+
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
   end
 
   describe '#show' do
-    context 'when missing parameters' do
-      subject { document.show(nil, :document_id) }
-      it 'raises an error when missing record id' do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
-      end
+    context 'when missing record_id' do
+      subject(:show) { document.show(nil, :document_id) }
 
-      subject { document.show(:record_id, nil) }
-      it 'raises an error when missing document id' do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
-      end
+      it { expect { show }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
-    subject(:show) do
-      document.show(
-        :record_id,
-        :document_id
-      )
+    context 'when missing document_id' do
+      subject(:show) { document.show(:record_id, nil) }
+
+      it { expect { show }.to raise_error(FinAppsCore::MissingArgumentsError) }
     end
 
+    subject { document.show(:record_id, :document_id) }
+
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
   end

data/spec/rest/verix/verix_metadata_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe FinApps::REST::VerixMetadata do
   let(:api_client) { client }
 
   describe '#show' do
-    subject(:show) { FinApps::REST::VerixMetadata.new(api_client).show }
+    subject(:show) { described_class.new(api_client).show }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'

data/spec/rest/verix/verix_pdf_documents_spec.rb

@@ -7,29 +7,24 @@ RSpec.describe FinApps::REST::VerixPdfDocuments do
   include SpecHelpers::Client
 
   let(:api_client) { client }
-  let(:document) { FinApps::REST::VerixPdfDocuments.new(api_client) }
+  let(:document) { described_class.new(api_client) }
 
   describe '#show' do
-    context 'when missing parameters' do
-      subject { document.show(nil, :provider_id) }
-      it 'raises an error when missing record id' do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
-      end
-
-      subject { document.show(:record_id, nil) }
-      it 'raises an error when missing provider id' do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
-      end
-    end
-
-    subject(:show) do
-      document.show(
-        :record_id,
-        :provider_id
-      )
-    end
+    subject { document.show(:record_id, :provider_id) }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
+
+    context 'when missing record_id' do
+      subject(:show) { document.show(nil, :provider_id) }
+
+      it { expect { show }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    end
+
+    context 'when missing provider_id' do
+      subject(:show) { document.show(:record_id, nil) }
+
+      it { expect { show }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    end
   end
 end

data/spec/rest/verix/verix_records_spec.rb

@@ -6,12 +6,11 @@ require 'rest/api_request'
 RSpec.describe FinApps::REST::VerixRecords do
   include SpecHelpers::Client
 
-  # noinspection RubyBlockToMethodReference
   let(:api_client) { client }
 
   describe '#create' do
     subject(:create) do
-      FinApps::REST::VerixRecords.new(api_client).create(
+      described_class.new(api_client).create(
         code: 'authcode'
       )
     end
@@ -19,24 +18,46 @@ RSpec.describe FinApps::REST::VerixRecords do
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
     it('returns an id') { expect(create[RESULTS]).to have_key(:_id) }
-    it('returns a consumer id') { expect(create[RESULTS]).to have_key(:consumer_id) }
+
+    it('returns a consumer id') {
+      expect(create[RESULTS]).to have_key(:consumer_id)
+    }
+
     it('returns a status') { expect(create[RESULTS]).to have_key(:status) }
     it('returns an error node') { expect(create[RESULTS]).to have_key(:error) }
-    it('returns a list of documents') { expect(create[RESULTS]).to have_key(:documents) }
-    it('returns a list of downloaded documents') { expect(create[RESULTS]).to have_key(:downloaded_documents) }
+
+    it('returns a list of documents') {
+      expect(create[RESULTS]).to have_key(:documents)
+    }
+
+    it('returns a list of downloaded documents') {
+      expect(create[RESULTS]).to have_key(:downloaded_documents)
+    }
   end
 
   describe '#list' do
-    subject(:list) { FinApps::REST::VerixRecords.new(api_client).list }
+    subject(:list) { described_class.new(api_client).list }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
     it('returns an array') { expect(list[RESULTS]).to be_an_instance_of(Array) }
     it('returns an id') { expect(list[RESULTS].first).to have_key(:_id) }
     it('returns a status') { expect(list[RESULTS].first).to have_key(:status) }
-    it('returns a consumer id') { expect(list[RESULTS].first).to have_key(:consumer_id) }
-    it('returns an error node') { expect(list[RESULTS].first).to have_key(:error) }
-    it('returns a list of documents') { expect(list[RESULTS].first).to have_key(:documents) }
-    it('returns a list of downloaded documents') { expect(list[RESULTS].first).to have_key(:downloaded_documents) }
+
+    it('returns a consumer id') {
+      expect(list[RESULTS].first).to have_key(:consumer_id)
+    }
+
+    it('returns an error node') {
+      expect(list[RESULTS].first).to have_key(:error)
+    }
+
+    it('returns a list of documents') {
+      expect(list[RESULTS].first).to have_key(:documents)
+    }
+
+    it('returns a list of downloaded documents') {
+      expect(list[RESULTS].first).to have_key(:downloaded_documents)
+    }
   end
 end