finapps 5.0.30 → 5.0.35

data/spec/rest/verix/verix_metadata_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe FinApps::REST::VerixMetadata do
   let(:api_client) { client }
 
   describe '#show' do
-    subject(:show) { FinApps::REST::VerixMetadata.new(api_client).show }
+    subject(:show) { described_class.new(api_client).show }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'

data/spec/rest/verix/verix_pdf_documents_spec.rb

@@ -7,29 +7,24 @@ RSpec.describe FinApps::REST::VerixPdfDocuments do
   include SpecHelpers::Client
 
   let(:api_client) { client }
-  let(:document) { FinApps::REST::VerixPdfDocuments.new(api_client) }
+  let(:document) { described_class.new(api_client) }
 
   describe '#show' do
-    context 'when missing parameters' do
-      subject { document.show(nil, :provider_id) }
-      it 'raises an error when missing record id' do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
-      end
-
-      subject { document.show(:record_id, nil) }
-      it 'raises an error when missing provider id' do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
-      end
-    end
-
-    subject(:show) do
-      document.show(
-        :record_id,
-        :provider_id
-      )
-    end
+    subject { document.show(:record_id, :provider_id) }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
+
+    context 'when missing record_id' do
+      subject(:show) { document.show(nil, :provider_id) }
+
+      it { expect { show }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    end
+
+    context 'when missing provider_id' do
+      subject(:show) { document.show(:record_id, nil) }
+
+      it { expect { show }.to raise_error(FinAppsCore::MissingArgumentsError) }
+    end
   end
 end

data/spec/rest/verix/verix_records_spec.rb

@@ -6,12 +6,11 @@ require 'rest/api_request'
 RSpec.describe FinApps::REST::VerixRecords do
   include SpecHelpers::Client
 
-  # noinspection RubyBlockToMethodReference
   let(:api_client) { client }
 
   describe '#create' do
     subject(:create) do
-      FinApps::REST::VerixRecords.new(api_client).create(
+      described_class.new(api_client).create(
         code: 'authcode'
       )
     end
@@ -19,24 +18,46 @@ RSpec.describe FinApps::REST::VerixRecords do
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
     it('returns an id') { expect(create[RESULTS]).to have_key(:_id) }
-    it('returns a consumer id') { expect(create[RESULTS]).to have_key(:consumer_id) }
+
+    it('returns a consumer id') {
+      expect(create[RESULTS]).to have_key(:consumer_id)
+    }
+
     it('returns a status') { expect(create[RESULTS]).to have_key(:status) }
     it('returns an error node') { expect(create[RESULTS]).to have_key(:error) }
-    it('returns a list of documents') { expect(create[RESULTS]).to have_key(:documents) }
-    it('returns a list of downloaded documents') { expect(create[RESULTS]).to have_key(:downloaded_documents) }
+
+    it('returns a list of documents') {
+      expect(create[RESULTS]).to have_key(:documents)
+    }
+
+    it('returns a list of downloaded documents') {
+      expect(create[RESULTS]).to have_key(:downloaded_documents)
+    }
   end
 
   describe '#list' do
-    subject(:list) { FinApps::REST::VerixRecords.new(api_client).list }
+    subject(:list) { described_class.new(api_client).list }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
     it('returns an array') { expect(list[RESULTS]).to be_an_instance_of(Array) }
     it('returns an id') { expect(list[RESULTS].first).to have_key(:_id) }
     it('returns a status') { expect(list[RESULTS].first).to have_key(:status) }
-    it('returns a consumer id') { expect(list[RESULTS].first).to have_key(:consumer_id) }
-    it('returns an error node') { expect(list[RESULTS].first).to have_key(:error) }
-    it('returns a list of documents') { expect(list[RESULTS].first).to have_key(:documents) }
-    it('returns a list of downloaded documents') { expect(list[RESULTS].first).to have_key(:downloaded_documents) }
+
+    it('returns a consumer id') {
+      expect(list[RESULTS].first).to have_key(:consumer_id)
+    }
+
+    it('returns an error node') {
+      expect(list[RESULTS].first).to have_key(:error)
+    }
+
+    it('returns a list of documents') {
+      expect(list[RESULTS].first).to have_key(:documents)
+    }
+
+    it('returns a list of downloaded documents') {
+      expect(list[RESULTS].first).to have_key(:downloaded_documents)
+    }
   end
 end

data/spec/rest/version_spec.rb

@@ -3,12 +3,14 @@
 RSpec.describe FinApps::REST::Version do
   include SpecHelpers::Client
 
-  subject { FinApps::REST::Version.new(client) }
+  subject(:version) { described_class.new(client) }
+
   describe '#show' do
-    it { expect { subject.show }.not_to raise_error }
-    it('returns a string') { expect(subject.show[0]).to be_a(String) }
+    it { expect { version.show }.not_to raise_error }
+    it('returns a string') { expect(version.show[0]).to be_a(String) }
+
     it('starts with the words "Version =>"') do
-      expect(subject.show[0]).to start_with('Version =>')
+      expect(version.show[0]).to start_with('Version =>')
     end
   end
 end

data/spec/spec_helper.rb

@@ -21,7 +21,7 @@ RSpec.configure do |config|
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
     expectations.syntax = :expect
   end
-  config.mock_with(:rspec) { |mocks| mocks.verify_partial_doubles = true }
+  config.mock_with(:rspec) {|mocks| mocks.verify_partial_doubles = true }
   # config.filter_run_including :focus => true
   config.default_formatter = 'doc' if config.files_to_run.one?
   config.order = :random
@@ -29,7 +29,7 @@ RSpec.configure do |config|
   config.warnings = true
   Kernel.srand config.seed
 
-  config.before(:each) do
+  config.before do
     base_url =
       "#{FinAppsCore::REST::Defaults::DEFAULTS[:host]}/v#{FinAppsCore::REST::Defaults::API_VERSION}/"
     stub_request(:any, /#{base_url}/).to_rack(::FakeApi)

data/spec/support/fake_api.rb

@@ -195,7 +195,7 @@ class FakeApi < Sinatra::Base
   post("/#{version}/orders") do
     request.body.rewind
     request_payload = JSON.parse request.body.read
-    if %w[applicant institutions product].all? { |s| request_payload.key? s }
+    if %w[applicant institutions product].all? {|s| request_payload.key? s }
       json_response 200, 'order_token.json'
     else
       json_response 400, 'invalid_request_body.json'
@@ -203,7 +203,13 @@ class FakeApi < Sinatra::Base
   end
 
   # documents_orders
-  get("/#{version}/documents/orders") { json_response 200, 'documents_orders.json' }
+  get("/#{version}/documents/orders") do
+    if params[:filter]&.include?('"status":2')
+      json_response 200, 'documents_orders_none.json'
+    else
+      json_response 200, 'documents_orders.json'
+    end
+  end
   get("/#{version}/documents/orders/valid_order_id") do
     json_response 200, 'documents_order.json'
   end
@@ -213,7 +219,7 @@ class FakeApi < Sinatra::Base
   post("/#{version}/documents/orders") do
     request.body.rewind
     request_payload = JSON.parse request.body.read
-    if %w[applicant esign_documents tag].all? { |s| request_payload.key? s }
+    if %w[applicant esign_documents tag].all? {|s| request_payload.key? s }
       json_response 200, 'documents_order.json'
     else
       json_response 400, 'invalid_request_body.json'

data/spec/support/fixtures/documents_orders_none.json

@@ -0,0 +1,6 @@
+{
+  "total_records": 0,
+  "page": 0,
+  "total_pages": 0,
+  "records": []
+}

data/spec/utils/query_builder_spec.rb

@@ -1,38 +1,64 @@
 # frozen_string_literal: true
 
+require 'cgi'
+
 class FakeClass
   include FinApps::Utils::QueryBuilder
 
-  def build_filter(param); end
+  def build_filter(params)
+    params&.key?(:role) ? {role: params[:role]} : {}
+  end
 end
 
 RSpec.describe FinApps::Utils::QueryBuilder do
-  subject { FakeClass.new }
+  subject(:fake_class) { FakeClass.new }
 
   describe '#build_query_path' do
     let(:end_point) { 'orders' }
 
     context 'with full params' do
       let(:params) do
-        { page: '1', requested: '20', sort: '-date', random: 'random' }
+        {
+          page: '1',
+          requested: '20',
+          sort: '-date',
+          random: 'random',
+          role: 2
+        }
+      end
+      let(:escaped_filter) { "filter=#{CGI.escape({role: 2}.to_json)}" }
+
+      it 'includes a page value in the query string' do
+        value = 'page=1'
+        expect(fake_class.build_query_path(end_point, params)).to include(value)
+      end
+
+      it 'includes a requested value in the query string' do
+        value = 'requested=20'
+        expect(fake_class.build_query_path(end_point, params)).to include(value)
       end
-      it 'calls #build_filter and returns correct string' do
-        allow(subject).to receive(:build_filter) { { role: 2 } }
-        expect(subject).to receive(:build_filter).with(params)
-        correct_string =
-          'orders?page=1&requested=20&sort=-date&filter=%7B%22role%22%3A2%7D'
-        expect(subject.build_query_path(end_point, params)).to eq(
-          correct_string
-        )
+
+      it 'includes a sort value in the query string' do
+        value = 'sort=-date'
+        expect(fake_class.build_query_path(end_point, params)).to include(value)
+      end
+
+      it 'includes a filter value in the query string' do
+        value = escaped_filter
+        expect(fake_class.build_query_path(end_point, params)).to include(value)
+      end
+
+      it 'builds a properly formatted query string' do
+        expected = "orders?page=1&requested=20&sort=-date&#{escaped_filter}"
+        expect(fake_class.build_query_path(end_point, params)).to eq(expected)
       end
     end
 
     context 'with no params' do
       let(:params) { {} }
+
       it 'returns root' do
-        allow(subject).to receive(:build_filter) { {} }
-        expect(subject).to receive(:build_filter).with(params)
-        expect(subject.build_query_path(end_point, params)).to eq(end_point)
+        expect(fake_class.build_query_path(end_point, params)).to eq(end_point)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 5.0.30
+  version: 5.0.35
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-28 00:00:00.000000000 Z
+date: 2020-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -19,7 +19,7 @@ dependencies:
         version: '5.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.7
+        version: 5.0.10
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.7
+        version: 5.0.10
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -176,60 +176,60 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.79'
+        version: '0.86'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: 0.86.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.79'
+        version: '0.86'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: 0.86.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.6.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.6.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.37'
+        version: '1.40'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.37.1
+        version: 1.40.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.37'
+        version: '1.40'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.37.1
+        version: 1.40.0
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -280,11 +280,13 @@ extra_rdoc_files:
 - LICENSE.txt
 files:
 - ".codeclimate.yml"
+- ".github/workflows/main.yaml"
 - ".gitignore"
 - ".gitlab-ci.yml"
 - ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".ruby-gemset"
 - ".ruby-version"
 - ".tmuxinator.yml"
@@ -386,6 +388,7 @@ files:
 - spec/support/fixtures/alert_occurrences.json
 - spec/support/fixtures/documents_order.json
 - spec/support/fixtures/documents_orders.json
+- spec/support/fixtures/documents_orders_none.json
 - spec/support/fixtures/error.json
 - spec/support/fixtures/esign_templates.json
 - spec/support/fixtures/invalid_order_id.json
@@ -468,7 +471,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client.