finapps 5.0.30 → 5.0.35

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c74f2340d52ad3cd13dc2bdf8415e7cf89e48f0993dbb346456546910a69ba9
-  data.tar.gz: 3bdefc2032a2efa241d5cc72ab5d6b74fc44b568599f0054bf5477e473fab81f
+  metadata.gz: 4756aafb56941b9eaf0609a1aa07d9eae9b3485e70a10bf1ab7590cc973654d1
+  data.tar.gz: 0e55b4ed791fc263027a21b6193ca025778e983fb0742006111b9fc1c5d88e4d
 SHA512:
-  metadata.gz: 9cb6732ca1b8ba09cc84920ec7fdd086259cd339f012f72cf19c30387f877f3af1aa495bea47f019ee638e9a32eb3f76bbd0397e89b6e773e108da98e9bc8300
-  data.tar.gz: 5dedcdb78fa82b22011520031aae7aa55b1c6e35a7f5ccd55e16fdaa1c6d3b19bd4d17e300a00849d1768be6528b2396adff43ef96b6c6f060740af4315c857f
+  metadata.gz: 90031e4f43d5a3fda8f4f3f2df53e7ecb8a5e27ab53830f79aaf80ab981b293b8890ad3e2bf8a31ebc210dcaf37f29fbcc1442fb139ee463b465243223381393
+  data.tar.gz: 56d79d89f1a40e4ee1fff5b58ad8e49f762375c7ea6a4911a3e149004272eba89fe3e6348653a49f75a2bf1cd6a1f41ef4e8c20af6857c0e75af76c818b88467

data/.github/workflows/main.yaml

@@ -0,0 +1,37 @@
+name: Main
+
+on: [push, pull_request]
+
+jobs:
+  ci:
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: true
+
+    steps:
+      - uses: actions/checkout@v1
+
+      - name: Use Ruby 2.6
+        uses: actions/setup-ruby@v1
+        with:
+          ruby-version: '2.6'
+
+      - uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os  }}-gems-${{ hashFiles('**/Gemfile.lock')  }}
+          restore-keys: |
+            ${{ runner.os  }}-gems-
+
+      - name: Install gems
+        run: |
+          gem install bundler
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+
+      - name: Run rubocop
+        run: bundle exec rubocop
+
+      - name: Run tests
+        run: bundle exec rspec

data/.rubocop.yml

@@ -1,26 +1,59 @@
+inherit_from: .rubocop_todo.yml
+
+require: 
+  - rubocop-rspec
+  - rubocop-performance
+
 AllCops:
-  DisplayCopNames: true
+  TargetRubyVersion: 2.6
   Exclude:
-  - "finapps.gemspec"
-  UseCache: false
+    - "vendor/**/*"
+    - "bin/**/*"
+  CacheRootDirectory: tmp
 
-# Commonly used screens these days easily fit more than 80 characters.
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceInsideBlockBraces:
+  # The space here provides no real gain in readability while consuming
+  # horizontal space that could be used for a better parameter name.
+  # Also {| differentiates better from a hash than { | does.
+  SpaceBeforeBlockParameters: false
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+Layout/DotPosition:
+  Description: Checks the position of the dot in multi-line method calls.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
+  Enabled: true
+  EnforcedStyle: leading
+  SupportedStyles:
+  - leading
+  - trailing
 Layout/LineLength:
-  Max: 120
+  Max: 110
 
-Style/CollectionMethods:
-  Description: Preferred collection methods.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
+Lint/DeprecatedOpenSSLConstant:
   Enabled: true
-  PreferredMethods:
-    collect: map
-    collect!: map!
-    find: detect
-    find_all: select
-    reduce: inject
-Style/OptionHash:
-  Description: Don't use option hashes when you can use keyword arguments.
-  Enabled: false
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+
+Metrics/ClassLength:
+  Exclude:
+    - app/controllers/orders_controller.rb
+    - app/models/order.rb
+Metrics/BlockLength:
+  ExcludedMethods: ['describe', 'context']
+  Exclude:
+    - config/environments/**/**
+    - Guardfile
+    - config/routes.rb
+    - config/Guardfile
+
 Naming/PredicateName:
   Description: Check the names of predicate methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
@@ -33,54 +66,94 @@ Naming/PredicateName:
   - is_
   Exclude:
   - spec/**/*
-Metrics/AbcSize:
-  Description: A calculated magnitude based on number of assignments, branches, and
-    conditions.
-  Enabled: false
-  Max: 15
-Metrics/BlockLength:
-  ExcludedMethods: ['describe', 'context']
-Metrics/ClassLength:
-  Description: Avoid classes longer than 100 lines of code.
-  Enabled: false
-  CountComments: false
-  Max: 100
-Metrics/ModuleLength:
-  CountComments: false
-  Max: 100
-  Description: Avoid modules longer than 100 lines of code.
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Description: A complexity metric that is strongly correlated to the number of test
-    cases needed to validate a method.
-  Enabled: false
-  Max: 6
-Metrics/MethodLength:
-  Description: Avoid methods longer than 10 lines of code.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#short-methods
+
+RSpec/FilePath:
   Enabled: false
-  CountComments: false
-  Max: 10
-Metrics/ParameterLists:
-  Description: Avoid parameter lists longer than three or four parameters.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#too-many-params
+    
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+Style/CollectionMethods:
+  Description: Preferred collection methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
+  Enabled: true
+  PreferredMethods:
+    collect: map
+    collect!: map!
+    find: detect
+    find_all: select
+    reduce: inject
+Style/GuardClause:
+  Description: Check for conditionals that can be replaced with guard clauses
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals
+  Enabled: true
+  MinBodyLength: 1
+Style/OptionHash:
+  Description: Don't use option hashes when you can use keyword arguments.
   Enabled: false
-  Max: 5
-  CountKeywordArgs: true
-Metrics/PerceivedComplexity:
-  Description: A complexity metric geared towards measuring complexity for a human
-    reader.
+Style/PercentLiteralDelimiters:
+  Description: Use `%`-literal delimiters consistently
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#percent-literal-braces
   Enabled: false
-  Max: 7
+  PreferredDelimiters:
+    "%": "()"
+    "%i": "()"
+    "%q": "()"
+    "%Q": "()"
+    "%r": "{}"
+    "%s": "()"
+    "%w": "()"
+    "%W": "()"
+    "%x": "()"
+Style/SignalException:
+  Description: Checks for proper usage of fail and raise.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#fail-method
+  Enabled: true
+  EnforcedStyle: semantic
+  SupportedStyles:
+  - only_raise
+  - only_fail
+  - semantic
+Style/StringLiterals:
+  Description: Checks if uses of quotes match the configured preference.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/StringLiteralsInInterpolation:
+  Description: Checks if uses of quotes inside expressions in interpolated strings
+    match the configured preference.
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
 Style/Documentation:
   Description: Document classes and non-namespace modules.
   Enabled: false
-Style/EmptyLiteral:
-  Description: Prefer literals to Array.new/Hash.new/String.new.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#literal-array-hash
-  Enabled: false
-Style/VariableInterpolation:
-  Description: Don't interpolate global, instance and class variables directly in
-    strings.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
+Style/OneLineConditional:
+  Description: Favor the ternary operator(?:) over if/then/else/end constructs.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#ternary-operator
   Enabled: false
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
+RSpec/NestedGroups:
+  Max: 5
+RSpec/DescribeClass:
+  Exclude:
+    - spec/system/*
+    - spec/factories_spec.rb

data/.rubocop_todo.yml

@@ -0,0 +1,29 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-06-24 14:28:46 UTC using RuboCop version 0.86.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+# finapps.gemspec - leaving as is intentionally
+Metrics/BlockLength:
+  Max: 28
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+# fake_api.rb - leaving as is intentionally
+Metrics/ClassLength:
+  Max: 431
+
+# Offense count: 5
+# Configuration parameters: Max.
+# Leaving as is intentionally - url being tested takes up as many lines
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/rest/consumers_spec.rb'
+    - 'spec/rest/documents_orders_spec.rb'
+    - 'spec/rest/orders_spec.rb'

data/.tmuxinator.yml

@@ -11,6 +11,7 @@ windows:
           - git pull
           - git status
           - bundle
+          - bundle outdated
   - 
     guard: 
       layout: even-horizontal

data/.travis.yml

@@ -1,5 +1,7 @@
-sudo: false
 language: ruby
+os: ["linux"]
+dist: "xenial"
+
 cache:
   bundler: true
 

data/README.md

@@ -3,6 +3,7 @@ FinApps Ruby-Client
 ===================
 
 [![Gem Version](https://img.shields.io/gem/v/finapps.svg)](https://rubygems.org/gems/finapps)
+![Main](https://github.com/finapps/ruby-client/workflows/Main/badge.svg)
 [![Build Status](https://travis-ci.org/finapps/ruby-client.svg?branch=master)](https://travis-ci.org/finapps/ruby-client)
 [![Code Climate](https://codeclimate.com/github/finapps/ruby-client/badges/gpa.svg)](https://codeclimate.com/github/finapps/ruby-client)
 [![Test Coverage](https://codeclimate.com/github/finapps/ruby-client/badges/coverage.svg)](https://codeclimate.com/github/finapps/ruby-client/coverage)

data/RELEASES.md

@@ -1,3 +1,32 @@
+## [5.0.35] - 2020-07-09
+
+### Changed
+* Change code to match rubocop suggestions ([#232][i232])
+* Add support for first name order search with space ([#404][i404])
+
+[i232]: https://github.com/finapps/ruby-client/issues/232
+[i404]: https://github.com/finapps/tenant-dashboard-react/issues/404
+
+[5.0.35]: https://github.com/finapps/ruby-client/compare/5.0.34...5.0.35
+
+## [5.0.32] - 2020-06-11
+
+### Fixed
+* Argument error resulting from space search ([#225][i225])
+
+[i225]: https://github.com/finapps/ruby-client/issues/225
+
+[5.0.32]: https://github.com/finapps/ruby-client/compare/5.0.31...5.0.32
+
+## [5.0.31] - 2020-06-11
+
+### Changed
+* Consumer and Doc-order search to query names on spaces ([#224][i224])
+
+[i224]: https://github.com/finapps/ruby-client/issues/224
+
+[5.0.31]: https://github.com/finapps/ruby-client/compare/5.0.30...5.0.31
+
 ## [5.0.30] - 2020-05-28
 
 ### Added

data/finapps.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.7'
+  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.10'
 
   spec.add_development_dependency 'bundler',                    '~> 2.0',   '>= 2.0.2'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'
@@ -29,9 +29,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'guard-rspec',                '~> 4.7',   '>= 4.7.3'
   spec.add_development_dependency 'rake',                       '~> 13.0',  '>= 13.0.1'
   spec.add_development_dependency 'rspec',                      '~> 3.9',   '>= 3.9.0'
-  spec.add_development_dependency 'rubocop',                    '~> 0.79',  '>= 0.79.0'
-  spec.add_development_dependency 'rubocop-performance',        '~> 1.5',   '>= 1.5.2'
-  spec.add_development_dependency 'rubocop-rspec',              '~> 1.37',  '>= 1.37.1'
+  spec.add_development_dependency 'rubocop',                    '~> 0.86',  '>= 0.86.0'
+  spec.add_development_dependency 'rubocop-performance',        '~> 1.6',   '>= 1.6.1'
+  spec.add_development_dependency 'rubocop-rspec',              '~> 1.40',  '>= 1.40.0'
   spec.add_development_dependency 'sinatra',                    '~> 2.0',   '>= 2.0.8'
   spec.add_development_dependency 'webmock',                    '~> 3.8',   '>= 3.8.0'
 

data/lib/finapps/rest/alert_definitions.rb

@@ -8,7 +8,7 @@ module FinApps
 
       def list(params = nil)
         return super END_POINT if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(END_POINT, params)
       end

data/lib/finapps/rest/alert_occurrences.rb

@@ -8,7 +8,7 @@ module FinApps
 
       def list(params = nil)
         return super END_POINT if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(END_POINT, params)
       end

data/lib/finapps/rest/client.rb

@@ -60,17 +60,18 @@ module FinApps
         if RESOURCES.include? symbol
           class_name = camelize(symbol.to_s)
           variable = "@#{class_name.downcase}"
-          unless instance_variable_defined? variable
-            klass =
-              Object.const_get('FinApps').const_get('REST').const_get class_name
-            instance_variable_set(variable, klass.new(self))
-          end
+          set_variable(class_name, variable) unless instance_variable_defined? variable
           instance_variable_get(variable)
         else
           super
         end
       end
 
+      def set_variable(class_name, variable)
+        klass = Object.const_get('FinApps').const_get('REST').const_get class_name
+        instance_variable_set(variable, klass.new(self))
+      end
+
       def respond_to_missing?(method_sym, include_private = false)
         RESOURCES.include?(method_sym) ? true : super
       end

data/lib/finapps/rest/consumers.rb

@@ -15,7 +15,7 @@ module FinApps
 
       def list(params = nil)
         return super if params.nil?
-        raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
+        fail FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash
 
         super build_query_path(end_point, params)
       end
@@ -54,14 +54,30 @@ module FinApps
       end
 
       def search_query(term)
+        query = with_space_search(term).concat(name_search(term))
         {
-          "$or": [
-            { "email": term },
-            { "first_name": term },
-            { "last_name": term }
-          ]
+          "$or": query
         }
       end
+
+      def with_space_search(term)
+        [
+          {"email": term},
+          {"first_name": term},
+          {"last_name": term}
+        ]
+      end
+
+      def name_search(term)
+        search_arr = []
+        if /\s/.match?(term)
+          term.split.each do |t|
+            search_arr.append("first_name": t)
+            search_arr.append("last_name": t)
+          end
+        end
+        search_arr
+      end
     end
   end
 end