finapps 5.0.30 → 5.0.35

data/spec/rest/password_resets_spec.rb

@@ -5,102 +5,112 @@ RSpec.describe FinApps::REST::PasswordResets do
 
   describe '#create' do
     context 'when missing id' do
-      subject { FinApps::REST::PasswordResets.new(client).create(nil) }
+      subject(:create) { described_class.new(client).create(nil) }
+
       it do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
     context 'when invalid id is provided' do
-      subject do
-        FinApps::REST::PasswordResets.new(client).create(:invalid_user_id)
+      subject(:create) do
+        described_class.new(client).create(:invalid_user_id)
       end
 
-      it { expect { subject }.not_to raise_error }
-      it('results is nil') { expect(subject[0]).to be_nil }
+      it { expect { create }.not_to raise_error }
+      it('results is nil') { expect(create[0]).to be_nil }
+
       it('error messages array is populated') do
-        expect(subject[1]).not_to be_nil
+        expect(create[1]).not_to be_nil
       end
     end
 
     context 'when valid id is provided' do
-      subject do
-        FinApps::REST::PasswordResets.new(client).create(:valid_user_id)
+      subject(:create) do
+        described_class.new(client).create(:valid_user_id)
       end
 
-      it { expect { subject }.not_to raise_error }
-      it('returns an array') { expect(subject).to be_a(Array) }
+      it { expect { create }.not_to raise_error }
+      it('returns an array') { expect(create).to be_a(Array) }
+
       it('performs a post and returns the response') do
-        expect(subject[0]).to have_key(:token)
+        expect(create[0]).to have_key(:token)
       end
-      it('returns no error messages') { expect(subject[1]).to be_empty }
+
+      it('returns no error messages') { expect(create[1]).to be_empty }
     end
   end
 
   describe '#update' do
-    let(:valid_params) { { token: 'valid_token' } }
-    let(:invalid_params) { { token: 'invalid_token' } }
+    let(:valid_params) { {token: 'valid_token'} }
+    let(:invalid_params) { {token: 'invalid_token'} }
 
     context 'when missing id' do
-      subject { FinApps::REST::PasswordResets.new(client).update(nil, :params) }
+      subject(:update) { described_class.new(client).update(nil, :params) }
+
       it do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
     context 'when missing params' do
-      subject do
-        FinApps::REST::PasswordResets.new(client).update(:valid_user_id, nil)
+      subject(:update) do
+        described_class.new(client).update(:valid_user_id, nil)
       end
+
       it do
-        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
     context 'when invalid id is provided' do
-      subject do
-        FinApps::REST::PasswordResets.new(client).update(
+      subject(:update) do
+        described_class.new(client).update(
           :invalid_user_id,
           valid_params
         )
       end
 
-      it { expect { subject }.not_to raise_error }
-      it('results is nil') { expect(subject[0]).to be_nil }
+      it { expect { update }.not_to raise_error }
+      it('results is nil') { expect(update[0]).to be_nil }
+
       it('error messages array is populated') do
-        expect(subject[1]).not_to be_nil
+        expect(update[1]).not_to be_nil
       end
     end
 
     context 'when invalid params are provided' do
-      subject do
-        FinApps::REST::PasswordResets.new(client).update(
+      subject(:update) do
+        described_class.new(client).update(
           :valid_user_id,
           invalid_params
         )
       end
 
-      it { expect { subject }.not_to raise_error }
-      it('results is nil') { expect(subject[0]).to be_nil }
+      it { expect { update }.not_to raise_error }
+      it('results is nil') { expect(update[0]).to be_nil }
+
       it('error messages array is populated') do
-        expect(subject[1]).not_to be_nil
+        expect(update[1]).not_to be_nil
       end
     end
 
     context 'when valid params are provided' do
-      subject do
-        FinApps::REST::PasswordResets.new(client).update(
+      subject(:update) do
+        described_class.new(client).update(
           :valid_user_id,
           valid_params
         )
       end
 
-      it { expect { subject }.not_to raise_error }
-      it('returns an array') { expect(subject).to be_a(Array) }
+      it { expect { update }.not_to raise_error }
+      it('returns an array') { expect(update).to be_a(Array) }
+
       it('performs a post and returns the response') do
-        expect(subject[0]).to have_key(:token)
+        expect(update[0]).to have_key(:token)
       end
-      it('returns no error messages') { expect(subject[1]).to be_empty }
+
+      it('returns no error messages') { expect(update[1]).to be_empty }
     end
   end
 end

data/spec/rest/plaid/plaid_account_permissions_spec.rb

@@ -13,6 +13,7 @@ RSpec.describe FinApps::REST::PlaidAccountPermissions do
     it('returns no content') do
       expect(subject[RESULTS]).to be_nil
     end
+
     it('returns no error messages') do
       expect(subject[ERROR_MESSAGES]).to be_empty
     end
@@ -20,8 +21,8 @@ RSpec.describe FinApps::REST::PlaidAccountPermissions do
 
   describe '#create' do
     subject(:show) do
-      FinApps::REST::PlaidAccountPermissions.new(api_client)
-                                            .create(:account_id)
+      described_class.new(api_client)
+                     .create(:account_id)
     end
 
     it_behaves_like 'an API request'
@@ -31,8 +32,8 @@ RSpec.describe FinApps::REST::PlaidAccountPermissions do
 
   describe '#destroy' do
     subject(:destroy) do
-      FinApps::REST::PlaidAccountPermissions.new(api_client)
-                                            .destroy(:account_id)
+      described_class.new(api_client)
+                     .destroy(:account_id)
     end
 
     it_behaves_like 'an API request'

data/spec/rest/plaid/plaid_accounts_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe FinApps::REST::PlaidAccounts do
 
   describe '#show' do
     subject(:show) do
-      FinApps::REST::PlaidAccounts.new(api_client).show(
+      described_class.new(api_client).show(
         :account_id
       )
     end
@@ -28,11 +28,16 @@ RSpec.describe FinApps::REST::PlaidAccounts do
   end
 
   describe '#list' do
-    subject(:list) { FinApps::REST::PlaidAccounts.new(api_client).list }
+    subject(:list) { described_class.new(api_client).list }
 
     it_behaves_like 'an API request'
     it_behaves_like 'a successful request'
-    it('returns an Array of institution data') { expect(list[RESULTS].first).to have_key(:plaid_institution_id) }
-    it('returns institution account data') { expect(list[RESULTS].first).to have_key(:accounts) }
+    it('returns an Array of institution data') {
+      expect(list[RESULTS].first).to have_key(:plaid_institution_id)
+    }
+
+    it('returns institution account data') {
+      expect(list[RESULTS].first).to have_key(:accounts)
+    }
   end
 end

data/spec/rest/plaid/plaid_consumer_institutions_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
 
   describe '#create' do
     subject(:create) do
-      FinApps::REST::PlaidConsumerInstitutions.new(api_client).create(
+      described_class.new(api_client).create(
         public_token: 'le-token'
       )
     end
@@ -29,7 +29,7 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
 
   describe '#show' do
     subject(:show) do
-      FinApps::REST::PlaidConsumerInstitutions.new(api_client).show(
+      described_class.new(api_client).show(
         :consumer_institution_id
       )
     end
@@ -39,7 +39,7 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
     it_behaves_like 'a request that returns institution data'
     context 'when requesting accounts information' do
       subject(:show) do
-        FinApps::REST::PlaidConsumerInstitutions.new(api_client).show(
+        described_class.new(api_client).show(
           :consumer_institution_id, show_accounts: true
         )
       end
@@ -48,14 +48,14 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
       it_behaves_like 'a successful request'
       it_behaves_like 'a request that returns institution data'
       it('returns institution account data') do
-        expect(subject[RESULTS]).to have_key(:accounts)
+        expect(show[RESULTS]).to have_key(:accounts)
       end
     end
   end
 
   describe '#list' do
     subject(:list) do
-      FinApps::REST::PlaidConsumerInstitutions.new(api_client).list
+      described_class.new(api_client).list
     end
 
     it_behaves_like 'an API request'
@@ -67,8 +67,8 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
 
   describe '#destroy' do
     subject(:destroy) do
-      FinApps::REST::PlaidConsumerInstitutions.new(api_client)
-                                              .destroy(:consumer_institution_id)
+      described_class.new(api_client)
+                     .destroy(:consumer_institution_id)
     end
 
     it_behaves_like 'an API request'
@@ -80,8 +80,8 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
 
   describe '#update_status' do
     subject(:update_status) do
-      FinApps::REST::PlaidConsumerInstitutions.new(api_client)
-                                              .update_status(:consumer_institution_id)
+      described_class.new(api_client)
+                     .update_status(:consumer_institution_id)
     end
 
     it_behaves_like 'an API request'
@@ -91,8 +91,8 @@ RSpec.describe FinApps::REST::PlaidConsumerInstitutions do
 
   describe '#public_token' do
     subject(:public_token) do
-      FinApps::REST::PlaidConsumerInstitutions.new(api_client)
-                                              .public_token(:consumer_institution_id)
+      described_class.new(api_client)
+                     .public_token(:consumer_institution_id)
     end
 
     it_behaves_like 'an API request'

data/spec/rest/plaid/plaid_institution_logos_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe FinApps::REST::PlaidInstitutionLogos do
 
   describe '#show' do
     subject(:show) do
-      FinApps::REST::PlaidInstitutionLogos.new(api_client).show(
+      described_class.new(api_client).show(
         :inst_id
       )
     end

data/spec/rest/plaid/plaid_webhooks_spec.rb

@@ -6,8 +6,9 @@ require 'rest/api_request'
 RSpec.describe FinApps::REST::PlaidWebhooks do
   include SpecHelpers::Client
 
+  subject(:show) { described_class.new(api_client).show }
+
   let(:api_client) { client }
-  subject(:show) { FinApps::REST::PlaidWebhooks.new(api_client).show }
 
   describe '#show' do
     context 'when valid tenant token is provided' do
@@ -25,6 +26,7 @@ RSpec.describe FinApps::REST::PlaidWebhooks do
       it_behaves_like 'an API request'
 
       it('results is nil') { expect(show[RESULTS]).to be_nil }
+
       it('error messages array is populated') do
         expect(show[ERROR_MESSAGES].first.downcase).to eq(
           'invalid tenant api key or secret'

data/spec/rest/portfolio_reports_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::PortfolioReports do
   include SpecHelpers::Client
-  subject { FinApps::REST::PortfolioReports.new(client) }
+  subject { described_class.new(client) }
 
   describe '#list' do
     let(:list) { subject.list(params) }
@@ -16,9 +16,11 @@ RSpec.describe FinApps::REST::PortfolioReports do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -29,14 +31,17 @@ RSpec.describe FinApps::REST::PortfolioReports do
     end
 
     context 'when including valid params' do
-      let(:params) { { page: 2, sort: '-created_date', requested: 25 } }
+      let(:params) { {page: 2, sort: '-created_date', requested: 25} }
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
+
       it 'builds query and sends proper request' do
         list
         url =

data/spec/rest/portfolios_alerts_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::PortfoliosAlerts do
   include SpecHelpers::Client
-  subject { FinApps::REST::PortfoliosAlerts.new(client) }
+  subject { described_class.new(client) }
 
   describe '#list' do
     let(:list) { subject.list(id) }
@@ -22,11 +22,13 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns array of alert definitions') do
+
+      it('performs a get and returns a results array') do
         expect(results).to be_a(Array)
-        expect(results.first).to have_key(:_id)
-        expect(results.first).to have_key(:rule_name)
       end
+
+      it { expect(results.first).to have_key(:_id) }
+      it { expect(results.first).to have_key(:rule_name) }
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -35,6 +37,7 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
 
       it { expect { list }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end
@@ -80,6 +83,7 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end
@@ -125,6 +129,7 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
 
       it { expect { destroy }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end

data/spec/rest/portfolios_available_consumers_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::PortfoliosAvailableConsumers do
   include SpecHelpers::Client
-  subject { FinApps::REST::PortfoliosAvailableConsumers.new(client) }
+  subject { described_class.new(client) }
 
   describe '#list' do
     let(:list) { subject.list(id, params) }
@@ -24,9 +24,11 @@ RSpec.describe FinApps::REST::PortfoliosAvailableConsumers do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -39,14 +41,17 @@ RSpec.describe FinApps::REST::PortfoliosAvailableConsumers do
 
     context 'when including valid params' do
       let(:id) { 'valid_id' }
-      let(:params) { { page: 2, sort: '-created_date', requested: 25 } }
+      let(:params) { {page: 2, sort: '-created_date', requested: 25} }
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
+
       it 'builds query and sends proper request' do
         list
         url =

data/spec/rest/portfolios_consumers_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helpers/client'
 
 RSpec.describe FinApps::REST::PortfoliosConsumers do
   include SpecHelpers::Client
-  subject { FinApps::REST::PortfoliosConsumers.new(client) }
+  subject { described_class.new(client) }
 
   describe '#list' do
     let(:list) { subject.list(portfolio_id, params) }
@@ -31,22 +31,27 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
     context 'when valid id is provided w/ valid params' do
       let(:portfolio_id) { 'valid_id' }
-      let(:params) { { page: 2, sort: '-created_date', requested: 25 } }
+      let(:params) { {page: 2, sort: '-created_date', requested: 25} }
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
+
       it('performs a get and returns the response') do
         expect(results).to have_key(:records)
       end
+
       it('returns no error messages') { expect(errors).to be_empty }
+
       it 'builds query and sends proper request' do
         list
         url =
@@ -62,6 +67,7 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
 
       it { expect { list }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end
@@ -91,7 +97,7 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
       end
     end
 
-    context 'for bulk subscribe' do
+    context 'with bulk subscribe' do
       context 'when valid id and params are provided' do
         let(:portfolio_id) { 'valid_id' }
         let(:params) { %w[id1 id2 id3] }
@@ -100,6 +106,7 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
         it('returns an array') { expect(create).to be_a(Array) }
         it('results is nil') { expect(results).to be_nil }
         it('returns no error messages') { expect(errors).to be_empty }
+
         it('builds correct url') do
           create
           url = "#{versioned_api_path}/portfolios/#{portfolio_id}/consumers"
@@ -113,6 +120,7 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
 
         it { expect { create }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
+
         it('error messages array is populated') do
           # this will break when client is fixed to expect new array error response
           expect(errors.first.downcase).to eq(
@@ -122,7 +130,7 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
       end
     end
 
-    context 'for single subscribe' do
+    context 'with single subscribe' do
       context 'when valid ids are provided' do
         let(:portfolio_id) { 'valid_id' }
         let(:params) { portfolio_id }
@@ -131,6 +139,7 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
         it('returns an array') { expect(create).to be_a(Array) }
         it('results is nil') { expect(results).to be_nil }
         it('returns no error messages') { expect(errors).to be_empty }
+
         it('builds correct url') do
           create
           url =
@@ -145,6 +154,7 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
 
         it { expect { create }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
+
         it('error messages array is populated') do
           expect(errors.first.downcase).to eq(
             'consumer not eligible, no completed orders.'
@@ -193,6 +203,7 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
 
       it { expect { destroy }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
+
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
       end