fedora-migrate 0.3.0 → 0.4.0

data/spec/integration/custom_target_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe FedoraMigrate::ObjectMover do
+  let(:source) { FedoraMigrate.source.connection.find("sufia:rb68xc089") }
+  let(:original_pid) { FedoraMigrate::Mover.id_component(source) }
+
+  context "when we use our own target constructor" do
+    let(:mover) { described_class.new source }
+
+    before do
+      # Override .build to use Fedora's default id minter
+      class FedoraMigrate::TargetConstructor
+        def build
+          target.new
+        end
+      end
+
+      Object.send(:remove_const, :GenericFile) if defined?(GenericFile)
+      class GenericFile < ActiveFedora::Base
+        contains "content", class_name: "ExampleModel::VersionedDatastream"
+        contains "thumbnail", class_name: "ActiveFedora::Datastream"
+        contains "characterization", class_name: "ActiveFedora::Datastream"
+      end
+    end
+
+    after do
+      load './lib/fedora_migrate/target_constructor.rb'
+    end
+
+    subject do
+      mover.migrate
+      mover.target
+    end
+
+    it "migrates the entire object using a different id" do
+      expect(subject.content.versions.all.count).to eql 3
+      expect(subject.thumbnail.mime_type).to eql "image/jpeg"
+      expect(subject.thumbnail.versions.all.count).to eql 0
+      expect(subject.characterization.versions.all.count).to eql 0
+      expect(subject).to be_kind_of GenericFile
+      expect(subject.id).not_to eq(original_pid)
+    end
+  end
+end

data/spec/integration/fedora3_interface_spec.rb

@@ -1,23 +1,19 @@
 require 'spec_helper'
 
-describe "The interface to Fedora3" do
-
+describe FedoraMigrate do
   context "with an object's datastreams" do
+    subject { described_class.source.connection.find("sufia:rb68xc089") }
 
-    subject { FedoraMigrate.source.connection.find("sufia:rb68xc089") }
-
-    it "should load them" do
-      expect(subject.datastreams.count).to eql 8 
+    it "loads them" do
+      expect(subject.datastreams.count).to eql 8
     end
 
-    it "should see thier names" do
+    it "sees thier names" do
       expect(subject.datastreams.keys).to include("content")
     end
 
-    it "should return their content" do
-      expect(subject.datastreams["content"].content).to_not be_nil
+    it "returns their content" do
+      expect(subject.datastreams["content"].content).not_to be_nil
     end
-
   end
-
 end

data/spec/integration/missing_relationships_spec.rb

@@ -1,39 +1,37 @@
 require 'spec_helper'
 
-describe "Collections with missing files" do
-
+describe ExampleModel::Collection do
   let(:collection)    { "x346dj04v" }
   let(:files)         { ["x346dj06d", "x346dj08z"] }
   let(:missing_file)  { "x346dj07p" }
 
   before do
-    FedoraMigrate::ObjectMover.new(FedoraMigrate.find("scholarsphere:#{collection}"), ExampleModel::Collection.new(collection)).migrate
+    FedoraMigrate::ObjectMover.new(FedoraMigrate.find("scholarsphere:#{collection}"), described_class.new(collection)).migrate
     files.each { |f| FedoraMigrate::ObjectMover.new(FedoraMigrate.find("scholarsphere:#{f}"), ExampleModel::MigrationObject.new(f)).migrate }
   end
 
   context "when migrating relationships" do
-    let(:migrated_collection) { ExampleModel::Collection.first }
+    let(:migrated_collection) { described_class.first }
     let(:error_message) do
       "scholarsphere:#{collection} could not migrate relationship info:fedora/fedora-system:def/relations-external#hasCollectionMember because info:fedora/scholarsphere:#{missing_file} doesn't exist in Fedora 4"
     end
     before { FedoraMigrate::RelsExtDatastreamMover.new(FedoraMigrate.find("scholarsphere:#{collection}")).migrate }
-    it "should only migrate existing relationships" do
+    it "only migrates existing relationships" do
       expect(migrated_collection.members.count).to eql 2
-      expect(migrated_collection.member_ids).to_not include(missing_file)
+      expect(migrated_collection.member_ids).not_to include(missing_file)
     end
   end
 
   context "when reporting" do
     subject { FedoraMigrate::RelsExtDatastreamMover.new(FedoraMigrate.find("scholarsphere:#{collection}")).migrate }
-    it "should include failed relationships" do
+    it "includes failed relationships" do
       expect(subject.sort.first).to match(/^could not migrate relationship/)
     end
-    it "should include all the possible relationships" do
+    it "includes all the possible relationships" do
       expect(subject.count).to eql 3
     end
-    it "should include the successful relationships" do
+    it "includes the successful relationships" do
       expect(subject.sort.last).to match(/^http/)
     end
   end
-
 end

data/spec/integration/object_migration_spec.rb

@@ -1,20 +1,18 @@
 require 'spec_helper'
 
-describe "Migrating an object" do
-
+describe FedoraMigrate::ObjectMover do
   let(:source)    { FedoraMigrate.source.connection.find("sufia:rb68xc089") }
   let(:fits_xml)  { load_fixture("sufia-rb68xc089-characterization.xml").read }
 
   context "when the target model is provided" do
-
-    let(:mover) { FedoraMigrate::ObjectMover.new source, ExampleModel::MigrationObject.new }
+    let(:mover) { described_class.new source, ExampleModel::MigrationObject.new }
 
     subject do
       mover.migrate
       mover.target
     end
 
-    it "should migrate the entire object" do
+    it "migrates the entire object" do
       expect(subject.content.versions.all.count).to eql 3
       expect(subject.thumbnail.mime_type).to eql "image/jpeg"
       expect(subject.thumbnail.versions.all.count).to eql 0
@@ -23,30 +21,27 @@ describe "Migrating an object" do
       expect(subject).to be_kind_of ExampleModel::MigrationObject
     end
 
-    it "should migrate the object's permissions" do
+    it "migrates the object's permissions" do
       expect(subject.edit_users).to include("jilluser@example.com")
     end
 
     describe "objects with Om datastreams" do
-      let(:mover) { FedoraMigrate::ObjectMover.new(source, ExampleModel::OmDatastreamExample.new) }
+      let(:mover) { described_class.new(source, ExampleModel::OmDatastreamExample.new) }
       subject do
         mover.migrate
         mover.target
       end
-      it "should migrate the object without warnings" do
-        expect(FedoraMigrate::Logger).to_not receive(:warn)
+      it "migrates the object without warnings" do
+        expect(FedoraMigrate::Logger).not_to receive(:warn)
         expect(subject.characterization.ng_xml).to be_equivalent_to(fits_xml)
       end
     end
-
   end
 
   context "when we have to determine the model" do
-
-    let(:mover) { FedoraMigrate::ObjectMover.new source }
+    let(:mover) { described_class.new source }
 
     context "and it is defined" do
-
       before do
         Object.send(:remove_const, :GenericFile) if defined?(GenericFile)
         class GenericFile < ActiveFedora::Base
@@ -61,7 +56,7 @@ describe "Migrating an object" do
         mover.target
       end
 
-      it "should migrate the entire object" do
+      it "migrates the entire object" do
         expect(subject.content.versions.all.count).to eql 3
         expect(subject.thumbnail.mime_type).to eql "image/jpeg"
         expect(subject.thumbnail.versions.all.count).to eql 0
@@ -75,24 +70,22 @@ describe "Migrating an object" do
       before do
         Object.send(:remove_const, :GenericFile) if defined?(GenericFile)
       end
-      it "should fail" do
-        expect{mover.migrate}.to raise_error(FedoraMigrate::Errors::MigrationError)
+      it "fails" do
+        expect { mover.migrate }.to raise_error(FedoraMigrate::Errors::MigrationError)
       end
     end
-
   end
 
   context "when the object has an ntriples datastream" do
-
     context "and we want to convert it to a provided model" do
-      let(:mover) { FedoraMigrate::ObjectMover.new(source, ExampleModel::RDFObject.new, {convert: "descMetadata"}) }
+      let(:mover) { described_class.new(source, ExampleModel::RDFObject.new, convert: "descMetadata") }
 
       subject do
         mover.migrate
         mover.target
       end
 
-      it "should migrate the entire object" do
+      it "migrates the entire object" do
         expect(subject.content.versions.all.count).to eql 3
         expect(subject.thumbnail.mime_type).to eql "image/jpeg"
         expect(subject.thumbnail.versions.all.count).to eql 0
@@ -102,7 +95,7 @@ describe "Migrating an object" do
         expect(subject.title).to eql(["world.png"])
       end
 
-      it "should migrate the createdDate and lastModifiedDate" do
+      it "migrates the createdDate and lastModifiedDate" do
         # The value of lastModifiedDate will depend on when you loaded your test fixtures
         expect(subject.date_modified).to eq source.lastModifiedDate
         expect(subject.date_uploaded).to eq '2014-10-15T03:50:37.063Z'
@@ -111,46 +104,42 @@ describe "Migrating an object" do
 
     context "with ISO-8859-1 characters" do
       let(:problem_source) { FedoraMigrate.source.connection.find("scholarsphere:5712mc568") }
-      let(:mover) { FedoraMigrate::ObjectMover.new(problem_source, ExampleModel::RDFObject.new, {convert: "descMetadata"}) }
+      let(:mover) { described_class.new(problem_source, ExampleModel::RDFObject.new, convert: "descMetadata") }
       subject do
         mover.migrate
         mover.target
       end
 
-      it "should migrate the content" do
+      it "migrates the content" do
         expect(subject.description.first).to match(/^The relationship between school administrators and music teachers/)
       end
-
     end
 
     context "and we want to convert multiple datastreas" do
-
       # Need a fixture with two different datastreams for this test to be more effective
-      let(:mover) { FedoraMigrate::ObjectMover.new(source, ExampleModel::RDFObject.new, {convert: ["descMetadata", "descMetadata"]}) }
+      let(:mover) { described_class.new(source, ExampleModel::RDFObject.new, convert: ["descMetadata", "descMetadata"]) }
 
       subject do
         mover.migrate
         mover.target
       end
 
-      it "should migrate all the datastreams" do
+      it "migrates all the datastreams" do
         expect(subject.title).to eql(["world.png"])
       end
     end
 
     context "with RDF errors" do
       let(:problem_source) { FedoraMigrate.source.connection.find("scholarsphere:sf2686078") }
-      let(:mover) { FedoraMigrate::ObjectMover.new(problem_source, ExampleModel::RDFObject.new, {convert: "descMetadata"}) }
+      let(:mover) { described_class.new(problem_source, ExampleModel::RDFObject.new, convert: "descMetadata") }
       subject do
         mover.migrate
         mover.target
       end
 
-      it "should migrate the content" do
+      it "migrates the content" do
         expect(subject.title).to eql([" The \"Value Added\" in Editorial Acquisitions.pdf"])
       end
     end
-
   end
-
 end

data/spec/integration/permission_migration_spec.rb

@@ -1,13 +1,11 @@
 require 'spec_helper'
 
-describe "Migrating permisisons" do
-
+describe FedoraMigrate::PermissionsMover do
   let(:source) { FedoraMigrate.source.connection.find("sufia:rb68xc089") }
- 
-  subject { FedoraMigrate::PermissionsMover.new(source.datastreams["rightsMetadata"], ExampleModel::MigrationObject.new)}
 
-  it "should display the permissions from the source datastream" do
+  subject { described_class.new(source.datastreams["rightsMetadata"], ExampleModel::MigrationObject.new) }
+
+  it "displays the permissions from the source datastream" do
     expect(subject.edit_users).to include("jilluser@example.com")
   end
-
 end

data/spec/integration/rdf_migration_spec.rb

@@ -1,13 +1,12 @@
 require 'spec_helper'
 
-describe "Mirating RDF terms" do
-  let(:mover) { FedoraMigrate::RDFDatastreamMover.new(file, ExampleModel::RDFProperties.new) }
+describe FedoraMigrate::RDFDatastreamMover do
+  let(:mover) { described_class.new(file, ExampleModel::RDFProperties.new) }
 
   context "normal record" do
-
     let(:file) { FedoraMigrate.source.connection.find("sufia:xp68km39w").datastreams["descMetadata"] }
 
-    it "should call the before and after hooks when migrating" do
+    it "calls the before and after hooks when migrating" do
       expect(mover).to receive(:before_rdf_datastream_migration)
       expect(mover).to receive(:after_rdf_datastream_migration)
       mover.migrate
@@ -27,7 +26,6 @@ describe "Mirating RDF terms" do
   end
 
   context "record with UTF8 chracters" do
-
     let(:file) { FedoraMigrate.source.connection.find("scholarsphere:7d279232g").datastreams["descMetadata"] }
 
     describe "using triples" do
@@ -42,6 +40,5 @@ describe "Mirating RDF terms" do
         expect(subject.description.first). to eql "Objectives:\r\n•  Explain the role of a new genomic assay (Target Now™) in guiding oncology treatment plans.\r\n•  Describe the Target Now™ assay.\r\n•  Present a case study where Target Now™ was instrumental in the patient’s treatment plan."
       end
     end
-
   end
 end

data/spec/integration/relationship_migration_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
-describe "Migrating objects with relationships" do
-
+describe FedoraMigrate::ObjectMover do
   before :all do
+    Object.send(:remove_const, :GenericFile) if defined?(GenericFile)
     class GenericFile < ActiveFedora::Base
       belongs_to :batch, predicate: ActiveFedora::RDF::Fcrepo::RelsExt.isPartOf
       property :title, predicate: ::RDF::DC.title do |index|
@@ -13,6 +13,7 @@ describe "Migrating objects with relationships" do
       end
     end
 
+    Object.send(:remove_const, :Batch) if defined?(Batch)
     class Batch < ActiveFedora::Base
       has_many :generic_files, predicate: ActiveFedora::RDF::Fcrepo::RelsExt.isPartOf
     end
@@ -20,16 +21,16 @@ describe "Migrating objects with relationships" do
 
   after :all do
     Object.send(:remove_const, :GenericFile) if defined?(GenericFile)
+    Object.send(:remove_const, :Batch) if defined?(Batch)
   end
 
   let(:parent_source) { FedoraMigrate.source.connection.find("sufia:rb68xc09k") }
   let(:child_source)  { FedoraMigrate.source.connection.find("sufia:rb68xc11m") }
 
   context "when all objects exist in Fedora4" do
-
     before do
-      FedoraMigrate::ObjectMover.new(parent_source).migrate
-      FedoraMigrate::ObjectMover.new(child_source).migrate
+      described_class.new(parent_source).migrate
+      described_class.new(child_source).migrate
     end
 
     subject { Batch.find("rb68xc09k") }
@@ -46,7 +47,5 @@ describe "Migrating objects with relationships" do
         expect(subject.generic_files.count).to eql 1
       end
     end
-
   end
-
 end

data/spec/integration/repository_migration_spec.rb

@@ -1,24 +1,21 @@
 require 'spec_helper'
 
-describe "Migrating the repository" do
-
+describe FedoraMigrate do
   context "when no target objects are defined" do
-
     before do
       Object.send(:remove_const, :GenericFile) if defined?(GenericFile)
       Object.send(:remove_const, :Batch) if defined?(Batch)
       Object.send(:remove_const, :Collection) if defined?(Collection)
     end
 
-    subject { FedoraMigrate.migrate_repository(namespace: "sufia", options: {convert: "descMetadata"}).report }
+    subject { described_class.migrate_repository(namespace: "sufia", options: { convert: "descMetadata" }).report }
 
-    it "should report warnings" do
+    it "reports warnings" do
       expect(subject.failed_objects.count).to eql 9
     end
   end
 
   context "when all target objects are defined" do
-
     before do
       Object.send(:remove_const, :GenericFile) if defined?(GenericFile)
       class GenericFile < ExampleModel::MigrationObject
@@ -52,8 +49,8 @@ describe "Migrating the repository" do
     let(:versions_report) { GenericFile.all.map { |f| f.content.versions.count }.uniq }
 
     context "by default" do
-      before { FedoraMigrate.migrate_repository(namespace: "sufia", options: {convert: "descMetadata"}) }
-      it "should move every object and its versions" do
+      before { described_class.migrate_repository(namespace: "sufia", options: { convert: "descMetadata" }) }
+      it "moves every object and its versions" do
         expect(file1.title).to eql ["world.png"]
         expect(file2.title).to eql ["Sample Migration Object A"]
         expect(file2.creator).to eql ["Adam Wead"]
@@ -63,17 +60,17 @@ describe "Migrating the repository" do
         expect(Batch.all.last.generic_files.count).to eql 2
         expect(Collection.all.count).to eql 1
         expect(Collection.first.members.count).to eql 2
-        expect(versions_report).to match_array [0,3,9]
+        expect(versions_report).to match_array [0, 3, 9]
       end
     end
 
     context "and the application will create versions" do
       before do
-        FedoraMigrate.migrate_repository(namespace: "sufia", 
-          options: {convert: "descMetadata", application_creates_versions: true}
-        )
+        described_class.migrate_repository(namespace: "sufia",
+                                           options: { convert: "descMetadata", application_creates_versions: true }
+                                          )
       end
-      it "should move every object but not its versions" do
+      it "moves every object but not its versions" do
         expect(file1.title).to eql ["world.png"]
         expect(versions_report).to eql [0]
       end
@@ -88,7 +85,7 @@ describe "Migrating the repository" do
       before do
         FileUtils.rm_rf(failed_report)
         FileUtils.cp_r(sample_report, failed_report)
-        migrator = FedoraMigrate.migrate_repository(namespace: "sufia", options: {convert: "descMetadata", report: failed_report})
+        described_class.migrate_repository(namespace: "sufia", options: { convert: "descMetadata", report: failed_report })
       end
       after { FileUtils.rm_rf(failed_report) }
       it "only migrates the objects that have failed" do
@@ -98,7 +95,7 @@ describe "Migrating the repository" do
         expect(new_report.total_objects).to eql 9
         expect(original_report.results[sample_pid]["status"]).to be false
         expect(new_report.results[sample_pid]["status"]).to be true
-        expect(new_report.results[sample_pid]["object"]).to_not be_nil
+        expect(new_report.results[sample_pid]["object"]).not_to be_nil
       end
     end
 
@@ -106,11 +103,9 @@ describe "Migrating the repository" do
       let(:pid1) { "sufia:rb68xc089" }
       let(:pid2) { "sufia:xp68km39w" }
       let(:report) { FedoraMigrate::MigrationReport.new }
-      before { FedoraMigrate.migrate_repository(namespace: "sufia", options: {convert: "descMetadata", blacklist: [pid1, pid2]}) }
+      before { described_class.migrate_repository(namespace: "sufia", options: { convert: "descMetadata", blacklist: [pid1, pid2] }) }
       subject { report.results.keys }
-      it { is_expected.to_not include(pid1)}
+      it { is_expected.not_to include(pid1) }
     end
-
   end
-
 end