fedora-migrate 0.3.0 → 0.4.0

data/lib/fedora_migrate/migration_options.rb

@@ -1,10 +1,9 @@
 module FedoraMigrate
   module MigrationOptions
-
     attr_accessor :options, :conversions
 
     def conversion_options
-      self.conversions = options.nil? ? [] : [options[:convert]].flatten      
+      self.conversions = options.nil? ? [] : [options[:convert]].flatten
     end
 
     def forced?
@@ -23,12 +22,12 @@ module FedoraMigrate
       return [] if options.nil?
       options.fetch(:blacklist, [])
     end
-    
+
     private
-    
-    def option_true?(name)
-      !!(options && options[name])
-    end
 
+      def option_true?(name)
+        return false unless options
+        options.fetch(name, false)
+      end
   end
 end

data/lib/fedora_migrate/migration_report.rb

@@ -1,13 +1,12 @@
 module FedoraMigrate
   class MigrationReport
-
     attr_accessor :path, :results
 
     DEFAULT_PATH = "migration_report".freeze
 
-    def initialize path=nil
+    def initialize(path = nil)
       @path = path.nil? ? DEFAULT_PATH : path
-      FileUtils::mkdir_p(@path)
+      FileUtils.mkdir_p(@path)
       reload
     end
 
@@ -15,9 +14,7 @@ module FedoraMigrate
       @results = load_results_from_directory
     end
 
-    def empty?
-      results.empty?
-    end
+    delegate :empty?, to: :results
 
     def failed_objects
       results.keys.map { |k| k unless results[k]["status"] }.compact
@@ -31,36 +28,35 @@ module FedoraMigrate
       results.keys.count
     end
 
-    def report_failures output = String.new
+    def report_failures(output = '')
       failed_objects.each do |k|
-        output << "#{k}:\n\tobject: #{results[k]["object"]}\n\trelationships: #{results[k]["relationships"]}\n\n"
+        output << "#{k}:\n\tobject: #{results[k]['object']}\n\trelationships: #{results[k]['relationships']}\n\n"
       end
       output
     end
 
     # Receives and individual report and writes it to the MigrationReport directory
-    def save pid, report
-      file = File.join(path,file_from_pid(pid))
+    def save(pid, report)
+      file = File.join(path, file_from_pid(pid))
       json = JSON.load(report.to_json)
       File.write(file, JSON.pretty_generate(json))
     end
 
     private
 
-    def load_results_from_directory assembled = Hash.new
-      Dir.glob(File.join(path,"*.json")).each do |file|
-        assembled[pid_from_file(file)] = JSON.parse(File.read(file))
+      def load_results_from_directory(assembled = {})
+        Dir.glob(File.join(path, "*.json")).each do |file|
+          assembled[pid_from_file(file)] = JSON.parse(File.read(file))
+        end
+        assembled
       end
-      assembled
-    end
-
-    def pid_from_file file
-      File.basename(file, ".*").gsub(/_/,":")
-    end
 
-    def file_from_pid pid
-      pid.gsub(/:/,"_")+".json"
-    end
+      def pid_from_file(file)
+        File.basename(file, ".*").tr('_', ":")
+      end
 
+      def file_from_pid(pid)
+        pid.tr(':', "_") + ".json"
+      end
   end
 end

data/lib/fedora_migrate/mover.rb

@@ -1,12 +1,11 @@
 module FedoraMigrate
   class Mover
-
     include MigrationOptions
     include Hooks
 
     attr_accessor :target, :source, :report
 
-    def initialize *args
+    def initialize(*args)
       @source = args[0]
       @target = args[1]
       @options = args[2]
@@ -37,17 +36,16 @@ module FedoraMigrate
       end
     end
 
-    def id_component object=nil
+    def id_component(object = nil)
       object ||= source
       raise FedoraMigrate::Errors::MigrationError, "can't get the id component without an object" if object.nil?
       self.class.id_component(object)
     end
 
-    def self.id_component object
-      return object.pid.split(/:/).last if object.kind_of?(Rubydora::DigitalObject)
+    def self.id_component(object)
+      return object.pid.split(/:/).last if object.is_a?(Rubydora::DigitalObject)
       return object.to_s.split(/:/).last if object.respond_to?(:to_s)
       nil
     end
-    
   end
 end

data/lib/fedora_migrate/object_mover.rb

@@ -1,6 +1,5 @@
 module FedoraMigrate
   class ObjectMover < Mover
-
     RIGHTS_DATASTREAM = "rightsMetadata".freeze
 
     ContentDatastreamReport = Struct.new(:ds, :versions)
@@ -38,52 +37,47 @@ module FedoraMigrate
       save
     end
 
+    def target
+      @target ||= FedoraMigrate::TargetConstructor.new(source).build
+    end
+
     private
 
-    def migrate_datastreams
-      migrate_content_datastreams
-      migrate_permissions
-      migrate_dates
-    end
+      def migrate_datastreams
+        migrate_content_datastreams
+        migrate_permissions
+        migrate_dates
+      end
 
-    # We have to call save before migrating content datastreams, otherwise versions aren't recorded
-    # TODO: this will fail if required fields are defined in a descMetadata datastream that is not
-    # converted to RDF (issue #8)
-    def migrate_content_datastreams
-      save
-      target.attached_files.keys.each do |ds|
-        mover = FedoraMigrate::DatastreamMover.new(source.datastreams[ds.to_s], target.attached_files[ds.to_s], options)
-        report.content_datastreams << ContentDatastreamReport.new(ds, mover.migrate)
+      # We have to call save before migrating content datastreams, otherwise versions aren't recorded
+      # TODO: this will fail if required fields are defined in a descMetadata datastream that is not
+      # converted to RDF (issue #8)
+      def migrate_content_datastreams
+        save
+        target.attached_files.keys.each do |ds|
+          mover = FedoraMigrate::DatastreamMover.new(source.datastreams[ds.to_s], target.attached_files[ds.to_s], options)
+          report.content_datastreams << ContentDatastreamReport.new(ds, mover.migrate)
+        end
       end
-    end
 
-    def convert_rdf_datastream ds
-      if source.datastreams.key?(ds)
+      def convert_rdf_datastream(ds)
+        return unless source.datastreams.key?(ds)
         mover = FedoraMigrate::RDFDatastreamMover.new(datastream_content(ds), target)
         report.rdf_datastreams << RDFDatastreamReport.new(ds, mover.migrate)
       end
-    end
 
-    def datastream_content(dsid)
-      source.datastreams[dsid.to_s]
-    end
+      def datastream_content(dsid)
+        source.datastreams[dsid.to_s]
+      end
 
-    def migrate_permissions
-      if source.datastreams.keys.include?(RIGHTS_DATASTREAM) && target.respond_to?(:permissions)
+      def migrate_permissions
+        return unless source.datastreams.keys.include?(RIGHTS_DATASTREAM) && target.respond_to?(:permissions)
         mover = FedoraMigrate::PermissionsMover.new(source.datastreams[RIGHTS_DATASTREAM], target)
         report.permissions = mover.migrate
       end
-    end
-
-    def migrate_dates
-      report.dates = FedoraMigrate::DatesMover.new(source, target).migrate
-    end
-
-    def create_target_model
-      builder = FedoraMigrate::TargetConstructor.new(source.models).build
-      raise FedoraMigrate::Errors::MigrationError, "No qualified targets found in #{source.pid}" if builder.target.nil?
-      @target = builder.target.new(id: id_component)
-    end
 
+      def migrate_dates
+        report.dates = FedoraMigrate::DatesMover.new(source, target).migrate
+      end
   end
 end

data/lib/fedora_migrate/permissions.rb

@@ -1,32 +1,30 @@
 module FedoraMigrate::Permissions
-
   # Taken from Hydra::AccessControls::Permissions under version 7.2.2
   #
   # We need the reader methods to get permissions from the Fedora3
   # rightsMetadata datastreams
 
   def read_groups
-    rightsMetadata.groups.map {|k, v| k if v == 'read'}.compact
+    rightsMetadata.groups.map { |k, v| k if v == 'read' }.compact
   end
-  
+
   def edit_groups
-    rightsMetadata.groups.map {|k, v| k if v == 'edit'}.compact
+    rightsMetadata.groups.map { |k, v| k if v == 'edit' }.compact
   end
-        
+
   def discover_groups
-    rightsMetadata.groups.map {|k, v| k if v == 'discover'}.compact
+    rightsMetadata.groups.map { |k, v| k if v == 'discover' }.compact
   end
 
   def read_users
-    rightsMetadata.users.map {|k, v| k if v == 'read'}.compact
+    rightsMetadata.users.map { |k, v| k if v == 'read' }.compact
   end
 
   def edit_users
-    rightsMetadata.users.map {|k, v| k if v == 'edit'}.compact
+    rightsMetadata.users.map { |k, v| k if v == 'edit' }.compact
   end
 
   def discover_users
-    rightsMetadata.users.map {|k, v| k if v == 'discover'}.compact
+    rightsMetadata.users.map { |k, v| k if v == 'discover' }.compact
   end
-
 end

data/lib/fedora_migrate/permissions_mover.rb

@@ -1,20 +1,17 @@
 module FedoraMigrate
   class PermissionsMover < Mover
-
     include FedoraMigrate::Permissions
 
     attr_accessor :rightsMetadata
 
     def post_initialize
-      if source.respond_to?(:content)
-        @rightsMetadata = datastream_from_content
-      end
+      @rightsMetadata = datastream_from_content if source.respond_to?(:content)
     end
 
     def migrate
       FedoraMigrate::Permissions.instance_methods.each do |permission|
-        report << "#{permission} = #{self.send(permission)}"
-        target.send(permission.to_s+"=", self.send(permission))
+        report << "#{permission} = #{send(permission)}"
+        target.send(permission.to_s + "=", send(permission))
       end
       save
       super
@@ -22,10 +19,9 @@ module FedoraMigrate
 
     private
 
-    def datastream_from_content ds = FedoraMigrate::RightsMetadata.new
-      ds.ng_xml = source.content
-      ds
-    end
-
+      def datastream_from_content(ds = FedoraMigrate::RightsMetadata.new)
+        ds.ng_xml = source.content
+        ds
+      end
   end
 end

data/lib/fedora_migrate/rdf_datastream_mover.rb

@@ -2,7 +2,6 @@ require 'rchardet'
 
 module FedoraMigrate
   class RDFDatastreamMover < Mover
-
     def migrate
       before_rdf_datastream_migration
       migrate_rdf_triples
@@ -22,7 +21,7 @@ module FedoraMigrate
       end
 
       def updated_datastream_content
-        correct_encoding(datastream_content).gsub(/<.+#{source.pid}>/,"<#{target.uri}>")
+        correct_encoding(datastream_content).gsub(/<.+#{source.pid}>/, "<#{target.uri}>")
       end
 
       def datastream_content

data/lib/fedora_migrate/rels_ext_datastream_mover.rb

@@ -1,6 +1,5 @@
 module FedoraMigrate
   class RelsExtDatastreamMover < Mover
-
     RELS_EXT_DATASTREAM = "RELS-EXT".freeze
 
     def migrate
@@ -18,42 +17,41 @@ module FedoraMigrate
 
     private
 
-    def migrate_statements
-      statements.each do |statement|
-        triple = [target.rdf_subject, migrate_predicate(statement.predicate), migrate_object(statement.object)]
-        target.ldp_source.graph << triple
-        report << triple.join("--")
+      def migrate_statements
+        statements.each do |statement|
+          triple = [target.rdf_subject, migrate_predicate(statement.predicate), migrate_object(statement.object)]
+          target.ldp_source.graph << triple
+          report << triple.join("--")
+        end
       end
-    end
-
-    def update_index
-      target.reload
-      target.update_index
-    end
 
-    def graph
-      @graph ||= RDF::Graph.new { |g| g.from_rdfxml(source.datastreams[RELS_EXT_DATASTREAM].content) }
-    end
+      def update_index
+        target.reload
+        target.update_index
+      end
 
-    # Override this if any predicate transformation is needed
-    def migrate_predicate(fc3_uri)
-      fc3_uri
-    end
+      def graph
+        @graph ||= RDF::Graph.new { |g| g.from_rdfxml(source.datastreams[RELS_EXT_DATASTREAM].content) }
+      end
 
-    def migrate_object(fc3_uri)
-      RDF::URI.new(ActiveFedora::Base.id_to_uri(id_component(fc3_uri)))
-    end
+      # Override this if any predicate transformation is needed
+      def migrate_predicate(fc3_uri)
+        fc3_uri
+      end
 
-    def has_missing_object?(statement)
-      return false if ActiveFedora::Base.exists?(id_component(statement.object))
-      report << "could not migrate relationship #{statement.predicate} because #{statement.object} doesn't exist in Fedora 4"
-      true
-    end
+      def migrate_object(fc3_uri)
+        RDF::URI.new(ActiveFedora::Base.id_to_uri(id_component(fc3_uri)))
+      end
 
-    # All the graph statements except hasModel and those with missing objects
-    def statements
-      graph.statements.reject { |stmt| stmt.predicate == ActiveFedora::RDF::Fcrepo::Model.hasModel || has_missing_object?(stmt) }
-    end
+      def missing_object?(statement)
+        return false if ActiveFedora::Base.exists?(id_component(statement.object))
+        report << "could not migrate relationship #{statement.predicate} because #{statement.object} doesn't exist in Fedora 4"
+        true
+      end
 
+      # All the graph statements except hasModel and those with missing objects
+      def statements
+        graph.statements.reject { |stmt| stmt.predicate == ActiveFedora::RDF::Fcrepo::Model.hasModel || missing_object?(stmt) }
+      end
   end
 end

data/lib/fedora_migrate/repository_migrator.rb

@@ -1,17 +1,15 @@
 module FedoraMigrate
   class RepositoryMigrator
-
     include MigrationOptions
 
     attr_accessor :source_objects, :namespace, :report, :source, :result
 
     SingleObjectReport = Struct.new(:status, :object, :relationships)
 
-    def initialize namespace = nil, options = {}
+    def initialize(namespace = nil, options = {})
       @namespace = namespace || repository_namespace
       @options = options
       @report = MigrationReport.new(@options.fetch(:report, nil))
-      @source_objects = get_source_objects
       conversion_options
     end
 
@@ -36,7 +34,7 @@ module FedoraMigrate
     end
 
     def migrate_relationships
-      return "Relationship migration halted because #{failures.to_s} objects didn't migrate successfully." if failures > 0 && not_forced?
+      return "Relationship migration halted because #{failures} objects didn't migrate successfully." if failures > 0 && not_forced?
       source_objects.each do |object|
         @source = object
         @result = find_or_create_single_object_report
@@ -44,8 +42,8 @@ module FedoraMigrate
       end
     end
 
-    def get_source_objects
-      FedoraMigrate.source.connection.search(nil).collect { |o| qualifying_object(o) }.compact
+    def source_objects
+      @source_objects ||= FedoraMigrate.source.connection.search(nil).collect { |o| qualifying_object(o) }.compact
     end
 
     def failures
@@ -54,48 +52,47 @@ module FedoraMigrate
 
     private
 
-    def migrate_object
-      result.object = FedoraMigrate::ObjectMover.new(source, nil, options).migrate
-      result.status = true
-    rescue StandardError => e
-      result.object = e.inspect
-      result.status = false
-    ensure
-      report.save(source.pid, result)
-    end
-
-    def migrate_relationship
-      result.relationships = FedoraMigrate::RelsExtDatastreamMover.new(source).migrate
-      result.status = true
-    rescue StandardError => e
-      result.relationships = e.inspect
-      result.status = false
-    ensure
-      report.save(source.pid, result)
-    end
+      def migrate_object
+        result.object = FedoraMigrate::ObjectMover.new(source, nil, options).migrate
+        result.status = true
+      rescue StandardError => e
+        result.object = e.inspect
+        result.status = false
+      ensure
+        report.save(source.pid, result)
+      end
 
-    def repository_namespace
-      FedoraMigrate.source.connection.repository_profile["repositoryPID"]["repositoryPID"].split(/:/).first.strip
-    end
+      def migrate_relationship
+        result.relationships = FedoraMigrate::RelsExtDatastreamMover.new(source).migrate
+        result.status = true
+      rescue StandardError => e
+        result.relationships = e.inspect
+        result.status = false
+      ensure
+        report.save(source.pid, result)
+      end
 
-    def qualifying_object object
-      name = object.pid.split(/:/).first
-      return object if name.match(namespace)
-    end
+      def repository_namespace
+        FedoraMigrate.source.connection.repository_profile["repositoryPID"]["repositoryPID"].split(/:/).first.strip
+      end
 
-    def migration_required?
-      return false if blacklist.include?(source.pid)
-      return true if report.results[source.pid].nil?
-      !report.results[source.pid]["status"]
-    end
+      def qualifying_object(object)
+        name = object.pid.split(/:/).first
+        return object if name.match(namespace)
+      end
 
-    def find_or_create_single_object_report
-      if report.results[source.pid].nil?
-        SingleObjectReport.new
-      else
-        SingleObjectReport.new(report.results[source.pid]["status"],report.results[source.pid]["object"],report.results[source.pid]["relationships"])
+      def migration_required?
+        return false if blacklist.include?(source.pid)
+        return true if report.results[source.pid].nil?
+        !report.results[source.pid]["status"]
       end
-    end
 
+      def find_or_create_single_object_report
+        if report.results[source.pid].nil?
+          SingleObjectReport.new
+        else
+          SingleObjectReport.new(report.results[source.pid]["status"], report.results[source.pid]["object"], report.results[source.pid]["relationships"])
+        end
+      end
   end
 end