fedora-migrate 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 127fba59aedee21753a2ab76236f32f9fd405dc3
-  data.tar.gz: 18b7cafa6247b840afcf79924565859333d99c2c
+  metadata.gz: 77fed55ecdbf64c57627ad65017d99be9f1424a1
+  data.tar.gz: fb0bfbb69e5d0efd99521bee4c3434218ae8f672
 SHA512:
-  metadata.gz: 468b7a0174d44e48b7c8b4d55c8ed6036e835a73e55cf3076f378806477e940c1cee5ebe96476cb6316a6582746d8dd5ace72f51c03813dcb56ad4cc500e9683
-  data.tar.gz: 0d961a07e3c4dc51691b5caa0c28065d6900b4c8dbe15c8d4e97ca1a8fe6f2a770d366894ec8b6c0b80e4cf225daccd568e94633f13cef6faa1f95d93c76f10d
+  metadata.gz: 4943665d395ae6e0d45f152f00eca3d7a9075c876be7757ec146d63b16b420db67ce3be520546bdbd0ce3cff1e10a6fc3071ff05c656459cc68e1a40cbcf5a34
+  data.tar.gz: 23f37bbb636630151e125384ddc00ef2c198209d0fa1aa2983abeb16dc5b07e34a1470ad26b1451ac4b8326708e2c48fbbcd05ba40baabb120300ce1fb915105

data/.rubocop.yml

@@ -0,0 +1,128 @@
+require: rubocop-rspec
+
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  TargetRubyVersion: 2.2
+  DisplayCopNames: true
+  Include:
+    - '**/Rakefile'
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Exclude:
+    - 'lib/fedora_migrate/rights_metadata.rb'
+
+Metrics/PerceivedComplexity:
+  Exclude:
+    - 'lib/fedora_migrate/rights_metadata.rb'
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ClassLength:
+  Exclude:
+    - 'lib/fedora_migrate/rights_metadata.rb'
+
+Metrics/ModuleLength:
+  Exclude:
+
+Style/BlockDelimiters:
+  Exclude:
+    - 'spec/**/*'
+
+Style/BlockEndNewline:
+  Exclude:
+    - 'spec/**/*'
+
+Style/MultilineBlockLayout:
+  Exclude:
+    - 'spec/**/*'
+
+Style/IndentationConsistency:
+  EnforcedStyle: rails
+
+Style/CollectionMethods:
+  PreferredMethods:
+    collect: 'map'
+    collect!: 'map!'
+    inject: 'reduce'
+    detect: 'find'
+    find_all: 'select'
+
+Style/WordArray:
+  Enabled: false
+
+Style/RegexpLiteral:
+  Enabled: false
+
+Style/StringLiterals:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/HashSyntax:
+  Exclude:
+
+Style/LineEndConcatenation:
+  Exclude:
+
+Style/PredicateName:
+  Exclude:
+
+Style/GlobalVars:
+  Exclude:
+    - 'spec/**/*'
+
+Style/SingleLineBlockParams:
+  Enabled: false
+
+Style/ClassVars:
+  Exclude:
+
+Style/SignalException:
+  Enabled: false
+
+Rails/Output:
+  Exclude:
+
+Rails/Date:
+  Enabled: false
+
+Rails/TimeZone:
+  Enabled: false
+
+RSpec/ExampleWording:
+  CustomTransform:
+    be: is
+    have: has
+    not: does not
+    NOT: does NOT
+  IgnoredWords:
+    - only
+
+RSpec/FilePath:
+  Enabled: false
+
+RSpec/InstanceVariable:
+  Enabled: false
+
+RSpec/DescribeClass:
+  Exclude:
+
+Style/FileName:
+  Exclude:
+    - 'lib/fedora-migrate.rb'
+
+Style/VariableName:
+  Exclude:
+    - 'lib/fedora_migrate/permissions_mover.rb'

data/.rubocop_todo.yml

@@ -0,0 +1,9 @@
+require: rubocop-rspec
+
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/**/*'
+
+Style/GuardClause:
+  Exclude:
+    - 'lib/fedora_migrate/rights_metadata.rb'

data/.travis.yml

@@ -1,8 +1,9 @@
 language: ruby
-cache: bundler
 sudo: false
 rvm:
-  - 2.2
+  - 2.2.0
+  - 2.2.1
+  - 2.3.0
 env:
   global:
     - NOKOGIRI_USE_SYSTEM_LIBRARIES=true

data/Gemfile

@@ -6,3 +6,5 @@ gemspec
 gem 'byebug'
 gem 'pry'
 gem 'http_logger'
+gem 'rubocop', '~> 0.39.0', require: false
+gem 'rubocop-rspec', '~> 1.4.1', require: false

data/fedora-migrate.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "jettywrapper"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec-its"
 end

data/lib/fedora-migrate.rb

@@ -5,7 +5,7 @@ require "hydra/head"
 require "rubydora"
 
 # Loads rake tasks
-Dir[File.expand_path(File.join(File.dirname(__FILE__),"tasks/*.rake"))].each { |ext| load ext } if defined?(Rake)
+Dir[File.expand_path(File.join(File.dirname(__FILE__), "tasks/*.rake"))].each { |ext| load ext } if defined?(Rake)
 
 module FedoraMigrate
   extend ActiveSupport::Autoload
@@ -45,19 +45,17 @@ module FedoraMigrate
       @source ||= FedoraMigrate::RubydoraConnection.new(fedora_config.credentials)
     end
 
-    def find id
+    def find(id)
       FedoraMigrate.source.connection.find(id)
     end
 
-    def migrate_repository args
+    def migrate_repository(args)
       migrator = FedoraMigrate::RepositoryMigrator.new(args[:namespace], args[:options])
       migrator.migrate_objects
       migrator.migrate_relationships
       migrator
     end
-
   end
 
   self.configurator ||= FedoraMigrate::FileConfigurator.new
-
 end

data/lib/fedora_migrate/content_mover.rb

@@ -1,6 +1,5 @@
 module FedoraMigrate
   class ContentMover < Mover
-
     include DatastreamVerification
 
     class Report
@@ -36,13 +35,13 @@ module FedoraMigrate
     end
 
     def insert_date_created_by_application
-      result = perform_sparql_insert 
+      result = perform_sparql_insert
       report.original_date = source.createDate.iso8601
       report.error = "There was a problem with sparql #{result.status} #{result.body}" unless result.status == 204
     end
 
     def sparql_insert
-<<-EOF
+      <<-EOF
 PREFIX premis: <http://www.loc.gov/premis/rdf/v1#>
 PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
 DELETE WHERE { ?s premis:hasDateCreatedByApplication ?o } ;
@@ -55,17 +54,14 @@ EOF
 
     private
 
-    def perform_sparql_insert
-      ActiveFedora.fedora.connection.patch(target.metadata.metadata_uri, sparql_insert, "Content-Type" => "application/sparql-update")
-    end
+      def perform_sparql_insert
+        ActiveFedora.fedora.connection.patch(target.metadata.metadata_uri, sparql_insert, "Content-Type" => "application/sparql-update")
+      end
 
-    def nil_source
-      if source.content.nil?
+      def nil_source
+        return unless source.content.nil?
         report.error = "Nil source -- it's probably defined in the target but not present in the source"
         true
       end
-    end
-
   end
-
 end

data/lib/fedora_migrate/datastream_mover.rb

@@ -1,6 +1,5 @@
 module FedoraMigrate
   class DatastreamMover < Mover
-
     attr_accessor :versionable
 
     def post_initialize
@@ -28,33 +27,31 @@ module FedoraMigrate
 
     private
 
-    def migrate_datastream
-      if versionable?
-        migrate_versions
-      else
-        migrate_current
+      def migrate_datastream
+        if versionable?
+          migrate_versions
+        else
+          migrate_current
+        end
       end
-    end
-
-    # Reload the target, otherwise the checksum is nil
-    def migrate_current
-      migrate_content
-      target.reload if report.last.success?
-    end
 
-    # Rubydora stores the versions array as the most recent first. We explicitly sort them according to createDate
-    def migrate_versions
-      source.versions.sort { |a,b| a.createDate <=> b.createDate }.each do |version|
-        migrate_content(version)
-        target.create_version if report.last.success? && !application_creates_versions?
+      # Reload the target, otherwise the checksum is nil
+      def migrate_current
+        migrate_content
+        target.reload if report.last.success?
       end
-    end
 
-    def migrate_content datastream=nil
-      datastream ||= source
-      report << FedoraMigrate::ContentMover.new(datastream, target).migrate
-    end
+      # Rubydora stores the versions array as the most recent first. We explicitly sort them according to createDate
+      def migrate_versions
+        source.versions.sort { |a, b| a.createDate <=> b.createDate }.each do |version|
+          migrate_content(version)
+          target.create_version if report.last.success? && !application_creates_versions?
+        end
+      end
 
+      def migrate_content(datastream = nil)
+        datastream ||= source
+        report << FedoraMigrate::ContentMover.new(datastream, target).migrate
+      end
   end
-
 end

data/lib/fedora_migrate/datastream_verification.rb

@@ -1,34 +1,32 @@
 module FedoraMigrate::DatastreamVerification
-  
   attr_accessor :datastream
 
-  def valid? datastream=nil
+  def valid?(datastream = nil)
     @datastream = datastream || @source
-    has_matching_checksums? || has_matching_nokogiri_checksums?
+    matching_checksums? || matching_nokogiri_checksums?
   end
 
-  def has_matching_checksums?
+  def matching_checksums?
     datastream.checksum == target_checksum || checksum(datastream.content) == target_checksum
   end
 
-  def has_matching_nokogiri_checksums?
+  def matching_nokogiri_checksums?
     return false unless datastream.mimeType == "text/xml"
     checksum(Nokogiri::XML(datastream.content).to_xml) == checksum(Nokogiri::XML(target_content).to_xml)
   end
 
-  private 
+  private
 
-  def target_checksum
-    target.digest.first.to_s.split(/:/).last
-  end
-
-  # In some cases, the data is in ldp_source but target.content is empty, so we check both places
-  def target_content
-    target.content.empty? ? target.ldp_source.content : target.content
-  end
+    def target_checksum
+      target.digest.first.to_s.split(/:/).last
+    end
 
-  def checksum content
-    Digest::SHA1.hexdigest(content)
-  end
+    # In some cases, the data is in ldp_source but target.content is empty, so we check both places
+    def target_content
+      target.content.empty? ? target.ldp_source.content : target.content
+    end
 
+    def checksum(content)
+      Digest::SHA1.hexdigest(content)
+    end
 end

data/lib/fedora_migrate/dates_mover.rb

@@ -1,6 +1,5 @@
 module FedoraMigrate
   class DatesMover < Mover
-
     Report = Struct.new(:uploaded, :modified)
 
     def migrate
@@ -22,6 +21,5 @@ module FedoraMigrate
       target.date_modified = source.lastModifiedDate
       report.modified = source.lastModifiedDate
     end
-
   end
 end

data/lib/fedora_migrate/file_configurator.rb

@@ -1,6 +1,5 @@
 module FedoraMigrate
   class FileConfigurator < ActiveFedora::FileConfigurator
-
     def fedora3_config
       load_fedora3_config
       @fedora_config
@@ -13,8 +12,8 @@ module FedoraMigrate
 
       begin
         config_erb = ERB.new(IO.read(@fedora_config_path)).result(binding)
-      rescue Exception => e
-        raise("fedora.yml was found, but could not be parsed with ERB. \n#{$!.inspect}")
+      rescue StandardError
+        raise("fedora.yml was found, but could not be parsed with ERB. \n#{$ERROR_INFO.inspect}")
       end
 
       begin
@@ -27,8 +26,7 @@ module FedoraMigrate
       config = fedora_yml.symbolize_keys
 
       cfg = config[ActiveFedora.environment.to_sym] || {}
-      @fedora_config = cfg.kind_of?(Array) ? cfg.map(&:symbolize_keys) : cfg.symbolize_keys
+      @fedora_config = cfg.is_a?(Array) ? cfg.map(&:symbolize_keys) : cfg.symbolize_keys
     end
-
   end
 end

data/lib/fedora_migrate/hooks.rb

@@ -5,7 +5,6 @@
 # you application and substitute methods for the ones listed below
 module FedoraMigrate
   module Hooks
-
     # Called from FedoraMigrate::ObjectMover
     def before_object_migration
     end
@@ -29,6 +28,5 @@ module FedoraMigrate
     # Called from FedoraMigrate::DatastreamMover
     def after_datastream_migration
     end
-
   end
 end

data/lib/fedora_migrate/logger.rb

@@ -1,28 +1,26 @@
 module FedoraMigrate
   class Logger
-
     class << self
-
-      def method_missing method_name, *arguments, &block
+      def method_missing(method_name, *arguments, &block)
         logger.send(method_name, *arguments, &block)
       rescue
         super
       end
 
-      def respond_to?(method_name, include_private = false)
+      def respond_to?(method_name, _include_private = false)
         logger.respond_to? method_name
       end
 
-      def info msg
-        super("FedoraMigrate INFO: ##{caller_locations(1,1)[0].label} " + msg)
+      def info(msg)
+        super("FedoraMigrate INFO: ##{caller_locations(1, 1)[0].label} " + msg)
       end
 
-      def warn msg
-        super("FedoraMigrate WARN: ##{caller_locations(1,1)[0].label} " + msg)
+      def warn(msg)
+        super("FedoraMigrate WARN: ##{caller_locations(1, 1)[0].label} " + msg)
       end
 
-      def fatal msg
-        super("FedoraMigrate FATAL: ##{caller_locations(1,1)[0].label} " + msg)
+      def fatal(msg)
+        super("FedoraMigrate FATAL: ##{caller_locations(1, 1)[0].label} " + msg)
       end
 
       private
@@ -30,7 +28,6 @@ module FedoraMigrate
       def logger
         ActiveFedora::Base.logger || ::Logger.new(STDOUT)
       end
-
     end
   end
 end