fe 0.0.4 → 1.0.0

data/db/migrate/20140625160545_create_fe_users.rb

@@ -1,6 +1,6 @@
 class CreateFeUsers < ActiveRecord::Migration
   def change
-    create_table :fe_users do |t|
+    create_table Fe::User do |t|
       t.integer :user_id
       t.datetime :last_login
       t.string :type

data/db/migrate/20150504221439_add_all_element_ids_to_pages.rb

@@ -0,0 +1,5 @@
+class AddAllElementIdsToPages < ActiveRecord::Migration
+  def change
+    add_column Fe::Page.table_name, :all_element_ids, :text
+  end
+end

data/db/migrate/20150713022326_add_locale_columns.rb

@@ -0,0 +1,9 @@
+class AddLocaleColumns < ActiveRecord::Migration
+  def change
+    add_column Fe::QuestionSheet.table_name, :languages, :text
+    add_column Fe::Element.table_name, :label_translations, :text
+    add_column Fe::Element.table_name, :tip_translations, :text
+    add_column Fe::Element.table_name, :content_translations, :text
+    add_column Fe::Page.table_name, :label_translations, :text
+  end
+end

data/db/migrate/20150714220730_add_locale_to_answer_sheet.rb

@@ -0,0 +1,5 @@
+class AddLocaleToAnswerSheet < ActiveRecord::Migration
+  def change
+    add_column Fe.answer_sheet_class.constantize.table_name, :locale, :string, default: 'en'
+  end
+end

data/db/migrate/20150928085325_change_pages_all_element_ids_to_text.rb

@@ -0,0 +1,5 @@
+class ChangePagesAllElementIdsToText < ActiveRecord::Migration
+  def change
+    change_column Fe::Page.table_name, :all_element_ids, :text
+  end
+end

data/db/migrate/20150930191538_add_locale_to_reference_sheets.rb

@@ -0,0 +1,5 @@
+class AddLocaleToReferenceSheets < ActiveRecord::Migration
+  def change
+    add_column Fe::ReferenceSheet.table_name, :locale, :string, default: 'en'
+  end
+end

data/lib/access_key_generator.rb

@@ -0,0 +1,12 @@
+require 'securerandom'
+
+module Fe
+  module AccessKeyGenerator
+    def generate_access_key
+      begin
+        self.access_key = SecureRandom.hex
+      end while self.class.exists?(access_key: access_key)
+      return access_key
+    end
+  end
+end

data/lib/distinct_distinct_patch.rb

@@ -0,0 +1,20 @@
+require 'active_record'
+
+module DistinctDistinctPatch
+  def construct_limited_ids_condition(relation)
+    orders = relation.order_values.map { |val| val.presence }.compact
+    values = @klass.connection.distinct("#{@klass.connection.quote_table_name table_name}.#{primary_key}", orders)
+
+    relation = relation.dup.select(values)
+    relation.uniq_value = nil
+
+    id_rows = @klass.connection.select_all(relation.arel, 'SQL', relation.bind_values)
+    ids_array = id_rows.map {|row| row[primary_key]}
+
+    ids_array.empty? ? raise(ActiveRecord::ThrowResult) : table[primary_key].in(ids_array)
+  end
+end
+
+class ActiveRecord::Relation
+  include DistinctDistinctPatch
+end

data/lib/fe.rb

@@ -1,6 +1,7 @@
 require "fe/engine"
 
 module Fe
+  LANGUAGES = { 'es' => 'Español', 'pt' => 'Português' }
   # prefix for database tables
   mattr_accessor :table_name_prefix
   self.table_name_prefix ||= 'fe_'
@@ -11,6 +12,9 @@ module Fe
   mattr_accessor :from_email
   self.from_email ||= 'info@example.com'
 
+  mattr_accessor :never_reuse_elements
+  self.never_reuse_elements = false
+
   def self.next_label(prefix, labels)
     max = labels.inject(0) do |m, label|
       num = label[/^#{prefix} ([0-9]+)$/i, 1].to_i   # extract your digits

data/lib/fe/engine.rb

@@ -1,3 +1,5 @@
+require 'acts_as_list'
+
 module Fe
   class Engine < ::Rails::Engine
     # isolate_namespace is causing problems accessing the app's url helpers when the app
@@ -37,12 +39,22 @@ module Fe
 
 
     config.to_prepare do
-      Dir.glob(File.join(File.dirname(__FILE__), "..", "..", "app", "**", "*_concern.rb")).each do |c|
-        require_dependency(c)
+      require_dependency('distinct_distinct_patch.rb')
+      require_dependency('access_key_generator')
+
+      # Loading concerns and dependencies here when running FE specs breaks the coverage report.  The
+      # Rakefile will set SKIP_CONCERNS and SKIP_DECORATORS true and decorators/concerns are loaded from
+      # spec/rails_helper.rb instead
+      if ENV['SKIP_CONCERNS'] != 'true'
+        Dir.glob(File.join(File.dirname(__FILE__), "..", "..", "app", "**", "*_concern.rb")).each do |c|
+          require_dependency(c)
+        end
       end
 
-      Dir.glob(File.join(Rails.root + 'app/decorators/**/*_decorator.rb')).each do |c|
-        require_dependency(c)
+      if ENV['SKIP_CONCERNS'] != 'true'
+        Dir.glob(File.join(Rails.root + 'app/decorators/**/*_decorator.rb')).each do |c|
+          require_dependency(c)
+        end
       end
     end
 

data/lib/fe/version.rb

@@ -1,3 +1,3 @@
 module Fe
-  VERSION = "0.0.4"
+  VERSION = "1.0.0"
 end

data/spec/controllers/fe/admin/elements_controller_spec.rb

@@ -1,4 +1,204 @@
 require 'rails_helper'
 
-describe Fe::Admin::ElementsController do
+describe Fe::Admin::ElementsController, type: :controller do
+  context '#show' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element)
+      create(:page_element, element: element, page: page)
+
+      xhr :get, :edit, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id
+      expect(assigns(:element)).to eq(element)
+    end
+  end
+  context '#new' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+
+      xhr :get, :new, element_type: 'Fe::TextField', element: { style: 'style' }, question_sheet_id: question_sheet.id, page_id: page.id
+      expect(assigns(:questions)).to eq([element])
+    end
+  end
+  context '#use_existing' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+
+      xhr :get, :use_existing, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id
+      expect(assigns(:page_element)).to_not be_nil
+    end
+    it 'should not put the same question on a questionnaire twice' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+
+      xhr :get, :use_existing, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id
+      expect(assigns(:page_element)).to be_nil
+    end
+  end
+  context '#create' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+
+      expect {
+        xhr :post, :create, element_type: 'Fe::TextField', element: { style: 'style' }, question_sheet_id: question_sheet.id, page_id: page.id
+      }.to change{Fe::Element.count}.by(1)
+
+      expect(assigns(:page_element)).to_not be_nil
+      new_element = Fe::Element.last
+      expect(assigns(:page_element).element).to eq(new_element)
+      expect(assigns(:page_element).page).to eq(page)
+    end
+    it 'should handle error saving element' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+
+      expect {
+        xhr :post, :create, element_type: 'Fe::TextField', element: { slug: "Illegal Chars: #@$!" }, question_sheet_id: question_sheet.id, page_id: page.id
+      }.to change{Fe::Element.count}.by(0)
+
+      expect(assigns(:page_element)).to be_nil
+      expect(response).to render_template('error.js.erb')
+    end
+  end
+  context '#update' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+
+      xhr :put, :update, element: { style: 'style' }, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id
+
+      expect(assigns(:element)).to eq(element)
+      expect(assigns(:element).style).to eq('style')
+    end
+    it 'should handle error saving element' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+
+      xhr :put, :update, element: { slug: "Illegal Chars: #@$!" }, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id
+      expect(assigns(:element)).to eq(element)
+      expect(response).to render_template('error.js.erb')
+    end
+  end
+  context '#destroy' do
+    it 'should destroy the element when it is not used in any other pages' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+
+      xhr :delete, :destroy, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id
+
+      expect(Fe::PageElement.find_by(page_id: page.id, element_id: element.id)).to be_nil
+      expect(Fe::Element.find_by(id: element.id)).to be_nil
+    end
+    it 'should not destroy the element when it is not used in any other pages, but it has answers' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+      create(:answer, question: element, value: 'answer here', answer_sheet: answer_sheet)
+
+      xhr :delete, :destroy, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id
+
+      expect(Fe::PageElement.find_by(page_id: page.id, element_id: element.id)).to be_nil
+      expect(Fe::Element.find_by(id: element.id)).to_not be_nil
+    end
+    it 'should not destroy the element when it has no answers, but is being used in another page' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      page2 = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+      create(:page_element, element: element, page: page2)
+
+      xhr :delete, :destroy, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id
+
+      expect(Fe::PageElement.find_by(page_id: page.id, element_id: element.id)).to be_nil
+      expect(Fe::Element.find_by(id: element.id)).to_not be_nil
+    end
+  end
+
+  context '#reorder' do
+    it 'should work inside a question grid' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      element2 = create(:text_field_element, style: 'style')
+      element3 = create(:question_grid, style: 'style')
+      element4 = create(:text_field_element, style: 'style', question_grid_id: element3.id)
+      element5 = create(:text_field_element, style: 'style', question_grid_id: element3.id)
+      create(:page_element, element: element, page: page)
+      create(:page_element, element: element2, page: page)
+      create(:page_element, element: element3, page: page)
+
+      page_element_positions_before = Fe::PageElement.all.pluck(:position)
+
+      xhr :post, :reorder, question_sheet_id: question_sheet.id, page_id: page.id, "questions_list_#{element3.id}" => [ element5.id, element4.id ]
+      # it shouldn't touch the page elements
+      expect(Fe::PageElement.all.pluck(:position)).to eq(page_element_positions_before)
+      # it should put a new order on the question grid elements
+      expect(element5.reload.position).to eq(1)
+      expect(element4.reload.position).to eq(2)
+    end
+    it 'should work outside a question grid' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      element2 = create(:text_field_element, style: 'style')
+      element3 = create(:question_grid, style: 'style')
+      element4 = create(:text_field_element, style: 'style', question_grid_id: element3.id)
+      element5 = create(:text_field_element, style: 'style', question_grid_id: element3.id)
+      pe1 = create(:page_element, element: element, page: page)
+      pe2 = create(:page_element, element: element2, page: page)
+      pe3 = create(:page_element, element: element3, page: page)
+
+      question_grid_elements_positions_before = element3.reload.elements.pluck(:position)
+
+      xhr :post, :reorder, question_sheet_id: question_sheet.id, page_id: page.id, "questions_list" => [ element3.id, element.id, element2.id ]
+      # it shouldn't touch the question grid positions
+      expect(element3.reload.elements.pluck(:position)).to eq(question_grid_elements_positions_before)
+      # it should put a new order on the page elements
+      expect(pe3.reload.position).to eq(1)
+      expect(pe1.reload.position).to eq(2)
+      expect(pe2.reload.position).to eq(3)
+    end
+  end
 end

data/spec/controllers/fe/admin/email_templates_controller_spec.rb

@@ -1,4 +1,29 @@
 require 'rails_helper'
 
-describe Fe::Admin::EmailTemplatesController do
+describe Fe::Admin::EmailTemplatesController, type: :controller do
+  let(:email_template) { create(:email_template) }
+
+  context '#index' do
+    it 'should work' do
+      email_template = create(:email_template, name: 'Template')
+      get :index
+      expect(assigns(:email_templates)).to eq([email_template])
+    end
+  end
+  
+  context '#new' do
+    it 'should work' do
+      get :new
+      expect(assigns(:email_template)).to_not be_nil
+    end
+  end
+
+  context '#create' do
+    it 'should work' do
+      expect {
+        post :create, email_template: { name: 'Name', subject: 'Subject', content: 'Content' }
+      }.to change{Fe::EmailTemplate.count}.by(1)
+      expect(assigns(:email_template)).to_not be_nil
+    end
+  end
 end

data/spec/controllers/fe/admin/question_pages_controller_spec.rb

@@ -1,4 +1,11 @@
 require 'rails_helper'
 
-describe Fe::Admin::QuestionPagesController do
+describe Fe::Admin::QuestionPagesController, type: :controller do
+  context '#show' do
+    it 'should work' do
+      page = create(:page)
+      question_sheet = page.question_sheet
+      xhr :get, :show, question_sheet_id: question_sheet.id, id: page.id
+    end
+  end
 end

data/spec/controllers/fe/admin/question_sheets_controller_spec.rb

@@ -1,4 +1,51 @@
 require 'rails_helper'
 
-describe Fe::Admin::QuestionSheetsController do
+describe Fe::Admin::QuestionSheetsController, type: :controller do
+  context '#index' do
+    it 'should work' do
+      active_qs = create(:question_sheet, archived: false)
+      archived_qs = create(:question_sheet, archived: true)
+      get :index
+      expect(assigns(:active_question_sheets)).to_not be_nil
+      expect(assigns(:archived_question_sheets)).to_not be_nil
+      expect(assigns(:active_question_sheets)).to eq([active_qs])
+      expect(assigns(:archived_question_sheets)).to eq([archived_qs])
+    end
+  end
+  context '#archive' do
+    it 'should work' do
+      active_qs = create(:question_sheet, archived: false)
+      request.env["HTTP_REFERER"] = '/'
+      post :archive, id: active_qs.id
+      expect(active_qs.reload.archived).to be true
+    end
+  end
+  context '#unarchive' do
+    it 'should work' do
+      active_qs = create(:question_sheet, archived: true)
+      request.env["HTTP_REFERER"] = '/'
+      post :unarchive, id: active_qs.id
+      expect(active_qs.reload.archived).to be false
+    end
+  end
+  context '#duplicate' do
+    it 'should work' do
+      qs = create(:question_sheet)
+      request.env["HTTP_REFERER"] = '/'
+      expect {
+        post :duplicate, id: qs.id
+      }.to change{Fe::QuestionSheet.count}.by(1)
+      expect(Fe::QuestionSheet.last.label).to eq("#{qs.label} - COPY")
+    end
+  end
+  context '#show' do
+    it 'should work' do
+      qs = create(:question_sheet)
+      p1 = create(:page, question_sheet: qs)
+      p2 = create(:page, question_sheet: qs)
+      get :show, id: qs.id
+      expect(assigns(:all_pages)).to eq([p1, p2])
+      expect(assigns(:page)).to eq(p1)
+    end
+  end
 end

data/spec/controllers/fe/answer_pages_controller_spec.rb

@@ -1,4 +1,76 @@
 require 'rails_helper'
 
-describe Fe::AnswerPagesController do
+describe Fe::AnswerPagesController, type: :controller do
+  context '#edit' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      get :edit, id: page.id, answer_sheet_id: answer_sheet.id
+      expect(response).to render_template('fe/answer_pages/_answer_page')
+    end
+  end
+  context '#update' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element)
+      create(:page_element, element: element, page: page)
+      # ref
+      reference_question = create(:reference_question)
+      reference_sheet = create(:reference_sheet, applicant_answer_sheet_id: answer_sheet.id, email: 'initial@ref.com')
+
+      xhr :put, :update, {
+        answers: { "#{element.id}" => 'answer here' },
+        reference: { "#{reference_sheet.id}" => {
+          relationship: 'roommate',
+          title: 'A',
+          first_name: 'FN',
+          last_name: 'LN',
+          phone: 'phone',
+          email: 'email@reference.com'
+        } },
+        id: page.id,
+        answer_sheet_id: answer_sheet.id
+      }
+
+      expect(response).to render_template('fe/answer_pages/update')
+      expect(Fe::Answer.find_by(answer_sheet_id: answer_sheet.id, question_id: element.id).value).to eq('answer here')
+      expect(reference_sheet.reload.email).to eq('email@reference.com')
+    end
+    it 'should store a reference sheet answer' do
+      # create a normal applicant sheet to make sure the answer isn't saved to that
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element)
+      create(:page_element, element: element, page: page)
+      # ref
+      ref_page = create(:page, label: 'Ref Page')
+      ref_question_sheet = ref_page.question_sheet
+      ref_element = create(:text_field_element)
+      create(:page_element, element: ref_element, page: ref_page)
+      reference_question = create(:reference_question, related_question_sheet_id: ref_question_sheet.id)
+      reference_sheet = create(:reference_sheet, question_id: reference_question.id, applicant_answer_sheet_id: answer_sheet.id, email: 'initial@ref.com')
+
+      xhr :put, :update, {
+        answers: { "#{ref_element.id}" => 'ref answer here' },
+        id: ref_page.id,
+        answer_sheet_id: reference_sheet.id,
+        answer_sheet_type: 'Fe::ReferenceSheet'
+      }
+
+      expect(response).to render_template('fe/answer_pages/update')
+      expect(Fe::Answer.find_by(answer_sheet_id: reference_sheet.id, question_id: ref_element.id).value).to eq('ref answer here')
+      expect(Fe::Answer.find_by(answer_sheet_id: answer_sheet.id, question_id: element.id)).to be_nil
+      # check the associations on reference/answer sheet returns the correct answers
+      expect(reference_sheet.reload.answers.collect(&:value)).to eq(['ref answer here'])
+      expect(answer_sheet.reload.answers).to eq([])
+    end
+  end
+
 end