fe 0.0.4 → 1.0.0

data/spec/factories/reference_sheets.rb

@@ -0,0 +1,9 @@
+FactoryGirl.define do 
+  factory :reference_sheet, class: Fe::ReferenceSheet do
+    sequence(:email) { |n| "email_#{n}@email.com" }
+    sequence(:first_name) { |n| "fn_#{n}" }
+    sequence(:last_name) { |n| "ln_#{n}" }
+    sequence(:phone) { |n| "phone_#{n}" }
+    sequence(:relationship) { |n| "relationship_#{n}" }
+  end
+end

data/spec/mailers/fe/notifier_spec.rb

@@ -0,0 +1,39 @@
+require 'rails_helper'
+ 
+RSpec.describe Fe::Notifier do
+  describe 'instructions' do
+    let(:user) { mock_model User, name: 'Lucas', email: 'lucas@email.com' }
+    let(:mail) { Fe::Notifier.notification('recipient@test.com', 'from@test.com', 'Staff Payment Request', {}, {format: 'html'}) }
+ 
+    before(:each) do
+      create(:fe_email_template, name: 'Staff Payment Request', subject: 'Staff Payment Request Subject', content: "<a href='test'>test</a>")
+    end
+
+    it 'renders the subject' do
+      expect(mail.subject).to eql('Staff Payment Request Subject')
+    end
+ 
+    it 'renders the receiver email' do
+      expect(mail.to).to eql(['recipient@test.com'])
+    end
+ 
+    it 'renders the sender email' do
+      expect(mail.from).to eql(['from@test.com'])
+    end
+ 
+    it 'sets the email to be an html email when format passed in is html' do
+      mail = Fe::Notifier.notification('recipient@test.com', 'from@test.com', 'Staff Payment Request', {}, {format: 'html'})
+      expect(mail[:content_type].to_s).to match(/text\/html/)
+    end
+
+    it 'sets the email to be a text email when text format is passed in' do
+      mail = Fe::Notifier.notification('recipient@test.com', 'from@test.com', 'Staff Payment Request', {}, {format: 'text'})
+      expect(mail[:content_type].to_s).to match(/text\/plain/)
+    end
+
+    it 'sets the email to be a text email when no format passed in' do
+      mail = Fe::Notifier.notification('recipient@test.com', 'from@test.com', 'Staff Payment Request', {}, {})
+      expect(mail[:content_type].to_s).to match(/text\/plain/)
+    end
+  end
+end

data/spec/models/fe/choice_field_spec.rb

@@ -1,4 +1,5 @@
 require 'rails_helper'
+require 'rexml/document'
 
 describe Fe::ChoiceField do
   
@@ -29,4 +30,23 @@ describe Fe::ChoiceField do
     end
   end
   
+  context '#choices' do
+    it 'should work for yes-no style' do
+      expect(Fe::ChoiceField.new(style: 'yes-no').choices).to eq([["Yes",1],["No",0]])
+    end
+    it 'should work for acceptance style' do
+      expect(Fe::ChoiceField.new(style: 'acceptance').choices).to eq([["Yes",1],["No",0]])
+    end
+    it 'should work for a local source using libxml' do
+      expect(Fe::ChoiceField.new(style: 'drop-down', source: 'spec/support/choices.xml', text_xpath: 'choice', value_xpath: 'value').choices).to eq([["A","1"],["B","0"]])
+    end
+    if RUBY_VERSION =~ /^2/
+      it 'should work for a remote source using rexml' do
+        expect(Fe::ChoiceField.new(style: 'drop-down', source: 'https://raw.githubusercontent.com/CruGlobal/qe/fe/spec/support/choices.xml', text_xpath: '*/choice', value_xpath: '*/value').choices).to eq([["A","1"],["B","0"]])
+      end
+    end
+    it 'should work for content set' do
+      expect(Fe::ChoiceField.new(style: 'drop-down', content: "1;A\n0;B").choices).to eq([["A","1"],["B","0"]])
+    end
+  end
 end

data/spec/models/fe/element_spec.rb

@@ -1,5 +1,12 @@
 require 'rails_helper'
 
+# when using a decorator in the enclosing app I get an error, don't have the time to
+# figure it out and since it's low priority since we're just testing, doing it here
+# should be fine
+Fe::Application.class_eval do
+  belongs_to :applicant, foreign_key: 'applicant_id', class_name: 'Person'
+end
+
 describe Fe::Element do
   it { expect belong_to :question_grid }  
   it { expect belong_to :choice_field }  
@@ -10,6 +17,22 @@ describe Fe::Element do
   it { expect ensure_length_of :kind }
   it { expect ensure_length_of :style }
 
+  it "should not require an element with choice_field set that has a false value" do
+    question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+    choice_field = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the enclosed element", conditional_type: "Fe::Element")
+    question_sheet.pages.reload
+    question_sheet.pages[3].elements << choice_field
+    element = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer that will be hidden by the enclosing element", choice_field_id: choice_field.id, required: true)
+
+    application = FactoryGirl.create(:answer_sheet)
+
+    # make the answer to the conditional question 'no' so that the element is not required
+    choice_field.set_response("no", application)
+    choice_field.save_response(application)
+
+    expect(element.required?(application)).to be false
+  end
+
   it "should update a conditional question if added after that question" do
     question_sheet = FactoryGirl.create(:question_sheet_with_pages)
     conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next element", conditional_type: "Fe::Element")
@@ -21,6 +44,32 @@ describe Fe::Element do
     expect(conditional_el.conditional).to eq(element)
   end
 
+  context "in a grid" do
+    it "should update a conditional question if added after that question" do
+      question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+      question_grid = FactoryGirl.create(:question_grid)
+      question_sheet.pages.reload
+      question_sheet.pages[3].elements << question_grid
+
+      conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next element", conditional_type: "Fe::Element", question_grid_id: question_grid.id)
+      element = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer that will be hidden by the previous elemenet", conditional_type: nil, conditional_answer: nil, question_grid_id: question_grid.id)
+      expect(conditional_el.reload.conditional).to eq(element)
+    end
+
+    it "should update the condition element" do
+      question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+      question_grid = FactoryGirl.create(:question_grid)
+      question_sheet.pages.reload
+      question_sheet.pages[3].elements << question_grid
+
+      conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next element", conditional_type: "Fe::Element", question_grid_id: question_grid.id)
+      element = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer that will be hidden by the previous elemenet", conditional_type: nil, conditional_answer: nil, question_grid_id: question_grid.id)
+
+      conditional_el.set_conditional_element
+      expect(conditional_el.conditional).to eq(element)
+    end
+  end
+
   it "should update a conditional question if elements are moved around" do
     question_sheet = FactoryGirl.create(:question_sheet_with_pages)
     conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next element", conditional_type: "Fe::Element")
@@ -139,4 +188,140 @@ describe Fe::Element do
     # validate the hidden page, it should be marked complete because of being hidden
     expect(hide_page.complete?(application)).to eq(true)
   end
+
+  it "should return false for has_response?" do
+    element = Fe::Element.new
+    expect(element.has_response?).to be false
+  end
+
+  context '#limit' do
+    it "should return a value for a legitimate object_name and attribute_name" do
+      application = FactoryGirl.create(:application)
+      application.applicant_id = create(:fe_person).id
+      element = Fe::Element.new object_name: 'applicant', attribute_name: 'first_name'
+      expect(element.limit(application)).to_not be_nil
+    end
+    it "should return nil instead of crashing if there's an exception thrown" do
+      application = FactoryGirl.create(:application)
+      application.applicant_id = create(:fe_person).id
+      element = Fe::Element.new object_name: 'applicant', attribute_name: 'asdf'
+      expect(element.limit(application)).to be_nil
+    end
+  end
+
+  context '#previous_element' do
+    it "should work" do
+      application = FactoryGirl.create(:application)
+      application.applicant_id = create(:fe_person).id
+      element1 = create(:text_field_element)
+      element2 = create(:text_field_element)
+      element3 = create(:text_field_element)
+      page = create(:page)
+      create(:page_element, page_id: page.id, element_id: element1.id)
+      create(:page_element, page_id: page.id, element_id: element2.id)
+      create(:page_element, page_id: page.id, element_id: element3.id)
+      expect(element2.previous_element(page.question_sheet)).to eq(element1)
+    end
+  end
+
+  context '#required' do
+    it "should work when the required flag is set" do
+      # TODO
+    end
+    it "should not require a conditional element when its prev element isn't matching the answer text" do
+      application = FactoryGirl.create(:application)
+      application.applicant_id = create(:fe_person).id
+      element1 = create(:text_field_element)
+      element2 = create(:text_field_element, conditional_answer: 'test')
+      element3 = create(:text_field_element, required: true)
+      # set conditional element to element3 (note that an element's conditional ref will always either be a page or the *next* element, never any other element than the next one)
+      element2.conditional = element3
+      element2.save!
+
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:page_element, page_id: page.id, element_id: element1.id)
+      create(:page_element, page_id: page.id, element_id: element2.id)
+      create(:page_element, page_id: page.id, element_id: element3.id)
+
+      # set up an answer sheet
+      application = FactoryGirl.create(:answer_sheet)
+      application.answer_sheet_question_sheet = FactoryGirl.create(:answer_sheet_question_sheet, answer_sheet: application, question_sheet: question_sheet)
+      application.answer_sheet_question_sheets.first.update_attributes(question_sheet_id: question_sheet.id)
+
+      # make the answer to the conditional question 'yes' so that the element shows up and is thus required
+      element2.set_response('nomatch', application)
+      element2.save_response(application)
+
+      expect(element3.required?(application)).to be false
+    end
+  end
+  context '#clone' do
+    it 'should duplicate question grid elements' do
+      element1 = create(:question_grid)
+      element2 = create(:text_field_element, question_grid_id: element1.id, position: 0) # added to grid
+      element3 = create(:text_field_element, question_grid_id: element1.id, position: 1) # added to grid
+      page = create(:page)
+      create(:page_element, page_id: page.id, element_id: element1.id)
+      expect {
+        element3.duplicate(page, element1)
+      }.to change{element1.reload.elements.count}.by(1) # added to grid
+      expect(element1.elements.last.position).to eq(2) # added to end of grid
+      expect(element1.elements.last.question_grid).to eq(element1) # added to the right grid
+      expect(element1.elements.last.pages).to eq([]) # not added to any pages
+    end
+    it 'should duplicate question' do
+      element1 = create(:question_grid)
+      element2 = create(:text_field_element)
+      element3 = create(:text_field_element)
+      page = create(:page)
+      create(:page_element, page_id: page.id, element_id: element1.id)
+      create(:page_element, page_id: page.id, element_id: element2.id)
+      create(:page_element, page_id: page.id, element_id: element3.id)
+      expect {
+        element3.duplicate(page)
+      }.to change{page.reload.elements.count}.by(1)
+      expect(page.page_elements.last.position).to eq(4)
+      expect(page.elements.last.question_grid).to be_nil
+      expect(page.elements.last.pages).to eq([page])
+    end
+  end
+  
+  context '#update_page_all_element_ids' do
+    it 'should rebuild all_element_ids in all pages' do
+      element1 = create(:text_field_element)
+      page1 = create(:page)
+      page2 = create(:page)
+      create(:page_element, page_id: page1.id, element_id: element1.id)
+      create(:page_element, page_id: page2.id, element_id: element1.id)
+      page1.update_column(:all_element_ids, nil)
+      page2.update_column(:all_element_ids, nil)
+      element1.pages.reload
+      element1.update_page_all_element_ids
+      expect(page1.reload.all_element_ids).to eq("#{element1.id}")
+      expect(page2.reload.all_element_ids).to eq("#{element1.id}")
+    end
+    it 'should rebuild all_element_ids when adding a question grid' do
+      page = create(:page)
+      grid = create(:question_grid)
+      create(:page_element, page_id: page.id, element_id: grid.id)
+      grid.pages.reload
+      textfield = create(:text_field_element, question_grid: grid)
+
+      page.update_column(:all_element_ids, nil)
+      textfield.update_page_all_element_ids
+      expect(page.reload.all_element_ids).to eq("#{grid.id},#{textfield.id}")
+    end
+    it 'should rebuild all_element_ids when adding a question grid with total' do
+      page = create(:page)
+      grid = create(:question_grid)
+      create(:page_element, page_id: page.id, element_id: grid.id)
+      grid.pages.reload
+      textfield = create(:text_field_element, question_grid: grid)
+
+      page.update_column(:all_element_ids, nil)
+      textfield.update_page_all_element_ids
+      expect(page.reload.all_element_ids).to eq("#{grid.id},#{textfield.id}")
+    end
+  end
 end

data/spec/models/fe/page_spec.rb

@@ -33,6 +33,8 @@ describe Fe::Page do
 
     # validate the page -- the next element after the conditional should not be required
     page = question_sheet.pages[3]
+    question_sheet.pages.reload
+    page.reload
     expect(page.complete?(application)).to eq(true)
 
     # make the answer to the conditional question 'yes' so that the next element shows up and is thus required
@@ -43,4 +45,114 @@ describe Fe::Page do
     page = question_sheet.pages[3]
     expect(page.complete?(application)).to eq(false)
   end
+
+  context '#all_elements' do
+    it 'should return elements in the same order the ids were given' do
+      p = create(:page, all_element_ids: '2,1')
+      e1 = create(:text_field_element)
+      e2 = create(:text_field_element)
+      expect(p.all_elements).to eq([e2,e1])
+    end
+    it 'should include elements in a grid' do
+      p = create(:page)
+      e = create(:question_grid)
+      create(:page_element, page: p, element: e)
+      tf1 = create(:text_field_element, question_grid: e)
+
+      # add text field directly to page
+      tf2 = create(:text_field_element)
+      create(:page_element, page: p, element: tf2)
+
+      # add section to grid
+      section = create(:section, question_grid: e)
+
+      p.reload # get the updated all_element_ids column
+      expect(p.all_elements).to eq([e, tf1, section, tf2])
+    end
+    it 'should return an empty active record result set when no elements are added' do
+      p = create(:page)
+      expect(p.all_elements).to eq([])
+    end
+    it 'should rebuild_all_element_ids first when not set' do
+      p = create(:page)
+      p.all_elements
+      p.reload
+      expect(p.all_element_ids).to eq('')
+    end
+  end
+  context '#has_questions?' do
+    it 'should return true when there is a question directly on the page' do
+      p = create(:page)
+      e = create(:text_field_element)
+      create(:page_element, page: p, element: e)
+      expect(p.has_questions?).to be true
+    end
+    it 'should not count a non-question directly on the page' do
+      p = create(:page)
+      e = create(:section)
+      create(:page_element, page: p, element: e)
+      expect(p.has_questions?).to be false
+    end
+    it 'should return true when the only question is in a grid' do
+      p = create(:page)
+      e = create(:question_grid)
+      create(:page_element, page: p, element: e)
+      tf1 = create(:text_field_element, question_grid: e)
+      section = create(:section, question_grid: e)
+      p.reload # get the updated all_element_ids column
+      expect(p.has_questions?).to be true
+    end
+    it 'should not count a non-question inside a grid as a question' do
+      p = create(:page)
+      e = create(:question_grid)
+      create(:page_element, page: p, element: e)
+      section = create(:section, question_grid: e)
+      p.reload # get the updated all_element_ids column
+      expect(p.has_questions?).to be false
+    end
+  end
+  context '#all_questions' do
+    it 'should include elements in a grid with total' do
+      p = create(:page)
+      grid = create(:question_grid_with_total) # shouldn't be included in all_questions because it's a not a question
+      create(:page_element, page: p, element: grid, position: 1)
+      tf1 = create(:text_field_element, question_grid: grid)
+      tf2 = create(:text_field_element) # add directly to page
+      create(:page_element, page: p, element: tf2, position: 2)
+      section = create(:section, question_grid: grid) # shouldn't be included in all_questions because it's not a question
+      p.reload # get the updated all_element_ids column
+      expect(p.all_questions).to eq([tf1, tf2])
+    end
+  end
+  context '#rebuild_all_element_ids' do
+    it 'should include elements in a grid' do
+      p = create(:page)
+      e = create(:question_grid)
+      create(:page_element, page: p, element: e)
+      tf1 = create(:text_field_element, question_grid: e)
+      tf2 = create(:text_field_element) # add directly to page
+      create(:page_element, page: p, element: tf2)
+      section = create(:section, question_grid: e)
+      p.update_column :all_element_ids, nil
+      p.rebuild_all_element_ids
+      expect(p.all_element_ids).to eq("#{e.id},#{tf1.id},#{section.id},#{tf2.id}")
+    end
+  end
+  context '#all_element_ids' do
+    it 'should rebuild_all_element_ids first when not set' do
+      p = create(:page)
+      p.all_element_ids
+      p.reload
+      expect(p.all_element_ids).to eq('')
+    end
+    it 'should rebuild_all_element_ids when an element is removed from a page' do
+      p = create(:page)
+      e = create(:text_field_element, question_grid: e)
+      pe = create(:page_element, page: p, element: e)
+      expect(p.all_element_ids).to eq(e.id.to_s)
+      pe.destroy
+      p.reload
+      expect(p.all_element_ids).to eq('')
+    end
+  end
 end

data/spec/models/fe/question_sheet_spec.rb

@@ -5,4 +5,110 @@ describe Fe::QuestionSheet do
   it { expect have_many :answer_sheets }
   it { expect validate_presence_of :label }
   it { expect validate_uniqueness_of :label }
+
+  context '#questions_count' do
+    it 'should count elements in a grid' do
+      s = create(:question_sheet)
+      p = create(:page, question_sheet: s)
+      e = create(:question_grid)
+      create(:page_element, page: p, element: e)
+      create(:text_field_element, question_grid: e)
+      create(:section, question_grid: e) # this shouldn't get counted
+      p.reload # get the updated all_element_ids column
+      expect(s.questions_count).to eq(1)
+    end
+  end
+
+  context '#all_elements' do
+    it 'should return elements in the same order as the ids' do
+      s = create(:question_sheet)
+
+      # P1
+      p1 = create(:page, question_sheet: s)
+      tf1 = create(:text_field_element)
+      create(:page_element, page: p1, element: tf1)
+      tf2 = create(:text_field_element)
+      create(:page_element, page: p1, element: tf2)
+      p1.update_column(:all_element_ids, "#{tf2.id},#{tf1.id}")
+
+      # P2
+      p2 = create(:page, question_sheet: s)
+      tf3 = create(:text_field_element)
+      create(:page_element, page: p2, element: tf3)
+      tf4 = create(:text_field_element)
+      create(:page_element, page: p2, element: tf4)
+      p2.update_column(:all_element_ids, "#{tf4.id},#{tf3.id}")
+
+      p1.reload # get the updated all_element_ids column
+      p2.reload # get the updated all_element_ids column
+      expect(s.all_elements).to eq([tf2, tf1, tf4, tf3])
+    end
+
+    it 'should include elements in a grid' do
+      s = create(:question_sheet)
+      p = create(:page, question_sheet: s)
+      e = create(:question_grid)
+      create(:page_element, page: p, element: e)
+      tf1 = create(:text_field_element, question_grid: e)
+      tf2 = create(:text_field_element) # add directly to page
+      create(:page_element, page: p, element: tf2)
+      section = create(:section, question_grid: e)
+      p.reload # get the updated all_element_ids column
+      expect(s.all_elements).to eq([e, tf1, section, tf2])
+    end
+    it 'should include elements across multiple pages' do
+      s = create(:question_sheet)
+
+      # P1
+      p1 = create(:page, question_sheet: s)
+
+      # grid pg1
+      g1 = create(:question_grid)
+      create(:page_element, page: p1, element: g1)
+      tf1 = create(:text_field_element, question_grid: g1)
+      s1 = create(:section, question_grid: g1)
+
+      # tf added directly to pg1
+      tf2 = create(:text_field_element)
+      create(:page_element, page: p1, element: tf2)
+
+      # P2
+      p2 = create(:page, question_sheet: s)
+
+      # grid pg2
+      g2 = create(:question_grid)
+      create(:page_element, page: p2, element: g2)
+      tf3 = create(:text_field_element, question_grid: g2)
+      s2 = create(:section, question_grid: g2)
+
+      # tf added directly to pg2
+      tf4 = create(:text_field_element)
+      create(:page_element, page: p2, element: tf4)
+
+      p1.reload # get the updated all_element_ids column
+      p2.reload # get the updated all_element_ids column
+      expect(s.all_elements).to eq([g1, tf1, s1, tf2, g2, tf3, s2, tf4])
+    end
+    it 'should handle pages with no elements' do
+      qs = create(:question_sheet)
+      p = create(:page)
+      qs.pages.reload
+      expect(qs.all_elements).to eq([])
+    end
+  end
+
+  context '#elements' do
+    it 'should not include elements in a grid' do
+      s = create(:question_sheet)
+      p = create(:page, question_sheet: s)
+      e = create(:question_grid)
+      create(:page_element, page: p, element: e)
+      tf1 = create(:text_field_element, question_grid: e) # shouldn't be included because it's in grid
+      tf2 = create(:text_field_element)
+      create(:page_element, page: p, element: tf2)
+      create(:section, question_grid: e) # shouldn't be included because it's in grid
+      p.reload # get the updated all_element_ids column
+      expect(s.elements).to eq([e, tf2])
+    end
+  end
 end