fe 0.0.4 → 1.0.0

data/app/models/fe/page.rb

@@ -6,25 +6,25 @@ module Fe
     belongs_to :question_sheet
 
     has_many :page_elements, -> { order(:position) },
-             :dependent => :destroy
+             dependent: :destroy
 
     has_many :elements, -> { order(Fe::PageElement.table_name + '.position') },
-             :through => :page_elements
+             through: :page_elements
 
     has_many :question_grid_with_totals, -> { where("kind = 'Fe::QuestionGridWithTotal'") },
-             :through => :page_elements,
-             :source => :element
+             through: :page_elements,
+             source: :element
 
-    has_many :questions, -> { where("kind NOT IN('Fe::Paragraph', 'Fe::Section', 'Fe::QuestionGrid', 'Fe::QuestionGridWithTotal')") },
-             :through => :page_elements,
-             :source => :element
+    has_many :questions, -> { questions.order(Fe::PageElement.table_name + '.position') },
+             through: :page_elements,
+             source: :element
 
     has_many :question_grids, -> { where("kind = 'Fe::QuestionGrid'") },
-             :through => :page_elements,
-             :source => :element
+             through: :page_elements,
+             source: :element
 
     # has_many :conditions, :class_name => "Condition", :foreign_key => "toggle_page_id",   # conditions associated with page as a whole
-    #         :conditions => 'toggle_id is NULL', :dependent => :nullify
+    #         conditions: 'toggle_id is NULL', :dependent => :nullify
 
     acts_as_list :column => :number, :scope => :question_sheet_id
 
@@ -41,6 +41,8 @@ module Fe
 
     validates_numericality_of :number, :only_integer => true
 
+    serialize :label_translations, Hash
+
     # a page is disabled if there is a condition, and that condition evaluates to false
     # could set multiple conditions to influence this question, in which case all must be met
     # def active?
@@ -52,8 +54,17 @@ module Fe
     #   false
     # end
 
+    def label(locale = nil)
+      label_translations[locale] || self[:label]
+    end
+
+    # returns true if there is a question element on the page, including one inside a grid
     def has_questions?
-      questions.present? || question_grids.present? || question_grid_with_totals.present?
+      all_questions.any?
+    end
+
+    def all_questions
+      all_elements.questions
     end
 
     def questions_before_position(position)
@@ -62,7 +73,22 @@ module Fe
 
     # Include nested elements
     def all_elements
-      (elements + elements.collect(&:all_elements)).flatten
+      ids = all_element_ids_arr
+      order = ids.collect{ |id| "id=#{id} DESC" }.join(', ')
+      ids.present? ? Element.where(id: ids).order(order) : Element.where("1 = 0")
+    end
+
+    def all_element_ids
+      rebuild_all_element_ids if self[:all_element_ids].nil?
+      self[:all_element_ids]
+    end
+
+    def all_element_ids_arr
+      @all_element_ids_arr ||= all_element_ids.split(',').collect(&:to_i)
+    end
+
+    def rebuild_all_element_ids
+      self.update_column :all_element_ids, elements.collect{ |e| [e] + e.all_elements }.flatten.collect(&:id).join(',')
     end
 
     def copy_to(question_sheet)
@@ -76,24 +102,30 @@ module Fe
           element.duplicate(new_page)
         end
       end
+      new_page.rebuild_all_element_ids
+    end
+
+    def hidden?(answer_sheet)
+      return false unless question_sheet.all_elements.where(conditional_type: 'Fe::Page', conditional_id: self).any?
+
+      # if any of the conditional questions matches, it's visible
+      !question_sheet.all_elements.where(conditional_type: 'Fe::Page', conditional_id: self).any?{ |e|
+        e.conditional_match(answer_sheet)
+      }
     end
 
     def complete?(answer_sheet)
-      return true if question_sheet.hidden_pages(answer_sheet).include?(self)
+      return true if hidden?(answer_sheet)
       prev_el = nil
-      all_elements.all? {|e| 
-        complete = !e.required? || (prev_el && prev_el.conditional == e && !prev_el.conditional_match(answer_sheet)) || e.has_response?(answer_sheet)
+      all_elements.all? {|e|
+        complete = !e.required?(answer_sheet, self, prev_el) || e.has_response?(answer_sheet)
         prev_el = e
         complete
       }
     end
 
     def started?(answer_sheet)
-      all_elements.any? {|e| e.has_response?(answer_sheet)}
-    end
-
-    def has_questions?
-      all_elements.any? {|e| e.is_a?(Question)}
+      all_questions.any? {|e| e.has_response?(answer_sheet)}
     end
 
     private

data/app/models/fe/page_element.rb

@@ -3,11 +3,12 @@ module Fe
   class PageElement < ActiveRecord::Base
     self.table_name = self.table_name.sub('fe_', Fe.table_name_prefix)
     acts_as_list :scope => :page_id
-    belongs_to :page
+    belongs_to :page, touch: true
     belongs_to :element
 
     after_save :save_element
     before_create :set_position
+    after_destroy :rebuild_page_all_element_ids
 
     def set_position
       self.position ||= (page.page_elements.last.try(:position) + 1) || page.elements.last.try(:position) || 0
@@ -17,5 +18,9 @@ module Fe
     def save_element
       element.save!
     end
+
+    def rebuild_page_all_element_ids
+      page.rebuild_all_element_ids
+    end
   end
 end

data/app/models/fe/page_link.rb

@@ -1,15 +1,18 @@
 # represents a link to a page for the page_list sidebar or next page links
 module Fe
   class PageLink
-    attr_accessor :dom_id, :label, :load_path, :page
+    attr_accessor :dom_id, :load_path, :page
     attr_accessor :save_path  # to save current page
 
-    def initialize(label, load_path, dom_id, page)
-      @label = label
+    def initialize(load_path, dom_id, page)
       @load_path = load_path
       @dom_id = dom_id
       @page = page
     end
 
+    def label(locale = nil)
+      page.label(locale)
+    end
+
   end
 end

data/app/models/fe/person.rb

@@ -1,14 +1,13 @@
 module Fe
   class Person < ActiveRecord::Base
     belongs_to :user, :foreign_key => "fk_ssmUserId" # TODO need to migrate person columns to be more rails-like
-    has_one    :current_address, -> { where("address_type = 'current'") }, :class_name => "Fe::Address"
-    has_many   :email_addresses, :foreign_key => "person_id", :class_name => '::EmailAddress', dependent: :destroy
-    has_many   :phone_numbers, :foreign_key => "person_id", :class_name => '::PhoneNumber', dependent: :destroy
-    has_one    :current_address, -> { where("address_type = 'current'") }, :foreign_key => "person_id", :class_name => '::Fe::Address'
-    has_one    :permanent_address, -> { where("address_type = 'permanent'") }, :foreign_key => "person_id", :class_name => '::Fe::Address'
-    has_one    :emergency_address1, -> { where("address_type = 'emergency1'") }, :foreign_key => "person_id", :class_name => 'Fe::Address'
-    has_many   :addresses, :foreign_key => "person_id", dependent: :destroy
-    has_one    :application, :foreign_key => "applicant_id"
+    has_many   :email_addresses, class_name: '::EmailAddress', dependent: :destroy
+    has_many   :phone_numbers, class_name: '::PhoneNumber', dependent: :destroy
+    has_one    :current_address, -> { where("address_type = 'current'") }, class_name: '::Fe::Address', dependent: :destroy
+    has_one    :permanent_address, -> { where("address_type = 'permanent'") }, class_name: '::Fe::Address', dependent: :destroy
+    has_one    :emergency_address1, -> { where("address_type = 'emergency1'") }, class_name: 'Fe::Address', dependent: :destroy
+    has_many   :addresses, dependent: :destroy
+    has_many   :applications, class_name: Fe.answer_sheet_class
 
     def emergency_address
       emergency_address1
@@ -28,6 +27,10 @@ module Fe
     def create_permanent_address
       Address.create(:person_id => self.id, :address_type => 'permanent')
     end
+
+    def name
+      [ first_name, last_name ].join(' ')
+    end
   end
 
 end

data/app/models/fe/question.rb

@@ -79,7 +79,7 @@ module Fe
     end
 
     def locked?(params, answer_sheet, presenter)
-      return true unless ['fe/answer_pages', 'fe/reference_sheets'].include?(params['controller']) && params['action'] == 'edit'
+      return true unless params['action'] == 'edit'
       if self.object_name == 'person.current_address' && ['address1','address2','city','zip','email','state','country'].include?(self.attribute_name)
         # Billing Address
         return false
@@ -169,7 +169,7 @@ module Fe
           value = values.first
           if self.is_a?(Fe::DateField) && value.present?
             begin
-              value = Date.strptime(value, (I18n.t 'date.formats.default'))
+              value = Date.strptime(value, '%Y-%m-%d')
             rescue
               raise "invalid date - " + value.inspect
             end
@@ -248,9 +248,5 @@ module Fe
       false
     end
 
-    def required?(answer_sheet = nil)
-      super
-    end
-
   end
 end

data/app/models/fe/question_grid.rb

@@ -7,7 +7,7 @@
 module Fe
   class QuestionGrid < Element
 
-    has_many :elements, -> { order('position') },
+    has_many :elements, -> { order('position asc, id asc') },
              :class_name => "Element",
              :foreign_key => "question_grid_id",
              :dependent => :nullify

data/app/models/fe/question_grid_with_total.rb

@@ -7,5 +7,20 @@
 
 module Fe
   class QuestionGridWithTotal < QuestionGrid
+    def totals(app)
+      totals = []
+      col = 0
+      row = []
+      elements.each do |el|
+        value = el.display_response(app) if el.respond_to?(:display_response) && el.display_response(app).present?
+
+        if value && value.present? # keep totals nil until there actually is a value, so that we can only display a total only if at least one row had a value
+          value = value.tr("^0-9.", '').to_f
+          totals[col] = (totals[col].present? ? totals[col] + value : value)
+        end
+        col = (col + 1) % num_cols
+      end
+      totals
+    end
   end
 end

data/app/models/fe/question_set.rb

@@ -65,7 +65,7 @@ module Fe
         if month.blank? or year.blank?
           values = ''
         else
-          values = [Date.new(year.to_i, month.to_i, 1).strftime('%m/%d/%Y')]  # for mm/yy drop downs
+          values = [Date.new(year.to_i, month.to_i, 1).strftime('%Y-%m-%d')]  # for mm/yy drop downs
         end
       elsif param.kind_of?(Hash)
         # from Hash with multiple answers per question

data/app/models/fe/question_sheet.rb

@@ -6,20 +6,19 @@ module Fe
     has_many :pages, -> { order('number') },
              :dependent => :destroy
 
-    # has_many :elements
-    # has_many :questions
-
     has_many :answer_sheet_question_sheets
 
     has_many :answer_sheets,
              :through => :answer_sheet_question_sheets
+    has_many :question_sheets,
+             :through => :answer_sheet_question_sheets
 
     scope :active, -> { where(:archived => false) }
     scope :archived, -> { where(:archived => true) }
 
     validates_presence_of :label
-    #  validates_length_of :label, :maximum => 60, :allow_nil => true
-    validates_uniqueness_of :label
+
+    serialize :languages, Array
 
     before_destroy :check_for_answers
 
@@ -30,14 +29,24 @@ module Fe
       question_sheet
     end
 
+    # count all questions including ones inside a grid
+    def questions_count
+      all_elements.questions.count
+    end
+
     def questions
-      pages.collect(&:questions).flatten
+      all_elements.questions
     end
 
     def elements
       pages.collect(&:elements).flatten
     end
 
+    def all_elements
+      element_ids = pages.pluck(:all_element_ids).compact.join(',').split(',')
+      element_ids.present? ? Element.where(id: element_ids).order(element_ids.collect{ |id| "id=#{id} DESC" }.join(', ')) : Element.where("1 = 0")
+    end
+
     # Pages get duplicated
     # Question elements get associated
     # non-question elements get cloned
@@ -51,13 +60,6 @@ module Fe
       new_sheet
     end
 
-    # pages hidden by a conditional element
-    def hidden_pages(answer_sheet)
-      elements.find_all{ |e| 
-        e.conditional.is_a?(Fe::Page) && !e.conditional_match(answer_sheet)
-      }.collect(&:conditional)
-    end
-
     private
 
     # next unused label with "Untitled form" prefix

data/app/models/fe/reference_question.rb

@@ -7,16 +7,6 @@ module Fe
       return unless app
       # A reference is the same if the related_question_sheet corresponding to the question is the same
       reference = Fe::ReferenceSheet.find_by_applicant_answer_sheet_id_and_question_id(app.id, id)
-      # if references.present?
-      #   reference = references.detect {|r| r.question_id == id }
-      #   # If they have another reference that matches this question id, don't go fishing for another one
-      #   unless reference
-      #     # If the question_id doesn't match, but the reference question is based on the same reference template (question sheet)
-      #     # update the reference with the new question_id
-      #     reference = references.detect {|r| r.question.related_question_sheet_id == related_question_sheet_id}
-      #     reference.update_attribute(:question_id, id) if reference
-      #   end
-      # end
       reference || Fe::ReferenceSheet.create(:applicant_answer_sheet_id => app.id, :question_id => id)
     end
 

data/app/models/fe/reference_sheet.rb

@@ -5,19 +5,21 @@ module Fe
     include Fe::AnswerSheetConcern
     include Rails.application.routes.url_helpers
     include AASM
+    include AccessKeyGenerator
+
     self.table_name = "#{Fe.table_name_prefix}references"
     self.inheritance_column = 'fake'
 
     belongs_to :question,
-               :class_name => 'Element',
+               :class_name => 'Fe::ReferenceQuestion',
                :foreign_key => 'question_id'
 
     belongs_to :applicant_answer_sheet,
-               :class_name => Fe.answer_sheet_class,
+               :class_name => "::#{Fe.answer_sheet_class}",
                :foreign_key => "applicant_answer_sheet_id"
 
     validates_presence_of :first_name, :last_name, :phone, :email, :relationship, :on => :update, :message => "can't be blank"
-    validates :email, :email_format => { :message => "doesn't look right." }
+    validates :email, :email_format => { :on => :update, :message => "doesn't look right." }
 
     delegate :style, :to => :question
 
@@ -74,10 +76,8 @@ module Fe
       end
     end
 
-    alias_method :applicant, :applicant_answer_sheet
-    def generate_access_key
-      self.access_key = Digest::MD5.hexdigest(email + Time.now.to_s)
-    end
+    alias_method :application, :applicant_answer_sheet
+    delegate :applicant, to: :application
 
     def frozen?
       !%w(started created).include?(self.status)
@@ -95,15 +95,15 @@ module Fe
                             Fe.from_email,
                             "Reference Invite",
                             {'reference_full_name' => self.name,
-                             'applicant_full_name' => application.name,
-                             'applicant_email' => application.email,
-                             'applicant_home_phone' => application.phone,
+                             'applicant_full_name' => application.applicant.name,
+                             'applicant_email' => application.applicant.email,
+                             'applicant_home_phone' => application.applicant.phone,
                              'reference_url' => edit_fe_reference_sheet_url(self, :a => self.access_key, :host => ActionMailer::Base.default_url_options[:host])}).deliver
       # Send notification to applicant
-      Notifier.notification(applicant_answer_sheet.email, # RECIPIENTS
+      Notifier.notification(applicant_answer_sheet.applicant.email, # RECIPIENTS
                             Fe.from_email, # FROM
                             "Reference Notification to Applicant", # LIQUID TEMPLATE NAME
-                            {'applicant_full_name' => applicant_answer_sheet.name,
+                            {'applicant_full_name' => applicant_answer_sheet.applicant.name,
                              'reference_full_name' => self.name,
                              'reference_email' => self.email,
                              'application_url' => edit_fe_answer_sheet_url(applicant_answer_sheet, :host => ActionMailer::Base.default_url_options[:host])}).deliver
@@ -144,6 +144,10 @@ module Fe
       [question_sheet]
     end
 
+    def question_sheet_ids
+      [question_sheet.try(:id)].compact
+    end
+
     def display_type
       question.label.split(/:| \(/).first
     end
@@ -151,7 +155,7 @@ module Fe
     protected
     # if the email address has changed, we have to trash the old reference answers
     def check_email_change
-      if changed.include?('email')
+      if !new_record? && changed.include?('email')
         answers.destroy_all
         # Every time the email address changes, generate a new access_key
         generate_access_key

data/app/models/staff.rb

@@ -5,6 +5,8 @@ class Staff < ActiveRecord::Base
   belongs_to :primary_address, :class_name => "StaffAddress", :foreign_key => :fk_primaryAddress
   belongs_to :secondary_address, :class_name => "StaffAddress", :foreign_key => :fk_secondaryAddress
   
+  alias_attribute :preferred_name, :preferredName
+
   def self.get_staff(ssm_id)
     if ssm_id.nil? then raise "nil ssm_id!" end
     ssm_user = User.find_by(userID: ssm_id)

data/app/validators/email_validator.rb

@@ -0,0 +1,11 @@
+require 'mail'
+
+class EmailValidator < ActiveModel::EachValidator
+  def validate_each(record, attribute, value)
+    begin
+      parsed = Mail::Address.new(value)
+    rescue Mail::Field::ParseError => e
+    end
+    record.errors.add attribute, "is not valid" unless !parsed.nil? && parsed.address == value && parsed.local != value #cannot be a local address
+  end
+end