excellent 1.7.2 → 2.0.0

data/spec/checks/rails/attr_protected_check_spec.rb

@@ -1,77 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Simplabs::Excellent::Checks::Rails::AttrProtectedCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::AttrProtectedCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should ignore classes that are not active record models' do
-      code = <<-END
-        class Test
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should reject an active record model that does specify attr_protected' do
-      code = <<-END
-        class User < ActiveRecord::Base
-          attr_protected :first_name
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'User specifies attr_protected.'
-    end
-
-    it 'should accept an active record model that does specify attr_accessible' do
-      code = <<-END
-        class User < ActiveRecord::Base
-          attr_accessible :first_name
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should accept an active record model that specifies neither attr_accessible not attr_protected' do
-      code = <<-END
-        class User < ActiveRecord::Base
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should also work with namespaced models' do
-      code = <<-END
-        class Backend::User < ActiveRecord::Base
-          attr_protected :first_name
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'Backend::User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'Backend::User specifies attr_protected.'
-    end
-
-  end
-
-end

data/spec/checks/rails/custom_initialize_method_check_spec.rb

@@ -1,58 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Simplabs::Excellent::Checks::Rails::CustomInitializeMethodCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::CustomInitializeMethodCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should ignore classes that are not active record models' do
-      code = <<-END
-        class Test
-          def initialize
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should reject an active record model that defines initialize' do
-      code = <<-END
-        class User < ActiveRecord::Base
-          def initialize
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'User defines initialize method.'
-    end
-
-    it 'should also work with namespaced models' do
-      code = <<-END
-        class Backend::User < ActiveRecord::Base
-          def initialize
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'Backend::User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'Backend::User defines initialize method.'
-    end
-
-  end
-
-end

data/spec/checks/rails/instance_var_in_partial_check_spec.rb

@@ -1,40 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Simplabs::Excellent::Checks::Rails::InstanceVarInPartialCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::InstanceVarInPartialCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept partials that do not use instance variables' do
-      code = <<-END
-        <div>
-          <%= 'some text' %>
-        </div>
-      END
-      @excellent.check('_dummy-file.html.erb', code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should reject partials that use instance variables' do
-      code = <<-END
-        <div>
-          <%= @ivar %>
-        </div>
-      END
-      @excellent.check('_dummy-file.html.erb', code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :variable => 'ivar' }
-      warnings[0].line_number.should == 2
-      warnings[0].message.should     == 'Instance variable ivar used in partial.'
-    end
-
-  end
-
-end

data/spec/checks/rails/params_hash_in_view_check_spec.rb

@@ -1,40 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Simplabs::Excellent::Checks::Rails::ParamsHashInViewCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::ParamsHashInViewCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept views that do not use the params hash' do
-      code = <<-END
-        <div>
-          <%= 'some text' %>
-        </div>
-      END
-      @excellent.check('dummy-file.html.erb', code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should reject views that use the params hash' do
-      code = <<-END
-        <div>
-          <%= params[:q] %>
-        </div>
-      END
-      @excellent.check('dummy-file.html.erb', code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == {}
-      warnings[0].line_number.should == 2
-      warnings[0].message.should     == 'Params hash used in view.'
-    end
-
-  end
-
-end

data/spec/checks/rails/session_hash_in_view_check_spec.rb

@@ -1,40 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Simplabs::Excellent::Checks::Rails::SessionHashInViewCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::SessionHashInViewCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should accept views that do not use the session hash' do
-      code = <<-END
-        <div>
-          <%= 'some text' %>
-        </div>
-      END
-      @excellent.check('dummy-file.html.erb', code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should reject views that use the session hash' do
-      code = <<-END
-        <div>
-          <%= session[:someCount] %>
-        </div>
-      END
-      @excellent.check('dummy-file.html.erb', code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == {}
-      warnings[0].line_number.should == 2
-      warnings[0].message.should     == 'Session hash used in view.'
-    end
-
-  end
-
-end

data/spec/checks/rails/validations_check_spec.rb

@@ -1,81 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Simplabs::Excellent::Checks::Rails::ValidationsCheck do
-
-  before do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::ValidationsCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should ignore classes that are not active record models' do
-      code = <<-END
-        class Test
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    it 'should reject an active record model that does not validate anything' do
-      code = <<-END
-        class User < ActiveRecord::Base
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'User does not validate any attributes.'
-    end
-
-    it 'should accept an active record model that validates attributes using a macro method' do
-      code = <<-END
-        class User < ActiveRecord::Base
-          validates_presence_of :login
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should be_empty
-    end
-
-    %w(validate validate_on_create validate_on_update).each do |method|
-
-      it "should accept an active record model that validates attribute by overriding #{method}" do
-        code = <<-END
-          class User < ActiveRecord::Base
-            def #{method}
-            end
-          end
-        END
-        @excellent.check_code(code)
-        warnings = @excellent.warnings
-
-        warnings.should be_empty
-      end
-
-    end
-
-    it 'should also work with namespaced models' do
-      code = <<-END
-        class Backend::User < ActiveRecord::Base
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :class => 'Backend::User' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'Backend::User does not validate any attributes.'
-    end
-
-  end
-
-end

data/spec/checks/singleton_variable_check_spec.rb

@@ -1,66 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe Simplabs::Excellent::Checks::SingletonVariableCheck do
-
-  before(:each) do
-    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::SingletonVariableCheck.new)
-  end
-
-  describe '#evaluate' do
-
-    it 'should reject singleton variables' do
-      code = <<-END
-        @@foo
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :variable => 'foo' }
-      warnings[0].line_number.should == 1
-      warnings[0].message.should     == 'Singleton variable foo used.'
-    end
-
-    it 'should also work for namespaced classes' do
-      code = <<-END
-        module Outer
-          module Inner
-            class Class
-              @@foo
-            end
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :variable => 'Outer::Inner::Class.foo' }
-      warnings[0].line_number.should == 4
-      warnings[0].message.should     == 'Singleton variable Outer::Inner::Class.foo used.'
-    end
-
-    it 'should also work for singleton variables that occur within methods' do
-      code = <<-END
-        module Outer
-          module Inner
-            class Class
-              def method
-                @@foo
-              end
-            end
-          end
-        end
-      END
-      @excellent.check_code(code)
-      warnings = @excellent.warnings
-
-      warnings.should_not be_empty
-      warnings[0].info.should        == { :variable => 'Outer::Inner::Class.foo' }
-      warnings[0].line_number.should == 5
-      warnings[0].message.should     == 'Singleton variable Outer::Inner::Class.foo used.'
-    end
-
-  end
-
-end

data/spec/extensions/string_spec.rb

@@ -1,13 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe String do
-
-  describe '#underscore' do
-
-    it 'should correctly add underscores to "AbcMetricMethodCheck"' do
-      'AbcMetricMethodCheck'.underscore.should == 'abc_metric_method_check'
-    end
-
-  end
-
-end

data/spec/spec_helper.rb

@@ -1,13 +0,0 @@
-$LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__) + "/../lib"))
-
-require 'rubygems'
-require 'spec'
-require 'simplabs/excellent'
-
-begin
-  require 'ruby-debug'
-  Debugger.start
-  Debugger.settings[:autoeval] = true if Debugger.respond_to?(:settings)
-rescue LoadError
-  # ruby-debug wasn't available so neither can the debugging be
-end